[DISCUSS] Release Apache NetBeans 12.2 u2 VSCode Extension

2021-02-13 Thread Matthias Bläsing
[Moving to discussion, please don't vote in this thread/with this
subject!]


Hi Jaroslav,

before casting a vote, I'd like to clarify what has happend until this
point. Am I right, that

a) creating the distribution is already done
b) the final tag was already created
c) publishing to marketplace has already happend?

If so, I think the correct procedure was not followed, as the procedure
can't be to first publish and the ask the PMC+Committers to rubberstamp
a release.

Greetings

Matthias



Am Sonntag, den 14.02.2021, 06:52 +0100 schrieb Jaroslav Tulach:
> Dear community,
> please accept my apology for this emergency vote. The work on release 12.3
> revealed a problem with autoupdate catalogs (see
> https://github.com/apache/netbeans/pull/2757) which prevents existing
> Apache NetBeans VSCode Extension to launch properly. That renders it
> useless for all its early adopters and may negatively impact their
> experience when using our technology. As such I have backported the
> necessary changes, tagged them and I am calling for a vote for 12.2 u2
> emergency update:
> 
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.asc
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.sha512
> 
> The sources are associated with a convenience binary containing the VSCode
> extension file
> for Apache NetBeans Language Server 12.2.2 extension:
> 
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.asc
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.sha512
> 
> The source ZIP as well as the `.vsix` file come from tag 12.2.2 in our
> repository: https://github.com/apache/netbeans/tree/12.2.2 - e.g. from
> commit 1fb82a99c5e633. The source ZIP has been produced by running `ant
> build-source-config`. The `.vsix` file has been produced by
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/290/ job run.
> Both artifacts were signed by my 2021 GPG key.
> 
> To build the Apache NetBeans Language Server extension please follow the
> instruction in [java/java.lsp.server/vscode/BUILD.md](https://github.com/
> apache/netbeans/blob/c8e0cec5edcbfbd61f22e07eb92fcdbad17f345b/java/
> java.lsp.server/vscode/BUILD.md), e.g.:
> 
> ```bash
> netbeans$ ant build
> netbeans$ cd java/java.lsp.server
> java.lsp.server$ ant build-vscode-ext
> ```
> 
> To test the resulting convenience `.vsix` file, please follow the [wiki
> page](https://cwiki.apache.org/confluence/display/NETBEANS/
> Apache+NetBeans+extension+for+Visual+Studio+Code) instructions that
> describe
> the typical scenarios the extension is supposed to support.
> 
> 
> Let's the testing and voting start!
> -jt



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [DISCUSS] Compile with JDK-11 javac --release flag

2021-02-13 Thread Jaroslav Tulach
Laszlo Kishalmi wrote:
> Well we should let the past go and occasionally set the javac.target to
> 1.8 wherever it is still lower than that.

Jan Lahoda wrote:
> The platform/openide.util.lookup module uses javac.source=1.8, so at least
> every module that depends on it, either directly or indirectly, effectively
> only runs on JDK 8, and hence we can upgrade javac.target to 1.8.

OK, let's upgrade the javac.target to 1.8 across the code base:
https://github.com/apache/netbeans/pull/2761

-jt




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Request for help: Failing unittests for nb-javac

2021-02-13 Thread Jaroslav Tulach
> I'd prefer the tests to be fixed, but if noone steps up, I'm inclinded
> to deactive them, as they are basicly ignored anyway and thus useless
> noice.

+1 to deactivate. Having a gate test that is failing with such a rate hurts 
the purpose of having tests in the gate at all.

> This needs attention from people with knowledge in the affected
> modules. It would be great if you could have a look.

There was some attempt to fix/disable the failing tests about six months ago. 
However it looks like the problem wasn't in particular tests, but rather in 
randomly failing test infrastructure.

I guess these tests can move to some http://builds.apache.org jobs and be 
stabilized there. If they get fixed, they may return back to the gate.
-jt




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [External] : Re: VSCode NetBeans 12.2.1 hotfix

2021-02-13 Thread Jaroslav Tulach
Hi.
Proper Apache voting process has just been initiated:
https://lists.apache.org/thread.html/r6f3058d31372047becaa44ea2d3246ab7cb7779767aa151be7cef4b2%40%3Cdev.netbeans.apache.org%3E
-jt

pá 12. 2. 2021 v 18:43 odesílatel Martin Balin 
napsal:

> Hi,
> thank you Neil.
>
> I moved ahead and published 12.2.2 VSNetBeans on VSCode Marketplace. The
> reason for this quick fix and update was that NB extension was
> completely broken and this does not affect NB releases/binaries at all.
>
> Me and Jarda will follow up with proper release process for this quick
> patch. Sources, binaries, voting and more testing as soon as possible.
>
> In the meantime extension build is here
>
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/290/artifact/java/java.lsp.server/build/apache-netbeans-java-12.2.2.vsix
> The PR for completeness https://github.com/apache/netbeans/pull/2757
>
> The reason why there was registered daily builds update center is the
> most likely some over look from development around 12.2 and also this
> issue was not spotted during extension testing for a long time as there
> were no modules for updating.
>
> Sorry for any inconvenience,
> Martin
>
> On 12. 02. 21 14:57, Neil C Smith wrote:
> > On Fri, 12 Feb 2021 at 13:45, Martin Balin 
> wrote:
> >> org.netbeans.modules.java.lsp.server 1.6.1.1.1.12.1.17.32.5.2.1.1.1.13
> >> Upgrade to 1.7.0.1.1.12.1.17.32.5.2.1.1.1.13
> >>
> >> It is coming as a left over of URL_Distribution=
> https://urldefense.com/v3/__https://netbeans.apache.org/nb/updates/dev/updates.xml.gz__;!!GqivPVa7Brio!Mn_zHW4OS0adciD6yVMRhSw0jIPDN4qvVNTj8s7bMM9LGZVfWuVkcIbj936c9Tfzcw$
> inside VSNB.
> > Er, what?!  Why is the daily builds update centre being picked up by a
> > released plugin anyway? That should never happen, and if so sounds
> > like the build process needs checking before 12.3 is released.  There
> > also seems to be no entry for NB 12.2u1 in
> >
> https://urldefense.com/v3/__https://github.com/apache/netbeans-jenkins-lib/blob/master/meta/netbeansrelease.json*L307__;Iw!!GqivPVa7Brio!Mn_zHW4OS0adciD6yVMRhSw0jIPDN4qvVNTj8s7bMM9LGZVfWuVkcIbj934osECGgw$
> > which is probably why it fell back to dev.
> >
> > Best wishes,
> >
> > Neil
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> > For additional commands, e-mail: dev-h...@netbeans.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> https://urldefense.com/v3/__https://cwiki.apache.org/confluence/display/NETBEANS/Mailing*lists__;Kw!!GqivPVa7Brio!Mn_zHW4OS0adciD6yVMRhSw0jIPDN4qvVNTj8s7bMM9LGZVfWuVkcIbj935vc3uT6g$
> >
> >
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


[VOTE] Release Apache NetBeans 12.2 u2 VSCode Extension

2021-02-13 Thread Jaroslav Tulach
Dear community,
please accept my apology for this emergency vote. The work on release 12.3
revealed a problem with autoupdate catalogs (see
https://github.com/apache/netbeans/pull/2757) which prevents existing
Apache NetBeans VSCode Extension to launch properly. That renders it
useless for all its early adopters and may negatively impact their
experience when using our technology. As such I have backported the
necessary changes, tagged them and I am calling for a vote for 12.2 u2
emergency update:

https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.asc
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/netbeans-12.2.2-source.zip.sha512

The sources are associated with a convenience binary containing the VSCode
extension file
for Apache NetBeans Language Server 12.2.2 extension:

https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.asc
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/netbeans-vscode-ext-12.2.2/apache-netbeans-java-12.2.2.vsix.sha512

The source ZIP as well as the `.vsix` file come from tag 12.2.2 in our
repository: https://github.com/apache/netbeans/tree/12.2.2 - e.g. from
commit 1fb82a99c5e633. The source ZIP has been produced by running `ant
build-source-config`. The `.vsix` file has been produced by
https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/290/ job run.
Both artifacts were signed by my 2021 GPG key.

To build the Apache NetBeans Language Server extension please follow the
instruction in [java/java.lsp.server/vscode/BUILD.md](https://github.com/
apache/netbeans/blob/c8e0cec5edcbfbd61f22e07eb92fcdbad17f345b/java/
java.lsp.server/vscode/BUILD.md), e.g.:

```bash
netbeans$ ant build
netbeans$ cd java/java.lsp.server
java.lsp.server$ ant build-vscode-ext
```

To test the resulting convenience `.vsix` file, please follow the [wiki
page](https://cwiki.apache.org/confluence/display/NETBEANS/
Apache+NetBeans+extension+for+Visual+Studio+Code) instructions that
describe
the typical scenarios the extension is supposed to support.


Let's the testing and voting start!
-jt


Getting path of selected project or workspace

2021-02-13 Thread Rahul Khandelwal
Hi all,

How can I get the path of selected project (which has its file currently
open and focused).
I also want to capture workspace path.

I would like to access above two details in an action.

Regards,
Rahul khandelwal


SQL Autocomplete

2021-02-13 Thread Eric Bresie
As a first bug fix, I thought I’d  try working some on the SQL
Autocompletion related issue like

NETBEANS-188 Please add support for code completion while typing

When I try with an empty sql file and start typing "s", with the
Ctrl+Space, it ends up with the "No database connection is selected.
Please select a connection in the Connection combo box in the editor
toolbar."

I assume is related to
NETBEANS-189 SQL editor, shouldn't ask evertime to set the connection

So assume these two may be related.

What is the best approach to start on this?  In the SQL Editor project, I
find a number test cases like the one for select but I’m a little unclear
of the flow for how key input ends up in the autocomplete logic and how to
determines the tokens for use in that and where the check for the
connection happens.

Eric Bresie
ebre...@gmail.com
-- 
Eric Bresie
ebre...@gmail.com


Re: Heads-Up: Merging delivery into master results in uncompilable state

2021-02-13 Thread Neil C Smith
On Sat, 13 Feb 2021, 22:17 Matthias Bläsing, 
wrote:

> 0f36a3f205e6f9e7d1df5b09b9427fdc9bf3b67c Showing completions returned by
> annotation Processors in VS Code.
> 24349e411664467c576dc1fc774ac197c2b0b41e LSP CodeActions enhancements.
> (#2714)
>
> Dusan, Jan you too are the authors, so please pay special attention.
> Neil, Geertjan, you will probably see this first, please be aware of this.
>

Thanks. Yes, visible here https://github.com/apache/netbeans/pull/2749

Something we'll have to review after beta 3 when we're ready to merge.

Best wishes,

Neil

>


Re: Re: Compiling Netbeans from source

2021-02-13 Thread Eric Bresie
See https://openjdk.java.net/jeps/372. It is removed (if I’m not mistaken) in 
Java 15. Expectations are for it to be replaced by GraalVM JavaScript engine.

Eric Bresie
ebre...@gmail.com (mailto:ebre...@gmail.com)

> On February 12, 2021 at 1:01:37 PM CST, Matthias Bläsing 
> mailto:mblaes...@doppel-helix.eu)> wrote:
> Hi,
>
> Am Freitag, den 12.02.2021, 14:03 +0100 schrieb Jeremy Cavanagh
> >
> > Another simple question. Why are there 60 warnings:
> >
> > Warning: Nashorn engine is planned to be removed from a future JDK release
> >
> > in the build log when we know that it has already been removed?
>
> this comes from the java binary, which is invoked multiple times in the
> build process.
>
> Greetings
>
> Matthias
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org 
> (mailto:dev-unsubscr...@netbeans.apache.org)
> For additional commands, e-mail: dev-h...@netbeans.apache.org 
> (mailto:dev-h...@netbeans.apache.org)
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>


Heads-Up: Merging delivery into master results in uncompilable state

2021-02-13 Thread Matthias Bläsing
Hi,

I just noticed the following: delivery and master drifted apart and
merging delivery into master creates a state, that is not compileable
anymore.

I guess we see merge issue, because the same areas were touched in
master and delivery. This needs special attention when delivery is
merged into master next. My gut feeling is, that the two commits:

0f36a3f205e6f9e7d1df5b09b9427fdc9bf3b67c Showing completions returned by 
annotation Processors in VS Code.
24349e411664467c576dc1fc774ac197c2b0b41e LSP CodeActions enhancements. (#2714)

Dusan, Jan you too are the authors, so please pay special attention.
Neil, Geertjan, you will probably see this first, please be aware of this.

Thank you

Matthias




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Request for help: Failing unittests for nb-javac

2021-02-13 Thread Matthias Bläsing
Hi all,

I'd like to raise attention for the java module unittests:

Test Java modules with nb-javac on Java 8 
https://travis-ci.com/github/apache/netbeans/jobs/482820779
Test Java modules with nb-javac on Java 11 
https://travis-ci.com/github/apache/netbeans/jobs/482820782
Test Java modules with nb-javac on Java 13 
https://travis-ci.com/github/apache/netbeans/jobs/482820783

They a major PITA in general and specially for PRs affecting nbjavac.
For normal PRs the unittests are regularly restarted and in the end
ignored, for the nbjavac it is a problem.

Consider this PR: https://github.com/apache/netbeans/pull/2759 can it
be merged or not?

I'd prefer the tests to be fixed, but if noone steps up, I'm inclinded
to deactive them, as they are basicly ignored anyway and thus useless
noice.


This needs attention from people with knowledge in the affected
modules. It would be great if you could have a look.

Thank you

Matthias


-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [VOTE] Apache NetBeans 12.0-u2

2021-02-13 Thread John Kostaras
+1 (binding)

Checked all what has been asked.
Built with Oracle JDK 1.8.0_221.
Ran with JDK 15.0.1.
Tested with Java ant/maven and NetBeans Platform projects. No apparent
issues.


On Thu, 11 Feb 2021 at 23:05, Matthias Bläsing 
wrote:

> +1 (binding)
>
> - checked SHA512 and signature
> - checked that contents of zip and git tag 12.0-u2 are identical apart
>   from the expected differences
> - checked NOTICE + LICENSE
> - builds on OpenJDK 1.8.0_262
> - tested opening and running maven project on JDK, nbjavac was
>   installed after opening started, works
>
> Positivly surprised about FlatLaf, looks good, will see if I change my
> main runtime from Metal.
>
> Am Dienstag, den 09.02.2021, 21:29 -0800 schrieb Laszlo Kishalmi:
> > Dear all,
> >
> > This is the voting candidate for the 12.0 update 2 release of Apache
> > NetBeans. This release is identical to 12.0-u1 except for the following
> > backported fixes for -
> >
> > [NETBEANS-5336] Replace jcenter() to mavenCentral() in Gradle Projects
> > [NETBEANS-3342] Fix Netbeans Installer on macOS to work with Java 8 and
> 11+
> > [NETBEANS-4617] Flush Gradle Standard output in 200ms if it stalled
> > [NETBEANS-4123] PAC evaluator scripts runs just one at a time.
> > Include both KDE4 and KDE5 proxy settings.
> > [NETBEANS-] The selected text is not removed in the Find Combobox
> > [NETBEANS-3409] Missing popup menu for sql editor tabs
> > [NETBEANS-4722] Add JAVA_HOME to Gradle build environment variables
> > [NETBEANS-4627] FlatLaf: fix wrong background color of search result
> > [NETBEANS-3428] FlatLaf: fix selection background color in output view
> >
> > The build artifacts are available at:
> >
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.0-u2/  <
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.0-u1/>
> >
> > We are voting on
> >
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.0-u2/netbeans-12.0-u2-source.zip
> <
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.0-u1/netbeans-12.0-u1-source.zip
> >
> >
> > SHA512:
> >
> >
> 72783736d5163c07d5b2ee1bb51816294263eef863efad6b6ddb83342c45f267d96682825c072c68dc42571b6e20d56b45729c8e447708fcc04948926bf5c775
> >
> > There is no full binary distribution for this update release all
> > convenience binaries are available as nbm packages. The folder:
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.0-u2/nbms/
> 
> >
> > The weak point of an update release is the handcrafted updates.xml which
> is hard to be tested without the binaries reaching their final location.
> > The following modules were updated in this release:
> >
> > ./ide/org-netbeans-modules-editor-search.nbm
> > ./groovy/org-netbeans-modules-gradle.nbm
> > ./platform/org-openide-filesystems-compat8.nbm
> > ./platform/org-netbeans-swing-laf-flatlaf.nbm
> > ./platform/org-netbeans-core-network.nbm
> >
> > Please check if their distribution url points right and their
> description matches:
> >
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbeans/job/release120/28/artifact/dist/netbeans/nbms/updates.xml
> >
> > The updates themselves can be installed and tested by adding the
> following UC to your NetBeans 12.0 installation:
> >
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbeans/job/release120/28/artifact/dist/netbeans/nbms/updates.xml.gz
> >
> > Before voting! See requirements below!
> >
> > KEYS file:
> > https://dist.apache.org/repos/dist/release/netbeans/KEYS
> >
> >
> > Before voting +1 you are required to download the signed source code
> > package, compile it as provided, and test the resulting executable on
> > your own platform, along with also verifying that the package meets
> > the requirements of the ASF policy on releases - see
> > http://www.apache.org/legal/release-policy.html#management
> >
> > In particular, you should (at least) follow these steps.
> >
> > 1. Download the artifact to be voted on and unzip it.
> > 2. Check that the ariefact does not contain any jar files, except for:
> > -
> >
> platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/empty.jar
> > - enterprise/glassfish.common/test/unit/data/nottaDir-4_1_2.jar
> > - enterprise/glassfish.common/test/unit/data/subdir/nottaDir-5.0.jar
> > - enterprise/payara.common/test/unit/data/nottaDir-4_1_2.jar
> > - enterprise/payara.common/test/unit/data/subdir/nottaDir-5.0.jar
> > which are only jars by their name
> > 3. Verify the cryptographic signatures, the NOTICE and LICENSE file
> > 4. Build it using the README provided by the artefact.
> > 5. Look in nbbuild/netbeans for the NetBeans installation created by
> > the build process and try running it.
> >
> >
> > In addition to checking the sources, you should check the associated
> > convenience binary NBMs at the artifact links above. As well as
> > checking any artifact functions correctly, you should check that it
>

Re: Fwd: compile NetBeans with JDK11 [Replacement Dependencies]

2021-02-13 Thread Matthias Bläsing
Hi Eric,

the question "what is the general rule" IMHO makes no sense. The right
answer is (again) IMHO to do the minimal invasive change. Consider
JAXB: JAXB was donated to the eclipse foundation, we can switch over to
that artifact (compatible license), JavaFX is released under GPLv2-CPE
with LGPL artifacts, we can only provide helpers for users to install,
other things: Depends.

For incompatible changes (removed APIs): You can hide them behind
reflective calls and conditional modules (see
ide/extexecution.process.jdk9)

My personal suggestion: Don't try big plans and don't ask general
questions, solution and anwsers are much easier if they get concrete.

Greetings

Matthias

Am Samstag, den 13.02.2021, 11:52 -0600 schrieb Eric Bresie:
> As I understand things many APIs started getting depreciated with the 
> eventual plan of removal in future release (I believe 11 had a lot deprecated 
> and 15 may have started removing a lot of them)
> 
> With that in mind for cases when there is a removed API from the JDK, what is 
> the general rule for handling these types of removals?
> 
> Assume
> (1) If there is a removed API with a new replacement API this would involve 
> updating codebase to use new interface in the newer JDK
> 
> (2) If there is not an alternative api in the JDK the requires and external 
> dependency to be added (i.e. JavaFX or JAXB) then adding some new external 
> dependency would be needed. Assume that means adding the dependency to the 
> build to pull it in some way and possible change and imports and/or API calls 
> to replace with new APIs.
> 
> Eric Bresie
> ebre...@gmail.com (mailto:ebre...@gmail.com)
> > On February 10, 2021 at 11:03:08 AM CST, Jeremy Cavanagh 
> > mailto:jeremy.cavan...@orange.fr)> wrote:
> > 
> > 
> > 
> >  Forwarded Message 
> > Subject: Re: compile NetBeans with JDK11
> > Date: Wed, 10 Feb 2021 12:57:05 +0100
> > From: Jeremy Cavanagh  > (mailto:jeremy.cavan...@orange.fr)>
> > To: Brad Walker mailto:bwal...@musings.com)>
> > 
> > Hi,
> > 
> > I have the same question. I have had absolutely no luck whatsoever. I've
> > tried all possible variants with both jdk 8 and jdk 11, but, they all
> > end in failure with the same error:
> > 
> > Java 15 has removed Nashorn, you must provide an engine for running
> > JavaScript yourself. GraalVM JavaScript currently is the preferred option.
> > 
> > BUILD FAILED
> > /Users/jeremycavanagh/Downloads/netbeans-12.3-beta2-source/nbbuild/build.xml:509:
> > The following error occurred while executing this line:
> > /Users/jeremycavanagh/Downloads/netbeans-12.3-beta2-source/nbbuild/build/langtools/make/build.xml:91:
> > Unable to create javax script engine for javascript
> > 
> > All requirements as far as I can tell are satisfied:
> > 
> > $ java -version
> > openjdk version "11.0.9.1" 2020-11-04 LTS
> > OpenJDK Runtime Environment Zulu11.43+55-CA (build 11.0.9.1+1-LTS)
> > OpenJDK 64-Bit Server VM Zulu11.43+55-CA (build 11.0.9.1+1-LTS, mixed mode)
> > $ js -version
> > GraalVM JavaScript (GraalVM CE Native 21.0.0)
> > $ ant -version
> > Apache Ant(TM) version 1.10.9 compiled on September 27 2020
> > 
> > I have used, the following build commands:
> > 
> > $ant
> > $ant build
> > $ant build -Dpermit.jdk9.builds=true
> > 
> > I normally don't try building from source having succeeded once in the
> > last few years, but, want to do so to aid my understanding of NetBeans.
> > 
> > Any ideas, suggestions or corrections to my attempts would be very much
> > appreciated.
> > 
> > Regards to all,
> > 
> > Jeremy
> > 
> > P.S., Stay Home, Stay Safe & Stay Healthy
> > 
> > On 09/02/2021 22:02 (x-apple-data-detectors://14), Brad Walker wrote:
> > > Hey Jaroslav,
> > > 
> > > I have a question related to this.
> > > 
> > > What would be the proper, accepted way to build Netbeans using JDK11?
> > > 
> > > -brad w.
> > > 
> > > ps: I changed the subject line since the question is not directly 
> > > related..
> > > 
> > > On Tue, Feb 9, 2021 at 12:19 PM Jaroslav Tulach 
> > > mailto:jaroslav.tul...@gmail.com)>
> > > wrote:
> > > 
> > > > Hi.
> > > > I knew the time for a discussion like this is going to come when I wrote
> > > > my
> > > > "Compile with JDK-11 javac --release flag" in November. I have just been
> > > > trying
> > > > to find the email in archives, but no luck! I had to resend it. Here is 
> > > > it
> > > > for
> > > > your reference:
> > > > 
> > > > https://lists.apache.org/thread.html/
> > > > r94d421ce16f609687c769125425b46f2322033879120b00afddbe17b%40%
> > > > 3Cdev.netbeans.apache.org (http://3Cdev.netbeans.apache.org)%3E
> > > > 
> > > > I guess I have to agree with Eric, we cannot stick with JDK8 forever. We
> > > > have
> > > > to move on. On the other hand, as you know, I am not fan of [Big Bang
> > > > changes]
> > > > (http://wiki.apidesign.org/wiki/Big_Bang), as such I'd like to propose 
> > > > to
> > > > move
> > > > forward step by step:
> > > > 
> > > > Let's require JDK11 to build NetBeans 

Re: Fwd: compile NetBeans with JDK11 [Replacement Dependencies]

2021-02-13 Thread Eric Bresie
As I understand things many APIs started getting depreciated with the eventual 
plan of removal in future release (I believe 11 had a lot deprecated and 15 may 
have started removing a lot of them)

With that in mind for cases when there is a removed API from the JDK, what is 
the general rule for handling these types of removals?

Assume
(1) If there is a removed API with a new replacement API this would involve 
updating codebase to use new interface in the newer JDK

(2) If there is not an alternative api in the JDK the requires and external 
dependency to be added (i.e. JavaFX or JAXB) then adding some new external 
dependency would be needed. Assume that means adding the dependency to the 
build to pull it in some way and possible change and imports and/or API calls 
to replace with new APIs.

Eric Bresie
ebre...@gmail.com (mailto:ebre...@gmail.com)
> On February 10, 2021 at 11:03:08 AM CST, Jeremy Cavanagh 
> mailto:jeremy.cavan...@orange.fr)> wrote:
>
>
>
>  Forwarded Message 
> Subject: Re: compile NetBeans with JDK11
> Date: Wed, 10 Feb 2021 12:57:05 +0100
> From: Jeremy Cavanagh  (mailto:jeremy.cavan...@orange.fr)>
> To: Brad Walker mailto:bwal...@musings.com)>
>
> Hi,
>
> I have the same question. I have had absolutely no luck whatsoever. I've
> tried all possible variants with both jdk 8 and jdk 11, but, they all
> end in failure with the same error:
>
> Java 15 has removed Nashorn, you must provide an engine for running
> JavaScript yourself. GraalVM JavaScript currently is the preferred option.
>
> BUILD FAILED
> /Users/jeremycavanagh/Downloads/netbeans-12.3-beta2-source/nbbuild/build.xml:509:
> The following error occurred while executing this line:
> /Users/jeremycavanagh/Downloads/netbeans-12.3-beta2-source/nbbuild/build/langtools/make/build.xml:91:
> Unable to create javax script engine for javascript
>
> All requirements as far as I can tell are satisfied:
>
> $ java -version
> openjdk version "11.0.9.1" 2020-11-04 LTS
> OpenJDK Runtime Environment Zulu11.43+55-CA (build 11.0.9.1+1-LTS)
> OpenJDK 64-Bit Server VM Zulu11.43+55-CA (build 11.0.9.1+1-LTS, mixed mode)
> $ js -version
> GraalVM JavaScript (GraalVM CE Native 21.0.0)
> $ ant -version
> Apache Ant(TM) version 1.10.9 compiled on September 27 2020
>
> I have used, the following build commands:
>
> $ant
> $ant build
> $ant build -Dpermit.jdk9.builds=true
>
> I normally don't try building from source having succeeded once in the
> last few years, but, want to do so to aid my understanding of NetBeans.
>
> Any ideas, suggestions or corrections to my attempts would be very much
> appreciated.
>
> Regards to all,
>
> Jeremy
>
> P.S., Stay Home, Stay Safe & Stay Healthy
>
> On 09/02/2021 22:02 (x-apple-data-detectors://14), Brad Walker wrote:
> > Hey Jaroslav,
> >
> > I have a question related to this.
> >
> > What would be the proper, accepted way to build Netbeans using JDK11?
> >
> > -brad w.
> >
> > ps: I changed the subject line since the question is not directly related..
> >
> > On Tue, Feb 9, 2021 at 12:19 PM Jaroslav Tulach  > (mailto:jaroslav.tul...@gmail.com)>
> > wrote:
> >
> > > Hi.
> > > I knew the time for a discussion like this is going to come when I wrote
> > > my
> > > "Compile with JDK-11 javac --release flag" in November. I have just been
> > > trying
> > > to find the email in archives, but no luck! I had to resend it. Here is it
> > > for
> > > your reference:
> > >
> > > https://lists.apache.org/thread.html/
> > > r94d421ce16f609687c769125425b46f2322033879120b00afddbe17b%40%
> > > 3Cdev.netbeans.apache.org (http://3Cdev.netbeans.apache.org)%3E
> > >
> > > I guess I have to agree with Eric, we cannot stick with JDK8 forever. We
> > > have
> > > to move on. On the other hand, as you know, I am not fan of [Big Bang
> > > changes]
> > > (http://wiki.apidesign.org/wiki/Big_Bang), as such I'd like to propose to
> > > move
> > > forward step by step:
> > >
> > > Let's require JDK11 to build NetBeans sources.
> > >
> > > The switch to JDK11 compiler doesn't mean I suggest to drop running on
> > > JDK8.
> > > Me, my employer/gang, OracleLabs, still need to run VSNetBeans on JDK8.
> > > However we can have it and still move our source code base forward where
> > > needed.
> > >
> > > Matthias wrote:
> > > > I think Jaroslav, said, that in the old time, NetBeans was
> > > > able to be run on JDK-1. I remember that also, but at some point in the
> > > > 8? cycle build requirements jumped to 8, while target version was still
> > > > 1.7.
> > >
> > > Yes, that used to be the policy. Even if we restrict the policy to LTS
> > > versions of Java, JDK17 is near and we have to move forward. As such I
> > > wanted
> > > to discuss this issue in November, 2020. I am still puzzled to understand
> > > where did my email disappear...
> > >
> > > Btw. there is `nb-javac` for JDK8 - related work I am involved in:
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Overview%3A+nb-javac
> > > This week we managed to ma