Re: Feedback: Release Management of Apache NetBeans (incubating) 11.0

2019-04-05 Thread Pete Whelpton
Thank you very much Laszlo!  Really appreciated!

P

On Fri, Apr 5, 2019 at 3:44 PM Geertjan Wielenga
 wrote:

> Yes, fantastic work, thank you very much!
>
> Gj
>
> On Fri, Apr 5, 2019 at 1:43 PM Junichi Yamamoto 
> wrote:
>
> > Thanks a lot for your great work, Laszlo!!!
> >
> > Junichi
> >
> > On Fri, Apr 5, 2019 at 8:23 PM Laszlo Kishalmi
> >  wrote:
> > >
> > > Dear all,
> > >
> > > I would like to thank you to be able to be the Release Manager of
> Apache
> > > NetBeans 11.0!
> > >
> > > Thank you all, who contributed in this release either by code,
> > > documentation, advice, or shared opinion!
> > >
> > > This cycle started a bit sleepy, either due to the new year's duties or
> > > due to the exhaustion from over-carrying the 10.0 release. After we
> were
> > > over the shock everything started to shape up nicely by end of
> February.
> > >
> > > As a release manager I found it a good practice not to do a release to
> > > staging for every vote candidate we made and we could use the artifacts
> > > from Jenkins directly. I still hope that it did not cause any trouble
> > > for the Apache Infrastructure. I'd keep that for the future releases as
> > > well.
> > >
> > > I'm still not fond of the vote candidate name. The release actually
> > > matured nicely vc1 - alpha, vc2 - beta 1, vc3- beta 2 and vc4 is an rc1
> > > quality. If I were not traveling through the world just at the end of
> > > our cycle, I would have cut a vc5 as well to address the minor
> > > non-technical concerns were found out during the voting cycle.
> > >
> > > Some Numbers:
> > >
> > > In this release we were resolving ~64 issues. 38 bugs, 13 improvement,
> > > 13 tasks
> > >
> > > The release process right now consists of ~30 steps (two steps more
> than
> > > 10.0), about the half of these steps requires changes in the release
> > > branch. This sets our limit to about four releases in a year, which is
> > > not bad, but we have that limit.
> > >
> > > I hope, I was documenting our work well enough, to make the job of the
> > > next Release Manager easier.
> > >
> > > This was a though, but wonderful journey! Thank you everyone for their
> > > work and support!
> > >
> > > Laszlo Kishalmi
> > >
> > > Volunteer Release Manager of Apache NetBeans 11.0
> > >
> > > P.S.: Constructive feedback on the process and on my work are , as
> > > always, welcome!
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
> > > For additional commands, e-mail:
> dev-h...@netbeans.incubator.apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > >
> > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
> > For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
>


Re: [DISCUSS] Experimental installers for 11.0

2019-04-05 Thread Pete Whelpton
No worries :)   My understanding (I'm 100% sure that this my understanding
is correct) is that digital signing weights the algorithm more in favour of
not displaying a warning, but the early adopters (first few people to
download) may still get the warning until a sufficient level of "trust" has
been built up.

All the best,

P

On Fri, Apr 5, 2019 at 10:01 AM Christian Lenz 
wrote:

> So signing is missing here, if I understand it correctly. Thx for the link
> Pete.
>
>
> Cheers
>
> Chris
>
>
>
> Von: Pete Whelpton
> Gesendet: Freitag, 5. April 2019 10:29
> An: dev@netbeans.incubator.apache.org
> Betreff: Re: [DISCUSS] Experimental installers for 11.0
>
> The smartscreen warning is mentioned in the Smartscreen wikipedia page,
> under criticism:  https://en.wikipedia.org/wiki/Microsoft_SmartScreen
>
> *SmartScreen Filter creates a problem for small software vendors when they
> distribute an updated version of installation or binary files over the
> internet. Whenever an updated version is released, SmartScreen responds by
> stating that the file is not commonly downloaded and can therefore install
> harmful files on your system. This can be fixed by the author digitally
> signing the distributed software. Reputation is then based not only on a
> file's hash but on the signing certificate as well. A common distribution
> method for authors to bypass SmartScreen warnings is to pack their
> installation program (for example Setup.exe) into a Z
> <https://en.wikipedia.org/wiki/Zip_(file_format)>ip-Archive and distribute
> it that way, though this can confuse non-expert users.  *
>
>
>
> On Fri, Apr 5, 2019 at 9:24 AM Christian Lenz 
> wrote:
>
> > Hi,
> >
> > I’m fine with adding this with a comment that those installer are not
> > official.
> >
> > One Issue here is, when I wanted to start the installer, Windows says
> > again this message: https://ibb.co/2Nr8Q43. This happened also for
> > NetBeans > 9. Until NetBeans 9, I didn’t have this Problem. So smth
> changed
> > in the behaviour of the NetBeans executables/binaries that Windows will
> > show this message. I already gave this info in another thread. This will
> > only happen, when I download NetBeans, fresh and new. But when I delete
> the
> > whole folder and the whole dependent directories (userdir, cache), it
> will
> > show the message again.
> >
> > Should I create a new thread?
> >
> >
> > Cheers
> >
> > Chris
> >
> >
> >
> > Von: Geertjan Wielenga
> > Gesendet: Freitag, 5. April 2019 09:54
> > An: dev
> > Betreff: [DISCUSS] Experimental installers for 11.0
> >
> > Hi all,
> >
> > Reema has put the installers created from the installer sources in her
> pull
> > request on Apache NetBeans GitHub in her repo:
> >
> >
> >
> https://github.com/rtaneja1/incubator-netbeans/tree/installer-bin-11vc4/nbbuild/installer/binaries
> >
> > She also has a process whereby the installers can be generated as part of
> > the build.
> >
> > However, since we have not checked in the sources of the installer into
> > Apache NetBeans GitHub and we have not included these convenience
> binaries
> > as part of the vote threads, the installers above can not be seen as
> > official Apache NetBeans installers -- though that should be the aim for
> > the next releases.
> >
> > However, as discussed in other threads some time ago, there's nothing
> wrong
> > with explicitly linking to the above on the page below so long as we
> clear
> > state that these are not official Apache NetBeans installers, though that
> > they should be seen as experimental installers for the next release:
> >
> > https://netbeans.apache.org/download/nb110/nb110.html
> >
> > Do we agree with this? Interested in responses and if everything is
> > favorable and no objections, will add the info as described above to the
> > page above in 24 hours.
> >
> > Thanks,
> >
> > Gj
> >
> >
>
>


Re: [DISCUSS] Experimental installers for 11.0

2019-04-05 Thread Pete Whelpton
The smartscreen warning is mentioned in the Smartscreen wikipedia page,
under criticism:  https://en.wikipedia.org/wiki/Microsoft_SmartScreen

*SmartScreen Filter creates a problem for small software vendors when they
distribute an updated version of installation or binary files over the
internet. Whenever an updated version is released, SmartScreen responds by
stating that the file is not commonly downloaded and can therefore install
harmful files on your system. This can be fixed by the author digitally
signing the distributed software. Reputation is then based not only on a
file's hash but on the signing certificate as well. A common distribution
method for authors to bypass SmartScreen warnings is to pack their
installation program (for example Setup.exe) into a Z
ip-Archive and distribute
it that way, though this can confuse non-expert users.  *



On Fri, Apr 5, 2019 at 9:24 AM Christian Lenz 
wrote:

> Hi,
>
> I’m fine with adding this with a comment that those installer are not
> official.
>
> One Issue here is, when I wanted to start the installer, Windows says
> again this message: https://ibb.co/2Nr8Q43. This happened also for
> NetBeans > 9. Until NetBeans 9, I didn’t have this Problem. So smth changed
> in the behaviour of the NetBeans executables/binaries that Windows will
> show this message. I already gave this info in another thread. This will
> only happen, when I download NetBeans, fresh and new. But when I delete the
> whole folder and the whole dependent directories (userdir, cache), it will
> show the message again.
>
> Should I create a new thread?
>
>
> Cheers
>
> Chris
>
>
>
> Von: Geertjan Wielenga
> Gesendet: Freitag, 5. April 2019 09:54
> An: dev
> Betreff: [DISCUSS] Experimental installers for 11.0
>
> Hi all,
>
> Reema has put the installers created from the installer sources in her pull
> request on Apache NetBeans GitHub in her repo:
>
>
> https://github.com/rtaneja1/incubator-netbeans/tree/installer-bin-11vc4/nbbuild/installer/binaries
>
> She also has a process whereby the installers can be generated as part of
> the build.
>
> However, since we have not checked in the sources of the installer into
> Apache NetBeans GitHub and we have not included these convenience binaries
> as part of the vote threads, the installers above can not be seen as
> official Apache NetBeans installers -- though that should be the aim for
> the next releases.
>
> However, as discussed in other threads some time ago, there's nothing wrong
> with explicitly linking to the above on the page below so long as we clear
> state that these are not official Apache NetBeans installers, though that
> they should be seen as experimental installers for the next release:
>
> https://netbeans.apache.org/download/nb110/nb110.html
>
> Do we agree with this? Interested in responses and if everything is
> favorable and no objections, will add the info as described above to the
> page above in 24 hours.
>
> Thanks,
>
> Gj
>
>


Re: Running GlassFish Under vc2 - Must use JDK 8

2019-03-02 Thread Pete Whelpton
 >>>> after the above steps.
> >>>>
> >>>> Gj
> >>>>
> >>>>> On Sat, Mar 2, 2019 at 7:46 PM Jose Ch  wrote:
> >>>>>
> >>>>> To be clear I used JDK 8 for the Platform option for Glassfish and
> >>> Payara
> >>>>> and JDK 11/12/13 for Netbeans and never successfully started them. I
> >>> will
> >>>>> try many combinations with different vendors (but always use JDK 8
> for
> >>> the
> >>>>> app servers) as soon as I get the chance this weekend.
> >>>>>
> >>>>> José.
> >>>>>
> >>>>> On Sat, Mar 2, 2019, 12:34 Geertjan Wielenga
> >>>>>  wrote:
> >>>>>
> >>>>>> GlassFish does not support anything beyond JDK 8.
> >>>>>>
> >>>>>> Gj
> >>>>>>
> >>>>>>> On Saturday, March 2, 2019, Jose Ch  wrote:
> >>>>>>>
> >>>>>>> The same happens to me in Fedora 29, but I never tried with JDK 8
> >>>>> always
> >>>>>>> with JDK 11/12/13 and never successfully start payara or glassfish
> >>>>> within
> >>>>>>> the IDE.
> >>>>>>>
> >>>>>>> On Sat, Mar 2, 2019, 10:04 Geertjan Wielenga
> >>>>>>>  wrote:
> >>>>>>>
> >>>>>>>> I’ve started GlassFish v5 and v5.1 from the Servers node with
> Apache
> >>>>>>>> NetBeans 11 vc1 without a problem several times. To check whether
> >>>>> this
> >>>>>> is
> >>>>>>>> specific to vc2 or specific to you, can you try with vc1 (instead
> of
> >>>>>>> vc2)?
> >>>>>>>>
> >>>>>>>> Gj
> >>>>>>>>
> >>>>>>>>> On Saturday, March 2, 2019, Josh Juneau 
> >>> wrote:
> >>>>>>>>>
> >>>>>>>>> Thanks Pete, I will put something in the JIRA.  Just wanted to
> >>>>>> confirm
> >>>>>>>> that
> >>>>>>>>> someone else was seeing the same issue first.  I'm running on Mac
> >>>>> OS
> >>>>>> X
> >>>>>>>>> 10.13.6.
> >>>>>>>>>
> >>>>>>>>> On Sat, Mar 2, 2019 at 9:46 AM Pete Whelpton <
> peedee...@gmail.com>
> >>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> Doh! I did notice whilst I was poking around in the GlassFish
> >>>>> code
> >>>>>>> that
> >>>>>>>>> the
> >>>>>>>>>> base64 package that is removed from JDK10 onwards was being used
> >>>>>>>>> somewhere
> >>>>>>>>>> in authentication, so hopefully it is something as simple as
> >>>>> that.
> >>>>>>>>>>
> >>>>>>>>>> If not, it might be beyond my abilities, but if you create an
> >>>>> issue
> >>>>>>> in
> >>>>>>>>> the
> >>>>>>>>>> Jira, hopefully somebody more talented than I can take a look
> and
> >>>>>>>> figure
> >>>>>>>>> it
> >>>>>>>>>> out.
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> P
> >>>>>>>>>>
> >>>>>>>>>> On Sat, 2 Mar 2019, 15:41 Josh Juneau, 
> >>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Hi Pete,
> >>>>>>>>>>>
> >>>>>>>>>>> Thanks for the write-up.  I have verified, and I already have
> >>>>>> JDK8
> >>>>>>>>>>> registered as an available platform.  When I right-click on
> >>>>>>> GlassFish
> >>>>>>>>> ->
> >>>>>>>>>>> Properties, the JDK 8 platform is already selected under the
> >>>>> Java
> >>>>>>>> tab.
> >>>>>>>>>>>
> >>>>>>>>>>> I've verified on vc2 that JDK 10, JDK 11, and JDK 12 seem to be
> >>>>>>>>>> exhibiting
> >>>>>>>>>>> the same behavior for GlassFish server.  I have had success
> >>>>>>> starting
> >>>>>>>>> the
> >>>>>>>>>>> server from within the IDE, but I am unable to open up the
> >>>>> server
> >>>>>>>>> domain
> >>>>>>>>>>> log or perform restart, stop, or terminate from within the IDE.
> >>>>>>>>>>>
> >>>>>>>>>>> Thanks again
> >>>>>>>>>>>
> >>>>>>>>>>> On Sat, Mar 2, 2019 at 9:22 AM Pete Whelpton <
> >>>>>> peedee...@gmail.com>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Hi Josh,
> >>>>>>>>>>>>
> >>>>>>>>>>>> Apologies if this is stating the obvious and you have already
> >>>>>>> tried
> >>>>>>>>> it
> >>>>>>>>>> -
> >>>>>>>>>>>> away from computer at the moment and can't test myself, but
> >>>>>> have
> >>>>>>>> you
> >>>>>>>>>>> tried:
> >>>>>>>>>>>>
> >>>>>>>>>>>> * Launching NB under JDK11
> >>>>>>>>>>>> * Right click GlassFish instance -> Properties
> >>>>>>>>>>>> * Java tab -> Manage platforms button
> >>>>>>>>>>>> * Add JDK8
> >>>>>>>>>>>> * Select JDK8 in dropdown
> >>>>>>>>>>>> * Close dialog and try starting GlassFish
> >>>>>>>>>>>>
> >>>>>>>>>>>> ?
> >>>>>>>>>>>>
> >>>>>>>>>>>> Hope that works!
> >>>>>>>>>>>>
> >>>>>>>>>>>> P
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Sat, Mar 2, 2019 at 3:08 PM Josh Juneau <
> >>>>>> juneau...@gmail.com>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>> I have noticed that using vc2, and running NetBeans on JDK
> >>>>> 11
> >>>>>>> or
> >>>>>>>>> 12,
> >>>>>>>>>> my
> >>>>>>>>>>>>> registered GlassFish server will not start from within the
> >>>>>> IDE.
> >>>>>>>> I
> >>>>>>>>> am
> >>>>>>>>>>>>> unable to manage GlassFish (or Payara) from within the IDE
> >>>>>>>> unless I
> >>>>>>>>>>> start
> >>>>>>>>>>>>> NetBeans under JDK 8.  If I start up NetBeans under JDK 8
> >>>>>>> things
> >>>>>>>>> seem
> >>>>>>>>>>> to
> >>>>>>>>>>>>> work without issue.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Has anyone else experienced this same behavior?
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Thanks
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Josh Juneau
> >>>>>>>>>>>>> juneau...@gmail.com
> >>>>>>>>>>>>> http://jj-blogger.blogspot.com
> >>>>>>>>>>>>>
> >>>>> https://www.apress.com/index.php/author/author/view/id/1866
> >>>>>>>>>>>>
> >>>>>>>>>>> --
> >>>>>>>>>>> Josh Juneau
> >>>>>>>>>>> juneau...@gmail.com
> >>>>>>>>>>> http://jj-blogger.blogspot.com
> >>>>>>>>>>> https://www.apress.com/index.php/author/author/view/id/1866
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Josh Juneau
> >>>>>>>>> juneau...@gmail.com
> >>>>>>>>> http://jj-blogger.blogspot.com
> >>>>>>>>> https://www.apress.com/index.php/author/author/view/id/1866
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>
> >>
>


Re: Running GlassFish Under vc2 - Must use JDK 8

2019-03-02 Thread Pete Whelpton
Doh! I did notice whilst I was poking around in the GlassFish code that the
base64 package that is removed from JDK10 onwards was being used somewhere
in authentication, so hopefully it is something as simple as that.

If not, it might be beyond my abilities, but if you create an issue in the
Jira, hopefully somebody more talented than I can take a look and figure it
out.


P

On Sat, 2 Mar 2019, 15:41 Josh Juneau,  wrote:

> Hi Pete,
>
> Thanks for the write-up.  I have verified, and I already have JDK8
> registered as an available platform.  When I right-click on GlassFish ->
> Properties, the JDK 8 platform is already selected under the Java tab.
>
> I've verified on vc2 that JDK 10, JDK 11, and JDK 12 seem to be exhibiting
> the same behavior for GlassFish server.  I have had success starting the
> server from within the IDE, but I am unable to open up the server domain
> log or perform restart, stop, or terminate from within the IDE.
>
> Thanks again
>
> On Sat, Mar 2, 2019 at 9:22 AM Pete Whelpton  wrote:
>
> > Hi Josh,
> >
> > Apologies if this is stating the obvious and you have already tried it -
> > away from computer at the moment and can't test myself, but have you
> tried:
> >
> > * Launching NB under JDK11
> > * Right click GlassFish instance -> Properties
> > * Java tab -> Manage platforms button
> > * Add JDK8
> > * Select JDK8 in dropdown
> > * Close dialog and try starting GlassFish
> >
> > ?
> >
> > Hope that works!
> >
> > P
> >
> > On Sat, Mar 2, 2019 at 3:08 PM Josh Juneau  wrote:
> >
> > > I have noticed that using vc2, and running NetBeans on JDK 11 or 12, my
> > > registered GlassFish server will not start from within the IDE.  I am
> > > unable to manage GlassFish (or Payara) from within the IDE unless I
> start
> > > NetBeans under JDK 8.  If I start up NetBeans under JDK 8 things seem
> to
> > > work without issue.
> > >
> > > Has anyone else experienced this same behavior?
> > >
> > > Thanks
> > >
> > > Josh Juneau
> > > juneau...@gmail.com
> > > http://jj-blogger.blogspot.com
> > > https://www.apress.com/index.php/author/author/view/id/1866
> >
> --
> Josh Juneau
> juneau...@gmail.com
> http://jj-blogger.blogspot.com
> https://www.apress.com/index.php/author/author/view/id/1866
>


Re: Running GlassFish Under vc2 - Must use JDK 8

2019-03-02 Thread Pete Whelpton
Hi Josh,

Apologies if this is stating the obvious and you have already tried it -
away from computer at the moment and can't test myself, but have you tried:

* Launching NB under JDK11
* Right click GlassFish instance -> Properties
* Java tab -> Manage platforms button
* Add JDK8
* Select JDK8 in dropdown
* Close dialog and try starting GlassFish

?

Hope that works!

P

On Sat, Mar 2, 2019 at 3:08 PM Josh Juneau  wrote:

> I have noticed that using vc2, and running NetBeans on JDK 11 or 12, my
> registered GlassFish server will not start from within the IDE.  I am
> unable to manage GlassFish (or Payara) from within the IDE unless I start
> NetBeans under JDK 8.  If I start up NetBeans under JDK 8 things seem to
> work without issue.
>
> Has anyone else experienced this same behavior?
>
> Thanks
>
> Josh Juneau
> juneau...@gmail.com
> http://jj-blogger.blogspot.com
> https://www.apress.com/index.php/author/author/view/id/1866


Re: [VOTE] PMC chair for Apache NetBeans

2019-03-01 Thread Pete Whelpton
+1

On Fri, Mar 1, 2019 at 2:53 PM Kodewerk  wrote:

> +1
>
>
> > On Mar 1, 2019, at 6:44 AM, Chuck Davis  wrote:
> >
> > +1
> >
> > On Fri, Mar 1, 2019 at 6:41 AM Mr_Krava 
> > wrote:
> >
> >> +1
> >>
> >>On Saturday, 2 March 2019, 1:29:07 am AEDT, Glenn Holmer
> >>  wrote:
> >>
> >> This voting thread is to confirm Geertjan Wielenga as the first PMC
> >> chair of NetBeans as we leave incubation and begin our journey as a
> >> top-level Apache project. As an Oracle employee, Geertjan has been in a
> >> unique position to help guide the project to independence and is the
> >> best choice to complete that process.
> >>
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


sigtest / API change

2019-02-27 Thread Pete Whelpton
Hi all,

Need some guidance from the NB pros!  I have a PR ready to submit that adds
a new method (getLicenseUrl()) to the ServerDetails class in the Glassfish
Common module.

This causes a sigtest warning during the building process, as described
here:
http://wiki.netbeans.org/SignatureTest


What is the correct process for me to follow to get an API change approved?


Cheers!

P


Re: [NETBEANS-965] & [NETBEANS-997]

2019-01-28 Thread Pete Whelpton
No problem :)

I guessed that parsing text files for the location would need to be
removed, so I have a branch nearly ready for PR that still has two URLs per
Glassfish version: a main location that will follow re-directs, and a
fallback that expects the URL to be correct

So, for example, NB could first try and download Glassfish from
netbeans.osuosl.org/binaries and fallback to downloading from
download.oracle.com, or vice versa.

Whilst I was in there, I also noticed that support for downloading &
registering GF5.0 was essentially already implemented, but commented out,
and I believe I've figured out how to add to add download/registering
support for GF4.1.2, so if there are no objections from the community, I
will add that in too.

HTH,



On Mon, Jan 28, 2019 at 3:49 PM Geertjan Wielenga
 wrote:

> Thanks for the great work. :-)
>
> Ideally, we wouldn't need to host any special file anywhere, if that can be
> done, that would be best.
>
> Alternatively, we have this location in Oregon:
>
> http://netbeans.osuosl.org/binaries
>
> See more about the above here:
> https://jaxenter.com/netbeans/towards-building-netbeans-new-home
>
> Any references to java.download.net or download.oracle.com should ideally
> be replaced with the above.
>
> Hope this helps,
>
> Gj
>
> On Sat, Jan 26, 2019 at 6:42 PM Pete Whelpton  wrote:
>
> > Ok, I figured out what is happening and got Glassfish 4.1.1 to download
> and
> > install via the NB installer :)  Now I could use some guidance from the
> > sages here on what they think the best way forward is!  What is happening
> > is:
> >
> > 1) NB first looks for the .txt file for the relevant Glassfish version on
> > serverplugins.netbeans.org (it will follow redirects to try and find
> it).
> > 2) If NB finds the txt file, it reads the first line, which contains the
> > directory path for that version of glassfish (see
> > http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt which is
> > still up!)
> >2a) The directory path is appended to the hardcoded base URL,
> > http://download.java.net
> >2b) NB will then try and download the glassfish .zip from this URL
> (but
> > won't follow redirects!)
> > 3) If NB fails to find/parse the .txt file, it will try and download the
> > .zip from the direct download.java.net link (the one with the
> > ?nbretriever=fallback querystring), but won't follow redirects
> >
> > Because there are now 301 redirects on the download.java.net URLs from
> > http
> > to https, even the fallback was failing.  Changing the fallback URL for
> > GF4.1.1. to https meant that it downloaded correctly.
> >
> > So my questions are:
> >
> > a) Do we want to keep this logic, and host .txt files with the download
> > path on netbeans.apache.org?  Probably the least intrusive way to get
> > things working again
> > b) If not, what to do with this logic?  Delete it?  comment it out and
> just
> > the fallback URL? or leave it in and allow NB to waste a few cycles
> trying
> > to find a .txt file that doesn't exist?
> > c) Do we want to take this opportunity to update the java.download.net
> > hostname to download.oracle.com, as that seems to be where the main
> > Glassfish web page links to now for downloads?
> > d) Should the fallback URL also follow redirects?
> >
> > Any and all opinions welcome :)
> >
> > HTH
> >
> > P
> >
> > On Fri, Jan 25, 2019 at 11:21 AM Pete Whelpton 
> > wrote:
> >
> > >
> > > I'm not 100% sure yet... still working through the downloader code.
> For
> > > each version of Glassfish supported, there is an enum
> > > in
> >
> /enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
> > > that contains among other things two URLS:
> > >
> > > 1) Link to the Glassfish .zip file hosted on download.java.net
> > > 2) Link to one of these .txt files hosted on
> serverplugins.netbeans.org
> > >
> > > E.g. for Glassfish 4.1.1:
> > >
> > > "
> > >
> >
> http://download.java.net/glassfish/4.1.1/release/glassfish-4.1.1.zip?nbretriever=fallback
> > ",
> > > // NOI18N
> > > "http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt"; //
> > NOI18N
> > >
> > > The download.java.net links still seem to be valid, but the
> > > serverplugins.netbeans.org links aren't.
> > >
> > > It's still a bit of a hunch at the moment, and you are right, we need
> to
> > > figur

Re: [NETBEANS-965] & [NETBEANS-997]

2019-01-26 Thread Pete Whelpton
Ok, I figured out what is happening and got Glassfish 4.1.1 to download and
install via the NB installer :)  Now I could use some guidance from the
sages here on what they think the best way forward is!  What is happening
is:

1) NB first looks for the .txt file for the relevant Glassfish version on
serverplugins.netbeans.org (it will follow redirects to try and find it).
2) If NB finds the txt file, it reads the first line, which contains the
directory path for that version of glassfish (see
http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt which is
still up!)
   2a) The directory path is appended to the hardcoded base URL,
http://download.java.net
   2b) NB will then try and download the glassfish .zip from this URL (but
won't follow redirects!)
3) If NB fails to find/parse the .txt file, it will try and download the
.zip from the direct download.java.net link (the one with the
?nbretriever=fallback querystring), but won't follow redirects

Because there are now 301 redirects on the download.java.net URLs from http
to https, even the fallback was failing.  Changing the fallback URL for
GF4.1.1. to https meant that it downloaded correctly.

So my questions are:

a) Do we want to keep this logic, and host .txt files with the download
path on netbeans.apache.org?  Probably the least intrusive way to get
things working again
b) If not, what to do with this logic?  Delete it?  comment it out and just
the fallback URL? or leave it in and allow NB to waste a few cycles trying
to find a .txt file that doesn't exist?
c) Do we want to take this opportunity to update the java.download.net
hostname to download.oracle.com, as that seems to be where the main
Glassfish web page links to now for downloads?
d) Should the fallback URL also follow redirects?

Any and all opinions welcome :)

HTH

P

On Fri, Jan 25, 2019 at 11:21 AM Pete Whelpton  wrote:

>
> I'm not 100% sure yet... still working through the downloader code.  For
> each version of Glassfish supported, there is an enum
> in 
> /enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
> that contains among other things two URLS:
>
> 1) Link to the Glassfish .zip file hosted on download.java.net
> 2) Link to one of these .txt files hosted on serverplugins.netbeans.org
>
> E.g. for Glassfish 4.1.1:
>
> "
> http://download.java.net/glassfish/4.1.1/release/glassfish-4.1.1.zip?nbretriever=fallback";,
> // NOI18N
> "http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt"; // NOI18N
>
> The download.java.net links still seem to be valid, but the
> serverplugins.netbeans.org links aren't.
>
> It's still a bit of a hunch at the moment, and you are right, we need to
> figure out how those txt files were used, but given that the downloader no
> longer works in NB8.2 too, I'm thinking it could well be an external
> dependency that is broken?
>
> I'm hoping somebody more experienced than I has an idea what those txt
> files were for?
>
>
>
> P
>
>
> On Fri, Jan 25, 2019 at 10:54 AM Geertjan Wielenga
>  wrote:
>
>> How are they needed? I doubt they have been needed or used for a while
>> since they come from Kenai which has not been around for some time. Thanks
>> for your great work.
>>
>> Gj
>>
>> On Friday, January 25, 2019, Pete Whelpton  wrote:
>>
>> > Hi all :)
>> >
>> > Thought I might have a quick look into these (attempting to download
>> > Glassfish via NB results in "Not Found" error).
>> >
>> > I think one problem here is that for each supported version of
>> Glassfish,
>> > there was a related text file on the old netbeans.org:
>> >
>> > * http://serverplugins.netbeans.org/glassfishv3/post701v3.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-0-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt
>> > * http://serverplugins.netbeans.org/glassfishv3/post71v5-0.txt
>> >
>> > Does anybody know:
>> >
>> > a) what these .txt files are?
>> > b) if they made it to a new home on netbeans.apache.org?
>> >
>> >
>> > P
>> >
>>
>


Re: [NETBEANS-965] & [NETBEANS-997]

2019-01-25 Thread Pete Whelpton
I'm not 100% sure yet... still working through the downloader code.  For
each version of Glassfish supported, there is an enum
in 
/enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
that contains among other things two URLS:

1) Link to the Glassfish .zip file hosted on download.java.net
2) Link to one of these .txt files hosted on serverplugins.netbeans.org

E.g. for Glassfish 4.1.1:

"
http://download.java.net/glassfish/4.1.1/release/glassfish-4.1.1.zip?nbretriever=fallback";,
// NOI18N
"http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt"; // NOI18N

The download.java.net links still seem to be valid, but the
serverplugins.netbeans.org links aren't.

It's still a bit of a hunch at the moment, and you are right, we need to
figure out how those txt files were used, but given that the downloader no
longer works in NB8.2 too, I'm thinking it could well be an external
dependency that is broken?

I'm hoping somebody more experienced than I has an idea what those txt
files were for?



P


On Fri, Jan 25, 2019 at 10:54 AM Geertjan Wielenga
 wrote:

> How are they needed? I doubt they have been needed or used for a while
> since they come from Kenai which has not been around for some time. Thanks
> for your great work.
>
> Gj
>
> On Friday, January 25, 2019, Pete Whelpton  wrote:
>
> > Hi all :)
> >
> > Thought I might have a quick look into these (attempting to download
> > Glassfish via NB results in "Not Found" error).
> >
> > I think one problem here is that for each supported version of Glassfish,
> > there was a related text file on the old netbeans.org:
> >
> > * http://serverplugins.netbeans.org/glassfishv3/post701v3.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-0-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt
> > * http://serverplugins.netbeans.org/glassfishv3/post71v5-0.txt
> >
> > Does anybody know:
> >
> > a) what these .txt files are?
> > b) if they made it to a new home on netbeans.apache.org?
> >
> >
> > P
> >
>


[NETBEANS-965] & [NETBEANS-997]

2019-01-25 Thread Pete Whelpton
Hi all :)

Thought I might have a quick look into these (attempting to download
Glassfish via NB results in "Not Found" error).

I think one problem here is that for each supported version of Glassfish,
there was a related text file on the old netbeans.org:

* http://serverplugins.netbeans.org/glassfishv3/post701v3.txt
* http://serverplugins.netbeans.org/glassfishv3/post701v3-0-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post701v3-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post701v3-1-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v4-0.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v4-0-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v4-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt
* http://serverplugins.netbeans.org/glassfishv3/post71v5-0.txt

Does anybody know:

a) what these .txt files are?
b) if they made it to a new home on netbeans.apache.org?


P