MonitorActivity bug?
Noticed "copy attributes" is implemented only for REL_ACTIVITY_RESTORED case. I needed original attributes for REL_INACTIVE case as well. wonder why it is limited to activity restored relationship only. https://github.com/apache/nifi/blob/31fba6b3332978ca2f6a1d693f6053d719fb9daa/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MonitorActivity.java#L208 -- Thanks, Sumanth
[GitHub] nifi pull request: NiFI-747: ListenHTTP exposes property for the U...
Github user vs186031 commented on the pull request:
https://github.com/apache/nifi/pull/104#issuecomment-148951828
>Aside from the property validation, it works as expected. I confirmed
POSTs and DELETEs on HOLDs work (using Poster)
Added a small Regex to ensure that the Property Validation works.
>Just a quick style question, did you give any thought to not removing the
annotation below and maybe instead changing it to 'Path("*")'?
Made this change as well.
I did the changes as two separate change-sets, just in case.
>Ah, sorry, it is a firefox browser extension I like to use that makes it
easy to do do arbitrary HTTP requests.
This is actually quite cool , thanks for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI 944: Support tab & special delimiter chars...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/87#issuecomment-148940719 It looks good, with the exception of a couple issues. First off, adding the allowableValues on the HAS_HEADER property descriptor actually could break flows already using this processor - e.g. If I have the value "False", which validated previously, it breaks with this change. I added a ticket (NIFI-1044) which sort of addresses this issue as a whole, if there is a compatibility break, we may want to hold that change. Secondly, there should probably be some sanity checking on the delimiter value now. It is pretty cool that I can use \t, or even \u0009, and I used \u0555 which totally worked. However, I can also use \n, which probably shouldn't be allowed (I'm not even sure what would be expected) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI 944: Support tab & special delimiter chars...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/87#issuecomment-148938140 out of curiosity, I noticed you moved unescapeString to a method between pull requests - is there a reason you pulled it out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-995: TestGetFile failed in case of NTFS pa...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/95#issuecomment-148921603 Nice catch and cool patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-995: TestGetFile failed in case of NTFS pa...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] nifi pull request: NiFI-747: ListenHTTP exposes property for the U...
Of course , the fancy curl or wget. -- View this message in context: http://apache-nifi-developer-list.39713.n7.nabble.com/GitHub-nifi-pull-request-NiFI-747-ListenHTTP-exposes-property-for-the-U-tp3126p3134.html Sent from the Apache NiFi Developer List mailing list archive at Nabble.com.
[GitHub] nifi pull request: nifi-612 Removing dead code, FlowUnmarshaller
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: Tabs to spaces in archetype
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: Tabs to spaces in archetype
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/100#issuecomment-148913652 looks good, applies cleanly, and yes, the tabs stuck out like a sore thumb in that file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NiFI-747: ListenHTTP exposes property for the U...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/104#issuecomment-148907545 > What exactly is Poster ? Ah, sorry, it is a firefox browser extension I like to use that makes it easy to do do arbitrary HTTP requests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NiFI-747: ListenHTTP exposes property for the U...
Github user vs186031 commented on the pull request:
https://github.com/apache/nifi/pull/104#issuecomment-148893113
"I set the URI to 'content5000', but this causes errors like these..."
- That's a good catch , i suspect this is due to the standard URI validator
"Just a quick style question, did you give any thought to not removing the
annotation below and maybe instead changing it to 'Path("*")'?"
- I did and then backed off to keep the first commit change minimal,
however i agree this is a good opportunity to change the (if path==null)
condition.
One question : "I confirmed POSTs and DELETEs on HOLDs work (using Poster)"
- What exactly is Poster ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
