Re: Maven Build Failure
Hmm, can't say I've seen those particular errors arise. I just made a simple Dockerfile as a sanity check that is available here: https://github.com/apiri/nifi-review-collateral/blob/master/docker-build/Dockerfile A 'docker build .' against that file is all that is needed. I ran this in a couple environments successfully inclusive of an older laptop with Centos 7 and, the other, a more modern desktop running Debian 9. Could you let us know if this is also problematic? Thanks! --Aldrin On Sun, Mar 25, 2018 at 2:02 PM, scottwrote: > Thanks for the help Aldrin. I've tried many permutations to get this to > work. The two environments I've been trying to build in are Centos and > Ubuntu. I've tried disabling the tests and adjusting the memory, with > moderate success, but I still cannot get a complete compile. > > export MAVEN_OPTS="-Xms2G -Xmx8G" > mvn clean install -Dmaven.test.skip=true > > Env1: > Centos 7, Apache Maven 3.5.3, Open JDK 64bit 1.8.0_161 > Farthest I've gotten is nifi-web-ui > [ERROR] Failed to extract goal com.github.eirslett:frontend-m > aven-plugin:1.1:install-node-and-npm (install-node-and-npm) on project > nifi-web-ui: Could not extract the Node archive: > '/home/scotty/.m2/repository/com/github/eirslett/node/5.7.0/node-5.7.0-linux-x64.tar.gz': > Operation not permitted > > Env2: > Ubuntu 16.04 LTS, Apache Maven 3.3.9, Open JDK 64 bit 1.8.0_151 > Farthest I've gotten is nifi-slack-processors > [ERROR] Failed to execute goal on project nifi-slack-processors: Could not > resolve dependencies for project > org.apache.nifi:nifi-slack-processors:jar:1.6.0-SNAPSHOT: > Could not find artifact org.apache.nifi:nifi-standard- > processors:jar:tests:1.6.0-SNAPSHOT in apache.snapshots ( > https://repository.apache.org/snapshots) > > Thanks, > Scott > > > > On 03/24/2018 07:14 PM, Aldrin Piri wrote: > >> Hi Scott, >> >> Are the issues with tests or something else? Could you share the error(s) >> you are seeing during the build process? I just checked out Travis, and >> it >> looks like we are building normally. >> >> >> Could you share more about your environment? >> >> "mvn -version" would be a great start as well as letting us know what >> distributions you attempted the build. >> >> Hopefully we can smooth out whatever is amiss and get you to those custom >> processors. >> >> --aldrin >> >> >> On Sat, Mar 24, 2018 at 9:41 PM, scott wrote: >> >> Hello Devs, >>> >>> I've been struggling with building NiFi's latest version. I've tried >>> turning off the tests, building on two different Linux instances and >>> different versions of Maven and Java and even gave it more memory. It >>> always stops somewhere in the build before completing. I'm just wondering >>> if there is a secret handshake I'm missing. Is there a docker base image, >>> for instance, that has an environment that will build NiFi every time? It >>> takes a while to build/fail, so I'm just a bit frustrated. I'm not really >>> interested in becoming a Maven expert, just want to crank out some custom >>> processors. >>> >>> Thanks for your time, >>> >>> Scott >>> >>> >>> >
RE: [EXT] Re: NiFi Versioned Process Group Status Icons
Matt, If you really want to enable awareness of this feature, enable the "Version" menu option even if no NiFi Registry has been enabled, and when the user clicks, "Start version control" take them to the help section for starting up a version control server and registering it. The existing "Up to date" and "Stale" status icons that show in the upper left corner are great. They only show up if the Process Group is versioned, and they aren't distracting you from the status of your flow in general; simple single icon. But the five new status icons at the bottom, even if I am actively using NiFi Registry, feel very busy and distracting. I am excited about NiFi Registry. I am just starting to use it and I think it's going to solve a lot of issues. Thanks, Peter -Original Message- From: Matt Gilman [mailto:matt.c.gil...@gmail.com] Sent: Saturday, March 24, 2018 04:18 To: dev@nifi.apache.org Subject: [EXT] Re: NiFi Versioned Process Group Status Icons Peter, The status icon for a specific Process Group is hidden until that group is versioned. That icon is positioned next to the group name. For the icons in the status bar and in the bottom of the Process Group, we were ultimately just trying to remain consistent. These reflect the counts of the encapsulated versioned Process Groups and does not include itself. Like we have with the status icons for the encapsulated Processors and Ports. Even if this Process Group is not configured to have any encapsulated components, we still render the counts as zero. Additionally, the presence of the icons helps drive awareness of the feature. Rob or Drew may have some additional insight to add. Hope this helps Matt On Fri, Mar 23, 2018 at 12:10 AM, Peter Wicks (pwicks)wrote: > Why does NiFi show status icons for Versioned Process Group's on > servers that are not configured to connect to a NiFi Registry? > > Thanks, > Peter >
published by PublishKafkaRecord_0_10 doesn't embed schema.
Hello Nifi Users, Apparently, it seems like PublishKafkaRecord_0_10 doesn't embed schema even if it Avro Record writer is configured with “Embed Avro Schema”. I have seen the following post from Bryan Brende. Wondering if it is a known issue or if I am missing anything here. https://community.hortonworks.com/questions/110652/cant-consume-avro-messages-whcih-are-published-by.html This is how message looks in Kafka-console-consumer, when published using “PublishKafkaRecord_0_11” $ bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 --topic test --from-beginning �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$�zpA �=h*�p��l �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$+�=�ت��;�.Y7 �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$�D�p��"B�� r0 �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$ekLl�;]�,Y�͙� �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$�z��klŤ�1�'�z� �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$���ξu��5�V}>�_ �SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$��=%��VbK� ��'~���X�controller1.ad.interset.com�H22018-03-15T09:07:04-04:00CONTROLLER1$��0 When I publish the message using my java class output from console consumer prints the avro schema. Objavro.schema�P{"type":"record","name":"ActiveDirectoryRecord","namespace":"com..schema","doc":"for more info, refer to http://docs.splunk.com/Documentation/CIM/4.2.0/User/Resource","fields":[{"name":"action","type":"string","doc":"The action performed on the resource."},{"name":"dest","type":"string","doc":"The target involved in the authentication. May be aliased from more specific fields, such as dest_host, dest_ip, or dest_nt_host."},{"name":"signature_id","type":"int","doc":"Description of the change performed (integer)"},{"name":"time","type":"string","doc":"ISO 8601 timestamp of the eventl,{"name":"privileges","type":["null",{"type":"array","items":"string"}],"doc":"The list of privileges associated with a Privilege Escalation event","default":null},{"name":"subcode","type":["null","string"],"doc":"The error subcode for auth;��d��g%�z�SUCCESS6controller1.ad.interset.com�H22018-03-15T09:07:04-04:00usedid1Pz�� Regards, Milan Das
Re: Maven Build Failure
Thanks for the help Aldrin. I've tried many permutations to get this to work. The two environments I've been trying to build in are Centos and Ubuntu. I've tried disabling the tests and adjusting the memory, with moderate success, but I still cannot get a complete compile. export MAVEN_OPTS="-Xms2G -Xmx8G" mvn clean install -Dmaven.test.skip=true Env1: Centos 7, Apache Maven 3.5.3, Open JDK 64bit 1.8.0_161 Farthest I've gotten is nifi-web-ui [ERROR] Failed to extract goal com.github.eirslett:frontend-maven-plugin:1.1:install-node-and-npm (install-node-and-npm) on project nifi-web-ui: Could not extract the Node archive: '/home/scotty/.m2/repository/com/github/eirslett/node/5.7.0/node-5.7.0-linux-x64.tar.gz': Operation not permitted Env2: Ubuntu 16.04 LTS, Apache Maven 3.3.9, Open JDK 64 bit 1.8.0_151 Farthest I've gotten is nifi-slack-processors [ERROR] Failed to execute goal on project nifi-slack-processors: Could not resolve dependencies for project org.apache.nifi:nifi-slack-processors:jar:1.6.0-SNAPSHOT: Could not find artifact org.apache.nifi:nifi-standard-processors:jar:tests:1.6.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) Thanks, Scott On 03/24/2018 07:14 PM, Aldrin Piri wrote: Hi Scott, Are the issues with tests or something else? Could you share the error(s) you are seeing during the build process? I just checked out Travis, and it looks like we are building normally. Could you share more about your environment? "mvn -version" would be a great start as well as letting us know what distributions you attempted the build. Hopefully we can smooth out whatever is amiss and get you to those custom processors. --aldrin On Sat, Mar 24, 2018 at 9:41 PM, scottwrote: Hello Devs, I've been struggling with building NiFi's latest version. I've tried turning off the tests, building on two different Linux instances and different versions of Maven and Java and even gave it more memory. It always stops somewhere in the build before completing. I'm just wondering if there is a secret handshake I'm missing. Is there a docker base image, for instance, that has an environment that will build NiFi every time? It takes a while to build/fail, so I'm just a bit frustrated. I'm not really interested in becoming a Maven expert, just want to crank out some custom processors. Thanks for your time, Scott
Re: [CANCEL][VOTE] Release Apache NiFi 1.6.0 RC1
I plan to review/test the fix that Sivaprasanna made first thing tomorrow morning, unless someone gets to it before then. > On Mar 25, 2018, at 10:29 AM, Joey Frazeewrote: > > Joe, yes, referring to what Bryan discovered. > > On Mar 25, 2018, 9:23 AM -0500, Joe Witt , wrote: >> Team >> >> RC1 vote is cancelled to correct findings of vote process. >> >> Joey: >> I pushed the RC1 branch >> https://github.com/apache/nifi/tree/NIFI-4995-RC1 as per release >> guide. We will push the actual tag once we get to a release point. >> >> Can you clarify what fingerprint issue you are referring to? Just >> want to make sure this is what BryanB pointed out and not something >> else. >> >> Thanks >> Joe >> >> On Sun, Mar 25, 2018 at 10:12 AM, Joey Frazee wrote: >>> -1 >>> >>> Ran through the usual release helper stuff, but it seems like the >>> fingerprint issue is going to cause problems, so not sure how useful >>> putting 1.6.0 out there will be if 1.6.1 will have to be turned around >>> immediately. >>> >>> Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the >>> tag got pushed. >>> >>> -joey >>> >>> On Mar 24, 2018, 12:38 AM -0500, Pierre Villard >>> , wrote: -1 (binding) I confirm the issue mentioned by Bryan. That's actually what Matt and I experienced when trying the PR about the S2S Metrics Reporting task [1]. I thought it was due to my change but it appears it's not the case. [1] https://github.com/apache/nifi/pull/2575 2018-03-23 22:53 GMT+01:00 Bryan Bende : > After voting I happened to be using the RC to test something else and > came across a bug that I think warrants changing my vote to a -1. > > I created a simple two node cluster and made a standard convert record > flow. When I ran the flow I got a schema not found exception, so I > used the debugger which showed AvroSchemaRegistry had no schemas, even > though there was one in the UI. > > I then used the debugger to make sure the onPropertyModified was > getting when a schema was added, and it was which meant some after > adding the schema but before running the flow, it was being removed. > > As far as I can tell, the issue is related to changes introduced in > NIFI-4864... the intent here was for components with property > descriptors that have "dynamically modifies classpath" to be able to > smartly reload when they are started based on knowing if more > classpath resources were added. > > The issue is that for components that don't have any property > descriptors like this, they have a null fingerprint, and before > starting it compares null to the fingerprint of empty string, and > decides to reload [2]. > > I think the fix should be fairly easy to just short-circuit at the > beginning of that method and return immediately if > additionalResourcesFingerprint is null, but will have to do some > testing. > > [1] https://issues.apache.org/jira/browse/NIFI-4864 > [2] https://github.com/apache/nifi/blob/master/nifi-nar- > bundles/nifi-framework-bundle/nifi-framework/nifi-framework- > core-api/src/main/java/org/apache/nifi/controller/ > AbstractConfiguredComponent.java#L313-L314 > > > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman wrote: >> +1 (binding) Release this package as nifi-1.6.0 >> >> Executed the release helper and verified new granular restrictions with >> regards to flow versioning. >> >> Thanks for RMing Joe! >> >> Matt >> >> On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser wrote: >> >>> +1 (binding) >>> >>> Ran through release helper to verify the release and run NiFi on Ubuntu >>> 16.04. It worked as expected with no new comments to add. >>> >>> -- Mike >>> >>> >>> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan >> wrote: >>> +1 (binding) - Ran through release helper - Setup secure NiFi and verified a test flow On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende wrote: > +1 (binding) > > - Ran through release helper and everything checked out > - Verified some test flows with the restricted components + keytab > CS > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne > +1 (binding) >> >> Was able to verify hashes, build with contrib-check, and start up > application. Performed some basic functionality tests and all > worked as > expected. >> >> Thanks! >>
Re: [VOTE] Release Apache NiFi 1.6.0
Is it not possible to review/verify the improvements made to NIFI-4864 issue and then go ahead with the 1.6.0 release process? The new change is relatively minor so if possible, we can verify whether everything is intact and not going to introduce new problems. Maybe, if that’s the case, we can still go ahead? Having said that, I don’t intend to mean a rushed up review/release process. Cheers, Sivaprasanna On Sun, 25 Mar 2018 at 7:43 PM, Joey Frazeewrote: > -1 > > Ran through the usual release helper stuff, but it seems like the > fingerprint issue is going to cause problems, so not sure how useful > putting 1.6.0 out there will be if 1.6.1 will have to be turned around > immediately. > > Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the > tag got pushed. > > -joey > > On Mar 24, 2018, 12:38 AM -0500, Pierre Villard < > pierre.villard...@gmail.com>, wrote: > > -1 (binding) > > > > I confirm the issue mentioned by Bryan. That's actually what Matt and I > > experienced when trying the PR about the S2S Metrics Reporting task [1]. > I > > thought it was due to my change but it appears it's not the case. > > > > [1] https://github.com/apache/nifi/pull/2575 > > > > 2018-03-23 22:53 GMT+01:00 Bryan Bende : > > > > > After voting I happened to be using the RC to test something else and > > > came across a bug that I think warrants changing my vote to a -1. > > > > > > I created a simple two node cluster and made a standard convert record > > > flow. When I ran the flow I got a schema not found exception, so I > > > used the debugger which showed AvroSchemaRegistry had no schemas, even > > > though there was one in the UI. > > > > > > I then used the debugger to make sure the onPropertyModified was > > > getting when a schema was added, and it was which meant some after > > > adding the schema but before running the flow, it was being removed. > > > > > > As far as I can tell, the issue is related to changes introduced in > > > NIFI-4864... the intent here was for components with property > > > descriptors that have "dynamically modifies classpath" to be able to > > > smartly reload when they are started based on knowing if more > > > classpath resources were added. > > > > > > The issue is that for components that don't have any property > > > descriptors like this, they have a null fingerprint, and before > > > starting it compares null to the fingerprint of empty string, and > > > decides to reload [2]. > > > > > > I think the fix should be fairly easy to just short-circuit at the > > > beginning of that method and return immediately if > > > additionalResourcesFingerprint is null, but will have to do some > > > testing. > > > > > > [1] https://issues.apache.org/jira/browse/NIFI-4864 > > > [2] https://github.com/apache/nifi/blob/master/nifi-nar- > > > bundles/nifi-framework-bundle/nifi-framework/nifi-framework- > > > core-api/src/main/java/org/apache/nifi/controller/ > > > AbstractConfiguredComponent.java#L313-L314 > > > > > > > > > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman > > wrote: > > > > +1 (binding) Release this package as nifi-1.6.0 > > > > > > > > Executed the release helper and verified new granular restrictions > with > > > > regards to flow versioning. > > > > > > > > Thanks for RMing Joe! > > > > > > > > Matt > > > > > > > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > Ran through release helper to verify the release and run NiFi on > Ubuntu > > > > > 16.04. It worked as expected with no new comments to add. > > > > > > > > > > -- Mike > > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan < > scottyas...@gmail.com > > > > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > - Ran through release helper > > > > > > - Setup secure NiFi and verified a test flow > > > > > > > > > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende > > wrote: > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > - Ran through release helper and everything checked out > > > > > > > - Verified some test flows with the restricted components + > keytab > > > CS > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne < > marka...@hotmail.com > > > > > > wrote: > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > Was able to verify hashes, build with contrib-check, and > start up > > > > > > > application. Performed some basic functionality tests and all > > > worked as > > > > > > > expected. > > > > > > > > > > > > > > > > Thanks! > > > > > > > > -Mark > > > > > > > > > > > > > > > > > > > > > > > > > On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma < > > > > > tasan...@yahoo-corp.jp > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Thanks for all your efforts, Joe. > > > > > > > > > > > > > > > > > > I
Re: [CANCEL][VOTE] Release Apache NiFi 1.6.0 RC1
Joe, yes, referring to what Bryan discovered. On Mar 25, 2018, 9:23 AM -0500, Joe Witt, wrote: > Team > > RC1 vote is cancelled to correct findings of vote process. > > Joey: > I pushed the RC1 branch > https://github.com/apache/nifi/tree/NIFI-4995-RC1 as per release > guide. We will push the actual tag once we get to a release point. > > Can you clarify what fingerprint issue you are referring to? Just > want to make sure this is what BryanB pointed out and not something > else. > > Thanks > Joe > > On Sun, Mar 25, 2018 at 10:12 AM, Joey Frazee wrote: > > -1 > > > > Ran through the usual release helper stuff, but it seems like the > > fingerprint issue is going to cause problems, so not sure how useful > > putting 1.6.0 out there will be if 1.6.1 will have to be turned around > > immediately. > > > > Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the > > tag got pushed. > > > > -joey > > > > On Mar 24, 2018, 12:38 AM -0500, Pierre Villard > > , wrote: > > > -1 (binding) > > > > > > I confirm the issue mentioned by Bryan. That's actually what Matt and I > > > experienced when trying the PR about the S2S Metrics Reporting task [1]. I > > > thought it was due to my change but it appears it's not the case. > > > > > > [1] https://github.com/apache/nifi/pull/2575 > > > > > > 2018-03-23 22:53 GMT+01:00 Bryan Bende : > > > > > > > After voting I happened to be using the RC to test something else and > > > > came across a bug that I think warrants changing my vote to a -1. > > > > > > > > I created a simple two node cluster and made a standard convert record > > > > flow. When I ran the flow I got a schema not found exception, so I > > > > used the debugger which showed AvroSchemaRegistry had no schemas, even > > > > though there was one in the UI. > > > > > > > > I then used the debugger to make sure the onPropertyModified was > > > > getting when a schema was added, and it was which meant some after > > > > adding the schema but before running the flow, it was being removed. > > > > > > > > As far as I can tell, the issue is related to changes introduced in > > > > NIFI-4864... the intent here was for components with property > > > > descriptors that have "dynamically modifies classpath" to be able to > > > > smartly reload when they are started based on knowing if more > > > > classpath resources were added. > > > > > > > > The issue is that for components that don't have any property > > > > descriptors like this, they have a null fingerprint, and before > > > > starting it compares null to the fingerprint of empty string, and > > > > decides to reload [2]. > > > > > > > > I think the fix should be fairly easy to just short-circuit at the > > > > beginning of that method and return immediately if > > > > additionalResourcesFingerprint is null, but will have to do some > > > > testing. > > > > > > > > [1] https://issues.apache.org/jira/browse/NIFI-4864 > > > > [2] https://github.com/apache/nifi/blob/master/nifi-nar- > > > > bundles/nifi-framework-bundle/nifi-framework/nifi-framework- > > > > core-api/src/main/java/org/apache/nifi/controller/ > > > > AbstractConfiguredComponent.java#L313-L314 > > > > > > > > > > > > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman > > > wrote: > > > > > +1 (binding) Release this package as nifi-1.6.0 > > > > > > > > > > Executed the release helper and verified new granular restrictions > > > > > with > > > > > regards to flow versioning. > > > > > > > > > > Thanks for RMing Joe! > > > > > > > > > > Matt > > > > > > > > > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser > > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Ran through release helper to verify the release and run NiFi on > > > > > > Ubuntu > > > > > > 16.04. It worked as expected with no new comments to add. > > > > > > > > > > > > -- Mike > > > > > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan > > > > > wrote: > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > - Ran through release helper > > > > > > > - Setup secure NiFi and verified a test flow > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende > > > wrote: > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > - Ran through release helper and everything checked out > > > > > > > > - Verified some test flows with the restricted components + > > > > > > > > keytab > > > > CS > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne > > > > > > > > > > > > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > Was able to verify hashes, build with contrib-check, and > > > > > > > > > start up > > > > > > > > application. Performed some basic
[CANCEL][VOTE] Release Apache NiFi 1.6.0 RC1
Team RC1 vote is cancelled to correct findings of vote process. Joey: I pushed the RC1 branch https://github.com/apache/nifi/tree/NIFI-4995-RC1 as per release guide. We will push the actual tag once we get to a release point. Can you clarify what fingerprint issue you are referring to? Just want to make sure this is what BryanB pointed out and not something else. Thanks Joe On Sun, Mar 25, 2018 at 10:12 AM, Joey Frazeewrote: > -1 > > Ran through the usual release helper stuff, but it seems like the fingerprint > issue is going to cause problems, so not sure how useful putting 1.6.0 out > there will be if 1.6.1 will have to be turned around immediately. > > Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the > tag got pushed. > > -joey > > On Mar 24, 2018, 12:38 AM -0500, Pierre Villard > , wrote: >> -1 (binding) >> >> I confirm the issue mentioned by Bryan. That's actually what Matt and I >> experienced when trying the PR about the S2S Metrics Reporting task [1]. I >> thought it was due to my change but it appears it's not the case. >> >> [1] https://github.com/apache/nifi/pull/2575 >> >> 2018-03-23 22:53 GMT+01:00 Bryan Bende : >> >> > After voting I happened to be using the RC to test something else and >> > came across a bug that I think warrants changing my vote to a -1. >> > >> > I created a simple two node cluster and made a standard convert record >> > flow. When I ran the flow I got a schema not found exception, so I >> > used the debugger which showed AvroSchemaRegistry had no schemas, even >> > though there was one in the UI. >> > >> > I then used the debugger to make sure the onPropertyModified was >> > getting when a schema was added, and it was which meant some after >> > adding the schema but before running the flow, it was being removed. >> > >> > As far as I can tell, the issue is related to changes introduced in >> > NIFI-4864... the intent here was for components with property >> > descriptors that have "dynamically modifies classpath" to be able to >> > smartly reload when they are started based on knowing if more >> > classpath resources were added. >> > >> > The issue is that for components that don't have any property >> > descriptors like this, they have a null fingerprint, and before >> > starting it compares null to the fingerprint of empty string, and >> > decides to reload [2]. >> > >> > I think the fix should be fairly easy to just short-circuit at the >> > beginning of that method and return immediately if >> > additionalResourcesFingerprint is null, but will have to do some >> > testing. >> > >> > [1] https://issues.apache.org/jira/browse/NIFI-4864 >> > [2] https://github.com/apache/nifi/blob/master/nifi-nar- >> > bundles/nifi-framework-bundle/nifi-framework/nifi-framework- >> > core-api/src/main/java/org/apache/nifi/controller/ >> > AbstractConfiguredComponent.java#L313-L314 >> > >> > >> > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman > > wrote: >> > > +1 (binding) Release this package as nifi-1.6.0 >> > > >> > > Executed the release helper and verified new granular restrictions with >> > > regards to flow versioning. >> > > >> > > Thanks for RMing Joe! >> > > >> > > Matt >> > > >> > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser > > wrote: >> > > >> > > > +1 (binding) >> > > > >> > > > Ran through release helper to verify the release and run NiFi on Ubuntu >> > > > 16.04. It worked as expected with no new comments to add. >> > > > >> > > > -- Mike >> > > > >> > > > >> > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan > > > > wrote: >> > > > >> > > > > +1 (binding) >> > > > > >> > > > > - Ran through release helper >> > > > > - Setup secure NiFi and verified a test flow >> > > > > >> > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende > > wrote: >> > > > > >> > > > > > +1 (binding) >> > > > > > >> > > > > > - Ran through release helper and everything checked out >> > > > > > - Verified some test flows with the restricted components + keytab >> > CS >> > > > > > >> > > > > > >> > > > > > >> > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne > > > > > wrote: >> > > > > > > +1 (binding) >> > > > > > > >> > > > > > > Was able to verify hashes, build with contrib-check, and start up >> > > > > > application. Performed some basic functionality tests and all >> > worked as >> > > > > > expected. >> > > > > > > >> > > > > > > Thanks! >> > > > > > > -Mark >> > > > > > > >> > > > > > > >> > > > > > > > On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma < >> > > > tasan...@yahoo-corp.jp >> > > > > > >> > > > > > wrote: >> > > > > > > > >> > > > > > > > Thanks for all your efforts, Joe. >> > > > > > > > >> > > > > > > > I have one question. The version of the generated package is >> > > > > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok, >> > > > > >
Re: [VOTE] Release Apache NiFi 1.6.0
-1 Ran through the usual release helper stuff, but it seems like the fingerprint issue is going to cause problems, so not sure how useful putting 1.6.0 out there will be if 1.6.1 will have to be turned around immediately. Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the tag got pushed. -joey On Mar 24, 2018, 12:38 AM -0500, Pierre Villard, wrote: > -1 (binding) > > I confirm the issue mentioned by Bryan. That's actually what Matt and I > experienced when trying the PR about the S2S Metrics Reporting task [1]. I > thought it was due to my change but it appears it's not the case. > > [1] https://github.com/apache/nifi/pull/2575 > > 2018-03-23 22:53 GMT+01:00 Bryan Bende : > > > After voting I happened to be using the RC to test something else and > > came across a bug that I think warrants changing my vote to a -1. > > > > I created a simple two node cluster and made a standard convert record > > flow. When I ran the flow I got a schema not found exception, so I > > used the debugger which showed AvroSchemaRegistry had no schemas, even > > though there was one in the UI. > > > > I then used the debugger to make sure the onPropertyModified was > > getting when a schema was added, and it was which meant some after > > adding the schema but before running the flow, it was being removed. > > > > As far as I can tell, the issue is related to changes introduced in > > NIFI-4864... the intent here was for components with property > > descriptors that have "dynamically modifies classpath" to be able to > > smartly reload when they are started based on knowing if more > > classpath resources were added. > > > > The issue is that for components that don't have any property > > descriptors like this, they have a null fingerprint, and before > > starting it compares null to the fingerprint of empty string, and > > decides to reload [2]. > > > > I think the fix should be fairly easy to just short-circuit at the > > beginning of that method and return immediately if > > additionalResourcesFingerprint is null, but will have to do some > > testing. > > > > [1] https://issues.apache.org/jira/browse/NIFI-4864 > > [2] https://github.com/apache/nifi/blob/master/nifi-nar- > > bundles/nifi-framework-bundle/nifi-framework/nifi-framework- > > core-api/src/main/java/org/apache/nifi/controller/ > > AbstractConfiguredComponent.java#L313-L314 > > > > > > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman > wrote: > > > +1 (binding) Release this package as nifi-1.6.0 > > > > > > Executed the release helper and verified new granular restrictions with > > > regards to flow versioning. > > > > > > Thanks for RMing Joe! > > > > > > Matt > > > > > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser > wrote: > > > > > > > +1 (binding) > > > > > > > > Ran through release helper to verify the release and run NiFi on Ubuntu > > > > 16.04. It worked as expected with no new comments to add. > > > > > > > > -- Mike > > > > > > > > > > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > - Ran through release helper > > > > > - Setup secure NiFi and verified a test flow > > > > > > > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > - Ran through release helper and everything checked out > > > > > > - Verified some test flows with the restricted components + keytab > > CS > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne > > > > wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > > > Was able to verify hashes, build with contrib-check, and start up > > > > > > application. Performed some basic functionality tests and all > > worked as > > > > > > expected. > > > > > > > > > > > > > > Thanks! > > > > > > > -Mark > > > > > > > > > > > > > > > > > > > > > > On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma < > > > > tasan...@yahoo-corp.jp > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > Thanks for all your efforts, Joe. > > > > > > > > > > > > > > > > I have one question. The version of the generated package is > > > > > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok, > > > > > > +1(non-binding). > > > > > > > > > > > > > > > > - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm" > > > > > > > > - Started secure cluster mode > > > > > > > > - Verified sample dataflows work fine > > > > > > > > - Verified the whitelist feature(NIFI-4761) works fine > > > > > > > > > > > > > > > > -Takanobu Asanuma > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Joe Witt [mailto:joew...@apache.org] > > > > > > > > Sent: Friday, March 23, 2018 1:12 AM > > > > > > > > To: dev@nifi.apache.org > > > > > > > > Subject: [VOTE] Release Apache NiFi