Re: Handling of newbie-oriented fixes
I just finished basic edition but my connection is veeery slow right now so I'll upload it until tomorrow morning I incorporated the ASCII function map and completely linearized the document I need to check the last part about nsh and such but the rest of the document is exact and up to date El mié, 6 ene 2021 a las 2:23, Brennan Ashton () escribió: > On Tue, Jan 5, 2021 at 2:46 PM Grr wrote: > > > > Thank you for your response. I'll check that > I assume that this is your github user https://github.com/sigdl If > that is the case > you can create your PR against the Apache repo with this link: > https://github.com/apache/incubator-nuttx/compare/master...sigdl:master > > > > > I also offered a function map to add to your > NuttX+Initialization+Sequence > > document > > > > Please check > https://www.mail-archive.com/dev@nuttx.apache.org/msg05417.html > > and let me know if it's useful or how can it be improved to be so > > Sorry I had forgotten to respond, eventually I think most of that Wiki > will make its way into > the documentation over at nuttx.apache.org/docs/latest but that will > take quite some > time, so keeping the wiki up to date would be most welcome. If you create > an > account and send me the username I will be happy to give you > permissions to edit that > page as you think it makes sense. > > --Brennan >
Re: Handling of newbie-oriented fixes
On Tue, Jan 5, 2021 at 2:46 PM Grr wrote: > > Thank you for your response. I'll check that I assume that this is your github user https://github.com/sigdl If that is the case you can create your PR against the Apache repo with this link: https://github.com/apache/incubator-nuttx/compare/master...sigdl:master > > I also offered a function map to add to your NuttX+Initialization+Sequence > document > > Please check https://www.mail-archive.com/dev@nuttx.apache.org/msg05417.html > and let me know if it's useful or how can it be improved to be so Sorry I had forgotten to respond, eventually I think most of that Wiki will make its way into the documentation over at nuttx.apache.org/docs/latest but that will take quite some time, so keeping the wiki up to date would be most welcome. If you create an account and send me the username I will be happy to give you permissions to edit that page as you think it makes sense. --Brennan
Re: Handling of newbie-oriented fixes
Thank you for your response. I'll check that I also offered a function map to add to your NuttX+Initialization+Sequence document Please check https://www.mail-archive.com/dev@nuttx.apache.org/msg05417.html and let me know if it's useful or how can it be improved to be so TIA Grr El mar, 5 ene 2021 a las 16:31, Brennan Ashton () escribió: > You can still open the PR in GitHub against the NuttX repo (with the extra > stuff from Peter's repo) , there is a option to select a different repo, > and we can either cherry pick your change for you or walk you through how > to do that. > Feel free to tag me in it @btashton > > Thanks for contributing! > > --Brennan > > On Tue, Jan 5, 2021, 1:13 PM Grr wrote: > > > I have several commits with fixes related to newbie issues > > > > -Avoid compilation crash due to enabling CONFIG_NET without board > > networking support > > > > -Avoid compilation crash due to CONFIG_NET_ICMP_SOCKET missing > > NET_READAHEAD > > > > and so on > > > > Problem is I can't make a PR on incubator-nuttx because my fork is not > from > > it but from Peter van der Perk's fork > > > > What would be the best way to handle this without bothering Peter to > > process every one of my fixes? > > > > TIA > > > > Grr > > >
Re: Handling of newbie-oriented fixes
You can still open the PR in GitHub against the NuttX repo (with the extra stuff from Peter's repo) , there is a option to select a different repo, and we can either cherry pick your change for you or walk you through how to do that. Feel free to tag me in it @btashton Thanks for contributing! --Brennan On Tue, Jan 5, 2021, 1:13 PM Grr wrote: > I have several commits with fixes related to newbie issues > > -Avoid compilation crash due to enabling CONFIG_NET without board > networking support > > -Avoid compilation crash due to CONFIG_NET_ICMP_SOCKET missing > NET_READAHEAD > > and so on > > Problem is I can't make a PR on incubator-nuttx because my fork is not from > it but from Peter van der Perk's fork > > What would be the best way to handle this without bothering Peter to > process every one of my fixes? > > TIA > > Grr >
Re: Handling of newbie-oriented fixes
Just fork again from main nuttx repository, to satisfy github. Then a) manually put yout changes back and commit, or b) add your current fork as additional remote, and get your commits from there. If fork doesn't have changes, you can pull it. Otherwise you might try to cherry pick. On Tue, 5 Jan 2021, 22:14 Grr, wrote: > I have several commits with fixes related to newbie issues > > -Avoid compilation crash due to enabling CONFIG_NET without board > networking support > > -Avoid compilation crash due to CONFIG_NET_ICMP_SOCKET missing > NET_READAHEAD > > and so on > > Problem is I can't make a PR on incubator-nuttx because my fork is not from > it but from Peter van der Perk's fork > > What would be the best way to handle this without bothering Peter to > process every one of my fixes? > > TIA > > Grr >
