[jira] Updated: (OFBIZ-1482) Implement an automatic GL posting service for sales invoices
[
https://issues.apache.org/jira/browse/OFBIZ-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shubham Goyal updated OFBIZ-1482:
-
Attachment: GLPostingServiceForSalesInvoice.patch
An automatic GL posting service for sales invoices.
Implement an automatic GL posting service for sales invoices
Key: OFBIZ-1482
URL: https://issues.apache.org/jira/browse/OFBIZ-1482
Project: OFBiz
Issue Type: Sub-task
Components: accounting
Affects Versions: SVN trunk
Reporter: Jacopo Cappellato
Attachments: GLPostingServiceForSalesInvoice.patch
Name of the service: createAcctgTransForSalesInvoice or similar
Service definition:
service name=createAcctgTransForSalesInvoice engine=simple
auth=true
location=org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
invoke=createAcctgTransForSalesInvoice
descriptionCreate an accounting transaction for a sales
invoice/description
attribute name=invoiceId type=String mode=IN optional=false/
attribute name=acctgTransId type=String mode=OUT
optional=true/
/service
The eca rule will be:
eca service=setInvoiceStatus event=commit
condition field-name=invoiceId operator=is-not-empty/
condition field-name=statusId operator=equals value=INVOICE_READY/
condition field-name=oldStatusId operator=not-equals
value=INVOICE_READY/
condition field-name=oldStatusId operator=not-equals
value=INVOICE_PAID/
action service=createAcctgTransForSalesInvoice mode=sync/
/eca
This is the general description: this service will call the
createAcctgTransAndEntries with the following input parameters:
a) acctgTransTypeId=SALES_INVOICE
b) partyId = invoice.partyId
c) roleTypeId = BILL_TO_CUSTOMER
d) invoiceId = invoice.invoiceId
e) acctgTransEntries: a list composed by the following AcctgTransEntry
elements:
e1) one element for each of the InvoiceItems; here is the content of each of
these elements:
-- debitCreditFlag = C
-- organizationPartyId = invoice.partyIdFrom
-- productId = invoiceItem.productId
-- glAccountTypeId = invoiceItem.invoiceItemTypeId
-- glAccountId = invoiceItem.overrideGlAccountId
-- origAmount = invoiceItem.quantity * invoiceItem.amount (NOTE: if quantity
is not set, then default to 1)
-- origCurrencyUomId = invoice.currencyUomId
-- if invoiceItem.taxAuthPartyId is-not-empty then {partyId =
invoiceItem.taxAuthPartyId and roleTypeId = TAX_AUTHORITY}
f) one element for the invoice total (the sum of all the items'
amount*quantity):
-- debitCreditFlag = D
-- organizationPartyId = invoice.partyIdFrom
-- glAccountTypeId = ACCOUNTS_RECEIVABLE
-- origAmount = the sum of all the items' amount*quantity
-- origCurrencyUomId = invoice.currencyUomId
-- partyId = invoice.partyId
-- roleTypeId = BILL_TO_CUSTOMER
Some more details about the logic:
1) get the Invoice record
2) if Invoice.invoiceTypeId != SALES_INVOICE return
3) get the InvoiceItems and iterate over them to create the entries (e) and
compute the total for the entry for the total (f)
4) call the createAcctgTransAndEntries service
Add information on the wiki page: http://docs.ofbiz.org/x/Qw0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1487) Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transactio
Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction Key: OFBIZ-1487 URL: https://issues.apache.org/jira/browse/OFBIZ-1487 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Create a service to clone an existing accounting transaction and its entries (AcctgTrans and AcctgTransEntry), with an optional parameter to revert the original transaction. Proposed service name: copyAcctgTransAndEntries IN parameters: fromAcctgTransId (mandatory), revert (optional) OUT parameters: acctgTransId The service simply clones the AcctgTrans record into a new identical one (if possible, use the createAcctgTrans service) with the exception of the following fields: transactionDate: do not set, so that it will be automatically set to now isPosted: set to N postedDate: do not set scheduledPostedDate: do not set createdByUserLogin: do not set lastModifiedByUserLogin: do not set and also clones all the AcctgTransEntry (if possible, use the createAcctgTransEntry service), with the exception of the following fields: reconcileStatusId: do not set For each entry, if the parameters.revert field is set to Y, flip the debitCreditFlag from C to D and vice versa. Add two new links to the Edit Accounting Transaction screen: duplicate accounting transaction and revert accounting transaction that both call the above service (the latter calls the service with revert=Y). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1485) UtilProperties - The Next Generation
[ https://issues.apache.org/jira/browse/OFBIZ-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548170 ] Jonathon Wong commented on OFBIZ-1485: -- Now that the code was reduced down to two caches of FlexibleProperties objects, I started to look at the FlexibleProperties class to see if there was a way to convert it to a Javalution FastMap. So, I traced through the UtilProperties-to-FlexibleProperties code and I determined that the FlexibleProperties class contributes nothing to the UtilProperties class. So, I converted all references to FlexibleProperties to plain Maps, and used the Javalution FastMap for new instances. A few points here. FlexibleProperties does contribute something. Look at the methods in there. A Map is different from a Properties object, less restrictive. In this case, less restrictive is not good. In fact, Properties wraps around Hashtable mainly to prevent non-strings from being inserted into the underlying Map. You called for suggestions to use the new powerful FastMap while avoiding breaking legacy codes that may expect methods getProperties(...) to return Properties. I suggested that FlexibleProperties class internally deals with a FastMap object, while also overriding all the methods in the Properties class. That way, you get absolutely zero need for change propagation. All legacy codes continue to work; FastMap is now used. If so inclined, you may want to create a new Properties subclass called FastProperties. I don't think we should make methods getProperties(...) return anything other than Properties. As mentioned above, a Map is less restrictive and does not confine entered values to just properties (which are usually just strings). UtilProperties - The Next Generation Key: OFBIZ-1485 URL: https://issues.apache.org/jira/browse/OFBIZ-1485 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: props_tng.patch Improve the UtilProperties class. Details in comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1473) Implement an automatic GL posting service triggered when inventory is issued to a work effort
[ https://issues.apache.org/jira/browse/OFBIZ-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-1473: --- Assignee: Anil K Patel Implement an automatic GL posting service triggered when inventory is issued to a work effort - Key: OFBIZ-1473 URL: https://issues.apache.org/jira/browse/OFBIZ-1473 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Assignee: Anil K Patel Attachments: GL posting service.patch, GlPostingService.patch Name of the service: createAcctgTransForWorkEffortIssuance or similar Service definition: service name=createAcctgTransForWorkEffortIssuance engine=simple auth=true location=org/ofbiz/accounting/ledger/GeneralLedgerServices.xml invoke=createAcctgTransForWorkEffortIssuance descriptionCreate an accounting transaction for inventory that is issued to a work effort (Type: INVENTORY D: RAWMAT_INVENTORY, C: WIP_INVENTORY)/description attribute name=workEffortId type=String mode=IN optional=false/ attribute name=inventoryItemId type=String mode=IN optional=false/ attribute name=acctgTransId type=String mode=OUT optional=true/ /service Use as a template the service createAcctgTransForSalesShipmentIssuance. The new service will be very similar, with the following differences: 1) replace shipmentId with workEffortId 2) do not set partyId and roleTypeId 3) the Credit glAccountTypeId is WIP_INVENTORY (and not COGS_ACCOUNT) 4) the Debit glAccountTypeId is RAWMAT_INVENTORY 5) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT) The seca will be: eca service=assignInventoryToWorkEffort event=commit action service=createAcctgTransForWorkEffortIssuance mode=sync/ /eca -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1473) Implement an automatic GL posting service triggered when inventory is issued to a work effort
[ https://issues.apache.org/jira/browse/OFBIZ-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-1473. --- Resolution: Fixed Thanks Sachin Chourasia and others for patch, its in rev#600844 Implement an automatic GL posting service triggered when inventory is issued to a work effort - Key: OFBIZ-1473 URL: https://issues.apache.org/jira/browse/OFBIZ-1473 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Assignee: Anil K Patel Attachments: GL posting service.patch, GlPostingService.patch Name of the service: createAcctgTransForWorkEffortIssuance or similar Service definition: service name=createAcctgTransForWorkEffortIssuance engine=simple auth=true location=org/ofbiz/accounting/ledger/GeneralLedgerServices.xml invoke=createAcctgTransForWorkEffortIssuance descriptionCreate an accounting transaction for inventory that is issued to a work effort (Type: INVENTORY D: RAWMAT_INVENTORY, C: WIP_INVENTORY)/description attribute name=workEffortId type=String mode=IN optional=false/ attribute name=inventoryItemId type=String mode=IN optional=false/ attribute name=acctgTransId type=String mode=OUT optional=true/ /service Use as a template the service createAcctgTransForSalesShipmentIssuance. The new service will be very similar, with the following differences: 1) replace shipmentId with workEffortId 2) do not set partyId and roleTypeId 3) the Credit glAccountTypeId is WIP_INVENTORY (and not COGS_ACCOUNT) 4) the Debit glAccountTypeId is RAWMAT_INVENTORY 5) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT) The seca will be: eca service=assignInventoryToWorkEffort event=commit action service=createAcctgTransForWorkEffortIssuance mode=sync/ /eca -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1474) Enhance the service described in OFBIZ-1473 to handle in a special way the workEffort that are part of a production run.
[ https://issues.apache.org/jira/browse/OFBIZ-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-1474. --- Resolution: Fixed Resolved with Jira issue 1473 Enhance the service described in OFBIZ-1473 to handle in a special way the workEffort that are part of a production run. Key: OFBIZ-1474 URL: https://issues.apache.org/jira/browse/OFBIZ-1474 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Assignee: Anil K Patel -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1453: - Attachment: aggregated_full_for_review.patch store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548189 ] Bilgin Ibryam commented on OFBIZ-1453: -- Hi all, this is a full patch ready for review and testing. It allows to save product configuration and restore it later. Here is the stating discussion for it http://www.nabble.com/Enhance-configurable-%28AGGREGATED%29-products-tf4888953.html I added new configId field to OrderItem, QuoteItem, CustRequestItem, ShoppingListItem and CartAbandonedLine entities. These are all the places, where products can be added (configurable products could be also added, but w/o saving the configuration, they become useless). I added also a new field called configId to ProductConfigWrapper class. This field will stores the persisted configuration Id. How it works: When user adds the configured product to shopping cart, the configuration is persisted and ProductConfigWrapper.configId gets the configId. Then the configurable product(and its configId) can be added to shopping list, Cust Request, Quote or to CartAbandonedLine entity when session times out, or to orderItem, when order is created. Later, when adding item back to cart (from shopping list, quote, cust request, existing order) the ProductConfigWrapper objct is restored through configId field. This allows us to edit orders containing configurable products (right now it is not possible!), to create new order from existing one, to create Cust request, then Quote from Cust request... Future ideas for improvements: 1) When saving the ProductConfigWrapper, it is possible first to check for existing saved configurations, and if they are the same, to return its configId instead of creating new records with the same configuration... 2) It is possible to add products to shopping list directly even w/o shopping cart (for example from party manager screens). There ProductConfigWrapper is not created, and we can create and store the default product configuration. This is dependent from OFBIZ-1393 I'd love to get your feedback. Regards, Bilgin Ibryam store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548195 ] Marco Risaliti commented on OFBIZ-1116: --- Also I have tried to change clientAuth to false instead of want in the catalina https connector config and now Safari will connect with no problems. So why Joe don't we close this issue or put it as a minor bug not to a major bug. Thanks Marco Problem making SSL connection to admin apps with Safari --- Key: OFBIZ-1116 URL: https://issues.apache.org/jira/browse/OFBIZ-1116 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Joe Eckard I can't seem to connect to any admin apps via SSL. The error message from Safari is: Safari can't open the page https://localhost:8443/webtools/control/main; because it couldn't establish a secure connection to the server localhost. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL
[
https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548193
]
Bilgin Ibryam commented on OFBIZ-1388:
--
how about adding it to the jscript?
I am not sure that @ofbizUrl will work in js files, didnot test it. Did you
test it ?
Also it will make all js files depend on @ofbizUrl. However i donot see a
problem in it (for now).
and why it works once but not after this particular situation.
If you check ControlServlet, you will see why
You can check these lines
String rname = ;
if (request.getPathInfo() != null) {
rname = request.getPathInfo().substring(1);
}
if (rname.indexOf('/') 0) {
rname = rname.substring(0, rname.indexOf('/'));
}
Bug in lookup windows URL
-
Key: OFBIZ-1388
URL: https://issues.apache.org/jira/browse/OFBIZ-1388
Project: OFBiz
Issue Type: Bug
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Attachments: lookup.patch
Hi all,
I just noticed a bug in lookup windows url generation.
One way to generate the bug is this:
Go to order manager and add to cart configurable pc (PC001). You can do it
browsing Configurable PCs category on the left corner.
After you add PC001 to cart, you will be in order entry screen and your URL
should look like this:
https://localhost:8443/ordermgr/control/additem/product
At this stage if you try to add another product AND click on the product
lookup button, the screen in the lookup window will be orderentry screen but
not the product lookup screen!
Popup screen will not generate LookupProduct request as it is expected,
instead the request is additem/LookupProduct and then ControlServlet
transform it to additem request. You can see that additem is coming from the
URL we mentioned /control/additem/product
Any ideas how to fix this bug?
Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548207 ] Jacopo Cappellato commented on OFBIZ-1453: -- Bilgin, it's great to see implemented this part of the system. I yet didn't have a chance to review your patch (I will do as soon as I have a free moment) but I think that what you did is interesting. My only and main concern is that there could be possibly (several) other places where we would need the configId. For example, what about inventory? And what about inventory reservation routines, picking lists, shipments, returns, work efforts (e.g. production runs)? My fear is that the configId field could be required potentially everywhere we have a productId. That is why I also suggested to consider the approach of creating a new product when a new configuration for an aggregate product is needed. By the way, also this approach has some cons... so I still don't have a strong opinion on the best solution. Maybe what you have implemented is fine. I'd love to get feedback from others. Jacopo store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1482) Implement an automatic GL posting service for sales invoices
[
https://issues.apache.org/jira/browse/OFBIZ-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548229
]
Jacopo Cappellato commented on OFBIZ-1482:
--
Wow... I've just quickly reviewed this patch (not time at the moment) but it
seems pretty good.
One funny thing that I've immediately noticed is that the service
implementation, well written by Shubham using Minilang, is not (much) longer
than the service description that I have written in this Jira task!
This is a great point in favor of Minilang indeed.
Jacopo
Implement an automatic GL posting service for sales invoices
Key: OFBIZ-1482
URL: https://issues.apache.org/jira/browse/OFBIZ-1482
Project: OFBiz
Issue Type: Sub-task
Components: accounting
Affects Versions: SVN trunk
Reporter: Jacopo Cappellato
Attachments: GLPostingServiceForSalesInvoice.patch
Name of the service: createAcctgTransForSalesInvoice or similar
Service definition:
service name=createAcctgTransForSalesInvoice engine=simple
auth=true
location=org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
invoke=createAcctgTransForSalesInvoice
descriptionCreate an accounting transaction for a sales
invoice/description
attribute name=invoiceId type=String mode=IN optional=false/
attribute name=acctgTransId type=String mode=OUT
optional=true/
/service
The eca rule will be:
eca service=setInvoiceStatus event=commit
condition field-name=invoiceId operator=is-not-empty/
condition field-name=statusId operator=equals value=INVOICE_READY/
condition field-name=oldStatusId operator=not-equals
value=INVOICE_READY/
condition field-name=oldStatusId operator=not-equals
value=INVOICE_PAID/
action service=createAcctgTransForSalesInvoice mode=sync/
/eca
This is the general description: this service will call the
createAcctgTransAndEntries with the following input parameters:
a) acctgTransTypeId=SALES_INVOICE
b) partyId = invoice.partyId
c) roleTypeId = BILL_TO_CUSTOMER
d) invoiceId = invoice.invoiceId
e) acctgTransEntries: a list composed by the following AcctgTransEntry
elements:
e1) one element for each of the InvoiceItems; here is the content of each of
these elements:
-- debitCreditFlag = C
-- organizationPartyId = invoice.partyIdFrom
-- productId = invoiceItem.productId
-- glAccountTypeId = invoiceItem.invoiceItemTypeId
-- glAccountId = invoiceItem.overrideGlAccountId
-- origAmount = invoiceItem.quantity * invoiceItem.amount (NOTE: if quantity
is not set, then default to 1)
-- origCurrencyUomId = invoice.currencyUomId
-- if invoiceItem.taxAuthPartyId is-not-empty then {partyId =
invoiceItem.taxAuthPartyId and roleTypeId = TAX_AUTHORITY}
f) one element for the invoice total (the sum of all the items'
amount*quantity):
-- debitCreditFlag = D
-- organizationPartyId = invoice.partyIdFrom
-- glAccountTypeId = ACCOUNTS_RECEIVABLE
-- origAmount = the sum of all the items' amount*quantity
-- origCurrencyUomId = invoice.currencyUomId
-- partyId = invoice.partyId
-- roleTypeId = BILL_TO_CUSTOMER
Some more details about the logic:
1) get the Invoice record
2) if Invoice.invoiceTypeId != SALES_INVOICE return
3) get the InvoiceItems and iterate over them to create the entries (e) and
compute the total for the entry for the total (f)
4) call the createAcctgTransAndEntries service
Add information on the wiki page: http://docs.ofbiz.org/x/Qw0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1448) Add links to the relevant fields of the list forms for accounting transactions and accounting transactions entries
[ https://issues.apache.org/jira/browse/OFBIZ-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-1448. --- Resolution: Fixed Sachin, thanks for providing improvements. your patch is in rev#600848 Add links to the relevant fields of the list forms for accounting transactions and accounting transactions entries -- Key: OFBIZ-1448 URL: https://issues.apache.org/jira/browse/OFBIZ-1448 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Assignee: Anil K Patel Attachments: [EMAIL PROTECTED], [EMAIL PROTECTED] Add links to the relevant fields (payments, work efforts, invoices, shipments etc...) of the list forms that appear when you perform a research for accounting transactions and accounting transactions entries The two forms are in the following two screens: AccountingGeneral LedgerAccountingAccounting Transactions and AccountingGeneral LedgerAccountingAccounting Transactions Entries The links should open the corresponding detail screens for payments, invoices, shipments, work efforts etc... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1436) New entity, CRUD services and screen to map, for an organization, a productCategoryId/glAccountTypeId pair to a glAccountId
[ https://issues.apache.org/jira/browse/OFBIZ-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-1436. --- Resolution: Fixed Ashish thanks for providing fix. Your patch is in rev#600909 New entity, CRUD services and screen to map, for an organization, a productCategoryId/glAccountTypeId pair to a glAccountId --- Key: OFBIZ-1436 URL: https://issues.apache.org/jira/browse/OFBIZ-1436 Project: OFBiz Issue Type: Sub-task Components: product Reporter: Jacopo Cappellato Assignee: Anil K Patel Attachments: ProductCategoryGlAccount_CRUD_Services.patch, RemoveWarningMessage.patch Define a new entity (ProductCategoryGlAccount) to map a productCategoryId and glAccountTypeId to a glAccountId. The entity will be similar to ProductGlAccount. Implement CRUD services. New screen to manage the ProductCategoryGlAccount information of an Organization: the screen will reside in the AccountingGeneral LedgerSetup menu and will show a (searchable?) list of all the ProductCategoryGlAccount records related to the Organization in the context (organizationPartyId). At the bottom of the screen there will be an Add/Edit form. In the list there will be, next to each item, a remove link. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r600881 - /ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java
Scott,
A quick question about you last post around tests. Should we merge them with
release4.0 ?
Jacques
De : [EMAIL PROTECTED]
Author: lektran
Date: Tue Dec 4 03:21:13 2007
New Revision: 600881
URL: http://svn.apache.org/viewvc?rev=600881view=rev
Log:
Couple of fixes to FinAccountTests:
1. There's no such type as a BALANCE_ACCOUNT so I switched to a BANK_ACCOUNT
2. You can't use instance variables in a test because each case is run as a
new object
The test now passes
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java?rev=600881r1=600880r2=600881view=diff
==
---
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java
(original)
+++
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/test/FinAccountTests.java
Tue Dec 4 03:21:13 2007
@@ -24,6 +24,7 @@
import org.ofbiz.entity.GenericValue;
import org.ofbiz.service.GenericDispatcher;
import org.ofbiz.service.LocalDispatcher;
+import org.ofbiz.service.ModelService;
import org.ofbiz.base.util.UtilMisc;
import java.util.Map;
@@ -37,8 +38,6 @@
protected LocalDispatcher dispatcher = null;
protected GenericValue userLogin = null;
-protected String finAccountId = null;
-protected double balance = 0.00;
public FinAccountTests(String name) {
super(name);
@@ -55,32 +54,32 @@
public void testCreateFinAccount() throws Exception {
Map ctx = FastMap.newInstance();
+ctx.put(finAccountId, TESTACCOUNT1);
ctx.put(finAccountName, Test Financial Account);
-ctx.put(finAccountTypeId, BALANCE_ACCOUNT);
+ctx.put(finAccountTypeId, BANK_ACCOUNT);
ctx.put(userLogin, userLogin);
Map resp = dispatcher.runSync(createFinAccount, ctx);
-finAccountId = (String) resp.get(finAccountId);
-assertNotNull(finAccountId);
+assertEquals(Service result success, ModelService.RESPOND_SUCCESS,
resp.get(ModelService.RESPONSE_MESSAGE));
}
public void testDeposit() throws Exception {
Map ctx = FastMap.newInstance();
-ctx.put(finAccountId, finAccountId);
+ctx.put(finAccountId, TESTACCOUNT1);
ctx.put(amount, new Double(100.00));
ctx.put(userLogin, userLogin);
Map resp = dispatcher.runSync(finAccountDeposit, ctx);
-balance = ((Double) resp.get(balance)).doubleValue();
+Double balance = ((Double) resp.get(balance)).doubleValue();
assertEquals(balance, 100.00, 0.0);
}
public void testWithdraw() throws Exception {
Map ctx = FastMap.newInstance();
-ctx.put(finAccountId, finAccountId);
+ctx.put(finAccountId, TESTACCOUNT1);
ctx.put(amount, new Double(50.00));
ctx.put(userLogin, userLogin);
Map resp = dispatcher.runSync(finAccountWithdraw, ctx);
Double previousBalance = (Double) resp.get(previousBalance);
-balance = ((Double) resp.get(balance)).doubleValue();
+Double balance = ((Double) resp.get(balance)).doubleValue();
assertEquals((balance + 50.00), previousBalance.doubleValue(), 0.0);
}
}
[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548258 ] Bilgin Ibryam commented on OFBIZ-1453: -- Jacopo, I was thinking that ProductConfigWrapper is needed/used only in order creation routinnes and once the order is created, the production run gets the configuration and issues the needed components for this configuration from inventory. I didnot imagine that configId would be required also in other places. For now i would like to know is the current patch a right direction to go... All suggestion are greatly appreciated. store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1273) fin account unit tests fail
[ https://issues.apache.org/jira/browse/OFBIZ-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548270 ] Marco Risaliti commented on OFBIZ-1273: --- I have tested and this bug has been solved today with rev. 600881 by lektran, so I think that this issue can be closed. Thanks Marco fin account unit tests fail --- Key: OFBIZ-1273 URL: https://issues.apache.org/jira/browse/OFBIZ-1273 Project: OFBiz Issue Type: Bug Reporter: Si Chen Could somebody please do an $ ant run-tests and see if they also get this: [java] org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:INSERT INTO public.FIN_ACCOUNT (FIN_ACCOUNT_ID, FIN_ACCOUNT_TYPE_ID, FIN_ACCOUNT_NAME, FIN_ACCOUNT_CODE, FIN_ACCOUNT_PIN, CURRENCY_UOM_ID, ORGANIZATION_PARTY_ID, OWNER_PARTY_ID, POST_TO_GL_ACCOUNT_ID, FROM_DATE, THRU_DATE, IS_FROZEN, IS_REFUNDABLE, REPLENISH_PAYMENT_ID, REPLENISH_LEVEL, ACTUAL_BALANCE, AVAILABLE_BALANCE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: insert or update on table fin_account violates foreign key constraint finacct_type [java] Detail: Key (fin_account_type_id)=(BALANCE_ACCOUNT) is not present in table fin_account_type.) [java] org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:433) [java] org.ofbiz.entity.datasource.GenericDAO.singleInsert(GenericDAO.java:169) [java] org.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:116) [java] org.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:68) [java] org.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:562) [java] org.ofbiz.minilang.method.entityops.CreateValue.exec(CreateValue.java:67) [java] org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:934) [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:571) [java] org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:108) [java] org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:90) [java] org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79) [java] org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:54) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:339) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:214) [java] org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:139) [java] org.ofbiz.accounting.test.FinAccountTests.testCreateFinAccount(FinAccountTests.java:64) [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testDeposit(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountDeposit.finAccountId] [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testWithdraw(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountWithdraw.finAccountId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1273) fin account unit tests fail
[ https://issues.apache.org/jira/browse/OFBIZ-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1273. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Scott Gray Closed on behalf of Marco Risaliti. I have asked Scott to know if we should back port to release4.0, we will see... fin account unit tests fail --- Key: OFBIZ-1273 URL: https://issues.apache.org/jira/browse/OFBIZ-1273 Project: OFBiz Issue Type: Bug Reporter: Si Chen Assignee: Scott Gray Fix For: SVN trunk Could somebody please do an $ ant run-tests and see if they also get this: [java] org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:INSERT INTO public.FIN_ACCOUNT (FIN_ACCOUNT_ID, FIN_ACCOUNT_TYPE_ID, FIN_ACCOUNT_NAME, FIN_ACCOUNT_CODE, FIN_ACCOUNT_PIN, CURRENCY_UOM_ID, ORGANIZATION_PARTY_ID, OWNER_PARTY_ID, POST_TO_GL_ACCOUNT_ID, FROM_DATE, THRU_DATE, IS_FROZEN, IS_REFUNDABLE, REPLENISH_PAYMENT_ID, REPLENISH_LEVEL, ACTUAL_BALANCE, AVAILABLE_BALANCE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: insert or update on table fin_account violates foreign key constraint finacct_type [java] Detail: Key (fin_account_type_id)=(BALANCE_ACCOUNT) is not present in table fin_account_type.) [java] org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:433) [java] org.ofbiz.entity.datasource.GenericDAO.singleInsert(GenericDAO.java:169) [java] org.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:116) [java] org.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:68) [java] org.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:562) [java] org.ofbiz.minilang.method.entityops.CreateValue.exec(CreateValue.java:67) [java] org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:934) [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:571) [java] org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:108) [java] org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:90) [java] org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79) [java] org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:54) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:339) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:214) [java] org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:139) [java] org.ofbiz.accounting.test.FinAccountTests.testCreateFinAccount(FinAccountTests.java:64) [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testDeposit(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountDeposit.finAccountId] [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testWithdraw(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountWithdraw.finAccountId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1273) fin account unit tests fail
[ https://issues.apache.org/jira/browse/OFBIZ-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548281 ] Marco Risaliti commented on OFBIZ-1273: --- This is the results in test-results/accountingtests.xml ?xml version=1.0 encoding=UTF-8 ? testsuite errors=0 failures=0 hostname=MRW2KRISALITM name=accountingtests tests=0 time=6.281 timestamp=2007-12-04T15:42:45 properties / testcase classname=org.ofbiz.accounting.test.FinAccountTests name=testCreateFinAccount time=1.063 / testcase classname=org.ofbiz.accounting.test.FinAccountTests name=testDeposit time=4.422 / testcase classname=org.ofbiz.accounting.test.FinAccountTests name=testWithdraw time=0.781 / /testsuite fin account unit tests fail --- Key: OFBIZ-1273 URL: https://issues.apache.org/jira/browse/OFBIZ-1273 Project: OFBiz Issue Type: Bug Reporter: Si Chen Assignee: Scott Gray Fix For: SVN trunk Could somebody please do an $ ant run-tests and see if they also get this: [java] org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:INSERT INTO public.FIN_ACCOUNT (FIN_ACCOUNT_ID, FIN_ACCOUNT_TYPE_ID, FIN_ACCOUNT_NAME, FIN_ACCOUNT_CODE, FIN_ACCOUNT_PIN, CURRENCY_UOM_ID, ORGANIZATION_PARTY_ID, OWNER_PARTY_ID, POST_TO_GL_ACCOUNT_ID, FROM_DATE, THRU_DATE, IS_FROZEN, IS_REFUNDABLE, REPLENISH_PAYMENT_ID, REPLENISH_LEVEL, ACTUAL_BALANCE, AVAILABLE_BALANCE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: insert or update on table fin_account violates foreign key constraint finacct_type [java] Detail: Key (fin_account_type_id)=(BALANCE_ACCOUNT) is not present in table fin_account_type.) [java] org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:433) [java] org.ofbiz.entity.datasource.GenericDAO.singleInsert(GenericDAO.java:169) [java] org.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:116) [java] org.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:68) [java] org.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:562) [java] org.ofbiz.minilang.method.entityops.CreateValue.exec(CreateValue.java:67) [java] org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:934) [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:571) [java] org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:108) [java] org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:90) [java] org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79) [java] org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:54) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:339) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:214) [java] org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:139) [java] org.ofbiz.accounting.test.FinAccountTests.testCreateFinAccount(FinAccountTests.java:64) [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testDeposit(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountDeposit.finAccountId] [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testWithdraw(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountWithdraw.finAccountId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1485) UtilProperties - The Next Generation
[ https://issues.apache.org/jira/browse/OFBIZ-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548282 ] Adrian Crum commented on OFBIZ-1485: Jonathon, Thank you for taking the time to review the code. If you look closely at the existing code, FlexibleProperties contributes nothing to UtilProperties. It may have additional methods, but they aren't being used anywhere. UtilProperties treats FlexibleProperties as a generic Properties object. I understand a Map is less restrictive than a Properties object - that's why the methods that returned Properties objects still do so. In addition, we have new methods that return Maps - and those Maps use Generics to enforce the Key is String and Value is String constraints. Building a custom Properties class around a FastMap is an interesting idea, but I don't think it's necessary. If a piece of code MUST have a Properties object, one can be constructed from a FastMap by using the Properties.putAll(...) method. UtilProperties - The Next Generation Key: OFBIZ-1485 URL: https://issues.apache.org/jira/browse/OFBIZ-1485 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: props_tng.patch Improve the UtilProperties class. Details in comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1472) Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
[ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548298 ] Pranay Pandey commented on OFBIZ-1472: -- Ashish, The template service given in this task is createAcctgTransForSalesShipmentIssuance, and in this the debit glAccountTypeId is COGS_ACCOUNT that's why i have swaped the entry for glAccountTypeId, so i think that in the service createAcctgTransForFixedAssetMaintIssuance the debit glAccountTypeId will be FIXED_ASSET_MAINT. -- Pranay Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance Key: OFBIZ-1472 URL: https://issues.apache.org/jira/browse/OFBIZ-1472 Project: OFBiz Issue Type: Sub-task Components: accounting Reporter: Jacopo Cappellato Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch Name of the service: createAcctgTransForFixedAssetMaintIssuance or similar Service definition: service name=createAcctgTransForFixedAssetMaintIssuance engine=simple auth=true location=org/ofbiz/accounting/ledger/GeneralLedgerServices.xml invoke=createAcctgTransForFixedAssetMaintIssuance descriptionCreate an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)/description attribute name=itemIssuanceId type=String mode=IN optional=false/ attribute name=acctgTransId type=String mode=OUT optional=true/ /service Use as a template the service createAcctgTransForSalesShipmentIssuance. The new service will be very similar, with the following differences: 1) replace shipmentId with fixedAssetId 2) do not set partyId and roleTypeId 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT) 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT) The seca will be: eca service=createItemIssuance event=commit condition field-name=fixedAssetId operator=is-not-empty/ action service=createAcctgTransForFixedAssetMaintIssuance mode=sync/ /eca -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1488) Bug in new XML properties code
[ https://issues.apache.org/jira/browse/OFBIZ-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1488: --- Attachment: xml_props_fix.patch Attached patch fixes the bug. Also has some code cleanups. Bug in new XML properties code -- Key: OFBIZ-1488 URL: https://issues.apache.org/jira/browse/OFBIZ-1488 Project: OFBiz Issue Type: Bug Components: framework Reporter: Adrian Crum Priority: Minor Attachments: xml_props_fix.patch The new XML properties code doesn't fall back to other locales when a specific element isn't found in the specified locale. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1422) Small fixup for rev 596815
[ https://issues.apache.org/jira/browse/OFBIZ-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548364 ] Adrian Crum commented on OFBIZ-1422: Bump. I'm about to wrap up the entity definition documentation code. It would help to get this committed. Small fixup for rev 596815 -- Key: OFBIZ-1422 URL: https://issues.apache.org/jira/browse/OFBIZ-1422 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Jacopo Cappellato Priority: Minor Attachments: modelviewentity.patch In some cases aliased entity fields were losing their description element. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1425) Improve the ModelField.getDescription method
[ https://issues.apache.org/jira/browse/OFBIZ-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-1425. -- Resolution: Fixed Improved field descriptions in rev 601056. Improve the ModelField.getDescription method Key: OFBIZ-1425 URL: https://issues.apache.org/jira/browse/OFBIZ-1425 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: example.patch, example.patch Based upon discussion on the dev mailing list and in the OFBIZ-1387 issue, modify the ModelField.getDescription method so it uses a more comprehensive way to resolve a field description. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1488) Bug in new XML properties code
[ https://issues.apache.org/jira/browse/OFBIZ-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1488: --- Attachment: xml_props_fix.patch Updated patch. Bug in new XML properties code -- Key: OFBIZ-1488 URL: https://issues.apache.org/jira/browse/OFBIZ-1488 Project: OFBiz Issue Type: Bug Components: framework Reporter: Adrian Crum Priority: Minor Attachments: xml_props_fix.patch, xml_props_fix.patch The new XML properties code doesn't fall back to other locales when a specific element isn't found in the specified locale. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL
[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548395 ] BJ Freeman commented on OFBIZ-1388: --- sorry I did the patch but did not put it in Bug in lookup windows URL - Key: OFBIZ-1388 URL: https://issues.apache.org/jira/browse/OFBIZ-1388 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup.patch Hi all, I just noticed a bug in lookup windows url generation. One way to generate the bug is this: Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner. After you add PC001 to cart, you will be in order entry screen and your URL should look like this: https://localhost:8443/ordermgr/control/additem/product At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen! Popup screen will not generate LookupProduct request as it is expected, instead the request is additem/LookupProduct and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product Any ideas how to fix this bug? Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1422) Small fixup for rev 596815
[ https://issues.apache.org/jira/browse/OFBIZ-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548397 ] Adrian Crum commented on OFBIZ-1422: Jacopo, Go check out the entity reference page - Example component entities. -Adrian Small fixup for rev 596815 -- Key: OFBIZ-1422 URL: https://issues.apache.org/jira/browse/OFBIZ-1422 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Jacopo Cappellato Priority: Minor Attachments: modelviewentity.patch In some cases aliased entity fields were losing their description element. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1388) Bug in lookup windows URL
[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-1388: -- Attachment: JsLookup.patch sorry thought I had uploaded this alread Bug in lookup windows URL - Key: OFBIZ-1388 URL: https://issues.apache.org/jira/browse/OFBIZ-1388 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: JsLookup.patch, lookup.patch Hi all, I just noticed a bug in lookup windows url generation. One way to generate the bug is this: Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner. After you add PC001 to cart, you will be in order entry screen and your URL should look like this: https://localhost:8443/ordermgr/control/additem/product At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen! Popup screen will not generate LookupProduct request as it is expected, instead the request is additem/LookupProduct and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product Any ideas how to fix this bug? Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1422) Small fixup for rev 596815
[ https://issues.apache.org/jira/browse/OFBIZ-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548408 ] Jacopo Cappellato commented on OFBIZ-1422: -- Very cool! Small fixup for rev 596815 -- Key: OFBIZ-1422 URL: https://issues.apache.org/jira/browse/OFBIZ-1422 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Jacopo Cappellato Priority: Minor Attachments: modelviewentity.patch In some cases aliased entity fields were losing their description element. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Any plan to allow field widgets like drop-down inside screen?
Oops. Sorry.
Jonathon
Jacques Le Roux wrote:
This discussion sounds interesting and should be rather done on the dev list,
suggesting...
Jacques
De : Jonathon -- Improov [EMAIL PROTECTED]
Forms can be written in total widget or total FTL, not a combination. That's
the problem.
See the editcontactmech.ftl example I gave.
Also, see the skip-start and skip-end attributes discussion I gave on element form. Note also
the inability to remove the table wrapper for form.
Jonathon
BJ Freeman wrote:
ignorant question.
if you can include a screen and a screen can include a form.
what am I missing.
Jonathon -- Improov sent the following on 12/4/2007 9:49 PM:
Skip,
Yes, I knew we can include screen widgets in FTL. I told you screens as
building blocks, remember?
Also, check out ${sections.render('section_name')}, by the way.
My problem is that I can't add less than a screen in FTL.
Consider that you have in FTL a HTML form. Somewhere inside that form,
you want to insert a drop-down widget. You can't, so you do what Si
Chen did, using FreeMarker macros.
Why are we doing a HTML form in FTL? Because as discussed often before,
some UIs just need to be complex and pretty and requires FTL.
Why am I trying to include drop-down widget into a HTML form in FTL?
Because it's more complex to use FTL select. Let me give a concrete
example. See ${component:party}/webapp/partymgr/party/editcontactmech.ftl .
See lines:
select name=stateProvinceGeoId
option${(mechMap.postalAddress.stateProvinceGeoId)?if_exists}/option
option/option
${screens.render(component://common/widget/CommonScreens.xml#states)}
/select
Looks simple enough?
See screen widget ${component:common}/widget/CommonScreens.xml#states .
It points to another FTL file in
/framework/common/webcommon/includes/states.ftl . Look in that
states.ftl , and see how a non-trivial CommonWorkers class is used.
If we can use widgets, it's just:
field name=geoId
drop-down
entity-options entity-name=Geo description=${geoName}
combine=or
entity-constraint name=geoTypeId value=STATE
entity-constraint name=geoTypeId value=PROVINCE
entity-order-by field-name=geoName/
/entity-options
/drop-down
/field
Compare the above field to the alternative now. See the select
chunk, plus the screen name=states chunk, plus the states.ftl, plus
the CommonWorkers.getStateList() chunk.
Note note! The attribute combine in element entity-options does not
exist... yet. :) Currently, all entity-constraint elements are ANDed
together, not ORed.
Jonathon
[EMAIL PROTECTED] wrote:
Yep, you can already do it, check out the screens.render line
#if collectionSummary?has_content
div class=screenlet-body
table width=100% border=0 cellspacing=5
tr
td width=50%
${screens.render(component://ar/widget/opentaps/collections/screens/Collect
ionScreens.xml#collectionWorkArea)}
/td
td width=50%
#if chartURL?has_content
img src=${chartURL} style=vertical-align:middle;
margin-left:35px/
#else
No chart Image
/#if
/td
/tr
/table
/div
#else
${uiLabelMap.PartyNoPartyFoundWithPartyId}:
${parameters.partyId?if_exists}
/#if
-Original Message-
From: Jonathon -- Improov [mailto:[EMAIL PROTECTED]
Sent: Tuesday, December 04, 2007 1:02 AM
To: [EMAIL PROTECTED]
Subject: Re: Any plan to allow field widgets like drop-down inside
screen?
Skip,
Do you mean it can currently be done already? Didn't know this.
Or you mean it's a good step forward?
Right now, whenever widgets are inadequate, a common practice (maybe the
only feasible one) is to
jump right into FTL and forget about widgets.
(But if you can do all-widget forms and all-ftl forms, they do mix. I
replied to your post about
the screens as building blocks thing.)
The lack of widgets (like convenient drop-down) in FTL is possibly the
main motivation behind Si
Chen's (opentaps) route with FreeMarker macros. Was mine too, at one
time. I
had a library of
macros (sold, privatized, again, sigh).
Jonathon
[EMAIL PROTECTED] wrote:
Widgets in FTL is the only way currently to get some things done if you
want
to use widgets.
Skip
-Original Message-
From: Jonathon -- Improov [mailto:[EMAIL PROTECTED]
Sent: Monday, December 03, 2007 5:36 PM
To: [EMAIL PROTECTED]
Subject: Re: Any plan to allow field widgets like drop-down inside
screen?
Actually, this isn't going backwards. It's going forward.
Some screens are best done in ftl. This was discussed countless times
before.
In getting ftl screens to use field widgets, we reuse more of OFBiz's
widgets in more places. This
will bring us closer to using more of widgets.
Jonathon
BJ Freeman wrote:
seems your going backwards.
remove the ftl and use screen widgets that include formwidgets.
add a class (style) and use the css for aligning tables.
Jonathon -- Improov sent the following on 12/2/2007 8:48 PM:
The problem I'm facing now is that form widgets
