[jira] Updated: (OFBIZ-1563) Re-Factor Party CommunicationEvent permissions to follow new patterns.
[ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Meshram updated OFBIZ-1563: --- Attachment: partymgr_security.patch Minor changes. Re-Factor Party CommunicationEvent permissions to follow new patterns. -- Key: OFBIZ-1563 URL: https://issues.apache.org/jira/browse/OFBIZ-1563 Project: OFBiz Issue Type: Improvement Components: party Reporter: Abhijit Meshram Attachments: partymgr_security.patch, partymgr_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1566) if all variants of a virtual product run out of stock and the disc indicator is set to 'Y' the ecommerce system abends
if all variants of a virtual product run out of stock and the disc indicator is set to 'Y' the ecommerce system abends -- Key: OFBIZ-1566 URL: https://issues.apache.org/jira/browse/OFBIZ-1566 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: SVN trunk Reporter: Hans Bakker if all variants of a virtual product run out of stock and the product 'disc' indicator is set to 'Y' the system abends with the following error message when the product detail page is shown of the virtual product. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#productdetail]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh], line [422]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh : Method Invocation dispatcher.runSync : at Line: 422 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh : dispatcher .runSync ( getAssociatedProducts , UtilMisc .toMap ( productId , productId , type , PRODUCT_OBSOLESCENCE , checkViewAllow , Boolean .TRUE , prodCatalogId , currentCatalogId ) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1566) if all variants of a virtual product run out of stock and the disc indicator is set to 'Y' the ecommerce system abends
[ https://issues.apache.org/jira/browse/OFBIZ-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-1566: --- Attachment: productDisc.diff the attached patch fixes the error and will show the the virtual product with the message: this product is out of stock. please let me know is this patch is acceptable then i will commit it to the trunk. if all variants of a virtual product run out of stock and the disc indicator is set to 'Y' the ecommerce system abends -- Key: OFBIZ-1566 URL: https://issues.apache.org/jira/browse/OFBIZ-1566 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: SVN trunk Reporter: Hans Bakker Attachments: productDisc.diff if all variants of a virtual product run out of stock and the product 'disc' indicator is set to 'Y' the system abends with the following error message when the product detail page is shown of the virtual product. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#productdetail]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh], line [422]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh : Method Invocation dispatcher.runSync : at Line: 422 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh : dispatcher .runSync ( getAssociatedProducts , UtilMisc .toMap ( productId , productId , type , PRODUCT_OBSOLESCENCE , checkViewAllow , Boolean .TRUE , prodCatalogId , currentCatalogId ) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1567) if 1566 is implemented and if the 'disc' flag is set the virtual product and all variant products are out of stock the product still shows
if 1566 is implemented and if the 'disc' flag is set the virtual product and all variant products are out of stock the product still shows --- Key: OFBIZ-1567 URL: https://issues.apache.org/jira/browse/OFBIZ-1567 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: SVN trunk Reporter: Hans Bakker Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1496) Reports: Implement a report to show the debit/credi totals of all the transactions in a date range by gl account
[ https://issues.apache.org/jira/browse/OFBIZ-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Pandit updated OFBIZ-1496: Attachment: DebitCreditTransectionTotal.patch We are working on this issue and for the same we have done the following : 1) we have created a view entity named GlAccOrgAndAcctgTransAndEntry using GlAccountOrganization, AcctgTransEntry, and AccTrans Entities. 2).we prepared screens and forms to Implement a report to show the debit/credi totals of all the transactions in a date range by gl account. 3).you can see the effects on Accounting General Ledger Accounting Reports AccountingTransactionTotals. we created the view entity with the required fields as given in the issue, if any one who have the extensive knowledge of accounting component please suggest us, Are any more fields required for the above view entity ? Submitted by : Ratnesh Upadhyay Rishi Solanki Sumit Pandit Reports: Implement a report to show the debit/credi totals of all the transactions in a date range by gl account Key: OFBIZ-1496 URL: https://issues.apache.org/jira/browse/OFBIZ-1496 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: SVN trunk Reporter: Jacopo Cappellato Assignee: Anil K Patel Attachments: DebitCreditTransectionTotal.patch There is already an empty screen definition for the report: https://localhost:8443/accounting/control/TransactionTotals?organizationPartyId=Company Add to the report a call to a bsh script (or minilang code) and forms to complete the screen. There will be a search form with from/thru dates and a submit button. Once submitted, under the form the screen will show two identical list forms: one containing unposted amounts and one containing posted amounts; each form will have the same fields of the Trial Balance: https://localhost:8443/accounting/control/TrialBalance?organizationPartyId=Company I can provide more details, if needed, to get the data but basically we'll have to create a bsh script (and possibly a view-entity definition) to select records (in the selected date range and for the organizationPartyId) from the AcctgTransEntry entity and summarize by glAccountId the credit total and debit total of each row. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1567) if 1566 is implemented and if the 'disc' flag is set the virtual product and all variant products are out of stock the product still shows
[ https://issues.apache.org/jira/browse/OFBIZ-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12557194#action_12557194 ] Hans Bakker commented on OFBIZ-1567: the 'disc' is the salesDiscWhenNotAvail field in the product if 1566 is implemented and if the 'disc' flag is set the virtual product and all variant products are out of stock the product still shows --- Key: OFBIZ-1567 URL: https://issues.apache.org/jira/browse/OFBIZ-1567 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: SVN trunk Reporter: Hans Bakker Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1563) Re-Factor Party CommunicationEvent permissions to follow new patterns.
[ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Meshram updated OFBIZ-1563: --- Attachment: partymgr_security.patch Re-Factor Party CommunicationEvent permissions to follow new patterns. -- Key: OFBIZ-1563 URL: https://issues.apache.org/jira/browse/OFBIZ-1563 Project: OFBiz Issue Type: Improvement Components: party Reporter: Abhijit Meshram Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1568) if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
[ https://issues.apache.org/jira/browse/OFBIZ-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-1568: --- Attachment: discVirtual.diff if salesDiscWhenNotAvail field on variant is empty take the value from the virtual -- Key: OFBIZ-1568 URL: https://issues.apache.org/jira/browse/OFBIZ-1568 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Reporter: Hans Bakker Attachments: discVirtual.diff The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product. Please let me know about any objections otherwise i will commit the attached path in a couple of days. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1568) if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
if salesDiscWhenNotAvail field on variant is empty take the value from the virtual -- Key: OFBIZ-1568 URL: https://issues.apache.org/jira/browse/OFBIZ-1568 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Reporter: Hans Bakker Attachments: discVirtual.diff The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product. Please let me know about any objections otherwise i will commit the attached path in a couple of days. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: ofbiz desktop client ?
Interesting, thanks for comment BJ, Note that you might also use a parametrised URI like http://www.parts-depot.com/parts?00345 which may avoid link repetitions, though I'm not sure how yet. This is how Amazon's OpenSearch works : http://www.opensearch.org/Home Maybe better explained here http://xml.com/pub/a/2005/09/21/atom-store-web-database.html And definitively by http://www.xml.com/pub/at/34 Jacques PS : still trying to understand this new stuff for me From: BJ Freeman [EMAIL PROTECTED] Actually there is a key concept that is missing here. in REST the example ?xml version=1.0? p:Parts xmlns:p=http://www.parts-depot.com; xmlns:xlink=http://www.w3.org/1999/xlink; Part id=00345 xlink:href=http://www.parts-depot.com/parts/00345/ Part id=00346 xlink:href=http://www.parts-depot.com/parts/00346/ Part id=00347 xlink:href=http://www.parts-depot.com/parts/00347/ Part id=00348 xlink:href=http://www.parts-depot.com/parts/00348/ /p:Parts provides a list of all possible links are provided. so say for 27,000 parts this list could be very big. then if you have option and variants, it could be a file that has millions of links. David E Jones sent the following on 1/7/2008 7:01 PM: On Jan 7, 2008, at 12:53 PM, Jacques Le Roux wrote: On Jan 7, 2008, at 5:14 AM, Jacques Le Roux wrote: From: David E Jones [EMAIL PROTECTED] REST is a more general architectural concept... what does it have to do with this? In other words, I'm not quite sure what you mean by REST along with other ways. -David As BJ suggested in http://www.xfront.com/REST-Web-Services.html you can create Web services in REST spirit. I know this have some limitations (regarding object types arguments) but don't you think it's a best practice to use this type of Web services before thinking about using SOAP when you are in an heterogeneous environment (ie not only Java using RMI) ? Jacques How would we implement a REST type web service interface? Using an HTTP service (ie using ofbiz-ser and XmlSerializer for arguments). In my mind REST type web service and HTTP service are the same, am'I wrong ? The idea is to avoid the SOAP overhead when it's not mandatory. At the beginning I Googled for rest vs soap from which the question. I think the point of REST is that it is an architectural approach, and pretty much anything that transfers information according to the REST patterns qualifies, and I'd interpret those to even include SOAP if it is used appropriately (like request/response via HTTP) as SOAP is just an information container specific to remote invocation. Thanks for describing in more detail what you had in mind. Actually what you describe already exists, it is the http service runner (org.ofbiz.service.engine.HttpEngine). -David
Re: ofbiz desktop client ?
Though Google seems to deal easily with such things (Billions links), and the Web is the proof of the REST architecture high value, your comment stills make me wondering... Thanks Jacques From: BJ Freeman [EMAIL PROTECTED] Actually there is a key concept that is missing here. in REST the example ?xml version=1.0? p:Parts xmlns:p=http://www.parts-depot.com; xmlns:xlink=http://www.w3.org/1999/xlink; Part id=00345 xlink:href=http://www.parts-depot.com/parts/00345/ Part id=00346 xlink:href=http://www.parts-depot.com/parts/00346/ Part id=00347 xlink:href=http://www.parts-depot.com/parts/00347/ Part id=00348 xlink:href=http://www.parts-depot.com/parts/00348/ /p:Parts provides a list of all possible links are provided. so say for 27,000 parts this list could be very big. then if you have option and variants, it could be a file that has millions of links. David E Jones sent the following on 1/7/2008 7:01 PM: On Jan 7, 2008, at 12:53 PM, Jacques Le Roux wrote: On Jan 7, 2008, at 5:14 AM, Jacques Le Roux wrote: From: David E Jones [EMAIL PROTECTED] REST is a more general architectural concept... what does it have to do with this? In other words, I'm not quite sure what you mean by REST along with other ways. -David As BJ suggested in http://www.xfront.com/REST-Web-Services.html you can create Web services in REST spirit. I know this have some limitations (regarding object types arguments) but don't you think it's a best practice to use this type of Web services before thinking about using SOAP when you are in an heterogeneous environment (ie not only Java using RMI) ? Jacques How would we implement a REST type web service interface? Using an HTTP service (ie using ofbiz-ser and XmlSerializer for arguments). In my mind REST type web service and HTTP service are the same, am'I wrong ? The idea is to avoid the SOAP overhead when it's not mandatory. At the beginning I Googled for rest vs soap from which the question. I think the point of REST is that it is an architectural approach, and pretty much anything that transfers information according to the REST patterns qualifies, and I'd interpret those to even include SOAP if it is used appropriately (like request/response via HTTP) as SOAP is just an information container specific to remote invocation. Thanks for describing in more detail what you had in mind. Actually what you describe already exists, it is the http service runner (org.ofbiz.service.engine.HttpEngine). -David
[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12557254#action_12557254 ] Bilgin Ibryam commented on OFBIZ-1453: -- Jacques, I fixed the bugs you described (Could you confirm this, please). You were right about them! The only bug that i cannot reproduce is create an order from this existing order (in Order View) It works for me w/o errors. In line 348 of ShoppingCartServices the product type *should be * AGGREGATED_CONF, because during order creation AGGREGATED products are replaced by AGGREGATED_CONF typed products, and orderItems are AGGREGATED_CONF. So in ShoppingCartServices.loadCartFromOrder() the product can not be AGGREGATED_CONF. I do not know how you got an AGGREGATED product in OrderItems. Also fixed the you end with the default configuration in any cases bug. But after the product is configured, before adding to shopping list is required to use Verify Configuration button. This should be replaced by an ajax event in the future. Thanks for your help. store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Components: order, product Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1453: - Attachment: aggregated_full_for_review.patch store/load possibility for AGGREGATED product configurations Key: OFBIZ-1453 URL: https://issues.apache.org/jira/browse/OFBIZ-1453 Project: OFBiz Issue Type: Improvement Components: order, product Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is displayed yet unattainable
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12557257#action_12557257 ] Bilgin Ibryam commented on OFBIZ-1495: -- Jacques, thank you for taking care of this issue! Aggregate items base price is displayed yet unattainable Key: OFBIZ-1495 URL: https://issues.apache.org/jira/browse/OFBIZ-1495 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Attachments: ofbiz-1495.patch, totalPrice.patch I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there. Configurable PC PC001 Your Price: $50.00 Hey, 50$ for a PC, I want one! So I click on the item. Configurable PC PC001 Product Aggregated Price: $385.00 What? So, whatever is being called for the price of a PC001 should probably report the price of the default configuration, not the price of the unconfigured product that you can't buy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
CallService throws cannot locate service by name
I'm upgrading an old OFBiz based application to the latest Apache version and I
discovered a problem with a custom simple method that no longer works.
I have traced the problem to the CallService class and a change made last year.
I'm not sure of the protocol to open a Jira Tracker but here's the details.
Simple Method declaration:
simple-method method-name=getDataMaps short-description=Call a series of
services to assemble a map hierarchy login-required=false
iterate-map map-name=parameters.operationMap key-name=serviceName
value-name=resultMap
clear-field field-name=serviceMap/
set-service-fields service-name=${serviceName} map-name=parameters
to-map-name=serviceMap/
call-service service-name=${serviceName} in-map-name=serviceMap
results-to-map map-name=${resultMap}/
/call-service
set field=dataMap.${resultMap} from-field=${resultMap}/
/iterate-map
When this simple method executes it fails (partial debug log)
2008-01-08 15:40:41,000 (http-0.0.0.0-8443-Processor4) [Log.java:94 :INFO ]
*getDataMaps parameters.operationMap [findProjectDetails=projectDetails,
findCustomAttachment=customAttachment]
2008-01-08 15:40:41,000 (http-0.0.0.0-8443-Processor4) [Log.java:94 :INFO ]
*calling service findProjectDetails
2008-01-08 15:40:44,500 (http-0.0.0.0-8443-Processor4)
[CallService.java:242:ERROR]
exception report --
Exception: org.ofbiz.service.GenericServiceException
Message: Cannot locate service by name (${serviceName})
stack trace ---
org.ofbiz.service.GenericServiceException: Cannot locate service by name
(${serviceName})
org.ofbiz.service.DispatchContext.getModelService(DispatchContext.java:190)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:143)
org.ofbiz.minilang.method.callops.CallService.exec(CallService.java:239)
org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:931)
The change is in CallService method exec(MethodContext methodContext) in the
block that checks for requiring a new transaction and timeout.
If you debug result = methodContext.getDispatcher().runSync(this.serviceName,
inMap); and inspect this.serviceName you will get ${serviceName}
If you inspect serviceName you will get findProjectDetails which is desired.
To fix my version, I changed the code back to the way serviceName used to be:
result = methodContext.getDispatcher().runSync(serviceName, inMap);
Chris Juettner
Integral Business Solutions
[jira] Assigned: (OFBIZ-1563) Re-Factor Party CommunicationEvent permissions to follow new patterns.
[ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1563: -- Assignee: Adrian Crum Re-Factor Party CommunicationEvent permissions to follow new patterns. -- Key: OFBIZ-1563 URL: https://issues.apache.org/jira/browse/OFBIZ-1563 Project: OFBiz Issue Type: Improvement Components: party Reporter: Abhijit Meshram Assignee: Adrian Crum Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1563) Re-Factor Party CommunicationEvent permissions to follow new patterns.
[ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1563: --- Priority: Minor (was: Major) Re-Factor Party CommunicationEvent permissions to follow new patterns. -- Key: OFBIZ-1563 URL: https://issues.apache.org/jira/browse/OFBIZ-1563 Project: OFBiz Issue Type: Improvement Components: party Reporter: Abhijit Meshram Assignee: Adrian Crum Priority: Minor Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: ofbiz desktop client ?
to parametrize is not the REST WAY. :) and for machine to machine millions of links is not bad. for using for a UI, the time lag is beyond what most users would tolerate. Jacques Le Roux sent the following on 1/9/2008 2:30 AM: Interesting, thanks for comment BJ, Note that you might also use a parametrised URI like http://www.parts-depot.com/parts?00345 which may avoid link repetitions, though I'm not sure how yet. This is how Amazon's OpenSearch works : http://www.opensearch.org/Home Maybe better explained here http://xml.com/pub/a/2005/09/21/atom-store-web-database.html And definitively by http://www.xml.com/pub/at/34 Jacques PS : still trying to understand this new stuff for me From: BJ Freeman [EMAIL PROTECTED] Actually there is a key concept that is missing here. in REST the example ?xml version=1.0? p:Parts xmlns:p=http://www.parts-depot.com; xmlns:xlink=http://www.w3.org/1999/xlink; Part id=00345 xlink:href=http://www.parts-depot.com/parts/00345/ Part id=00346 xlink:href=http://www.parts-depot.com/parts/00346/ Part id=00347 xlink:href=http://www.parts-depot.com/parts/00347/ Part id=00348 xlink:href=http://www.parts-depot.com/parts/00348/ /p:Parts provides a list of all possible links are provided. so say for 27,000 parts this list could be very big. then if you have option and variants, it could be a file that has millions of links. David E Jones sent the following on 1/7/2008 7:01 PM: On Jan 7, 2008, at 12:53 PM, Jacques Le Roux wrote: On Jan 7, 2008, at 5:14 AM, Jacques Le Roux wrote: From: David E Jones [EMAIL PROTECTED] REST is a more general architectural concept... what does it have to do with this? In other words, I'm not quite sure what you mean by REST along with other ways. -David As BJ suggested in http://www.xfront.com/REST-Web-Services.html you can create Web services in REST spirit. I know this have some limitations (regarding object types arguments) but don't you think it's a best practice to use this type of Web services before thinking about using SOAP when you are in an heterogeneous environment (ie not only Java using RMI) ? Jacques How would we implement a REST type web service interface? Using an HTTP service (ie using ofbiz-ser and XmlSerializer for arguments). In my mind REST type web service and HTTP service are the same, am'I wrong ? The idea is to avoid the SOAP overhead when it's not mandatory. At the beginning I Googled for rest vs soap from which the question. I think the point of REST is that it is an architectural approach, and pretty much anything that transfers information according to the REST patterns qualifies, and I'd interpret those to even include SOAP if it is used appropriately (like request/response via HTTP) as SOAP is just an information container specific to remote invocation. Thanks for describing in more detail what you had in mind. Actually what you describe already exists, it is the http service runner (org.ofbiz.service.engine.HttpEngine). -David
Re: CallService throws cannot locate service by name
Fixed, rev 610440. Thanks Chris!
-Adrian
Chris Juettner wrote:
I'm upgrading an old OFBiz based application to the latest Apache version and I discovered a problem with a custom simple method that no longer works.
I have traced the problem to the CallService class and a change made last year. I'm not sure of the protocol to open a Jira Tracker but here's the details.
Simple Method declaration:
simple-method method-name=getDataMaps short-description=Call a series of services to assemble
a map hierarchy login-required=false
iterate-map map-name=parameters.operationMap key-name=serviceName
value-name=resultMap
clear-field field-name=serviceMap/
set-service-fields service-name=${serviceName} map-name=parameters
to-map-name=serviceMap/
call-service service-name=${serviceName} in-map-name=serviceMap
results-to-map map-name=${resultMap}/
/call-service
set field=dataMap.${resultMap} from-field=${resultMap}/
/iterate-map
When this simple method executes it fails (partial debug log)
2008-01-08 15:40:41,000 (http-0.0.0.0-8443-Processor4) [Log.java:94 :INFO ]
*getDataMaps parameters.operationMap [findProjectDetails=projectDetails,
findCustomAttachment=customAttachment]
2008-01-08 15:40:41,000 (http-0.0.0.0-8443-Processor4) [Log.java:94 :INFO ]
*calling service findProjectDetails
2008-01-08 15:40:44,500 (http-0.0.0.0-8443-Processor4) [CallService.java:242:ERROR]
exception report --
Exception: org.ofbiz.service.GenericServiceException
Message: Cannot locate service by name (${serviceName})
stack trace ---
org.ofbiz.service.GenericServiceException: Cannot locate service by name
(${serviceName})
org.ofbiz.service.DispatchContext.getModelService(DispatchContext.java:190)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:143)
org.ofbiz.minilang.method.callops.CallService.exec(CallService.java:239)
org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:931)
The change is in CallService method exec(MethodContext methodContext) in the
block that checks for requiring a new transaction and timeout.
If you debug result = methodContext.getDispatcher().runSync(this.serviceName, inMap); and inspect
this.serviceName you will get ${serviceName}
If you inspect serviceName you will get findProjectDetails which is desired.
To fix my version, I changed the code back to the way serviceName used to be:
result = methodContext.getDispatcher().runSync(serviceName, inMap);
Chris Juettner
Integral Business Solutions
Re: svn commit: r610440 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java
When you reference the mailing list could you give a subject and date.
helps finding the conversation.
[EMAIL PROTECTED] sent the following on 1/9/2008 8:32 AM:
Author: adrianc
Date: Wed Jan 9 08:32:21 2008
New Revision: 610440
URL: http://svn.apache.org/viewvc?rev=610440view=rev
Log:
Fixed problem with simple method call-service operation, reported by Chris
Juettner on the dev mailing list.
Modified:
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java
Modified:
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java?rev=610440r1=610439r2=610440view=diff
==
---
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java
(original)
+++
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/callops/CallService.java
Wed Jan 9 08:32:21 2008
@@ -222,10 +222,10 @@
if (locale != null) {
inMap.put(locale, locale);
}
-
+
try {
if (UtilValidate.isEmpty(this.requireNewTransactionStr)
this.transactionTimeout 0) {
-result =
methodContext.getDispatcher().runSync(this.serviceName, inMap);
+result = methodContext.getDispatcher().runSync(serviceName,
inMap);
} else {
ModelService modelService =
methodContext.getDispatcher().getDispatchContext().getModelService(serviceName);
boolean requireNewTransaction =
modelService.requireNewTransaction;
@@ -236,7 +236,7 @@
if (this.transactionTimeout = 0) {
timeout = this.transactionTimeout;
}
-result =
methodContext.getDispatcher().runSync(this.serviceName, inMap, timeout,
requireNewTransaction);
+result = methodContext.getDispatcher().runSync(serviceName,
inMap, timeout, requireNewTransaction);
}
} catch (GenericServiceException e) {
Debug.logError(e, module);
[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12557367#action_12557367 ] Jacques Le Roux commented on OFBIZ-1453: Bilgin, I suppose you did not test this patch protected double defaultPrice = 0.0; was missing in ProductConfigWrapper String sequenceNum = null; Should be Long sequenceNum = null; in ProductConfigWorker.java and ProductConfigWrapper.java (and related changes) The error you can't reproduce is still there : 2008-01-09 19:13:31,406 (http-0.0.0.0-28443-Processor3) [ ShoppingCartItem.java:491:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly. 2008-01-09 19:13:31,421 (http-0.0.0.0-28443-Processor3) [ShoppingCartServices.java:369:ERROR] exception report -- Exception: org.ofbiz.order.shoppingcart.CartItemModifyException Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly. stack trace --- org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly. org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:492) org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:324) org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:557) org.ofbiz.order.shoppingcart.ShoppingCartServices.loadCartFromOrder(ShoppingCartServices.java:364) sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) java.lang.reflect.Method.invoke(Method.java:585) org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:96) org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54) org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:375) org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:208) org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136) org.ofbiz.order.shoppingcart.ShoppingCartEvents.loadCartFromOrder(ShoppingCartEvents.java:1234) sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) java.lang.reflect.Method.invoke(Method.java:585) org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:88) org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:74) org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:454) org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:281) org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:193) javax.servlet.http.HttpServlet.service(HttpServlet.java:595) javax.servlet.http.HttpServlet.service(HttpServlet.java:688) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210) org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174) org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117) org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108) org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:542) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151) org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870) org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665) org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528) org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81) org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685) java.lang.Thread.run(Thread.java:595) 2008-01-09 19:13:31,421 (http-0.0.0.0-28443-Processor3) [ ServiceDispatcher.java:513:ERROR] Error in
Re: svn commit: r610489 - /ofbiz/trunk/applications/accounting/data/DemoOrganizationData.xml
Hi, MARKETING, ACCOUNTING, SALES, DEV, TESTING parties need _NA_ role for the PartyRelationships. Regards, Bilgin
Re: svn commit: r610489 - /ofbiz/trunk/applications/accounting/data/DemoOrganizationData.xml
I'll take care of that... sorry. I did a fresh database load test, but hit the wrong ant target. :( It'll be right in. -David On Jan 9, 2008, at 1:03 PM, Bilgin Ibryam wrote: Hi, MARKETING, ACCOUNTING, SALES, DEV, TESTING parties need _NA_ role for the PartyRelationships. Regards, Bilgin smime.p7s Description: S/MIME cryptographic signature
OrganizationData
Parent === SCorp1 -Sales how to show this in both accounting and Party. In party show can you have multiple Sales departments. maybe Sales_SCorp1 Then in accounting have the GL base with a drop down select for the Sub company PartyID and the Department for the Sub Company. then the acct transactions would carry a partyID for company(profitcenter) and Deptartment party ID. if only Department then it would be the Profitcenter ID and the sub ID for the Department would be _NA_ possibly have this in the demo data.
[jira] Created: (OFBIZ-1569) Re-Factor Facility permissions of Product component to follow new patterns.
Re-Factor Facility permissions of Product component to follow new patterns. Key: OFBIZ-1569 URL: https://issues.apache.org/jira/browse/OFBIZ-1569 Project: OFBiz Issue Type: Improvement Components: product Reporter: Abhijit Meshram Attachments: facility_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1569) Re-Factor Facility permissions of Product component to follow new patterns.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Meshram updated OFBIZ-1569: --- Attachment: facility_security.patch Refactor the Facility permission to follow up new pattern. Please have a look at this patch and suggest if it needs any modification. Re-Factor Facility permissions of Product component to follow new patterns. Key: OFBIZ-1569 URL: https://issues.apache.org/jira/browse/OFBIZ-1569 Project: OFBiz Issue Type: Improvement Components: product Reporter: Abhijit Meshram Attachments: facility_security.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
