Issue : with disable userLogin not working.
When we tried to disable(block) a user login with following route. https://demo.hotwaxmedia.com/partymgr/control/editlogin?partyId=DemoCustomer1&userLoginId=DemoCustomer1 Now here Set enable = N and save. Now after 5 mins, on ecommerce when i tried to do login with same user name : DemoCustomer1 and password ofbiz then it logged in successfully. So here after 5 mins userlogin is not disable/blocked any more. NOTE : I chacked in database at UserLogin entity (after disable via partymgr, login via ecommerce) Before login : enabled = N after login : enabled = N logout : enabled = N login again : enabled = Y where enabled is attribute of UserLogin entity. -- Thanks and Regards Sumit Pandit Rishi Solanki HotWaxMedia, Inc http://www.hotwaxmedia.com
Re: Issue : with disable userLogin not working.
This is actually how it is supposed to work. Accounts are generally disabled because the user enters the wrong password X number of times, and then the account is automatically re-enabled after Y number of minutes. This is all configurable in the security.properties file, and the behavior can be changed there. Also, if you want to "permanently" disable a UserLogin, even with the OOTB settings you can set the disabled date to far in the future, and 5 minutes after that won't come up for a long time. -David Sumit Pandit wrote: When we tried to disable(block) a user login with following route. https://demo.hotwaxmedia.com/partymgr/control/editlogin?partyId=DemoCustomer1&userLoginId=DemoCustomer1 Now here Set enable = N and save. Now after 5 mins, on ecommerce when i tried to do login with same user name : DemoCustomer1 and password ofbiz then it logged in successfully. So here after 5 mins userlogin is not disable/blocked any more. NOTE : I chacked in database at UserLogin entity (after disable via partymgr, login via ecommerce) Before login : enabled = N after login : enabled = N logout : enabled = N login again : enabled = Y where enabled is attribute of UserLogin entity. -- Thanks and Regards Sumit Pandit Rishi Solanki HotWaxMedia, Inc http://www.hotwaxmedia.com
Re: Issue : with disable userLogin not working.
Thanks David for your reply, It would be very help ful for us. Thanks and Regards [Rishi Solanki] On Sat, Aug 30, 2008 at 2:07 PM, David E. Jones <[EMAIL PROTECTED]>wrote: > > This is actually how it is supposed to work. Accounts are generally > disabled because the user enters the wrong password X number of times, and > then the account is automatically re-enabled after Y number of minutes. > > This is all configurable in the security.properties file, and the behavior > can be changed there. > > Also, if you want to "permanently" disable a UserLogin, even with the OOTB > settings you can set the disabled date to far in the future, and 5 minutes > after that won't come up for a long time. > > -David > > > > Sumit Pandit wrote: > >> When we tried to disable(block) a user login with following route. >> >> >> https://demo.hotwaxmedia.com/partymgr/control/editlogin?partyId=DemoCustomer1&userLoginId=DemoCustomer1 >> >> Now here Set enable = N and save. >> >> Now after 5 mins, on ecommerce when i tried to do login with same user >> name : DemoCustomer1 and password ofbiz then it logged in successfully. >> >> So here after 5 mins userlogin is not disable/blocked any more. >> >> NOTE : I chacked in database at UserLogin entity >> >> (after disable via partymgr, login via ecommerce) >> Before login : enabled = N >> after login : enabled = N >> logout : enabled = N >> login again : enabled = Y >> >> where enabled is attribute of UserLogin entity. >> >> -- >> Thanks and Regards >> Sumit Pandit >> Rishi Solanki >> HotWaxMedia, Inc >> http://www.hotwaxmedia.com >> >> >>
Re: Issue : with disable userLogin not working.
Hi Sumit, Here it is explained why http://www.nabble.com/Users-with-disabled-accounts-are-still-able-to-login-to18223799.html#a18225350 Bilgin This message was sent using IMP, the Internet Messaging Program.
Re: Issue : with disable userLogin not working.
Thank you very much, David, Bilgin, and Reshi for your help. On Aug 30, 2008, at 2:24 PM, Bilgin Ibryam wrote: Hi Sumit, Here it is explained why http://www.nabble.com/Users-with-disabled-accounts-are-still-able-to-login-to18223799.html#a18225350 Bilgin This message was sent using IMP, the Internet Messaging Program.
Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web
Getting following error on process order call and it is related to new field
added to OrderItemShipGroup entity.
Failure in create operation for entity [OrderItemShipGroup]:
org.ofbiz.entity.GenericEntityException: Error while inserting:
[GenericEntity:OrderItemShipGroup][carrierPartyId,UPS(java.lang.String)][carrierRoleTypeId,CARRIER(java.lang.String)][contactMechId,9015(java.lang.String)][createdStamp,2008-08-30
15:23:26.671(java.sql.Timestamp)][createdTxStamp,2008-08-30
15:23:23.768(java.sql.Timestamp)][facilityId,(java.lang.String)][giftMessage,(java.lang.String)][isGift,N(java.lang.String)][lastUpdatedStamp,2008-08-30
15:23:26.671(java.sql.Timestamp)][lastUpdatedTxStamp,2008-08-30
15:23:23.768(java.sql.Timestamp)][maySplit,N(java.lang.String)][orderId,WSCO1(java.lang.String)][shipAfterDate,null()][shipByDate,null()][shipGroupSeqId,1(java.lang.String)][shipmentMethodTypeId,NEXT_DAY(java.lang.String)][shippingInstructions,null()][supplierPartyId,null()][vendorPartyId,null()]
(SQL Exception while executing the following:INSERT INTO
OFBIZ.ORDER_ITEM_SHIP_GROUP (ORDER_ID, SHIP_GROUP_SEQ_ID,
SHIPMENT_METHOD_TYPE_ID, SUPPLIER_PARTY_ID, VENDOR_PARTY_ID,
CARRIER_PARTY_ID, CARRIER_ROLE_TYPE_ID, FACILITY_ID, CONTACT_MECH_ID,
TELECOM_CONTACT_MECH_ID, TRACKING_NUMBER, SHIPPING_INSTRUCTIONS, MAY_SPLIT,
GIFT_MESSAGE, IS_GIFT, SHIP_AFTER_DATE, SHIP_BY_DATE, LAST_UPDATED_STAMP,
LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table
'ORDER_ITEM_SHIP_GROUP' caused a violation of foreign key constraint
'ORDER_ITSG_FAC' for key (). The statement has been rolled back.)). Rolling
back transaction.
- Vikas
On Tue, Aug 26, 2008 at 2:00 PM, <[EMAIL PROTECTED]> wrote:
> Author: bibryam
> Date: Tue Aug 26 01:30:05 2008
> New Revision: 688993
>
> URL: http://svn.apache.org/viewvc?rev=688993&view=rev
> Log:
> Applied (with few modifications) patch from Len Shein, OFBIZ-1928: "Allow
> the Shopping Cart to accept a facility per ship group to specify where
> inventory should be reserved from".
> Also added a dropdown button to choose a facility in order manager shipping
> screen.
>
>
> Modified:
>ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
>
>
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy
>ofbiz/trunk/applications/order/webapp/ordermgr/entry/shipsettings.ftl
>ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>
>
> ofbiz/trunk/applications/product/script/org/ofbiz/product/store/ProductStoreServices.xml
>ofbiz/trunk/applications/product/servicedef/services_store.xml
>
> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=688993&r1=688992&r2=688993&view=diff
>
> ==
> --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Tue Aug 26
> 01:30:05 2008
> @@ -794,6 +794,7 @@
> For use with
> multi-vendor stores, order will be split so that each ship group is
> associated with only one vendor (only if applicable)
>
>
> +
>
>
>
> @@ -826,6 +827,9 @@
>
> rel-field-name="roleTypeId"/>
>
> + rel-entity-name="Facility">
> +
> +
>rel-entity-name="ShipmentMethodType">
>
>
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=688993&r1=688992&r2=688993&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> (original)
> +++
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> Tue Aug 26 01:30:05 2008
> @@ -1115,6 +1115,8 @@
> continue;
> }
> GenericValue orderItem = (GenericValue)
> itemValuesBySeqId.get(orderItemShipGroupAssoc.get("orderItemSeqId"));
> +GenericValue orderItemShipGroup =
> orderItemShipGroupAssoc.getRelatedOne("OrderItemShipGroup");
> +String shipGroupFacilityId =
> orderItemShipGroup.getString("facilityId");
> String itemStatus = orderItem.getString("statusId");
> if ("ITEM_REJECTED".equals(itemStatus) ||
> "ITEM_CANCELLED".equals(itemStatus) || "ITEM_COMPLETED".equals
Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web
Quoting Vikas Mayur <[EMAIL PROTECTED]>: Getting following error on process order call and it is related to new field added to OrderItemShipGroup entity. Vikas, can you provide some more information on how you get this error? I couldn't find "process order call" stuff. Bilgin This message was sent using IMP, the Internet Messaging Program.
Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web
Bilgin, I am sorry that I just post this in hurry. The error comes when you click on create order link on order confirmation screen on order manager screen. Hope this helps ! - Vikas On Sat, Aug 30, 2008 at 6:36 PM, Bilgin Ibryam <[EMAIL PROTECTED]> wrote: > Quoting Vikas Mayur <[EMAIL PROTECTED]>: > > Getting following error on process order call and it is related to new >> field >> added to OrderItemShipGroup entity. >> >> > Vikas, > can you provide some more information on how you get this error? > I couldn't find "process order call" stuff. > > Bilgin > > > This message was sent using IMP, the Internet Messaging Program. > >
Idea: OFBiz self-hosting
Hi devs, the OFBiz CMS application is having more and more improvements and this is really good. However (as read on ML) more seems to be done. I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site instead of Confluence would be the best way to have all contributors to see how the CMS works and where it needs to be improved. Probably, at this stage, this will sound a crazy idea but I would like to hear what you guy that know the real OFBIZ CMS actual features think about it. Having a CMS hosting its own website is something obvious (all CMS do this). Of course OFBiz is not a CMS only but, again, I think this is the best way to power the CMS up. My two cents, Bruno
[jira] Closed: (OFBIZ-1936) Change the text of the Induce DB.
[ https://issues.apache.org/jira/browse/OFBIZ-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1936. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks BJ, Your patch is in trunk revision: 690538 I know it's not related to this patch but do you know if it's normal that to view the result in FF3 you have to view the page source (Ctrl+U) ? Same in Opera (but faster ;o) in IE7 I get an error... > Change the text of the Induce DB. > - > > Key: OFBIZ-1936 > URL: https://issues.apache.org/jira/browse/OFBIZ-1936 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: inducedb_text.patch > > > put the information in the text for the page > I took this from an email in 2006 > this was David's response > It's the datasource name. It doesn't need to be associated with a > delegator, just defined in entityengine.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1528) Can't reconfigure items once they are added to cart
[ https://issues.apache.org/jira/browse/OFBIZ-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627227#action_12627227 ] Jacques Le Roux commented on OFBIZ-1528: Hi Chris, Yes, fine indeed. I noticed that they use only dropdowns. This is also something we could consider, it's easier to deal with (less UI choices to do at coding level) > Can't reconfigure items once they are added to cart > --- > > Key: OFBIZ-1528 > URL: https://issues.apache.org/jira/browse/OFBIZ-1528 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Chris Lombardi >Assignee: Bilgin Ibryam >Priority: Minor > > Steps to duplicate. > 1. Add an aggregated item to your shopping cart in the ecommerce app. > 2. View your shopping cart. > 3. Click on the aggregated item in your shopping cart. > 4. A new, default aggregated item is shown, not the aggregated item with the > configuration your previously chose. > I'm not sure what the best practice is here, but the current process flow was > unexpected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1689) CASifying OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627230#action_12627230 ] Jacques Le Roux commented on OFBIZ-1689: Shi, I just realize now, this patch if for release4.0 only ? Did you testit in trunk since your last comment about that ? > CASifying OFBiz > --- > > Key: OFBIZ-1689 > URL: https://issues.apache.org/jira/browse/OFBIZ-1689 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Release Branch 4.0 >Reporter: Shi Yusen >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Release Branch 4.0 > > Attachments: ldap.zip, ofbiz4.0-ldap-patch-20080828.txt > > Original Estimate: 336h > Remaining Estimate: 336h > > I'll start my work on CASifying OFBiz, the method will be similar to this one: > http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms > Please keep this issue open, I'll post my code to this issue when it's done. > I'm eager to hear your suggestions on this topic. > TIA > Shi Yusen/Beijing Langhua Ltd. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: OFBiz self-hosting
Interesting idea... Looking forward for comments... Jacques From: "Bruno Busco" <[EMAIL PROTECTED]> Hi devs, the OFBiz CMS application is having more and more improvements and this is really good. However (as read on ML) more seems to be done. I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site instead of Confluence would be the best way to have all contributors to see how the CMS works and where it needs to be improved. Probably, at this stage, this will sound a crazy idea but I would like to hear what you guy that know the real OFBIZ CMS actual features think about it. Having a CMS hosting its own website is something obvious (all CMS do this). Of course OFBiz is not a CMS only but, again, I think this is the best way to power the CMS up. My two cents, Bruno
Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web
Quoting Vikas Mayur <[EMAIL PROTECTED]>: Bilgin, I am sorry that I just post this in hurry. The error comes when you click on create order link on order confirmation screen on order manager screen. Hope this helps ! - Vikas It should be fixed in r690564 Thanks for reporting Vikas. This message was sent using IMP, the Internet Messaging Program.
[jira] Commented: (OFBIZ-1936) Change the text of the Induce DB.
[ https://issues.apache.org/jira/browse/OFBIZ-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627238#action_12627238 ] BJ Freeman commented on OFBIZ-1936: --- I guess I should upgrade to test, but I don't want to effect my computer. i am still on FF2. seems everytime I upgrade with ms I have to spend a week dealing with things the ms has messed up. :D > Change the text of the Induce DB. > - > > Key: OFBIZ-1936 > URL: https://issues.apache.org/jira/browse/OFBIZ-1936 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: inducedb_text.patch > > > put the information in the text for the page > I took this from an email in 2006 > this was David's response > It's the datasource name. It doesn't need to be associated with a > delegator, just defined in entityengine.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1936) Change the text of the Induce DB.
[ https://issues.apache.org/jira/browse/OFBIZ-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627244#action_12627244 ] Jacques Le Roux commented on OFBIZ-1936: So true, I believe they do it on purpose... Like you know when they change all places in your usual supermarket : marketing evil ;) > Change the text of the Induce DB. > - > > Key: OFBIZ-1936 > URL: https://issues.apache.org/jira/browse/OFBIZ-1936 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: inducedb_text.patch > > > put the information in the text for the page > I took this from an email in 2006 > this was David's response > It's the datasource name. It doesn't need to be associated with a > delegator, just defined in entityengine.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r689772 - in /ofbiz/trunk: applications/product/data/ applications/product/servicedef/ applications/product/src/org/ofbiz/product/product/ applications/product/webapp/catalog/WEB-INF/
Something I forgot to mention
http://docs.ofbiz.org/pages/viewpage.action?pageId=4472
Jacques
From: "Jacques Le Roux" <[EMAIL PROTECTED]>
To:
Sent: Saturday, August 30, 2008 1:36 AM
Subject: Re: svn commit: r689772 - in /ofbiz/trunk: applications/product/data/ applications/product/servicedef/
applications/product/src/org/ofbiz/product/product/ applications/product/webapp/catalog/WEB-INF/
applications/product/webapp/catalog/WEB-INF/actions/prod
From: "Jacques Le Roux" <[EMAIL PROTECTED]>
From: "Vikas Mayur" <[EMAIL PROTECTED]>
Yeah, it would be good to have consensus on usage of groovy features not just on this semi-colon issue but others - if any
(which
I am not able to think of).
- Vikas
This might help http://groovy.codehaus.org/Differences+from+Java
For instance note the optional return in
http://groovy.codehaus.org/Differences+from+Java#DifferencesfromJava-Thingstobeawareof
This is interesting too
http://groovy.codehaus.org/Runtime+vs+Compile+time%2C+Static+vs+Dynamic
I also wondered if removing type when creating a variable was a good thing. It's obvious sometimes, somtimes not. But a rule for
that would be boolean, so we would have to rewrite them all ... tedious...
I had some other considerations, but, from the top of my head, the only one that really makes me hesitate was the semi-colon
issue. Optional return maybe also but we don't use them much in script...
Jacques
I'm not sure anybody used it in OFBiz yet but there are also optional
parenthesis
http://groovy.codehaus.org/Statements#Statements-Optionalparenthesis (another
interesting page :o)
Jacques
On Aug 28, 2008, at 4:38 PM, Jacques Le Roux wrote:
I'm divided. The 1st time I saw that in groovy scripts I checked and saw that
Groovy allows that.
My 1st reaction was, like you, to fix it. For me it was the same than not using {} for a single line in Java. It's like a
bomb
: sooner or later it may explode...
But then I thought that there are other differences between Java and Goovy,
why not allow this one ?
As I outlined above it's a bit dangerous, even Groovy authors point it out !
Of course I will follow consensus...
Jacques
From: "Vikas Mayur" <[EMAIL PROTECTED]>
On Aug 28, 2008, at 3:32 PM, [EMAIL PROTECTED] wrote:
Author: jleroux
Date: Thu Aug 28 03:02:47 2008
New Revision: 689772
URL: http://svn.apache.org/viewvc?rev=689772&view=rev
Log:
A patch from Mridul Pathak "Added support for uploading additional Product Views
(images)"
(https://issues.apache.org/jira/browse/OFBIZ-1930 ) - OFBIZ-1930
I fixed an, unrelated to patch, problem in EditProductContentContent.groovy. This is not the 1st time I cross this type
of
issue. I checked it does not appear on demo server and I guess it was not
appearing with bsh before. I'm not sure of its
origin but it seems related to my configuration. I use, from my machine default,
"Central European Summer Time" and demo
server uses "Central Daylight Time". But I can't see why it affects my machine and not the demo server : there is no
origin
here (maybe GMT, but obviously it's not the case)
The lines I added are (+ import)
} else {
fromDate = ObjectType.simpleTypeConvert(fromDate, "Timestamp", null, null,
false)
}
(I intentionnaly let the line without semi-colon as it's not mandatory in
Groovy)
I think we should stick to some guidelines on usage of groovy features especially semi-colon not mandatory, in OFBiz. This
is
just to make sure that code looks alike.
My preference is to use semicolon. Thoughts ?
- Vikas
Added:
ofbiz/trunk/framework/images/webapp/images/products/additional/
Modified:
ofbiz/trunk/applications/product/data/ProductTypeData.xml
ofbiz/trunk/applications/product/servicedef/services.xml
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/
ProductServices.java
ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/
product/EditProductContentContent.groovy
ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ controller.xml
ofbiz/trunk/applications/product/webapp/catalog/product/ ProductForms.xml
Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=689772&r1=689771&r2=689772&view=diff
= = = = = = = = = =
--- ofbiz/trunk/applications/product/data/ProductTypeData.xml (original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Thu Aug 28
03:02:47 2008
@@ -231,6 +231,10 @@
+
+
+
+
productContentTypeId="ADDTOCART_LABEL"/>
productContentTypeId="ADDTOCART_IMAGE"/>
Modified: ofbiz/trunk/applications/product/servicedef/services.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services.xml?rev=689772&r1=689771&r2=689772&view=diff
= = = = = = = = = =
=
[jira] Commented: (OFBIZ-1940) Add use of Groovy in Minilang as BeansShell is used now
[ https://issues.apache.org/jira/browse/OFBIZ-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627245#action_12627245 ] Jacques Le Roux commented on OFBIZ-1940: Something I forgot to mention, not totally related but interesting http://docs.ofbiz.org/pages/viewpage.action?pageId=4472 > Add use of Groovy in Minilang as BeansShell is used now > --- > > Key: OFBIZ-1940 > URL: https://issues.apache.org/jira/browse/OFBIZ-1940 > Project: OFBiz > Issue Type: New Feature >Reporter: Jacques Le Roux > > 2 interesting related links : > http://groovy.codehaus.org/Bean+Scripting+Framework > http://groovy.codehaus.org/JSR+223+Scripting+with+Groovy > The 2d could be used as soon as we officialy switch to Java 1.6... (though I > had only a cursory review of both articles) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r690573 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/payment/ party/src/org/ofbiz/party/contact/ party/src/org/ofbiz/party/party/ product/src/org/ofbiz/product/c
Why not at the next release ? But sometimes it's better to keep it forever
(working with API is hard)... So I think each case should
be discussed...
My 2 cents
Jacques
From: <[EMAIL PROTECTED]>
Author: lektran
Date: Sat Aug 30 13:05:40 2008
New Revision: 690573
URL: http://svn.apache.org/viewvc?rev=690573&view=rev
Log:
Added deprecation flags to the old jsp based worker methods, any thoughts on
how long a method should be deprecated for before we
can remove it?
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/project/ProjectWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
(original)
+++
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
Sat Aug 30 13:05:40 2008
@@ -49,6 +49,7 @@
private static int decimals =
UtilNumber.getBigDecimalScale("invoice.decimals");
private static int rounding =
UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
+/** @deprecated */
public static void getPartyPaymentMethodValueMaps(PageContext pageContext,
String partyId, boolean showOld, String
paymentMethodValueMapsAttr) {
GenericDelegator delegator = (GenericDelegator)
pageContext.getRequest().getAttribute("delegator");
List paymentMethodValueMaps = getPartyPaymentMethodValueMaps(delegator,
partyId, showOld);
@@ -92,6 +93,7 @@
}
/** TODO: REMOVE (DEJ 20030301): This is the OLD style and should be
removed when the eCommerce and party mgr JSPs are */
+/** @deprecated */
public static void getPaymentMethodAndRelated(PageContext pageContext,
String partyId,
String paymentMethodAttr, String creditCardAttr, String
eftAccountAttr, String paymentMethodIdAttr, String
curContactMechIdAttr,
String donePageAttr, String tryEntityAttr) {
Modified:
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
(original)
+++
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
Sat Aug 30 13:05:40 2008
@@ -20,9 +20,7 @@
package org.ofbiz.party.contact;
import java.util.Collection;
-import java.util.HashMap;
import java.util.Iterator;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
@@ -40,7 +38,6 @@
import org.ofbiz.entity.GenericEntityException;
import org.ofbiz.entity.GenericValue;
import org.ofbiz.entity.condition.EntityCondition;
-import org.ofbiz.entity.condition.EntityExpr;
import org.ofbiz.entity.util.EntityUtil;
/**
@@ -50,6 +47,7 @@
public static final String module = ContactMechWorker.class.getName();
+/** @deprecated */
public static void getPartyContactMechValueMaps(PageContext pageContext,
String partyId, boolean showOld, String
partyContactMechValueMapsAttr) {
GenericDelegator delegator = (GenericDelegator)
pageContext.getRequest().getAttribute("delegator");
List> partyContactMechValueMaps =
getPartyContactMechValueMaps(delegator, partyId, showOld);
@@ -205,6 +203,7 @@
}
+/** @deprecated */
public static void getOrderContactMechValueMaps(PageContext pageContext,
String orderId, String orderContactMechValueMapsAttr)
{
GenericDelegator delegator = (GenericDelegator)
pageContext.getRequest().getAttribute("delegator");
List> maps =
getOrderContactMechValueMaps(delegator, orderId);
Modified:
ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
--- ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
(original)
+++ ofbiz/trunk/applications
[jira] Commented: (OFBIZ-1936) Change the text of the Induce DB.
[ https://issues.apache.org/jira/browse/OFBIZ-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627254#action_12627254 ] BJ Freeman commented on OFBIZ-1936: --- I wish I could tell you some of the things I have heard in meetings, while contracting for MS. unfortunately, I am under a NDA. > Change the text of the Induce DB. > - > > Key: OFBIZ-1936 > URL: https://issues.apache.org/jira/browse/OFBIZ-1936 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: BJ Freeman >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: inducedb_text.patch > > > put the information in the text for the page > I took this from an email in 2006 > this was David's response > It's the datasource name. It doesn't need to be associated with a > delegator, just defined in entityengine.xml. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Method deprecation WAS svn commit: r690573 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/payment/ party/src/org/ofbiz/party/contact/ party/src/org/ofbiz/party/party/ product/src/
Removing deprecated methods before a release would be good but who
knows when that would be? A search reveals 121 matches for
@deprecated and I think it would be good to set a timeframe for their
removal. How about 12 months after deprecation or right before a
release (whichever comes first)?
Regards
Scott
2008/8/31 Jacques Le Roux <[EMAIL PROTECTED]>:
> Why not at the next release ? But sometimes it's better to keep it forever
> (working with API is hard)... So I think each case should
> be discussed...
>
> My 2 cents
>
> Jacques
>
> From: <[EMAIL PROTECTED]>
>>
>> Author: lektran
>> Date: Sat Aug 30 13:05:40 2008
>> New Revision: 690573
>>
>> URL: http://svn.apache.org/viewvc?rev=690573&view=rev
>> Log:
>> Added deprecation flags to the old jsp based worker methods, any thoughts
>> on how long a method should be deprecated for before we
>> can remove it?
>>
>> Modified:
>>
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
>>
>> ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
>>
>> ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
>>
>> ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
>>
>> ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
>>
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/project/ProjectWorker.java
>>
>> ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
>> URL:
>>
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java?rev=690573&r1=690572&r2=690573&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
>> (original)
>> +++
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
>> Sat Aug 30 13:05:40 2008
>> @@ -49,6 +49,7 @@
>>private static int decimals =
>> UtilNumber.getBigDecimalScale("invoice.decimals");
>>private static int rounding =
>> UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
>>
>> +/** @deprecated */
>>public static void getPartyPaymentMethodValueMaps(PageContext
>> pageContext, String partyId, boolean showOld, String
>> paymentMethodValueMapsAttr) {
>>GenericDelegator delegator = (GenericDelegator)
>> pageContext.getRequest().getAttribute("delegator");
>>List paymentMethodValueMaps =
>> getPartyPaymentMethodValueMaps(delegator, partyId, showOld);
>> @@ -92,6 +93,7 @@
>>}
>>
>>/** TODO: REMOVE (DEJ 20030301): This is the OLD style and should be
>> removed when the eCommerce and party mgr JSPs are */
>> +/** @deprecated */
>>public static void getPaymentMethodAndRelated(PageContext pageContext,
>> String partyId,
>>String paymentMethodAttr, String creditCardAttr, String
>> eftAccountAttr, String paymentMethodIdAttr, String
>> curContactMechIdAttr,
>>String donePageAttr, String tryEntityAttr) {
>>
>> Modified:
>> ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
>> URL:
>>
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java?rev=690573&r1=690572&r2=690573&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
>> (original)
>> +++
>> ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
>> Sat Aug 30 13:05:40 2008
>> @@ -20,9 +20,7 @@
>> package org.ofbiz.party.contact;
>>
>> import java.util.Collection;
>> -import java.util.HashMap;
>> import java.util.Iterator;
>> -import java.util.LinkedList;
>> import java.util.List;
>> import java.util.Map;
>>
>> @@ -40,7 +38,6 @@
>> import org.ofbiz.entity.GenericEntityException;
>> import org.ofbiz.entity.GenericValue;
>> import org.ofbiz.entity.condition.EntityCondition;
>> -import org.ofbiz.entity.condition.EntityExpr;
>> import org.ofbiz.entity.util.EntityUtil;
>>
>> /**
>> @@ -50,6 +47,7 @@
>>
>>public static final String module = ContactMechWorker.class.getName();
>>
>> +/** @deprecated */
>>public static void getPartyContactMechValueMaps(PageContext
>> pageContext, String partyId, boolean showOld, String
>> partyContactMechValueMapsAttr) {
>>GenericDelegator delegator = (GenericDelegator)
>> pageContext.getRequest().getAttribute("delegator");
>>List> partyContactMechValueMaps =
>> getPartyContactMechValueMaps(delegator, partyId, showOld);
>> @@ -205,6 +203,7 @@
>>}
>>
>>
>> +/** @deprecated */
>>public static void getOrderContactMechValueMaps(PageContext
>> pageContext, String orderId, String ord
Typo error in keywordsearch.ftl
Hi, in file applications\order\webapp\ordermgr\entry\catalog\keywordsearch.ftl at line 30 there is a typo error that causes the refine search not work properly. Please change from: (reqeustParameters.SEARCH_CATEGORY_ID to: requestParameters.SEARCH_CATEGORY_ID -Bruno
Re: Method deprecation WAS svn commit: r690573 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/payment/ party/src/org/ofbiz/party/contact/ party/src/org/ofbiz/party/party/ product/
While deprecations is okay pretty much any time, removing methods or anything else is maybe better done just after a
release branch. That was people can more easily use the release branch, and when upgrading in the future know that there
may be some effort involved.
The idea is the same though, ie that moving from one release to another chances are you'll have functionality changes
that you may have to adjust your code for. The only difference is that if we're going to do it close to a release let's
do it just after instead of just before so that people using release branches have more time to adjust.
-David
Scott Gray wrote:
Removing deprecated methods before a release would be good but who
knows when that would be? A search reveals 121 matches for
@deprecated and I think it would be good to set a timeframe for their
removal. How about 12 months after deprecation or right before a
release (whichever comes first)?
Regards
Scott
2008/8/31 Jacques Le Roux <[EMAIL PROTECTED]>:
Why not at the next release ? But sometimes it's better to keep it forever
(working with API is hard)... So I think each case should
be discussed...
My 2 cents
Jacques
From: <[EMAIL PROTECTED]>
Author: lektran
Date: Sat Aug 30 13:05:40 2008
New Revision: 690573
URL: http://svn.apache.org/viewvc?rev=690573&view=rev
Log:
Added deprecation flags to the old jsp based worker methods, any thoughts
on how long a method should be deprecated for before we
can remove it?
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/project/ProjectWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
(original)
+++
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
Sat Aug 30 13:05:40 2008
@@ -49,6 +49,7 @@
private static int decimals =
UtilNumber.getBigDecimalScale("invoice.decimals");
private static int rounding =
UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
+/** @deprecated */
public static void getPartyPaymentMethodValueMaps(PageContext
pageContext, String partyId, boolean showOld, String
paymentMethodValueMapsAttr) {
GenericDelegator delegator = (GenericDelegator)
pageContext.getRequest().getAttribute("delegator");
List paymentMethodValueMaps =
getPartyPaymentMethodValueMaps(delegator, partyId, showOld);
@@ -92,6 +93,7 @@
}
/** TODO: REMOVE (DEJ 20030301): This is the OLD style and should be
removed when the eCommerce and party mgr JSPs are */
+/** @deprecated */
public static void getPaymentMethodAndRelated(PageContext pageContext,
String partyId,
String paymentMethodAttr, String creditCardAttr, String
eftAccountAttr, String paymentMethodIdAttr, String
curContactMechIdAttr,
String donePageAttr, String tryEntityAttr) {
Modified:
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
(original)
+++
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
Sat Aug 30 13:05:40 2008
@@ -20,9 +20,7 @@
package org.ofbiz.party.contact;
import java.util.Collection;
-import java.util.HashMap;
import java.util.Iterator;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
@@ -40,7 +38,6 @@
import org.ofbiz.entity.GenericEntityException;
import org.ofbiz.entity.GenericValue;
import org.ofbiz.entity.condition.EntityCondition;
-import org.ofbiz.entity.condition.EntityExpr;
import org.ofbiz.entity.util.EntityUtil;
/**
@@ -50,6 +47,7 @@
public static final String module = ContactMechWorker.class.getName();
+/** @deprecated */
public static void getPartyContactMechValueMaps(PageContext
pageContext, String partyId, boolean showOld, String
partyContactMechValueMapsAttr) {
GenericDelegator delegator = (GenericDelegator
Re: Idea: OFBiz self-hosting
Bruno Busco wrote: Hi devs, the OFBiz CMS application is having more and more improvements and this is really good. However (as read on ML) more seems to be done. I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site instead of Confluence would be the best way to have all contributors to see how the CMS works and where it needs to be improved. Probably, at this stage, this will sound a crazy idea but I would like to hear what you guy that know the real OFBIZ CMS actual features think about it. When you wrote www.ofbiz.org did you mean "ofbiz.apache.org" or "docs.ofbiz.org"? If you meant ofbiz.apache.org, then we'd have to come up with something pretty creative that not only allows for content management, but also did a static HTML export since that's all we can do on that server. Even if we did that we'd have to work with the ASF infra to figure out where to host an instance of OFBiz that could be used to drive the exports for the site. If you meant docs.ofbiz.org then we'd have to write something that offers sufficient wiki functionality to replace the confluence application running there. That would certainly be done based on the OFBiz content management stuff, but it hasn't been done yet. -David
Re: OFBiz self-hosting
I like the Geronimo Project site http://geronimo.apache.org/, wish we could see something like that in OFbiz home page.. Enrique Ruibal jacques.le.roux wrote: > > Interesting idea... Looking forward for comments... > > Jacques > > From: "Bruno Busco" <[EMAIL PROTECTED]> >> Hi devs, >> the OFBiz CMS application is having more and more improvements and this >> is >> really good. However (as read on ML) more seems to be done. >> >> I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site >> instead of Confluence would be the best way to have all contributors to >> see >> how the CMS works and where it needs to be improved. >> Probably, at this stage, this will sound a crazy idea but I would like to >> hear what you guy that know the real OFBIZ CMS actual features think >> about >> it. >> >> Having a CMS hosting its own website is something obvious (all CMS do >> this). >> Of course OFBiz is not a CMS only but, again, I think this is the best >> way >> to power the CMS up. >> >> My two cents, >> Bruno >> > > -- View this message in context: http://www.nabble.com/Idea%3A-OFBiz-self-hosting-tp19235405p19239491.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz self-hosting
I'm interested in what you mean by this... What is it that you like on the Geronimo site? -David Enrique Ruibal wrote: I like the Geronimo Project site http://geronimo.apache.org/, wish we could see something like that in OFbiz home page.. Enrique Ruibal jacques.le.roux wrote: Interesting idea... Looking forward for comments... Jacques From: "Bruno Busco" <[EMAIL PROTECTED]> Hi devs, the OFBiz CMS application is having more and more improvements and this is really good. However (as read on ML) more seems to be done. I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site instead of Confluence would be the best way to have all contributors to see how the CMS works and where it needs to be improved. Probably, at this stage, this will sound a crazy idea but I would like to hear what you guy that know the real OFBIZ CMS actual features think about it. Having a CMS hosting its own website is something obvious (all CMS do this). Of course OFBiz is not a CMS only but, again, I think this is the best way to power the CMS up. My two cents, Bruno
Re: OFBiz self-hosting
1) First of all you have a search box on the main page I assume it is useful to search the whole site, including wiki pages. 2) you have nabble forumes nicely embedded in the portal page 3) You have main issues resolved / Opened on the main page 4) You have a newer version of confluence in their wiki with navigation buttons and all.. Those are a few things a I notice a first glance Enrique Ruibal David E. Jones-2 wrote: > > > I'm interested in what you mean by this... > > What is it that you like on the Geronimo site? > > -David > > > Enrique Ruibal wrote: >> I like the Geronimo Project site http://geronimo.apache.org/, wish we >> could >> see something like that in OFbiz home page.. >> >> Enrique Ruibal >> >> >> >> jacques.le.roux wrote: >>> Interesting idea... Looking forward for comments... >>> >>> Jacques >>> >>> From: "Bruno Busco" <[EMAIL PROTECTED]> Hi devs, the OFBiz CMS application is having more and more improvements and this is really good. However (as read on ML) more seems to be done. I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site instead of Confluence would be the best way to have all contributors to see how the CMS works and where it needs to be improved. Probably, at this stage, this will sound a crazy idea but I would like to hear what you guy that know the real OFBIZ CMS actual features think about it. Having a CMS hosting its own website is something obvious (all CMS do this). Of course OFBiz is not a CMS only but, again, I think this is the best way to power the CMS up. My two cents, Bruno >>> >> > > -- View this message in context: http://www.nabble.com/Idea%3A-OFBiz-self-hosting-tp19235405p19239590.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: ofbiz upgrade doc
We definitely need to discuss this more... The main thing to consider when updating is entities with primary key changes, which should ALWAYS be done by deprecating the current entity and creating a new one, and creating a service to move the data from the old entity to the new one. There is really no excuse for not doing so, and while I've reminded people about it a few times I'm tempted to start reverting commits if people don't do this. Yes, it's that important. Saying that someone should do this manually through an export and import is a bad idea and a real PITA, even with separate old and new entities. As for seed data: the way "seed data" is defined and used means that it should ALWAYS be reloaded when updating an existing system. The pattern and how and such is pretty well explained in the ofbiz/build.xml file. Also, there are lots of things that people can do when updating, but don't really have to. Removing unused tables is a good example of this. Usually server capacity is way cheaper than human time. -David Hans Bakker wrote: I created a first version of a OFBiz system upgrade document. any comments welcome. http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier +revisions
Re: Method deprecation WAS svn commit: r690573 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/payment/ party/src/org/ofbiz/party/contact/ party/src/org/ofbiz/party/party/ product/
I will vote for "just after the release is created".
Jacques
From: "David E. Jones" <[EMAIL PROTECTED]>
While deprecations is okay pretty much any time, removing methods or anything else is maybe better done just after a release
branch. That was people can more easily use the release branch, and when upgrading in the future know that there may be some
effort involved.
The idea is the same though, ie that moving from one release to another chances are you'll have functionality changes that you may
have to adjust your code for. The only difference is that if we're going to do it close to a release let's do it just after
instead of just before so that people using release branches have more time to adjust.
-David
Scott Gray wrote:
Removing deprecated methods before a release would be good but who
knows when that would be? A search reveals 121 matches for
@deprecated and I think it would be good to set a timeframe for their
removal. How about 12 months after deprecation or right before a
release (whichever comes first)?
Regards
Scott
2008/8/31 Jacques Le Roux <[EMAIL PROTECTED]>:
Why not at the next release ? But sometimes it's better to keep it forever
(working with API is hard)... So I think each case should
be discussed...
My 2 cents
Jacques
From: <[EMAIL PROTECTED]>
Author: lektran
Date: Sat Aug 30 13:05:40 2008
New Revision: 690573
URL: http://svn.apache.org/viewvc?rev=690573&view=rev
Log:
Added deprecation flags to the old jsp based worker methods, any thoughts
on how long a method should be deprecated for before we
can remove it?
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
ofbiz/trunk/applications/party/src/org/ofbiz/party/party/PartyWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/project/ProjectWorker.java
ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
Modified:
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
(original)
+++
ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
Sat Aug 30 13:05:40 2008
@@ -49,6 +49,7 @@
private static int decimals =
UtilNumber.getBigDecimalScale("invoice.decimals");
private static int rounding =
UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
+/** @deprecated */
public static void getPartyPaymentMethodValueMaps(PageContext
pageContext, String partyId, boolean showOld, String
paymentMethodValueMapsAttr) {
GenericDelegator delegator = (GenericDelegator)
pageContext.getRequest().getAttribute("delegator");
List paymentMethodValueMaps =
getPartyPaymentMethodValueMaps(delegator, partyId, showOld);
@@ -92,6 +93,7 @@
}
/** TODO: REMOVE (DEJ 20030301): This is the OLD style and should be
removed when the eCommerce and party mgr JSPs are */
+/** @deprecated */
public static void getPaymentMethodAndRelated(PageContext pageContext,
String partyId,
String paymentMethodAttr, String creditCardAttr, String
eftAccountAttr, String paymentMethodIdAttr, String
curContactMechIdAttr,
String donePageAttr, String tryEntityAttr) {
Modified:
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java?rev=690573&r1=690572&r2=690573&view=diff
==
---
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
(original)
+++
ofbiz/trunk/applications/party/src/org/ofbiz/party/contact/ContactMechWorker.java
Sat Aug 30 13:05:40 2008
@@ -20,9 +20,7 @@
package org.ofbiz.party.contact;
import java.util.Collection;
-import java.util.HashMap;
import java.util.Iterator;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
@@ -40,7 +38,6 @@
import org.ofbiz.entity.GenericEntityException;
import org.ofbiz.entity.GenericValue;
import org.ofbiz.entity.condition.EntityCondition;
-import org.ofbiz.entity.condition.EntityExpr;
import org.ofbiz.entity.util.EntityUtil;
/**
@@ -50,6 +47,7 @@
public static final String module = ContactMechWorker.class.getName();
+/** @deprecated */
public static void getPartyContactMechValueMaps(PageContext
pageContext, String partyId, boo
Re: ofbiz upgrade doc
From: "David E. Jones" <[EMAIL PROTECTED]> We definitely need to discuss this more... The main thing to consider when updating is entities with primary key changes, which should ALWAYS be done by deprecating the current entity and creating a new one, and creating a service to move the data from the old entity to the new one. There is really no excuse for not doing so, and while I've reminded people about it a few times I'm tempted to start reverting commits if people don't do this. Yes, it's that important. Saying that someone should do this manually through an export and import is a bad idea and a real PITA, even with separate old and new entities. +1 As for seed data: the way "seed data" is defined and used means that it should ALWAYS be reloaded when updating an existing system. The pattern and how and such is pretty well explained in the ofbiz/build.xml file. +1 Also, there are lots of things that people can do when updating, but don't really have to. Removing unused tables is a good example of this. Usually server capacity is way cheaper than human time. +1 Ready for discussion :o) Jacques -David Hans Bakker wrote: I created a first version of a OFBiz system upgrade document. any comments welcome. http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier +revisions
Re: Idea: OFBiz self-hosting
David, I meant docs.ofbiz.org, the one that is hosted at hotwaxmedia (more controllable). IMO the confluence wiki functionality is surely usefull but not strictly necessary and in OFBiz it is not as urgent as an user friendly CMS feature. For instance at http://drupal.org/handbooks they handle all the documentation, the contributed modules repository and more, without wiki, just CMS. And it looks very well !! Does the OFBIz CMS handle the contents versioning? If yes it could be enough. -Bruno 2008/8/31 David E. Jones <[EMAIL PROTECTED]> > > > Bruno Busco wrote: > >> Hi devs, >> the OFBiz CMS application is having more and more improvements and this is >> really good. However (as read on ML) more seems to be done. >> >> I was thinking that a using OFBiz CMS to host the www.ofbiz.org web site >> instead of Confluence would be the best way to have all contributors to >> see >> how the CMS works and where it needs to be improved. >> Probably, at this stage, this will sound a crazy idea but I would like to >> hear what you guy that know the real OFBIZ CMS actual features think about >> it. >> > > When you wrote www.ofbiz.org did you mean "ofbiz.apache.org" or " > docs.ofbiz.org"? > > If you meant ofbiz.apache.org, then we'd have to come up with something > pretty creative that not only allows for content management, but also did a > static HTML export since that's all we can do on that server. Even if we did > that we'd have to work with the ASF infra to figure out where to host an > instance of OFBiz that could be used to drive the exports for the site. > > If you meant docs.ofbiz.org then we'd have to write something that offers > sufficient wiki functionality to replace the confluence application running > there. That would certainly be done based on the OFBiz content management > stuff, but it hasn't been done yet. > > -David > >
Re: Typo error in keywordsearch.ftl
Thanks Bruno, Fixed in revision 690644. Jacques From: "Bruno Busco" <[EMAIL PROTECTED]> Hi, in file applications\order\webapp\ordermgr\entry\catalog\keywordsearch.ftl at line 30 there is a typo error that causes the refine search not work properly. Please change from: (reqeustParameters.SEARCH_CATEGORY_ID to: requestParameters.SEARCH_CATEGORY_ID -Bruno
