[jira] Updated: (OFBIZ-2924) Duplicate specification of attribute "type" for script tag.

2009-09-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-2924:


Attachment: OFBIZ-2924.patch

Here is the patch for this issue.

> Duplicate specification of attribute "type" for script tag.
> ---
>
> Key: OFBIZ-2924
> URL: https://issues.apache.org/jira/browse/OFBIZ-2924
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Release Branch 9.04, SVN trunk
>Reporter: Deepak Dixit
>Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2924.patch
>
>
> Duplicate specification of attribute "type" for script tag in headerHead.ftl. 
> It gave error while validating in XHTML.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2924) Duplicate specification of attribute "type" for script tag.

2009-09-09 Thread Deepak Dixit (JIRA)
Duplicate specification of attribute "type" for script tag.
---

 Key: OFBIZ-2924
 URL: https://issues.apache.org/jira/browse/OFBIZ-2924
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Deepak Dixit
Priority: Minor
 Fix For: Release Branch 9.04, SVN trunk


Duplicate specification of attribute "type" for script tag in headerHead.ftl. 
It gave error while validating in XHTML.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2415) createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment security related error

2009-09-09 Thread Amit Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753456#action_12753456
 ] 

Amit Sharma commented on OFBIZ-2415:


Hi Jacques,

Please close this issue because its is fixed at r778653.

Regards,
-Amit Sharma

> createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment 
> security related error
> -
>
> Key: OFBIZ-2415
> URL: https://issues.apache.org/jira/browse/OFBIZ-2415
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Reporter: Amit Sharma
>Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: editorderitems.patch, editorderitems.patch
>
>
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
> parameter [orderAdjustmentId] passed to secure (https) request-map with uri 
> [createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2425) Set Profile Default link on View Profile in eCommerce

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753450#action_12753450
 ] 

Jacques Le Roux commented on OFBIZ-2425:


Any update ?

> Set Profile Default link on View Profile in eCommerce
> -
>
> Key: OFBIZ-2425
> URL: https://issues.apache.org/jira/browse/OFBIZ-2425
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ecommerce
>Affects Versions: Release Branch 9.04, SVN trunk
>Reporter: Vikas Mayur
>Assignee: Vikas Mayur
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: setProfileDefaultLink.patch
>
>
> Steps:
> 1) Login in eCommerce app using DemoCustomer/ofbiz
> 2) Click on Profile to see the profile of this user.
> 3) Go to Payment Method Information section. If there is no payment method 
> then create a credit card.
> 4) Once their is a payment method, click on the link "Set Default" and now 
> you see the error.
> Note: This issue is reported by Pranay Pandey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2415) createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment security related error

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753451#action_12753451
 ] 

Jacques Le Roux commented on OFBIZ-2415:


Any update ?

> createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment 
> security related error
> -
>
> Key: OFBIZ-2415
> URL: https://issues.apache.org/jira/browse/OFBIZ-2415
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Reporter: Amit Sharma
>Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: editorderitems.patch, editorderitems.patch
>
>
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
> parameter [orderAdjustmentId] passed to secure (https) request-map with uri 
> [createOrderAdjustment, updateOrderAdjustment and deleteOrderAdjustment].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2714) Delete Product from Category

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753444#action_12753444
 ] 

Jacques Le Roux commented on OFBIZ-2714:


Any update ?

> Delete Product from Category
> 
>
> Key: OFBIZ-2714
> URL: https://issues.apache.org/jira/browse/OFBIZ-2714
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: SVN trunk
>Reporter: Evangelina Bowman
>Assignee: Jacques Le Roux
> Attachments: EditCategoryProducts.patch
>
>
> I get the following error when trying to delete a Product from a Category:
> The Following Errors Occurred:
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
> parameter [productCategoryId] passed to secure (https) request-map with uri 
> [removeCategoryProductMember] with an event that calls service 
> [removeProductFromCategory]; this is not allowed for security reasons! The 
> data should be encrypted by making it part of the request body (a form field) 
> instead of the request URL. Moreover it would be kind if you could create a 
> Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check 
> before if a sub-task for this error does not exist). If you are not sure how 
> to create a Jira issue please have a look before at 
> http://docs.ofbiz.org/x/r. Thank you in advance for your help.
> Thank you,
> Evangelina Bowman
> ebow...@globalera.com

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1533) Order Lookup fails with "Order not found with ID [XXXXX], or not allowed to view" message while sending email confirmation from order manager

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753440#action_12753440
 ] 

Jacques Le Roux commented on OFBIZ-1533:


Any tries ?

> Order Lookup fails with "Order not found with ID [X], or not allowed to 
> view" message while sending email confirmation from order manager
> -
>
> Key: OFBIZ-1533
> URL: https://issues.apache.org/jira/browse/OFBIZ-1533
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 4.0, SVN trunk
> Environment: Ubuntu 7.10
>Reporter: Raj Saini
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: orderstatus.bsh-trunk.patch, 
> orderstatus.bsh.branch-4.0.patch
>
>
> order lookup fails and following messages, while sending email confirmation 
> from the order manager for orders created through the e-commerce or the order 
> entry.
> "Order not found with ID [X], or not allowed to view"  where [X] is 
> the order id.
> How to reproduce:
> 1. Create an order form e-commerce by logging in (as registered user).
> 2. Goto the order manager and login with FULLADMIN or ORDERADMIN security 
> group permission.
> 3. Lookup the newly created order.
> 4. Click on the send confirmation button in the top right area of the order 
> screen.
> 5. It will open up a window with the email text. Email text shows the above 
> message instead of actual order confirmation html.
> 6. You can repeat the above by creating an order from Order Entry as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1086) Show prices incl. VAT in shoppingcart Total and miniproductsummary

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1086.
--

Resolution: Fixed

This should be fixed now

> Show prices incl. VAT in shoppingcart Total and miniproductsummary
> --
>
> Key: OFBIZ-1086
> URL: https://issues.apache.org/jira/browse/OFBIZ-1086
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Thomas Herzog
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: carttotal_miniproductsummary_prices__incl_VAT.diff
>
>
> In current implementation of VAT displays a mixture of incl. and excl. prices 
> in some ecommerce screens. This patch shows prices incl. VAT for Mini 
> Shopping Cart Total, Micro Shopping Cart Total (displayed in the Header), 
> Last Products Minibox and Quick Reorder... Minibox.
> It also solves issuses left open in OFBIZ-113.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2913) Write a new service for quick create customer profile.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753438#action_12753438
 ] 

Jacques Le Roux commented on OFBIZ-2913:


Should we not close ?

> Write a new service for quick create customer profile.
> --
>
> Key: OFBIZ-2913
> URL: https://issues.apache.org/jira/browse/OFBIZ-2913
> Project: OFBiz
>  Issue Type: New Feature
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Sumit Pandit
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2913.patch, OFBIZ-2913.patch
>
>
> Write a new service for creating a customer profile. This could be called as 
> QuickCreateCustomerProfile.
> Create a Customer Profile based on following IN parameter - 
> 1) First Name 
> 2) Last Name
> 3) Email Address
> Based on above information create - Person, Party, PartyRole (CUSTOMER), 
> Contact (Email).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread Scott Gray (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Gray closed OFBIZ-2833.
-

   Resolution: Fixed
Fix Version/s: SVN trunk
 Assignee: Scott Gray

Using ObjectType.simpleTypeConvert seems to fix the issue, committed in 
r813232.  Thanks for the detailed report Miles.

> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>Assignee: Scott Gray
> Fix For: SVN trunk
>
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753418#action_12753418
 ] 

Scott Gray commented on OFBIZ-2833:
---

The problem is right here:
{code}
paymentTypeAmount = new 
BigDecimal(NumberFormat.getNumberInstance(locale).parse(amountStr).doubleValue());
{code}

what we need is a better way to parse a localized amount into a BigDecimal that 
doen't require an intermediate double.

> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Hans Bakker
Yes You are right it is the requestViewwhat i think is ok because
the same view needs the same help screen?


On Thu, 2009-09-10 at 11:31 +0700, Hans Bakker wrote:
> Hi Scott, i had some duplicates in the invoice i just changed it:
> the generation of the helpTopic is now:
> websiteId + request
> 
> if longer than 20:
> 
> the first 15 characters of the total string(websiteId + request) + the
> last 5
> 
> request within a website=controller.xml is unique
> 
> Regards,
> Hans
> 
> 
> On Thu, 2009-09-10 at 16:15 +1200, Scott Gray wrote:
> > Okay I had a quick look at helptopic.ftl and from what I can see the  
> > desire is to load a help page for that screen without actually having  
> > each screen point to the help contentId explicitly.
> > 
> > It is done by the following convention:
> > contentId = (websiteId +  
> > requestAttributes._CURRENT_VIEW_).substring(0, 20)
> > 
> > The current filename convention is then:
> > "HELP_" + contentId + ".xml"
> > 
> > What is the plan of attack when you get more than one view sub- 
> > stringing to the same value?
> > 
> > Anybody have any thoughts on how we could better use the content model  
> > to handle these view specific content records?
> > 
> > Regards
> > Scott
> > 
> > On 10/09/2009, at 3:53 PM, Hans Bakker wrote:
> > 
> > > Hi Scott,
> > >
> > > What is required to easily find file related to the topicHelp variable
> > > in helpLink.ftl.
> > >
> > > I simply put "HELP_" in front of it
> > >
> > > You name is nice to read but has no relation to the helptopic what is
> > > required.
> > >
> > > in the case below:
> > >
> > > helpTopic = ACCOUNTING_editInvoi
> > > filename: HELP_ACCOUNTING_editInvoi.xml
> > >
> > > Regards,
> > > Hans
> > >
> > >
> > > On Thu, 2009-09-10 at 13:37 +1200, Scott Gray wrote:
> > >> Hi Hans
> > >>
> > >> Following on from what Ashish brought up about the naming convention
> > >> of the help files, I'm struggling to see the need for the strange  
> > >> names.
> > >>
> > >> If they are only referenced by DataResource.objectInfo and the names
> > >> don't actually contain any information required by the rendering
> > >> logic, couldn't we make them more intuitive?
> > >>
> > >> For example instead of:
> > >> HELP_ACCOUNTING_editInvoi.xml
> > >> why can't the name be:
> > >> HelpAccountingEditInvoice.xml
> > >>
> > >> Thanks
> > >> Scott
> > >>
> > >> HotWax Media
> > >> http://www.hotwaxmedia.com
> > >>
> > >> On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:
> > >>
> > >>> Author: hansbak
> > >>> Date: Thu Sep 10 01:21:20 2009
> > >>> New Revision: 813189
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?rev=813189&view=rev
> > >>> Log:
> > >>> invoice help screens contributed by Sharon Foga
> > >>>
> > >>> Added:
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_editInvoi.xml   (with props)
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_findInvoi.xml   (with props)
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_invoiceOv.xml   (with props)
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_invoiceRo.xml   (with props)
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_listInvoi.xml   (with props)
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_sendPerEm.xml   (with props)
> > >>> Modified:
> > >>>   ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING.xml
> > >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_main.xml
> > >>>   ofbiz/trunk/applications/accounting/documents/Accounting.xml
> > >>>
> > >>> Modified: ofbiz/trunk/applications/accounting/data/
> > >>> AccountingHelpData.xml
> > >>> URL: 
> > >>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
> > >>> =
> > >>> =
> > >>> =
> > >>> =
> > >>> =
> > >>> =
> > >>> =
> > >>> =
> > >>> = 
> > >>> = 
> > >>> 
> > >>> --- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> > >>> (original)
> > >>> +++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> > >>> Thu Sep 10 01:21:20 2009
> > >>> @@ -29,4 +29,34 @@
> > >>>objectInfo="applications/accounting/data/helpdata/
> > >>> HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"
> > >>> statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"
> > >>> mimeTypeId="text/xml" isPublic="Y" />
> > >>> > >>> contentName="Accounting Main Help"
> > >>> templateDataResourceId="HELP_TEMPL" dataResourceId="ACCOUNTING_main"
> > >>> statusId="CTNT_IN_PROGRESS" mimeTypeId="text/html"/>/>
> > >>> > >>> contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"
> > >>> fromDate="2006-01-12 

Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Hans Bakker
Hi Scott, i had some duplicates in the invoice i just changed it:
the generation of the helpTopic is now:
websiteId + request

if longer than 20:

the first 15 characters of the total string(websiteId + request) + the
last 5

request within a website=controller.xml is unique

Regards,
Hans


On Thu, 2009-09-10 at 16:15 +1200, Scott Gray wrote:
> Okay I had a quick look at helptopic.ftl and from what I can see the  
> desire is to load a help page for that screen without actually having  
> each screen point to the help contentId explicitly.
> 
> It is done by the following convention:
> contentId = (websiteId +  
> requestAttributes._CURRENT_VIEW_).substring(0, 20)
> 
> The current filename convention is then:
> "HELP_" + contentId + ".xml"
> 
> What is the plan of attack when you get more than one view sub- 
> stringing to the same value?
> 
> Anybody have any thoughts on how we could better use the content model  
> to handle these view specific content records?
> 
> Regards
> Scott
> 
> On 10/09/2009, at 3:53 PM, Hans Bakker wrote:
> 
> > Hi Scott,
> >
> > What is required to easily find file related to the topicHelp variable
> > in helpLink.ftl.
> >
> > I simply put "HELP_" in front of it
> >
> > You name is nice to read but has no relation to the helptopic what is
> > required.
> >
> > in the case below:
> >
> > helpTopic = ACCOUNTING_editInvoi
> > filename: HELP_ACCOUNTING_editInvoi.xml
> >
> > Regards,
> > Hans
> >
> >
> > On Thu, 2009-09-10 at 13:37 +1200, Scott Gray wrote:
> >> Hi Hans
> >>
> >> Following on from what Ashish brought up about the naming convention
> >> of the help files, I'm struggling to see the need for the strange  
> >> names.
> >>
> >> If they are only referenced by DataResource.objectInfo and the names
> >> don't actually contain any information required by the rendering
> >> logic, couldn't we make them more intuitive?
> >>
> >> For example instead of:
> >> HELP_ACCOUNTING_editInvoi.xml
> >> why can't the name be:
> >> HelpAccountingEditInvoice.xml
> >>
> >> Thanks
> >> Scott
> >>
> >> HotWax Media
> >> http://www.hotwaxmedia.com
> >>
> >> On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:
> >>
> >>> Author: hansbak
> >>> Date: Thu Sep 10 01:21:20 2009
> >>> New Revision: 813189
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=813189&view=rev
> >>> Log:
> >>> invoice help screens contributed by Sharon Foga
> >>>
> >>> Added:
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_editInvoi.xml   (with props)
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_findInvoi.xml   (with props)
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_invoiceOv.xml   (with props)
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_invoiceRo.xml   (with props)
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_listInvoi.xml   (with props)
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_sendPerEm.xml   (with props)
> >>> Modified:
> >>>   ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING.xml
> >>>   ofbiz/trunk/applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_main.xml
> >>>   ofbiz/trunk/applications/accounting/documents/Accounting.xml
> >>>
> >>> Modified: ofbiz/trunk/applications/accounting/data/
> >>> AccountingHelpData.xml
> >>> URL: 
> >>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
> >>> =
> >>> =
> >>> =
> >>> =
> >>> =
> >>> =
> >>> =
> >>> =
> >>> = 
> >>> = 
> >>> 
> >>> --- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> >>> (original)
> >>> +++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> >>> Thu Sep 10 01:21:20 2009
> >>> @@ -29,4 +29,34 @@
> >>>objectInfo="applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"
> >>> statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"
> >>> mimeTypeId="text/xml" isPublic="Y" />
> >>> >>> contentName="Accounting Main Help"
> >>> templateDataResourceId="HELP_TEMPL" dataResourceId="ACCOUNTING_main"
> >>> statusId="CTNT_IN_PROGRESS" mimeTypeId="text/html"/>/>
> >>> >>> contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"
> >>> fromDate="2006-01-12 01:01:01" sequenceNum="000"/>
> >>> +
> >>> + >>> localeString="en" dataResourceTypeId="OFBIZ_FILE"
> >>> +objectInfo="applications/accounting/data/helpdata/
> >>> HELP_ACCOUNTING_findInvoi.xml" dataTemplateTypeId="NONE"
> >>> statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Find
> >>> Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
> >>> + >>> contentTypeId="DOCUMENT" contentName="Accounting Find Invoices Help"
> >>> tem

[jira] Commented: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread Miles Huang (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753414#action_12753414
 ] 

Miles Huang commented on OFBIZ-2833:


May I suggest if someone familiar with JDBC specification can check this 
problem?
If the JDBC specification has clarified that the JDBC driver should do the 
number round operation in round half up mode, then its okay that OFBiz relies 
on the JDBC specification to do the round operation. This issue could be 
considered as a Derby bug.
Otherwise, may we still consider this is an OFBiz bug? Although this bug 
condition will not be triggered on some specific kinds of DB, it may be 
triggered by others, may be someday in the future.

Best Regards,
Miles.





> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Scott Gray
Okay I had a quick look at helptopic.ftl and from what I can see the  
desire is to load a help page for that screen without actually having  
each screen point to the help contentId explicitly.


It is done by the following convention:
contentId = (websiteId +  
requestAttributes._CURRENT_VIEW_).substring(0, 20)


The current filename convention is then:
"HELP_" + contentId + ".xml"

What is the plan of attack when you get more than one view sub- 
stringing to the same value?


Anybody have any thoughts on how we could better use the content model  
to handle these view specific content records?


Regards
Scott

On 10/09/2009, at 3:53 PM, Hans Bakker wrote:


Hi Scott,

What is required to easily find file related to the topicHelp variable
in helpLink.ftl.

I simply put "HELP_" in front of it

You name is nice to read but has no relation to the helptopic what is
required.

in the case below:

helpTopic = ACCOUNTING_editInvoi
filename: HELP_ACCOUNTING_editInvoi.xml

Regards,
Hans


On Thu, 2009-09-10 at 13:37 +1200, Scott Gray wrote:

Hi Hans

Following on from what Ashish brought up about the naming convention
of the help files, I'm struggling to see the need for the strange  
names.


If they are only referenced by DataResource.objectInfo and the names
don't actually contain any information required by the rendering
logic, couldn't we make them more intuitive?

For example instead of:
HELP_ACCOUNTING_editInvoi.xml
why can't the name be:
HelpAccountingEditInvoice.xml

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:


Author: hansbak
Date: Thu Sep 10 01:21:20 2009
New Revision: 813189

URL: http://svn.apache.org/viewvc?rev=813189&view=rev
Log:
invoice help screens contributed by Sharon Foga

Added:
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_editInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_findInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_invoiceOv.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_invoiceRo.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_listInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_sendPerEm.xml   (with props)
Modified:
  ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING.xml
  ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_main.xml
  ofbiz/trunk/applications/accounting/documents/Accounting.xml

Modified: ofbiz/trunk/applications/accounting/data/
AccountingHelpData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
=
=
=
=
=
=
=
=
= 
= 


--- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
(original)
+++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
Thu Sep 10 01:21:20 2009
@@ -29,4 +29,34 @@
   objectInfo="applications/accounting/data/helpdata/
HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"
mimeTypeId="text/xml" isPublic="Y" />
   />
   
+
+
+/>
+
+
+
+/>
+
+
+
+/>
+
+
+
+/>
+
+
+
+/>
+
+
+
+/>
+


Modified: ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/helpdata/HELP_ACCOUNTING.xml?rev=813189&r1=813188&r2=813189&view=diff
=
=
=
=
=
=
=
=
= 
= 


--- ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING.xml (original)
+++ ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING.xml Thu Sep 10 01:21:20 2009
@@ -1,21 +1,21 @@


http://www.w3.org/2001/XMLSchema-instance";
version="5.0"
xmlns:xl="http://www.w3.org/1999/xlink";
@@ -23,9 +23,10 @@
xsi:schemaLocation="http://docbook.org/ns/docbook ../../../content/
dtd/docbook.xsd"
xmlns="http://docbook.org/ns/docbook";>
The Accounting Introduction
-Introductory text
+The Accounting Manager application is used to manage the
accounting function for a business. It gives access to various sub
tabs
+   related to OFBiz accounting configuration and setup.
   
-subsection heading
+Subsection heading
   Subsection content
   


Added: ofbiz/trunk/applications/accounting/data/helpdata/
HELP_ACCOUNTING_editInvoi.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/helpdata/HELP_ACCOUNTING_editInvoi.xml?rev=813189&view=auto
=
=
=
=
=
=
=
=
= 
= 


--- ofbiz/trunk/applications/acc

Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Hans Bakker
Hi Scott,

What is required to easily find file related to the topicHelp variable
in helpLink.ftl.

I simply put "HELP_" in front of it

You name is nice to read but has no relation to the helptopic what is
required.

in the case below:

helpTopic = ACCOUNTING_editInvoi
filename: HELP_ACCOUNTING_editInvoi.xml

Regards,
Hans


On Thu, 2009-09-10 at 13:37 +1200, Scott Gray wrote:
> Hi Hans
> 
> Following on from what Ashish brought up about the naming convention  
> of the help files, I'm struggling to see the need for the strange names.
> 
> If they are only referenced by DataResource.objectInfo and the names  
> don't actually contain any information required by the rendering  
> logic, couldn't we make them more intuitive?
> 
> For example instead of:
> HELP_ACCOUNTING_editInvoi.xml
> why can't the name be:
> HelpAccountingEditInvoice.xml
> 
> Thanks
> Scott
> 
> HotWax Media
> http://www.hotwaxmedia.com
> 
> On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:
> 
> > Author: hansbak
> > Date: Thu Sep 10 01:21:20 2009
> > New Revision: 813189
> >
> > URL: http://svn.apache.org/viewvc?rev=813189&view=rev
> > Log:
> > invoice help screens contributed by Sharon Foga
> >
> > Added:
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_editInvoi.xml   (with props)
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_findInvoi.xml   (with props)
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_invoiceOv.xml   (with props)
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_invoiceRo.xml   (with props)
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_listInvoi.xml   (with props)
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_sendPerEm.xml   (with props)
> > Modified:
> >ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING.xml
> >ofbiz/trunk/applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_main.xml
> >ofbiz/trunk/applications/accounting/documents/Accounting.xml
> >
> > Modified: ofbiz/trunk/applications/accounting/data/ 
> > AccountingHelpData.xml
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
> > = 
> > = 
> > = 
> > = 
> > = 
> > = 
> > = 
> > = 
> > ==
> > --- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
> > (original)
> > +++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
> > Thu Sep 10 01:21:20 2009
> > @@ -29,4 +29,34 @@
> > objectInfo="applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"  
> > statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"  
> > mimeTypeId="text/xml" isPublic="Y" />
> >  > contentName="Accounting Main Help"  
> > templateDataResourceId="HELP_TEMPL" dataResourceId="ACCOUNTING_main"  
> > statusId="CTNT_IN_PROGRESS" mimeTypeId="text/html"/>/>
> >  > contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"  
> > fromDate="2006-01-12 01:01:01" sequenceNum="000"/>
> > +
> > + > localeString="en" dataResourceTypeId="OFBIZ_FILE"
> > +objectInfo="applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_findInvoi.xml" dataTemplateTypeId="NONE"  
> > statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Find  
> > Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
> > + > contentTypeId="DOCUMENT" contentName="Accounting Find Invoices Help"  
> > templateDataResourceId="HELP_TEMPL"  
> > dataResourceId="ACCOUNTING_findInvoi" statusId="CTNT_IN_PROGRESS"  
> > mimeTypeId="text/html"/>/>
> > + > contentIdTo="ACCOUNTING_findInvoi" contentAssocTypeId="TREE_CHILD"  
> > fromDate="2006-01-12 01:01:01" sequenceNum="000"/>
> > +
> > + > localeString="en" dataResourceTypeId="OFBIZ_FILE"
> > +objectInfo="applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_invoiceOv.xml" dataTemplateTypeId="NONE"  
> > statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Invoice  
> > Overview Help" mimeTypeId="text/xml" isPublic="Y" />
> > + > contentTypeId="DOCUMENT" contentName="Accounting Invoice Overview  
> > Help" templateDataResourceId="HELP_TEMPL"  
> > dataResourceId="ACCOUNTING_invoiceOv" statusId="CTNT_IN_PROGRESS"  
> > mimeTypeId="text/html"/>/>
> > + > contentIdTo="ACCOUNTING_invoiceOv" contentAssocTypeId="TREE_CHILD"  
> > fromDate="2006-01-12 01:01:01" sequenceNum="000"/>
> > +
> > + > localeString="en" dataResourceTypeId="OFBIZ_FILE"
> > +objectInfo="applications/accounting/data/helpdata/ 
> > HELP_ACCOUNTING_editInvoi.xml" dataTemplateTypeId="NONE"  
> > statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Edit  
> > Invoice Help" mimeTypeId="text/xml" isPublic="Y" />
> > +

Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread David E Jones


I agree with this too. I was looking at the stuff earlier, and in  
general it looks great, but the naming did strike me as inconsistent  
with how other files are named.


-David


On Sep 9, 2009, at 8:50 PM, Anil Patel wrote:


+1 for Scott's suggestion.

Regards
Anil Patel

On Sep 9, 2009, at 9:37 PM, Scott Gray wrote:


Hi Hans

Following on from what Ashish brought up about the naming  
convention of the help files, I'm struggling to see the need for  
the strange names.


If they are only referenced by DataResource.objectInfo and the  
names don't actually contain any information required by the  
rendering logic, couldn't we make them more intuitive?


For example instead of:
HELP_ACCOUNTING_editInvoi.xml
why can't the name be:
HelpAccountingEditInvoice.xml

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:


Author: hansbak
Date: Thu Sep 10 01:21:20 2009
New Revision: 813189

URL: http://svn.apache.org/viewvc?rev=813189&view=rev
Log:
invoice help screens contributed by Sharon Foga

Added:
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml   (with props)
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml   (with props)
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml   (with props)
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceRo.xml   (with props)
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml   (with props)
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_sendPerEm.xml   (with props)

Modified:
 ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING.xml
 ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml

 ofbiz/trunk/applications/accounting/documents/Accounting.xml

Modified: ofbiz/trunk/applications/accounting/data/ 
AccountingHelpData.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
= 

--- ofbiz/trunk/applications/accounting/data/ 
AccountingHelpData.xml (original)
+++ ofbiz/trunk/applications/accounting/data/ 
AccountingHelpData.xml Thu Sep 10 01:21:20 2009

@@ -29,4 +29,34 @@
  objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main  
Help" mimeTypeId="text/xml" isPublic="Y" />
  contentName="Accounting Main Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_main" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
  contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Find  
Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Find Invoices  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_findInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_findInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Invoice  
Overview Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Invoice Overview  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_invoiceOv" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_invoiceOv" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Edit  
Invoice Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Edit Invoice  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_editInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_editInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml" dataTem

Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Anil Patel

+1 for Scott's suggestion.

Regards
Anil Patel

On Sep 9, 2009, at 9:37 PM, Scott Gray wrote:


Hi Hans

Following on from what Ashish brought up about the naming convention  
of the help files, I'm struggling to see the need for the strange  
names.


If they are only referenced by DataResource.objectInfo and the names  
don't actually contain any information required by the rendering  
logic, couldn't we make them more intuitive?


For example instead of:
HELP_ACCOUNTING_editInvoi.xml
why can't the name be:
HelpAccountingEditInvoice.xml

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:


Author: hansbak
Date: Thu Sep 10 01:21:20 2009
New Revision: 813189

URL: http://svn.apache.org/viewvc?rev=813189&view=rev
Log:
invoice help screens contributed by Sharon Foga

Added:
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceRo.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml   (with props)
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_sendPerEm.xml   (with props)

Modified:
  ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING.xml
  ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml

  ofbiz/trunk/applications/accounting/documents/Accounting.xml

Modified: ofbiz/trunk/applications/accounting/data/ 
AccountingHelpData.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
(original)
+++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
Thu Sep 10 01:21:20 2009

@@ -29,4 +29,34 @@
   objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"  
mimeTypeId="text/xml" isPublic="Y" />
   contentName="Accounting Main Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_main" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
   contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Find  
Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Find Invoices  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_findInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_findInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Invoice  
Overview Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Invoice Overview  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_invoiceOv" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_invoiceOv" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Edit  
Invoice Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Edit Invoice Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_editInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_editInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting List  
Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting List Invoices  
Help" templa

Re: svn commit: r813189 - in /ofbiz/trunk/applications/accounting: data/ data/helpdata/ documents/

2009-09-09 Thread Scott Gray

Hi Hans

Following on from what Ashish brought up about the naming convention  
of the help files, I'm struggling to see the need for the strange names.


If they are only referenced by DataResource.objectInfo and the names  
don't actually contain any information required by the rendering  
logic, couldn't we make them more intuitive?


For example instead of:
HELP_ACCOUNTING_editInvoi.xml
why can't the name be:
HelpAccountingEditInvoice.xml

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/09/2009, at 1:21 PM, hans...@apache.org wrote:


Author: hansbak
Date: Thu Sep 10 01:21:20 2009
New Revision: 813189

URL: http://svn.apache.org/viewvc?rev=813189&view=rev
Log:
invoice help screens contributed by Sharon Foga

Added:
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml   (with props)
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml   (with props)
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml   (with props)
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceRo.xml   (with props)
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml   (with props)
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_sendPerEm.xml   (with props)

Modified:
   ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING.xml
   ofbiz/trunk/applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml

   ofbiz/trunk/applications/accounting/documents/Accounting.xml

Modified: ofbiz/trunk/applications/accounting/data/ 
AccountingHelpData.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml?rev=813189&r1=813188&r2=813189&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
(original)
+++ ofbiz/trunk/applications/accounting/data/AccountingHelpData.xml  
Thu Sep 10 01:21:20 2009

@@ -29,4 +29,34 @@
objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_main.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Main Help"  
mimeTypeId="text/xml" isPublic="Y" />
contentName="Accounting Main Help"  
templateDataResourceId="HELP_TEMPL" dataResourceId="ACCOUNTING_main"  
statusId="CTNT_IN_PROGRESS" mimeTypeId="text/html"/>/>
contentIdTo="ACCOUNTING_main" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_findInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Find  
Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Find Invoices Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_findInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_findInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_invoiceOv.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Invoice  
Overview Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Invoice Overview  
Help" templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_invoiceOv" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_invoiceOv" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_editInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting Edit  
Invoice Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting Edit Invoice Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_editInvoi" statusId="CTNT_IN_PROGRESS"  
mimeTypeId="text/html"/>/>
+contentIdTo="ACCOUNTING_editInvoi" contentAssocTypeId="TREE_CHILD"  
fromDate="2006-01-12 01:01:01" sequenceNum="000"/>

+
+localeString="en" dataResourceTypeId="OFBIZ_FILE"
+objectInfo="applications/accounting/data/helpdata/ 
HELP_ACCOUNTING_listInvoi.xml" dataTemplateTypeId="NONE"  
statusId="CTNT_IN_PROGRESS" dataResourceName="Accounting List  
Invoices Help" mimeTypeId="text/xml" isPublic="Y" />
+contentTypeId="DOCUMENT" contentName="Accounting List Invoices Help"  
templateDataResourceId="HELP_TEMPL"  
dataResourceId="ACCOUNTING_listInvoi" statusId="CTNT_IN_P

Re: svn commit: r813150 - /ofbiz/trunk/applications/product/data/ProductTypeData.xml

2009-09-09 Thread Adam Heath
Adrian Crum wrote:
> Ummm...
> 
> Second time is a charm?

I lead a charmed life.  And 'Typoe' was on purpose, to be cute.



Re: svn commit: r813150 - /ofbiz/trunk/applications/product/data/ProductTypeData.xml

2009-09-09 Thread Adrian Crum

Ummm...

Second time is a charm?


doo...@apache.org wrote:

Author: doogie
Date: Wed Sep  9 22:45:27 2009
New Revision: 813150

URL: http://svn.apache.org/viewvc?rev=813150&view=rev
Log:
Typoe fix.

Modified:
ofbiz/trunk/applications/product/data/ProductTypeData.xml

Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=813150&r1=813149&r2=813150&view=diff
==
--- ofbiz/trunk/applications/product/data/ProductTypeData.xml (original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Wed Sep  9 
22:45:27 2009
@@ -343,7 +343,7 @@
 
 
 
-
+
 
 
 





[jira] Closed: (OFBIZ-113) Showing VAT/Sales tax in Shopping cart before checkout

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-113.
-

Resolution: Fixed

It's not perfect, but in trunk at r813136, I have commited something which 
solves this issue.

> Showing VAT/Sales tax in Shopping cart before checkout
> --
>
> Key: OFBIZ-113
> URL: https://issues.apache.org/jira/browse/OFBIZ-113
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Eriks Dobelis
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: cart.diff
>
>
> VAT/Sales tax is currently calculated only after initiating Checkout. Even if 
> the price in ecommerce catalog includes tax, shopping cart shows price 
> without tax. It would be nice if Shopping cart showed the same price as in 
> ecommerce catalog and instantly calculated total tax when a new product is 
> added to Shopping cart.
> I tried to look into source code and seems this has to be changed in 
> ShoppingCart.java, but it also seems quite complex issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2923) Find tracking code page not redering

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-2923.
--

Resolution: Fixed
  Assignee: Jacques Le Roux

Thanks Garfield,

Fixed at r813120  


> Find tracking code page not redering
> 
>
> Key: OFBIZ-2923
> URL: https://issues.apache.org/jira/browse/OFBIZ-2923
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Release Branch 4.0
> Environment: Marketing application
>Reporter: Garfield Heron
>Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===
> --- 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (revision 754681)
> +++ 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (working copy)
> @@ -260,7 +260,7 @@
>   target="createTrackingCodeType"/>
>  
>   title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonNotModifRecreat}" 
> widget-style="tabletext">
> - use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/>
> + use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}">
>   use-when="trackingCodeType==null&&trackingCodeTypeId!=null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" 
> widget-style="tabletext">
>  
>   title="${uiLabelMap.TrackingCodeTypeDescription}">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753265#action_12753265
 ] 

Jacques Le Roux commented on OFBIZ-2833:


At least it's ok with postgres

> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2923) Find tracking code page not redering

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753263#action_12753263
 ] 

Jacques Le Roux commented on OFBIZ-2923:


http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Your patch in comment should be ok for this though...

> Find tracking code page not redering
> 
>
> Key: OFBIZ-2923
> URL: https://issues.apache.org/jira/browse/OFBIZ-2923
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Release Branch 4.0
> Environment: Marketing application
>Reporter: Garfield Heron
> Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===
> --- 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (revision 754681)
> +++ 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (working copy)
> @@ -260,7 +260,7 @@
>   target="createTrackingCodeType"/>
>  
>   title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonNotModifRecreat}" 
> widget-style="tabletext">
> - use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/>
> + use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}">
>   use-when="trackingCodeType==null&&trackingCodeTypeId!=null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" 
> widget-style="tabletext">
>  
>   title="${uiLabelMap.TrackingCodeTypeDescription}">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2923) Find tracking code page not redering

2009-09-09 Thread Garfield Heron (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753228#action_12753228
 ] 

Garfield Heron commented on OFBIZ-2923:
---

Is there a list of commiters I could mail the patch to?

> Find tracking code page not redering
> 
>
> Key: OFBIZ-2923
> URL: https://issues.apache.org/jira/browse/OFBIZ-2923
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Release Branch 4.0
> Environment: Marketing application
>Reporter: Garfield Heron
> Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===
> --- 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (revision 754681)
> +++ 
> applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> (working copy)
> @@ -260,7 +260,7 @@
>   target="createTrackingCodeType"/>
>  
>   title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonNotModifRecreat}" 
> widget-style="tabletext">
> - use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/>
> + use-when="trackingCodeType==null&&trackingCodeTypeId==null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}">
>   use-when="trackingCodeType==null&&trackingCodeTypeId!=null" 
> name="trackingCodeTypeId" 
> title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" 
> tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" 
> widget-style="tabletext">
>  
>   title="${uiLabelMap.TrackingCodeTypeDescription}">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2923) Find tracking code page not redering

2009-09-09 Thread Garfield Heron (JIRA)
Find tracking code page not redering


 Key: OFBIZ-2923
 URL: https://issues.apache.org/jira/browse/OFBIZ-2923
 Project: OFBiz
  Issue Type: Bug
  Components: marketing
Affects Versions: Release Branch 4.0
 Environment: Marketing application
Reporter: Garfield Heron
 Fix For: Release Branch 4.0


the find tracking code page is not rendering.  The following patch fixes it.

Index: 
applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
===
--- applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml  
(revision 754681)
+++ applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml  
(working copy)
@@ -260,7 +260,7 @@
 
 
 
-<§text/>
+
 
 
 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread David E. Jones (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753212#action_12753212
 ] 

David E. Jones commented on OFBIZ-2833:
---

Based on the description this doesn't sound like a database problem, but rather 
a problem where rounding is missing in the code. My guess is that this would 
happen on any database... just based on the description thought, I haven't 
tested it.

> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2833) Receive offline payment (May be the Entity Engine) has decimal precision problem

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753193#action_12753193
 ] 

Jacques Le Roux commented on OFBIZ-2833:


I checked this problem does not exist in PostGres (8.3). I suggest to close 
this issue as Derby is not our recommenced DBMS for production, PostGres is. 
Any other opinions ?

> Receive offline payment (May be the Entity Engine) has decimal precision 
> problem
> 
>
> Key: OFBIZ-2833
> URL: https://issues.apache.org/jira/browse/OFBIZ-2833
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Release Branch 9.04, SVN trunk
> Environment: The Database I'm used for testing is the built in Derby. 
> I'm not sure if other DBMS has same problem.
>Reporter: Miles Huang
>
> Reproduce the problem is simple. In Order Manager Application, simply enter 
> an offline payment for a sales order with amount $65.30, the payment amount 
> stored in the DB will change to $65.29.
> Digging into the code, in the 
> org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment method, although the 
> passed in amountStr is "65.30", the parsed out BigDecimal paymentTypeAmount 
> have value "65.2971578290569595992565155029296875". Checking the 
> payment amount stored in the Payments entity use web tools, the result is 
> 65.29. And the order still has $0.01 outstanding amount.
> Parse the BigDecimal value from string directly may solve the problem 
> partially. But imagine if someone enters $65.299, the problem is still there.
> Or a better and safe solution, in Entity Engine, always round half up 
> BigDecimal value to the same precision as the corresponding DB column before 
> insert/update?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-2921:
---

Attachment: OFBIZ-2921_sortable_table_headers.patch

Better version of the patch (no space left) but I did not put ExampleForms.xml 
because I have another change waiting in it.

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch, 
> OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Erwan de FERRIERES (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753127#action_12753127
 ] 

Erwan de FERRIERES commented on OFBIZ-2921:
---

i've just done it on a single forms as PoF. And forgot to tell it in this 
JIRA's comments. thanks for making it !

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-2921:
---

Attachment: OFBIZ-2921_sortable_table_headers.patch

OFBIZ-2921_sortable_table_headers would be the patch

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff, OFBIZ-2921_sortable_table_headers.patch
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-2921:
--

Assignee: Jacques Le Roux

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753117#action_12753117
 ] 

Jacques Le Roux commented on OFBIZ-2921:


Hi Erwan,

This works great and like you I prefer black on white images for these arrows. 
However before applying, I'd like to have other opinions as if we commit it we 
have also to remove all header-row-style="header-row-2"  (which is not a big 
deal) to have the other forms working also.

If nobody replies, in some days I will proceed...

Thanks

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2913) Write a new service for quick create customer profile.

2009-09-09 Thread Ashish Vijaywargiya (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753119#action_12753119
 ] 

Ashish Vijaywargiya commented on OFBIZ-2913:


Thanks Awdesh.

Map processor changes are done at r812985.
I didn't commit your new service as similar services exists in SFA/ Party 
component.

--
Ashish

> Write a new service for quick create customer profile.
> --
>
> Key: OFBIZ-2913
> URL: https://issues.apache.org/jira/browse/OFBIZ-2913
> Project: OFBiz
>  Issue Type: New Feature
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Sumit Pandit
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2913.patch, OFBIZ-2913.patch
>
>
> Write a new service for creating a customer profile. This could be called as 
> QuickCreateCustomerProfile.
> Create a Customer Profile based on following IN parameter - 
> 1) First Name 
> 2) Last Name
> 3) Email Address
> Based on above information create - Person, Party, PartyRole (CUSTOMER), 
> Contact (Email).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2922) Update Sign up for Contact List (signUpForContactList) service.

2009-09-09 Thread Surya Kusumakar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surya Kusumakar updated OFBIZ-2922:
---

Attachment: OFBIZ_2922.patch

Here is the patch for changes mentioned .

--
Regards
Surya KUsumakar

> Update Sign up for Contact List (signUpForContactList) service.
> ---
>
> Key: OFBIZ-2922
> URL: https://issues.apache.org/jira/browse/OFBIZ-2922
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: SVN trunk
>Reporter: Sumit Pandit
> Fix For: SVN trunk
>
> Attachments: OFBIZ_2922.patch
>
>
> Update service - signUpForContactList and add a new IN parameter - 
> partyId(o), if it passed then create Party Email Address and Contact List for 
> passed in partyId. If it is not then it will work in same manner as it is 
> working currently. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2922) Update Sign up for Contact List (signUpForContactList) service.

2009-09-09 Thread Sumit Pandit (JIRA)
Update Sign up for Contact List (signUpForContactList) service.
---

 Key: OFBIZ-2922
 URL: https://issues.apache.org/jira/browse/OFBIZ-2922
 Project: OFBiz
  Issue Type: Improvement
  Components: marketing
Affects Versions: SVN trunk
Reporter: Sumit Pandit
 Fix For: SVN trunk


Update service - signUpForContactList and add a new IN parameter - partyId(o), 
if it passed then create Party Email Address and Contact List for passed in 
partyId. If it is not then it will work in same manner as it is working 
currently. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Erwan de FERRIERES (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753095#action_12753095
 ] 

Erwan de FERRIERES commented on OFBIZ-2921:
---

the modifications for testing have been made in this page : (juste removed the 
header-row-style for the ListeExamples form)
https://localhost:8443/example/control/FindExample

the images have to be placed in framework/images/webapp/images

It's working on the 3 themes.

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Erwan de FERRIERES (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES updated OFBIZ-2921:
--

Attachment: arrow-gr-up.png

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Erwan de FERRIERES (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES updated OFBIZ-2921:
--

Attachment: arrow-gr-dw.png
arrow-gr.png
OFBIZ-2921.diff

> sortable table headers
> --
>
> Key: OFBIZ-2921
> URL: https://issues.apache.org/jira/browse/OFBIZ-2921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: arrow-gr-dw.png, arrow-gr-up.png, arrow-gr.png, 
> OFBIZ-2921.diff
>
>
> When using sortable headers in the forms, we have to specify that headers are 
> sortable with the  header-row-style="header-row-2" option. with some simple 
> modifications in the css files, we can make the css work for us, and detect 
> if there is a link.
> I've also modified the 3 arrows pictures, to make them black on white, insted 
> of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2921) sortable table headers

2009-09-09 Thread Erwan de FERRIERES (JIRA)
sortable table headers
--

 Key: OFBIZ-2921
 URL: https://issues.apache.org/jira/browse/OFBIZ-2921
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
 Fix For: SVN trunk


When using sortable headers in the forms, we have to specify that headers are 
sortable with the  header-row-style="header-row-2" option. with some simple 
modifications in the css files, we can make the css work for us, and detect if 
there is a link.
I've also modified the 3 arrows pictures, to make them black on white, insted 
of white on grey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2561) Implementing Customer Service functionality

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753088#action_12753088
 ] 

Jacques Le Roux commented on OFBIZ-2561:


Hi Serveen,

Also are you aware of 
http://docs.ofbiz.org/download/attachments/4008/IfCrmPlanEstimate.pdf?version=1 
?

> Implementing Customer Service functionality 
> 
>
> Key: OFBIZ-2561
> URL: https://issues.apache.org/jira/browse/OFBIZ-2561
> Project: OFBiz
>  Issue Type: New Feature
>  Components: marketing
>Affects Versions: SVN trunk
>Reporter: Serveen Kaur
> Fix For: SVN trunk
>
> Attachments: SFA_CustomerService.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I am implementing customer service functionality in SFA.
> Screens for Customer Service include Query, Solution, Services.
> In Customer Service customer can ask any query related to product.Solution to 
> that query is provided to customer by employee via email notification.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2920) Outgoing Shipment - Exception

2009-09-09 Thread Aswath Satrasala (JIRA)
Outgoing Shipment - Exception
-

 Key: OFBIZ-2920
 URL: https://issues.apache.org/jira/browse/OFBIZ-2920
 Project: OFBiz
  Issue Type: Bug
 Environment: Revision 812811
Reporter: Aswath Satrasala


Go to Facility -> OutgoingShipment - throws an Exception

org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
[component://webtools/widget/ArtifactInfoScreens.xml#ArtifactInfo]: 
org.ofbiz.base.util.GeneralException: Error running Groovy script at location 
[component://webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy]
 (Error finding Service with name updatePersonTraining for auto-fields-service 
in a form widget) (Error running Groovy script at location 
[component://webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy]
 (Error finding Service with name updatePersonTraining for auto-fields-service 
in a form widget))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2603) Main storefront web page - left column "Browse Category" links - on nightly build does not render lists within lists (collapsed lists) correctly.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753087#action_12753087
 ] 

Jacques Le Roux commented on OFBIZ-2603:


For the 1st point :

Open "Widgets (english)" down to "Micro Widgets (english)" and go to "Micro 
Widgets (english)" page (BTW I will remove this english word - which should be 
English anyway :/ - I stupidly put there when I created the French version in 
demo data)
click on Small Widgets : it works! But not for all, not sure what the "rule" 
is, if any

> Main storefront web page - left column "Browse Category" links -  on nightly 
> build does not render lists within lists (collapsed lists) correctly.
> --
>
> Key: OFBIZ-2603
> URL: https://issues.apache.org/jira/browse/OFBIZ-2603
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
> Environment: CSS for left column styles needs additional style for 
> display of lists within lists
>Reporter: Ruth Hoffman
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: allthree.jpg, ofbiz-2603_ecommain.css.patch, ulfix.jpg
>
>
> Main storefront web page - left column "Browse Category" links -  on nightly 
> build does not render lists within lists (collapsed lists) correctly. Will 
> supply graphic as an attachment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2603) Main storefront web page - left column "Browse Category" links - on nightly build does not render lists within lists (collapsed lists) correctly.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753084#action_12753084
 ] 

Jacques Le Roux commented on OFBIZ-2603:


Hi Ruth,

* I just tried from bread crumbs and sometimes it works :/
* For the middle column all is in OFBIZ-2602
* I'm not sure to understand what you want to achieve in your 3d proposition, 
could you explain more please, as usual :
# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)
# If relevant provide an URL

Thanks




> Main storefront web page - left column "Browse Category" links -  on nightly 
> build does not render lists within lists (collapsed lists) correctly.
> --
>
> Key: OFBIZ-2603
> URL: https://issues.apache.org/jira/browse/OFBIZ-2603
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
> Environment: CSS for left column styles needs additional style for 
> display of lists within lists
>Reporter: Ruth Hoffman
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: allthree.jpg, ofbiz-2603_ecommain.css.patch, ulfix.jpg
>
>
> Main storefront web page - left column "Browse Category" links -  on nightly 
> build does not render lists within lists (collapsed lists) correctly. Will 
> supply graphic as an attachment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2918) Added Opening Balance field in Bank Reconciliation entity, Also added a calculated field (Closing Balance) on GlReconciliation Screen.

2009-09-09 Thread Anil K Patel (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel closed OFBIZ-2918.
---

Resolution: Fixed

Patch applied to r812946. Thanks.

> Added Opening Balance field in Bank Reconciliation entity, Also added a 
> calculated field (Closing Balance) on GlReconciliation Screen.
> --
>
> Key: OFBIZ-2918
> URL: https://issues.apache.org/jira/browse/OFBIZ-2918
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: OFBiz-2918.patch
>
>
> Added Opening Balance field to GlReconciliation entity. In Bank 
> reconciliation process it allows user to edit value of this field. Once 
> reconciliation is completed this field shown as read only. Added calculated 
> field on GlReconcilation screen to show closing balance (opening balance + 
> reconciled amount + running total). Updated value of closing amount on change 
> of opening balance field and running total field.
> Regards,
> -- Ratnesh Upadhyay
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-2918) Added Opening Balance field in Bank Reconciliation entity, Also added a calculated field (Closing Balance) on GlReconciliation Screen.

2009-09-09 Thread Anil K Patel (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel reassigned OFBIZ-2918:
---

Assignee: Anil K Patel

> Added Opening Balance field in Bank Reconciliation entity, Also added a 
> calculated field (Closing Balance) on GlReconciliation Screen.
> --
>
> Key: OFBIZ-2918
> URL: https://issues.apache.org/jira/browse/OFBIZ-2918
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: OFBiz-2918.patch
>
>
> Added Opening Balance field to GlReconciliation entity. In Bank 
> reconciliation process it allows user to edit value of this field. Once 
> reconciliation is completed this field shown as read only. Added calculated 
> field on GlReconcilation screen to show closing balance (opening balance + 
> reconciled amount + running total). Updated value of closing amount on change 
> of opening balance field and running total field.
> Regards,
> -- Ratnesh Upadhyay
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2628) No Url encoding for get parameters

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753080#action_12753080
 ] 

Jacques Le Roux commented on OFBIZ-2628:


Hi Patrick,

Your patch looks good, though it's not an habit in OFBiz to put reference to 
Jira issues in code. This afterall would add a lot of useless informations, we 
try to keep the code as clean as possible.

I had a look at 
http://freemarker.sourceforge.net/docs/ref_builtins_string.html#ref_builtin_url 
and http://freemarker.sourceforge.net/docs/pgui_misc_charset.html, but I'd 
still prefer to make the change in makeLink (I suppose you mean in the "encode 
section") as 
# it's used widely and not only in OfbizUrlTransform (look for references in 
Eclipse)
# as you said putting ?url in templates would be wide and hazardous task (I 
guess I did not check, using regexp replacement in Eclipse you can do miracles) 

My 2 cts



> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk
> Environment: All
>Reporter: Patrick Antivackis
>Priority: Critical
> Attachments: OFBIZ-2628-widget.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is  DVD+R
> Creation is ok through the admin interface, but whenever i want to access 
> this category, the get parameter productCategoryId= of the url is wrong 
> as it's not url encoded, so we have :
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R
>  instead of
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the 
> makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function 
> buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of 
> simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side 
> effects

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2919) Click on ArtifactInfo menu item - Exception

2009-09-09 Thread Aswath Satrasala (JIRA)
Click on ArtifactInfo menu item - Exception
---

 Key: OFBIZ-2919
 URL: https://issues.apache.org/jira/browse/OFBIZ-2919
 Project: OFBiz
  Issue Type: Bug
Affects Versions: SVN trunk
 Environment: Revision 812811
Reporter: Aswath Satrasala


Go to Webtools->click on ArtifactInfo menu item.

org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
[component://webtools/widget/ArtifactInfoScreens.xml#ArtifactInfo]: 
org.ofbiz.base.util.GeneralException: Error running Groovy script at location 
[component://webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy]
 (Error finding Service with name updatePersonTraining for auto-fields-service 
in a form widget) (Error running Groovy script at location 
[component://webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy]
 (Error finding Service with name updatePersonTraining for auto-fields-service 
in a form widget))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753067#action_12753067
 ] 

Jacques Le Roux commented on OFBIZ-2916:


Nicolas,

It's ok for me as long as both work the same way (and yes having an optionnal 
message is obviously a +)

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2918) Added Opening Balance field in Bank Reconciliation entity, Also added a calculated field (Closing Balance) on GlReconciliation Screen.

2009-09-09 Thread Ratnesh Upadhyay (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ratnesh Upadhyay updated OFBIZ-2918:


Attachment: OFBiz-2918.patch

Here is the patch to serve this functionality.

Thanks Sumit and Chirag for discussion.

Regards,
-- Ratnesh Upadhyay

> Added Opening Balance field in Bank Reconciliation entity, Also added a 
> calculated field (Closing Balance) on GlReconciliation Screen.
> --
>
> Key: OFBIZ-2918
> URL: https://issues.apache.org/jira/browse/OFBIZ-2918
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
> Fix For: SVN trunk
>
> Attachments: OFBiz-2918.patch
>
>
> Added Opening Balance field to GlReconciliation entity. In Bank 
> reconciliation process it allows user to edit value of this field. Once 
> reconciliation is completed this field shown as read only. Added calculated 
> field on GlReconcilation screen to show closing balance (opening balance + 
> reconciled amount + running total). Updated value of closing amount on change 
> of opening balance field and running total field.
> Regards,
> -- Ratnesh Upadhyay
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2918) Added Opening Balance field in Bank Reconciliation entity, Also added a calculated field (Closing Balance) on GlReconciliation Screen.

2009-09-09 Thread Ratnesh Upadhyay (JIRA)
Added Opening Balance field in Bank Reconciliation entity, Also added a 
calculated field (Closing Balance) on GlReconciliation Screen.
--

 Key: OFBIZ-2918
 URL: https://issues.apache.org/jira/browse/OFBIZ-2918
 Project: OFBiz
  Issue Type: New Feature
  Components: accounting
Affects Versions: SVN trunk
Reporter: Ratnesh Upadhyay
 Fix For: SVN trunk


Added Opening Balance field to GlReconciliation entity. In Bank reconciliation 
process it allows user to edit value of this field. Once reconciliation is 
completed this field shown as read only. Added calculated field on 
GlReconcilation screen to show closing balance (opening balance + reconciled 
amount + running total). Updated value of closing amount on change of opening 
balance field and running total field.


Regards,
-- Ratnesh Upadhyay
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753047#action_12753047
 ] 

nicolas malin commented on OFBIZ-2916:
--

Scott, Jacques,

I propose to adapt the patch to follow this :
 1. I change confirm by  confirmation-message
 2. I add request-confirmation
 3. When test, 
   if  request-confirmation is true  
if  confirmation-message not empty -> use it
else use CommonConfirm
   if confirmation-message not empty -> use it

With this system, If we want just confirmation we put 
request-confirmation="yes" and if we have specific message we use 
confirmation-message, with the goal to minimize writing attribute.

If you are ok, I operate modification in few days.

Nicolas

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2739) This patch is for Improvent in HR module in Global Hr Setting tabs in Paygrade section.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753036#action_12753036
 ] 

Jacques Le Roux commented on OFBIZ-2739:


Hi Pradeep,

It seems that these issues are already resolved, could you update and check 
please

Thanks

> This patch is for Improvent in HR module in Global Hr Setting tabs in 
> Paygrade section. 
> 
>
> Key: OFBIZ-2739
> URL: https://issues.apache.org/jira/browse/OFBIZ-2739
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: SVN trunk
> Environment: Window XP, JDK 1.6, Processor :t5...@1.83ghz, 1.99GB of 
> RAM
>Reporter: Pradeep Ruhil
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: HR PayGrade.patch
>
>
> In this patch I have solved two problems that were ocurring in HR->Global HR 
> Setting-> Pay Grades-> 
> First :  When you  edit a pay grade id that is already created by clicking 
> the payGradeId , it will redirect to edit Pay Grade Screen, In this when we 
> press the save button it gives me this exception :
> The Following Errors Occurred:
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: No rows to 
> process.
> This is coming because in the controller.xml the service type is written 
> 'service-multi' for the URI 'updatePayGrade' , as their are no multiple rows 
> present in Edit Pay Grade screen, so thats why that error was coming. So i 
> changed the service event type to 'service' and error was resolved.
> Second:  This issue is that when you select any payGradeId that is already 
> created and then you check the Salary Steps for that payGradeId, it was 
> showing the Salary Steps of all the payGradeId present.  So I resolved that 
> issue and now it will display the Salary Step for the selected payGradeId 
> only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Increase size of the ProductFeature.idCode field

2009-09-09 Thread Ashish Vijaywargiya
+1.

--
Ashish

On Wed, Sep 9, 2009 at 1:11 PM, Scott Gray wrote:

> Hi all,
>
> I'm using ProductFeature records to map various pieces of product
> information with an external application and I'd like to use the idCode
> field to store the external identifier.  The problem I'm having is that some
> of the external ids are longer than 20 characters.
>
> Does anyone have any objections if I change the field type from 'id' to
> 'id-long' (60 characters)?
>
> Thanks
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
>


[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753020#action_12753020
 ] 

Scott Gray commented on OFBIZ-2916:
---

I think the reasoning for the extra attribute was so that a default message 
could display if you chose not to specify one but I'm not 100% sure (even 
though I implemented it :-) )

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2917) Out Parameter showing under In Parameter head for createAcctgTransAndEntries service reference.

2009-09-09 Thread Chirag Manocha (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chirag Manocha updated OFBIZ-2917:
--

Attachment: OFBiz-2917.patch

In service createAcctgTransAndEntries, there is no need to IN acctgTranId. It 
is required as OUT parameter. So behavior should be overridden instead of 
defining acctgTransId again.

Here is the patch.

Thanks and Regards
-- 
Chirag Manocha

> Out Parameter showing under In Parameter head for createAcctgTransAndEntries 
> service reference.
> ---
>
> Key: OFBIZ-2917
> URL: https://issues.apache.org/jira/browse/OFBIZ-2917
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 9.04, SVN trunk
>Reporter: Chirag Manocha
>Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBiz-2917.patch
>
>
> On looking at service reference for the above said service, acctgTransId 
> shown as out parameter under the head of In Parameters.
> To re-create go to 
> https://demo.ofbiz.org/webtools/control/ServiceList?sel_service_name=createAcctgTransAndEntries
>  and look at the In Parameters, acctgTransId with mode OUT.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2917) Out Parameter showing under In Parameter head for createAcctgTransAndEntries service reference.

2009-09-09 Thread Chirag Manocha (JIRA)
Out Parameter showing under In Parameter head for createAcctgTransAndEntries 
service reference.
---

 Key: OFBIZ-2917
 URL: https://issues.apache.org/jira/browse/OFBIZ-2917
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Chirag Manocha
Priority: Minor
 Fix For: Release Branch 9.04, SVN trunk


On looking at service reference for the above said service, acctgTransId shown 
as out parameter under the head of In Parameters.

To re-create go to 
https://demo.ofbiz.org/webtools/control/ServiceList?sel_service_name=createAcctgTransAndEntries
 and look at the In Parameters, acctgTransId with mode OUT.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753016#action_12753016
 ] 

Jacques Le Roux commented on OFBIZ-2916:


Nicolas,

I think it's a good way of doing it. But the problem here is inconsistency. So 
I would say, from a core commiter POV, else change menu to conform your way or 
vice-versa...

My 2 cts

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Jacopo Cappellato

Ok, I will look at it; thanks for your research.

Jacopo

On Sep 9, 2009, at 11:57 AM, Hans Bakker wrote:


Jacopo,

i had a look: here are 3 types of binary file:
1. local binary
2. local to appl binary
3. local to ofbiz home binary

i tried all of the three and reverted back to the revision before  
811787

and the problem is still there for not only pdf filedo i miss
something?

if you use 'image file' then the upload works

it looks like when it is an external file the problem appears,  
saving in

the database is ok.

on the upload screen the bottom part should only be shown if the  
object

fields is not empty and the file can be found...

So let me know if I can help.

Regards,
Hans

--
Antwebsystems.com: Quality OFBiz services for competitive rates





[jira] Commented: (OFBIZ-934) PayPal Express Checkout Support in Ecommerce Checkout Process.

2009-09-09 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753010#action_12753010
 ] 

Scott Gray commented on OFBIZ-934:
--

Hi Corey,

If the shipping option is the only one you use then you would be better off 
modifying the setExpressCheckout service to send it as a default in place of 
"Calculated Offline" option and then don't specify a callbackurl.  That will 
save unnecessary callbacks since you already know what your shipping rate will 
be before receiving the shipping address.

I've had no problems processing orders with a quantity of one, I did it many 
times trying testing without issue.

My problem with the shipping callback ended being because I was specify port 
8443 in the callbackurl which paypal didn't like, you can't specify a port 
number in the url only http or https.  The other problem was that paypal 
stupidly only returns the label of the shipping option and not a hidden 
identifier meaning that you have to attempt to look up the chosen shipping 
methods by description.

I would suggest that you pull the request strings and responses being sent 
to/from paypal from the logs and ask for help on their forums, they are quite 
responsive (so long as the problem isn't too difficult to answer).

> PayPal Express Checkout Support in Ecommerce Checkout Process.
> --
>
> Key: OFBIZ-934
> URL: https://issues.apache.org/jira/browse/OFBIZ-934
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, specialpurpose/ecommerce
>Reporter: Anil K Patel
>Assignee: Scott Gray
> Fix For: SVN trunk
>
>
> Implement Support for PayPal Express Checkout. Some help is available at 
> following locations.
> https://www.paypal.com/IntegrationCenter/ic_expresscheckout.html
> https://www.paypal.com/IntegrationCenter/ic_nvp.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Hans Bakker
Jacopo,

i had a look: here are 3 types of binary file:
1. local binary
2. local to appl binary
3. local to ofbiz home binary

i tried all of the three and reverted back to the revision before 811787
and the problem is still there for not only pdf filedo i miss
something?

if you use 'image file' then the upload works

it looks like when it is an external file the problem appears, saving in
the database is ok.

on the upload screen the bottom part should only be shown if the object
fields is not empty and the file can be found...

So let me know if I can help.

Regards,
Hans

-- 
Antwebsystems.com: Quality OFBiz services for competitive rates



[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-2916:
---

Attachment: OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch

BTW, here is a small patch for some labels changes

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753007#action_12753007
 ] 

nicolas malin commented on OFBIZ-2916:
--

Hi scott,

when I finalize my patch and add information on form widget xsd I show the 
recently code in menu widget xsd. After look in menu we need to up  
request-confirmation="yes" and confirmation-message="text"

When I create this addon juste add confirm="text" and test if text is not empty 
to enable confirmation.
What you prefer ? 
 - I change confirm by confirmation-message and test just if empty to enable 
this action 
or
 - apply also request-confirmation on form and confirmation-message as menu

I forget, Thanks Scott for your review :)

Nicolas

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, 
> OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nicolas malin updated OFBIZ-2916:
-

Attachment: (was: confirm.diff)

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nicolas malin updated OFBIZ-2916:
-

Attachment: confirm.diff

forget CommonUiLabel in previous patch

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753001#action_12753001
 ] 

Scott Gray commented on OFBIZ-2916:
---

Hi Nicolas

I haven't reviewed your patch but it sounds like a good idea, this feature 
already exists for the menu widget.  If you have not done so yet please check 
the menu widget code and xsd to make sure you are following the same pattern, 
solely for sake of consistency.

Thanks
Scott

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nicolas malin updated OFBIZ-2916:
-

Attachment: delete-confirm.png
add-confirm.png
confirm.diff

> Add confirm action before do submit action
> --
>
> Key: OFBIZ-2916
> URL: https://issues.apache.org/jira/browse/OFBIZ-2916
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: SVN trunk
>Reporter: nicolas malin
> Fix For: SVN trunk
>
> Attachments: add-confirm.png, confirm.diff, delete-confirm.png
>
>
> In old thread on dev mailing I explain a process to confirm an action before 
> submit for xml form.
> After a big latency, I create the patch.
> On type submit and hyperlink, I added an attribute confirm that take a take 
> to display in the confirm box. Exemple :
>  button-type="button"  confirm="${uiLabelMap.CommonConfirm}"/>
> I added on example on example component : to test, after apply patch on 
> rebuild, go to example component, add example and add example item. When you 
> add a new exampleItem OFBiz ask to confirm and when you want delete it, he 
> ask also confirmation before delete this element.
> I create two screenshot.
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-2916) Add confirm action before do submit action

2009-09-09 Thread nicolas malin (JIRA)
Add confirm action before do submit action
--

 Key: OFBIZ-2916
 URL: https://issues.apache.org/jira/browse/OFBIZ-2916
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: nicolas malin
 Fix For: SVN trunk


In old thread on dev mailing I explain a process to confirm an action before 
submit for xml form.
After a big latency, I create the patch.

On type submit and hyperlink, I added an attribute confirm that take a take to 
display in the confirm box. Exemple :


I added on example on example component : to test, after apply patch on 
rebuild, go to example component, add example and add example item. When you 
add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask 
also confirmation before delete this element.

I create two screenshot.

Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Increase size of the ProductFeature.idCode field

2009-09-09 Thread Jacques Le Roux

+1

Jacques

From: "Jacopo Cappellato" 

+1

On Sep 9, 2009, at 9:41 AM, Scott Gray wrote:


Hi all,

I'm using ProductFeature records to map various pieces of product  
information with an external application and I'd like to use the  
idCode field to store the external identifier.  The problem I'm  
having is that some of the external ids are longer than 20 characters.


Does anyone have any objections if I change the field type from 'id'  
to 'id-long' (60 characters)?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com







[jira] Closed: (OFBIZ-2914) Improved Inventory Average Cost Valuation Algorithm.

2009-09-09 Thread Vikas Mayur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Mayur closed OFBIZ-2914.
--

Resolution: Fixed

Patch is committed in r812744. Thank you - Everyone.

> Improved Inventory Average Cost Valuation Algorithm.
> 
>
> Key: OFBIZ-2914
> URL: https://issues.apache.org/jira/browse/OFBIZ-2914
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: OFBiz-2914.patch
>
>
> Now this calculation will be done by following formula :  ( (old average cost 
> * total old stock) + (new purchase price * new qty received) ) / (total old 
> stock + new qty received). 
> You can verify calculated result from Accounting > Organization GL Settings > 
> Reports > Inventory valuation report screen.
> Regards,
> -- Ratnesh Upadhyay

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2893) Displayed gl account transactions for Bank Reconciliation.

2009-09-09 Thread Vikas Mayur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Mayur closed OFBIZ-2893.
--

Resolution: Fixed

Patch is committed in r812742. Thank you - Everyone.

> Displayed gl account transactions for Bank Reconciliation.
> --
>
> Key: OFBIZ-2893
> URL: https://issues.apache.org/jira/browse/OFBIZ-2893
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: PopupGlTransactions.png, ReconciliationScreen.png, 
> ShowGlTransactions.patch
>
>
> Added link [Gl Transactions] on Bank Reconciliation view screen. On click of 
> link pop up a window that shows above gl transactions. I have also added 
> screen shots to see resultant screens of this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2896) Added menus in AR and AP web applications to show payment groups of their specific type.

2009-09-09 Thread Vikas Mayur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Mayur closed OFBIZ-2896.
--

Resolution: Fixed

Patch is committed in r812743. Thank you - Everyone.

> Added menus in AR and AP web applications to show payment groups of their 
> specific type.
> 
>
> Key: OFBIZ-2896
> URL: https://issues.apache.org/jira/browse/OFBIZ-2896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-2896.patch
>
>
> Implemented following functionalities in AR & AP web applications : 
> - Added a screen in AP to find and view Payment Group of type Check Run.
> - Added a screen in AR to find and view Payment Group of type (Batch Payment) 
> Deposits to financial account. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Jacopo Cappellato

Np,

Hans, would you mind going here:

https://localhost:8443/content/control/findDataResource

creating a new data resource of type "binary file"

and then trying to upload (using the "Upload" tab) an existing PDF  
file from your filesystem?


It used to work but now it is throwing an exception, even after  
updating with your last fix.


Thanks,

Jacopo

On Sep 9, 2009, at 10:10 AM, Hans Bakker wrote:


sorry about that, the code is now commented out.

Regards,
Hans

On Wed, 2009-09-09 at 09:51 +0200, Jacopo Cappellato wrote:

Hi Hans,

could you please fix the code that has been committed in rev 811787?
It is causing issues because there are settings like this in
ModelScreenWidget:

String fileName = "/home/hans/ofbiz/svn/applications/commonext/
documents/ApacheOfbiz.xml";
SAXSource source = new SAXSource(reader, new InputSource(fileName));

Upload of PDF file is broken.

Thanks,

Jacopo


--
Antwebsystems.com: Quality OFBiz services for competitive rates





Re: Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Hans Bakker
sorry about that, the code is now commented out.

Regards,
Hans

On Wed, 2009-09-09 at 09:51 +0200, Jacopo Cappellato wrote:
> Hi Hans,
> 
> could you please fix the code that has been committed in rev 811787?
> It is causing issues because there are settings like this in  
> ModelScreenWidget:
> 
> String fileName = "/home/hans/ofbiz/svn/applications/commonext/ 
> documents/ApacheOfbiz.xml";
> SAXSource source = new SAXSource(reader, new InputSource(fileName));
> 
> Upload of PDF file is broken.
> 
> Thanks,
> 
> Jacopo
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates



Re: Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Jacopo Cappellato
Wow, Hans it seems that this is broken since the 29th of August... do  
you think you can quickly fix it?


Jacopo

On Sep 9, 2009, at 9:51 AM, Jacopo Cappellato wrote:


Hi Hans,

could you please fix the code that has been committed in rev 811787?
It is causing issues because there are settings like this in  
ModelScreenWidget:


String fileName = "/home/hans/ofbiz/svn/applications/commonext/ 
documents/ApacheOfbiz.xml";

SAXSource source = new SAXSource(reader, new InputSource(fileName));

Upload of PDF file is broken.

Thanks,

Jacopo





[jira] Commented: (OFBIZ-2914) Improved Inventory Average Cost Valuation Algorithm.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752972#action_12752972
 ] 

Jacques Le Roux commented on OFBIZ-2914:


The patch has been commited at r812744, should we not close ? 

> Improved Inventory Average Cost Valuation Algorithm.
> 
>
> Key: OFBIZ-2914
> URL: https://issues.apache.org/jira/browse/OFBIZ-2914
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: OFBiz-2914.patch
>
>
> Now this calculation will be done by following formula :  ( (old average cost 
> * total old stock) + (new purchase price * new qty received) ) / (total old 
> stock + new qty received). 
> You can verify calculated result from Accounting > Organization GL Settings > 
> Reports > Inventory valuation report screen.
> Regards,
> -- Ratnesh Upadhyay

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2896) Added menus in AR and AP web applications to show payment groups of their specific type.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752971#action_12752971
 ] 

Jacques Le Roux commented on OFBIZ-2896:


The patch has been commited at r812743, should we not close ? 

> Added menus in AR and AP web applications to show payment groups of their 
> specific type.
> 
>
> Key: OFBIZ-2896
> URL: https://issues.apache.org/jira/browse/OFBIZ-2896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-2896.patch
>
>
> Implemented following functionalities in AR & AP web applications : 
> - Added a screen in AP to find and view Payment Group of type Check Run.
> - Added a screen in AR to find and view Payment Group of type (Batch Payment) 
> Deposits to financial account. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-2893) Displayed gl account transactions for Bank Reconciliation.

2009-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752970#action_12752970
 ] 

Jacques Le Roux commented on OFBIZ-2893:


The patch has been commited at r812742, should we not close ?

> Displayed gl account transactions for Bank Reconciliation.
> --
>
> Key: OFBIZ-2893
> URL: https://issues.apache.org/jira/browse/OFBIZ-2893
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: SVN trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Anil K Patel
> Fix For: SVN trunk
>
> Attachments: PopupGlTransactions.png, ReconciliationScreen.png, 
> ShowGlTransactions.patch
>
>
> Added link [Gl Transactions] on Bank Reconciliation view screen. On click of 
> link pop up a window that shows above gl transactions. I have also added 
> screen shots to see resultant screens of this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Increase size of the ProductFeature.idCode field

2009-09-09 Thread Jacopo Cappellato

+1

On Sep 9, 2009, at 9:41 AM, Scott Gray wrote:


Hi all,

I'm using ProductFeature records to map various pieces of product  
information with an external application and I'd like to use the  
idCode field to store the external identifier.  The problem I'm  
having is that some of the external ids are longer than 20 characters.


Does anyone have any objections if I change the field type from 'id'  
to 'id-long' (60 characters)?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com





Upload PDF is broken due to bad commit rev. 811787

2009-09-09 Thread Jacopo Cappellato

Hi Hans,

could you please fix the code that has been committed in rev 811787?
It is causing issues because there are settings like this in  
ModelScreenWidget:


String fileName = "/home/hans/ofbiz/svn/applications/commonext/ 
documents/ApacheOfbiz.xml";

SAXSource source = new SAXSource(reader, new InputSource(fileName));

Upload of PDF file is broken.

Thanks,

Jacopo



Increase size of the ProductFeature.idCode field

2009-09-09 Thread Scott Gray

Hi all,

I'm using ProductFeature records to map various pieces of product  
information with an external application and I'd like to use the  
idCode field to store the external identifier.  The problem I'm having  
is that some of the external ids are longer than 20 characters.


Does anyone have any objections if I change the field type from 'id'  
to 'id-long' (60 characters)?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com



smime.p7s
Description: S/MIME cryptographic signature