[jira] Commented: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758605#action_12758605 ] Aswath Satrasala commented on OFBIZ-2946: - Following are the steps. * I order 10-tiny zigmo through ecommerce * I did a quick ship entire order in the order manager * In the ecommerce, I did 'client-order history'. Then, multiple pdf's are shown. I think, in general completed orders has this issue -Aswath orderHistory for completed orders - shows multiple invoices --- Key: OFBIZ-2946 URL: https://issues.apache.org/jira/browse/OFBIZ-2946 Project: OFBiz Issue Type: Bug Environment: trunk version Reporter: Aswath Satrasala Attachments: orderhistorypatch.txt There is a bug in orderHistory.ftl. In the line 60, that is as follows #assign invoices = delegator.findByAnd(OrderItemBilling, Static[org.ofbiz.base.util.UtilMisc].toMap(orderId, ${orderHeader.orderId})) #if invoices?has_content #list invoices as invoice a href=@ofbizUrlinvoice.pdf?invoiceId=${invoice.invoiceId}/@ofbizUrl class=buttontext(${invoice.invoiceId} PDF) /a /#list #else /#if Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. orderid seqid invoiceid issuanceid quantity amount WSCO1 1 CI1 1 100126 38.4 WSCO1 1 CI1 6 10013 5 38.4 WSCO1 2 CI1 00011 10014 1 59.99 WSCO1 5 CI1 00013 10017 1 59.99 WSCO1 3 CI1 00015 10015 1 1.99 WSCO1 4 CI1 00017 10016 1 1.99 --- I have the patch for this already. -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2124) Ofbiz freeze
[ https://issues.apache.org/jira/browse/OFBIZ-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2124: --- Attachment: OFBIZ-2124_Ofbiz_freeze.patch I have upadated the patch. It was not mergeable anymore, so I merged by hand and double-checked. I also replaced Iterators by for loops, ArrayList by FastList and tabs by 4 spaces. Ofbiz freeze Key: OFBIZ-2124 URL: https://issues.apache.org/jira/browse/OFBIZ-2124 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: JDK5 1.5.0_15-b04, Linux Reporter: Philippe Mouawad Assignee: Jacques Le Roux Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-2124_Ofbiz_freeze.patch, patch-Freeze-to-Trunk.patch, ThreadDumps.zip In a certain scenario the application freezes, no more AJP connector thread are available. I attach 5 Thread dump done after the freeze -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Synchronisation issues
Hi, I'm highly interested by the issues Philippe Mouawad created, notably https://issues.apache.org/jira/browse/OFBIZ-2186 https://issues.apache.org/jira/browse/OFBIZ-2124 Also, but not directly related to Synchronisation issues in OFBiz https://issues.apache.org/jira/browse/OFBIZ-2353 (waiting comments from Philippe) https://issues.apache.org/jira/browse/OFBIZ-2599 (waiting action by DBCP team) I trust Philippe and his colleagues since I know they worked on the optimisation of a large and successful OFBiz deployment. David suggested successively 2 patches for OFBIZ-2186 but they did not fix the problem Philippe encountered. However Philippe's patch did. Since I'd like to fix these 2 issues in OFBiz (2124 and then 2186) but I have no time to set 2 machines and a load balancer for these particular problems to test, I googled for synchronized java performance and I found this article http://www.ibm.com/developerworks/java/library/j-jtp04223.html#N1005B by Brian Goetz who also wrote http://www.javaconcurrencyinpractice.com/ (I did not read the book yet) I read also in Sun documentation http://java.sun.com/developer/onlineTraining/Programming/JDCBook/perf2.html Synchronized methods and objects have until Java 2 always incurred an additional performance hit as the mechanism used to implement the locking of this code used a global monitor registry which was only single threaded in some areas such as searching for existing monitors. In the Java 2 release, each thread has a monitor registry and so many of the existing bottlenecks have been removed. If you have previously used other locking mechanisms because of the performance hit with synchronized methods it is now worthwhile re-visiting this code and incorporating the new Java 2 streamlined locks. And also for Java 6 at http://java.sun.com/performance/reference/whitepapers/6_performance.html#2.1 So I would like to commit the patch I slightly modified in OFBIZ-2124 But before that I'd be interested to have some opinions by people who are using load balancers. Notably Brett who recently answered about this subject on user ML. Because I wonder why Philippe was the 1st to discover theses issues and if others have fixed them in another way. Please comment Thanks Jacques
[jira] Created: (OFBIZ-2965) calendar picker does not parse the selected date correctly
calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Priority: Minor Fix For: Release Branch 9.04, SVN trunk The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2965) calendar picker does not parse the selected date correctly
[ https://issues.apache.org/jira/browse/OFBIZ-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wickersheimer Jeremy updated OFBIZ-2965: Attachment: calendar.patch This should apply to 09.04 and trunk calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Priority: Minor Fix For: Release Branch 9.04, SVN trunk Attachments: calendar.patch The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2964) seleniumXml: Patch 1 to seleniumXml ofbiz integration
[ https://issues.apache.org/jira/browse/OFBIZ-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reassigned OFBIZ-2964: -- Assignee: Hans Bakker seleniumXml: Patch 1 to seleniumXml ofbiz integration - Key: OFBIZ-2964 URL: https://issues.apache.org/jira/browse/OFBIZ-2964 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: eclipse generated patch from svn revision 817293 Reporter: Brett G. Palmer Assignee: Hans Bakker Fix For: SVN trunk Attachments: ofbiz_rev817293_seleniumxml_20090922.patch Here is a patch to the framework/testtools/seleniumxml code and build files. I tried this a couple of times but could not avoid some painful merges. There were a lot of changes made between the time the code was introduced into ofbiz and now. We will try to get these patches more frequently to avoid the merge problems. This patch includes the following: - Updates to the install-seleniumxml target which includes a new 1.0.2 selenium-server jar file - Ability to run selenium-server and selenium-xml test cases from the ant targets instead of shell scripts. - Ability to use custom FireFox profiles while testing. This lets you avoid the invalid ofbiz certificate error that we saw with the previous version. - Updates to Example test case - More selenium-rc commands and advanced features for testing AJAX applications. I will also add documentation to the ofbiz doc site on how the framework can be setup and run. Brett -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2965) calendar picker does not parse the selected date correctly
[ https://issues.apache.org/jira/browse/OFBIZ-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758639#action_12758639 ] Jacques Le Roux commented on OFBIZ-2965: Hi Jeremy, Did you email the Author - Tim Harper timseehar...@gmail.seeom.gsub(see, c) ? Thanks calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Priority: Minor Fix For: Release Branch 9.04, SVN trunk Attachments: calendar.patch The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2965) calendar picker does not parse the selected date correctly
[ https://issues.apache.org/jira/browse/OFBIZ-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758641#action_12758641 ] Jacques Le Roux commented on OFBIZ-2965: I tried it but when I enter a date without time (for instance 2009-09-03) I still get now's date+time. What am I missing ? calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Priority: Minor Fix For: Release Branch 9.04, SVN trunk Attachments: calendar.patch The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2946. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 9.04 Assignee: Jacques Le Roux Thanks Aswath, Your patch is in trunk at r818030, R9.04 at r818035 I had to merge it by hand, but it was easily done so I did not ask for an update. orderHistory for completed orders - shows multiple invoices --- Key: OFBIZ-2946 URL: https://issues.apache.org/jira/browse/OFBIZ-2946 Project: OFBiz Issue Type: Bug Environment: trunk version Reporter: Aswath Satrasala Assignee: Jacques Le Roux Fix For: Release Branch 9.04, SVN trunk Attachments: orderhistorypatch.txt There is a bug in orderHistory.ftl. In the line 60, that is as follows #assign invoices = delegator.findByAnd(OrderItemBilling, Static[org.ofbiz.base.util.UtilMisc].toMap(orderId, ${orderHeader.orderId})) #if invoices?has_content #list invoices as invoice a href=@ofbizUrlinvoice.pdf?invoiceId=${invoice.invoiceId}/@ofbizUrl class=buttontext(${invoice.invoiceId} PDF) /a /#list #else /#if Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. orderid seqid invoiceid issuanceid quantity amount WSCO1 1 CI1 1 100126 38.4 WSCO1 1 CI1 6 10013 5 38.4 WSCO1 2 CI1 00011 10014 1 59.99 WSCO1 5 CI1 00013 10017 1 59.99 WSCO1 3 CI1 00015 10015 1 1.99 WSCO1 4 CI1 00017 10016 1 1.99 --- I have the patch for this already. -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2965) calendar picker does not parse the selected date correctly
[ https://issues.apache.org/jira/browse/OFBIZ-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758648#action_12758648 ] Wickersheimer Jeremy commented on OFBIZ-2965: - Jacques, i think this file was modified by ofbiz, the file i get from upstream does not include all that's bellow the // OFBiz addition: modified format_iso_date.js, included here for convenience. Can you try debugging with firebug ? if you put a break at Date.parseFormattedString return dt_date; you should see the returned Date object (it was Undefined Date for me before). Also make sure you reload with Ctrl+F5 to avoid getting the js file from the browser cache. calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Priority: Minor Fix For: Release Branch 9.04, SVN trunk Attachments: calendar.patch The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2960) Improve layout of shopping cart(Step-1) on onepage checkout page
[ https://issues.apache.org/jira/browse/OFBIZ-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur reassigned OFBIZ-2960: -- Assignee: Vikas Mayur Improve layout of shopping cart(Step-1) on onepage checkout page Key: OFBIZ-2960 URL: https://issues.apache.org/jira/browse/OFBIZ-2960 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Bharat Soni Assignee: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: 1.png, 2.png, OFBIZ-2960.patch Improve layout of shopping cart(Step-1) on onepage checkout process. After clicking of Continue to step 2 button in cart summary panal will display and in this panal, Table footer (tfoot) should be right align. Please see attached images. 1) First Add a item to cart. 2) Click on link https://demo.ofbiz.org/ecommerce/control/onePageCheckout -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2960) Improve layout of shopping cart(Step-1) on onepage checkout page
[ https://issues.apache.org/jira/browse/OFBIZ-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur closed OFBIZ-2960. -- Thanks Bharat, Your patch is in trunk rev. 818057 Vikas Improve layout of shopping cart(Step-1) on onepage checkout page Key: OFBIZ-2960 URL: https://issues.apache.org/jira/browse/OFBIZ-2960 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Bharat Soni Assignee: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: 1.png, 2.png, OFBIZ-2960.patch Improve layout of shopping cart(Step-1) on onepage checkout process. After clicking of Continue to step 2 button in cart summary panal will display and in this panal, Table footer (tfoot) should be right align. Please see attached images. 1) First Add a item to cart. 2) Click on link https://demo.ofbiz.org/ecommerce/control/onePageCheckout -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2965) calendar picker does not parse the selected date correctly
[ https://issues.apache.org/jira/browse/OFBIZ-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2965. -- Resolution: Fixed Assignee: Jacques Le Roux Yes, it was a brower cache issue, I thought about OFBiz caches but forgot the browser, thanks Jeremy. I think the only change we did are after // OFBiz addition: functions to call the calendar. So maybe only referring to this issue would be helpful to Tim Harper Your patch is in trunk at r818049, R9.04 r 818065 calendar picker does not parse the selected date correctly -- Key: OFBIZ-2965 URL: https://issues.apache.org/jira/browse/OFBIZ-2965 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04, SVN trunk Reporter: Wickersheimer Jeremy Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 9.04, SVN trunk Attachments: calendar.patch The javascript calendar does not parse date with no times properly, the side effect is that the calendar will default to today's date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2961) Order detail page is not showing selected value for priority.
[ https://issues.apache.org/jira/browse/OFBIZ-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur reassigned OFBIZ-2961: -- Assignee: Vikas Mayur Order detail page is not showing selected value for priority. - Key: OFBIZ-2961 URL: https://issues.apache.org/jira/browse/OFBIZ-2961 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Amit Sharma Assignee: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-2961.patch When we set the order priority from order detail page then priority drop down is not showing selected value. https://demo.ofbiz.org/ordermgr/control/orderview?orderId=DEMO1009 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2961) Order detail page is not showing selected value for priority.
[ https://issues.apache.org/jira/browse/OFBIZ-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur closed OFBIZ-2961. -- Resolution: Fixed Thanks Amit Divesh, Amit your patch is in trunk rev. 818066 Vikas Order detail page is not showing selected value for priority. - Key: OFBIZ-2961 URL: https://issues.apache.org/jira/browse/OFBIZ-2961 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Amit Sharma Assignee: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-2961.patch When we set the order priority from order detail page then priority drop down is not showing selected value. https://demo.ofbiz.org/ordermgr/control/orderview?orderId=DEMO1009 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2960) Improve layout of shopping cart(Step-1) on onepage checkout page
[ https://issues.apache.org/jira/browse/OFBIZ-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758666#action_12758666 ] Bharat Soni commented on OFBIZ-2960: Thanks Vikas for committing my patch. -- Bharat Soni Improve layout of shopping cart(Step-1) on onepage checkout page Key: OFBIZ-2960 URL: https://issues.apache.org/jira/browse/OFBIZ-2960 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Bharat Soni Assignee: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: 1.png, 2.png, OFBIZ-2960.patch Improve layout of shopping cart(Step-1) on onepage checkout process. After clicking of Continue to step 2 button in cart summary panal will display and in this panal, Table footer (tfoot) should be right align. Please see attached images. 1) First Add a item to cart. 2) Click on link https://demo.ofbiz.org/ecommerce/control/onePageCheckout -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Broken links from ofbiz.apache.org
Does somebody knows if we should change Undersun URL or simply remove (comment out actually) ? Thanks Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com The undersun site is no longer at this point - those others - we should definitely remove them. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 20, 2009, at 7:50 AM, Jacques Le Roux wrote: Hi, Not sure it's a problem but on http://ofbiz.apache.org Dnky and Totes-isotoner do not seem to use OFBiz anymore. A problem with Undersun site ? http://www.undersunconsulting.com/control/home.html Jacques
[jira] Commented: (OFBIZ-2353) SequenceUtil may generate duplicate IDs in Load Balancing mode
[ https://issues.apache.org/jira/browse/OFBIZ-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758697#action_12758697 ] Karl Eilebrecht commented on OFBIZ-2353: Hi, if you don't like to replace the whole SequenceUtil by some other implementation, you may adapt the fillBank-method in SequenceUtil as follows: if bank empty then fill bank { suspend TX0; int upd = 0; do { newSequenceMaxValue = lastKnownUsedSequenceValue + bankSize begin TX1 { upd = executeUpdate(UPDATE SEQUENCE_VALUE_ITEM SET SEQ_ID = newSequenceMaxValue WHERE SEQ_NAME = 'mySequence' AND SEQ_ID = lastKnownUsedSequenceValue ); commit TX1; if (upd == 0) { begin TX2 { lastKnownUsedSequenceValue = select SEQ_ID from SEQUENCE_VALUE_ITEM where SEQ_NAME = 'mySequence' commit TX2; } while upd 1; resume TX0; Now the range from lastKnownUsedSequenceValue (exclusive) to newSequenceMaxValue (inclusive) is safe to be used within the current Ofbiz instance. It is essential to use different transactions. Otherwise the pattern will not work. You'll have to integrate the create sequence if missing-feature again, but that is no problem, you may test once for existence and memorize locally that the sequence has been created. (However this convenience feature is a pain in the ass anyway (typos rule the world) ... ;-) ) Regards. Karl SequenceUtil may generate duplicate IDs in Load Balancing mode --- Key: OFBIZ-2353 URL: https://issues.apache.org/jira/browse/OFBIZ-2353 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Philippe Mouawad Priority: Critical If Ofbiz is deploy on 2 servers in Load Balancing Mode SequenceUtil will generate duplicate IDs because synchronization is done at JVM level instead of doing it in DB. A good replacement implementation would be: org.hibernate.id.enhanced.TableGenerator But it would involve a dependency on Hibernate Philippe www.ubik-ingenierie.com -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Broken links from ofbiz.apache.org
Feel free to remove it or direct it www.hotwaxmedia.com - we are no longer using that URL. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 23, 2009, at 6:00 AM, Jacques Le Roux wrote: Does somebody knows if we should change Undersun URL or simply remove (comment out actually) ? Thanks Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com The undersun site is no longer at this point - those others - we should definitely remove them. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 20, 2009, at 7:50 AM, Jacques Le Roux wrote: Hi, Not sure it's a problem but on http://ofbiz.apache.org Dnky and Totes-isotoner do not seem to use OFBiz anymore. A problem with Undersun site ? http://www.undersunconsulting.com/control/home.html Jacques smime.p7s Description: S/MIME cryptographic signature
Re: Synchronisation issues
But before that I'd be interested to have some opinions by people who are using load balancers. Notably Brett who recently answered about this subject on user ML. Because I wonder why Philippe was the 1st to discover theses issues and if others have fixed them in another way. Using synchronization can cause deadlocks. If you do not *fully* control *all* code that is run under synchronization, then a deadlock can occur. If you call some other library, and said library is extensible, such that it might end up calling *back* into your code, you *will* deadlock. Non-blocking algorythms don't have this problem, because they retry in these cases.
Re: Designs behind OFBiz
Hi Ashish, Divesh, I would say that some of OFBiz inspiration is at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Related+Books Also we moved from * Jetty to Tomcat (OFBiz version 3) * Minerva to DBCP (just after OFBiz version 4) * JOTM to Geronimo Transaction manager (OFBiz version 4) Also ECAs replaced previous attempts on workflow engines (notably Shark which was actually an enhancement of the 1st OFBiz workflow) It's all from the top of my head right now HTH Jacques - Original Message - From: Ashish Vijaywargiya To: dev@ofbiz.apache.org Sent: Monday, September 21, 2009 9:16 AM Subject: Re: Designs behind OFBiz Hello Divesh, This is very good post and I would wait to see comment from other senior members involved in this project. Here are few points that I was thinking since last few days and putting here for your reference. -- Initially the project was following the design pattern provided in the book Core J2ee Patterns http://www.corej2eepatterns.com/. -- As the time passed away community discussed so many things on the mailing list and then did vote to move further with the best things in favor of the project. Here are few things that I remembered. --- Initially OFBiz was distributed with jsp files for presentation purpose and then later we have switched to FTL's. --- JPublish was used initially - I am not able to memorize too much details on this project. In past there were no / less activity in this project so community decided to move something better and stable in this area. Now the project is moved to GoogleCode - Please refer: http://code.google.com/p/jpublish/ --- Move from Beanshell to Groovy. The activity on Beanshell project was almost nil so community decided to move to the alternate framework for scripting purpose. There were a long discussion on mailing list to choose which one from available alternates i.e Groovy Ruby scripting language. Then due to so many similarity in Groovy code with Java Syntax community moved along with Groovy project. AFAIK beanshell was one man army open source project - I can be wrong on this point but again this is in my memory. --- Another interesting document: http://docs.ofbiz.org/x/JAw HTH! -- Ashish On Thu, Sep 17, 2009 at 12:16 PM, Divesh Dutta divesh.du...@hotwaxmedia.com wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta Divesh Dutta wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta
[jira] Updated: (OFBIZ-2964) seleniumXml: Patch 1 to seleniumXml ofbiz integration
[ https://issues.apache.org/jira/browse/OFBIZ-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett G. Palmer updated OFBIZ-2964: --- Attachment: ofbiz_seleniumxml_fix_20090923_rev818045.zip This attachment includes the merged seleniumxml files with revision 818045 of the ofbiz trunk. You just need to unzip this file from your ofbiz_home directory and the files should overwrite the existing seleniumxml source and build files. This will be easier than trying to merge the patch I already included. Let me know if there are any questions. Brett seleniumXml: Patch 1 to seleniumXml ofbiz integration - Key: OFBIZ-2964 URL: https://issues.apache.org/jira/browse/OFBIZ-2964 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: eclipse generated patch from svn revision 817293 Reporter: Brett G. Palmer Assignee: Hans Bakker Fix For: SVN trunk Attachments: ofbiz_rev817293_seleniumxml_20090922.patch, ofbiz_seleniumxml_fix_20090923_rev818045.zip Here is a patch to the framework/testtools/seleniumxml code and build files. I tried this a couple of times but could not avoid some painful merges. There were a lot of changes made between the time the code was introduced into ofbiz and now. We will try to get these patches more frequently to avoid the merge problems. This patch includes the following: - Updates to the install-seleniumxml target which includes a new 1.0.2 selenium-server jar file - Ability to run selenium-server and selenium-xml test cases from the ant targets instead of shell scripts. - Ability to use custom FireFox profiles while testing. This lets you avoid the invalid ofbiz certificate error that we saw with the previous version. - Updates to Example test case - More selenium-rc commands and advanced features for testing AJAX applications. I will also add documentation to the ofbiz doc site on how the framework can be setup and run. Brett -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1599) Issues with tax adjustment precision (3 decimals) and AcctgTransEntry.amount field (2 decimal)
[ https://issues.apache.org/jira/browse/OFBIZ-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1599. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Sumit, After 2 successful tests I commited your patch in trunk at r818257 Issues with tax adjustment precision (3 decimals) and AcctgTransEntry.amount field (2 decimal) -- Key: OFBIZ-1599 URL: https://issues.apache.org/jira/browse/OFBIZ-1599 Project: OFBiz Issue Type: Sub-task Components: accounting Reporter: Jacopo Cappellato Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: Issue_1599.patch, Issue_1599.patch, Issue_1599.patch, Issue_1599.patch, Issue_1599.patch On Jan 7, 2008, at 10:17 PM, Scott Gray wrote: Perhaps we need to do 2 things: 1. Summarize AcctgTransEntries so that you have one entry per TaxAuthority rather than for each tax adjustment 2. During order/invoice processing, calc and final should be applied on a per TaxAuthority basis, so that we are only ever collecting final rounded amounts for each tax authority. So for example if we have invoice with the following adjustments: (I just made these numbers up, they don't relate to any percentages) UT_TAXMAN - $4.311 UT_TAXMAN - $7.397 UT_UTAH_TAXMAN - $5.643 UT_UTAH_TAXMAN - $16.828 Tax final would be calculated like this: UT_TAXMAN - $4.311 + $7.399 = $11.71 (2dp) UT_UTAH_TAXMAN - $5.643 + $16.828 = $22.47 (2dp) Tax Total = $11.71 + $22.47 = $34.18 Then the AcctgTransEntries would be: UT_TAXMAN = $11.71 UT_UTAH_TAXMAN = $22.47 Regards Scott On 08/01/2008, David E Jones jone...@hotwaxmedia.com wrote: On Jan 7, 2008, at 11:04 AM, Scott Gray wrote: Hi Jacopo My understanding of calc and final: calc - adjustment level rounding final - the sum of all tax adjustments (tax total) is rounded to this precision Perhaps AcctgTransEntry.amount needs to store to a higher precision as well? What Scott says above is correct as I understand it, but I'm not sure this last part is a good idea. Accounting/GL transactions are meant to be final and to avoid problems they are structured in a way where reporting just involves adding things up and using straight totals with no rounding, etc to avoid any biasing (with the exception of certain averages and such, but that is different as precision on those is used in a different way). It seems to me that posting anything to an accounting with more than 2 decimals of precision seems like a bad idea to me, except perhaps the infamous rounding remainder accounts. We should probably consult with an accounting before doing much of that sort of thing, but of course if we do change the AcctgTransEntry.amount to be higher precision we can always configure/code around it. -David On 08/01/2008, Jacopo Cappellato t...@sastau.it wrote: While testing the GL accounting transactions I've found something that could be an issue in the procedure that computes the sales tax adjustment for the invoice. I've noticed that the InvoiceItem.amount for sales tax contains sometimes a number with 3 decimals, even if the arithmetic.properties file we have: salestax.calc.decimals = 3 salestax.final.decimals = 2 salestax.rounding = ROUND_HALF_UP You can recreate this by creating and invoicing a sales order for 3 units of GZ-1000. For example, look at this invoice: https://demo.hotwaxmedia.com/accounting/control/invoiceOverview?invoiceId=CI1 Having 3 decimals is an issue for the gl auto posting service for sales invoices because the sales tax item generates an AcctgTransEntry, but the AcctgTransEntry.amount field can only store 2 decimals. I'd appreciate suggestions/hints. Cheers, Jacopo -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r728176 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/payment/ webapp/accounting/invoice/ webapp/accounting/payment/ widget/ widget/ap/forms/ widget/ar/forms/
Happy to say that both are closed, thanks to Sumit. Jacques From: Scott Gray lekt...@gmail.com Hi Jacques, Sadly not, both of those issues will require some form of additional rounding logic. Regards Scott 2008/12/27 Jacques Le Roux jacques.le.r...@les7arts.com I did not get a chance to look at this yet. I wonder if this effort will solve https://issues.apache.org/jira/browse/OFBIZ-1599 https://issues.apache.org/jira/browse/OFBIZ-1579 ? Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Scott, I checked out and will have a look Thanks Jacques From: Scott Gray lekt...@gmail.com Hi Jacques Any help would be appreciated, there are still a number of components which need cleaning. Many thanks Scott 2008/12/20 Jacques Le Roux jacques.le.r...@les7arts.com OK no pb, reverted in revision: 728247 I thought it would be good to give the right type. For instance getInvoiceNotApplied is returning a BigDecimal not a Double But I must say I did not check them all (my changes I mean) Anyway I understan it should be better done in typecheckcleanup200810. Scott do you prefer to do it or that I do it myself ? Thanks Jacques From: David E Jones d...@me.com Jacques, The Double to BigDecimal work is currently being done in the typecheckcleanup200810 branch. The reason is that there are a LOT of changes to make, and many places where even Java types for entity engine fields are changing. Making changes a little at a time has proven to be problematic and painful, so in this branch we are taking a bottom-up approach and making it pretty comprehensive. Unless there is a specific issue you're trying to address with this commit, I'd recommend reverting it and looking at the same changes in the typecheckcleanup200810 branch. The full SVN URL for that branch is: https://svn.apache.org/repos/asf/ofbiz/branches/typecheckcleanup200810 -David On Dec 19, 2008, at 3:25 PM, jler...@apache.org wrote: Author: jleroux Date: Fri Dec 19 14:25:35 2008 New Revision: 728176 URL: http://svn.apache.org/viewvc?rev=728176view=rev Log: Some BigDecimals in xml files Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ payment/PaymentServices.xml ofbiz/trunk/applications/accounting/webapp/accounting/invoice/ InvoiceForms.xml ofbiz/trunk/applications/accounting/webapp/accounting/payment/ PaymentForms.xml ofbiz/trunk/applications/accounting/widget/BillingAccountForms.xml ofbiz/trunk/applications/accounting/widget/PaymentScreens.xml ofbiz/trunk/applications/accounting/widget/ ReportFinancialSummaryForms.xml ofbiz/trunk/applications/accounting/widget/ap/forms/ InvoiceForms.xml ofbiz/trunk/applications/accounting/widget/ar/forms/ InvoiceForms.xml Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/ accounting/payment/PaymentServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=728176r1=728175r2=728176view=diff = = = = = = = = == --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ payment/PaymentServices.xml (original) +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ payment/PaymentServices.xml Fri Dec 19 14:25:35 2008 @@ -145,7 +145,7 @@ entity-one entity-name=Invoice value-name=invoice/ !-- get the amount that has not been applied yet for the invoice (outstanding amount) -- -set field=notApplied value=$ {bsh:org .ofbiz .accounting .invoice.InvoiceWorker.getInvoiceNotApplied(invoice).doubleValue()} type=Double/ +set field=notApplied value=$ {bsh:org .ofbiz .accounting .invoice.InvoiceWorker.getInvoiceNotApplied(invoice).doubleValue()} type=BigDecimal/ !-- if the amount to apply goes over the outstanding amount, then use the notApplied amount and log a warning -- if-compare-field field=paymentAppl.amountApplied to- field=notApplied operator=greater type=Double @@ -186,7 +186,7 @@ !-- check if the payment fully applied when set to confirmed-- if-compare field=parameters.statusId operator=equals value=PMNT_CONFIRMED -set field=notYetApplied value=$ {bsh:org .ofbiz .accounting.payment.PaymentWorker.getPaymentNotAppliedBd(payment)}/ +set field=notYetApplied value=$ {bsh:org .ofbiz .accounting.payment.PaymentWorker.getPaymentNotAppliedBd(payment)} type=BigDecimal/ if-compare field=notYetApplied operator=greater value=0.00 add-errorfail-property resource=AccountingUiLabels property=AccountingPSNotConfirmedNotFullyApplied//add-error log level=error message=Cannot change from ${payment.statusId} to ${parameters.statusId}, payment not fully applied: ${notYetapplied}/ Modified: ofbiz/trunk/applications/accounting/webapp/accounting/
[jira] Updated: (OFBIZ-2219) Special feature to allow submitting patches for online help update
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-2219: --- Attachment: (was: OFBIZ-2219_DocbookAccountingHelp4.patch) Special feature to allow submitting patches for online help update -- Key: OFBIZ-2219 URL: https://issues.apache.org/jira/browse/OFBIZ-2219 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Hans Bakker Priority: Minor *This issue should not be closed, at least until the online help is not completed...* in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2219) Special feature to allow submitting patches for online help update
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-2219: --- Attachment: OFBIZ-2219_DocbookAccountingHelp5.patch Hi Hans Another online help and Docbook patch for Accounting. This time for Billing Accounts and Payment Gateway Configuration. I've kept in line with your new 2nd level tree structure and corrected a minor error on the xml file name that was not allowing the 'Payment Gateway' (Transactions) top level help from being displayed. I can see that the online help is coming together now and really starting to look good. Thanks Sharan Special feature to allow submitting patches for online help update -- Key: OFBIZ-2219 URL: https://issues.apache.org/jira/browse/OFBIZ-2219 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Hans Bakker Priority: Minor Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch *This issue should not be closed, at least until the online help is not completed...* in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Designs behind OFBiz
You might find the old conference videos interesting. There is a lot of history and background presented there, as well as what was going on around the time of those conferences. -David On Sep 23, 2009, at 12:07 PM, Jacques Le Roux wrote: Hi Ashish, Divesh, I would say that some of OFBiz inspiration is at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Related+Books Also we moved from * Jetty to Tomcat (OFBiz version 3) * Minerva to DBCP (just after OFBiz version 4) * JOTM to Geronimo Transaction manager (OFBiz version 4) Also ECAs replaced previous attempts on workflow engines (notably Shark which was actually an enhancement of the 1st OFBiz workflow) It's all from the top of my head right now HTH Jacques - Original Message - From: Ashish Vijaywargiya To: dev@ofbiz.apache.org Sent: Monday, September 21, 2009 9:16 AM Subject: Re: Designs behind OFBiz Hello Divesh, This is very good post and I would wait to see comment from other senior members involved in this project. Here are few points that I was thinking since last few days and putting here for your reference. -- Initially the project was following the design pattern provided in the book Core J2ee Patterns http://www.corej2eepatterns.com/. -- As the time passed away community discussed so many things on the mailing list and then did vote to move further with the best things in favor of the project. Here are few things that I remembered. --- Initially OFBiz was distributed with jsp files for presentation purpose and then later we have switched to FTL's. --- JPublish was used initially - I am not able to memorize too much details on this project. In past there were no / less activity in this project so community decided to move something better and stable in this area. Now the project is moved to GoogleCode - Please refer: http://code.google.com/p/jpublish/ --- Move from Beanshell to Groovy. The activity on Beanshell project was almost nil so community decided to move to the alternate framework for scripting purpose. There were a long discussion on mailing list to choose which one from available alternates i.e Groovy Ruby scripting language. Then due to so many similarity in Groovy code with Java Syntax community moved along with Groovy project. AFAIK beanshell was one man army open source project - I can be wrong on this point but again this is in my memory. --- Another interesting document: http://docs.ofbiz.org/x/JAw HTH! -- Ashish On Thu, Sep 17, 2009 at 12:16 PM, Divesh Dutta divesh.du...@hotwaxmedia.com wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta Divesh Dutta wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta
Re: Designs behind OFBiz
Forgot the link: http://ofbiz.apache.org/VideosConf.html -David On Sep 23, 2009, at 4:13 PM, David E Jones wrote: You might find the old conference videos interesting. There is a lot of history and background presented there, as well as what was going on around the time of those conferences. -David On Sep 23, 2009, at 12:07 PM, Jacques Le Roux wrote: Hi Ashish, Divesh, I would say that some of OFBiz inspiration is at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Related+Books Also we moved from * Jetty to Tomcat (OFBiz version 3) * Minerva to DBCP (just after OFBiz version 4) * JOTM to Geronimo Transaction manager (OFBiz version 4) Also ECAs replaced previous attempts on workflow engines (notably Shark which was actually an enhancement of the 1st OFBiz workflow) It's all from the top of my head right now HTH Jacques - Original Message - From: Ashish Vijaywargiya To: dev@ofbiz.apache.org Sent: Monday, September 21, 2009 9:16 AM Subject: Re: Designs behind OFBiz Hello Divesh, This is very good post and I would wait to see comment from other senior members involved in this project. Here are few points that I was thinking since last few days and putting here for your reference. -- Initially the project was following the design pattern provided in the book Core J2ee Patterns http://www.corej2eepatterns.com/. -- As the time passed away community discussed so many things on the mailing list and then did vote to move further with the best things in favor of the project. Here are few things that I remembered. --- Initially OFBiz was distributed with jsp files for presentation purpose and then later we have switched to FTL's. --- JPublish was used initially - I am not able to memorize too much details on this project. In past there were no / less activity in this project so community decided to move something better and stable in this area. Now the project is moved to GoogleCode - Please refer: http://code.google.com/p/jpublish/ --- Move from Beanshell to Groovy. The activity on Beanshell project was almost nil so community decided to move to the alternate framework for scripting purpose. There were a long discussion on mailing list to choose which one from available alternates i.e Groovy Ruby scripting language. Then due to so many similarity in Groovy code with Java Syntax community moved along with Groovy project. AFAIK beanshell was one man army open source project - I can be wrong on this point but again this is in my memory. --- Another interesting document: http://docs.ofbiz.org/x/JAw HTH! -- Ashish On Thu, Sep 17, 2009 at 12:16 PM, Divesh Dutta divesh.du...@hotwaxmedia.com wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta Divesh Dutta wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta
[jira] Commented: (OFBIZ-2219) Special feature to allow submitting patches for online help update
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758977#action_12758977 ] Hans Bakker commented on OFBIZ-2219: Hi Sharan, you contribution OFBIZ-2219_DocbookAccountingHelp5.patch is Committed in revision 818348. Could you please have a look at you editor settings? 4 spaces for a tab should be the setting so the file should not contain tabs. In this contribution i have corrected this for you. Regards, Hans Special feature to allow submitting patches for online help update -- Key: OFBIZ-2219 URL: https://issues.apache.org/jira/browse/OFBIZ-2219 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Hans Bakker Priority: Minor Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch *This issue should not be closed, at least until the online help is not completed...* in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Service deprecation
Hi all, What do you think about adding the ability to deprecate services? We could add an attribute to the service definition indicating that it has been deprecated and then log a warning whenever it is invoked. That would allow us to change the names of or remove services without breaking existing installations, we'd just move the old service to the bottom of the service definition file and then remove it after the next release. I don't have a pressing need for this, it's just an idea I had after seeing some poorly named services around the place. Regards Scott HotWax Media http://www.hotwaxmedia.com smime.p7s Description: S/MIME cryptographic signature
Re: Service deprecation
+1, This would be a good idea, Including this I would be good to have two attribute instead of one - One for indicating that it has been deprecated (as Scott's suggested) and second one tell the name of service/s that will replace the deprecated service. -- Thanks And Regards Sumit Pandit On 24-Sep-09, at 8:19 AM, Scott Gray wrote: Hi all, What do you think about adding the ability to deprecate services? We could add an attribute to the service definition indicating that it has been deprecated and then log a warning whenever it is invoked. That would allow us to change the names of or remove services without breaking existing installations, we'd just move the old service to the bottom of the service definition file and then remove it after the next release. I don't have a pressing need for this, it's just an idea I had after seeing some poorly named services around the place. Regards Scott HotWax Media http://www.hotwaxmedia.com
Re: Service deprecation
A deprecation message would be a good idea, perhaps we could just have that as the single attribute, if the attribute has content then the service is deprecated. Doing so would force a developer to include a message in order to deprecate a service. Regards Scott On 24/09/2009, at 3:44 PM, Sumit Pandit wrote: +1, This would be a good idea, Including this I would be good to have two attribute instead of one - One for indicating that it has been deprecated (as Scott's suggested) and second one tell the name of service/s that will replace the deprecated service. -- Thanks And Regards Sumit Pandit On 24-Sep-09, at 8:19 AM, Scott Gray wrote: Hi all, What do you think about adding the ability to deprecate services? We could add an attribute to the service definition indicating that it has been deprecated and then log a warning whenever it is invoked. That would allow us to change the names of or remove services without breaking existing installations, we'd just move the old service to the bottom of the service definition file and then remove it after the next release. I don't have a pressing need for this, it's just an idea I had after seeing some poorly named services around the place. Regards Scott HotWax Media http://www.hotwaxmedia.com smime.p7s Description: S/MIME cryptographic signature
[jira] Commented: (OFBIZ-2219) Special feature to allow submitting patches for online help update
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12759002#action_12759002 ] Jacques Le Roux commented on OFBIZ-2219: Hi Sharan, This may help http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions Special feature to allow submitting patches for online help update -- Key: OFBIZ-2219 URL: https://issues.apache.org/jira/browse/OFBIZ-2219 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Hans Bakker Priority: Minor Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch *This issue should not be closed, at least until the online help is not completed...* in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Service deprecation
+1, and maybe another field to comment Jacques From: Sumit Pandit sumit.pan...@hotwaxmedia.com +1, This would be a good idea, Including this I would be good to have two attribute instead of one - One for indicating that it has been deprecated (as Scott's suggested) and second one tell the name of service/s that will replace the deprecated service. -- Thanks And Regards Sumit Pandit On 24-Sep-09, at 8:19 AM, Scott Gray wrote: Hi all, What do you think about adding the ability to deprecate services? We could add an attribute to the service definition indicating that it has been deprecated and then log a warning whenever it is invoked. That would allow us to change the names of or remove services without breaking existing installations, we'd just move the old service to the bottom of the service definition file and then remove it after the next release. I don't have a pressing need for this, it's just an idea I had after seeing some poorly named services around the place. Regards Scott HotWax Media http://www.hotwaxmedia.com
Re: Designs behind OFBiz
Thanks David Jacques for your valuable comment. -- Ashish On Thu, Sep 24, 2009 at 3:44 AM, David E Jones d...@me.com wrote: Forgot the link: http://ofbiz.apache.org/VideosConf.html -David On Sep 23, 2009, at 4:13 PM, David E Jones wrote: You might find the old conference videos interesting. There is a lot of history and background presented there, as well as what was going on around the time of those conferences. -David On Sep 23, 2009, at 12:07 PM, Jacques Le Roux wrote: Hi Ashish, Divesh, I would say that some of OFBiz inspiration is at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Related+Books Also we moved from * Jetty to Tomcat (OFBiz version 3) * Minerva to DBCP (just after OFBiz version 4) * JOTM to Geronimo Transaction manager (OFBiz version 4) Also ECAs replaced previous attempts on workflow engines (notably Shark which was actually an enhancement of the 1st OFBiz workflow) It's all from the top of my head right now HTH Jacques - Original Message - From: Ashish Vijaywargiya To: dev@ofbiz.apache.org Sent: Monday, September 21, 2009 9:16 AM Subject: Re: Designs behind OFBiz Hello Divesh, This is very good post and I would wait to see comment from other senior members involved in this project. Here are few points that I was thinking since last few days and putting here for your reference. -- Initially the project was following the design pattern provided in the book Core J2ee Patterns http://www.corej2eepatterns.com/. -- As the time passed away community discussed so many things on the mailing list and then did vote to move further with the best things in favor of the project. Here are few things that I remembered. --- Initially OFBiz was distributed with jsp files for presentation purpose and then later we have switched to FTL's. --- JPublish was used initially - I am not able to memorize too much details on this project. In past there were no / less activity in this project so community decided to move something better and stable in this area. Now the project is moved to GoogleCode - Please refer: http://code.google.com/p/jpublish/ --- Move from Beanshell to Groovy. The activity on Beanshell project was almost nil so community decided to move to the alternate framework for scripting purpose. There were a long discussion on mailing list to choose which one from available alternates i.e Groovy Ruby scripting language. Then due to so many similarity in Groovy code with Java Syntax community moved along with Groovy project. AFAIK beanshell was one man army open source project - I can be wrong on this point but again this is in my memory. --- Another interesting document: http://docs.ofbiz.org/x/JAw HTH! -- Ashish On Thu, Sep 17, 2009 at 12:16 PM, Divesh Dutta divesh.du...@hotwaxmedia.com wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta Divesh Dutta wrote: Hello all, I would like to know that, Was there any Blue Print, or Design developed when OFBiz was imagined or started. Do we have any documentation, Where when one get information like, What Design patterns were kept in mind when OFBiz was started. How OFBiz evolved or What was initial thought behind this and as time went by , How these designs changed? Thanks -- Divesh Dutta
[jira] Commented: (OFBIZ-2600) Bugs under Getting and Running OFBiz in 5 steps
[ https://issues.apache.org/jira/browse/OFBIZ-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12759009#action_12759009 ] Jacques Le Roux commented on OFBIZ-2600: Hi BJ, I wonder if the new Setup component is not the solution now. I did not test, could you ? Bugs under Getting and Running OFBiz in 5 steps --- Key: OFBIZ-2600 URL: https://issues.apache.org/jira/browse/OFBIZ-2600 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 9.04, SVN trunk Environment: branch 9.04 Centos 5 using open JDK 1.6 Reporter: BJ Freeman Priority: Minor Fix For: Release Branch 9.04, SVN trunk http://docs.ofbiz.org/display/~jacopoc/Quick+Start+Guide+1+-+Getting+and+Running+OFBiz+in+5+steps did a ant run-install-extseed load-admin-user-login -DuserLoginId=ENTER-A-USER-LOGIN-HERE I am finding different bug in this configuration so this is the focal point for them. I will make a comment with same data to show. 1)Party profile get all scrunched up if imported. 2) Customer role is not appended to a new customer when created thru the ecommerce. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
OFBiz site as an application
Hi, I will soon remove this application if nobody sees a problem with that. It's totally deprecated now and anyway, even if we update it, we will have to update in the future, etc. Jacques
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12759014#action_12759014 ] Jacques Le Roux commented on OFBIZ-2888: Bump! Reserved words used for field names in PaymentGatewayOrbital Key: OFBIZ-2888 URL: https://issues.apache.org/jira/browse/OFBIZ-2888 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Environment: Linux, Java 1.6, Postgresql 8.3 with driver postgresql-8.3-604.jdbc4.jar Reporter: Anne Jessel Priority: Minor On starting Rev 809782 of trunk, I see the following warnings: 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= Found 2 warnings when checking the entity definitions: 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a reserved word. 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Service deprecation
+1. I think that a single attribute, something like deprecation- message or deprecation-comment, should do the job. -- Thanks, Mridul Pathak On 24-Sep-09, at 9:24 AM, Scott Gray wrote: A deprecation message would be a good idea, perhaps we could just have that as the single attribute, if the attribute has content then the service is deprecated. Doing so would force a developer to include a message in order to deprecate a service. Regards Scott On 24/09/2009, at 3:44 PM, Sumit Pandit wrote: +1, This would be a good idea, Including this I would be good to have two attribute instead of one - One for indicating that it has been deprecated (as Scott's suggested) and second one tell the name of service/s that will replace the deprecated service. -- Thanks And Regards Sumit Pandit On 24-Sep-09, at 8:19 AM, Scott Gray wrote: Hi all, What do you think about adding the ability to deprecate services? We could add an attribute to the service definition indicating that it has been deprecated and then log a warning whenever it is invoked. That would allow us to change the names of or remove services without breaking existing installations, we'd just move the old service to the bottom of the service definition file and then remove it after the next release. I don't have a pressing need for this, it's just an idea I had after seeing some poorly named services around the place. Regards Scott HotWax Media http://www.hotwaxmedia.com smime.p7s Description: S/MIME cryptographic signature
[jira] Updated: (OFBIZ-2895) POS for 800 x 600
[ https://issues.apache.org/jira/browse/OFBIZ-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Ng updated OFBIZ-2895: -- Attachment: 800x600.zip Enclosed please find a zip file. Remarks: In /specialpurpose/pos/config/xpos.properties, the variables of ClientWidth/ClientHeight have to be modified from 1024/768 to 800/600. POS for 800 x 600 - Key: OFBIZ-2895 URL: https://issues.apache.org/jira/browse/OFBIZ-2895 Project: OFBiz Issue Type: New Feature Affects Versions: SVN trunk Reporter: Terence Ng Assignee: Jacques Le Roux Priority: Minor Attachments: 800x600.zip, ConfigureItem.xml, journal.xml, mgrmain.xml, mgrpanel.xml, numeric.xml, payinput.xml, paymain.xml, paypanel.xml, posinput.xml, posmain.xml, pospanel.xml, promomain.xml, promopanel.xml Enclosed please find several files required to run POS for 800 x 600 resolution basically. Because I do not know where to trigger e.g. keyboard.xml; therefore, I have not worked on it yet. And I do not know how to add this feature. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.