date:20110129


[ 
https://issues.apache.org/jira/browse/OFBIZ-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988420#action_12988420
 ] 

Jacques Le Roux commented on OFBIZ-3897:


James,

From the recent exchanges on dev ML, should we keep this issue open?

 Wicket component
 

 Key: OFBIZ-3897
 URL: https://issues.apache.org/jira/browse/OFBIZ-3897
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: james yong
Priority: Minor
 Fix For: SVN trunk

 Attachments: patch.txt, patch20100901.txt


 This component allow developers to use Wicket framework

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly


[ 
https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988423#action_12988423
 ] 

Jacques Le Roux commented on OFBIZ-3862:


Hi Bilgin,

Yes I think it's a good idea

 Ajax requests prevent externalLoginKey parameters from working correctly
 

 Key: OFBIZ-3862
 URL: https://issues.apache.org/jira/browse/OFBIZ-3862
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Scott Gray

 A new external login key is generated for every request so if an ajax request 
 fires on a page then the externalLoginKey used in any links on the page is 
 invalidated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3868) Adding de UI Lables on framework CommonUILabels


[ 
https://issues.apache.org/jira/browse/OFBIZ-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988425#action_12988425
 ] 

Jacques Le Roux commented on OFBIZ-3868:


Ping

 Adding de UI Lables on framework CommonUILabels
 ---

 Key: OFBIZ-3868
 URL: https://issues.apache.org/jira/browse/OFBIZ-3868
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: irrelevant; XML config data
Reporter: Carsten Schinzer
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: OFBIZ-3868_Adding de UI Lables on framework 
 CommonUILabels.patch, OFBIZ-3868_Adding de UI Lables on framework 
 CommonUILabels.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 All missing de UI labels have been added in the CommonUiLables.xml file.
 Note: This patch also includes the UI Labels required for JIRA issue 
 OFBIZ-3844 (i.e. replacing the OFBIZ-3844_Splitting CommonRate and 
 CommonProductRating_part2.patch which has now been removed from OFBIY-3844.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3186) Layered Navigation of Categories

[
https://issues.apache.org/jira/browse/OFBIZ-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988426#action_12988426
]

Jacques Le Roux commented on OFBIZ-3186:

Hi Mridul,

Why can't it stays side by side with Side Deep Category?

Layered Navigation of Categories

Key: OFBIZ-3186
URL: https://issues.apache.org/jira/browse/OFBIZ-3186
Project: OFBiz
Issue Type: New Feature
Components: product, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Mridul Pathak
Assignee: Ashish Vijaywargiya
Priority: Minor
Fix For: SVN trunk

Attachments: OFBIZ-3186.patch

Layered navigation in an Ecommerce application allows the user to filter the
product listing based on categories, features and price ranges. The user can
apply multiple filters to the given product listing. He can narrow or expand
his search and try different filter combinations so as to find the desired
product.
I have implemented Layered Navigation in OFBiz ecommerce with following
filters:
# Sub Categories: This filter is shown whenever there are sub-categories
present under the top-level category or current selected category. Count of
products within the category is shown against each category, works with
multilevel deep category hierarchy. Selecting a sub category will show
products within that category and filters will be updated accordingly for the
new product list.
# Features: Feature filters are grouped by Feature Types. Count of products
that has the feature associated as standard, selectable or distinguishing is
shown against that feature. Current Implementation has feature filters for
ProductFeatureType=COLOR.
# List Price Range: This filter will always show. When applied filters
product based on List Price Range. Current implementation is done by listing
static price ranges at code level.
The above implementation is completely based on the OOTB Product Search
functionality with few additional methods in ProductSearchSession to derive
count against different type of filters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (OFBIZ-3839) Wrong number of products coming in layered navigation functionality.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3839.
--

Resolution: Fixed
  Assignee: Jacques Le Roux

Thanks Amit,

Your patch is in trunk at r1064996

 Wrong number of products coming in layered navigation functionality.
 

 Key: OFBIZ-3839
 URL: https://issues.apache.org/jira/browse/OFBIZ-3839
 Project: OFBiz
  Issue Type: Bug
Reporter: Amit Sharma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: Release Branch 10.04

 Attachments: OFBIZ-3839.patch


 Wrong number of products coming in layered navigation functionality.
 Here is the steps to verify :-
 # Enable layered navigation by uncommenting layered section in category 
 screen of CatalogScreens.xml.
 # Go to http://localhost:8080/ecommerce/control/main
 # Press Gizmos category from browse category section.
 # Now Layered Navigation section will show it sub category and features with 
 number of products. Like :-
 #* Categories
 ##*  Large Gizmos (12)
 ##*  Small Gizmos (14)
 #* Price Range
 ##* $0.00 - $10.00 (4)
 ##* $10.00 - $20.00 (2)
 # Click on Large Gizmos category.
 # Now category details shows only 6 products.
 There are only 6 products in large gizmos category but it shows 12 products, 
 which is wrong behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

buildbot success in ASF Buildbot on ofbiz-trunk

2011-01-29 Thread buildbot

The Buildbot has detected a restored build of ofbiz-trunk on ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/1249

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason: 
Build Source Stamp: [branch ofbiz/trunk] 1064993
Blamelist: ashish

Build succeeded!

sincerely,
 -The Buildbot

[jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode

2011-01-29 Thread Shi Yusen (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988428#action_12988428
 ] 

Shi Yusen commented on OFBIZ-4154:
--

Hi Jacques,

Yes, I agree with you. Only the jars and a simple sample are required as the 
barcode4j. I'm not sure where to put them.

Regards,

 Use ZXing to generic QR 2d barcode
 --

 Key: OFBIZ-4154
 URL: https://issues.apache.org/jira/browse/OFBIZ-4154
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: SVN trunk
 Environment: OFBiz trunk 1064255 + Sun JDK 1.5.0_14-b03 + Fedora 10
Reporter: Shi Yusen
Priority: Trivial
 Attachments: greetings.png, ofbiz-trunk-zxing.patch, 
 zxing-core-1.6.jar, zxing-javase-1.6.jar

   Original Estimate: 24h
  Remaining Estimate: 24h

 QR 2d barcode gives me a lot of fun when I use an adroid mobile. After google 
 search, without any difficulty I found zxing: 
 http://code.google.com/p/zxing/, it's in Apache License.
 I'll submit a sample component of zxing to generate 2d qr barcode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

End of month : Main New features

2011-01-29 Thread Jacques Le Roux


Please devs, don't forget to add your changes in Main New features with shorts 
explanations

https://cwiki.apache.org/confluence/display/OFBIZ/Main+New+Features

Thanks

Jacques

[jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode


[ 
https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988434#action_12988434
 ] 

Jacques Le Roux commented on OFBIZ-4154:


Yusen,

I'd suggest a new Barcodes Menu in Example. When you will have done it (can 
you?), I will also add an example using the std one I already posted for 
Product long time ago (it's generated in a PDF using FOP)

Thanks!

 Use ZXing to generic QR 2d barcode
 --

 Key: OFBIZ-4154
 URL: https://issues.apache.org/jira/browse/OFBIZ-4154
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: SVN trunk
 Environment: OFBiz trunk 1064255 + Sun JDK 1.5.0_14-b03 + Fedora 10
Reporter: Shi Yusen
Priority: Trivial
 Attachments: greetings.png, ofbiz-trunk-zxing.patch, 
 zxing-core-1.6.jar, zxing-javase-1.6.jar

   Original Estimate: 24h
  Remaining Estimate: 24h

 QR 2d barcode gives me a lot of fun when I use an adroid mobile. After google 
 search, without any difficulty I found zxing: 
 http://code.google.com/p/zxing/, it's in Apache License.
 I'll submit a sample component of zxing to generate 2d qr barcode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode

2011-01-29 Thread Shi Yusen

Sure, I'll do it as you suggested several days later.

Thank you,
 

在 2011-01-29六的 06:24 -0500，Jacques Le Roux (JIRA)写道：
 [ 
 https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988434#action_12988434
  ] 
 
 Jacques Le Roux commented on OFBIZ-4154:
 
 
 Yusen,
 
 I'd suggest a new Barcodes Menu in Example. When you will have done it (can 
 you?), I will also add an example using the std one I already posted for 
 Product long time ago (it's generated in a PDF using FOP)
 
 Thanks!
 
  Use ZXing to generic QR 2d barcode
  --
 
  Key: OFBIZ-4154
  URL: https://issues.apache.org/jira/browse/OFBIZ-4154
  Project: OFBiz
   Issue Type: New Feature
 Affects Versions: SVN trunk
  Environment: OFBiz trunk 1064255 + Sun JDK 1.5.0_14-b03 + Fedora 10
 Reporter: Shi Yusen
 Priority: Trivial
  Attachments: greetings.png, ofbiz-trunk-zxing.patch, 
  zxing-core-1.6.jar, zxing-javase-1.6.jar
 
Original Estimate: 24h
   Remaining Estimate: 24h
 
  QR 2d barcode gives me a lot of fun when I use an adroid mobile. After 
  google search, without any difficulty I found zxing: 
  http://code.google.com/p/zxing/, it's in Apache License.
  I'll submit a sample component of zxing to generate 2d qr barcode.

Re: svn commit: r1064953 - in /ofbiz/trunk/framework/common: script/org/ofbiz/common/email/EmailServices.xml src/org/ofbiz/common/email/EmailServices.java

2011-01-29 Thread Ashish Vijaywargiya

Its been taken care in my recent r1064993.
Now buildbot is returning success :-)

--
Ashish

On Sat, Jan 29, 2011 at 11:38 AM, Ashish Vijaywargiya 
vijaywargiya.ash...@gmail.com wrote:

 Hello Jacopo,

 Yes, I noticed the buildbot failure notification. We are looking into it
 and then will get back.
 Thanks!

 --
 Ashish


 On Sat, Jan 29, 2011 at 11:31 AM, Jacopo Cappellato 
 jacopo.cappell...@hotwaxmedia.com wrote:

 Hi Ashish,

 it seems that this is breaking an automated test:

 sendShipmentCompleteNotification) does not match expected requirements
 (Unknown parameter found:
 [sendShipmentCompleteNotification.communicationEventId])

 Jacopo


 On Jan 29, 2011, at 6:29 AM, ash...@apache.org wrote:

  Author: ashish
  Date: Sat Jan 29 05:29:55 2011
  New Revision: 1064953
 
  URL: http://svn.apache.org/viewvc?rev=1064953view=rev
  Log:
  Bug fix. Returning communicationEventId from the service implementation
 which was defined OUT in service definition. Thanks Divesh!
 
  Modified:
 
  ofbiz/trunk/framework/common/script/org/ofbiz/common/email/EmailServices.xml
 
  ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
 
  Modified:
 ofbiz/trunk/framework/common/script/org/ofbiz/common/email/EmailServices.xml
  URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/script/org/ofbiz/common/email/EmailServices.xml?rev=1064953r1=1064952r2=1064953view=diff
 
 ==
  ---
 ofbiz/trunk/framework/common/script/org/ofbiz/common/email/EmailServices.xml
 (original)
  +++
 ofbiz/trunk/framework/common/script/org/ofbiz/common/email/EmailServices.xml
 Sat Jan 29 05:29:55 2011
  @@ -69,6 +69,7 @@ under the License.
  call-service service-name=sendMailFromScreen
 in-map-name=emailParams
  result-to-result result-name=messageWrapper/
  result-to-result result-name=body/
  +result-to-result result-name=communicationEventId/
  /call-service
  else
  log level=error message=sendMailFromTemplateSetting
 service could not find the emailTemplateSettingId:
 ${parameters.emailTemplateSettingId}/log
 
  Modified:
 ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
  URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java?rev=1064953r1=1064952r2=1064953view=diff
 
 ==
  ---
 ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
 (original)
  +++
 ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
 Sat Jan 29 05:29:55 2011
  @@ -611,6 +611,7 @@ public class EmailServices {
  result.put(messageWrapper,
 sendMailResult.get(messageWrapper));
  result.put(body, bodyWriter.toString());
  result.put(subject, subject);
  +result.put(communicationEventId,
 sendMailResult.get(communicationEventId));
  if (UtilValidate.isNotEmpty(orderId)) {
  result.put(orderId, orderId);
  }

[jira] Closed: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3765.
--

Resolution: Fixed

Thanks Nicolas, Anne,

Nicolas, your patch is in trunk at r1065014  


 Use CustomMethod for select order, quote and invoice hook to resolve id
 ---

 Key: OFBIZ-3765
 URL: https://issues.apache.org/jira/browse/OFBIZ-3765
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting, order
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Assignee: Erwan de FERRIERES
 Fix For: SVN trunk

 Attachments: hookByPartyAcctgPreference.patch, 
 OFBIZ-3765-Missed.patch, OFBIZ-3765.patch


 Currently the invoiceId resolve process is define on PartyAcctgPreference by 
 a enumeration. The service getNextInvoiceId analyse enumeration to active 
 code correponding to enumeration.
 I propose pass enumeration to CustumMethod that permit to add more easier a 
 new resolve process. Just define a new CusthomMethod and associate to 
 PartyAcctgPreference. It's possible to add this by hot-deploy compenents 
 without change accounting code or add many unreadable function.
 The patch contains :
  * Entity modiication : pass enumeration to deprecated and add custumMethod 
 attribute/relation
  * Add service enforced ans restart define previously by enumeration
  * Implement getNextSeqId service by origin call service to permet analyse 
 and resolve new id by all information present in context
  * Add error message if PartyAcctgPreference not define.
  * Apply on invoice, quote an order
 To test just ant clean-all  ant run-install and create quote, order and 
 invoice
 Thanks to Leila Mekika for the help
 Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1063233 - in /ofbiz/branches/release10.04/applications/product/widget/catalog: CommonScreens.xml ProductScreens.xml

2011-01-29 Thread Vikas Mayur

Jacques,

I completely agree with you. Will keep an eye on others response and if
required will revert.

Regards
Vikas

On Sat, Jan 29, 2011 at 3:04 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 Vikas,

 If nobody see a problem with it and you are sure it's safe, why not...
 Just that it should be considered as really exceptional

 Thanks

 Jacques

 From: Vikas Mayur vikasma...@gmail.com

  Sorry for late reply - Jacques.

 It does not relates to a real bug but I think the changes does no harm to
 the release either.

 is that okay?

 Regards
 Vikas

 On Tue, Jan 25, 2011 at 5:23 PM, Jacques Le Roux 
 jacques.le.r...@les7arts.com wrote:

  Mmm... is that a bug?

 Jacques


 m...@apache.org wrote:

  Author: mor
 Date: Tue Jan 25 11:32:24 2011
 New Revision: 1063233

 URL: http://svn.apache.org/viewvc?rev=1063233view=rev
 Log:
 Merged from trunk r1063227. Log: Parameterized CommonProductDecorator
 screen location so that custom apps can override it easily.

 Modified:


 ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml


 ofbiz/branches/release10.04/applications/product/widget/catalog/ProductScreens.xml

 Modified:

 ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
 URL:


 http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml?rev=1063233r1=1063232r2=1063233view=diff

 ==
 ---

 ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
 (original) +++

 ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
 Tue Jan 25 11:32:24 2011 @@ -48,92 +48,6 @@
   under the License. /section
   /screen

 -screen name=CommonProductDecorator
 -section
 -actions
 -property-map resource=PartyUiLabels
 map-name=uiLabelMap global=true/
 -property-map resource=OrderUiLabels
 map-name=uiLabelMap global=true/
 -set field=productId
 from-field=parameters.productId/
 -entity-one entity-name=Product
 value-field=product/
 -set field=productName
 from-field=product.productName/
 -/actions
 -widgets
 -decorator-screen name=main-decorator
 location=${parameters.mainDecoratorLocation}
 -decorator-section name=pre-body
 -section
 -condition
 -and
 -if-has-permission
 permission=CATALOG action=_VIEW/
 -notif-empty
 field=product//not
 -/and
 -/condition
 -widgets
 -include-menu name=ProductTabBar
 location=component://product/widget/catalog/CatalogMenus.xml/
 -/widgets
 -/section
 -/decorator-section
 -decorator-section name=left-column
 -include-screen name=leftbar/
 -/decorator-section
 -decorator-section name=body
 -section
 -!-- do check for CATALOG, _VIEW permission
 --
 -condition
 -if-has-permission permission=CATALOG
 action=_VIEW/
 -/condition
 -widgets
 -section
 -condition
 -notif-empty
 field=product//not
 -/condition
 -widgets
 -container
 -label
 style=h1${uiLabelMap[labelTitleProperty]} ${uiLabelMap.CommonFor}:
 ${product.internalName} [${uiLabelMap.CommonId}:${productId}]
  ${${extraFunctionName}}/label
 -image
 src=${product.smallImageUrl} height=40 width=40 url-mode=content
 alt=${product.internalName}/
 -/container
 -
 -!-- add Create Product and
 View
 Product (in ecommerce) links --
 -container style=button-bar
 -link target=EditProduct
 text=${uiLabelMap.ProductNewProduct} style=buttontext
 create/
 -link
 target=CreateVirtualWithVariantsForm
 text=${uiLabelMap.ProductNewVirtualProduct} style=buttontext
 create/
 -link
 target=/ecommerce/control/product url-mode=inter-app
 text=${uiLabelMap.ProductProductPage} style=buttontext
 -

Could we remove button-style-1 and button-style-2 ?

Hi,
again on this topic.

I have seen that in the new Flat grey theme the button-style-1 and
button-style-2 are rendered in the same way.
I agree on this and was going to do the same on the Tomahawk theme.
While doing this I asked myself if it does make sense to keep those two
styles.

They seems to be intended to be used to differentiate between intra-app and
inter-app links.
But why an user should be aware of the matter that a link is an intra-app or
inter-app ?
Shouldn't it be completely transparent to him?

I think that keeping these styles is only confusing and I would like to
remove it.
Moreover we should go toward style names that describe element functions and
not their apparence.
For example the create, delete, search, refresh button styles have
not been defined as button-with-plus, button-with-cross,
button-with-maglens etc.

The new Demo page layout is a great tool to test themes.
It could also work as a style dictionary having all allowed styles present
on the page and specifiyng that only styles present in this page should be
used in the rest of the code.

Does anybody see any issue if we get rid of the button-style-1 and
button-style-2 styles?

Thank you,
Bruno

[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created

2011-01-29 Thread Bruno Busco (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988464#action_12988464
 ] 

Bruno Busco commented on OFBIZ-4127:


Hi,
I have posted something in the DEV ML and later I have seen this JIRA.
Well, could we definitively remove these two button-styles?
There is no reason IMO to let the user know that a button links to intra-app or 
inter-app.
The only reason the user should know about it is if it is not allowed to access 
a different applicationbut, in this case, a disabled button should be used (or 
no button at all).

In any case if we would keep these styles they should better be named 
intra-app-button and inter-app-button.
This means use functional names for styles.

 Styles for the button-bar buttons are not created
 -

 Key: OFBIZ-4127
 URL: https://issues.apache.org/jira/browse/OFBIZ-4127
 Project: OFBiz
  Issue Type: Bug
  Components: themes
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Assignee: Adrian Crum
Priority: Minor
 Fix For: SVN trunk

 Attachments: disabledBtn.patch, fg_button-bar.png


 The buttons in button-bar have no style definition. You can see it through 
 the screenshot, or going to the layout demo page (nice idea, BTW!).
 Cheers,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml


Bruno,

At first glance, it might seem logical to have text describing each of 
the styles or elements being displayed, but it really isn't necessary - 
since the styles/elements can be seen when viewing the markup.


-Adrian

On 1/29/2011 6:22 AM, bus...@apache.org wrote:

Author: buscob
Date: Sat Jan 29 14:22:28 2011
New Revision: 1065018

URL: http://svn.apache.org/viewvc?rev=1065018view=rev
Log:
Added other button styles in the Layout demo.
Added Italian localization.

Modified:
 ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018r1=1065017r2=1065018view=diff
==
--- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml (original)
+++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan 29 
14:22:28 2011
@@ -2444,9 +2444,11 @@
  /property
  property key=WebtoolsLayoutDemo
  value xml:lang=enLayout Demo/value
+value xml:lang=itDimostrazione Layout/value
  /property
  property key=WebtoolsLayoutDemoText
  value xml:lang=enDemonstrate layout best practices and provide a visual 
theme test page./value
+value xml:lang=itDimostrazione di come utilizzare gli stili e pagina per il test 
dei temi visuali./value
  /property
  property key=WebtoolsLeaveAllEntriesBlank
  value xml:lang=dealle EintrÃ¤ge leer lassen/value

Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018r1=1065017r2=1065018view=diff
==
--- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
+++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29 14:22:28 
2011
@@ -111,6 +111,9 @@ under the License.
  container style=button-bar 
button-style-1
  !-- Typically used for intra-app 
links --
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonNew} style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete} 
style=delete/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh} 
style=refresh/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch} 
style=search/
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonSelected} style=selected/
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonEnabled}/
  link text=${uiLabelMap.CommonDisabled} 
style=disabled/
@@ -118,6 +121,9 @@ under the License.
  container style=button-bar 
button-style-2
  !-- Typically used for inter-app 
links --
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonNew} style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete} 
style=delete/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh} 
style=refresh/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch} 
style=search/
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonSelected} style=selected/
  link target=${demoTargetUrl} 
text=${uiLabelMap.CommonEnabled}/
  link text=${uiLabelMap.CommonDisabled} 
style=disabled/
@@ -127,12 +133,12 @@ under the License.
  section name=h1-h6 Styles
  widgets
  horizontal-separator/
-label style=h1 text=${demoText}/
-label style=h2 text=${demoText}/
-label style=h3 text=${demoText}/
-label style=h4 text=${demoText}/
-label style=h5 text=${demoText}/
-label style=h6 text=${demoText}/
+label style=h1 text=${demoText} (h1)/
+label style=h2 text=${demoText} (h2)/
+label style=h3 text=${demoText} (h3)/
+label style=h4 text=${demoText} (h4)/
+label style=h5 text=${demoText} (h5)/
+label style=h6 text=${demoText} (h6)/
  /widgets
  /section
  section name=Form/List Styles

[jira] Commented: (OFBIZ-3971) enhancement to create new tenants easier

2011-01-29 Thread BJ Freeman (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988497#action_12988497
]

BJ Freeman commented on OFBIZ-3971:
---

please use the jira for comments it is easier to keep track.
I a not sure I can afford time before end of feb.
have a lot on my plate.
I am on a simular track
http://mail-archives.apache.org/mod_mbox/ofbiz-dev/201008.mbox/ajax/%3c4c76f7b4.4090...@free-man.net%3E

enhancement to create new tenants easier

Key: OFBIZ-3971
URL: https://issues.apache.org/jira/browse/OFBIZ-3971
Project: OFBiz
Issue Type: Improvement
Components: commonext/setup, framework
Affects Versions: SVN trunk
Environment: All
Reporter: Pierre Smits
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: OFBIZ-3971-multitenant-improvement-20110121.patch

This modification enables backend admins to easier create new tenants.
It first enters data about the tenant (tenantID and tenantName) in entity
Tenant and TenantDataSource.
Subsequently it creates the databases (derby only) for the new delegator. The
backend-admin can state which datafiles must be loaded in the newly created
databases (seed, seed-initial, ext, etc...)
Finally it creates the tenant-admin and its password in the newly created
database. The name of tenant-admin is based on the tenantId given (i.e.
tenantId-admin). The password of the tenant-admin must be changed on first
login.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-4157) Incorrect CSS path for elRTE editor

2011-01-29 Thread Rene Scheibe (JIRA)

Incorrect CSS path for elRTE editor
---

 Key: OFBIZ-4157
 URL: https://issues.apache.org/jira/browse/OFBIZ-4157
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Rene Scheibe
Priority: Minor


The path to elrte-inner.css is incorrect when starting the editor.

The result is that in the WYSIWYG view eg. div and tables are not surrounded 
with a small blue border.
The problem is also visible in the logs: Unknown request [css]; this request 
does not exist or cannot be called directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: jackrabbit branch


Something more things to think about...

I believe Scott started exploring this option after coming to the 
conclusion that the current OFBiz Content component is a mess (Scott- 
correct me if I'm wrong). So, it might help to research previous mailing 
list discussions about the Content component or CMS in general.


There have been some good CMS ideas discussed in the past - I remember 
Ean and Adam at Brainfood supporting the idea that OFBiz could serve up 
content from a repository that is built on a version control system (SVN 
at the time, but I'm sure they would prefer Git now) . A setup like that 
would allow you to have a running OFBiz instance that is serving content 
from revision (or branch) X, and with a simple setting change, that 
instance would start serving content from revision (or branch) Y. The 
webslinger component might tie into that somehow - but I'm not sure what 
webslinger does.


Another thing that was discussed is whether or not we should even have 
our own CMS component. I suggested that OFBiz could have adapters to 
connect it to third-party CMS implementations - so a developer could 
connect OFBiz to any CMS they prefer.


The Jackrabbit integration might facilitate some of those ideas.

-Adrian

On 1/29/2011 12:09 AM, Sascha Rodekamp wrote:

That's good to hear. I will check in the next we. And create a wiki page for it.

Am 28.01.2011 um 21:19 schrieb Scott Grayscott.g...@hotwaxmedia.com:


I do intend to return to the branch at some point, I just don't know when.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 29/01/2011, at 6:20 AM, adrian.c...@sandglass-software.com wrote:


As far as I know, everything was discussed on the dev mailing list - just search for 
jackrabbit in the subject line.

To summarize: Scott created the branch to try out some ideas, and I made a few 
changes so that OFBiz could connect to external repositories.

My involvement had a very narrow focus: I wanted to see OFBiz used in a large 
enterprise where it can serve up content from various repositories scattered 
around the organization.

-Adrian


Quoting Sascha Rodekampsascha.rodekamp.lynx...@googlemail.com:


Good idea. maybe Adrian can summarize the changes in a few words:

https://fisheye6.atlassian.com/changelog/ofbiz/branches/jackrabbit20100709

Cheers

2011/1/28 Erwan de FERRIERESerwan.de-ferrie...@nereide.fr


Le 28/01/2011 08:47, Sascha Rodekamp a écrit :


Hi Erwan,
i thing the basic work to let JR running is done.
To be honest i didn't found time to catch up.

But i really would be interested in reanimating the branch ;)

2011/1/27 Erwan de FERRIERESerwan.de-ferrie...@nereide.fr

Hi all,

some time ago, the jackrabbit branch was created. There has not be many
commits in it, and from this thread, it was looking very promising.
https://svn.apache.org/repos/asf/ofbiz/branches/jackrabbit20100709/

Is the project dead ? Or what is missing to make it work ?

TIA,

--
Erwan de FERRIERES
www.nereide.biz




maybe we could start with a wiki page, with what is done, what is

expected, and what to do. This will guide us in the developemnts.

--
Erwan de FERRIERES
www.nereide.biz




--
Sascha Rodekamp
   Lynx-Consulting GmbH
   Johanniskirchplatz 6
   D-33615 Bielefeld
   http://www.lynx.de

[jira] Updated: (OFBIZ-4157) Incorrect CSS path for elRTE editor

2011-01-29 Thread Rene Scheibe (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rene Scheibe updated OFBIZ-4157:


Attachment: OFBIZ-4157-correct_css_path.patch

this is sets the correct CSS path

 Incorrect CSS path for elRTE editor
 ---

 Key: OFBIZ-4157
 URL: https://issues.apache.org/jira/browse/OFBIZ-4157
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Rene Scheibe
Priority: Minor
 Attachments: OFBIZ-4157-correct_css_path.patch


 The path to elrte-inner.css is incorrect when starting the editor.
 The result is that in the WYSIWYG view eg. div and tables are not surrounded 
 with a small blue border.
 The problem is also visible in the logs: Unknown request [css]; this request 
 does not exist or cannot be called directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3971) enhancement to create new tenants easier

2011-01-29 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988504#action_12988504
 ] 

BJ Freeman commented on OFBIZ-3971:
---

also check if this does not happen
https://issues.apache.org/jira/browse/OFBIZ-3908

 enhancement to create new tenants easier
 

 Key: OFBIZ-3971
 URL: https://issues.apache.org/jira/browse/OFBIZ-3971
 Project: OFBiz
  Issue Type: Improvement
  Components: commonext/setup, framework
Affects Versions: SVN trunk
 Environment: All
Reporter: Pierre Smits
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: OFBIZ-3971-multitenant-improvement-20110121.patch


 This modification enables backend admins to easier create new tenants. 
 It first enters data about the tenant (tenantID and tenantName) in entity 
 Tenant and TenantDataSource.
 Subsequently it creates the databases (derby only) for the new delegator. The 
 backend-admin can state which datafiles must be loaded in the newly created 
 databases (seed, seed-initial, ext, etc...)
 Finally it creates the tenant-admin and its password in the newly created 
 database. The name of tenant-admin is based on the tenantId given (i.e. 
 tenantId-admin). The password of the tenant-admin must be changed on first 
 login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

Adrian,
I thougth this was usefull above all when different styles are rendered in
the same way (i.e. h4, h5, h6).

In this case, having different texts, helps understanding very easily even
if not looking at the markup.

-Bruno
2011/1/29 Adrian Crum adrian.c...@sandglass-software.com

 Bruno,

 At first glance, it might seem logical to have text describing each of the
 styles or elements being displayed, but it really isn't necessary - since
 the styles/elements can be seen when viewing the markup.

 -Adrian


 On 1/29/2011 6:22 AM, bus...@apache.org wrote:

 Author: buscob
 Date: Sat Jan 29 14:22:28 2011
 New Revision: 1065018

 URL: http://svn.apache.org/viewvc?rev=1065018view=rev
 Log:
 Added other button styles in the Layout demo.
 Added Italian localization.

 Modified:
 ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

 Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018r1=1065017r2=1065018view=diff

 ==
 --- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml (original)
 +++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan 29
 14:22:28 2011
 @@ -2444,9 +2444,11 @@
  /property
  property key=WebtoolsLayoutDemo
  value xml:lang=enLayout Demo/value
 +value xml:lang=itDimostrazione Layout/value
  /property
  property key=WebtoolsLayoutDemoText
  value xml:lang=enDemonstrate layout best practices and
 provide a visual theme test page./value
 +value xml:lang=itDimostrazione di come utilizzare gli stili e pagina
 per il test dei temi visuali./value
  /property
  property key=WebtoolsLeaveAllEntriesBlank
  value xml:lang=dealle EintrÃ¤ge leer lassen/value

 Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018r1=1065017r2=1065018view=diff

 ==
 --- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
 +++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29
 14:22:28 2011
 @@ -111,6 +111,9 @@ under the License.
  container style=button-bar
 button-style-1
  !-- Typically used for
 intra-app links --
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonNew} style=create/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
 style=delete/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
 style=refresh/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
 style=search/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
 style=selected/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
 text=${uiLabelMap.CommonDisabled} style=disabled/
 @@ -118,6 +121,9 @@ under the License.
  container style=button-bar
 button-style-2
  !-- Typically used for
 inter-app links --
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonNew} style=create/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
 style=delete/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
 style=refresh/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
 style=search/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
 style=selected/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
 text=${uiLabelMap.CommonDisabled} style=disabled/
 @@ -127,12 +133,12 @@ under the License.
  section name=h1-h6 Styles
  widgets
  horizontal-separator/
 -label style=h1 text=${demoText}/
 -label style=h2 text=${demoText}/
 -label style=h3 text=${demoText}/
 -label style=h4 text=${demoText}/
 -label style=h5 text=${demoText}/
 -label style=h6 text=${demoText}/
 +label style=h1 text=${demoText} (h1)/
 +label style=h2 text=${demoText} (h2)/
 +label style=h3 text=${demoText} (h3)/
 +label style=h4 text=${demoText} (h4)/
 +label style=h5 text=${demoText} (h5)/
 +label style=h6 text=${demoText} (h6)/
  /widgets
  /section
  section name=Form/List Styles

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

Using the same logic, the page title should say Layout Demo 
(page-title) because it is rendered in the same way as h1.


The whole point of the screen is to look at the markup - to understand 
how a screen's markup is composed and how various styles are applied. In 
other words, if you want to use the Layout Demo screen as a tool, then 
looking at the markup is required - not optional.


-Adrian

On 1/29/2011 12:53 PM, Bruno Busco wrote:

Adrian,
I thougth this was usefull above all when different styles are rendered in
the same way (i.e. h4, h5, h6).

In this case, having different texts, helps understanding very easily even
if not looking at the markup.

-Bruno
2011/1/29 Adrian Crumadrian.c...@sandglass-software.com


Bruno,

At first glance, it might seem logical to have text describing each of the
styles or elements being displayed, but it really isn't necessary - since
the styles/elements can be seen when viewing the markup.

-Adrian


On 1/29/2011 6:22 AM, bus...@apache.org wrote:


Author: buscob
Date: Sat Jan 29 14:22:28 2011
New Revision: 1065018

URL: http://svn.apache.org/viewvc?rev=1065018view=rev
Log:
Added other button styles in the Layout demo.
Added Italian localization.

Modified:
 ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018r1=1065017r2=1065018view=diff

==
--- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml (original)
+++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan 29
14:22:28 2011
@@ -2444,9 +2444,11 @@
  /property
  property key=WebtoolsLayoutDemo
  value xml:lang=enLayout Demo/value
+value xml:lang=itDimostrazione Layout/value
  /property
  property key=WebtoolsLayoutDemoText
  value xml:lang=enDemonstrate layout best practices and
provide a visual theme test page./value
+value xml:lang=itDimostrazione di come utilizzare gli stili e pagina
per il test dei temi visuali./value
  /property
  property key=WebtoolsLeaveAllEntriesBlank
  value xml:lang=dealle EintrÃ¤ge leer lassen/value

Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018r1=1065017r2=1065018view=diff

==
--- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
+++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29
14:22:28 2011
@@ -111,6 +111,9 @@ under the License.
  container style=button-bar
button-style-1
  !-- Typically used for
intra-app links --
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonNew} style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
style=delete/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
style=refresh/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
style=search/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
style=selected/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
text=${uiLabelMap.CommonDisabled} style=disabled/
@@ -118,6 +121,9 @@ under the License.
  container style=button-bar
button-style-2
  !-- Typically used for
inter-app links --
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonNew} style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
style=delete/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
style=refresh/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
style=search/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
style=selected/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
text=${uiLabelMap.CommonDisabled} style=disabled/
@@ -127,12 +133,12 @@ under the License.
  section name=h1-h6 Styles
  widgets
  horizontal-separator/
-label style=h1 text=${demoText}/
-label style=h2 text=${demoText}/
-label style=h3 text=${demoText}/
-label style=h4 text=${demoText}/
-label style=h5 text=${demoText}/
-label style=h6 text=${demoText}/
+label style=h1

Re: Could we remove button-style-1 and button-style-2 ?

Adrian,
I am sorry to put again this on the table. I know we have already discussed
about but I think that you are trying to better explain over and over a
wrong concept.
You can see how it is wrong when you say In the original visual theme, the
tab-bar decorator was used for the sub-menu at the top of the main content
area, button-style-1 was used for intra-app links, and button-style-2 was
used for inter-app links.

It cannot be a visual theme to use a decorator for a sub-menu,
button-style-1 for intra-app links etc. It is the application itself. So why
the application should decide which style should be used for a sub-menu? It
should only identify the sub-menu as a sub-menu and then the visual theme
should decide to decorate the sub-menu with a specific visual aspect.

If the application developer A is free to use button-style-1 for intra-app
links and button-style-2 for inter-app links then application developer B
would be free to use button-style-1, let me say, for backoffice links and
button-style-2 for ecommerce web site links.

Then how could a visual theme designer create a graphics that somehow helps
the user to distinguish between links?
He could not do anything, he will understand that if the two decoration
classes have not the same CSS the links will appear different without a
clear reason and so we will have that the two classes will be, in a proper
designed theme, with the same CSS.

We are moving now towards having more visual themes hosted separately from
the main trunk. If we do not clear away those ambiguity we will never have a
solid base in the main trunk to let external visual themes to rely on.

So my suggestion is to change all style names that do not describe element
functionality but visual aspect.
Of course I get your suggestion to spend some time removing box* styles but
they should not be the only one to leave.

-Bruno


2011/1/29 Adrian Crum adrian.c...@sandglass-software.com

 I'm sure we discussed this just a few weeks ago, but I will go over it
 again...

 The  button-style-1 and button-style-2 CSS classes are button-bar class
 decorators. The button-bar class has other decorators too - tab-bar and
 tool-bar. Altogether, there are four button-bar decorators. The button-bar
 decorators were not intended to be used alone to style links, but they have
 been used that way recently and I have been fixing those instances as I come
 across them.

 Setting up the CSS classes this way gives the graphic artist some
 flexibility in styling the buttons. Attributes that all button bars have in
 common (spacing, positioning, orientation) can be applied to the button-bar
 class, and then the various decorators can have attributes that make them
 unique.

 It is up to the application developer to decide what the various button-bar
 decorators represent. The decorators have no inherent purpose - they simply
 provide the developer with some choices. In the original visual theme, the
 tab-bar decorator was used for the sub-menu at the top of the main content
 area, button-style-1 was used for intra-app links, and button-style-2 was
 used for inter-app links.

 I see no reason to remove any of the button-bar decorators. The decorators
 give the developer and graphic artist a palette of choices. That same
 concept gives us a choice of table header styles, table grid styles, etc.

 If there is an interest in removing unnecessary styles, then (in my
 opinion) that effort should be invested in removing the deprecated CSS
 styles. You can find them listed at the bottom of the Flat Grey maincss.css
 file. Removing the box* styles would be a good place to start.

 -Adrian


 On 1/29/2011 6:46 AM, Bruno Busco wrote:

 Hi,
 again on this topic.

 I have seen that in the new Flat grey theme the button-style-1 and
 button-style-2 are rendered in the same way.
 I agree on this and was going to do the same on the Tomahawk theme.
 While doing this I asked myself if it does make sense to keep those two
 styles.

 They seems to be intended to be used to differentiate between intra-app
 and
 inter-app links.
 But why an user should be aware of the matter that a link is an intra-app
 or
 inter-app ?
 Shouldn't it be completely transparent to him?

 I think that keeping these styles is only confusing and I would like to
 remove it.
 Moreover we should go toward style names that describe element functions
 and
 not their apparence.
 For example the create, delete, search, refresh button styles have
 not been defined as button-with-plus, button-with-cross,
 button-with-maglens etc.

 The new Demo page layout is a great tool to test themes.
 It could also work as a style dictionary having all allowed styles
 present
 on the page and specifiyng that only styles present in this page should be
 used in the rest of the code.

 Does anybody see any issue if we get rid of the button-style-1 and
 button-style-2 styles?

 Thank you,
 Bruno

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

Yes, you are right, the page title should be changed as well.
I did not change it yet because I was using the Tomahawk theme and, in this
theme, the page title is not visible because it is already present in the
breadcrumb.

The logic should be this:
- for all styles that are rendered as simple strings on the page, the style
should be added to the displyed text.
- for styles that are part of a table, a menu, a screenlet, a form header,
that is something whose function is clearly understandable from the page it
is not necessary to add the style to the displayed string.

-Bruno

2011/1/29 Adrian Crum adrian.c...@sandglass-software.com

 Using the same logic, the page title should say Layout Demo (page-title)
 because it is rendered in the same way as h1.

 The whole point of the screen is to look at the markup - to understand how
 a screen's markup is composed and how various styles are applied. In other
 words, if you want to use the Layout Demo screen as a tool, then looking at
 the markup is required - not optional.

 -Adrian


 On 1/29/2011 12:53 PM, Bruno Busco wrote:

 Adrian,
 I thougth this was usefull above all when different styles are rendered in
 the same way (i.e. h4, h5, h6).

 In this case, having different texts, helps understanding very easily even
 if not looking at the markup.

 -Bruno
 2011/1/29 Adrian Crumadrian.c...@sandglass-software.com

  Bruno,

 At first glance, it might seem logical to have text describing each of
 the
 styles or elements being displayed, but it really isn't necessary - since
 the styles/elements can be seen when viewing the markup.

 -Adrian


 On 1/29/2011 6:22 AM, bus...@apache.org wrote:

  Author: buscob
 Date: Sat Jan 29 14:22:28 2011
 New Revision: 1065018

 URL: http://svn.apache.org/viewvc?rev=1065018view=rev
 Log:
 Added other button styles in the Layout demo.
 Added Italian localization.

 Modified:
 ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

 Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 URL:

 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018r1=1065017r2=1065018view=diff


 ==
 --- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 (original)
 +++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan
 29
 14:22:28 2011
 @@ -2444,9 +2444,11 @@
  /property
  property key=WebtoolsLayoutDemo
  value xml:lang=enLayout Demo/value
 +value xml:lang=itDimostrazione Layout/value
  /property
  property key=WebtoolsLayoutDemoText
  value xml:lang=enDemonstrate layout best practices and
 provide a visual theme test page./value
 +value xml:lang=itDimostrazione di come utilizzare gli stili e
 pagina
 per il test dei temi visuali./value
  /property
  property key=WebtoolsLeaveAllEntriesBlank
  value xml:lang=dealle Einträge leer lassen/value


 Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
 URL:

 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018r1=1065017r2=1065018view=diff


 ==
 --- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
 +++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29
 14:22:28 2011
 @@ -111,6 +111,9 @@ under the License.
  container style=button-bar
 button-style-1
  !-- Typically used for
 intra-app links --
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonNew}
 style=create/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
 style=delete/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
 style=refresh/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
 style=search/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
 style=selected/
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
 text=${uiLabelMap.CommonDisabled} style=disabled/
 @@ -118,6 +121,9 @@ under the License.
  container style=button-bar
 button-style-2
  !-- Typically used for
 inter-app links --
  link
 target=${demoTargetUrl} text=${uiLabelMap.CommonNew}
 style=create/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
 style=delete/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
 style=refresh/
 +link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
 style=search/
  link

[jira] Closed: (OFBIZ-3971) enhancement to create new tenants easier


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3971.
--

Resolution: Fixed

Thanks Pierre,

Your (slightly modified) patch is in trunk at r1065144  

I have noticed that most of the time I had to enter twice (or IIRW also hit 
enter and then y or Y) at this stage

load-tenant-admin-user-login:
 [echo] 
 [echo] Installing the admin for the tenant
 [echo] Delegator = default#tenant1
 [echo] Tenant admin = 'tenant1-admin'
 [echo] Password for tenant admin is 'ofbiz' must change on first login
 [echo] 
[input] Continue Y or N (N, n, Y, y)

Not sure why (I did not try to fix)

I tested with an IP:port string, of course no pb (locally I use diff port # for 
diff versions of Postgres)

In the target comments I have added (in bold):
input addproperty=db-IP message=Enter IP address of the database server 
*(you may add a port number)*/
in get-tenant-data
echo message=Please make sure that the driver of the platform is installed 
and that the databases have been created *(in function of the entityengine.xml 
datasource-names)*/
echo message=Please make sure that the driver of the platform is installed 
and that the databases have been created *(Check names just above)*/
And when not Derby 
description=Creates tenant data and instance. *Don't forget db driver(s) and 
already created DBs in function of the entityengine.xml datasource-names* 
Also
description=This build script creates a new tenant in your environment, 
creates the delegator, and loads initial data *(needs multitenant=Y in 
general.properties)*

Please re-check on your side...

 enhancement to create new tenants easier
 

 Key: OFBIZ-3971
 URL: https://issues.apache.org/jira/browse/OFBIZ-3971
 Project: OFBiz
  Issue Type: Improvement
  Components: commonext/setup, framework
Affects Versions: SVN trunk
 Environment: All
Reporter: Pierre Smits
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: OFBIZ-3971-multitenant-improvement-20110121.patch


 This modification enables backend admins to easier create new tenants. 
 It first enters data about the tenant (tenantID and tenantName) in entity 
 Tenant and TenantDataSource.
 Subsequently it creates the databases (derby only) for the new delegator. The 
 backend-admin can state which datafiles must be loaded in the newly created 
 databases (seed, seed-initial, ext, etc...)
 Finally it creates the tenant-admin and its password in the newly created 
 database. The name of tenant-admin is based on the tenantId given (i.e. 
 tenantId-admin). The password of the tenant-admin must be changed on first 
 login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (OFBIZ-4157) Incorrect CSS path for elRTE editor


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4157.
--

   Resolution: Fixed
Fix Version/s: SVN trunk
 Assignee: Jacques Le Roux

Thanks René,

Your patch is in trunk at r1065147  


 Incorrect CSS path for elRTE editor
 ---

 Key: OFBIZ-4157
 URL: https://issues.apache.org/jira/browse/OFBIZ-4157
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Rene Scheibe
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4157-correct_css_path.patch


 The path to elrte-inner.css is incorrect when starting the editor.
 The result is that in the WYSIWYG view eg. div and tables are not surrounded 
 with a small blue border.
 The problem is also visible in the logs: Unknown request [css]; this request 
 does not exist or cannot be called directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

No, the page title should NOT be changed. You're missing the point. The 
extra text is redundant and unnecessary. Please do NOT clutter up a 
simple tool with a lot of unnecessary text.


-Adrian

On 1/29/2011 2:42 PM, Bruno Busco wrote:

Yes, you are right, the page title should be changed as well.
I did not change it yet because I was using the Tomahawk theme and, in this
theme, the page title is not visible because it is already present in the
breadcrumb.

The logic should be this:
- for all styles that are rendered as simple strings on the page, the style
should be added to the displyed text.
- for styles that are part of a table, a menu, a screenlet, a form header,
that is something whose function is clearly understandable from the page it
is not necessary to add the style to the displayed string.

-Bruno

2011/1/29 Adrian Crumadrian.c...@sandglass-software.com


Using the same logic, the page title should say Layout Demo (page-title)
because it is rendered in the same way ash1.

The whole point of the screen is to look at the markup - to understand how
a screen's markup is composed and how various styles are applied. In other
words, if you want to use the Layout Demo screen as a tool, then looking at
the markup is required - not optional.

-Adrian


On 1/29/2011 12:53 PM, Bruno Busco wrote:


Adrian,
I thougth this was usefull above all when different styles are rendered in
the same way (i.e. h4, h5, h6).

In this case, having different texts, helps understanding very easily even
if not looking at the markup.

-Bruno
2011/1/29 Adrian Crumadrian.c...@sandglass-software.com

  Bruno,

At first glance, it might seem logical to have text describing each of
the
styles or elements being displayed, but it really isn't necessary - since
the styles/elements can be seen when viewing the markup.

-Adrian


On 1/29/2011 6:22 AM, bus...@apache.org wrote:

  Author: buscob

Date: Sat Jan 29 14:22:28 2011
New Revision: 1065018

URL: http://svn.apache.org/viewvc?rev=1065018view=rev
Log:
Added other button styles in the Layout demo.
Added Italian localization.

Modified:
 ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
 ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018r1=1065017r2=1065018view=diff


==
--- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
(original)
+++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan
29
14:22:28 2011
@@ -2444,9 +2444,11 @@
  /property
  property key=WebtoolsLayoutDemo
  value xml:lang=enLayout Demo/value
+value xml:lang=itDimostrazione Layout/value
  /property
  property key=WebtoolsLayoutDemoText
  value xml:lang=enDemonstrate layout best practices and
provide a visual theme test page./value
+value xml:lang=itDimostrazione di come utilizzare gli stili e
pagina
per il test dei temi visuali./value
  /property
  property key=WebtoolsLeaveAllEntriesBlank
  value xml:lang=dealle Einträge leer lassen/value


Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018r1=1065017r2=1065018view=diff


==
--- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
+++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29
14:22:28 2011
@@ -111,6 +111,9 @@ under the License.
  container style=button-bar
button-style-1
  !-- Typically used for
intra-app links --
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonNew}
style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
style=delete/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonRefresh}
style=refresh/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonSearch}
style=search/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonSelected}
style=selected/
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonEnabled}/
  link
text=${uiLabelMap.CommonDisabled} style=disabled/
@@ -118,6 +121,9 @@ under the License.
  container style=button-bar
button-style-2
  !-- Typically used for
inter-app links --
  link
target=${demoTargetUrl} text=${uiLabelMap.CommonNew}
style=create/
+link target=${demoTargetUrl} text=${uiLabelMap.CommonDelete}
style=delete/
+link target=${demoTargetUrl}

Re: Could we remove button-style-1 and button-style-2 ?

The application developer designs the application, not the graphic 
artist. The graphic artist styles the application, he doesn't design it.


For example, I am a developer designing a screen. The screen requires 
two sets of links. The links in set A all share something in common, and 
the links in set B all share something in common, but sets A and B have 
nothing in common. How do I indicate that to the user? I will use 
different styles for the two sets of links.


What you're saying is that I am not allowed to make that decision - that 
is the theme designer's decision. I don't agree with that view. The 
theme designer is free to style set A and set B any way they want, but 
it is not their job to determine if set A or set B exist in the application.


As an application developer, I want the option to use different styles 
to provide different visual cues to the user.


I agree that some of the styles have been named poorly. We should rename 
them if that is the case, but we shouldn't get rid of them.


-Adrian

On 1/29/2011 2:35 PM, Bruno Busco wrote:

Adrian,
I am sorry to put again this on the table. I know we have already discussed
about but I think that you are trying to better explain over and over a
wrong concept.
You can see how it is wrong when you say In the original visual theme, the
tab-bar decorator was used for the sub-menu at the top of the main content
area, button-style-1 was used for intra-app links, and button-style-2 was
used for inter-app links.

It cannot be a visual theme to use a decorator for a sub-menu,
button-style-1 for intra-app links etc. It is the application itself. So why
the application should decide which style should be used for a sub-menu? It
should only identify the sub-menu as a sub-menu and then the visual theme
should decide to decorate the sub-menu with a specific visual aspect.

If the application developer A is free to use button-style-1 for intra-app
links and button-style-2 for inter-app links then application developer B
would be free to use button-style-1, let me say, for backoffice links and
button-style-2 for ecommerce web site links.

Then how could a visual theme designer create a graphics that somehow helps
the user to distinguish between links?
He could not do anything, he will understand that if the two decoration
classes have not the same CSS the links will appear different without a
clear reason and so we will have that the two classes will be, in a proper
designed theme, with the same CSS.

We are moving now towards having more visual themes hosted separately from
the main trunk. If we do not clear away those ambiguity we will never have a
solid base in the main trunk to let external visual themes to rely on.

So my suggestion is to change all style names that do not describe element
functionality but visual aspect.
Of course I get your suggestion to spend some time removing box* styles but
they should not be the only one to leave.

-Bruno


2011/1/29 Adrian Crumadrian.c...@sandglass-software.com


I'm sure we discussed this just a few weeks ago, but I will go over it
again...

The  button-style-1 and button-style-2 CSS classes are button-bar class
decorators. The button-bar class has other decorators too - tab-bar and
tool-bar. Altogether, there are four button-bar decorators. The button-bar
decorators were not intended to be used alone to style links, but they have
been used that way recently and I have been fixing those instances as I come
across them.

Setting up the CSS classes this way gives the graphic artist some
flexibility in styling the buttons. Attributes that all button bars have in
common (spacing, positioning, orientation) can be applied to the button-bar
class, and then the various decorators can have attributes that make them
unique.

It is up to the application developer to decide what the various button-bar
decorators represent. The decorators have no inherent purpose - they simply
provide the developer with some choices. In the original visual theme, the
tab-bar decorator was used for the sub-menu at the top of the main content
area, button-style-1 was used for intra-app links, and button-style-2 was
used for inter-app links.

I see no reason to remove any of the button-bar decorators. The decorators
give the developer and graphic artist a palette of choices. That same
concept gives us a choice of table header styles, table grid styles, etc.

If there is an interest in removing unnecessary styles, then (in my
opinion) that effort should be invested in removing the deprecated CSS
styles. You can find them listed at the bottom of the Flat Grey maincss.css
file. Removing the box* styles would be a good place to start.

-Adrian


On 1/29/2011 6:46 AM, Bruno Busco wrote:


Hi,
again on this topic.

I have seen that in the new Flat grey theme the button-style-1 and
button-style-2 are rendered in the same way.
I agree on this and was going to do the same on the Tomahawk theme.
While doing this I asked myself if it does make sense

Re: Could we remove button-style-1 and button-style-2 ?