[jira] [Assigned] (OFBIZ-4722) completePack service times out for large orders
[ https://issues.apache.org/jira/browse/OFBIZ-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-4722: -- Assignee: Ashish Vijaywargiya completePack service times out for large orders --- Key: OFBIZ-4722 URL: https://issues.apache.org/jira/browse/OFBIZ-4722 Project: OFBiz Issue Type: Bug Components: product Reporter: Atul Vani Assignee: Ashish Vijaywargiya Attachments: OFBIZ-4722.patch The completePack service times out for large orders. Though the code should be looked for possible optimizations, but increasing timeout value is also required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Service alert: ofbiz-vm.apache.org/HTTP - Ofbiz Demo Trunk is WARNING
Hi, I just restarted trunk demo. I found demo-old.ofbiz.apache.org in the trunk log 340076 [http-bio-0.0.0.0-8080-exec-1] INFO org.ofbiz.webapp.control.ControlServlet - [[[tellafriend(Domain:http://demo-old.ofbiz.apache.org)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 378846 [http-bio-0.0.0.0-8443-exec-4] INFO org.ofbiz.webapp.control.ControlServlet - [[[checkLogin(Domain:https://demo-old.ofbiz.apache.org)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] And the trunk demo has been (it seems) normally stopped Not sure why... Jacques nag...@monitoring.apache.org wrote: *** ASF Nagios *** Notification Type: PROBLEM Host: ofbiz-vm.apache.org Address: 140.211.11.41 Service: HTTP - Ofbiz Demo Trunk State: WARNING Info: HTTP WARNING: - HTTP/1.1 200 OK - 10.912 second response time Date/Time: Sat Mar 3 10:33:18 UTC 2012
[jira] [Closed] (OFBIZ-4599) Product NOTFOUND causes java.lang.NullPointerException, ugly screen, and excessive logging
[ https://issues.apache.org/jira/browse/OFBIZ-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4599. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Assignee: Jacques Le Roux Thanks Mike, Indeed Michael, it was pretty obvious as soon as I looked at the code :) Mike your patch is in trunk r1296597 R11.04 r1296599 Product NOTFOUND causes java.lang.NullPointerException, ugly screen, and excessive logging -- Key: OFBIZ-4599 URL: https://issues.apache.org/jira/browse/OFBIZ-4599 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04, SVN trunk Environment: Any Reporter: mz4wheeler Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 11.04, SVN trunk Attachments: OFBIZ-4599.patch If you manually enter a URL (or via search engine) for a non-existing product, the following (annoying) long java exception is logged. 2011-11-30 20:56:35,431 (TP-Processor3) [ModelScreen.java:401:ERROR] Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#product]: java.lang.NullPointerException: Cannot get property 'isVirtual' on null object. Rolling back transaction. 2011-11-30 20:56:35,436 (TP-Processor3) [TransactionUtil.java:349:INFO ] [TransactionUtil.rollback] transaction rolled back 2011-11-30 20:56:35,437 (TP-Processor3) [TransactionUtil.java:274:WARN ] [TransactionUtil.commit] Not committing transaction, status is No Transaction (6) 2011-11-30 20:56:35,446 (TP-Processor3) [ ControlServlet.java:227:ERROR] exception report -- Error in request handler: Exception: org.ofbiz.widget.screen.ScreenRenderException Message: Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#product]: java.lang.NullPointerException: Cannot get property 'isVirtual' on null object (Cannot get property 'isVirtual' on null object) cause - Exception: java.lang.NullPointerException Message: Cannot get property 'isVirtual' on null object stack trace --- java.lang.NullPointerException: Cannot get property 'isVirtual' on null object org.codehaus.groovy.runtime.NullObject.getProperty(NullObject.java:56) org.codehaus.groovy.runtime.InvokerHelper.getProperty(InvokerHelper.java:156) org.codehaus.groovy.runtime.callsite.NullCallSite.getProperty(NullCallSite.java:44) org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGetProperty(AbstractCallSite.java:235) Product.run(Product.groovy:48) etc ... etc ... etc ... org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690) java.lang.Thread.run(Thread.java:662) 2011-11-30 20:56:35,449 (TP-Processor3) [ ControlServlet.java:243:ERROR] An error occurred, going to the errorPage: /error/error.jsp 2011-11-30 20:56:35,450 (TP-Processor3) [ ControlServlet.java:250:ERROR] Including errorPage: /error/error.jsp 2011-11-30 20:56:37,437 (TP-Processor3) [ ControlServlet.java:324:INFO ] [[[product] Request Done- total:6.14,since last([product] Request...):6.14]] On top of this, the following (BIG RED) error screen is shown to the user: :ERROR MESSAGE: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#product]: java.lang.NullPointerException: Cannot get property 'isVirtual' on null object (Cannot get property 'isVirtual' on null object) This is caused by Product.groovy performing a search for a product (which fails) and then trying to reference product.isVariant, which doesn't exist. After the simple patch, the store now shows the default ecommerce screen, with the following message in the main ecommerce area: RESULT: Product not found for Product ID 1001JAPANCROS! Much better. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4535) Search using Russian word (maybe others) causes distortion and failed product search
[ https://issues.apache.org/jira/browse/OFBIZ-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221553#comment-13221553 ] Jacques Le Roux commented on OFBIZ-4535: Hi Uwe, Thanks for your help. From description it seems only Release 09.04.01 and trunk are touched. This could help to track the issue. Because it works on 09.04 and the culprit commit must be between (also 11.04 work(s/d) this could also foster to track). For now it's not a priority for me, sorry... Search using Russian word (maybe others) causes distortion and failed product search Key: OFBIZ-4535 URL: https://issues.apache.org/jira/browse/OFBIZ-4535 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release 09.04.01, SVN trunk Environment: Ubuntu and others. Reporter: mz4wheeler NOTE: The following post contains UTF8 characters. After rebuilding keywords in a UTF8 database (postgres) and searching a UTF8 browser (chrome), the Russian phrase is correctly present in the database, as follows: ofbiz=# select * from product_keyword where keyword = 'игроков'; product_id| keyword | relevancy_weight (trimmed) -+-+- DVDMV-ADVANGYM | игроков |1 However, when pasting 'игроков' into ecommerce Search, the following is returned Not Found Keywords: Ð¸Ð³Ñ Ð¾ÐºÐ¾Ð², where any word matches, which distorts the search. This may affect other languages, which I haven't tested. I also tried the same search in 9.04 (demo) and trunk and it produces the same issue. This means that multi-language product search is broken in OFBiz. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4535) Search using Russian word (maybe others) causes distortion and failed product search
[ https://issues.apache.org/jira/browse/OFBIZ-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221553#comment-13221553 ] Jacques Le Roux edited comment on OFBIZ-4535 at 3/3/12 11:36 AM: - EDIT Hi Uwe, Thanks for your help. From description it seems only Release 09.04.01 and trunk are touched. This could help to track the issue. Because it works on 09.04 and the culprit commit must be between (also 11.04 work(s/d) this could foster tracking). For now it's not a priority for me, sorry... was (Author: jacques.le.roux): Hi Uwe, Thanks for your help. From description it seems only Release 09.04.01 and trunk are touched. This could help to track the issue. Because it works on 09.04 and the culprit commit must be between (also 11.04 work(s/d) this could also foster to track). For now it's not a priority for me, sorry... Search using Russian word (maybe others) causes distortion and failed product search Key: OFBIZ-4535 URL: https://issues.apache.org/jira/browse/OFBIZ-4535 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release 09.04.01, SVN trunk Environment: Ubuntu and others. Reporter: mz4wheeler NOTE: The following post contains UTF8 characters. After rebuilding keywords in a UTF8 database (postgres) and searching a UTF8 browser (chrome), the Russian phrase is correctly present in the database, as follows: ofbiz=# select * from product_keyword where keyword = 'игроков'; product_id| keyword | relevancy_weight (trimmed) -+-+- DVDMV-ADVANGYM | игроков |1 However, when pasting 'игроков' into ecommerce Search, the following is returned Not Found Keywords: Ð¸Ð³Ñ Ð¾ÐºÐ¾Ð², where any word matches, which distorts the search. This may affect other languages, which I haven't tested. I also tried the same search in 9.04 (demo) and trunk and it produces the same issue. This means that multi-language product search is broken in OFBiz. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Service alert: ofbiz-vm.apache.org/HTTP - Ofbiz Demo Trunk is WARNING
On Mar 3, 2012, at 11:44 AM, Jacques Le Roux wrote: And the trunk demo has been (it seems) normally stopped Not sure why... Yeah, I know why but can't tell you at the moment (not in this public list) Jacopo
Re: Definitively remove beanshell from OFBiz
On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I know, most scripting engines have some sort of embedded cache. The problem will be that we can't clear the embedded cache like we can with our own cache implementation. I don't see that as a show stopper - it's mostly inconvenient. I can help out with the conversion. I don't think the task will be that hard. Adrian, FYI I am enhancing some of the existing framework code that uses the GroovyUtil class to simplify this task. I will commit my code changes today. Regards, Jacopo
[jira] [Closed] (OFBIZ-4719) Error org.ofbiz.webapp.event.EventHandlerException: Service invocation error (null)
[ https://issues.apache.org/jira/browse/OFBIZ-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4719. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Release Branch 10.04 Assignee: Jacques Le Roux Thanks for report Ashish, It's fixed in trunk r1296697 R11.04 r1296699 R10.04 r1296699 Error org.ofbiz.webapp.event.EventHandlerException: Service invocation error (null) - Key: OFBIZ-4719 URL: https://issues.apache.org/jira/browse/OFBIZ-4719 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 11.04, SVN trunk Environment: Linux Reporter: Ashish Ambulkar Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: Error1.png, Error2.png When enter a non existing Payment Id while applying payments 'editPaymentApplications' screen breaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
buildbot failure in ASF Buildbot on ofbiz-trunk
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2635 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch ofbiz/trunk] 1296697 Blamelist: jleroux BUILD FAILED: failed svn sincerely, -The Buildbot
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221702#comment-13221702
]
Jacques Le Roux commented on OFBIZ-2628:
Hi Sascha,
It works here. But I read in the autocompletion JavaDoc (using 1.6.22 in
Eclipse on Windows XP)
{quote}
Note: The World Wide Web Consortium Recommendation states that UTF-8 should be
used. Not doing so may introduce incompatibilites.
{quote}
This is best explained here
http://www.w3.org/TR/html40/appendix/notes.html#non-ascii-chars
Though I did not find a so affirmative advice in the [Java 6 API
doc|http://docs.oracle.com/javase/6/docs/api/java/net/URLEncoder.html], I also
read
{quote}
The recommended encoding scheme to use is UTF-8. However, for compatibility
reasons, if an encoding is not specified, then the default encoding of the
platform is used.
{quote}
So I think we should rather use Charset.forName(UTF-8).displayName() instead
of Charset.defaultCharset().displayName(). AFAIK, UTF-8 should fits with all
server and clients types...
No Url encoding for get parameters
--
Key: OFBIZ-2628
URL: https://issues.apache.org/jira/browse/OFBIZ-2628
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
Environment: All
Reporter: Patrick Antivackis
Assignee: Sascha Rodekamp
Priority: Critical
Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch,
OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch
Original Estimate: 4h
Remaining Estimate: 4h
Let's say I want to create a new category which ID is DVD+R
Creation is ok through the admin interface, but whenever i want to access
this category, the get parameter productCategoryId= of the url is wrong
as it's not url encoded, so we have :
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R
instead of
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
Both @ofbizUrl tag and menu widgets are not encoding get parameters.
Way to correct :
framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the
makeLink function
framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function
buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of
simpleEncoder
Beofre i do the fix, can a core developper let me know about possible side
effects
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221703#comment-13221703 ] Jacques Le Roux commented on OFBIZ-2628: Forgot to mention that the changes in WidgetWorker.java are OK with me No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Framework refactor
Jacopo, I would go, or at least, deeply consider option: 3.a) we base the Apache OFBiz ERP on a release of Moqui: this will only be possible if Moqui release will have all the features we need (and if Moqui community will be interested in getting contribution to evolve in the direction required by OFBzi) I think that David will be more than interested in evaluating every feature needed by OFBiz. He has already started the mantle and crust projects that, on top of the Moqui framework, should be something like a reworked OFBiz. -Bruno 2012/3/2 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Mar 2, 2012, at 7:50 AM, Hans Bakker wrote: Jacopo, You would even consider forking? From Wikipedia [*]: [...] More recently, distributed revision control (DVCS) tools have popularised a less emotive use of the term fork, blurring the distinction with branch. With a DVCS such as Mercurial or Git, the normal way to contribute to a project is to first branch the repository, and later seek to have your changes integrated with the main repository. Sites such as Github, Bitbucket and Launchpad provide free DVCS hosting expressly supporting independent branches, such that the technical, social and financial barriers to forking a source code repository are massively reduced. In order of preference (descending), here are the options I see for the future of the OFBiz framework: 1) develop a great Apache OFBiz framework 2.0 within the OFBiz community; then release it separately from the Apache OFBiz ERP 2) greatly clean up and improve the existing framework (I was not sure if this could go at #1) 3) if the above will not be possible (frankly speaking, in the committers group, apart from David, none of us ever implemented with success an open source framework) we should also consider to drop the existing code and have our community focusing on the ERP part (as Hans seems to advocate); at this point Moqui would be the most natural choice; if we will ever go with this path a great exchange of information will have to happen between the two projects: for example OFBiz will probably have to ask the Moqui framework to evolve some of its features; given the current nature of the Moqui project, I doubt that the OFBiz committers will be ever invited as committers there; if Moqui will be our choice, I see two possibilities: 3.a) we base the Apache OFBiz ERP on a release of Moqui: this will only be possible if Moqui release will have all the features we need (and if Moqui community will be interested in getting contribution to evolve in the direction required by OFBzi) 3.b) if 3.a will not be possible because OFBiz will need some features that Moqui community will not consider as a good fit for Moqui, then, under the guidance and bless of David, we could work on a fork: get the code from a Moqui release, import in our repository and add to it, in a controlled way, the features we need; of course this should be always kept as close as possible to the original code; we could synch our custom code with every new Moqui release; I was not thinking about *stealing* code to Moqui and the fact that David is both the founder of OFBiz and of Moqui and he is both in the OFBiz PMC and the leader of the Moqui project will definitely facilitate this; but it will be still an ugly solution but for example when you said: My proposal is that Apache OFBiz will be in the future just the ERP system based on many opensource products like birt and also Moqui you are actually implying that the ERP applications will be able to use Birt... but this requires some sort of framework and what would you do if Moqui will not think that Birt is a good fit for them? 4) if Moqui will not be a good option we may consider other frameworks (?), but it will be difficult, or continue with what we have Jacopo [*]: http://en.wikipedia.org/wiki/Fork_(software_development)
Re: Definitively remove beanshell from OFBiz
My changes are in commit 1296762 Help with reviews and tests will be very much appreciated. Jacopo On Mar 3, 2012, at 1:45 PM, Jacopo Cappellato wrote: On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I know, most scripting engines have some sort of embedded cache. The problem will be that we can't clear the embedded cache like we can with our own cache implementation. I don't see that as a show stopper - it's mostly inconvenient. I can help out with the conversion. I don't think the task will be that hard. Adrian, FYI I am enhancing some of the existing framework code that uses the GroovyUtil class to simplify this task. I will commit my code changes today. Regards, Jacopo
