Moving framework/jcr out of trunk and back to experimental branch

2012-05-25 Thread Jacopo Cappellato
Here are some of the arguments for moving it out of trunk:
* it is still a work in progress, and not really used in OFBiz (afaik apart 
from some examples in the "example" component)
* the architecture and goals of this component that should replace or enhance 
the OFBiz "content" framework are still to be defined
* a lot of code under jcr component is clearly a work in progress and not ready 
for distribution: several files are missing the license header (have they been 
copied?)
* most of the jars in it are not listed under the LICENSE and NOTICE files
* logging from JCR are not properly formatted (and make me think that we do not 
have proper configuration in log4j for it)
* the development on it is staling

In summary, I think it was moved too early out of the experimental branch.
What do you think?

Kind regards,

Jacopo



Re: svn commit: r1342324 - in /ofbiz/trunk: startofbiz.sh stopofbiz.sh

2012-05-25 Thread Jacopo Cappellato

On May 25, 2012, at 7:32 PM, Adam Heath wrote:

> On 05/25/2012 10:58 AM, Pierre Smits wrote:
>> Please revert this commit. Not all documentation on website and wiki
>> reflect the new situation.
> 
> Keep the commit.  Trunk doesn't have to be perfect all the time, it
> *will* be broken, and will be inconsistent from time to time.
> 
> Fix the other locations.

Thank you Adam.
To all the persons willing to contribute; please review the documentation that 
needs to be updated and share the urls here (or in a Jira task) and I (or 
others) will take care of updating it.

Jacopo


> 
>> 
>> 2012/5/24 
>> 
>>> Author: jacopoc
>>> Date: Thu May 24 16:26:51 2012
>>> New Revision: 1342324
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1342324&view=rev
>>> Log:
>>> Removed start/stop scripts for *unix systems from the OFBiz home folder:
>>> they were copies of the ones in the "tools" folder, the folder where all
>>> the scripts are now located.
>>> These two copies have been kept for a while to give enough time to some
>>> development teams to adjust their Linux based infra accordingly; at this
>>> point this commit should not cause problems.
>>> 
>>> Removed:
>>>   ofbiz/trunk/startofbiz.sh
>>>   ofbiz/trunk/stopofbiz.sh
>>> 
>>> 
>> 
> 



[jira] [Closed] (OFBIZ-4899) langDir is unavailable in ecommerce

2012-05-25 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum closed OFBIZ-4899.
--

Resolution: Fixed
  Assignee: Adrian Crum

Fixed, rev 1342852. Thanks Mohamed!

> langDir is unavailable in ecommerce
> ---
>
> Key: OFBIZ-4899
> URL: https://issues.apache.org/jira/browse/OFBIZ-4899
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: SVN trunk
>Reporter: Mohamed Amine AZZI
>Assignee: Adrian Crum
>Priority: Minor
> Fix For: SVN trunk
>
>
> When the ecommerce theme contains an rtl style sheet the condition is true 
> and the ftl tries to compare the value of langDir.
> langDir is unavailable in the context so an exception is thrown.
> Expression langDir is undefined on line 48, column 56 in 
> component://ecommerce/webapp/ecommerce/includes/headerHead.ftl. The 
> problematic instruction: -- ==> if 
> layoutSettings.VT_RTL_STYLESHEET?has_content && langDir == "rtl" [on line 48, 
> column 3 in component://ecommerce/webapp/ecommerce/includes/headerHead.ftl] 
> -- Java backtrace for programmers: -- 
> freemarker.core.InvalidReferenceException: Expression langDir is undefined on 
> line 48, column 56 in 
> component://ecommerce/webapp/ecommerce/includes/headerHead.ftl. at 
> freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:125) at 
> freemarker.core.ComparisonExpression.isTrue(ComparisonExpression.java:121) at 
> freemarker.core.AndExpression.isTrue(AndExpression.java:68) at 
> freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at 
> freemarker.core.Environment.visit(Environment.java:221) at 
> freemarker.core.MixedContent.accept(MixedContent.java:92) at 
> freemarker.core.Environment.visit(Environment.java:221) at 
> freemarker.core.Environment.process(Environment.java:199) at 
> org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:257)
>  at 
> org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:225) at 
> org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:270)
>  at 
> org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:130) at 
> org.ofbiz.widget.screen.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:915)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
>  at 
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) 
> at 
> org.ofbiz.widget.screen.ScreenFactory.renderReferencedScreen(ScreenFactory.java:216)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:580)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
>  at 
> org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
>  at 
> org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) 
> at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:135) at 
> org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:97) at 
> org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:104)
>  at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:864) 
> at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:612) 
> at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224) at 
> javax.servlet.http.HttpServlet.service(HttpServlet.java:621) at 
> javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>  at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:337) 
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>  at 
> org.ofbiz.content.content.ContentUrlFilter.doFilter(ContentUrlFilter.java:106)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>  at 
> org.ofbiz.product.category.CatalogUrlFilter.

Re: svn commit: r1342846 - in /ofbiz/trunk/framework/common: data/GeoData_CH.xml data/GeoData_CHE.xml data/GeoData_IE.xml data/GeoData_IRL.xml data/GeoData_UK.xml ofbiz-component.xml

2012-05-25 Thread Adrian Crum

This commit is throwing exceptions during data load.

-Adrian

On 5/26/2012 4:56 AM, jler...@apache.org wrote:

Author: jleroux
Date: Sat May 26 03:56:52 2012
New Revision: 1342846

URL: http://svn.apache.org/viewvc?rev=1342846&view=rev
Log:
Thanks to Martin Kaiser report on dev ML, cleans geo data a bit

Use Swiss geo data. To be consistent I have also renamed GeoData_CHE.xml to 
GeoData_CH.xml.

While at it I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed things 
internally, and extracted the  North Ireland geo data from it to GeoData_UK.xml 
where it actually belongs

Added:
 ofbiz/trunk/framework/common/data/GeoData_CH.xml
   - copied unchanged from r1342843, 
ofbiz/trunk/framework/common/data/GeoData_CHE.xml
 ofbiz/trunk/framework/common/data/GeoData_IE.xml
   - copied, changed from r1342843, 
ofbiz/trunk/framework/common/data/GeoData_IRL.xml
Removed:
 ofbiz/trunk/framework/common/data/GeoData_CHE.xml
 ofbiz/trunk/framework/common/data/GeoData_IRL.xml
Modified:
 ofbiz/trunk/framework/common/data/GeoData_UK.xml
 ofbiz/trunk/framework/common/ofbiz-component.xml

Copied: ofbiz/trunk/framework/common/data/GeoData_IE.xml (from r1342843, 
ofbiz/trunk/framework/common/data/GeoData_IRL.xml)
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData_IE.xml?p2=ofbiz/trunk/framework/common/data/GeoData_IE.xml&p1=ofbiz/trunk/framework/common/data/GeoData_IRL.xml&r1=1342843&r2=1342846&rev=1342846&view=diff
==
--- ofbiz/trunk/framework/common/data/GeoData_IRL.xml (original)
+++ ofbiz/trunk/framework/common/data/GeoData_IE.xml Sat May 26 03:56:52 2012
@@ -19,73 +19,57 @@ under the License.
  -->

  
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

-
-
-
-
-
-
-
-
-
-
-
-
-
-
  

Modified: ofbiz/trunk/framework/common/data/GeoData_UK.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData_UK.xml?rev=1342846&r1=1342845&r2=1342846&view=diff
==
--- ofbiz/trunk/framework/common/data/GeoData_UK.xml (original)
+++ ofbiz/trunk/framework/common/data/GeoData_UK.xml Sat May 26 03:56:52 2012
@@ -191,4 +191,20 @@ under the License.
  
  
  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
  

Modified: ofbiz/trunk/framework/common/ofbiz-component.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/ofbiz-component.xml?rev=1342846&r1=1342845&r2=1342846&view=diff
==
--- ofbiz/trunk/framework/common/ofbiz-component.xml (original)
+++ ofbiz/trunk/framework/common/ofbiz-component.xml Sat May 26 03:56:52 2012
@@ -38,19 +38,20 @@ under the License.
  
  
  
+
  
  
  
  
  
-
+
  
-
+
+
  
  
  
  
-

  
  




Re: GeoData_CH.xml seed data

2012-05-25 Thread Jacques Le Roux

Thanks for report,

You are right, this is now fixed in trunk at revision: 1342846

Though I noticed that at
https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title
 no states are shown, I
gave up...

To be consistent, I have also renamed GeoData_CHE.xml to GeoData_CH.xml.  Not 
sure what should be used for geoTypeId. Is STATE
correct (not a big deal)?

While at it, I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed things 
internally, and extracted the  North Ireland geo data
from it to GeoData_UK.xml where it actually belongs

I did not fill an entry at
https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29,
 I think it'spretty
obvious. Also I did not backport to branches releases.

Please check

Jacques

From: "Martin Kaiser" 

Hi all,

I'm new on this list and want to contribute to the development of OFBiz.

I found that in the seed data there exists a file containing the seed
data for the switzerland states. But the file is not used upon reading
the seed data. Is there a reason for this? Or should I just file a bug
for this? I can also immediately a patch for this.

Best regards,
Martin


Re: OFBiz translations in Chinese zh zh_CN

2012-05-25 Thread Jacques Le Roux

From: "Adrian Crum" 

On 5/25/2012 7:25 AM, Thibault Saint-Marc wrote:

Hi All,

using OFBiz in Chinese environment for an ERP in China, I realize how the
translations can be improved.
quick examples:
 
 财务
 会计
 財務
 
 
 有效的和无效的
 不在用
 有效的和無效的
 
 
 下一步
 后
 下一步
 


1) the first problem is that some properties have values in zh, zh_CN and
zh_TW.
well, what is zh if not zh_CN ?
I suggest that we put the 'mandarin' (普通话, simplified Chinese) version in
the zh locale as a default, and the Taiwanese (traditional Chinese) version
in zh_TW.
I can keep zh_CN as a copy of zh but I guess it is useless. or is it ? how
does the algorithm work in OFBiz to get the right locale ?


http://docs.oracle.com/javase/6/docs/api/java/util/ResourceBundle.html


The idea is that you overrides not common values. For instance take French.
In fr you would put all common words (avoid long sentences).
in fr_FR you would put French specific words (slang? I don't see any other 
usage)
in fr_CH you would put Swiss specific  words
in fr_BE you would put Belgian specific words
in fr_CA you would put Canadian specific words
in fr_LU you would put Luxembourg specific words
Actually nobody never did any of these, and all words are in fr.

There are some for en_GB, same idea applies.


please note that having just zh_CN and zh_TW won't do because some browser
will have zh as locale instead of zh_CN so we need that one (same way it
looks like there is only 'en' for english and no 'en_US', 'en_GB',...)

2) some translations in 'mandarin' are bad (zh or zh_CN): Accounting->  the
zh translation means 'finance', the zh_CN is right
Actually it looks like the zh_CN translation was done according to the
specifications of someone, but doesn't match the OOTB version.


That needs to be discussed with the Chinese community


Can an expert of Locales confirm my vision (just zh with Mandarin, and
zh_TW for Taiwanese) and then I can work on a patch to correct all these
simplified Chinese versions with Chinese people ?


Makes sense to me, since zh_CN is de facto the reference. But again, that needs 
to be discussed with the Chinese community.

My 2cts

Jacques


Note I will work only on the zh=zh_CN, because it looks like the zh_TW is
better and I am not able to change those.

Thanks

Thibault



Re: svn commit: r1342324 - in /ofbiz/trunk: startofbiz.sh stopofbiz.sh

2012-05-25 Thread Adam Heath
On 05/25/2012 10:58 AM, Pierre Smits wrote:
> Please revert this commit. Not all documentation on website and wiki
> reflect the new situation.

Keep the commit.  Trunk doesn't have to be perfect all the time, it
*will* be broken, and will be inconsistent from time to time.

Fix the other locations.

> 
> 2012/5/24 
> 
>> Author: jacopoc
>> Date: Thu May 24 16:26:51 2012
>> New Revision: 1342324
>>
>> URL: http://svn.apache.org/viewvc?rev=1342324&view=rev
>> Log:
>> Removed start/stop scripts for *unix systems from the OFBiz home folder:
>> they were copies of the ones in the "tools" folder, the folder where all
>> the scripts are now located.
>> These two copies have been kept for a while to give enough time to some
>> development teams to adjust their Linux based infra accordingly; at this
>> point this commit should not cause problems.
>>
>> Removed:
>>ofbiz/trunk/startofbiz.sh
>>ofbiz/trunk/stopofbiz.sh
>>
>>
> 



[jira] [Created] (OFBIZ-4899) langDir is unavailable in ecommerce

2012-05-25 Thread Mohamed Amine AZZI (JIRA)
Mohamed Amine AZZI created OFBIZ-4899:
-

 Summary: langDir is unavailable in ecommerce
 Key: OFBIZ-4899
 URL: https://issues.apache.org/jira/browse/OFBIZ-4899
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Mohamed Amine AZZI
Priority: Minor
 Fix For: SVN trunk


When the ecommerce theme contains an rtl style sheet the condition is true and 
the ftl tries to compare the value of langDir.
langDir is unavailable in the context so an exception is thrown.
Expression langDir is undefined on line 48, column 56 in 
component://ecommerce/webapp/ecommerce/includes/headerHead.ftl. The problematic 
instruction: -- ==> if layoutSettings.VT_RTL_STYLESHEET?has_content && 
langDir == "rtl" [on line 48, column 3 in 
component://ecommerce/webapp/ecommerce/includes/headerHead.ftl] -- Java 
backtrace for programmers: -- 
freemarker.core.InvalidReferenceException: Expression langDir is undefined on 
line 48, column 56 in 
component://ecommerce/webapp/ecommerce/includes/headerHead.ftl. at 
freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:125) at 
freemarker.core.ComparisonExpression.isTrue(ComparisonExpression.java:121) at 
freemarker.core.AndExpression.isTrue(AndExpression.java:68) at 
freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at 
freemarker.core.Environment.visit(Environment.java:221) at 
freemarker.core.MixedContent.accept(MixedContent.java:92) at 
freemarker.core.Environment.visit(Environment.java:221) at 
freemarker.core.Environment.process(Environment.java:199) at 
org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:257)
 at org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:225) 
at 
org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:270)
 at org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:130) 
at 
org.ofbiz.widget.screen.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:915)
 at 
org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
 at 
org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
 at 
org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
 at 
org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
 at 
org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) at 
org.ofbiz.widget.screen.ScreenFactory.renderReferencedScreen(ScreenFactory.java:216)
 at 
org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:580)
 at 
org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:104)
 at 
org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:191)
 at 
org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) at 
org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:135) at 
org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:97) at 
org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:104)
 at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:864) 
at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:612) 
at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224) at 
javax.servlet.http.HttpServlet.service(HttpServlet.java:621) at 
javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
 at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:337) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
 at 
org.ofbiz.content.content.ContentUrlFilter.doFilter(ContentUrlFilter.java:106) 
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
 at 
org.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:336) 
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
 at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:225)
 at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169)
 at 
org.apach

Re: svn commit: r1342324 - in /ofbiz/trunk: startofbiz.sh stopofbiz.sh

2012-05-25 Thread Pierre Smits
Please revert this commit. Not all documentation on website and wiki
reflect the new situation.

2012/5/24 

> Author: jacopoc
> Date: Thu May 24 16:26:51 2012
> New Revision: 1342324
>
> URL: http://svn.apache.org/viewvc?rev=1342324&view=rev
> Log:
> Removed start/stop scripts for *unix systems from the OFBiz home folder:
> they were copies of the ones in the "tools" folder, the folder where all
> the scripts are now located.
> These two copies have been kept for a while to give enough time to some
> development teams to adjust their Linux based infra accordingly; at this
> point this commit should not cause problems.
>
> Removed:
>ofbiz/trunk/startofbiz.sh
>ofbiz/trunk/stopofbiz.sh
>
>


Re: Releasing Apache OFBiz 11.04.01

2012-05-25 Thread Venkat Mangudi
On Tue, May 22, 2012 at 5:51 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:

>
>
> All the files under /build/ folders are generated ones and
> should be ignored.
> I would suggest to run RAT in your local box on a clean OFBiz in order to
> avoid these false positives.
>


Installed RAT and saxon9b. Where can I get the xsl stylesheet that was used
to build the rat-output file? The xml data is not as pretty as the output
file.

-- 
Regards,
Venkat


GeoData_CH.xml seed data

2012-05-25 Thread Martin Kaiser
Hi all,

I'm new on this list and want to contribute to the development of OFBiz.

I found that in the seed data there exists a file containing the seed
data for the switzerland states. But the file is not used upon reading
the seed data. Is there a reason for this? Or should I just file a bug
for this? I can also immediately a patch for this.

Best regards,
Martin


Re: OFBiz translations in Chinese zh zh_CN

2012-05-25 Thread Adrian Crum

On 5/25/2012 7:25 AM, Thibault Saint-Marc wrote:

Hi All,

using OFBiz in Chinese environment for an ERP in China, I realize how the
translations can be improved.
quick examples:
 
 财务
 会计
 財務
 
 
 有效的和无效的
 不在用
 有效的和無效的
 
 
 下一步
 后
 下一步
 


1) the first problem is that some properties have values in zh, zh_CN and
zh_TW.
well, what is zh if not zh_CN ?
I suggest that we put the 'mandarin' (普通话, simplified Chinese) version in
the zh locale as a default, and the Taiwanese (traditional Chinese) version
in zh_TW.
I can keep zh_CN as a copy of zh but I guess it is useless. or is it ? how
does the algorithm work in OFBiz to get the right locale ?


http://docs.oracle.com/javase/6/docs/api/java/util/ResourceBundle.html



please note that having just zh_CN and zh_TW won't do because some browser
will have zh as locale instead of zh_CN so we need that one (same way it
looks like there is only 'en' for english and no 'en_US', 'en_GB',...)

2) some translations in 'mandarin' are bad (zh or zh_CN): Accounting->  the
zh translation means 'finance', the zh_CN is right
Actually it looks like the zh_CN translation was done according to the
specifications of someone, but doesn't match the OOTB version.

Can an expert of Locales confirm my vision (just zh with Mandarin, and
zh_TW for Taiwanese) and then I can work on a patch to correct all these
simplified Chinese versions with Chinese people ?
Note I will work only on the zh=zh_CN, because it looks like the zh_TW is
better and I am not able to change those.

Thanks

Thibault



[jira] [Commented] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283277#comment-13283277
 ] 

Jacques Le Roux commented on OFBIZ-4898:


{quote}
"to use the "Provide Path" button" Huh? Maybe I am missing the obvious, but 
where do I find such a button?
{quote}
I did it for you, so the button is not available anymore. You can  see Status: 
Patch Available. You could check using the "All" tab instead of "Comments" (or 
any other tab, like "History")

Same issue with the v3 patch:

D:\workspace\ofbizSetup>patch -N -p0  0 Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch, 
> OFBIZ-4802-MFG-Help-NL-v3.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-4898:


Attachment: OFBIZ-4802-MFG-Help-NL-v3.patch

This path fixes the licence header and updates the text in help files in locale 
NL

> Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch, 
> OFBIZ-4802-MFG-Help-NL-v3.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283253#comment-13283253
 ] 

Pierre Smits commented on OFBIZ-4898:
-

"to use the "Provide Path" button" Huh? Maybe I am missing the obvious, but 
where do I find such a button?

I have synchronized with trunk this morning, but don't see any differences in 
licence header. But I will redo the process.

Regards,

Pierre

> Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: CommonEmptyHeader

2012-05-25 Thread Christian Geisert
Paul Foxworthy schrieb:
> If the intention is to override the default behaviour, wouldn't it be clearer
> to add an attribute to the widget  along the lines of
> 
> showTitle="false"
> 
> or perhaps
> 
> useFieldNameForTitle="false"
> 
> instead of fighting with a fake title that's not really a title at all?
> 
> The default value out of the schema for the attribute would, of course, be
> "true".
> 
> What do people think?

It's a little bit less hackish, but still a workaround ;-)

Let's go another step back.

In all the cases I had a closer look the field with CommonEmptyHeader
was an additional button (Cancel/Delete) to the default Submit button
(Create/Save etc.). I guess this is modeled after HTML.

So I think the best thing would be to add a button as another field type
to Forms.

Christian




[jira] [Assigned] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-4898:
--

Assignee: Jacques Le Roux

> Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283202#comment-13283202
 ] 

Jacques Le Roux commented on OFBIZ-4898:


There is an issue with your patch. You should update you working copy. We 
already patched the license header issue.

D:\workspace\ofbizClean>patch -N -p0  0 Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (OFBIZ-4898) Complete Help screens in Manufacturing in NL language

2012-05-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283195#comment-13283195
 ] 

Jacques Le Roux commented on OFBIZ-4898:


In those cases Pierre, please remember to use the "Provide Path" button. It's 
then easier for us to select issues to 1st work on...

> Complete Help screens in Manufacturing in NL language
> -
>
> Key: OFBIZ-4898
> URL: https://issues.apache.org/jira/browse/OFBIZ-4898
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>  Labels: Help, Manufacturing
> Attachments: OFBIZ-4802-MFG-Help-NL-v2.patch
>
>
> This is related and sequel of OFBIZ-4802

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira