[jira] [Commented] (OFBIZ-4848) Create return invoice from invoice
[ https://issues.apache.org/jira/browse/OFBIZ-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915595#comment-13915595 ] Nicolas Malin commented on OFBIZ-4848: -- Hi Robert, This patch it's really easier, just call copyInvoice service and change the invoice type to create a quick refund so check this service to ensure what it does. Pierre thanks for your review, this patch haven't a large business cover. It's just quick help to create credit Note realized for a small customer and I shared it. We works on a better implementation for an other projet with association between the invoice refunded and the credit note but this issue haven't the purpose to replace a stock return process, it's only works for agreement between financial employees (internal and supplier/cutomers) Nicolas Create return invoice from invoice -- Key: OFBIZ-4848 URL: https://issues.apache.org/jira/browse/OFBIZ-4848 Project: OFBiz Issue Type: New Feature Components: accounting Affects Versions: SVN trunk Reporter: Nicolas Malin Priority: Minor Attachments: OFBIZ-4848.patch If a credit note is needed on a existing invoice, I add a but on invoice menu to generate it by copyInvoice service. I improve getInvoice service to ordered invoiceItem by their sequence and when duplicate invoice items check if the parentInvoiceId is the same that duplicate invoice to propagate on new invoice. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
Re: Planning the next releases
I have spent some time reviewing a part of the code and I have a few comments inline: On Feb 25, 2014, at 10:48 PM, Pierre Smits pierre.sm...@gmail.com wrote: Jacopo, I also would like to understand what that means. And what I don't understand I can't recreate it also. the main design around the entities in the org.ofbiz.tenant group is the following: one separate small database is created to host all and only the org.ofbiz.tenant entities: these entities contain meta-data information for all tenants (url, db user and password to get access to each tenant db). The patch you have proposed, by removing the org.ofbiz.tenant group, has the effect of moving these entities to the main OFBiz database: could you please check if you see these entities in your local box (with your patch applied)? Also, could you please check the content of these entities in the tenant specific databases and in the main database? As far as conditions go, I will elaborate here under what conditions we have tested the patch. We created a virtual test setup consisting of 1 webserver (Apache HTTP) and 1 app server (consisting of Apache OFBiz, set up against derby) whereby the connection and traffic between the 2 servers was with and through the AJP protocol. In that setup we created 5 tenants (with ./ant create-tenant). And without the patch we tested all tenants accessing various apps and components with Apache JMeter (and scripts). This included accessing various functions in webtools as well. Are you saying that when you log in into Webtools with a tenantId you actually see the data from the main database rather than the data from the tenant specific db only? Is this happening for all the entities or just (as I suspect) for the entities in the org.ofbiz.tenant group? Jacopo Subsequently, we implemented the patch and ran the same tests again. Again we had no problems accessing the various apps and components. The only thing we didn't succeed in was accessing Tenant and TenantDataSource, when being logged in as a tenant super-user. However, when logged in as the admin of the master (without tenantId) we were abel to access those entities and its data. Both situations, being able to access the two entities and the data when logged in as master admin and not being able to when logged in as a tenant-admin, are as to be expected. Now, I don't know what that means when having set up the domain name for a tenant as the means to access the tenant environment. Apparently that has been developed to have a unique uri per tenant. But we never have had any use for that as we in our 3-tier productions setups have it as described as above. This avoids us having to set up internal dns records to point to specific tenants to connect to the app server. Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com
[jira] [Updated] (OFBIZ-5552) Problems in single form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leila Mekika updated OFBIZ-5552: Summary: Problems in single form when use-when and position are used together (was: Problems in singel form when use-when and position are used together) Problems in single form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Priority: Minor The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered in a new line -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (OFBIZ-5552) Problems in singel form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leila Mekika updated OFBIZ-5552: Summary: Problems in singel form when use-when and position are used together (was: Problems in form list when use-when and position are used together) Problems in singel form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Priority: Minor The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered in a new line -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (OFBIZ-5552) Problems in single form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leila Mekika updated OFBIZ-5552: Attachment: OFBIZ-5552.patch Problems in single form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Priority: Minor Attachments: OFBIZ-5552.patch The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered in a new line -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (OFBIZ-5552) Problems in single form when use-when and position are used together
[ https://issues.apache.org/jira/browse/OFBIZ-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leila Mekika updated OFBIZ-5552: Description: The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered on a new line was: The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered in a new line Problems in single form when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Priority: Minor Attachments: OFBIZ-5552.patch The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered on a new line -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (OFBIZ-5552) Problems in form list when use-when and position are used together
Leila Mekika created OFBIZ-5552: --- Summary: Problems in form list when use-when and position are used together Key: OFBIZ-5552 URL: https://issues.apache.org/jira/browse/OFBIZ-5552 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Leila Mekika Priority: Minor The service renderSingleFormString check the previous field position to see if the current field must be displayed after the previous field or on a new line. When the previous field has a use-when condition that is not valid, it remains as the currentFormField and the next field is compared with this not rendered field. If the position of this previous field is the same as the current field, the current is displayed on the next line. To reproduce, add in a single form the three fields below : field position=1 name=firstdisplay description=first//field field position=2 name=second use-when=truedisplay description=second//field field position=2 name=second use-when=falsedisplay description=second//field The field second is rendered in a new line -- This message was sent by Atlassian JIRA (v6.1.5#6160)
Re: Planning the next releases
Jacopo, Jou said: the main design around the entities in the org.ofbiz.tenant group is the following: one separate small database is created to host all and only the org.ofbiz.tenant entities: these entities contain meta-data information for all tenants (url, db user and password to get access to each tenant db). That is what I am saying. The database containing the details about each tenant should only be accessible from the master, and not from each tenant. Without the patch the super user of any tenant can see the details (of every other tenant) in the tables tenant and tenantdatasource of that database. And this shouldn't be. The patch will ensure that only through the master the db and these tables are accessible. Regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Fri, Feb 28, 2014 at 5:10 PM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: I have spent some time reviewing a part of the code and I have a few comments inline: On Feb 25, 2014, at 10:48 PM, Pierre Smits pierre.sm...@gmail.com wrote: Jacopo, I also would like to understand what that means. And what I don't understand I can't recreate it also. the main design around the entities in the org.ofbiz.tenant group is the following: one separate small database is created to host all and only the org.ofbiz.tenant entities: these entities contain meta-data information for all tenants (url, db user and password to get access to each tenant db). The patch you have proposed, by removing the org.ofbiz.tenant group, has the effect of moving these entities to the main OFBiz database: could you please check if you see these entities in your local box (with your patch applied)? Also, could you please check the content of these entities in the tenant specific databases and in the main database? As far as conditions go, I will elaborate here under what conditions we have tested the patch. We created a virtual test setup consisting of 1 webserver (Apache HTTP) and 1 app server (consisting of Apache OFBiz, set up against derby) whereby the connection and traffic between the 2 servers was with and through the AJP protocol. In that setup we created 5 tenants (with ./ant create-tenant). And without the patch we tested all tenants accessing various apps and components with Apache JMeter (and scripts). This included accessing various functions in webtools as well. Are you saying that when you log in into Webtools with a tenantId you actually see the data from the main database rather than the data from the tenant specific db only? Is this happening for all the entities or just (as I suspect) for the entities in the org.ofbiz.tenant group? Jacopo Subsequently, we implemented the patch and ran the same tests again. Again we had no problems accessing the various apps and components. The only thing we didn't succeed in was accessing Tenant and TenantDataSource, when being logged in as a tenant super-user. However, when logged in as the admin of the master (without tenantId) we were abel to access those entities and its data. Both situations, being able to access the two entities and the data when logged in as master admin and not being able to when logged in as a tenant-admin, are as to be expected. Now, I don't know what that means when having set up the domain name for a tenant as the means to access the tenant environment. Apparently that has been developed to have a unique uri per tenant. But we never have had any use for that as we in our 3-tier productions setups have it as described as above. This avoids us having to set up internal dns records to point to specific tenants to connect to the app server. Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com
