Re: Committer documentation on wiki

[Jacques Le Roux]

Done, you can edit now. Welcome in Confluence Nicolas.

When you will need access to other Confluence spaces, just ask...

Jacques

Le 27/09/2014 21:33, Nicolas Malin a écrit :
Hello, it's possible to have a write access on this page 
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities ?


Else the link associate to "Committers should set up their SVN client to use the official OFBIZ Subversion client configuration file 
" follow "http://svn.ofbiz.org/svn/ofbiz/trunk/website/svn/config"; instead of 
http://ofbiz.apache.org/svn/config


Nicolas

[jira] [Commented] (OFBIZ-5674) User with view permissions can't access several screens in content application

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150957#comment-14150957
 ] 

Jacques Le Roux commented on OFBIZ-5674:


Please Pierre, confirm and close if you agree, thanks.

> User with view permissions can't access several screens in content application
> --
>
> Key: OFBIZ-5674
> URL: https://issues.apache.org/jira/browse/OFBIZ-5674
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>Reporter: Pierre Smits
>
> When a user has basic CONTENTMGR_VIEW or CONTENTMGR_ROLE_VIEW (with 
> appropriate role(s) assigned) permission he should be able to access the 
> various screens in the content application.
> The user sees the menu-items, but can't get to the screens. The response 
> given, when doing so, is: 'You do not have permission to view this page. 
> ("CONTENTMGR_UPDATE" or "CONTENTMGR_ADMIN" needed)'
> This happens for following menu-items:
> Content
> DataSource
> DataResource Setup
> Template
> CMS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-4927) The updation and deletion of content meta data tab is not working.Needs a change of entity ContentMetaData.

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150956#comment-14150956
 ] 

Jacques Le Roux commented on OFBIZ-4927:


Hi Deepak,

I found how to reproduce in UI for ContentMetaData but not 
DataResourceMetaData. DId you find a way to test your change?

> The updation and deletion of content meta data tab is not working.Needs a 
> change of entity ContentMetaData.
> ---
>
> Key: OFBIZ-4927
> URL: https://issues.apache.org/jira/browse/OFBIZ-4927
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Release 09.04, Release 10.04, Release 11.04.01
> Environment: windows
>Reporter: Tata Consultancy Services ltd
> Attachments: OFBIZ-4927.patch, updatemeta.txt
>
>
> The updation and deletion of content meta data tab is not working.Needs a 
> change of entity ContentMetaData.As metaDataValue is changed from primary key 
> to non primary key as the value can be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-4654) "ContentContent Page" not implemented

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4654.
--
Resolution: Cannot Reproduce

> "ContentContent Page" not implemented
> -
>
> Key: OFBIZ-4654
> URL: https://issues.apache.org/jira/browse/OFBIZ-4654
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>
> In this page:
> https://demo-trunk.=-ofbiz.apache.org/catalog/control/EditCategoryContentContent?productCategoryId=20111&contentId=20111-ALT&prodCatContentTypeId=ALTERNATIVE_URL&fromDate=2001-05-13%2012:00:00.000
> The "ContentContent Page" button is not implemented. Clicking on this button 
> gives the following message.
> :ERROR MESSAGE:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [gotoContent]; this request does not exist or cannot be called directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-4654) "ContentContent Page" not implemented

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4654:
---
Description: 
In this page:
https://demo-trunk.=-ofbiz.apache.org/catalog/control/EditCategoryContentContent?productCategoryId=20111&contentId=20111-ALT&prodCatContentTypeId=ALTERNATIVE_URL&fromDate=2001-05-13%2012:00:00.000

The "ContentContent Page" button is not implemented. Clicking on this button 
gives the following message.

:ERROR MESSAGE:
org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[gotoContent]; this request does not exist or cannot be called directly.



  was:
In this page:
https://demo-trunk.ofbiz.apache.org/catalog/control/EditCategoryContentContent?productCategoryId=20111&contentId=20111-ALT&prodCatContentTypeId=ALTERNATIVE_URL&fromDate=2001-05-13%2012:00:00.000

The "ContentContent Page" button is not implemented. Clicking on this button 
gives the following message.

:ERROR MESSAGE:
org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[gotoContent]; this request does not exist or cannot be called directly.



   Assignee: Jacques Le Roux

I fixed the link (now the domain is demo-trunk-ofbiz.apache.org not 
demo-trunk.ofbiz.apache.org), tried and it' works. So I agree with Deepak 
(thanks Deepak!) and I close as not reproductible

> "ContentContent Page" not implemented
> -
>
> Key: OFBIZ-4654
> URL: https://issues.apache.org/jira/browse/OFBIZ-4654
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>
> In this page:
> https://demo-trunk.=-ofbiz.apache.org/catalog/control/EditCategoryContentContent?productCategoryId=20111&contentId=20111-ALT&prodCatContentTypeId=ALTERNATIVE_URL&fromDate=2001-05-13%2012:00:00.000
> The "ContentContent Page" button is not implemented. Clicking on this button 
> gives the following message.
> :ERROR MESSAGE:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [gotoContent]; this request does not exist or cannot be called directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-4777) Add missing ConverterLoader to framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader for running FOBiz in debug under Eclipse

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150939#comment-14150939
 ] 

Jacques Le Roux commented on OFBIZ-4777:


Hi Francis,

Is there a reason why you added these lines in 
framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
 rather than creating a 
framework/base/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader 
file and put these lines there?

> Add missing ConverterLoader to 
> framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
>  for running FOBiz in debug under Eclipse
> 
>
> Key: OFBIZ-4777
> URL: https://issues.apache.org/jira/browse/OFBIZ-4777
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
> Environment: WXP SP3 JDK 1.6.0_30
>Reporter: Francis ANDRE
>Assignee: Jacques Le Roux
> Fix For: Trunk
>
> Attachments: ofbiz-services.patch
>
>
> Hi
> In order to run OFBiz in debug mode under Eclipse with hot class reloading, 
> one needs to add the following Converters to the services 
> framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
>  because they are added at build time by the build.xml of the framework. 
> Thus, they are missing when running OFBiz as an full Eclipse debug launcher.
> org.ofbiz.base.conversion.BooleanConverters
> org.ofbiz.base.conversion.CollectionConverters
> org.ofbiz.base.conversion.DateTimeConverters
> org.ofbiz.base.conversion.JSONConverters
> org.ofbiz.base.conversion.MiscConverters
> org.ofbiz.base.conversion.NetConverters
> org.ofbiz.base.conversion.NumberConverters
> Rgds



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (OFBIZ-3719) Include DOCTYPE at the begining of CMS driven html page.

[Anil K Patel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel resolved OFBIZ-3719.
-
Resolution: Fixed

Reverted hardcoding of DOCTYPE from cmsevents.

> Include DOCTYPE at the begining of CMS driven html page.
> 
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before 
> rendering single HTML statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-3719) Include DOCTYPE at the begining of CMS driven html page.

[Anil K Patel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel closed OFBIZ-3719.
---

> Include DOCTYPE at the begining of CMS driven html page.
> 
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before 
> rendering single HTML statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-3719) Include DOCTYPE at the begining of CMS driven html page.

[Anil K Patel (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150798#comment-14150798
 ] 

Anil K Patel commented on OFBIZ-3719:
-

I agree with Scott. The template / decorator can handle adding DOCTYPE. Hard 
coding is not a good idea.

> Include DOCTYPE at the begining of CMS driven html page.
> 
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before 
> rendering single HTML statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (OFBIZ-3719) Include DOCTYPE at the begining of CMS driven html page.

[Anil K Patel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel reopened OFBIZ-3719:
-
  Assignee: Anil K Patel  (was: Ashish Vijaywargiya)

> Include DOCTYPE at the begining of CMS driven html page.
> 
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Anil K Patel
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before 
> rendering single HTML statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Committer documentation on wiki

[Nicolas Malin]

Hello, it's possible to have a write access on this page 
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities 
?


Else the link associate to "Committers should set up their SVN client to 
use the official OFBIZ Subversion client configuration file 
" follow 
"http://svn.ofbiz.org/svn/ofbiz/trunk/website/svn/config"; instead of 
http://ofbiz.apache.org/svn/config


Nicolas

Re: Welcome Nicolas Malin as new committer!

[Nicolas Malin]

Hello,

I did not except to the PMC invitation, so it's a real pleasure to 
participate on this great project and help PMC and commiter to make it 
even more powerful !


Le 26/09/2014 18:55, Jacopo Cappellato a écrit :

The OFBiz PMC has invited Nicolas to become a new committer and he has accepted 
the new role: Nicolas is a skilled developer and he knows the OFBiz codebase 
quite well; but most of all Nicolas
is committed to the project and has always showed a positive and collaborative 
attitude. Please welcome him onboard!
Wow ... as says Jacques : " I don't need laudations (I mean this makes 
me feel a bit uncomfortable), just doing my job"  ^^


Thanks to all for your congratulations, now I need to continue my work ! :)

Regards,
Nicolas



Thank you

Jacopo

Fwd: [ NOTICE ] Upcoming change to committer email services

[Jacopo Cappellato]

FYI

Begin forwarded message:

> From: Tony Stevenson 
> Subject: [ NOTICE ] Upcoming change to committer email services
> Date: September 26, 2014 at 12:58:46 AM GMT+2
> To: committ...@apache.org
> Reply-To: ASF Infrastructure 
> 
> The Infrastructure team have just published a new blog post in which we talk 
> about an upcoming change to how we will handle email from committers.  This 
> will affect anyone who sends email from their apache.org email address - if 
> this is you you should read this blog post and implement the changes it talks 
> about. 
> 
> In short, we have a new service which we will require anyone who sends email 
> from any apache.org email address.  Historically this has not been enforced, 
> but going forward it will be. This is to try and improve the overall mail 
> service. 
> 
> The blog post can be found here.  [1]
> 
> The new service is available immediately.  The incumbent service will be 
> disabled at 13:00 UTC on Friday 10th October.  It is important you read and 
> understand the changes in plenty of time.
> 
> If you have any questions please address them to the infrastructure@ list 
> (Reply-To set to this already). If you have any technical issues with the 
> service, please open a JIRA issue at [2] in the INFRA queue.
> 
> 
> 
> [1] - https://blogs.apache.org/infra/entry/committers_mail_relay_service 
> [2] - https://issues.apache.org/jira/
> 
> 
> p.s. And, yes, this email was sent using this service.  :) 
> 
> 
> Cheers,
> Tony
> 
> On behalf of the Apache Infrastructure Team
> 
> --
> Tony Stevenson
> 
> pct...@apache.org
> 
> http://www.pc-tony.com
> 
> GPG - 1024D/51047D66
> --
> 

[jira] [Commented] (OFBIZ-5632) Changing Visual theme in Order manager results in error message

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150582#comment-14150582
 ] 

Deepak Dixit commented on OFBIZ-5632:
-

Here is the error from demo instance 

{quote}
2014-09-27 12:41:55,328 (http-bio-0.0.0.0-28080-exec-20) [ 
RequestHandler.java:208:ERROR] Got a insecure (non-https) form POST to a secure 
(http) request [setUserPreference], returning error
2014-09-27 12:41:55,328 (http-bio-0.0.0.0-28080-exec-20) [ 
RequestHandler.java:226:WARN ] HTTPS is disabled for this site, so we can't 
tell if this was encrypted or not which means if a form was POSTed and it was 
not over HTTPS we don't know, but it would be vulnerable to an XSRF and other 
attacks: Not accepting insecure form data posted to a secure request
2014-09-27 12:41:55,361 (http-bio-0.0.0.0-28080-exec-20) [ 
RequestHandler.java:661:INFO ] Ran Event [service:#setUserPreference] from 
[request], result is [success]
2014-09-27 12:41:55,362 (http-bio-0.0.0.0-28080-exec-20) [ 
RequestHandler.java:766:INFO ] Rendering View [quickcheckout], 
sessionId=22BF8627BD39C87C3AFDB82AD172D870.jvm1
2014-09-27 12:41:55,397 (http-bio-0.0.0.0-28080-exec-20) [ 
ScreenFactory.java:130:INFO ] Got 15 screens in 0.005s from: 
file:/home/ofbizDemo/branch12.4/applications/order/widget/ordermgr/OrderEntryOrderScreens.xml
2014-09-27 12:41:55,430 (http-bio-0.0.0.0-28080-exec-20) [ 
ScriptUtil.java:347:WARN ]
 exception report --
Error running script at location 
[component://order/webapp/ordermgr/WEB-INF/actions/entry/CheckoutPayment.groovy]:
 javax.script.ScriptException: java.lang.NullPointerException: Cannot invoke 
method getCurrency() on null object
Exception: javax.script.ScriptException
Message: java.lang.NullPointerException: Cannot invoke method getCurrency() on 
null object
 cause -
Exception: java.lang.NullPointerException
{quote}

> Changing Visual theme in Order manager results in error message
> ---
>
> Key: OFBIZ-5632
> URL: https://issues.apache.org/jira/browse/OFBIZ-5632
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Trunk
> Environment: Primarily tested on Ubuntu, but affects all OS.
>Reporter: Vyom Jain
> Attachments: ChangeVisualTheme.png, RemoveCart.png
>
>
> The reported issue has been observed in the order manager application. It 
> happens when there's no shopping cart in the session.
> Steps to test -
> 1. Try changing visual theme in the order manager application.
> Observations -
> 1. Returns ERROR MESSAGE - org.ofbiz.widget.screen.ScreenRenderException: 
> Error rendering screen 
> [component://order/widget/ordermgr/OrderEntryOrderScreens.xml#quickFinalizeOrder]:
>  java.lang.IllegalArgumentException: Error running script at location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/CheckoutPayment.groovy]:
>  java.lang.NullPointerException: Cannot invoke method getRelated() on null 
> object (Error running script at location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/CheckoutPayment.groovy]:
>  java.lang.NullPointerException: Cannot invoke method getRelated() on null 
> object)
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5632) Changing Visual theme in Order manager results in error message

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150581#comment-14150581
 ] 

Deepak Dixit commented on OFBIZ-5632:
-

This issue exists for relase12.04 branch.
Here are the steps to regenerate issue:
- Go to ordermgr select customer, product
- Click on finalize order
- Click on create order button
- After creating order screen will be redirected to order view page
- Now click on Visual Theme link to change the theme
- Select any theme now you will get an error. 

It might be possible that due to some framework level enhancement/fixes this 
issue has been fixed in trunk. release13.07 branch.


> Changing Visual theme in Order manager results in error message
> ---
>
> Key: OFBIZ-5632
> URL: https://issues.apache.org/jira/browse/OFBIZ-5632
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Trunk
> Environment: Primarily tested on Ubuntu, but affects all OS.
>Reporter: Vyom Jain
> Attachments: ChangeVisualTheme.png, RemoveCart.png
>
>
> The reported issue has been observed in the order manager application. It 
> happens when there's no shopping cart in the session.
> Steps to test -
> 1. Try changing visual theme in the order manager application.
> Observations -
> 1. Returns ERROR MESSAGE - org.ofbiz.widget.screen.ScreenRenderException: 
> Error rendering screen 
> [component://order/widget/ordermgr/OrderEntryOrderScreens.xml#quickFinalizeOrder]:
>  java.lang.IllegalArgumentException: Error running script at location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/CheckoutPayment.groovy]:
>  java.lang.NullPointerException: Cannot invoke method getRelated() on null 
> object (Error running script at location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/CheckoutPayment.groovy]:
>  java.lang.NullPointerException: Cannot invoke method getRelated() on null 
> object)
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Welcome Nicolas Malin as new committer!

[Jacques Le Roux]

I updated the PMC wiki page

Jacques

Le 26/09/2014 23:17, Jacques Le Roux a écrit :

Hi Nicolas,

Quite happy to have you with us

Jacques

Le 26/09/2014 18:55, Jacopo Cappellato a écrit :
The OFBiz PMC has invited Nicolas to become a new committer and he has accepted the new role: Nicolas is a skilled developer and he knows the OFBiz 
codebase quite well; but most of all Nicolas

is committed to the project and has always showed a positive and collaborative 
attitude. Please welcome him onboard!

Thank you

Jacopo

Re: Welcome Nicolas Malin as new committer!

[Pranay Pandey]

Many Congratulations Nicolas.

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com

On Sep 26, 2014, at 10:25 PM, Jacopo Cappellato 
 wrote:

> The OFBiz PMC has invited Nicolas to become a new committer and he has 
> accepted the new role: Nicolas is a skilled developer and he knows the OFBiz 
> codebase quite well; but most of all Nicolas
> is committed to the project and has always showed a positive and 
> collaborative attitude. Please welcome him onboard!
> 
> Thank you
> 
> Jacopo

Re: svn commit: r1308085 - /ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversi on.ConverterLoader

[Jacques Le Roux]

I must say I never questioned this, I will have a look...

Jacques

Le 26/09/2014 17:17, Jacopo Cappellato a écrit :

Hi Jacques,

why these services have been added to the entity component rather than to the 
base component?

Regards,
Jacopo

On Apr 1, 2012, at 1:39 PM, jler...@apache.org wrote:


Author: jleroux
Date: Sun Apr  1 11:39:34 2012
New Revision: 1308085

URL: http://svn.apache.org/viewvc?rev=1308085&view=rev
Log:
A patch from Francis ANDRE "Add missing ConverterLoader to 
framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader for 
running FOBiz in debug under Eclipse https://issues.apache.org/jira/browse/OFBIZ-4777

In order to run OFBiz in debug mode under Eclipse with hot class reloading, one 
needs to add the following Converters to the services 
framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
 because they are added at build time by the build.xml of the framework. Thus, 
they are missing when running OFBiz as an full Eclipse debug launcher.

org.ofbiz.base.conversion.BooleanConverters
org.ofbiz.base.conversion.CollectionConverters
org.ofbiz.base.conversion.DateTimeConverters
org.ofbiz.base.conversion.JSONConverters
org.ofbiz.base.conversion.MiscConverters
org.ofbiz.base.conversion.NetConverters
org.ofbiz.base.conversion.NumberConverters

Modified:

ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader

Modified: 
ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader?rev=1308085&r1=1308084&r2=1308085&view=diff
==
--- 
ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
 (original)
+++ 
ofbiz/trunk/framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
 Sun Apr  1 11:39:34 2012
@@ -16,3 +16,10 @@
# under the License.

org.ofbiz.entity.util.Converters
+org.ofbiz.base.conversion.BooleanConverters
+org.ofbiz.base.conversion.CollectionConverters
+org.ofbiz.base.conversion.DateTimeConverters
+org.ofbiz.base.conversion.JSONConverters
+org.ofbiz.base.conversion.MiscConverters
+org.ofbiz.base.conversion.NetConverters
+org.ofbiz.base.conversion.NumberConverters

Re: OFBiz and OHLOH (OpenHub.net

[Jacques Le Roux]

Indeed, I'd need to ask, being read only would maybe not be enough :/
The advantage I see is the longevity...

Jacques

Le 27/09/2014 11:51, Jacopo Cappellato a écrit :

it is an interesting idea but please remember that the code was not under the 
ASL2.0 at that time (if my memory serves) and I am not sure if we can do that.

Jacopo

On Sep 27, 2014, at 11:34 AM, Jacques Le Roux  
wrote:


David, All,

I just thought about that. If ever someone can get a hand on the missing part, 
we could create a read only repo under https://svn.apache.org/repos/asf/ofbiz 
and link it to Open Hub

Jacques

Le 27/09/2014 10:55, Jacques Le Roux a écrit :

Today, I got the opportunity to write a short historical background at Quora
https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux

Jacques

Le 17/09/2014 08:55, Pierre Smits a écrit :

Thanks for the update, David.

I will add the sourceforge reference of the duplicate to the main ohloh
OFBiz reference and ask them to kill the duplicate. This will end the
ambiguity.


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:


A couple of corrections:

1. during that time without data available OFBiz was hosted as a java.net
project (not on Undersun infrastructure); looking there I can't find any
sign of it though... unlike SourceForce maybe they clean out projects and
get rid of data

2. I did not create an OFBiz project on Openhub and have no admin access
to either of the OFBiz listings there; they both show on my profile because
my account is linked to the committer accounts for both

It would be great to have this history, but not sure if the data is
available. I may have an archive somewhere (just looked on my laptop and
couldn't find it, so would have to search old disks), but to get it into
Openhub/Ohloh it would probably need to be hosted somewhere. The reason I
say I might have an archive is that IIRC when we moved from java.net to
the ASF we got a full dump of the SVN repo from java.net. That may still
exist somewhere...

-David


On Sep 16, 2014, at 1:16 PM, Jacques Le Roux 
wrote:


I found that David certainly created the OFBiz duplicate on Openhub

https://www.openhub.net/accounts/jonesde/positions

He has commits almost from the start there, but with a hole between mid

2003 and the Apache Era (mid 2006)

It would be good if we could merge the duplicate and add the missing

commits in between

Jacques

Le 16/09/2014 18:32, Jacques Le Roux a écrit :

You might find interesting stuff here

https://web.archive.org/web/20060701213529/http://www.ofbiz.org/

Jacques

Le 16/09/2014 17:03, Pierre Smits a écrit :

Yes they can.

Actually there is a duplicate that has a sourceforge repository

referenced

as well. That duplicate has commit data prior to aug 2003.

See: https://www.openhub.net/p/ofbiz

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Also, I wonder if openhub is able to concatenate (time ordered) the
content of 2 svn repos?

Jacques

Le 16/09/2014 13:58, Jacques Le Roux a écrit :

  I remember BJ had a copy, not sure he is still listening...

Jacques

Le 16/09/2014 13:14, Pierre Smits a écrit :


It would be good to have a complete and accurate history.

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

  I fear the pre Apache era svn server (Undersun consulting) is no

longer

available.
But maybe someone has a copy and could set a svn server?

Jacques

Le 16/09/2014 13:05, Pierre Smits a écrit :

  The openhub maintainers have informed me that commit data between

2003-8-31
and  2006-07-01 is missing.

Does anybody know what was used to commit changes to and is that
resource
still available to be included in the OHLOH (openhub) page of

OFBiz?

Regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <

pierre.sm...@gmail.com

wrote:

   Hi all,


The OFBiz page at OHLOH had gotten outdated since the OHLOH
organisation
moved to openhub.net.

The stats have been updated, and can be found here:
https://www.openhub.net/p/Apache-OFBiz

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: OFBiz and OHLOH (OpenHub.net

[Jacques Le Roux]

Thanks Adrian!

Jacques

Le 27/09/2014 12:12, Adrian Crum a écrit :

incumbating -> incubating

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/27/2014 9:55 AM, Jacques Le Roux wrote:

Today, I got the opportunity to write a short historical background at
Quora
https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux


Jacques

Le 17/09/2014 08:55, Pierre Smits a écrit :

Thanks for the update, David.

I will add the sourceforge reference of the duplicate to the main ohloh
OFBiz reference and ask them to kill the duplicate. This will end the
ambiguity.


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:


A couple of corrections:

1. during that time without data available OFBiz was hosted as a
java.net
project (not on Undersun infrastructure); looking there I can't find any
sign of it though... unlike SourceForce maybe they clean out projects
and
get rid of data

2. I did not create an OFBiz project on Openhub and have no admin access
to either of the OFBiz listings there; they both show on my profile
because
my account is linked to the committer accounts for both

It would be great to have this history, but not sure if the data is
available. I may have an archive somewhere (just looked on my laptop and
couldn't find it, so would have to search old disks), but to get it into
Openhub/Ohloh it would probably need to be hosted somewhere. The
reason I
say I might have an archive is that IIRC when we moved from java.net to
the ASF we got a full dump of the SVN repo from java.net. That may still
exist somewhere...

-David


On Sep 16, 2014, at 1:16 PM, Jacques Le Roux

wrote:


I found that David certainly created the OFBiz duplicate on Openhub

https://www.openhub.net/accounts/jonesde/positions

He has commits almost from the start there, but with a hole between mid

2003 and the Apache Era (mid 2006)

It would be good if we could merge the duplicate and add the missing

commits in between

Jacques

Le 16/09/2014 18:32, Jacques Le Roux a écrit :

You might find interesting stuff here

https://web.archive.org/web/20060701213529/http://www.ofbiz.org/

Jacques

Le 16/09/2014 17:03, Pierre Smits a écrit :

Yes they can.

Actually there is a duplicate that has a sourceforge repository

referenced

as well. That duplicate has commit data prior to aug 2003.

See: https://www.openhub.net/p/ofbiz

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Also, I wonder if openhub is able to concatenate (time ordered) the
content of 2 svn repos?

Jacques

Le 16/09/2014 13:58, Jacques Le Roux a écrit :

  I remember BJ had a copy, not sure he is still listening...

Jacques

Le 16/09/2014 13:14, Pierre Smits a écrit :


It would be good to have a complete and accurate history.

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

  I fear the pre Apache era svn server (Undersun consulting) is no

longer

available.
But maybe someone has a copy and could set a svn server?

Jacques

Le 16/09/2014 13:05, Pierre Smits a écrit :

  The openhub maintainers have informed me that commit data
between

2003-8-31
and  2006-07-01 is missing.

Does anybody know what was used to commit changes to and is that
resource
still available to be included in the OHLOH (openhub) page of

OFBiz?

Regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <

pierre.sm...@gmail.com

wrote:

   Hi all,


The OFBiz page at OHLOH had gotten outdated since the OHLOH
organisation
moved to openhub.net.

The stats have been updated, and can be found here:
https://www.openhub.net/p/Apache-OFBiz

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Order items edition

[Jacques Le Roux]

Hi,

In the order view screen, I always wondered why there were check boxes to select when you change a value (price or/and quantity) of an order item when 
simply putting a value should be enough.
It barely makes sense because there is also a "Cancel Selected Items" option. Though it's confusing because you need to check the quantity check box 
and not the price one.


But I wonder even more about the "Override Price" check box which is associated 
with Price input.

So in both cases what are the rationales behind those check boxes? Could be not get rid of these and have only a check box, in each order item line, 
just under the "Cancel Selected Items" option?


Thanks

Jacques

Re: Welcome Nicolas Malin as new committer!

[Guillaume Sigoigne]

Congratulations Nicolas !!!

Guillaume Sigoigne
Nomaka


Le 27 septembre 2014 09:01:24 UTC+02:00, Adrian Crum 
 a écrit :
>Congratulations Nicolas! Welcome aboard!
>
>Adrian Crum
>Sandglass Software
>www.sandglass-software.com
>
>On 9/26/2014 5:55 PM, Jacopo Cappellato wrote:
>> The OFBiz PMC has invited Nicolas to become a new committer and he
>has accepted the new role: Nicolas is a skilled developer and he knows
>the OFBiz codebase quite well; but most of all Nicolas
>> is committed to the project and has always showed a positive and
>collaborative attitude. Please welcome him onboard!
>>
>> Thank you
>>
>> Jacopo
>>

Re: OFBiz and OHLOH (OpenHub.net

[Pierre Smits]

Well done, Jacques.

A nice addition to the promotion of OFBiz.

Regards,

Pierre

Verstuurd vanaf mijn iPad

> Op 27 sep. 2014 om 10:55 heeft Jacques Le Roux  
> het volgende geschreven:
> 
> Today, I got the opportunity to write a short historical background at Quora
> https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux
> 
> Jacques
> 
> Le 17/09/2014 08:55, Pierre Smits a écrit :
>> Thanks for the update, David.
>> 
>> I will add the sourceforge reference of the duplicate to the main ohloh
>> OFBiz reference and ask them to kill the duplicate. This will end the
>> ambiguity.
>> 
>> 
>> Pierre Smits
>> 
>> *ORRTIZ.COM *
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>> 
>>> On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:
>>> 
>>> A couple of corrections:
>>> 
>>> 1. during that time without data available OFBiz was hosted as a java.net
>>> project (not on Undersun infrastructure); looking there I can't find any
>>> sign of it though... unlike SourceForce maybe they clean out projects and
>>> get rid of data
>>> 
>>> 2. I did not create an OFBiz project on Openhub and have no admin access
>>> to either of the OFBiz listings there; they both show on my profile because
>>> my account is linked to the committer accounts for both
>>> 
>>> It would be great to have this history, but not sure if the data is
>>> available. I may have an archive somewhere (just looked on my laptop and
>>> couldn't find it, so would have to search old disks), but to get it into
>>> Openhub/Ohloh it would probably need to be hosted somewhere. The reason I
>>> say I might have an archive is that IIRC when we moved from java.net to
>>> the ASF we got a full dump of the SVN repo from java.net. That may still
>>> exist somewhere...
>>> 
>>> -David
>>> 
>>> 
>>> On Sep 16, 2014, at 1:16 PM, Jacques Le Roux 
>>> wrote:
>>> 
 I found that David certainly created the OFBiz duplicate on Openhub
>>> https://www.openhub.net/accounts/jonesde/positions
 He has commits almost from the start there, but with a hole between mid
>>> 2003 and the Apache Era (mid 2006)
 It would be good if we could merge the duplicate and add the missing
>>> commits in between
 Jacques
 
 Le 16/09/2014 18:32, Jacques Le Roux a écrit :
> You might find interesting stuff here
>>> https://web.archive.org/web/20060701213529/http://www.ofbiz.org/
> Jacques
> 
> Le 16/09/2014 17:03, Pierre Smits a écrit :
>> Yes they can.
>> 
>> Actually there is a duplicate that has a sourceforge repository
>>> referenced
>> as well. That duplicate has commit data prior to aug 2003.
>> 
>> See: https://www.openhub.net/p/ofbiz
>> 
>> Pierre Smits
>> 
>> *ORRTIZ.COM *
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>> 
>> On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>> 
>>> Also, I wonder if openhub is able to concatenate (time ordered) the
>>> content of 2 svn repos?
>>> 
>>> Jacques
>>> 
>>> Le 16/09/2014 13:58, Jacques Le Roux a écrit :
>>> 
>>>  I remember BJ had a copy, not sure he is still listening...
 Jacques
 
 Le 16/09/2014 13:14, Pierre Smits a écrit :
 
> It would be good to have a complete and accurate history.
> 
> Pierre Smits
> 
> *ORRTIZ.COM *
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
> 
> On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
> 
>  I fear the pre Apache era svn server (Undersun consulting) is no
>>> longer
>> available.
>> But maybe someone has a copy and could set a svn server?
>> 
>> Jacques
>> 
>> Le 16/09/2014 13:05, Pierre Smits a écrit :
>> 
>>  The openhub maintainers have informed me that commit data between
>>> 2003-8-31
>>> and  2006-07-01 is missing.
>>> 
>>> Does anybody know what was used to commit changes to and is that
>>> resource
>>> still available to be included in the OHLOH (openhub) page of
>>> OFBiz?
>>> Regards,
>>> 
>>> Pierre Smits
>>> 
>>> *ORRTIZ.COM *
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>> 
>>> On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <
>>> pierre.sm...@gmail.com
>>> wrote:

Re: OFBiz and OHLOH (OpenHub.net

[Adrian Crum]

incumbating -> incubating

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/27/2014 9:55 AM, Jacques Le Roux wrote:

Today, I got the opportunity to write a short historical background at
Quora
https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux


Jacques

Le 17/09/2014 08:55, Pierre Smits a écrit :

Thanks for the update, David.

I will add the sourceforge reference of the duplicate to the main ohloh
OFBiz reference and ask them to kill the duplicate. This will end the
ambiguity.


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:


A couple of corrections:

1. during that time without data available OFBiz was hosted as a
java.net
project (not on Undersun infrastructure); looking there I can't find any
sign of it though... unlike SourceForce maybe they clean out projects
and
get rid of data

2. I did not create an OFBiz project on Openhub and have no admin access
to either of the OFBiz listings there; they both show on my profile
because
my account is linked to the committer accounts for both

It would be great to have this history, but not sure if the data is
available. I may have an archive somewhere (just looked on my laptop and
couldn't find it, so would have to search old disks), but to get it into
Openhub/Ohloh it would probably need to be hosted somewhere. The
reason I
say I might have an archive is that IIRC when we moved from java.net to
the ASF we got a full dump of the SVN repo from java.net. That may still
exist somewhere...

-David


On Sep 16, 2014, at 1:16 PM, Jacques Le Roux

wrote:


I found that David certainly created the OFBiz duplicate on Openhub

https://www.openhub.net/accounts/jonesde/positions

He has commits almost from the start there, but with a hole between mid

2003 and the Apache Era (mid 2006)

It would be good if we could merge the duplicate and add the missing

commits in between

Jacques

Le 16/09/2014 18:32, Jacques Le Roux a écrit :

You might find interesting stuff here

https://web.archive.org/web/20060701213529/http://www.ofbiz.org/

Jacques

Le 16/09/2014 17:03, Pierre Smits a écrit :

Yes they can.

Actually there is a duplicate that has a sourceforge repository

referenced

as well. That duplicate has commit data prior to aug 2003.

See: https://www.openhub.net/p/ofbiz

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Also, I wonder if openhub is able to concatenate (time ordered) the
content of 2 svn repos?

Jacques

Le 16/09/2014 13:58, Jacques Le Roux a écrit :

  I remember BJ had a copy, not sure he is still listening...

Jacques

Le 16/09/2014 13:14, Pierre Smits a écrit :


It would be good to have a complete and accurate history.

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

  I fear the pre Apache era svn server (Undersun consulting) is no

longer

available.
But maybe someone has a copy and could set a svn server?

Jacques

Le 16/09/2014 13:05, Pierre Smits a écrit :

  The openhub maintainers have informed me that commit data
between

2003-8-31
and  2006-07-01 is missing.

Does anybody know what was used to commit changes to and is that
resource
still available to be included in the OHLOH (openhub) page of

OFBiz?

Regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <

pierre.sm...@gmail.com

wrote:

   Hi all,


The OFBiz page at OHLOH had gotten outdated since the OHLOH
organisation
moved to openhub.net.

The stats have been updated, and can be found here:
https://www.openhub.net/p/Apache-OFBiz

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

[Jacopo Cappellato]

This is really an amazing contribution! Thank you Scott.

Jacopo

On Sep 27, 2014, at 11:22 AM, lekt...@apache.org wrote:

> Author: lektran
> Date: Sat Sep 27 09:22:31 2014
> New Revision: 1627940
> 
> URL: http://svn.apache.org/r1627940
> Log:
> OFBIZ-4053 Implement an entity query builder to be used as a friendlier API 
> for executing entity queries.
> 
> Entry point is the static EntityQuery.use(Delegator) method which will then 
> return an EntityQuery instance whose methods support method chaining to set 
> query options.
> The query can then be executed using the first(), list(), iterator() and 
> one() methods which respectively return:
> - The first result from a result set
> - The full list of results from a result set
> - An EntityListIterator to iterate over a result set
> - The single record from a query that will return only one record (such as a 
> lookup by primary key)
> 
> Added:
>ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java   
> (with props)
> 
> Added: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java?rev=1627940&view=auto
> ==
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java 
> (added)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java 
> Sat Sep 27 09:22:31 2014
> @@ -0,0 +1,416 @@
> +/***
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + 
> ***/
> +package org.ofbiz.entity.util;
> +
> +import java.sql.Timestamp;
> +import java.util.Arrays;
> +import java.util.List;
> +import java.util.Map;
> +import java.util.Set;
> +
> +import org.ofbiz.base.util.Debug;
> +import org.ofbiz.base.util.UtilMisc;
> +import org.ofbiz.entity.Delegator;
> +import org.ofbiz.entity.GenericEntityException;
> +import org.ofbiz.entity.GenericValue;
> +import org.ofbiz.entity.condition.EntityCondition;
> +import org.ofbiz.entity.model.DynamicViewEntity;
> +import org.ofbiz.entity.util.EntityFindOptions;
> +import org.ofbiz.entity.util.EntityListIterator;
> +import org.ofbiz.entity.util.EntityUtil;
> +
> +/**
> + * Used to setup various options for and subsequently execute entity queries.
> + *
> + * All methods to set options modify the EntityQuery instance then return 
> this modified object to allow method call chaining. It is
> + * important to note that this object is not immutable and is modified 
> internally, and returning EntityQuery is just a
> + * self reference for convenience.
> + *
> + * After a query the object can be further modified and then used to perform 
> another query if desired.
> + */
> +public class EntityQuery {
> +
> +public static final String module = EntityQuery.class.getName();
> +
> +private Delegator delegator;
> +private String entityName = null;
> +private DynamicViewEntity dynamicViewEntity = null;
> +private boolean useCache = false;
> +private EntityCondition whereEntityCondition = null;
> +private Set fieldsToSelect = null;
> +private List orderBy = null;
> +private Integer resultSetType = EntityFindOptions.TYPE_FORWARD_ONLY;
> +private Integer fetchSize = null;
> +private Integer maxRows = null;
> +private Boolean distinct = null;
> +private EntityCondition havingEntityCondition = null;
> +private boolean filterByDate = false;
> +private Timestamp filterByDateMoment;
> +
> +
> +
> +/** Construct an EntityQuery object for use against the specified 
> Delegator
> + * @param delegator - The delegator instance to use for the query
> + * @return Returns a new EntityQuery object
> + */
> +public static EntityQuery use(Delegator delegator) {
> +return new EntityQuery(delegator);
> +}
> +
> +/** Construct an EntityQuery object for use against the specified 
> Delegator
> + * @param delegator - The delegator instance to use for the query
> + * @return Re

Re: OFBiz and OHLOH (OpenHub.net

[Jacopo Cappellato]

it is an interesting idea but please remember that the code was not under the 
ASL2.0 at that time (if my memory serves) and I am not sure if we can do that.

Jacopo

On Sep 27, 2014, at 11:34 AM, Jacques Le Roux  
wrote:

> David, All,
> 
> I just thought about that. If ever someone can get a hand on the missing 
> part, we could create a read only repo under 
> https://svn.apache.org/repos/asf/ofbiz and link it to Open Hub
> 
> Jacques
> 
> Le 27/09/2014 10:55, Jacques Le Roux a écrit :
>> Today, I got the opportunity to write a short historical background at Quora
>> https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux
>> 
>> Jacques
>> 
>> Le 17/09/2014 08:55, Pierre Smits a écrit :
>>> Thanks for the update, David.
>>> 
>>> I will add the sourceforge reference of the duplicate to the main ohloh
>>> OFBiz reference and ask them to kill the duplicate. This will end the
>>> ambiguity.
>>> 
>>> 
>>> Pierre Smits
>>> 
>>> *ORRTIZ.COM *
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>> 
>>> On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:
>>> 
 A couple of corrections:
 
 1. during that time without data available OFBiz was hosted as a java.net
 project (not on Undersun infrastructure); looking there I can't find any
 sign of it though... unlike SourceForce maybe they clean out projects and
 get rid of data
 
 2. I did not create an OFBiz project on Openhub and have no admin access
 to either of the OFBiz listings there; they both show on my profile because
 my account is linked to the committer accounts for both
 
 It would be great to have this history, but not sure if the data is
 available. I may have an archive somewhere (just looked on my laptop and
 couldn't find it, so would have to search old disks), but to get it into
 Openhub/Ohloh it would probably need to be hosted somewhere. The reason I
 say I might have an archive is that IIRC when we moved from java.net to
 the ASF we got a full dump of the SVN repo from java.net. That may still
 exist somewhere...
 
 -David
 
 
 On Sep 16, 2014, at 1:16 PM, Jacques Le Roux 
 wrote:
 
> I found that David certainly created the OFBiz duplicate on Openhub
 https://www.openhub.net/accounts/jonesde/positions
> He has commits almost from the start there, but with a hole between mid
 2003 and the Apache Era (mid 2006)
> It would be good if we could merge the duplicate and add the missing
 commits in between
> Jacques
> 
> Le 16/09/2014 18:32, Jacques Le Roux a écrit :
>> You might find interesting stuff here
 https://web.archive.org/web/20060701213529/http://www.ofbiz.org/
>> Jacques
>> 
>> Le 16/09/2014 17:03, Pierre Smits a écrit :
>>> Yes they can.
>>> 
>>> Actually there is a duplicate that has a sourceforge repository
 referenced
>>> as well. That duplicate has commit data prior to aug 2003.
>>> 
>>> See: https://www.openhub.net/p/ofbiz
>>> 
>>> Pierre Smits
>>> 
>>> *ORRTIZ.COM *
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>> 
>>> On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
>>> jacques.le.r...@les7arts.com> wrote:
>>> 
 Also, I wonder if openhub is able to concatenate (time ordered) the
 content of 2 svn repos?
 
 Jacques
 
 Le 16/09/2014 13:58, Jacques Le Roux a écrit :
 
  I remember BJ had a copy, not sure he is still listening...
> Jacques
> 
> Le 16/09/2014 13:14, Pierre Smits a écrit :
> 
>> It would be good to have a complete and accurate history.
>> 
>> Pierre Smits
>> 
>> *ORRTIZ.COM *
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>> 
>> On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>> 
>>  I fear the pre Apache era svn server (Undersun consulting) is no
 longer
>>> available.
>>> But maybe someone has a copy and could set a svn server?
>>> 
>>> Jacques
>>> 
>>> Le 16/09/2014 13:05, Pierre Smits a écrit :
>>> 
>>>  The openhub maintainers have informed me that commit data between
 2003-8-31
 and  2006-07-01 is missing.
 
 Does anybody know what was used to commit changes to and is that
 resource
 still available to be included in the OHLOH (openhub) p

Re: OFBiz and OHLOH (OpenHub.net

[Jacques Le Roux]

David, All,

I just thought about that. If ever someone can get a hand on the missing part, we could create a read only repo under 
https://svn.apache.org/repos/asf/ofbiz and link it to Open Hub


Jacques

Le 27/09/2014 10:55, Jacques Le Roux a écrit :

Today, I got the opportunity to write a short historical background at Quora
https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux

Jacques

Le 17/09/2014 08:55, Pierre Smits a écrit :

Thanks for the update, David.

I will add the sourceforge reference of the duplicate to the main ohloh
OFBiz reference and ask them to kill the duplicate. This will end the
ambiguity.


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:


A couple of corrections:

1. during that time without data available OFBiz was hosted as a java.net
project (not on Undersun infrastructure); looking there I can't find any
sign of it though... unlike SourceForce maybe they clean out projects and
get rid of data

2. I did not create an OFBiz project on Openhub and have no admin access
to either of the OFBiz listings there; they both show on my profile because
my account is linked to the committer accounts for both

It would be great to have this history, but not sure if the data is
available. I may have an archive somewhere (just looked on my laptop and
couldn't find it, so would have to search old disks), but to get it into
Openhub/Ohloh it would probably need to be hosted somewhere. The reason I
say I might have an archive is that IIRC when we moved from java.net to
the ASF we got a full dump of the SVN repo from java.net. That may still
exist somewhere...

-David


On Sep 16, 2014, at 1:16 PM, Jacques Le Roux 
wrote:


I found that David certainly created the OFBiz duplicate on Openhub

https://www.openhub.net/accounts/jonesde/positions

He has commits almost from the start there, but with a hole between mid

2003 and the Apache Era (mid 2006)

It would be good if we could merge the duplicate and add the missing

commits in between

Jacques

Le 16/09/2014 18:32, Jacques Le Roux a écrit :

You might find interesting stuff here

https://web.archive.org/web/20060701213529/http://www.ofbiz.org/

Jacques

Le 16/09/2014 17:03, Pierre Smits a écrit :

Yes they can.

Actually there is a duplicate that has a sourceforge repository

referenced

as well. That duplicate has commit data prior to aug 2003.

See: https://www.openhub.net/p/ofbiz

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Also, I wonder if openhub is able to concatenate (time ordered) the
content of 2 svn repos?

Jacques

Le 16/09/2014 13:58, Jacques Le Roux a écrit :

  I remember BJ had a copy, not sure he is still listening...

Jacques

Le 16/09/2014 13:14, Pierre Smits a écrit :


It would be good to have a complete and accurate history.

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

  I fear the pre Apache era svn server (Undersun consulting) is no

longer

available.
But maybe someone has a copy and could set a svn server?

Jacques

Le 16/09/2014 13:05, Pierre Smits a écrit :

  The openhub maintainers have informed me that commit data between

2003-8-31
and  2006-07-01 is missing.

Does anybody know what was used to commit changes to and is that
resource
still available to be included in the OHLOH (openhub) page of

OFBiz?

Regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <

pierre.sm...@gmail.com

wrote:

   Hi all,


The OFBiz page at OHLOH had gotten outdated since the OHLOH
organisation
moved to openhub.net.

The stats have been updated, and can be found here:
https://www.openhub.net/p/Apache-OFBiz

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

[jira] [Resolved] (OFBIZ-4053) Implement an Entity Query Builder

[Scott Gray (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Gray resolved OFBIZ-4053.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed r1627940

Thanks to everyone who provided input here and on the dev mailing list.

> Implement an Entity Query Builder
> -
>
> Key: OFBIZ-4053
> URL: https://issues.apache.org/jira/browse/OFBIZ-4053
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Scott Gray
>Assignee: Scott Gray
> Fix For: Upcoming Branch
>
> Attachments: builder.patch, builder.patch, builder.patch
>
>
> As discussed on the dev list here: 
> http://ofbiz.markmail.org/thread/l6kiywqzfj656dhc
> Attached is an initial implementation of builder classes (of sorts) that make 
> use of method chaining in order to simplify use of the Delegator interface to 
> query entities.
> Rather than taking all possible query parameters into a single method as the 
> delegator does, this implementation instead builds a query through a 
> succession of distinct method calls.
> A simple example:
> {code}
> // Using the Delegator interface directly
> eli = delegator.find("FinAccountTrans", condition, null, null, 
> UtilMisc.toList("-transactionDate"), null);
> // Using the new implementation
> eli = 
> EntityBuilderUtil.list(delegator).from("FinAccountTrans").where(condition).orderBy("-transactionDate").iterator();
> {code}
> A more complex example:
> {code}
> // Delegator
> EntityCondition queryConditionsList = 
> EntityCondition.makeCondition(allConditions, EntityOperator.AND);
> EntityFindOptions options = new EntityFindOptions(true, 
> EntityFindOptions.TYPE_SCROLL_INSENSITIVE, 
> EntityFindOptions.CONCUR_READ_ONLY, true);
> options.setMaxRows(viewSize * (viewIndex + 1));
> EntityListIterator iterator = delegator.find("OrderHeader", 
> queryConditionsList, null, null, UtilMisc.toList("orderDate DESC"), options);
> // becomes
> EntityListIterator iterator = EntityBuilderUtil.list(delegator).distinct()
>
> .from("OrderHeader")
>
> .where(allConditions)
>
> .orderBy("orderDate DESC")
>
> .maxRows(viewSize * (viewIndex + 1))
>
> .cursorScrollInsensitive()
>.iterator();
> {code}
> A couple of issues with the implementation so far that I'm not entirely happy 
> with:
> - I'm not so sure that I like EntityBuilderUtil.list(delegator) in place of 
> something like EntityList.use(delegator).  The latter requires less typing 
> and I think is more intuitive than typing EntityBuilderUtil because of its 
> similarities to the corresponding minilang method calls, I actually kept 
> having trouble remembering what it was called when converting some delegator 
> calls over.  It also requires a little more typing (16-17 characters vs. 
> 12-13), not a big deal but every little bit helps with what would be a very 
> commonly used class.
> - I'm struggling to see the point of having the GenericQueryBuilder 
> interface, the two classes share very little in the way of API and its use 
> seems a little superfluous to me.
> Opinions on the above points or anything else to do with the implementation 
> are most welcome.  I'd like to get the API locked down (and hopefully some 
> javadocs in place) before committing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: OFBiz and OHLOH (OpenHub.net

[Jacques Le Roux]

Today, I got the opportunity to write a short historical background at Quora
https://www.quora.com/How-long-has-Apache-OFBiz-aka-Open-For-Business-been-around/answer/Jacques-Le-Roux

Jacques

Le 17/09/2014 08:55, Pierre Smits a écrit :

Thanks for the update, David.

I will add the sourceforge reference of the duplicate to the main ohloh
OFBiz reference and ask them to kill the duplicate. This will end the
ambiguity.


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Sep 17, 2014 at 7:28 AM, David E. Jones  wrote:


A couple of corrections:

1. during that time without data available OFBiz was hosted as a java.net
project (not on Undersun infrastructure); looking there I can't find any
sign of it though... unlike SourceForce maybe they clean out projects and
get rid of data

2. I did not create an OFBiz project on Openhub and have no admin access
to either of the OFBiz listings there; they both show on my profile because
my account is linked to the committer accounts for both

It would be great to have this history, but not sure if the data is
available. I may have an archive somewhere (just looked on my laptop and
couldn't find it, so would have to search old disks), but to get it into
Openhub/Ohloh it would probably need to be hosted somewhere. The reason I
say I might have an archive is that IIRC when we moved from java.net to
the ASF we got a full dump of the SVN repo from java.net. That may still
exist somewhere...

-David


On Sep 16, 2014, at 1:16 PM, Jacques Le Roux 
wrote:


I found that David certainly created the OFBiz duplicate on Openhub

https://www.openhub.net/accounts/jonesde/positions

He has commits almost from the start there, but with a hole between mid

2003 and the Apache Era (mid 2006)

It would be good if we could merge the duplicate and add the missing

commits in between

Jacques

Le 16/09/2014 18:32, Jacques Le Roux a écrit :

You might find interesting stuff here

https://web.archive.org/web/20060701213529/http://www.ofbiz.org/

Jacques

Le 16/09/2014 17:03, Pierre Smits a écrit :

Yes they can.

Actually there is a duplicate that has a sourceforge repository

referenced

as well. That duplicate has commit data prior to aug 2003.

See: https://www.openhub.net/p/ofbiz

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 4:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Also, I wonder if openhub is able to concatenate (time ordered) the
content of 2 svn repos?

Jacques

Le 16/09/2014 13:58, Jacques Le Roux a écrit :

  I remember BJ had a copy, not sure he is still listening...

Jacques

Le 16/09/2014 13:14, Pierre Smits a écrit :


It would be good to have a complete and accurate history.

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Sep 16, 2014 at 1:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

  I fear the pre Apache era svn server (Undersun consulting) is no

longer

available.
But maybe someone has a copy and could set a svn server?

Jacques

Le 16/09/2014 13:05, Pierre Smits a écrit :

  The openhub maintainers have informed me that commit data between

2003-8-31
and  2006-07-01 is missing.

Does anybody know what was used to commit changes to and is that
resource
still available to be included in the OHLOH (openhub) page of

OFBiz?

Regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Sat, Sep 13, 2014 at 11:25 AM, Pierre Smits <

pierre.sm...@gmail.com

wrote:

   Hi all,


The OFBiz page at OHLOH had gotten outdated since the OHLOH
organisation
moved to openhub.net.

The stats have been updated, and can be found here:
https://www.openhub.net/p/Apache-OFBiz

Best regards,

Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: svn commit: r1338394 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java

[Jacopo Cappellato]

On Sep 27, 2014, at 10:12 AM, Adrian Crum  
wrote:

> Yes. To be clear:
> 
> 
> 
> someField is an expression, and
> 
> 
> 
> ${result} is a nested expression (an expression within an expression).

Ok, this was my understanding as well. Based on this, the fix you did in 
1338394 *should* make it possible to set:



and so the documentation on the xsd grammar should be updated.
However the code in commit 1338394 doesn't work as the test I have committed 
recently demonstrate.

> 
> I can take another look at the Mini-language code next weekend if you are 
> willing to wait until then.

This would be great, thank you. In the meantime I have fixed the code that was 
using this feature to prevent errors, so I don't have any rush. Take all the 
time you need.

Regards,

Jacopo

> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/26/2014 4:09 PM, Jacopo Cappellato wrote:
>> 
>> On Sep 26, 2014, at 5:02 PM, Adrian Crum 
>>  wrote:
>> 
>>> The change should be self-explanatory. If the attribute contains a nested 
>>> expression, then use FSE to expand the nested expression before using FMA 
>>> to retrieve the value.
>> 
>> Like this:
>> 
>> 
>> 
>> ?
>> 
>>> 
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>> 
>>> On 9/26/2014 1:11 PM, Jacopo Cappellato wrote:
 Adrian,
 
 this is still related to the issue related to the field-to-result 
 operation with an ${} value in the result name.
 This is the modification you did a couple of years ago trying to fix the 
 issue I reported at that time.
 Could you help me to understand what is the effect of this enhancement? An 
 example of intended usage of the  element would be 
 enough.
 
 Jacopo
 
 
 
 On May 14, 2012, at 10:49 PM, adri...@apache.org wrote:
 
> Author: adrianc
> Date: Mon May 14 20:49:01 2012
> New Revision: 1338394
> 
> URL: http://svn.apache.org/viewvc?rev=1338394&view=rev
> Log:
> Fixed a bug in Mini-language  element where nested 
> expressions were not evaluated correctly.
> 
> Modified:
>
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
> 
> Modified: 
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java?rev=1338394&r1=1338393&r2=1338394&view=diff
> ==
> --- 
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
>  (original)
> +++ 
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
>  Mon May 14 20:49:01 2012
> @@ -28,7 +28,7 @@ import org.ofbiz.minilang.method.MethodO
> import org.w3c.dom.Element;
> 
> /**
> - * Copies a field to a service OUT attribute.
> + * Copies a field to the simple-method result Map.
>  */
> public final class FieldToResult extends MethodOperation {
> 
> @@ -58,9 +58,13 @@ public final class FieldToResult extends
> public boolean exec(MethodContext methodContext) throws 
> MiniLangException {
> Object fieldVal = this.fieldFma.get(methodContext.getEnvMap());
> if (fieldVal != null) {
> -// FIXME: Needs special handling for nested expressions.
> -// The result attribute might contain a reference to an 
> environment (not result Map) variable.
> -this.resultFma.put(methodContext.getResults(), fieldVal);
> +if (this.resultFma.containsNestedExpression()) {
> +String expression = (String) 
> this.resultFma.get(methodContext.getEnvMap());
> +FlexibleMapAccessor resultFma = 
> FlexibleMapAccessor.getInstance(expression);
> +resultFma.put(methodContext.getResults(), fieldVal);
> +} else {
> +this.resultFma.put(methodContext.getResults(), fieldVal);
> +}
> }
> return true;
> }
> 
> 
 
>> 

Re: svn commit: r1338394 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java

[Adrian Crum]

Yes. To be clear:



someField is an expression, and



${result} is a nested expression (an expression within an expression).

I can take another look at the Mini-language code next weekend if you 
are willing to wait until then.


Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2014 4:09 PM, Jacopo Cappellato wrote:


On Sep 26, 2014, at 5:02 PM, Adrian Crum  
wrote:


The change should be self-explanatory. If the attribute contains a nested 
expression, then use FSE to expand the nested expression before using FMA to 
retrieve the value.


Like this:



?



Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2014 1:11 PM, Jacopo Cappellato wrote:

Adrian,

this is still related to the issue related to the field-to-result operation 
with an ${} value in the result name.
This is the modification you did a couple of years ago trying to fix the issue 
I reported at that time.
Could you help me to understand what is the effect of this enhancement? An example of 
intended usage of the  element would be enough.

Jacopo



On May 14, 2012, at 10:49 PM, adri...@apache.org wrote:


Author: adrianc
Date: Mon May 14 20:49:01 2012
New Revision: 1338394

URL: http://svn.apache.org/viewvc?rev=1338394&view=rev
Log:
Fixed a bug in Mini-language  element where nested expressions 
were not evaluated correctly.

Modified:

ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java

Modified: 
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java?rev=1338394&r1=1338393&r2=1338394&view=diff
==
--- 
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
 (original)
+++ 
ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/serviceops/FieldToResult.java
 Mon May 14 20:49:01 2012
@@ -28,7 +28,7 @@ import org.ofbiz.minilang.method.MethodO
import org.w3c.dom.Element;

/**
- * Copies a field to a service OUT attribute.
+ * Copies a field to the simple-method result Map.
  */
public final class FieldToResult extends MethodOperation {

@@ -58,9 +58,13 @@ public final class FieldToResult extends
 public boolean exec(MethodContext methodContext) throws MiniLangException {
 Object fieldVal = this.fieldFma.get(methodContext.getEnvMap());
 if (fieldVal != null) {
-// FIXME: Needs special handling for nested expressions.
-// The result attribute might contain a reference to an 
environment (not result Map) variable.
-this.resultFma.put(methodContext.getResults(), fieldVal);
+if (this.resultFma.containsNestedExpression()) {
+String expression = (String) 
this.resultFma.get(methodContext.getEnvMap());
+FlexibleMapAccessor resultFma = 
FlexibleMapAccessor.getInstance(expression);
+resultFma.put(methodContext.getResults(), fieldVal);
+} else {
+this.resultFma.put(methodContext.getResults(), fieldVal);
+}
 }
 return true;
 }

Re: Welcome Nicolas Malin as new committer!

[Adrian Crum]

Congratulations Nicolas! Welcome aboard!

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2014 5:55 PM, Jacopo Cappellato wrote:

The OFBiz PMC has invited Nicolas to become a new committer and he has accepted 
the new role: Nicolas is a skilled developer and he knows the OFBiz codebase 
quite well; but most of all Nicolas
is committed to the project and has always showed a positive and collaborative 
attitude. Please welcome him onboard!

Thank you

Jacopo