[jira] [Closed] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6458. -- Resolution: Done This was finalised by Adrian at r1684216 for StringUtil and r1684217 for the Generics in ECJ. Upgrade OFBiz to Java JDK 8 --- Key: OFBIZ-6458 URL: https://issues.apache.org/jira/browse/OFBIZ-6458 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Critical Labels: java, jdk, jdk8, upgrade Fix For: Upcoming Branch Attachments: OFBIZ-6458-01-fix-test-errors.patch, OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, OFBIZ-6458-04-update-README.patch The following will be tracked through this JIRA: - upgrade the framework to JDK 8 and fix any errors - make sure that ./ant clean-all load-demo run-tests will run after the upgrade - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
Hi Taher, All, This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) Jacques Le 08/06/2015 12:56, Taher Alkhateeb a écrit : Hi Everyone, May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: 1- actually upgrade to JDK 8 (by applying the patches in JIRA). 2- commit functional and Java 8 code into trunk going forward . 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . The patches and the code to move to JDK 8 are ready and tested with at least ./ant clean-all load-demo run-tests on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 Taher Alkhateeb
[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591770#comment-14591770 ] Jacques Le Roux commented on OFBIZ-5403: In France it's only about tax rates. But you have also to report apart the incomes you have in other countries where VAT does not apply (like Switzerland) or those where it's compensate (other countries of the European Union). Implement separate glAccounts per TaxAuthority-ProductCategory combination -- Key: OFBIZ-5403 URL: https://issues.apache.org/jira/browse/OFBIZ-5403 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Labels: Tax,, accounting, transactions In current setup only 1 glAccount can be defined for each combination of TaxGeo, TaxAuthority and Internal Organization. However, it is common that multiple tax rates exist per TaxGeo (e.g. VAT rates of 0, 6 and 21% for The Netherlands) and it also customary to report separately for sales and purchasing per tax rate and audit registered tax bookings vs sales and purchases per period. As such implementing a glAccount per TaxGeo-TaxAuth-IntOrganisation-ProductCategory, and upgrading applicable transaction processing services would facilitate the above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591797#comment-14591797 ] Taher Alkhateeb commented on OFBIZ-6458: Hi Jacques, Patches 3 and 4 which apply the actual upgrade to JDK 8 are not yet applied. Shouldn't this JIRA be closed after applying them once we get community consensus? Upgrade OFBiz to Java JDK 8 --- Key: OFBIZ-6458 URL: https://issues.apache.org/jira/browse/OFBIZ-6458 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Critical Labels: java, jdk, jdk8, upgrade Fix For: Upcoming Branch Attachments: OFBIZ-6458-01-fix-test-errors.patch, OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, OFBIZ-6458-04-update-README.patch The following will be tracked through this JIRA: - upgrade the framework to JDK 8 and fix any errors - make sure that ./ant clean-all load-demo run-tests will run after the upgrade - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6398) Print Pick Sheet PDF using orderId.pdf as attachement name.
[ https://issues.apache.org/jira/browse/OFBIZ-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592007#comment-14592007 ] Michael Brohl commented on OFBIZ-6398: -- I'm going to implement Christian's suggestion to rename it to PickSheet-orderId.pdf if no one is against it. Print Pick Sheet PDF using orderId.pdf as attachement name. --- Key: OFBIZ-6398 URL: https://issues.apache.org/jira/browse/OFBIZ-6398 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 14.12, Trunk Reporter: Deepak Dixit Assignee: Michael Brohl Priority: Minor Print Pick Sheet PDF using orderId.pdf as attachement name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592187#comment-14592187 ] Adrian Crum commented on OFBIZ-6516: I don't think buttontext is a valid CSS class: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms --- Key: OFBIZ-6516 URL: https://issues.apache.org/jira/browse/OFBIZ-6516 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Affects Versions: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch Environment: Ofbiz Web UI Reporter: Gavin Mabie Priority: Minor Icons can be used to great effect to enhance both the user experience and as well as the look-and-feel of an application. In Ofbiz this is facilitated by using meaningful styles name in the widget-style attribute. Examples are buttontext create, buttontext delete/remove, buttontext update. That takes care of the basic CRUD actions. The widget-style attribute is used by front-end designers (on the presentation layer) to create their own designs via macro libraries, stylesheets and javascript files. It will be useful for designers if widget-styles are defined in a standard way in widget definitions (*forms.xml, *menu.xml etc). To set this process in motion I propose the following: 1. All buttontext widget-style attributes should have a meaningful additional class which describes the action linked to the button, i.e create, update, delete, refresh - depending on the action. 2. Add missing descriptive classes like copy, print, view, download, save etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592357#comment-14592357 ] Jacques Le Roux commented on OFBIZ-6458: Right, Taher but it depends on a vote before applying these patches. We could actually ask for a consensus rather than a vote. So I reopen and we wait for a vote or a community consensus. Upgrade OFBiz to Java JDK 8 --- Key: OFBIZ-6458 URL: https://issues.apache.org/jira/browse/OFBIZ-6458 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Critical Labels: java, jdk, jdk8, upgrade Fix For: Upcoming Branch Attachments: OFBIZ-6458-01-fix-test-errors.patch, OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, OFBIZ-6458-04-update-README.patch The following will be tracked through this JIRA: - upgrade the framework to JDK 8 and fix any errors - make sure that ./ant clean-all load-demo run-tests will run after the upgrade - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-6458: Upgrade OFBiz to Java JDK 8 --- Key: OFBIZ-6458 URL: https://issues.apache.org/jira/browse/OFBIZ-6458 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Critical Labels: java, jdk, jdk8, upgrade Fix For: Upcoming Branch Attachments: OFBIZ-6458-01-fix-test-errors.patch, OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch, OFBIZ-6458-04-update-README.patch The following will be tracked through this JIRA: - upgrade the framework to JDK 8 and fix any errors - make sure that ./ant clean-all load-demo run-tests will run after the upgrade - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
Ok for me, move to the height level :) Nicolas Le 18/06/2015 21:36, Jacques Le Roux a écrit : BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at OFBIZ-6458 and then allow to commit Java 8 specific code. Though if we want the trunk demo and build to work we need to make some infra changes before. I will look at it this weekend, nothing prevents us to already run the trunk with Java 8. Jacques Le 18/06/2015 15:09, Jacques Le Roux a écrit : Hi Taher, All, This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) Jacques Le 08/06/2015 12:56, Taher Alkhateeb a écrit : Hi Everyone, May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: 1- actually upgrade to JDK 8 (by applying the patches in JIRA). 2- commit functional and Java 8 code into trunk going forward . 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . The patches and the code to move to JDK 8 are ready and tested with at least ./ant clean-all load-demo run-tests on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 Taher Alkhateeb
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
All tests pass from my side on Debian Linux with JDK 8 U 45 after applying the commits in OFBIZ-6458 and thanks to Adrian we have all other issues ironed out. Taher Alkhateeb On Jun 18, 2015 10:48 PM, Nicolas Malin nicolas.ma...@nereide.fr wrote: Ok for me, move to the height level :) Nicolas Le 18/06/2015 21:36, Jacques Le Roux a écrit : BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at OFBIZ-6458 and then allow to commit Java 8 specific code. Though if we want the trunk demo and build to work we need to make some infra changes before. I will look at it this weekend, nothing prevents us to already run the trunk with Java 8. Jacques Le 18/06/2015 15:09, Jacques Le Roux a écrit : Hi Taher, All, This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) Jacques Le 08/06/2015 12:56, Taher Alkhateeb a écrit : Hi Everyone, May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: 1- actually upgrade to JDK 8 (by applying the patches in JIRA). 2- commit functional and Java 8 code into trunk going forward . 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . The patches and the code to move to JDK 8 are ready and tested with at least ./ant clean-all load-demo run-tests on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 Taher Alkhateeb
Re: [Vote] upgrading OFBiz to JDK 8 on trunk
BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at OFBIZ-6458 and then allow to commit Java 8 specific code. Though if we want the trunk demo and build to work we need to make some infra changes before. I will look at it this weekend, nothing prevents us to already run the trunk with Java 8. Jacques Le 18/06/2015 15:09, Jacques Le Roux a écrit : Hi Taher, All, This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for internal Java auto-completion), we should do a vote again about allowing to use Java 8 new features in trunk. I can take care of the infrastructure upgrade... Note: I just successfully ran the tests again with jdk1.8.0_31 on Win 7 (trunk HEAD) Jacques Le 08/06/2015 12:56, Taher Alkhateeb a écrit : Hi Everyone, May I suggest a vote in reference to the email thread and JIRA mentioned below on what follows: 1- actually upgrade to JDK 8 (by applying the patches in JIRA). 2- commit functional and Java 8 code into trunk going forward . 3- upgrade infrastructure (demo, build, ...) to host OFBiz on JDK 8 . The patches and the code to move to JDK 8 are ready and tested with at least ./ant clean-all load-demo run-tests on JDK 8u45 and all 882 tests pass from my side. I also logged into the system and navigated to a few random screens just to run some smoke tests randomly and I did not encounter any problems. Mail Thread: http://markmail.org/message/wbomdrdwl77yntx4 JIRA: https://issues.apache.org/jira/browse/OFBIZ-6458 Taher Alkhateeb
[jira] [Created] (OFBIZ-6515) partymgr/control/EditPartyRelationships add odd-row=alternate-row for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI
Christian Carlow created OFBIZ-6515: --- Summary: partymgr/control/EditPartyRelationships add odd-row=alternate-row for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI Key: OFBIZ-6515 URL: https://issues.apache.org/jira/browse/OFBIZ-6515 Project: OFBiz Issue Type: Improvement Components: themes Affects Versions: Trunk Reporter: Christian Carlow Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6515) partymgr/control/EditPartyRelationships add odd-row=alternate-row for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI
[ https://issues.apache.org/jira/browse/OFBIZ-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6515: Attachment: OFBIZ-6515.patch partymgr/control/EditPartyRelationships add odd-row=alternate-row for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI Key: OFBIZ-6515 URL: https://issues.apache.org/jira/browse/OFBIZ-6515 Project: OFBiz Issue Type: Improvement Components: themes Affects Versions: Trunk Reporter: Christian Carlow Priority: Minor Attachments: OFBIZ-6515.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthoritiy-ProductCategory combination
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591477#comment-14591477 ] Paul Foxworthy commented on OFBIZ-5403: --- I have to agree this is important. In Australia, you have to report some tax collections separately from others, e.g. the Wine Equalisation Tax is reported separately from the Goods and Services Tax. Implement separate glAccounts per TaxAuthoritiy-ProductCategory combination --- Key: OFBIZ-5403 URL: https://issues.apache.org/jira/browse/OFBIZ-5403 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Labels: Tax,, accounting, transactions In current setup only 1 glAccount can be defined for each combination of TaxGeo, TaxAuthority and Internal Organization. However, it is common that multiple tax rates exist per TaxGeo (e.g. VAT rates of 0, 6 and 21% for The Netherlands) and it also customary to report separately for sales and purchasing per tax rate and audit registered tax bookings vs sales and purchases per period. As such implementing a glAccount per TaxGeo-TaxAuth-IntOrganisation-ProductCategory, and upgrading applicable transaction processing services would facilitate the above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5403: -- Summary: Implement separate glAccounts per TaxAuthority-ProductCategory combination (was: Implement separate glAccounts per TaxAuthoritiy-ProductCategory combination) Implement separate glAccounts per TaxAuthority-ProductCategory combination -- Key: OFBIZ-5403 URL: https://issues.apache.org/jira/browse/OFBIZ-5403 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Labels: Tax,, accounting, transactions In current setup only 1 glAccount can be defined for each combination of TaxGeo, TaxAuthority and Internal Organization. However, it is common that multiple tax rates exist per TaxGeo (e.g. VAT rates of 0, 6 and 21% for The Netherlands) and it also customary to report separately for sales and purchasing per tax rate and audit registered tax bookings vs sales and purchases per period. As such implementing a glAccount per TaxGeo-TaxAuth-IntOrganisation-ProductCategory, and upgrading applicable transaction processing services would facilitate the above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5163) Tax calculated on unit price before adjustments
[ https://issues.apache.org/jira/browse/OFBIZ-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5163: -- Labels: tax (was: ) Tax calculated on unit price before adjustments --- Key: OFBIZ-5163 URL: https://issues.apache.org/jira/browse/OFBIZ-5163 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Trunk Reporter: Paul Foxworthy Assignee: Paul Foxworthy Labels: tax Attachments: OFBIZ-5163.patch, OFBIZ-5163_Edit.patch Some taxes cut in at a minimum item price. A promotional adjustment can lower the price the customer is paying, so they should not have to pay any tax. However, the tax is being calculated on the base item price, before any promotional adjustment. r1449615 was a partial fix, but only when the order quantity is one. In the more complex situation where the quantity is greater than one, at present the tax calculation does not have the information it needs. All it has is the base unit price for the item (itemPrice), and the total amount for the item (itemAmount, which is itemPrice * quantity - adjustments). Here's what I think needs to happen. 1. We need to define two categories of item adjustments: - those which modify the price, including promotional pricing and discounts - adjustments for additional services such as shipping, an extended warranty and so on. The first category should be combined with the product price before tax calculations are done. The second category may need to be taxed separately. So a new attribute should be added to the OrderAdjustment entity to say which it is. 2. An additional list of data needs to be supplied to the tax calculation, a list of adjusted unit prices with promotional discounts and any other adjustments in the first category above. The tax calculation would, of course, use the adjusted unit price, so the change at https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java?hb=true#to215 won't be needed any more. If we do these, there would be no need for the calcTaxAfterPromotion attribute. In effect, it would always apply, for adjustments in category 1. If anyone didn't want that behaviour, all they would need to do is define an adjustment in category 2, not 1. This issue was found and worked on by Tom at ANTWebsystems, thanks for your help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5584) VAT on Purchase Orders
[ https://issues.apache.org/jira/browse/OFBIZ-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5584: -- Labels: accounting tax (was: ) VAT on Purchase Orders -- Key: OFBIZ-5584 URL: https://issues.apache.org/jira/browse/OFBIZ-5584 Project: OFBiz Issue Type: New Feature Components: order Reporter: David Hughes-Owens Priority: Minor Labels: accounting, tax I have a general query regarding charging VAT on supplier purchase orders. Some suppliers are other group companies and therefore we do not wish to show VAT. Some suppliers are external and VAT is applicable. How does Ofbiz deal with this? I thought it might be on the supplier section of the product setup, but appears not to be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-366) Separate VAT from Sales Tax
[ https://issues.apache.org/jira/browse/OFBIZ-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-366: - Labels: accounting tax (was: ) Separate VAT from Sales Tax --- Key: OFBIZ-366 URL: https://issues.apache.org/jira/browse/OFBIZ-366 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: David E. Jones Labels: accounting, tax Fix For: Trunk We need to separate VAT from Sales Tax. The main reason is that VAT taxe is a very important type of tax in EU (and I guess on some other places) but not in US. An example of problems that arise if we not distinguish them is shown in OFBIZ-362. There we see that VAT in EU has specific mandatory constraints. This is a huge work I guess. We will see from futur if it's really needed... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1686116 - in /ofbiz/trunk: framework/common/widget/ framework/webtools/widget/ framework/widget/dtd/ framework/widget/src/org/ofbiz/widget/artifact/ framework/widget/src/org/ofbiz/wid
Good job! I wonder though if we are not missing a definitive reference for widgets like we have https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference +1 This will an ideal opportunity to standardise some conventions with the view to facilitate Theme Development and to promote the use of icons in Ofbiz. We have already seen with the Bootstrap initiative that iconisation can be achieved fairly easily - provided that the original widgets are defined properly. Take for example the widget-style attribute, specifically the buttontext style. Using buttontext create, buttontext delete, buttontext refresh and not just supply buttontext makes it easy for designers to employ vector-based icons in their designs. Where possible the widget-style attribute should be accompanied by a meaningful descriptor beyond the ones already used such as update, download, save, print, copy etc. I will create a separate jira where this issue can be further explored by those interested. Gavin On Thu, Jun 18, 2015 at 6:21 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: I very like it thanks Nicolas! I'd also like to thanks Adam for the prior idea and effort on the grid element and Christian for pushing things :) I wonder though if we are not missing a definitive reference for widgets like we have https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference It could be built from the auto-completion, with an opportunity to complete and update it (the documentation in the XSDs is a must to get more collaboration from new comers on this) Kudos guys, we are heading in the right direction. I mean to replace as much as possible FTL in backend, and even ecommerce when possible... ;) OK seems that I have more new things to learn/review Jacques Le 17/06/2015 23:50, nma...@apache.org a écrit : Author: nmalin Date: Wed Jun 17 21:50:27 2015 New Revision: 1686116 URL: http://svn.apache.org/r1686116 Log: Improve widget-form with four elements : include-form, include-grid, include-menu, include-screen to offert more flexibility to define complex display. The main purpose is to complete the screen widget capacity to replace ftl screen. With these elements, example component have a new FindExample search screen to select the display list type with a example of : * include-form : list examples with their features * include-screen : list examples with their items * include-grid : list examples with their status history The element include-menu is present on FindUtilCache screen. Also a new CommonInlineBarMenu menu type to display menu with specific purpose (in-line) is now present and with this logic adding in-line-bar css class on themes thomawak and flatgrey. This patch is combinate Issues : * OFBIZ-6502 Add support for form/grid embedding within grids * OFBIZ-6501 Add support for screen embedding inside grids * OFBIZ-6404 Allow form/grid widget hyperlinks to be grouped into a single column sub-tasks of master issue OFBIZ-6314 Widget Refactoring - Placeholder issue Thanks to Christian and Adrian for their time Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml ofbiz/trunk/framework/webtools/widget/CacheForms.xml ofbiz/trunk/framework/webtools/widget/Menus.xml ofbiz/trunk/framework/widget/dtd/widget-form.xsd ofbiz/trunk/framework/widget/src/org/ofbiz/widget/artifact/ArtifactInfoGatherer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/FieldInfo.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/ModelFieldVisitor.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/ModelFormField.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/ModelFormFieldBuilder.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/XmlWidgetFieldVisitor.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/fo/FoFormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/html/HtmlFormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/text/TextFormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/xml/XmlFormRenderer.java ofbiz/trunk/specialpurpose/example/data/ExampleDemoData.xml ofbiz/trunk/specialpurpose/example/widget/example/CommonScreens.xml ofbiz/trunk/specialpurpose/example/widget/example/ExampleForms.xml ofbiz/trunk/specialpurpose/example/widget/example/ExampleScreens.xml
[jira] [Created] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms
Gavin Mabie created OFBIZ-6516: -- Summary: Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms Key: OFBIZ-6516 URL: https://issues.apache.org/jira/browse/OFBIZ-6516 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Affects Versions: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch Environment: Ofbiz Web UI Reporter: Gavin Mabie Priority: Minor Icons can be used to great effect to enhance both the user experience and as well as the look-and-feel of an application. In Ofbiz this is facilitated by using meaningful styles name in the widget-style attribute. Examples are buttontext create, buttontext delete/remove, buttontext update. That takes care of the basic CRUD actions. The widget-style attribute is used by front-end designers (on the presentation layer) to create their own designs via macro libraries, stylesheets and javascript files. It will be useful for designers if widget-styles are defined in a standard way in widget definitions (*forms.xml, *menu.xml etc). To set this process in motion I propose the following: 1. All buttontext widget-style attributes should have a meaningful additional class which describes the action linked to the button, i.e create, update, delete, refresh - depending on the action. 2. Add missing descriptive classes like copy, print, view, download, save etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
