[jira] [Assigned] (OFBIZ-7535) Broken page renders while click on Submit button
[ https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta reassigned OFBIZ-7535: --- Assignee: Divesh Dutta > Broken page renders while click on Submit button > > > Key: OFBIZ-7535 > URL: https://issues.apache.org/jira/browse/OFBIZ-7535 > Project: OFBiz > Issue Type: Bug > Components: party >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta >Priority: Minor > > Steps to reproduce: > 1. Go to party manager. > 2. Find party Company and navigate to Employment Application tab. > 3. Now if there is no existing application and Submit button visible then > click on submit button. > 4. Broken page renders with error message " > :ERROR MESSAGE: > org.ofbiz.webapp.event.EventHandlerException: No rows to process" > Ideally system should hide submit button if there is no application to > process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343805#comment-15343805 ] Pierre Smits commented on OFBIZ-7529: - If that is part of the POS solution, it should move into the special purpose component. > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item
[ https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343803#comment-15343803 ] Pierre Smits commented on OFBIZ-7533: - The lot management solution in OFBiz is flawed. See https://issues.apache.org/jira/browse/OFBIZ-5704 > Not able to set new Lot Id to existing inventory item > - > > Key: OFBIZ-7533 > URL: https://issues.apache.org/jira/browse/OFBIZ-7533 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: II_LOT.png > > > When any new lot is assigned to exiting inventory item then it ends up > throwing foreign key constraint. > We could allow it by creating first new lot (if its not found already > existent in DB) and then associate the same with given inventory item. (Also > currently i couldn't find any screen to create new lot in given facility) > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7526) View Quote screen is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7526. -- Resolution: Fixed Assignee: Jacques Le Roux Fix Version/s: Upcoming Branch Well spotted Pritam, Fixed at revision: 1749634 > View Quote screen is broken > --- > > Key: OFBIZ-7526 > URL: https://issues.apache.org/jira/browse/OFBIZ-7526 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: Upcoming Branch > > > Steps to regenerate: > 1) Login to ordermgr. > 2) Click on Quotes and find quotes. > 3) Click on any quote in the search result to go to the overview screen. > You can see screen is broken with error: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ObjectType > |W| The specified type [] is not a valid class or a known special type, > may see more errors later because of this: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 > |AbstractModelCondition|W| Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported. > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ModelScreen >|E| Error rendering screen > [component://common/widget/CommonScreens.xml#GlobalDecorator]: > java.lang.IllegalArgumentException: Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported.. Rolling back transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343780#comment-15343780 ] Jacques Le Roux commented on OFBIZ-7061: Thanks James, I did not spot it as well, we should indeed not have used targetNamespace (should only be used in schema) instead of xsi:schemaLocation. BTW all files were concerned, not only menu. Fixed at r1749634. > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: XML autocompletion issue
Hi All, Fixed at revision: 1749634 We should not have used targetNamespace (should only be used in schema) instead of xsi:schemaLocation. Jacques Le 21/06/2016 à 22:53, Jacques Le Roux a écrit : Hi, I just noticed that we seem to have an issue with XML autocompletion in files concerned (used by the Compound Widget feature) since I committed today the last changes for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 Before reverting anything I will tomorrow check why we have this issue Thanks for your patience Jacques
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343767#comment-15343767 ] Jacques Le Roux commented on OFBIZ-7519: Thanks for your comprehension Pranay :) > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7535) Broken page renders while click on Submit button
Ankush Upadhyay created OFBIZ-7535: -- Summary: Broken page renders while click on Submit button Key: OFBIZ-7535 URL: https://issues.apache.org/jira/browse/OFBIZ-7535 Project: OFBiz Issue Type: Bug Components: party Reporter: Ankush Upadhyay Priority: Minor Steps to reproduce: 1. Go to party manager. 2. Find party Company and navigate to Employment Application tab. 3. Now if there is no existing application and Submit button visible then click on submit button. 4. Broken page renders with error message " :ERROR MESSAGE: org.ofbiz.webapp.event.EventHandlerException: No rows to process" Ideally system should hide submit button if there is no application to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Important Changes to Trunk and Use of Ant & Gradle
On Tue, Jun 21, 2016 at 11:30 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > - gen-kek >> > > Never used it, but Jacopo put it in recent > Actually, I didn't create it: it has been created long ago by Adam; but I edited it to work with Shiro. In my opinion it can be dropped and possibly re-implemented in a cleaner way in the future if/when needed. Jacopo
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343754#comment-15343754 ] Pranay Pandey commented on OFBIZ-7519: -- Sure thing Jacques, please take your time. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7521) Refer to objects by their interfaces rather than class when instantiating Collection implementation classes in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343749#comment-15343749 ] Pranay Pandey commented on OFBIZ-7521: -- +1 > Refer to objects by their interfaces rather than class when instantiating > Collection implementation classes in Java files > --- > > Key: OFBIZ-7521 > URL: https://issues.apache.org/jira/browse/OFBIZ-7521 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Divesh Dutta >Assignee: Divesh Dutta > > We should favor the use of interfaces rather than class to refer to objects > where ever possible. It is entirely appropriate to refer an object by a class > rather than an interface if no appropriate interface exists. But wherever > appropriate interface exists we should use them to refer to objects. > For example: > {code} > ArrayList itemsExprs = new ArrayList(); > {code} > should be written as : > {code} > List itemsExprs = new ArrayList(); > {code} > Writing this way will make code more flexible . If you want to switch > implementations, all you have to do is change the class name in the > constructor and all surrounding code will continue to work. > This is parent ticket, we will create logical tasks for each component and > collection class to improve this code. There are very less such occurrences > and most of the code is written following the best practice. But we could > improve the code which has not followed this best practice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343748#comment-15343748 ] Deepak Dixit commented on OFBIZ-7511: - If we can enhance form rendering then why go and add required filed on each form? If form uses auto-fields service then its done by default, and if form not using auto-fields service then we can enhance form widget. I am done with my part :) If still it make sense to go and add required-field on each form than its fine I don't have any concern. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343744#comment-15343744 ] Divesh Dutta commented on OFBIZ-7511: - why will we not use auto-fields-service ? :) Develper should use auto-field service when ever possible, and when developer will use auto-field-service then we don't have to work on solution you are proposing. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7526) View Quote screen is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343746#comment-15343746 ] Pritam Kute commented on OFBIZ-7526: This issue is related to OFBIZ-7061. In a comment on OFBIZ-7061, [~jamesyong] suggested changing 'targetNamespace' to 'xsi:schemaLocation'. I have tested by doing so and found all screens working fine. > View Quote screen is broken > --- > > Key: OFBIZ-7526 > URL: https://issues.apache.org/jira/browse/OFBIZ-7526 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Priority: Blocker > > Steps to regenerate: > 1) Login to ordermgr. > 2) Click on Quotes and find quotes. > 3) Click on any quote in the search result to go to the overview screen. > You can see screen is broken with error: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ObjectType > |W| The specified type [] is not a valid class or a known special type, > may see more errors later because of this: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 > |AbstractModelCondition|W| Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported. > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ModelScreen >|E| Error rendering screen > [component://common/widget/CommonScreens.xml#GlobalDecorator]: > java.lang.IllegalArgumentException: Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported.. Rolling back transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343738#comment-15343738 ] Divesh Dutta edited comment on OFBIZ-7511 at 6/22/16 5:45 AM: -- Also I agree with Mridul that when we already have auto-fields-service feature which allows you to render all the fields of service in form and put required validation on fields in forms which are not optional in service, then why we are you proposing to identify request with an event of type service and then putting validations. auto-fields service already does the job. was (Author: diveshdut): Also I agree with Mridul that when we already have auto-fields-feature which allows you to render all the fields of service in form and put required validation on fields in forms which are not optional in service, then why we are you proposing to identify request with an event of type service and then putting validations. auto-fields service already does the job. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7523) Error in deleting AddressMatchMap for party
[ https://issues.apache.org/jira/browse/OFBIZ-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-7523: Assignee: Pranay Pandey (was: Chandan Khandelwal) > Error in deleting AddressMatchMap for party > --- > > Key: OFBIZ-7523 > URL: https://issues.apache.org/jira/browse/OFBIZ-7523 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > Attachments: OFBIZ-7523.patch, OFBIZ-7523_1307.patch, OFBIZ-7523_1412 > .patch, OFBIZ-7523_1512.patch > > > Go To Party -> AddressMatchMap > # Create New AddressMatchMap (or use an existing AddressMatchMap) > # Delete AddressMatchMap > # Try to delete the AddressMatchMap > URL : https://ofbiz-vm.apache.org:8443/partymgr/control/addressMatchMap > Here is the error message displayed in the screen: > The Following Errors Occurred: > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [mapKey] passed to secure (https) request-map with uri > [removeAddressMatchMap] with an event that calls service > [removeAddressMatchMap]; this is not allowed for security reasons! The data > should be encrypted by making it part of the request body (a form field) > instead of the request URL. Moreover it would be kind if you could create a > Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check > before if a sub-task for this error does not exist). If you are not sure how > to create a Jira issue please have a look before at > http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343738#comment-15343738 ] Divesh Dutta commented on OFBIZ-7511: - Also I agree with Mridul that when we already have auto-fields-feature which allows you to render all the fields of service in form and put required validation on fields in forms which are not optional in service, then why we are you proposing to identify request with an event of type service and then putting validations. auto-fields service already does the job. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343736#comment-15343736 ] Paul Foxworthy commented on OFBIZ-6576: --- Hi all, See this discussion from 2011: http://ofbiz.135035.n4.nabble.com/Display-VAT-on-checkout-pages-td3386374.html There are several places in the OFBiz code where there is an if statement testing for SALES_TAX, where it should probably be SALES_TAX or VAT_TAX. To me, there is very little difference between the two for a sale: they are both taxes levied by a tax authority on a sale. the key difference is VAT applies to purchases as well, and your tax liability is reduced by the tax you have paid on purchases. In contrast, sales tax only applies to sales. Cheers Paul > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date:
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343728#comment-15343728 ] Ankush Upadhyay edited comment on OFBIZ-6576 at 6/22/16 5:36 AM: - Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching the patch to provide the generic and correct fix for this issue. Solution summary: If we did not find the product price on the variant level then the system should lookup it on virtual level instead of returning the error or skip the workflow. [~Peter Arnold] The solution you adopting is not recommended solution, in that case, you can't create sales tax adjustment anymore in system. Please review the changes and let me know if anything else needs to be taken care under this. was (Author: ankush.upadhyay): Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching patch to fix this issue. Please review the changes and let me know if anything else need to be taken care under this. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red >
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343728#comment-15343728 ] Ankush Upadhyay commented on OFBIZ-6576: Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching patch to fix this issue. Please review the changes and let me know if anything else need to be taken care under this. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the pro
[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-6576: --- Attachment: OFBIZ-6576.patch > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices add: > - Tax Percentage:19 > - Tax Authority Party (ID):1 (Or whatever ID corresponds to > SII_CHL Party) > - Tax Auth
[jira] [Assigned] (OFBIZ-7531) On deleting manufacturing rule, rule id is getting set on Create Manufacturing Rule form
[ https://issues.apache.org/jira/browse/OFBIZ-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7531: -- Assignee: Ashish Vijaywargiya (was: Ravi Lodhi) > On deleting manufacturing rule, rule id is getting set on Create > Manufacturing Rule form > > > Key: OFBIZ-7531 > URL: https://issues.apache.org/jira/browse/OFBIZ-7531 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya > Attachments: DeleteManufacturingRule_01.jpeg, > DeleteManufacturingRule_02.jpeg, OFBIZ-7531_trunk.patch > > > Steps to regenerate: > 1) Login to Manufacturing component and go to "Bill Of Materials" screen. > 2) Now go to "Manufacturing Rules" screen. Here a form to create/update > manufacturing rules and list of manufacturing rule is displayed. > 3) Delete any manufacturing rule. Rule id is getting set on create form. As > role id is passed to the form which in turns sets form target to > "UpdateProductManufacturingRule" (Used in update operation). > 4) Fill the necessary detail and submit the form. It returns following error: > Entity value not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7528) Display commission agreements on product detail page
[ https://issues.apache.org/jira/browse/OFBIZ-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7528: -- Assignee: Ashish Vijaywargiya (was: Ravi Lodhi) > Display commission agreements on product detail page > > > Key: OFBIZ-7528 > URL: https://issues.apache.org/jira/browse/OFBIZ-7528 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya > Attachments: OFBIZ-7528_trunk.patch > > > Go to Catalogs -> Products -> Find any product -> detail page -> Agreements > section > ToDo: > 1) Change section heading from "Commissions" to "Products". Actually > agreements displayed in this section are product agreements. > 2) Display Commission agreements to complete the feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-7020: Fix Version/s: (was: Trunk) > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7530) Hide Rule Id field when creating Product Manufacturing Rule
[ https://issues.apache.org/jira/browse/OFBIZ-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7530: -- Assignee: Ashish Vijaywargiya (was: Ravi Lodhi) > Hide Rule Id field when creating Product Manufacturing Rule > > > Key: OFBIZ-7530 > URL: https://issues.apache.org/jira/browse/OFBIZ-7530 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya >Priority: Minor > Attachments: CreateManufacturingRules.jpeg, OFBIZ-7530_trunk.patch > > > Problem Area: > 1) Login to Manufacturing component and go to "Bill Of Materials" screen. > 2) Now go to "Manufacturing Rules" screen. > Here a form for creating/updating manufacturing rule is available. System > generated Rule Id is used when we create a new rule, so no need to display it > at the time of creation. Rule Id should only be displayed in case of editing. > One more reason to hide this at the time of creation is when we submit the > form (target=AddProductManufacturingRule) without the required parameter > needed for the underline service. It returns error that the required > parameter is missing, which is good but the form target get changed to > "UpdateProductManufacturingRule" though we are still creating a rule not > updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7527) Questions from category should not come to apply on survey when creating/editing any question
[ https://issues.apache.org/jira/browse/OFBIZ-7527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7527: -- Assignee: Ashish Vijaywargiya (was: Ravi Lodhi) > Questions from category should not come to apply on survey when > creating/editing any question > - > > Key: OFBIZ-7527 > URL: https://issues.apache.org/jira/browse/OFBIZ-7527 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya > Attachments: OFBIZ-7527_trunk.patch, SurveyQuestion.jpeg > > > Steps to regenerate: > 1) Go to Content -> Survey > 2) Find any survey and go to detail page. > 3) Now go to "Questions" page of that survey. > 4) Go to "Create New Question" section. Select a Survey Question Category Id > and other necessary detail and click on Create button > 5) Question successfully gets created but the list of questions from the > selected "Survey Question Category Id" appears to apply to survey. > There is a separate section to apply questions from category. So IMO question > from category should only come when we submit form to apply question from any > category not when creating a question or editing any question. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343695#comment-15343695 ] Arun Patidar commented on OFBIZ-7020: - Thanks [~jacques.le.roux] for your suggestion. I have updated the concerned tickets and also, will take care in future. > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Trunk, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7313) Coupon Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7313: Fix Version/s: (was: Upcoming Branch) Trunk > Coupon Sales Report is not working > -- > > Key: OFBIZ-7313 > URL: https://issues.apache.org/jira/browse/OFBIZ-7313 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: CouponSalesReport.patch > > > Coupon Sales Report is not working (Data is not getting populated) > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Coupon Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7020: Fix Version/s: (was: Upcoming Branch) Trunk > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Trunk, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7314) Last 3 Months Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7314: Fix Version/s: (was: Upcoming Branch) Trunk > Last 3 Months Sales Report is not working > -- > > Key: OFBIZ-7314 > URL: https://issues.apache.org/jira/browse/OFBIZ-7314 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: Last3MonthsSalesReport.patch > > > Last 3 Months Sales Report is not working > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Last 3 Months Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343112#comment-15343112 ] james yong edited comment on OFBIZ-7061 at 6/22/16 12:49 AM: - Hi [~jacques.le.roux], There are problems in my previous code change proposal; I didn't test it :( For example in menu, Originally {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; targetNamespace="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu-ns.xsd"; {code} But should be {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; xsi:schemaLocation="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu.xsd"; {code} Note the change from 'targetNamespace' from 'xsi:schemaLocation'. The rest (e.g screen, form) should be the same, but I can only test it later. Regards, James was (Author: jamesyong): Hi [~jacques.le.roux], There are problems in my original code change proposal. For example in menu, Originally {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; targetNamespace="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu-ns.xsd"; {code} But should be {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; xsi:schemaLocation="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu.xsd"; {code} Note the change from 'targetNamespace' from 'xsi:schemaLocation'. The rest (e.g screen, form) should be the same, but I can only test it later. Regards, James > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343120#comment-15343120 ] james yong commented on OFBIZ-7061: --- 'targetNamespace' should have been 'xsi:schemaLocation'. Sorry for not testing the previous code change. > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343112#comment-15343112 ] james yong edited comment on OFBIZ-7061 at 6/22/16 12:41 AM: - Hi [~jacques.le.roux], There are problems in my original code change proposal. For example in menu, Originally {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; targetNamespace="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu-ns.xsd"; {code} But should be {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; xsi:schemaLocation="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu.xsd"; {code} Note the change from 'targetNamespace' from 'xsi:schemaLocation'. The rest (e.g screen, form) should be the same, but I can only test it later. Regards, James was (Author: jamesyong): Hi [~jacques.le.roux], There are problems in my original code change proposal. For example in menu, Originally {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; targetNamespace="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu-ns.xsd"; http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; xsi:schemaLocation="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu.xsd"; {code} Note the change from 'targetNamespace' from 'xsi:schemaLocation'. The rest (e.g screen, form) should be the same, but I can only test it later. Regards, James > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343112#comment-15343112 ] james yong commented on OFBIZ-7061: --- Hi [~jacques.le.roux], There are problems in my original code change proposal. For example in menu, Originally {code} xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; targetNamespace="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu-ns.xsd"; http://ofbiz.apache.org/dtds/widget-menu.xsd"; to xmlns="http://ofbiz.apache.org/Widget-Menu"; xsi:schemaLocation="http://ofbiz.apache.org/Widget-Menu http://ofbiz.apache.org/dtds/widget-menu.xsd"; {code} Note the change from 'targetNamespace' from 'xsi:schemaLocation'. The rest (e.g screen, form) should be the same, but I can only test it later. Regards, James > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343070#comment-15343070 ] james yong commented on OFBIZ-7061: --- In ExampleCompoundWidgets.xml, 'compound-widget.xsd' should be 'compound-widgets.xsd' > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc"; > targetNamespace="http://ofbiz.apache.org/sc"; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance"; > xmlns:sc="http://ofbiz.apache.org/sc"; > xmlns:m="http://ofbiz.apache.org/m"; > xmlns:s="http://ofbiz.apache.org/s"; > xmlns:f="http://ofbiz.apache.org/f"; > xmlns:sm="http://ofbiz.apache.org/sm"; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd";> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Important Changes to Trunk and Use of Ant & Gradle
Inline Op dinsdag 21 juni 2016 heeft Taher Alkhateeb het volgende geschreven: > Hi Everyone, > > I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 > for > this project > > I have two questions in this thread > > First Question > -- > Can I drop the below tasks from the build system? They currently exist in > Ant but I am not sure whether they are actively used or not. So if you want > me to add any of these tasks please reply to this thread, otherwise I will > not include them in gradle. Please note I added all multi tenant tasks > because many of them are broken or have no functionality, so I am assuming > people are doing multi-tenancy manually but not sure, so please help! > > - build-dev > - build-production > - build-qa > - build-test > - clean-ivy > - copy-dtds > - create-tenant Don't drop, until replaced by gradlle equivalent. Used to setup a tenant instanciation in a multi-tenant setup. This has dependencies that set the tenant admin Id an password and execute the initial data load for the tenant. For these dependencies the same 'don't drop, until.' applies. > - download-PG-JDBC Don't drop, until replaced by gradlle equivalent. Used for PostgreSQL based test and/or production environment - download-activemq Don't drop, until replaced by gradlle equivalent. Used for clustered test and/or production environment - download-mySQL-JDBC Don't drop, until replaced by gradlle equivalent. Used for MySQL based test and/or production environment > - gen-kek > - gitinfo > - load-all-tenants Drop. Used for multi tenant demo setup. Deprecated. > - load-demo-multitenant Drop. Used for multi tenant demo setup. Deprecated. > - load-tenant > - load-tenant-data-readers > - refresh > - revert-dev > - run-test-list > - start-batch > - start-batch-secure > - start-both-secure > - start-pos-secure > - start-secure > - svninfo > > Second Question > --- > > it seems many of the load tasks are too specific. So I suggest to only > implement loadDemo and the rest are executed manually by users, for > example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' > instead of load-extseed. > > Then there is no need to maintain the load-demo variant, as it can be executed like the other data loading mechanism. It is better not to confuse potential adopters by serving them 2 variants that basically do the same, but wit different data sets. > If you would like to add the other load data tasks, please specify which > ones. > > Appreciate your early responses. > > Taher Alkhateeb > > On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb < > slidingfilame...@gmail.com > > wrote: > > > Hi Everyone, > > > > Thank you all for your support and kinds words. This is truly a wonderful > > atmosphere and I am lucky, honoured, and privileged to work with you all > on > > this project. > > > > My patch is almost done, but definitely there is a lot of work to be done > > which includes the following: > > - I have one failing test out of 889 that I need to dig through, maybe > you > > guy can help > > - I want to change / delete / add some tasks > > - Documentation needs to be updated in multiple areas > > - Testing, testing, testing, testing, testing, testing, testing, testing, > > testing > > > > So the plan of action is as follows: > > - I will continue the discussion on this thread for a few questions that > I > > need an answer for. > > - I will issue a JIRA to hold the patch and everything else > > > > Please consider helping, this is something that definitely needs a team, > > more than one brain! If you are working on something not urgent, please > > consider dropping it for a while and jump along for help. > > > > I will post another email soon with the JIRA details and list of > questions > > I need answer for. > > > > Again, thank you, you guys rock, I love OFBiz and this community! > > > > Regards, > > > > Taher Alkhateeb > > > > > > > > On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin < > nicolas.ma...@nereide.fr > > > wrote: > > > >> I'm in over for these technical aspects but the motivation and > enthusiasm > >> for many PMC and commiter tells me that seems a good way. > >> > >> So now I will learn gradle ;) and I'm in favor to realize this change > >> directly on trunk > >> > >> Thks Taher to your engine energy on this subject ! > >> > >> Nicolas > >> > >> > >> > >> Le 21/06/2016 10:43, Jacques Le Roux a écrit : > >> > >>> As Gavin mentioned, Gradle can run Ant so no worries using only Gradle > >>> > >>> https://docs.gradle.org/current/userguide/ant.html > >>> > >>> Jacques > >>> > >>> > >>> Le 21/06/2016 à 09:59, Michael Brohl a écrit : > >>> > I have no strong opinion for/against Gradle (I simply have no > experience with it) but I agree that it should be either Ant or > Gradle. > Running two build tools in parallel would make it too complex an gain > nothing. > > I'm in favor for learning new things so Gr
Re: XML autocompletion issue
Hi Taher Yes that can surely be done. BTW these changes have no impacts on the level you are working, apart the copy-dtds Ant target ;) Anyway I'll tell you more tomorrow about that... Cheers Jacques Le 21/06/2016 à 23:01, Taher Alkhateeb a écrit : Hi Jacques, Since you mentioned regressions may I suggest that we slow down a little bit our work on trunk for a few days as we work on Gradle to avoid crossing wires. We can focus instead on work at the applications level or for anyone interested to work on gradle itself. Cheers! Taher Alkhateeb On Jun 21, 2016 11:53 PM, "Jacques Le Roux" wrote: Hi, I just noticed that we seem to have an issue with XML autocompletion in files concerned (used by the Compound Widget feature) since I committed today the last changes for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 Before reverting anything I will tomorrow check why we have this issue Thanks for your patience Jacques
Re: Important Changes to Trunk and Use of Ant & Gradle
Inline... Le 21/06/2016 à 23:00, Michael Brohl a écrit : Hi Taher, First question: Don't drop: - build-dev - build-production - build-qa - build-test - refresh - revert-dev - run-test-list Drop: - clean-ivy (assuming this is not needed if we use Gradle) - copy-dtds Nope, this one is useful to copy the updated XDSs from the trunk to the "website" (ie under http://ofbiz.apache.org/) - download-PG-JDBC - download-activemq - download-mySQL-JDBC (download tasks: assuming they are not needed if we use Gradle/automatic dependency mechanism) Not sure (I don't use them): - create-tenant - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers Those are used in a multi-tenant context - gen-kek Never used it, but Jacopo put it in recently - gitinfo Used by external projects which use Git - run-test-list I guess this will become redundant with Gradle - start-batch-secure - start-both-secure - start-pos-secure - start-secure (...secure: not sure if these are needed anymore, I think Jacques can give some hints about them) This is needed as soon as you use RMI, JMX, Spring, or/and any external librairies within your OFBiz instance see https://cwiki.apache.org/confluence/display/OFBIZ/The+infamous+Java+serialization+vulnerability for details. Unfortunately currently the link between Confluence and Jira is broken: https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-12138 - svninfo It can be used by custom projects but is for sure used by the demos: it generates the information you read at the bottom on each page. Second question: +1 Same here: +1 but I'm not sure about the load-tenant... tasks (I don't use them). I guess at least Pierre will chime in... Cheers Jacques Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 21.06.16 um 22:09 schrieb Taher Alkhateeb: Hi Everyone, I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 for this project I have two questions in this thread First Question -- Can I drop the below tasks from the build system? They currently exist in Ant but I am not sure whether they are actively used or not. So if you want me to add any of these tasks please reply to this thread, otherwise I will not include them in gradle. Please note I added all multi tenant tasks because many of them are broken or have no functionality, so I am assuming people are doing multi-tenancy manually but not sure, so please help! - build-dev - build-production - build-qa - build-test - clean-ivy - copy-dtds - create-tenant - download-PG-JDBC - download-activemq - download-mySQL-JDBC - gen-kek - gitinfo - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers - refresh - revert-dev - run-test-list - start-batch - start-batch-secure - start-both-secure - start-pos-secure - start-secure - svninfo Second Question --- it seems many of the load tasks are too specific. So I suggest to only implement loadDemo and the rest are executed manually by users, for example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' instead of load-extseed. If you would like to add the other load data tasks, please specify which ones. Appreciate your early responses. Taher Alkhateeb
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342685#comment-15342685 ] Jacques Le Roux commented on OFBIZ-7532: bq. I think that it will require a discussion on Dev mailing-list to validate the choices. The best practice is to discuss before creating the Jira ;) > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Priority: Minor > Attachments: OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Important Changes to Trunk and Use of Ant & Gradle
Hi Taher, First question: Don't drop: - build-dev - build-production - build-qa - build-test - refresh - revert-dev - run-test-list Drop: - clean-ivy (assuming this is not needed if we use Gradle) - copy-dtds - download-PG-JDBC - download-activemq - download-mySQL-JDBC (download tasks: assuming they are not needed if we use Gradle/automatic dependency mechanism) Not sure (I don't use them): - create-tenant - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers - gen-kek - gitinfo - run-test-list - start-batch-secure - start-both-secure - start-pos-secure - start-secure (...secure: not sure if these are needed anymore, I think Jacques can give some hints about them) - svninfo Second question: +1 but I'm not sure about the load-tenant... tasks (I don't use them). Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 21.06.16 um 22:09 schrieb Taher Alkhateeb: Hi Everyone, I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 for this project I have two questions in this thread First Question -- Can I drop the below tasks from the build system? They currently exist in Ant but I am not sure whether they are actively used or not. So if you want me to add any of these tasks please reply to this thread, otherwise I will not include them in gradle. Please note I added all multi tenant tasks because many of them are broken or have no functionality, so I am assuming people are doing multi-tenancy manually but not sure, so please help! - build-dev - build-production - build-qa - build-test - clean-ivy - copy-dtds - create-tenant - download-PG-JDBC - download-activemq - download-mySQL-JDBC - gen-kek - gitinfo - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers - refresh - revert-dev - run-test-list - start-batch - start-batch-secure - start-both-secure - start-pos-secure - start-secure - svninfo Second Question --- it seems many of the load tasks are too specific. So I suggest to only implement loadDemo and the rest are executed manually by users, for example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' instead of load-extseed. If you would like to add the other load data tasks, please specify which ones. Appreciate your early responses. Taher Alkhateeb smime.p7s Description: S/MIME Cryptographic Signature
Re: XML autocompletion issue
Hi Jacques, Since you mentioned regressions may I suggest that we slow down a little bit our work on trunk for a few days as we work on Gradle to avoid crossing wires. We can focus instead on work at the applications level or for anyone interested to work on gradle itself. Cheers! Taher Alkhateeb On Jun 21, 2016 11:53 PM, "Jacques Le Roux" wrote: > Hi, > > I just noticed that we seem to have an issue with XML autocompletion in > files concerned (used by the Compound Widget feature) since I committed > today the last changes for "Autocompletion for Compound Widget" - > https://issues.apache.org/jira/browse/OFBIZ-7061 > > Before reverting anything I will tomorrow check why we have this issue > > Thanks for your patience > > Jacques > >
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342667#comment-15342667 ] Jacques Le Roux commented on OFBIZ-7519: Thanks guys for the "generalisation", though before being totally sure about that I have to read OFBIZ-7511. I'll do tomorrow... > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
XML autocompletion issue
Hi, I just noticed that we seem to have an issue with XML autocompletion in files concerned (used by the Compound Widget feature) since I committed today the last changes for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 Before reverting anything I will tomorrow check why we have this issue Thanks for your patience Jacques
Re: Important Changes to Trunk and Use of Ant & Gradle
Hello Taher, First question, from the given list I personally only use : - download-PG-JDBC to easily get through ivy the last postgresql driver - start-batch that can be avoided using shell tricks, so no problem No opinions against others removal For the load-task, if its easily documented with a feature like ant -p, it's ok for me. Regards Gil On 21/06/2016 22:09, Taher Alkhateeb wrote: Hi Everyone, I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 for this project I have two questions in this thread First Question -- Can I drop the below tasks from the build system? They currently exist in Ant but I am not sure whether they are actively used or not. So if you want me to add any of these tasks please reply to this thread, otherwise I will not include them in gradle. Please note I added all multi tenant tasks because many of them are broken or have no functionality, so I am assuming people are doing multi-tenancy manually but not sure, so please help! - build-dev - build-production - build-qa - build-test - clean-ivy - copy-dtds - create-tenant - download-PG-JDBC - download-activemq - download-mySQL-JDBC - gen-kek - gitinfo - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers - refresh - revert-dev - run-test-list - start-batch - start-batch-secure - start-both-secure - start-pos-secure - start-secure - svninfo Second Question --- it seems many of the load tasks are too specific. So I suggest to only implement loadDemo and the rest are executed manually by users, for example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' instead of load-extseed. If you would like to add the other load data tasks, please specify which ones. Appreciate your early responses. Taher Alkhateeb On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb wrote: Hi Everyone, Thank you all for your support and kinds words. This is truly a wonderful atmosphere and I am lucky, honoured, and privileged to work with you all on this project. My patch is almost done, but definitely there is a lot of work to be done which includes the following: - I have one failing test out of 889 that I need to dig through, maybe you guy can help - I want to change / delete / add some tasks - Documentation needs to be updated in multiple areas - Testing, testing, testing, testing, testing, testing, testing, testing, testing So the plan of action is as follows: - I will continue the discussion on this thread for a few questions that I need an answer for. - I will issue a JIRA to hold the patch and everything else Please consider helping, this is something that definitely needs a team, more than one brain! If you are working on something not urgent, please consider dropping it for a while and jump along for help. I will post another email soon with the JIRA details and list of questions I need answer for. Again, thank you, you guys rock, I love OFBiz and this community! Regards, Taher Alkhateeb On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin wrote: I'm in over for these technical aspects but the motivation and enthusiasm for many PMC and commiter tells me that seems a good way. So now I will learn gradle ;) and I'm in favor to realize this change directly on trunk Thks Taher to your engine energy on this subject ! Nicolas Le 21/06/2016 10:43, Jacques Le Roux a écrit : As Gavin mentioned, Gradle can run Ant so no worries using only Gradle https://docs.gradle.org/current/userguide/ant.html Jacques Le 21/06/2016 à 09:59, Michael Brohl a écrit : I have no strong opinion for/against Gradle (I simply have no experience with it) but I agree that it should be either Ant or Gradle. Running two build tools in parallel would make it too complex an gain nothing. I'm in favor for learning new things so Gradle sounds fine for me :-) Regards, Michael Am 21.06.16 um 08:11 schrieb Taher Alkhateeb: Hi Deepak, Ant would be removed completely for the following reasons: - First to resolve the ASF issue about the libraries mentioned by Sharan below without expending effort on both build systems. - Ant is an obstacle to refactoring the framework. If we keep both systems side by side we gain nothing, actually we lose value because the builds become more complex. For example, we will not be able to intrduce the unit tests, and we will have two build outputs, and we will have two ways of running the framework (java -jar ofbiz.jar and gradlew ofbiz) and we will have other incompatibility issues. With that being said, we will not make the switch before a thorough and full testing. That is why we ask everyone who is willing to please help us out to make this transition smooth by testing and providing feedback and comments. Taher Alkhateeb On Tuesday, 21 June 2016, Deepak Dixit Are we going to remove ant from framework completely or planning to keep both ant and gradle? Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com On M
[jira] [Commented] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342620#comment-15342620 ] Jacques Le Roux commented on OFBIZ-7020: Hi Arun, Please put "Upcoming Branch" *only* when *only the trunk is concerned*. Else simply put the concerned releases versions. Jacopo explained that in a question I asked on dev ML. You can find some concerned issues with this [Jira research|https://issues.apache.org/jira/browse/OFBIZ-7314?jql=project%20%3D%20OFBIZ%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20in%20(15.12.01%2C%20%22Upcoming%20Branch%22)%20AND%20resolved%20%3E%3D%20-5d%20AND%20assignee%20in%20(arun.patidar%2C%20arunpati)%20ORDER%20BY%20updated%20DESC] Thanks! > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5610) Labels for UK date formats
[ https://issues.apache.org/jira/browse/OFBIZ-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5610: --- Fix Version/s: (was: Release Branch 13.07) 13.07.04 > Labels for UK date formats > -- > > Key: OFBIZ-5610 > URL: https://issues.apache.org/jira/browse/OFBIZ-5610 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Gareth Carter >Assignee: Michael Brohl >Priority: Trivial > Fix For: 14.12.01, 13.07.04 > > Attachments: gb_labels.patch > > > Date formats displayed in the title of the input field are not correctly > showing the default format for UK but the actual date itself is correct -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342602#comment-15342602 ] Jacques Le Roux commented on OFBIZ-5776: The most interesting point to me is to move dynamically created content from framework/images. The rest is a moot point to me (though of course ressources name makes more sens for js and css to me than images). As mentionned Pierrre the templates are not at their right place either. There are maybe other kinds of stuff in images (Adrian spoke about "application-specific content"), I did not check, but it will be certainly easier to check and decide to their place after this move... > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341849#comment-15341849 ] Jacques Le Roux edited comment on OFBIZ-5776 at 6/21/16 8:11 PM: - Can we conclude this ticket? Either we are fine to move static content from images (as image webapp name is miss leading) to resources (appropriate place for js/css) or we can discard this ticket as well :) was (Author: deepak.dixit): Can we conclude this ticket? Either we are fine to move static content form images (as image webapp name is miss leading) to resources (appropriate place for js/css) or we can discard this ticket as well :) > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342569#comment-15342569 ] Jacques Le Roux commented on OFBIZ-7529: Please keep ShipmentScaleApplet.java. It can be used in the POS context > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Important Changes to Trunk and Use of Ant & Gradle
Hi Everyone, I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 for this project I have two questions in this thread First Question -- Can I drop the below tasks from the build system? They currently exist in Ant but I am not sure whether they are actively used or not. So if you want me to add any of these tasks please reply to this thread, otherwise I will not include them in gradle. Please note I added all multi tenant tasks because many of them are broken or have no functionality, so I am assuming people are doing multi-tenancy manually but not sure, so please help! - build-dev - build-production - build-qa - build-test - clean-ivy - copy-dtds - create-tenant - download-PG-JDBC - download-activemq - download-mySQL-JDBC - gen-kek - gitinfo - load-all-tenants - load-demo-multitenant - load-tenant - load-tenant-data-readers - refresh - revert-dev - run-test-list - start-batch - start-batch-secure - start-both-secure - start-pos-secure - start-secure - svninfo Second Question --- it seems many of the load tasks are too specific. So I suggest to only implement loadDemo and the rest are executed manually by users, for example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' instead of load-extseed. If you would like to add the other load data tasks, please specify which ones. Appreciate your early responses. Taher Alkhateeb On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb wrote: > Hi Everyone, > > Thank you all for your support and kinds words. This is truly a wonderful > atmosphere and I am lucky, honoured, and privileged to work with you all on > this project. > > My patch is almost done, but definitely there is a lot of work to be done > which includes the following: > - I have one failing test out of 889 that I need to dig through, maybe you > guy can help > - I want to change / delete / add some tasks > - Documentation needs to be updated in multiple areas > - Testing, testing, testing, testing, testing, testing, testing, testing, > testing > > So the plan of action is as follows: > - I will continue the discussion on this thread for a few questions that I > need an answer for. > - I will issue a JIRA to hold the patch and everything else > > Please consider helping, this is something that definitely needs a team, > more than one brain! If you are working on something not urgent, please > consider dropping it for a while and jump along for help. > > I will post another email soon with the JIRA details and list of questions > I need answer for. > > Again, thank you, you guys rock, I love OFBiz and this community! > > Regards, > > Taher Alkhateeb > > > > On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin > wrote: > >> I'm in over for these technical aspects but the motivation and enthusiasm >> for many PMC and commiter tells me that seems a good way. >> >> So now I will learn gradle ;) and I'm in favor to realize this change >> directly on trunk >> >> Thks Taher to your engine energy on this subject ! >> >> Nicolas >> >> >> >> Le 21/06/2016 10:43, Jacques Le Roux a écrit : >> >>> As Gavin mentioned, Gradle can run Ant so no worries using only Gradle >>> >>> https://docs.gradle.org/current/userguide/ant.html >>> >>> Jacques >>> >>> >>> Le 21/06/2016 à 09:59, Michael Brohl a écrit : >>> I have no strong opinion for/against Gradle (I simply have no experience with it) but I agree that it should be either Ant or Gradle. Running two build tools in parallel would make it too complex an gain nothing. I'm in favor for learning new things so Gradle sounds fine for me :-) Regards, Michael Am 21.06.16 um 08:11 schrieb Taher Alkhateeb: > Hi Deepak, > > Ant would be removed completely for the following reasons: > > - First to resolve the ASF issue about the libraries mentioned by > Sharan > below without expending effort on both build systems. > - Ant is an obstacle to refactoring the framework. If we keep both > systems > side by side we gain nothing, actually we lose value because the builds > become more complex. For example, we will not be able to intrduce the > unit > tests, and we will have two build outputs, and we will have two ways of > running the framework (java -jar ofbiz.jar and gradlew ofbiz) and we > will > have other incompatibility issues. > > With that being said, we will not make the switch before a thorough and > full testing. That is why we ask everyone who is willing to please > help us > out to make this transition smooth by testing and providing feedback > and > comments. > > Taher Alkhateeb > > On Tuesday, 21 June 2016, Deepak Dixit > > wrote: > > +1 for Gradle. >> >> Are we going to remove ant from framework completely or planning to >> keep >> both ant and gradle? >> >> >> >> Thanks & Regard
[jira] [Created] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
Taher Alkhateeb created OFBIZ-7534: -- Summary: Migrate OFBiz from Apache Ant to Gradle build system Key: OFBIZ-7534 URL: https://issues.apache.org/jira/browse/OFBIZ-7534 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Taher Alkhateeb This is a major refactoring task referring to the [email thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] in which the community voted for the switch after a proposal from the PMC The purpose of this JIRA is to achieve the following objectives - Fully implement a working compiling system in Gradle that passes all tests - Remove all ant and maven build scripts from the system - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342285#comment-15342285 ] Peter Arnold commented on OFBIZ-6576: - Issue is caused by the code further below in TaxAuthorityServices.java: _ Since for a variant product the "productPrice" and "taxInPrice" is set only on the corresponding virtual product, the Else part of below code becomes active and does the following: taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX"); Therewith Sales tax is added later on to the Variant Product. By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX" the issue seems to be resolved. However this can only be a temporary fix. ___ Code: ___ GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment"); if (productPrice != null && "Y".equals(productPrice.getString("taxInPrice"))) { // tax is in the price already, so we want the adjustment to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment to be added taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX"); // the amount will be different because we want to figure out how much of the price was tax, and not how much tax needs to be added // the formula is: taxAmount = priceWithTax - (priceWithTax/(1+taxPercentage/100)) BigDecimal taxAmountIncluded = itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE, 4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP)); taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded); taxAdjValue.set("amount", BigDecimal.ZERO); } else { taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX"); taxAdjValue.set("amount", taxAmount); } > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color
[jira] [Updated] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item
[ https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Shah updated OFBIZ-7533: Description: When any new lot is assigned to exiting inventory item then it ends up throwing foreign key constraint. We could allow it by creating first new lot (if its not found already existent in DB) and then associate the same with given inventory item. (Also currently i couldn't find any screen to create new lot in given facility) Please refer to attached screenshot for reference. was: When any new lot is assigned to exiting inventory item then it ends up throwing foreign key constraint. We could allow it by creating first new lot (if its not found already existent in DB) and then associate the same with given inventory item. Please refer to attached screenshot for reference. > Not able to set new Lot Id to existing inventory item > - > > Key: OFBIZ-7533 > URL: https://issues.apache.org/jira/browse/OFBIZ-7533 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: II_LOT.png > > > When any new lot is assigned to exiting inventory item then it ends up > throwing foreign key constraint. > We could allow it by creating first new lot (if its not found already > existent in DB) and then associate the same with given inventory item. (Also > currently i couldn't find any screen to create new lot in given facility) > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item
[ https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Shah updated OFBIZ-7533: Attachment: II_LOT.png > Not able to set new Lot Id to existing inventory item > - > > Key: OFBIZ-7533 > URL: https://issues.apache.org/jira/browse/OFBIZ-7533 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: II_LOT.png > > > When any new lot is assigned to exiting inventory item then it ends up > throwing foreign key constraint. > We could allow it by creating first new lot (if its not found already > existent in DB) and then associate the same with given inventory item. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item
[ https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Shah updated OFBIZ-7533: Affects Version/s: (was: Release Branch 15.12) (was: Release Branch 14.12) 15.12.01 14.12.01 > Not able to set new Lot Id to existing inventory item > - > > Key: OFBIZ-7533 > URL: https://issues.apache.org/jira/browse/OFBIZ-7533 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Swapnil Shah > > When any new lot is assigned to exiting inventory item then it ends up > throwing foreign key constraint. > We could allow it by creating first new lot (if its not found already > existent in DB) and then associate the same with given inventory item. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item
Swapnil Shah created OFBIZ-7533: --- Summary: Not able to set new Lot Id to existing inventory item Key: OFBIZ-7533 URL: https://issues.apache.org/jira/browse/OFBIZ-7533 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Release Branch 15.12, Release Branch 14.12 Reporter: Swapnil Shah Assignee: Swapnil Shah When any new lot is assigned to exiting inventory item then it ends up throwing foreign key constraint. We could allow it by creating first new lot (if its not found already existent in DB) and then associate the same with given inventory item. Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7526) View Quote screen is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342141#comment-15342141 ] Pritam Kute commented on OFBIZ-7526: I found that this issue is because of the commit at revision 1749488. We have XSD http://ofbiz.apache.org/dtds/widget-common.xsd which includes the definition for 'if-compare' which has a default value for type attribute as 'String'. It is not getting parsed properly. If we explicitly add 'type' attribute to if-compare, it works. {code} {code} > View Quote screen is broken > --- > > Key: OFBIZ-7526 > URL: https://issues.apache.org/jira/browse/OFBIZ-7526 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Priority: Blocker > > Steps to regenerate: > 1) Login to ordermgr. > 2) Click on Quotes and find quotes. > 3) Click on any quote in the search result to go to the overview screen. > You can see screen is broken with error: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ObjectType > |W| The specified type [] is not a valid class or a known special type, > may see more errors later because of this: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 > |AbstractModelCondition|W| Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported. > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ModelScreen >|E| Error rendering screen > [component://common/widget/CommonScreens.xml#GlobalDecorator]: > java.lang.IllegalArgumentException: Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported.. Rolling back transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342039#comment-15342039 ] Deepak Dixit commented on OFBIZ-7511: - I am not getting the point "override validation like auto-field-service provide?' I think currently we don't have any option in auto-field-service to override required field. I am not proposing to remove required-field attribute if user want to override it so he can use required-field to override behavior. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7252) Error adding task to backlog
[ https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342036#comment-15342036 ] Pritam Kute commented on OFBIZ-7252: Hi [~Florian M], I have already started the discussion on the developer list. You can search the mail thread with subject ' is not working as expected in Form Widget'. I have traced the exact problem and logged issue OFBIZ-7513 for the same. I will upload the patch for the fix soon. Thanks. > Error adding task to backlog > > > Key: OFBIZ-7252 > URL: https://issues.apache.org/jira/browse/OFBIZ-7252 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Ashish Vijaywargiya > Labels: error, form, scrum, sprint, task > Attachments: OFBIZ-7252-Trunk.patch > > > There are several problems in the form to add a new task in a backlog. Step > to reproduce : > - Go to the Scrum component and select a product sprint > (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1&projectId=DEMO-PROJECT-1) > - Scroll down to the Sprint Backlog List > - Click on a button "Add Task" > - See the error in the console. > From there, it's not possible to create a new task. When clicking on the > create button, there is an error and the target is > "https://localhost:8443/scrum/control/updateSprintTask"; where it should be > "https://localhost:8443/scrum/control/createSprintBacklogTask";. > I tried to solve the problem but it's beyond me. The form causing the problem > is scrumForms.xml#NewTaskForSprintBacklog and it extends the form > TaskForms.xml#EditSprintTask . > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7526) View Quote screen is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341992#comment-15341992 ] Pritam Kute commented on OFBIZ-7526: When I looked deeper into the issue, I found that lot of screens are broken like while changing theme we are getting the same error, on FindProduct screen we are getting the same error etc. > View Quote screen is broken > --- > > Key: OFBIZ-7526 > URL: https://issues.apache.org/jira/browse/OFBIZ-7526 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Priority: Blocker > > Steps to regenerate: > 1) Login to ordermgr. > 2) Click on Quotes and find quotes. > 3) Click on any quote in the search result to go to the overview screen. > You can see screen is broken with error: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ObjectType > |W| The specified type [] is not a valid class or a known special type, > may see more errors later because of this: > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 > |AbstractModelCondition|W| Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported. > [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ModelScreen >|E| Error rendering screen > [component://common/widget/CommonScreens.xml#GlobalDecorator]: > java.lang.IllegalArgumentException: Error with comparison in if-compare > between field [quote.statusId] with value [QUO_CREATED] and value > [QUO_CREATED] with operator [equals] and type []: Type "" specified for > compare not supported.. Rolling back transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7252) Error adding task to backlog
[ https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341970#comment-15341970 ] Montalbano Florian commented on OFBIZ-7252: --- Hi, thank you for your explanation [~pritam.kute]. I saw another issue with a problem related to this in inherited form. Did you start the discussion you talked about ? I'm interested in following it. Do you think the patch will be committed ? I would like to stay in phase with the standard and from what you said, this problem seems deeper than what it seemed to be. Have a nice day. > Error adding task to backlog > > > Key: OFBIZ-7252 > URL: https://issues.apache.org/jira/browse/OFBIZ-7252 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Ashish Vijaywargiya > Labels: error, form, scrum, sprint, task > Attachments: OFBIZ-7252-Trunk.patch > > > There are several problems in the form to add a new task in a backlog. Step > to reproduce : > - Go to the Scrum component and select a product sprint > (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1&projectId=DEMO-PROJECT-1) > - Scroll down to the Sprint Backlog List > - Click on a button "Add Task" > - See the error in the console. > From there, it's not possible to create a new task. When clicking on the > create button, there is an error and the target is > "https://localhost:8443/scrum/control/updateSprintTask"; where it should be > "https://localhost:8443/scrum/control/createSprintBacklogTask";. > I tried to solve the problem but it's beyond me. The form causing the problem > is scrumForms.xml#NewTaskForSprintBacklog and it extends the form > TaskForms.xml#EditSprintTask . > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles STELTZLEN updated OFBIZ-7532: - Attachment: OFBIZ-7532.patch > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Priority: Minor > Attachments: OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
Charles STELTZLEN created OFBIZ-7532: Summary: Form Display Field improvement to manage multiple number format Key: OFBIZ-7532 URL: https://issues.apache.org/jira/browse/OFBIZ-7532 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Charles STELTZLEN Priority: Minor On display field used in forms, there is a "type" "accounting-number" which is used to format number like property configuration : #,##0.;(#,##0.). This JIRA propose to extend this idea by using a "type" "number" and an additional attribute called "format-pattern". This field will be used by form renderer to get the good property. It use FlexibleString to manage variable in this field and so allow to have different format for the same column according to some conditions. example: The "format-pattern" will be stored in arithmetic.properties. example: # the default number format default.number.format = ##0.00 accounting.number.format = #,##0.;(#,##0.) quantity.number.format = ##0.00 integer-quantity.number.format = #0 percentage.number.format = ##.##% export.number.format = #.00 In ModelFormField.java, the system gets property using EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. I think that it will require a discussion on Dev mailing-list to validate the choices. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7314) Last 3 Months Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7314: Affects Version/s: Release Branch 14.12 Trunk Release Branch 15.12 > Last 3 Months Sales Report is not working > -- > > Key: OFBIZ-7314 > URL: https://issues.apache.org/jira/browse/OFBIZ-7314 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: Last3MonthsSalesReport.patch > > > Last 3 Months Sales Report is not working > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Last 3 Months Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7314) Last 3 Months Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7314. --- Resolution: Fixed Fix Version/s: 15.12.01 Upcoming Branch 14.12.01 Committed patch in trunk at rev: 1749552 in 15.12 at rev: 1749553 in 14.12 at rev: 1749554 Thanks [~rohit.koushal] for your patch. > Last 3 Months Sales Report is not working > -- > > Key: OFBIZ-7314 > URL: https://issues.apache.org/jira/browse/OFBIZ-7314 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: Last3MonthsSalesReport.patch > > > Last 3 Months Sales Report is not working > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Last 3 Months Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7531) On deleting manufacturing rule, rule id is getting set on Create Manufacturing Rule form
[ https://issues.apache.org/jira/browse/OFBIZ-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7531: -- Attachment: OFBIZ-7531_trunk.patch DeleteManufacturingRule_01.jpeg DeleteManufacturingRule_02.jpeg Used request redirect to avoid the problem. Uploaded patch for the same. > On deleting manufacturing rule, rule id is getting set on Create > Manufacturing Rule form > > > Key: OFBIZ-7531 > URL: https://issues.apache.org/jira/browse/OFBIZ-7531 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: DeleteManufacturingRule_01.jpeg, > DeleteManufacturingRule_02.jpeg, OFBIZ-7531_trunk.patch > > > Steps to regenerate: > 1) Login to Manufacturing component and go to "Bill Of Materials" screen. > 2) Now go to "Manufacturing Rules" screen. Here a form to create/update > manufacturing rules and list of manufacturing rule is displayed. > 3) Delete any manufacturing rule. Rule id is getting set on create form. As > role id is passed to the form which in turns sets form target to > "UpdateProductManufacturingRule" (Used in update operation). > 4) Fill the necessary detail and submit the form. It returns following error: > Entity value not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341937#comment-15341937 ] Divesh Dutta commented on OFBIZ-7511: - Ok, [~deepak.dixit] I am getting your point. Your solution will work when we call service. But in case of event this solution will not work and in that case we will have to explicitly define required field in form as done in this task. So I think the solution you are proposing is not generic. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7392) Not selecting 'project Id' on creating a new task, it is being created for the first project from the list of Project Ids
[ https://issues.apache.org/jira/browse/OFBIZ-7392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey resolved OFBIZ-7392. -- Resolution: Fixed Fix Version/s: 15.12.01 14.12.01 Patch committed to Trunk r1749546, R15.12 r1749547 and R14.12 r1749548. Thanks [~aditi17] for the contribution. > Not selecting 'project Id' on creating a new task, it is being created for > the first project from the list of Project Ids > - > > Key: OFBIZ-7392 > URL: https://issues.apache.org/jira/browse/OFBIZ-7392 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Pranay Pandey >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7392.patch, create new task.png > > > New task created for first project from the list if user didn't select any > project from the list. > Steps to regenerate issue: > # Browse the link: https://localhost:8443/scrum/control/EditTask > # Fill the task name and push 'Create' button. View the task created it will > be created for the first project appearing in the list. > As the task can't exist without a project, this field must be a required > field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7531) On deleting manufacturing rule, rule id is getting set on Create Manufacturing Rule form
Ravi Lodhi created OFBIZ-7531: - Summary: On deleting manufacturing rule, rule id is getting set on Create Manufacturing Rule form Key: OFBIZ-7531 URL: https://issues.apache.org/jira/browse/OFBIZ-7531 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi Steps to regenerate: 1) Login to Manufacturing component and go to "Bill Of Materials" screen. 2) Now go to "Manufacturing Rules" screen. Here a form to create/update manufacturing rules and list of manufacturing rule is displayed. 3) Delete any manufacturing rule. Rule id is getting set on create form. As role id is passed to the form which in turns sets form target to "UpdateProductManufacturingRule" (Used in update operation). 4) Fill the necessary detail and submit the form. It returns following error: Entity value not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7313) Coupon Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7313: --- Assignee: Arun Patidar (was: Rohit Koushal) > Coupon Sales Report is not working > -- > > Key: OFBIZ-7313 > URL: https://issues.apache.org/jira/browse/OFBIZ-7313 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: CouponSalesReport.patch > > > Coupon Sales Report is not working (Data is not getting populated) > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Coupon Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7314) Last 3 Months Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7314: --- Assignee: Arun Patidar (was: Rohit Koushal) > Last 3 Months Sales Report is not working > -- > > Key: OFBIZ-7314 > URL: https://issues.apache.org/jira/browse/OFBIZ-7314 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Reporter: Rohit Koushal >Assignee: Arun Patidar > Attachments: Last3MonthsSalesReport.patch > > > Last 3 Months Sales Report is not working > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Last 3 Months Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7313) Coupon Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7313. --- Resolution: Fixed Fix Version/s: 15.12.01 Upcoming Branch 14.12.01 Committed patch in trunk at rev:1749543 15.12 at rev: 1749544 and in 14.12 at rev: 1749549 Thanks [~rohit.koushal] for your contribution. > Coupon Sales Report is not working > -- > > Key: OFBIZ-7313 > URL: https://issues.apache.org/jira/browse/OFBIZ-7313 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: CouponSalesReport.patch > > > Coupon Sales Report is not working (Data is not getting populated) > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Coupon Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7313) Coupon Sales Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7313: Affects Version/s: Release Branch 14.12 Trunk Release Branch 15.12 > Coupon Sales Report is not working > -- > > Key: OFBIZ-7313 > URL: https://issues.apache.org/jira/browse/OFBIZ-7313 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Fix For: 14.12.01, Upcoming Branch, 15.12.01 > > Attachments: CouponSalesReport.patch > > > Coupon Sales Report is not working (Data is not getting populated) > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Coupon Sales Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341919#comment-15341919 ] Mridul Pathak commented on OFBIZ-7511: -- If we are rendering validations by default through form renderer using the auto-field-service validation, would there still be the flexibility to override validation like auto-field-service provide? > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7392) Not selecting 'project Id' on creating a new task, it is being created for the first project from the list of Project Ids
[ https://issues.apache.org/jira/browse/OFBIZ-7392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey closed OFBIZ-7392. > Not selecting 'project Id' on creating a new task, it is being created for > the first project from the list of Project Ids > - > > Key: OFBIZ-7392 > URL: https://issues.apache.org/jira/browse/OFBIZ-7392 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Pranay Pandey >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7392.patch, create new task.png > > > New task created for first project from the list if user didn't select any > project from the list. > Steps to regenerate issue: > # Browse the link: https://localhost:8443/scrum/control/EditTask > # Fill the task name and push 'Create' button. View the task created it will > be created for the first project appearing in the list. > As the task can't exist without a project, this field must be a required > field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341897#comment-15341897 ] Pierre Smits commented on OFBIZ-5776: - The framework / resources folder contains the templates for creating new applications, to jump start junior developers but also to get some consistency between components (following naming conventions for generic data, screen and form widget, services, etc files). These templates shouldn't be in the framework stack. But should probably live in the special purposes stack. > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7530) Hide Rule Id field when creating Product Manufacturing Rule
[ https://issues.apache.org/jira/browse/OFBIZ-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7530: -- Attachment: OFBIZ-7530_trunk.patch CreateManufacturingRules.jpeg > Hide Rule Id field when creating Product Manufacturing Rule > > > Key: OFBIZ-7530 > URL: https://issues.apache.org/jira/browse/OFBIZ-7530 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Minor > Attachments: CreateManufacturingRules.jpeg, OFBIZ-7530_trunk.patch > > > Problem Area: > 1) Login to Manufacturing component and go to "Bill Of Materials" screen. > 2) Now go to "Manufacturing Rules" screen. > Here a form for creating/updating manufacturing rule is available. System > generated Rule Id is used when we create a new rule, so no need to display it > at the time of creation. Rule Id should only be displayed in case of editing. > One more reason to hide this at the time of creation is when we submit the > form (target=AddProductManufacturingRule) without the required parameter > needed for the underline service. It returns error that the required > parameter is missing, which is good but the form target get changed to > "UpdateProductManufacturingRule" though we are still creating a rule not > updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey closed OFBIZ-7519. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey resolved OFBIZ-7519. -- Resolution: Fixed Fix Version/s: Upcoming Branch Committed to Trunk r1749532. Thanks [~amardeepsj] for the contribution. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7020. --- > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341880#comment-15341880 ] Arun Patidar edited comment on OFBIZ-7020 at 6/21/16 2:35 PM: -- I have added comment and committed patch in trunk at rev: 1749525 and in 15.12 at rev: 1749527 Thanks [~rohit.koushal] for your contribution. was (Author: arunpati): I have add comment and committed patch in trunk at rev: 1749525 and in 15.12 at rev: 1749527 Thanks [~rohit.koushal] for your contribution. > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7020: Affects Version/s: Release Branch 15.12 Fix Version/s: (was: Trunk) Upcoming Branch > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341879#comment-15341879 ] Deepak Dixit commented on OFBIZ-7511: - Hi [~mridul.pathak], How can we say its hardcoding? I am proposing same that used in auto-field-service, if we did not use auto-field-service in form, than we can use the target to analyze the required field. So this is not hard coding at rendering level. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar resolved OFBIZ-7020. - Resolution: Fixed Fix Version/s: Trunk 15.12.01 I have add comment and committed patch in trunk at rev: 1749525 and in 15.12 at rev: 1749527 Thanks [~rohit.koushal] for your contribution. > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Fix For: 15.12.01, Trunk > > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-7519: - Summary: Some entity-auto services fields doesn't have optional false in case of multiple PK's (was: Some entity-auto services fields doesn't have optional false in case of multiple PK's.) > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7530) Hide Rule Id field when creating Product Manufacturing Rule
Ravi Lodhi created OFBIZ-7530: - Summary: Hide Rule Id field when creating Product Manufacturing Rule Key: OFBIZ-7530 URL: https://issues.apache.org/jira/browse/OFBIZ-7530 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi Priority: Minor Problem Area: 1) Login to Manufacturing component and go to "Bill Of Materials" screen. 2) Now go to "Manufacturing Rules" screen. Here a form for creating/updating manufacturing rule is available. System generated Rule Id is used when we create a new rule, so no need to display it at the time of creation. Rule Id should only be displayed in case of editing. One more reason to hide this at the time of creation is when we submit the form (target=AddProductManufacturingRule) without the required parameter needed for the underline service. It returns error that the required parameter is missing, which is good but the form target get changed to "UpdateProductManufacturingRule" though we are still creating a rule not updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7404) Sales Quote can be created for canceled cust request item
[ https://issues.apache.org/jira/browse/OFBIZ-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey closed OFBIZ-7404. > Sales Quote can be created for canceled cust request item > - > > Key: OFBIZ-7404 > URL: https://issues.apache.org/jira/browse/OFBIZ-7404 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7404.patch, screenshot-1.png, screenshot-2.png > > > # Go to Order > # Create New Request > # Add Two Request Items > # Cancel One Request Item > # Create Quote from request > # View Quote > Quote Item should not be created for the request items which have cancelled > status. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7404) Sales Quote can be created for canceled cust request item
[ https://issues.apache.org/jira/browse/OFBIZ-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey resolved OFBIZ-7404. -- Resolution: Fixed Fix Version/s: 13.07.04 15.12.01 14.12.01 Thanks [~chandan.khandelwal] for the contribution, your patch committed to Trunk r1749519, R15.12 r1749520, R14.12 r1749521 and R13.07 r1749523. > Sales Quote can be created for canceled cust request item > - > > Key: OFBIZ-7404 > URL: https://issues.apache.org/jira/browse/OFBIZ-7404 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7404.patch, screenshot-1.png, screenshot-2.png > > > # Go to Order > # Create New Request > # Add Two Request Items > # Cancel One Request Item > # Create Quote from request > # View Quote > Quote Item should not be created for the request items which have cancelled > status. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341860#comment-15341860 ] Mridul Pathak commented on OFBIZ-7511: -- Hi [~deepak.dixit] auto-field-service tag does the job already and provides the required flexibility to override validations as well and when auto-field-service already provides this facility I do not see it as something that needs to be fixed at framework level. The problem I see here is that in many forms auto-field-service might have been used but when the fields are overridden validations are not applied properly and this is some thing that needs to be fixed. In fact, the approach you are suggesting seems to be hardcoding validations at the renderer level and would remove the flexibility we have at this moment, I might be mistaken though. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341849#comment-15341849 ] Deepak Dixit commented on OFBIZ-5776: - Can we conclude this ticket? Either we are fine to move static content form images (as image webapp name is miss leading) to resources (appropriate place for js/css) or we can discard this ticket as well :) > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-5776: --- Assignee: Deepak Dixit > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341833#comment-15341833 ] Deepak Dixit edited comment on OFBIZ-7511 at 6/21/16 2:14 PM: -- There is no bug in required-field attribute, we can fix or can say improve form rendering mechanism to handle the required-field based on target. was (Author: deepak.dixit): There is no bug in required-field attribute, I meant to we can fix or can say improve form render to handle the required-field based on target. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-7529: - Summary: Delete stale java files from applications and framework (was: Delete stale java files from applications) > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7529) Delete stale java files from applications
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-7529: - Description: As per the discussions on the thread - http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, following files and their references needs to be deleted from applications and framework, applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java applications/content/src/org/ofbiz/content/report applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java applications/product/src/ShipmentScaleApplet.java applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java was: As per the discussions on the thread - http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, following files and their references needs to be deleted from applications and framework, applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java applications/content/src/org/ofbiz/content/report applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java applications/product/src/ShipmentScaleApplet.java applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java > Delete stale java files from applications > - > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341833#comment-15341833 ] Deepak Dixit commented on OFBIZ-7511: - There is no bug in require-label attribute, I meant to we can fix or can say improve form render to handle the require-field based on target. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341833#comment-15341833 ] Deepak Dixit edited comment on OFBIZ-7511 at 6/21/16 2:10 PM: -- There is no bug in required-field attribute, I meant to we can fix or can say improve form render to handle the required-field based on target. was (Author: deepak.dixit): There is no bug in require-label attribute, I meant to we can fix or can say improve form render to handle the require-field based on target. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7529) Delete stale java files from applications
Mridul Pathak created OFBIZ-7529: Summary: Delete stale java files from applications Key: OFBIZ-7529 URL: https://issues.apache.org/jira/browse/OFBIZ-7529 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Mridul Pathak Assignee: Mridul Pathak As per the discussions on the thread - http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, following files and their references needs to be deleted from applications and framework, applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java applications/content/src/org/ofbiz/content/report applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java applications/product/src/ShipmentScaleApplet.java applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341829#comment-15341829 ] Deepak Dixit commented on OFBIZ-7511: - Thanks [~diveshdut] for your detailed input, My proposal to identify form request and if an event (type of service) is associated with request than we can use that to identify required fields and in OFBiz most of the forms are using request that call an service type of event. Currently we are using this pattern to render hyperlink whit link-type=auto. It check if request has an service type event then it create hidden form else it render the anchor tag. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341810#comment-15341810 ] Divesh Dutta edited comment on OFBIZ-7511 at 6/21/16 2:02 PM: -- auto-fields-service handles required option i.e if IN attribute is not optional then required is set to "true" in form widget. so where ever auto-fields-service is used fields will be automatically work as required field, but in forms where you want to make field mandatory but that field in not mandatory in service definition, there is no option available. Also forms which are directly not based on service, for those forms, there is no option available. So such cases, this is the only option available i.e you will have to define required explicitly in form. I don't see any thing to to be fixed at framework level here as auto-fields-service handles this already . Approach taken in ticket can be done when, you cannot use auto-fields-service or auto-fields-service is used but fields are overridden in form. So my +1 for the approach taken in this ticket. I agree that we can manage this effort at component level instead of each form. [~deepak.dixit] what do you have in mind when you say we can fix this required-field at the time of form rendering ? There is no bug in required-field. was (Author: diveshdut): auto-fields-service handles required option i.e if IN attribute is not optional then required is set to "true" in form widget. so where ever auto-fields-service is used fields will be automatically work as required field, but in forms where you want to make field mandatory but that field in not mandatory in service definition, there is no option available. Also forms which are directly not based on service, for those forms, there is no option available. So such cases, this is the only option available i.e you will have to define required explicitly in form. I don't see any thing to to be fixed at framework level here. Deepak what do you have in mind when you say we can fix this required-field at the time of form rendering. There is no bug in required-field. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[ https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341810#comment-15341810 ] Divesh Dutta commented on OFBIZ-7511: - auto-fields-service handles required option i.e if IN attribute is not optional then required is set to "true" in form widget. so where ever auto-fields-service is used fields will be automatically work as required field, but in forms where you want to make field mandatory but that field in not mandatory in service definition, there is no option available. Also forms which are directly not based on service, for those forms, there is no option available. So such cases, this is the only option available i.e you will have to define required explicitly in form. I don't see any thing to to be fixed at framework level here. Deepak what do you have in mind when you say we can fix this required-field at the time of form rendering. There is no bug in required-field. > Add proper form validation across the application > -- > > Key: OFBIZ-7511 > URL: https://issues.apache.org/jira/browse/OFBIZ-7511 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > This is the place holder task for adding proper form validation across the > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)