Re: Track user for status change

[Taher Alkhateeb]

Hi Nameet,

I am assuming that you will not just change the entities but everything
like the services and events where necessary to ensure updating this field.
Am I correct in my understanding?

Taher Alkhateeb

On Saturday, 25 June 2016, Jacques Le Roux 
wrote:

> +1
>
> Jacques
>
>
> Le 24/06/2016 à 15:26, Nameet Jain a écrit :
>
>> Hello everyone,
>>
>> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
>> entities (like: ShipmentStatus). Using this field we can maintain the
>> history for each status change made by user.
>>
>> I will recommend here to add 'changedByUserLoginId' field to track the
>> userlogin detail. Here is the list of entities with missing such type of
>> field.
>>
>> 1. BudgetStatus
>> 2. ContactListCommStatus
>> 3. CustRequestStatus
>> 4. ExampleStatus
>> 5. FinAccountStatus
>> 6. InventoryItemStatus
>> 7. InvoiceStatus
>> 8. PartyStatus
>> 9. RequirementStatus
>> 10. ShipmentStatus
>>
>> Please let me know your thoughts. If it looks good I will open a ticket
>> for
>> the same.
>>
>> Thanks
>>
>> --
>> Regards,
>> Nameet Jain
>>
>>
>

[jira] [Comment Edited] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=12983046#comment-12983046
 ] 

Jacques Le Roux edited comment on OFBIZ-1319 at 6/24/16 10:15 PM:
--

Adrian, I guess you already read my comments about that in the related tasks I 
just closed. But for those interested and record fo the future here is a 
summary:

There are 444 calls of  Split javascript files to have more generic ones includable in all screens, 
> and the more specific ones included more locally
> 
>
> Key: OFBIZ-1319
> URL: https://issues.apache.org/jira/browse/OFBIZ-1319
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable 
> in all screens, and the more specific ones (like the toggle* and selectAll* 
> methods in there) into a file that can be included more locally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-1319:
---
Summary: Split javascript files to have more generic ones includable in all 
screens, and the more specific ones included more locally  (was: Split 
javascript files to have more generic ones includ-able in all screens, and the 
more specific ones included more locally)

> Split javascript files to have more generic ones includable in all screens, 
> and the more specific ones included more locally
> 
>
> Key: OFBIZ-1319
> URL: https://issues.apache.org/jira/browse/OFBIZ-1319
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable 
> in all screens, and the more specific ones (like the toggle* and selectAll* 
> methods in there) into a file that can be included more locally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-1319) Split javascript files to have more generic ones includ-able in all screens, and the more specific ones included more locally

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-1319:
---
Description: 
>From a David's E. Jones comment on ML :

We should split up javascript files to have the more generic ones includable in 
all screens, and the more specific ones (like the toggle* and selectAll* 
methods in there) into a file that can be included more locally. 

  was:
>From a David's E. Jones comment on ML :

Weshould split up javascript files to have the more generic ones includ-able in 
all screens, and the more specific ones (like the toggle* and selectAll* 
methods in there) into a file that can be included more locally. 


> Split javascript files to have more generic ones includ-able in all screens, 
> and the more specific ones included more locally
> -
>
> Key: OFBIZ-1319
> URL: https://issues.apache.org/jira/browse/OFBIZ-1319
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable 
> in all screens, and the more specific ones (like the toggle* and selectAll* 
> methods in there) into a file that can be included more locally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Track user for status change

[Jacques Le Roux]

+1

Jacques


Le 24/06/2016 à 15:26, Nameet Jain a écrit :

Hello everyone,

Currently in OFBiz, 'changedByUserLoginId' field is missing from status
entities (like: ShipmentStatus). Using this field we can maintain the
history for each status change made by user.

I will recommend here to add 'changedByUserLoginId' field to track the
userlogin detail. Here is the list of entities with missing such type of
field.

1. BudgetStatus
2. ContactListCommStatus
3. CustRequestStatus
4. ExampleStatus
5. FinAccountStatus
6. InventoryItemStatus
7. InvoiceStatus
8. PartyStatus
9. RequirementStatus
10. ShipmentStatus

Please let me know your thoughts. If it looks good I will open a ticket for
the same.

Thanks

--
Regards,
Nameet Jain

[jira] [Closed] (OFBIZ-7188) Add Work Effort Party Assignment creates record with invalid PartyId

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7188.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Gopal,

Your patch is in
trunk r1750166  
R15.12 r1750167
R14.12 r1750169 (conflicts handled by hand)
R13.07 r1750169 (conflicts handled by hand)




> Add Work Effort Party Assignment creates record with invalid PartyId
> 
>
> Key: OFBIZ-7188
> URL: https://issues.apache.org/jira/browse/OFBIZ-7188
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
>  Labels: workeffort
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7188.patch, OFBIZ-7188.patch
>
>
> Steps to regenerate:
> 1.  Go to FindWorkEffort screen 
> https://localhost:8443/workeffort/control/FindWorkEffort
> 2. Click on Find button in search option and choose any of the WorkEffort 
> from the list. 
> 3. Go to the Parties tab to check parties assigned to the WorkEffort.
> 4. Add Work Effort Party Assignment: 
>  - Enter any invalid PartyId (which does not exist in the system e.g, XYZ or 
> ABC)
> - Choose any of the roles from the drop-down list.
> - Add FromDate.
> - Submit the form.
> Current Behaviour: System creates a WorkEffortPartyAssignment record with 
> invalid data (partyId).
> Expected: System should not create this record as entered data - partyId is 
> invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7358) In Facility find shipment button doesn't work on first click

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348677#comment-15348677
 ] 

Jacques Le Roux commented on OFBIZ-7358:


Only trunk was concerned (broken by OFBIZ-7170)

> In Facility find shipment button doesn't work on first click
> 
>
> Key: OFBIZ-7358
> URL: https://issues.apache.org/jira/browse/OFBIZ-7358
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7358.patch
>
>
> Steps to generate:
> Click on Facility --> Shipments --> find button doesn't works on single click.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7602) Hide product sub menus while creating new product

[Nameet Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7602:
---
Attachment: CreateProduct.png

> Hide product sub menus while creating new product
> -
>
> Key: OFBIZ-7602
> URL: https://issues.apache.org/jira/browse/OFBIZ-7602
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nameet Jain
> Attachments: CreateProduct.png
>
>
> 1. Open Catalog Manager
> 2. Click "New Product"
> 3. All the Sub Menus are visible. 
> If we navigate to any sub menu (say: Content) and try to create it, system 
> returns error.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7602) Hide product sub menus while creating new product

[Nameet Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7602:
---
Priority: Minor  (was: Major)

> Hide product sub menus while creating new product
> -
>
> Key: OFBIZ-7602
> URL: https://issues.apache.org/jira/browse/OFBIZ-7602
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Priority: Minor
> Attachments: CreateProduct.png
>
>
> 1. Open Catalog Manager
> 2. Click "New Product"
> 3. All the Sub Menus are visible. 
> If we navigate to any sub menu (say: Content) and try to create it, system 
> returns error.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7602) Hide product sub menus while creating new product

[Nameet Jain (JIRA)]

Nameet Jain created OFBIZ-7602:
--

 Summary: Hide product sub menus while creating new product
 Key: OFBIZ-7602
 URL: https://issues.apache.org/jira/browse/OFBIZ-7602
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Nameet Jain


1. Open Catalog Manager
2. Click "New Product"
3. All the Sub Menus are visible. 

If we navigate to any sub menu (say: Content) and try to create it, system 
returns error.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Track user for status change

[Rishi Solanki]

+1, Nameet.

Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain 
wrote:

> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
> entities (like: ShipmentStatus). Using this field we can maintain the
> history for each status change made by user.
>
> I will recommend here to add 'changedByUserLoginId' field to track the
> userlogin detail. Here is the list of entities with missing such type of
> field.
>
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus
>
> Please let me know your thoughts. If it looks good I will open a ticket for
> the same.
>
> Thanks
>
> --
> Regards,
> Nameet Jain
>

[jira] [Created] (OFBIZ-7601) Enforce noninstantiability to UtilURL class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7601:


 Summary: Enforce noninstantiability to UtilURL class
 Key: OFBIZ-7601
 URL: https://issues.apache.org/jira/browse/OFBIZ-7601
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.

No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7590) Enforce noninstantiability to UtilIO class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7590:
-
Attachment: OFBIZ-7590.patch

1. Class is already final.
2. Making below public variable as private
{code}
public static final Charset UTF8 = Charset.forName("UTF-8");
{code}
3.  Wrote a getter method getUtf8() and replace its occurrences in file 
{code}
UtilIOTests.java
{code}

Thanks [~rishisolankii] for the details.

> Enforce noninstantiability to UtilIO class
> --
>
> Key: OFBIZ-7590
> URL: https://issues.apache.org/jira/browse/OFBIZ-7590
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7590.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class

[Rishi Solanki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-7600:
-
Attachment: OFBIZ-7600.patch

Providing patch as per the details mentioned in the ticket.

> Enforce noninstantiability to UtilPlist class
> -
>
> Key: OFBIZ-7600
> URL: https://issues.apache.org/jira/browse/OFBIZ-7600
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7600.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String indentFourString = "";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7589:
-
Attachment: (was: OFBIZ-7589.patch)

> Enforce noninstantiability to UtilHttp class
> 
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH = 
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH = 
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH = 
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), 
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch

> Enforce noninstantiability to UtilHttp class
> 
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH = 
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH = 
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH = 
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), 
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class

[Rishi Solanki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-7600:


Assignee: Rishi Solanki

> Enforce noninstantiability to UtilPlist class
> -
>
> Key: OFBIZ-7600
> URL: https://issues.apache.org/jira/browse/OFBIZ-7600
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String indentFourString = "";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7590) Enforce noninstantiability to UtilIO class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7590:


Assignee: Rohit Koushal

> Enforce noninstantiability to UtilIO class
> --
>
> Key: OFBIZ-7590
> URL: https://issues.apache.org/jira/browse/OFBIZ-7590
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7600) Enforce noninstantiability to UtilPlist class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7600:


 Summary: Enforce noninstantiability to UtilPlist class
 Key: OFBIZ-7600
 URL: https://issues.apache.org/jira/browse/OFBIZ-7600
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String indentFourString = "";
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch

Thanks [~rishisolankii] for the details. Here is the patch for the ticket

> Enforce noninstantiability to UtilHttp class
> 
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH = 
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH = 
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH = 
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), 
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7181) Error on Product Requirement Creation

[Ashish Vijaywargiya (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348337#comment-15348337
 ] 

Ashish Vijaywargiya edited comment on OFBIZ-7181 at 6/24/16 2:22 PM:
-

Thanks Ravi for the contribution. Your changes are committed at following 
revisions. Thanks Montalbano for your help in reviewing the patch and then 
providing the comment.

trunk - r1750115
R15.12 - r1750116
R14.12 - r1750117
R13.07 - r1750118


was (Author: toashishvijay):
Thanks Ravi for the contribution. Your changes are committed at following 
revisions.

trunk - r1750115
R15.12 - r1750116
R14.12 - r1750117
R13.07 - r1750118

> Error on Product Requirement Creation
> -
>
> Key: OFBIZ-7181
> URL: https://issues.apache.org/jira/browse/OFBIZ-7181
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7181_trunk.patch
>
>
> Step to regenerate:
> 1) Got to Order -> Requirements -> New Requirement
> 2) On Create Requirement form select  Requirement Type Id equals to "Product 
> Requirement"
> 3) Select any product and submit the form.
> 4) Here you get the broken screen.
> Root Cause:
> There is a seca rule on "createRequirement" service that triggered 
> "autoAssignRequirementToSupplier" for requirementTypeId equals to 
> "PRODUCT_REQUIREMENT". This service is generating error when quantity is not 
> passed to it. One can easily submit the form to create new requirement 
> without passing quantity as there is not client side validation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7181) Error on Product Requirement Creation

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7181.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Ravi for the contribution. Your changes are committed at following 
revisions.

trunk - r1750115
R15.12 - r1750116
R14.12 - r1750117
R13.07 - r1750118

> Error on Product Requirement Creation
> -
>
> Key: OFBIZ-7181
> URL: https://issues.apache.org/jira/browse/OFBIZ-7181
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7181_trunk.patch
>
>
> Step to regenerate:
> 1) Got to Order -> Requirements -> New Requirement
> 2) On Create Requirement form select  Requirement Type Id equals to "Product 
> Requirement"
> 3) Select any product and submit the form.
> 4) Here you get the broken screen.
> Root Cause:
> There is a seca rule on "createRequirement" service that triggered 
> "autoAssignRequirementToSupplier" for requirementTypeId equals to 
> "PRODUCT_REQUIREMENT". This service is generating error when quantity is not 
> passed to it. One can easily submit the form to create new requirement 
> without passing quantity as there is not client side validation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7347) If promo text contains any HTML elements elements, it is not getting properly rendered on order return screen

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7347.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Pritam for the contribution. Your changes are committed at following 
revisions. Thanks Jacques for your comment.

trunk - r1750109
R15.12 - r1750110
R14.12 - r1750111
R13.07 - r1750113

> If promo text contains any HTML elements elements, it is not getting properly 
> rendered on order return screen
> -
>
> Key: OFBIZ-7347
> URL: https://issues.apache.org/jira/browse/OFBIZ-7347
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7347-Trunk.patch, Promotion.png, Return.png
>
>
> Steps to regenerate:
> 1. Create an order for product 'WG-' with 5 quantity so that promo 'Test 
> Promo 1' gets applied.
> 2. Quick ship the same order.
> 3. Create return for the fulfilled order.
> 4. You can see in return item that promo description is rendered with HTML 
> elements.
> See attached screen shots for the details. (Promotion.png and Return.png)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7358) In Facility find shipment button doesn't work on first click

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7358.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Aman and Rahul for the contribution. Please refer trunk r1750114

> In Facility find shipment button doesn't work on first click
> 
>
> Key: OFBIZ-7358
> URL: https://issues.apache.org/jira/browse/OFBIZ-7358
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7358.patch
>
>
> Steps to generate:
> Click on Facility --> Shipments --> find button doesn't works on single click.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7589:


Assignee: Rohit Koushal

> Enforce noninstantiability to UtilHttp class
> 
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH = 
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH = 
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH = 
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), 
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7587) Enforce noninstantiability to UtilFormatOut class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7587:


Assignee: Rohit Koushal

> Enforce noninstantiability to UtilFormatOut class
> -
>
> Key: OFBIZ-7587
> URL: https://issues.apache.org/jira/browse/OFBIZ-7587
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as private static final. Also move it to 
> begining of the class with FIXME: comment
> {code}
> // --- price format handlers ---
> // FIXME: This is not thread-safe! DecimalFormat is not synchronized.
> static DecimalFormat priceDecimalFormat = new 
> DecimalFormat(UtilProperties.getPropertyValue("general", 
> "currency.decimal.format", "#,##0.00"));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7596) Error on deleting Party Invitation

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7596.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Ravi for the contribution. Your changes are committed at following 
revisions.

trunk - r1750105
R15.12 - r1750106
R14.12 - r1750107
R13.07 - r1750108

> Error on deleting Party Invitation
> --
>
> Key: OFBIZ-7596
> URL: https://issues.apache.org/jira/browse/OFBIZ-7596
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7596_trunk.patch
>
>
> Steps to regenerate:
> 1)  Go to party component.
> 2) Go to Invitation screen.
> 3) From the list delete any party invitation and see the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7516) Missing UI Label at Production Run Assoc screen

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7516.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Pritam and Deepak for the contribution/discussion. Your changes are 
committed at following revisions.

trunk - r1750100
R15.12 - r1750102
R14.12 - r1750103
R13.07 - r1750104

> Missing UI Label at Production Run Assoc screen
> ---
>
> Key: OFBIZ-7516
> URL: https://issues.apache.org/jira/browse/OFBIZ-7516
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7516-Trunk.patch, OFBIZ-7516-Trunk.patch
>
>
> Steps to regenerate:
> 1) Login to manufacturing -> JobShop
> 2) Find production run.
> 3) Go to any production run overview screen.
> 4) Click on Assocs.
> You can see UiLabels missing for panel names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7599) Entered To Name is not getting stored when creating Party Invitation

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7599:
-

 Summary: Entered To Name is not getting stored when creating Party 
Invitation
 Key: OFBIZ-7599
 URL: https://issues.apache.org/jira/browse/OFBIZ-7599
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi
Priority: Minor


Steps to regenerate:
1) Go to party component.
2) Go to Invitation screen.
3) Create an invitation with the To Name field filled. 

Name (firstName, middleName, lastName) from Person entity is saved instead of 
entered To Name.
Code snippet from "createPartyInvitation" service used to create party 
invitation.

{code}






{code}

Possible solution:
1) Remove "To Name" field from the Create form.
OR
2) Remove that code snippet from the service which is setting toName.
OR
3) Neither remove field from the form nor code snippet. If the toName is not 
passed from the UI then only used code snippet to set toName.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7596) Error on deleting Party Invitation

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-7596:
--

Assignee: Ashish Vijaywargiya  (was: Ravi Lodhi)

> Error on deleting Party Invitation
> --
>
> Key: OFBIZ-7596
> URL: https://issues.apache.org/jira/browse/OFBIZ-7596
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Attachments: OFBIZ-7596_trunk.patch
>
>
> Steps to regenerate:
> 1)  Go to party component.
> 2) Go to Invitation screen.
> 3) From the list delete any party invitation and see the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Amardeep Singh Jhajj]

Thanks all for approval.

Thanks Taher and Deepak for valuable suggestions. I will think on them.

Jacques,

I am bit confused by your reply, could you please elaborate your point.

Regards,
--
Amardeep Singh Jhajj


On Fri, Jun 24, 2016 at 4:17 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Amardeep,
>
> I agree with your points, I'd just request that we do that in a branch
> with a load of UI tests (good occasion to use Selenium).
> Our js code is complex and fragile, I think notably at the global
> variables in fieldlookup.js and selectall.js which are maybe hard to avoid.
> IMO those files are the main pains.
>
> Thanks
>
> Jacques
>
>
>
> Le 24/06/2016 à 09:20, Amardeep Singh Jhajj a écrit :
>
>> Hello everyone,
>>
>> Currently, OFBiz javascript code (except third party libraries) is not
>> written with the best practices which can cause following problems -
>>
>> 1. Increases the code maintenance effort.
>> 2. Impact page performance.
>> 3. Present not good examples to new contributors which leads to C/P to
>> various areas of js code.
>>
>> Here are things we should do for cleanup and improvements in js code.
>>
>> 1. Remove unused javascript code and files if any.
>> 2. Use best practices for javascript coding to improve performance (I have
>> listed some of it below).
>> 3. Move utility js functions to one js file.
>> 4. Remove deprecated code and use latest. For ex: We are still using
>> "language='javascript'" attribute at script tag which is deprecated a
>> years
>> ago.
>> 5. js should be loaded at bottom of the page, currently its in Header. Its
>> a tedious task now to move it into footer because we have lot of js code
>> inline in ftls.
>> 6. js should not be written inline, it should be enough generic to be in
>> minimum number of files and have generic code for doing the common set of
>> operations over DOM.
>> 7. Currently our macros of rendering pages has inline scripts, they can be
>> moved to one macrorenderer.js with generic code as we can use classes, ids
>> and data-attributes for doing any operation over html DOM.
>> 8. After all cleanup work, we can think of build tool (like grunt) for
>> various javascript build tasks (minification, concatenation of files) if
>> needed. Its just a thought.
>>
>> I know its a huge effort and need to be done carefully. So before doing
>> any
>> major changes, I would like to start work with first 4 points.
>>
>> Here is the list of some best practices to start with:
>>
>> 1. Use [] Instead of New Array()
>> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
>> 3. Reduce global variables
>> 4. Use explicit blocks
>> 5. Start blocks on the same line
>> 6. Always, Always Use Semicolons - Having said that, this is a very bad
>> practice that can potentially lead to much bigger, and harder to find,
>> issues.
>> 7. Optimize loops. Avoid calculating the length of array in for loop
>> iteration.
>> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
>> any object.
>> 9. Try to use meaningful comments.
>> 10. Many more.
>>
>> Here are some links of best practices information-
>>
>> https://www.w3.org/wiki/JavaScript_best_practices
>> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
>> https://developer.yahoo.com/performance/rules.html
>>
>> If everyone agrees, I would like to start on this work.
>>
>> Please let me know your thoughts on it.
>>
>> Thanks and Regards
>> --
>> Amardeep Singh Jhajj
>>
>>
>

[jira] [Closed] (OFBIZ-7556) Error occurred when making notes private/public from project screen

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7556.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Deepak Baghel for the contribution. Your changes are committed at 
following revisions.

trunk - r1750097
R15.12 - r1750098
R14.12 - r1750099

> Error occurred when making notes private/public from project screen
> ---
>
> Key: OFBIZ-7556
> URL: https://issues.apache.org/jira/browse/OFBIZ-7556
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Deepak Baghel
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7556-Trunk.patch
>
>
> Steps to regenerate :- 
> 1. Login into project component and select any created project from the 
> projects list.
> 2. Add note from note section and make it public/private.
> 3. See the notes in the project summary.
> 4. Try to make it public/private then error comes with below message
> {code}
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
> parameter [workEffortId] passed to secure (https) request-map with uri 
> [updateProjectNote] with an event that calls service [updateWorkEffortNote]; 
> this is not allowed for security reasons! The data should be encrypted by 
> making it part of the request body (a form field) instead of the request URL. 
> Moreover it would be kind if you could create a Jira sub-task of 
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task 
> for this error does not exist). If you are not sure how to create a Jira 
> issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 
> Thank you in advance for your help.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

[Suraj Khurana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7598:
-
Attachment: OFBIZ-7598.png

> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

[Suraj Khurana (JIRA)]

Suraj Khurana created OFBIZ-7598:


 Summary: Empty header row should not render if list to render in 
file is empty
 Key: OFBIZ-7598
 URL: https://issues.apache.org/jira/browse/OFBIZ-7598
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Suraj Khurana
Assignee: Suraj Khurana


If list inside form doesn't contain data, then header row should not render 
from better UI perspective and proper message should be shown to user.
Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7597) Entity auto services doesn't returns success message

[Suraj Khurana (JIRA)]

Suraj Khurana created OFBIZ-7597:


 Summary: Entity auto services doesn't returns success message
 Key: OFBIZ-7597
 URL: https://issues.apache.org/jira/browse/OFBIZ-7597
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Suraj Khurana
Assignee: Suraj Khurana


All the services which uses entity-auto engine should return proper success 
messages according to action.

With reference to EntityAutoEngine.java, proposed messages according to action:
For Create:  created successfully
For Update:  updated successfully
For Delete:  deleted successfully
For Expire:  expired successfully




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7596) Error on deleting Party Invitation

[Ravi Lodhi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-7596:
--
Attachment: OFBIZ-7596_trunk.patch

I looked around this issue and found that value="partyInvitationId" is used 
instead of from-field="partyInvitationId". Uploaded patch for the same.

> Error on deleting Party Invitation
> --
>
> Key: OFBIZ-7596
> URL: https://issues.apache.org/jira/browse/OFBIZ-7596
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
> Attachments: OFBIZ-7596_trunk.patch
>
>
> Steps to regenerate:
> 1)  Go to party component.
> 2) Go to Invitation screen.
> 3) From the list delete any party invitation and see the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7374) Add capability to Expire or Remove the added content for a party

[Swapnil Shah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah closed OFBIZ-7374.
---

Thanks [~ankush.upadhyay] I have tested the fixes and found them working fine:

Unit Tests:
# Expired the existing content by setting thru dateand it stopped getting 
applied (*PASS*)
# Added content with from date in future and it didn't get applied (*PASS*)
# Added content with from date in past and it correctly got applied (*PASS*)

> Add capability to Expire or Remove the added content for a party
> 
>
> Key: OFBIZ-7374
> URL: https://issues.apache.org/jira/browse/OFBIZ-7374
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: EditPartyContent.png, OFBIZ-7374.patch, 
> Party_content_1.png
>
>
> Currently when any content is uploaded/added with respect to any party via 
> Party Manager >> Parties >> Party Content tab, there is no option for user to 
> Expire or remove such added content in any form
> We could try adding this feature that could allow user to 
> # Expire any content by setting thru_date to now() on click of "Expire" 
> button against each content row
> # Or option to update the From/Thru date by showing these dates as editable 
> against each content row
> # Remove any added content on click of a "Delete" button 
> (Please refer to attached screenshot for reference)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Track user for status change

[Divesh Dutta]

Yea I think it makes sense.

Thanks
--
Divesh Dutta.

On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain 
wrote:

> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
> entities (like: ShipmentStatus). Using this field we can maintain the
> history for each status change made by user.
>
> I will recommend here to add 'changedByUserLoginId' field to track the
> userlogin detail. Here is the list of entities with missing such type of
> field.
>
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus
>
> Please let me know your thoughts. If it looks good I will open a ticket for
> the same.
>
> Thanks
>
> --
> Regards,
> Nameet Jain
>

[jira] [Created] (OFBIZ-7596) Error on deleting Party Invitation

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7596:
-

 Summary: Error on deleting Party Invitation
 Key: OFBIZ-7596
 URL: https://issues.apache.org/jira/browse/OFBIZ-7596
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Steps to regenerate:
1)  Go to party component.
2) Go to Invitation screen.
3) From the list delete any party invitation and see the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7524) Error on clicking Content Page button over Edit Product Config Item Content screen

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7524.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Ravi for the contribution. Your changes are committed at following 
revisions.

trunk - r1750092
R15.12 - r1750093
R14.12 - r1750094
R13.07 - r1750095

> Error on clicking Content Page button over Edit Product Config Item Content 
> screen
> --
>
> Key: OFBIZ-7524
> URL: https://issues.apache.org/jira/browse/OFBIZ-7524
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, 13.07.04
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7524_trunk.patch
>
>
> Steps to regenerate:
> 1) Go to Catalog -> Configuration
> 2) Search Config item and go to detail page of that item.
> 3) Now got to Content screen
> 4) Go to edit ant Product Config Item Content from the list. Create New 
> Product Config Item Content if not available.
> 5) In this page Click on "Content Page" button. 
> It will throw error:
> Unknown request [gotoContent]; this request does not exist or cannot be 
> called directly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7588:
-
Attachment: OFBIZ-7588.patch

Thanks [~rishisolankii] for the details. Here is the patch for the issue.

> Enforce noninstantiability to UtilGenerics class
> 
>
> Key: OFBIZ-7588
> URL: https://issues.apache.org/jira/browse/OFBIZ-7588
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7588.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7588:


Assignee: Rohit Koushal

> Enforce noninstantiability to UtilGenerics class
> 
>
> Key: OFBIZ-7588
> URL: https://issues.apache.org/jira/browse/OFBIZ-7588
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Track user for status change

[Nameet Jain]

Hello everyone,

Currently in OFBiz, 'changedByUserLoginId' field is missing from status
entities (like: ShipmentStatus). Using this field we can maintain the
history for each status change made by user.

I will recommend here to add 'changedByUserLoginId' field to track the
userlogin detail. Here is the list of entities with missing such type of
field.

1. BudgetStatus
2. ContactListCommStatus
3. CustRequestStatus
4. ExampleStatus
5. FinAccountStatus
6. InventoryItemStatus
7. InvoiceStatus
8. PartyStatus
9. RequirementStatus
10. ShipmentStatus

Please let me know your thoughts. If it looks good I will open a ticket for
the same.

Thanks

--
Regards,
Nameet Jain

[jira] [Closed] (OFBIZ-6293) If a party is both a contact and a lead, then SFA profile renders screens for both

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-6293.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Pierre for creating the issue and Thanks Ravi for providing the patch. 
Changes are committed at following revisions:

trunk - r1750089
R15.12 - r1750090
R14.12 - r1750091

> If a party is both a contact and a lead, then SFA profile renders screens for 
> both
> --
>
> Key: OFBIZ-6293
> URL: https://issues.apache.org/jira/browse/OFBIZ-6293
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6293_trunk.patch
>
>
> When a party is assigned both roles Contact and Lead, then the contact 
> profile shows all screens for the Lead profile too. And the lead profile 
> shows the screens for the contact too.
> In both cases this results in multiple screens shown twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7584) Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs.

[Anuj Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Jain updated OFBIZ-7584:
-
Attachment: OFBIZ-7584.patch

> Workeffort: Correct all the checkboxes and radio buttons in all the 
> workeffort FTLs.
> 
>
> Key: OFBIZ-7584
> URL: https://issues.apache.org/jira/browse/OFBIZ-7584
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7584.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7584) Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs.

[Anuj Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348242#comment-15348242
 ] 

Anuj Jain commented on OFBIZ-7584:
--

Hello [~Mohammad K],

Thanks for reporting this improvement, I have added a patch which will address 
this improvement throughout workeffort component ftls.

> Workeffort: Correct all the checkboxes and radio buttons in all the 
> workeffort FTLs.
> 
>
> Key: OFBIZ-7584
> URL: https://issues.apache.org/jira/browse/OFBIZ-7584
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7584.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7252) Error adding task to backlog

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7252.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Pritam and Montalbano for the contribution and discussion. I have 
committed the patch at following revisions:

trunk - r1750082
R15.12 - r1750084
R14.12 - r1750086

> Error adding task to backlog
> 
>
> Key: OFBIZ-7252
> URL: https://issues.apache.org/jira/browse/OFBIZ-7252
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Ashish Vijaywargiya
>  Labels: error, form, scrum, sprint, task
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7252-Trunk.patch
>
>
> There are several problems in the form to add a new task in a backlog. Step 
> to reproduce :
> - Go to the Scrum component and select a product sprint 
> (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1)
> - Scroll down to the Sprint Backlog List
> - Click on a button "Add Task"
> - See the error in the console.
> From there, it's not possible to create a new task. When clicking on the 
> create button, there is an error and the target is 
> "https://localhost:8443/scrum/control/updateSprintTask; where it should be 
> "https://localhost:8443/scrum/control/createSprintBacklogTask;. 
> I tried to solve the problem but it's beyond me. The form causing the problem 
> is scrumForms.xml#NewTaskForSprintBacklog and it extends the form 
> TaskForms.xml#EditSprintTask .
> Thanks,
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files

[Sanjay Yadav (JIRA)]

Sanjay Yadav created OFBIZ-7595:
---

 Summary: Replace references of Entity Engine methods with 
EntityQUery methods in various Groovy and Java Files
 Key: OFBIZ-7595
 URL: https://issues.apache.org/jira/browse/OFBIZ-7595
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Sanjay Yadav
Assignee: Sanjay Yadav
Priority: Minor


Replace references of Entity Engine methods with EntityQUery methods in various 
Groovy and Java Files.

This is a parent task to remove references of Entity Engine methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7188) Add Work Effort Party Assignment creates record with invalid PartyId

[Gopal Yadav (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gopal Yadav updated OFBIZ-7188:
---
Attachment: OFBIZ-7188.patch

Hi [~jacques.le.roux],

Thanks for reviewing the patch, I have corrected the demo data and updated the 
patch.

> Add Work Effort Party Assignment creates record with invalid PartyId
> 
>
> Key: OFBIZ-7188
> URL: https://issues.apache.org/jira/browse/OFBIZ-7188
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
>  Labels: workeffort
> Attachments: OFBIZ-7188.patch, OFBIZ-7188.patch
>
>
> Steps to regenerate:
> 1.  Go to FindWorkEffort screen 
> https://localhost:8443/workeffort/control/FindWorkEffort
> 2. Click on Find button in search option and choose any of the WorkEffort 
> from the list. 
> 3. Go to the Parties tab to check parties assigned to the WorkEffort.
> 4. Add Work Effort Party Assignment: 
>  - Enter any invalid PartyId (which does not exist in the system e.g, XYZ or 
> ABC)
> - Choose any of the roles from the drop-down list.
> - Add FromDate.
> - Submit the form.
> Current Behaviour: System creates a WorkEffortPartyAssignment record with 
> invalid data (partyId).
> Expected: System should not create this record as entered data - partyId is 
> invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7540) Enforce noninstantiability to FileUtil class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7540:


Assignee: Rohit Koushal

> Enforce noninstantiability to FileUtil class
> 
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7540.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the 
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7562) Enforce noninstantiability to UtilDateTime class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7562:
-
Attachment: OFBIZ-7562.patch

Thanks [~rishisolankii] for the details. Here is the patch for the ticket.

> Enforce noninstantiability to UtilDateTime class
> 
>
> Key: OFBIZ-7562
> URL: https://issues.apache.org/jira/browse/OFBIZ-7562
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7562.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String[] months = {
> "January", "February", "March", "April", "May", "June",
> "July", "August", "September", "October", "November",
> "December"
> };
> public static final String[] days = {
> "Monday", "Tuesday", "Wednesday",
> "Thursday", "Friday", "Saturday", "Sunday"
> };
> public static final String[][] timevals = {
> {"1000", "millisecond"},
> {"60", "second"},
> {"60", "minute"},
> {"24", "hour"},
> {"168", "week"}
> };
> public static final DecimalFormat df = new DecimalFormat("0.00;-0.00");
> public static final String DATE_FORMAT = "-MM-dd";
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> public static final String TIME_FORMAT = "HH:mm:ss";
> {code}
> - Add public static methods as getDateFormat(), getDateTimeFormat() and 
> getTimeFormat() methods and use them in following classes;
> {code}
> DateTimeConverters.java
> UelFunctions.java
> CommonWidgetModels.java
> ModelFormField.java
> SetCalendar.java
> EbayStoreAutoPreferences.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: OFBIZ-7518.patch

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: OFBIZ-7518.patch)

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7562) Enforce noninstantiability to UtilDateTime class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7562:


Assignee: Rohit Koushal

> Enforce noninstantiability to UtilDateTime class
> 
>
> Key: OFBIZ-7562
> URL: https://issues.apache.org/jira/browse/OFBIZ-7562
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String[] months = {
> "January", "February", "March", "April", "May", "June",
> "July", "August", "September", "October", "November",
> "December"
> };
> public static final String[] days = {
> "Monday", "Tuesday", "Wednesday",
> "Thursday", "Friday", "Saturday", "Sunday"
> };
> public static final String[][] timevals = {
> {"1000", "millisecond"},
> {"60", "second"},
> {"60", "minute"},
> {"24", "hour"},
> {"168", "week"}
> };
> public static final DecimalFormat df = new DecimalFormat("0.00;-0.00");
> public static final String DATE_FORMAT = "-MM-dd";
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> public static final String TIME_FORMAT = "HH:mm:ss";
> {code}
> - Add public static methods as getDateFormat(), getDateTimeFormat() and 
> getTimeFormat() methods and use them in following classes;
> {code}
> DateTimeConverters.java
> UelFunctions.java
> CommonWidgetModels.java
> ModelFormField.java
> SetCalendar.java
> EbayStoreAutoPreferences.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7551:
-
Attachment: OFBIZ-7551.patch

Thanks [~rishisolankii] for the  details. Here is the patch for the ticket.

> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7551.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and 
> getHostCertNormalCheck() public static methods and use them in following 
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348195#comment-15348195
 ] 

Ankush Upadhyay commented on OFBIZ-7518:


Thanks [~soledad] for patch review, yes seca call is more adaptive and I missed 
the references so use service group concept.

I have updated my patch and used seca call instead of service group.

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7551:


Assignee: Rohit Koushal

> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and 
> getHostCertNormalCheck() public static methods and use them in following 
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: RenderPartyAssignedRolesInDropDown.patch)

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: EnsureAndCreateProductStoreRole.patch)

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: OFBIZ-7518.patch

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7540) Enforce noninstantiability to FileUtil class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-7540:
-
Attachment: OFBIZ-7540.patch

Thanks [~rishisolankii] for the details. Here is the patch for the ticket.

> Enforce noninstantiability to FileUtil class
> 
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7540.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the 
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7594) Unable to delete a survey in project component

[Deepak Baghel (JIRA)]

Deepak Baghel created OFBIZ-7594:


 Summary: Unable to delete a survey in project component
 Key: OFBIZ-7594
 URL: https://issues.apache.org/jira/browse/OFBIZ-7594
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Trunk
Reporter: Deepak Baghel
Assignee: Deepak Baghel


Step to regenerate 

1. Login into project component.
2. Go to the task section.
3. Find the task.
4. Go to the any of the task from the list.
5. Then go to surveys section
6. Try to delete the survey, if any exist.
7. Surveys are unable to delete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay reassigned OFBIZ-7518:
--

Assignee: Ankush Upadhyay

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: EnsureAndCreateProductStoreRole.patch, 
> ProductStoreRoleError.png, RenderPartyAssignedRolesInDropDown.patch
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Jacques Le Roux]

Amardeep,

I agree with your points, I'd just request that we do that in a branch with a 
load of UI tests (good occasion to use Selenium).
Our js code is complex and fragile, I think notably at the global variables in 
fieldlookup.js and selectall.js which are maybe hard to avoid.
IMO those files are the main pains.

Thanks

Jacques


Le 24/06/2016 à 09:20, Amardeep Singh Jhajj a écrit :

Hello everyone,

Currently, OFBiz javascript code (except third party libraries) is not
written with the best practices which can cause following problems -

1. Increases the code maintenance effort.
2. Impact page performance.
3. Present not good examples to new contributors which leads to C/P to
various areas of js code.

Here are things we should do for cleanup and improvements in js code.

1. Remove unused javascript code and files if any.
2. Use best practices for javascript coding to improve performance (I have
listed some of it below).
3. Move utility js functions to one js file.
4. Remove deprecated code and use latest. For ex: We are still using
"language='javascript'" attribute at script tag which is deprecated a years
ago.
5. js should be loaded at bottom of the page, currently its in Header. Its
a tedious task now to move it into footer because we have lot of js code
inline in ftls.
6. js should not be written inline, it should be enough generic to be in
minimum number of files and have generic code for doing the common set of
operations over DOM.
7. Currently our macros of rendering pages has inline scripts, they can be
moved to one macrorenderer.js with generic code as we can use classes, ids
and data-attributes for doing any operation over html DOM.
8. After all cleanup work, we can think of build tool (like grunt) for
various javascript build tasks (minification, concatenation of files) if
needed. Its just a thought.

I know its a huge effort and need to be done carefully. So before doing any
major changes, I would like to start work with first 4 points.

Here is the list of some best practices to start with:

1. Use [] Instead of New Array()
2. Long list of variables? Omit the "Var" keyword and use commas instead.
3. Reduce global variables
4. Use explicit blocks
5. Start blocks on the same line
6. Always, Always Use Semicolons - Having said that, this is a very bad
practice that can potentially lead to much bigger, and harder to find,
issues.
7. Optimize loops. Avoid calculating the length of array in for loop
iteration.
8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
any object.
9. Try to use meaningful comments.
10. Many more.

Here are some links of best practices information-

https://www.w3.org/wiki/JavaScript_best_practices
http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
https://developer.yahoo.com/performance/rules.html

If everyone agrees, I would like to start on this work.

Please let me know your thoughts on it.

Thanks and Regards
--
Amardeep Singh Jhajj

[jira] [Updated] (OFBIZ-7473) Induce Model XML from Database throws exception

[Gopal Yadav (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gopal Yadav updated OFBIZ-7473:
---
Attachment: OFBIZ-7473.patch

Attached patch for this issue, in which I have corrected the location of the 
file ModelInduceFromDb.jsp

> Induce Model XML from Database throws exception
> ---
>
> Key: OFBIZ-7473
> URL: https://issues.apache.org/jira/browse/OFBIZ-7473
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Gopal Yadav
> Attachments: OFBIZ-7473.patch
>
>
> Go to Webtools -> Import/Export -> Induce Model XML from Database 
> (https://localhost:8443/webtools/control/view/ModelInduceFromDb)
> An exception is thrown: javax.servlet.ServletException: File 
> [/entity/ModelInduceFromDb.jsp] not found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7563) Error message not visible properly after adding item in webpos

[Suraj Khurana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7563:
-
Attachment: OFBIZ-7563

Attached patch with proper fix. Increased section top-margin so that it won't 
overlap in above section.

> Error message not visible properly after adding item in webpos
> --
>
> Key: OFBIZ-7563
> URL: https://issues.apache.org/jira/browse/OFBIZ-7563
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-7563, OFBIZ-7563.png
>
>
> Steps to generate:
> - Go to Web Pos:
> - Click on search button on product search.
> - Click on product CPU 586 to add it to cart.
> - As no valid product price is not associated with product, then it should 
> not be added to cart, and show proper error message.
> - Error message is not properly visible to user due to overlapped div. 
> (Please refer screenshot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7592) Show price column in supplier product lookup during PO creation

[Pranay Pandey (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348120#comment-15348120
 ] 

Pranay Pandey commented on OFBIZ-7592:
--

Hi Yash,
There is a best practice of naming patch that you upload to JIRA Ticket. You 
should name it with JIRA Ticket ID, so in this case the patch name could be 
"OFBIZ-7592.patch", and if you provide patches for branches too, it can be 
OFBIZ-7592-1412.patch OFBIZ-7592-1512.patch.

> Show price column in supplier product lookup during PO creation
> ---
>
> Key: OFBIZ-7592
> URL: https://issues.apache.org/jira/browse/OFBIZ-7592
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Priority: Minor
> Attachments: productfeature.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7593) Enforce noninstantiability to UtilNumber class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7593:


 Summary: Enforce noninstantiability to UtilNumber class
 Key: OFBIZ-7593
 URL: https://issues.apache.org/jira/browse/OFBIZ-7593
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private and move it to top with 
static block
{code}
// ICU4J rule sets for the en_US locale. To add more rules, expand this 
string.
// For reference, see the RbnfSampleRuleSets.java file distributed with 
ICU4J
public static final String ruleSet_en_US =
/*
 * These rules format a number in one of the two styles often used
 * on checks.  %dollars-and-hundredths formats cents as hundredths of
 * a dollar (23.40 comes out as "twenty-three and 40/100 dollars").
 * %dollars-and-cents formats in dollars and cents (23.40 comes out as
 * "twenty-three dollars and forty cents")
 */
"%dollars-and-cents:\n"
+ "x.0: << [and >%%cents>];\n"
+ "0.x: >%%cents>;\n"
+ "0: zero dollars; one dollar; =%%main= dollars;\n"
+ "%%main:\n"
+ "zero; one; two; three; four; five; six; seven; eight; nine;\n"
+ "ten; eleven; twelve; thirteen; fourteen; fifteen; sixteen;\n"
+ "seventeen; eighteen; nineteen;\n"
+ "20: twenty[->>];\n"
+ "30: thirty[->>];\n"
+ "40: forty[->>];\n"
+ "50: fifty[->>];\n"
+ "60: sixty[->>];\n"
+ "70: seventy[->>];\n"
+ "80: eighty[->>];\n"
+ "90: ninety[->>];\n"
+ "100: << hundred[ >>];\n"
+ "1000: << thousand[ >>];\n"
+ "1,000,000: << million[ >>];\n"
+ "1,000,000,000: << billion[ >>];\n"
+ "1,000,000,000,000: << trillion[ >>];\n"
+ "1,000,000,000,000,000: =#,##0=;\n"
+ "%%cents:\n"
+ "100: <%%main< cent[s];\n"
+ "%dollars-and-hundredths:\n"
+ "x.0: <%%main< and >%%hundredths>/100;\n" // this used to end in 
'dollars' but that should be added later
+ "%%hundredths:\n"
+ "100: <00<;\n";

// ICU4J rule sets for the th_TH locale. To add more rules, expand this 
string.
// For reference, see the RbnfSampleRuleSets.java file distributed with 
ICU4J
public static final String ruleSet_th_TH =
/*
 * These rules format a number in one of the two styles often used
 * on checks.  %bahts-and-hundredths formats stangs as hundredths of
 * a baht (23.40 comes out as "twenty-three and 40/100 bahts").
 * %bahts-and-stangs formats in bahts and stangs (23.40 comes out as
 * "twenty-three bahts and forty stangs")
 */
"%bahts-and-stangs:\n"
+ "x.0: << [and >%%stangs>];\n"
+ "0.x: >%%stangs>;\n"
+ "0: zero bahts; one baht; =%%main= bahts;\n"
+ "%%main:\n"
+ "zero; one; two; three; four; five; six; seven; eight; nine;\n"
+ "ten; eleven; twelve; thirteen; fourteen; fifteen; sixteen;\n"
+ "seventeen; eighteen; nineteen;\n"
+ "20: twenty[->>];\n"
+ "30: thirty[->>];\n"
+ "40: forty[->>];\n"
+ "50: fifty[->>];\n"
+ "60: sixty[->>];\n"
+ "70: seventy[->>];\n"
+ "80: eighty[->>];\n"
+ "90: ninety[->>];\n"
+ "100: << hundred[ >>];\n"
+ "1000: << thousand[ >>];\n"
+ "1,000,000: << million[ >>];\n"
+ "1,000,000,000: << billion[ >>];\n"
+ "1,000,000,000,000: << trillion[ >>];\n"
+ "1,000,000,000,000,000: =#,##0=;\n"
+ "%%stangs:\n"
+ "100: <%%main< stang[s];\n"
+ "%bahts-and-hundredths:\n"
+ "x.0: <%%main< and >%%hundredths>/100;\n" // this used to end in 
'bahts' but that should be added later
+ "%%hundredths:\n"
+ "100: <00<;\n";

// hash map to store ICU4J rule sets keyed to Locale
public static HashMap rbnfRuleSets;
static {
rbnfRuleSets = new HashMap();
rbnfRuleSets.put(Locale.US, ruleSet_en_US);
rbnfRuleSets.put(new Locale("th"), ruleSet_th_TH);
}

{code}





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7592) Show price column in supplier product lookup during PO creation

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-7592:
---
Attachment: productfeature.patch

Please find patch for the issue.

> Show price column in supplier product lookup during PO creation
> ---
>
> Key: OFBIZ-7592
> URL: https://issues.apache.org/jira/browse/OFBIZ-7592
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Priority: Minor
> Attachments: productfeature.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1160964 - /ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml

[Jacques Le Roux]

Hi Hans,

I stumbled upon this by chance, not sure how UpdateContentPurposeOperation is 
supposed to work.

+

is not correct (misses the value-field attribute)

Thanks

Jacques

Le 24/08/2011 à 04:38, hans...@apache.org a écrit :

Author: hansbak
Date: Wed Aug 24 02:38:54 2011
New Revision: 1160964

URL: http://svn.apache.org/viewvc?rev=1160964=rev
Log:
another formsfile where the content was lost

Modified:
 ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml

Modified: 
ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml?rev=1160964=1160963=1160964=diff
==
--- ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml 
(original)
+++ ofbiz/trunk/applications/content/widget/contentsetup/ContentSetupForms.xml 
Wed Aug 24 02:38:54 2011
@@ -0,0 +1,233 @@
+
+
+
+http://www.w3.org/2001/XMLSchema-instance;
+
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-form.xsd;>
+
+
+
+
+
+
+
+
+
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+   
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

[jira] [Created] (OFBIZ-7592) Show price column in supplier product lookup during PO creation

[Nameet Jain (JIRA)]

Nameet Jain created OFBIZ-7592:
--

 Summary: Show price column in supplier product lookup during PO 
creation
 Key: OFBIZ-7592
 URL: https://issues.apache.org/jira/browse/OFBIZ-7592
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Nameet Jain
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7591) Enforce noninstantiability to UtilJavaParse class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7591:


 Summary: Enforce noninstantiability to UtilJavaParse class
 Key: OFBIZ-7591
 URL: https://issues.apache.org/jira/browse/OFBIZ-7591
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private and move them to top of 
class. Also move the static block initializing it.
{code}
// FIXME: Not thread safe
public static Set serviceMethodNames = new HashSet();
static {
serviceMethodNames.add("runSync");
serviceMethodNames.add("runSyncIgnore");
serviceMethodNames.add("runAsync");
serviceMethodNames.add("runAsyncWait");
serviceMethodNames.add("registerCallback");
serviceMethodNames.add("schedule"); // NOTE: the service name may be 
the 1st, 2nd or 3rd param for variations on this
serviceMethodNames.add("addRollbackService");
serviceMethodNames.add("addCommitService");
}

{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

[Divesh Dutta (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348054#comment-15348054
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

[~Peter Arnold] we can create a separate ticket for this problem . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party 

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

[Divesh Dutta (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348052#comment-15348052
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the 

[jira] [Issue Comment Deleted] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

[Divesh Dutta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6576:

Comment: was deleted

(was: Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . )

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID 

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

[Divesh Dutta (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348053#comment-15348053
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the 

[jira] [Created] (OFBIZ-7590) Enforce noninstantiability to UtilIO class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7590:


 Summary: Enforce noninstantiability to UtilIO class
 Key: OFBIZ-7590
 URL: https://issues.apache.org/jira/browse/OFBIZ-7590
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.

No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Ashish Vijaywargiya]

Very good idea Amardeep. Big +1.

--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997
https://www.linkedin.com/in/ashishvijaywargiya1

On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>

Re: Javascript clean up and improvements

[Rishi Solanki]

+1.

Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Fri, Jun 24, 2016 at 2:13 PM, Divesh Dutta <
divesh.du...@hotwaxsystems.com> wrote:

> +1 Amardeep.
>
>
> Thanks
> --
> Divesh Dutta.
>
> On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
> amardeep.jh...@hotwaxsystems.com> wrote:
>
> > Hello everyone,
> >
> > Currently, OFBiz javascript code (except third party libraries) is not
> > written with the best practices which can cause following problems -
> >
> > 1. Increases the code maintenance effort.
> > 2. Impact page performance.
> > 3. Present not good examples to new contributors which leads to C/P to
> > various areas of js code.
> >
> > Here are things we should do for cleanup and improvements in js code.
> >
> > 1. Remove unused javascript code and files if any.
> > 2. Use best practices for javascript coding to improve performance (I
> have
> > listed some of it below).
> > 3. Move utility js functions to one js file.
> > 4. Remove deprecated code and use latest. For ex: We are still using
> > "language='javascript'" attribute at script tag which is deprecated a
> years
> > ago.
> > 5. js should be loaded at bottom of the page, currently its in Header.
> Its
> > a tedious task now to move it into footer because we have lot of js code
> > inline in ftls.
> > 6. js should not be written inline, it should be enough generic to be in
> > minimum number of files and have generic code for doing the common set of
> > operations over DOM.
> > 7. Currently our macros of rendering pages has inline scripts, they can
> be
> > moved to one macrorenderer.js with generic code as we can use classes,
> ids
> > and data-attributes for doing any operation over html DOM.
> > 8. After all cleanup work, we can think of build tool (like grunt) for
> > various javascript build tasks (minification, concatenation of files) if
> > needed. Its just a thought.
> >
> > I know its a huge effort and need to be done carefully. So before doing
> any
> > major changes, I would like to start work with first 4 points.
> >
> > Here is the list of some best practices to start with:
> >
> > 1. Use [] Instead of New Array()
> > 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> > 3. Reduce global variables
> > 4. Use explicit blocks
> > 5. Start blocks on the same line
> > 6. Always, Always Use Semicolons - Having said that, this is a very bad
> > practice that can potentially lead to much bigger, and harder to find,
> > issues.
> > 7. Optimize loops. Avoid calculating the length of array in for loop
> > iteration.
> > 8. Avoid multiple redundant jQuery DOM manupulation by saving reference
> to
> > any object.
> > 9. Try to use meaningful comments.
> > 10. Many more.
> >
> > Here are some links of best practices information-
> >
> > https://www.w3.org/wiki/JavaScript_best_practices
> > http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> > https://developer.yahoo.com/performance/rules.html
> >
> > If everyone agrees, I would like to start on this work.
> >
> > Please let me know your thoughts on it.
> >
> > Thanks and Regards
> > --
> > Amardeep Singh Jhajj
> >
>

[jira] [Created] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7589:


 Summary: Enforce noninstantiability to UtilHttp class
 Key: OFBIZ-7589
 URL: https://issues.apache.org/jira/browse/OFBIZ-7589
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final String MULTI_ROW_DELIMITER = "_o_";
public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
public static final String COMPOSITE_DELIMITER = "_c_";
public static final int MULTI_ROW_DELIMITER_LENGTH = 
MULTI_ROW_DELIMITER.length();
public static final int ROW_SUBMIT_PREFIX_LENGTH = 
ROW_SUBMIT_PREFIX.length();
public static final int COMPOSITE_DELIMITER_LENGTH = 
COMPOSITE_DELIMITER.length();

public static final String SESSION_KEY_TIMEZONE = "timeZone";
{code}

- Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(), 
and use them in following classes/scripts;
{code}
GlEvents.java
ShoppingCartEvents.java
CheckAction.groovy
CheckRejected.groovy
ServiceMultiEventHandler.java
EbayEvents.java
{code}

No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348021#comment-15348021
 ] 

Jacques Le Roux commented on OFBIZ-7576:


Yes both CAN be done, but replacing the bshInterpreter with groovyShell should 
not hide the awful code. In other words both SHOULD be done ;)

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348019#comment-15348019
 ] 

Jacques Le Roux commented on OFBIZ-7061:


Fixed at revision: 1750050 .It was the only case like that (checked in Eclipse 
using validate, there are tons of other minor issues BTW)

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348006#comment-15348006
 ] 

Deepak Dixit edited comment on OFBIZ-7576 at 6/24/16 8:45 AM:
--

We can use groovyShell instead of bshInterpreter, and than can replace 
{code}

{code} with single quote.




was (Author: deepak.dixit):
We can use groovyShell instead of bshInterpreter, and than can replace 
{code}"{code} with single quote.



> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7588:


 Summary: Enforce noninstantiability to UtilGenerics class
 Key: OFBIZ-7588
 URL: https://issues.apache.org/jira/browse/OFBIZ-7588
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.

No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348006#comment-15348006
 ] 

Deepak Dixit commented on OFBIZ-7576:
-

We can use groovyShell instead of bshInterpreter, and than can replace 
{code}"{code} with single quote.



> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Divesh Dutta]

+1 Amardeep.


Thanks
--
Divesh Dutta.

On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348000#comment-15348000
 ] 

Jacques Le Roux commented on OFBIZ-7576:


Yes, but the code would still be awful :/ It's not for (hypothetical) 
performance reasons that I suggested that, but why do you suggest this?

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Divesh Dutta (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347996#comment-15347996
 ] 

Divesh Dutta commented on OFBIZ-7576:
-

Thanks [~jacques.le.roux] for committing this patch . If you get time, feel 
free to pick other tickets which are assigned to me and  patches are available 
for them :)

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7587) Enforce noninstantiability to UtilFormatOut class

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7587:


 Summary: Enforce noninstantiability to UtilFormatOut class
 Key: OFBIZ-7587
 URL: https://issues.apache.org/jira/browse/OFBIZ-7587
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following static variable as private static final. Also move it to 
begining of the class with FIXME: comment
{code}
// --- price format handlers ---
// FIXME: This is not thread-safe! DecimalFormat is not synchronized.
static DecimalFormat priceDecimalFormat = new 
DecimalFormat(UtilProperties.getPropertyValue("general", 
"currency.decimal.format", "#,##0.00"));

{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347993#comment-15347993
 ] 

Jacques Le Roux commented on OFBIZ-7576:


Wait... because of Jira stubbornly not refreshing (I know, I'm a dreamer), I 
missed the new patch.

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Deepak Dixit]

Hi Amardeep,

I agree with you current js code is not written as per the best practice.
Here are some inputs from my side.
Please see comments inline:



On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
>

Here is the existing ticket for same:
https://issues.apache.org/jira/browse/OFBIZ-1319


> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.

4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.

5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
>


We can't load all js file at bottom, library file should be loaded at top
and utility and other js can be loaded at bottom on screen.



> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.

7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.

8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>



We can use html5 based data element as well in js to remove inline
scripting.


Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

[Swapnil M Mane (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347988#comment-15347988
 ] 

Swapnil M Mane commented on OFBIZ-7061:
---

Thanks [~jacques.le.roux]!

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Enforce noninstantiability with a private constructor

[Rishi Solanki]

Team,

We have started pushing changes into trunk, in case anyone would like to
review then we are keeping it very simple;
- For any class we have an sub ticket with class name.
- On the ticket description we are posting the changes needs to be done,
then discuss and finalize the changes.
- Upload the patch with same finalized changes and edit the ticket's
description accordingly.

If you would like to review, then commit, patch and ticket description all
are same so that can be reviewed easily. Thanks!


Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Sat, Jun 18, 2016 at 7:56 PM, Rishi Solanki 
wrote:

> Moving thread to dev list.
>
> All, we have started effort on this under OFBIZ-7272. In that effort we
> found some classes isn't in use. Once completed this effort we will share
> them for discussion so that we can decide weather to keep them in OFBiz or
> we are good to remove them.
>
>
> --
> Rishi Solanki
> Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
> -- Forwarded message --
> From: Rishi Solanki 
> Date: Fri, Jun 10, 2016 at 7:40 PM
> Subject: Re: Enforce noninstantiability with a private constructor
> To: ofbizuser 
>
>
> Taher,
>
> Thank you very much for your inputs. I was thinking to do the same to add
> private constructors first then do other things. But after your reply I
> think better to pick one class at a time, and check everything for that
> class which includes removing public modifiers, method and fields. Marking
> classes members as final and all your suggestions.
>
> We would start picking classes one by one, and check all its references
> and finally make necessary changes for each class. In that way we would be
> able to match the classes with purpose. This is better way to fix this
> design flaw.
>
> Thanks!
>
>
> Rishi Solanki
> Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
> On Fri, Jun 10, 2016 at 5:00 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com> wrote:
>
>> Hi Rishi,
>>
>> I would suggest when refactoring such classes to apply everything that has
>> to do with visibility including:
>> - Removing public modifiers if not needed on class, method, and field
>> levels
>> - adding private where appropriate
>> - marking classes, methods and fields as final where appropriate
>> - marking method arguments as final where appropriate
>>
>> So I would consider a private constructor to be just one of a suite of
>> activites that I call them collectively as visibility and mutability which
>> are important to provide real isolation between the components with
>> minimal
>> dependencies.
>>
>> My 2 cents
>>
>> Taher Alkhateeb
>>
>> On Fri, Jun 10, 2016 at 2:22 PM, Rishi Solanki 
>> wrote:
>>
>> > Dear All,
>> >
>> > In past we did same for CatalogWorker, ProductWorker, CategoryWorker,
>> and
>> > UtilMisc classed. Now I think for all the utility, worker, helper
>> classes
>> > having only static members are eligible to have an private constructor
>> with
>> > them to make them non instantiable from anywhere.
>> >
>> > We have log an JIra and added patch for the same. So requesting you to
>> take
>> > a look at OFBIZ-7272 for more details and share your feedback in case we
>> > can do the same for more classes or if any classes we have added should
>> not
>> > be in list.
>> >
>> > Thanks for your help in advance.
>> >
>> >
>> > Rishi Solanki
>> > Manager, Enterprise Software Development
>> > HotWax Systems Pvt. Ltd.
>> > Direct: +91-9893287847
>> > http://www.hotwaxsystems.com
>> >
>>
>
>
>

Re: Javascript clean up and improvements

[Pranay Pandey]

+1 for the recommendation Amardeep.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>

[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347972#comment-15347972
 ] 

Deepak Dixit commented on OFBIZ-7576:
-

Hi [~jacques.le.roux],

I think we can replace the bshInterpreter with groovyShell so by default form 
widget uses groovyShell instead of bshInterpreter.

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347964#comment-15347964
 ] 

Jacques Le Roux commented on OFBIZ-7061:


Thanks Swapnil,

Actually this was lost earlier in 
[r1749488|http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/PortalPageForms.xml?limit_changes=0=1749488=1749487=1749488]

I will check that there are no other cases like that!

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

[Montalbano Florian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Montalbano Florian updated OFBIZ-7576:
--
Attachment: OFBIZ-7576_proposition.patch

Hi,
I was wondering the difference between the submitted patch and this solution 
(proposition.patch).
Is there one with better performance or are they quite equivalent ?

Thanks.

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Javascript clean up and improvements

[Taher Alkhateeb]

and +1 for your recommendations

On Friday, 24 June 2016, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>

Re: Javascript clean up and improvements

[Taher Alkhateeb]

Hi Amardeep,

In my opinion, the absolute best thing you can do for JavaScript is to run
it through jslint. If you are serious about the work, I would suggest you
take all the JavaScript files and snippets inside FTL files and run them
inside jslint and fix the issues one by one. That would automatically
include best practices from what I consider the king of JavaScript: Douglas
Crockford.

my 2 cents

Taher Alkhateeb

On Friday, 24 June 2016, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>

Re: svn commit: r1750045 - /ofbiz/trunk/applications/party/widget/partymgr/LookupScreens.xml

[Jacques Le Roux]

+1 for 1 option (yes, I'm lazy). Of course people preferring the std groovy 
snippet could continue to use it :p

Jacques


Le 24/06/2016 à 09:14, Nicolas Malin a écrit :

Le 24/06/2016 09:00, jler...@apache.org a écrit :

+

This commit is fine and when I read it, I ask myself if a dsl groovy syntax 
would be define like as example

${groovy: entity condition make([['roleTypeId' : 'CONTACT']]}

${groovy: entity condition make([andCondition, ['roleTypeId' : 'CONTACT']]}

${groovy: entity condition make([andCondition, make ('roleTypeId', NOT_EQUALS,  
'CONTACT')]}

It's completly open idea

Nicoals