[jira] [Reopened] (OFBIZ-7112) EntityUtilProperties
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reopened OFBIZ-7112: please see my comment at: https://issues.apache.org/jira/browse/OFBIZ-7754 where i propose to revert this change. > EntityUtilProperties > > > Key: OFBIZ-7112 > URL: https://issues.apache.org/jira/browse/OFBIZ-7112 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, > OFBIZ-7112.patch > > > Ofbiz reads properties from either a properties file or the > entity:SystemProperty. The way it works previously is that ofbiz reads from > the entity:SystemProperty first and if there is no value associated with the > target propertyname, it would then locate the value from the relevant > properties file. > In other words, if there is a database entry for a property, the database > entry should override the associated properties file. > The issue is that if a database entry exist but the value is empty, it would > look for a value from the properties file. It should not do so. If a > database entry exists for the propertyname of interest, the value should be > taken from the database even if it holds an empty value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364925#comment-15364925 ] Jacques Le Roux commented on OFBIZ-7680: Should we not rather fix (for those which are used) and get rid of useless parts? Who will misse CompDocTemplateTree.xml for instance? I curious about it! Other opinions? > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364884#comment-15364884 ] Nicolas Malin commented on OFBIZ-7680: -- :) Yes at first time I was going for correct all instantiation error but after this discover I don't know well these form to be sure not introduce a regression. And on second time I found that indicate context on value-field is really explicit when you read the form code ;) > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364499#comment-15364499 ] Jacques Le Roux edited comment on OFBIZ-7680 at 7/6/16 6:34 PM: Hi Nicolas, This souds like a hack to me, maybe a smart hack but still a hack. This would *maybe* (did not check) fixes the issues locally but would introduce confusion elsewhere. I'd prefer to check the occurrences one by one and see what we should do with them. Surprisingly the issues in CompDocTemplateTree.xml are very old (pre Apache era) and it seems nobody complained since. I just had a quick look at the CompDocTemplateTree case, I wonder if somebody is really using stuff like https://localhost:8443/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201 I'll try to have a look at the other cases... was (Author: jacques.le.roux): Hi Nicolas, This souds like a hack to me, maybe a smart hack but still a hack. This would *maybe* (did not check) fixes the issues locally but would introduce confusion elsewhere. I'd prefer to check the occurrences one and one and see what we should do with them. Surprisingly the issues in CompDocTemplateTree.xml are very old (pre Apache Era) and it seems nobody complained since. I just had a quick look at the CompDocTemplateTree case, I wonder if somebody is really using stuff like https://localhost:8443/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201 I'll try to have a look at the other cases... > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364837#comment-15364837 ] Jacques Le Roux commented on OFBIZ-7544: I agree Swapnil, but really the bare HTML multi-select is awful for users, better to always use jquery multi-select IMO. > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7608) On Product>>Agreement screen rename the button label to create new agreement from "Edit Agreement" to "Create Agreement"
[ https://issues.apache.org/jira/browse/OFBIZ-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Shah updated OFBIZ-7608: Assignee: Divesh Dutta (was: Swapnil Shah) > On Product>>Agreement screen rename the button label to create new agreement > from "Edit Agreement" to "Create Agreement" > > > Key: OFBIZ-7608 > URL: https://issues.apache.org/jira/browse/OFBIZ-7608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Minor > Attachments: OFBIZ-7608.patch, PA.png > > > Please refer to attached screenshot and change the button label to "Create > Agreement" as currently no agreement exists for given product -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364693#comment-15364693 ] Swapnil Shah commented on OFBIZ-7544: - I agree that check box is more convenient when there are comparatively fewer options to select from (i.e. less than 8-9 options). At the same time other patterns like multi-select jquery or multi-select within drop-down itself could be preferred choice when there are relatively large number to choose from (i.e >10 options) as in those cases showing all options at a time in form of checkboxes would distort UI and consume lot of screen real estate > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity
[ https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Shah resolved OFBIZ-7512. - Resolution: Fixed > 'Issue Component' option after partial issuance against required component > quantity is not accounting for already issued quantity > - > > Key: OFBIZ-7512 > URL: https://issues.apache.org/jira/browse/OFBIZ-7512 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, > 15.12.01 >Reporter: Swapnil Shah >Assignee: Divesh Dutta > Attachments: OFBIZ-7173.png, OFBIZ-7512.patch > > > Once we issue the required component partially (i.e. by producing partial > quantity while task is still is still running or in case full ATP against > required quantity is not available for issuance) then "Issue Component" is > not honoring the already made issuance and hence issuing the whole required > quantity once again. (please refer to attached screenshot) > !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity
[ https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364661#comment-15364661 ] Swapnil Shah commented on OFBIZ-7512: - Thanks [~anuj.jain] I have validated the fixes and its working as expected. [~diveshdut] You may like to close this one after backporting the changes so assigning back to you for closure.. > 'Issue Component' option after partial issuance against required component > quantity is not accounting for already issued quantity > - > > Key: OFBIZ-7512 > URL: https://issues.apache.org/jira/browse/OFBIZ-7512 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, > 15.12.01 >Reporter: Swapnil Shah >Assignee: Divesh Dutta > Attachments: OFBIZ-7173.png, OFBIZ-7512.patch > > > Once we issue the required component partially (i.e. by producing partial > quantity while task is still is still running or in case full ATP against > required quantity is not available for issuance) then "Issue Component" is > not honoring the already made issuance and hence issuing the whole required > quantity once again. (please refer to attached screenshot) > !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364499#comment-15364499 ] Jacques Le Roux commented on OFBIZ-7680: Hi Nicolas, This souds like a hack to me, maybe a smart hack but still a hack. This would *maybe* (did not check) fixes the issues locally but would introduce confusion elsewhere. I'd prefer to check the occurrences one and one and see what we should do with them. Surprisingly the issues in CompDocTemplateTree.xml are very old (pre Apache Era) and it seems nobody complained since. I just had a quick look at the CompDocTemplateTree case, I wonder if somebody is really using stuff like https://localhost:8443/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201 I'll try to have a look at the other cases... > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364301#comment-15364301 ] Jacques Le Roux commented on OFBIZ-7544: BTW, I have used it in find orders for role: at https://ofbiz-vm.apache.org:8443/ordermgr/control/findorders > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364294#comment-15364294 ] Jacques Le Roux commented on OFBIZ-7544: Annother option is jquery.asmselect.js. We have it embedded, see example at https://ofbiz-vm.apache.org:8443/example/control/FormWidgetExamples > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala reassigned OFBIZ-7544: - Assignee: Mohammad Kathawala (was: Swapnil Shah) > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364245#comment-15364245 ] Jacques Le Roux commented on OFBIZ-7680: Totally agreed > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7272) Enforce noninstantiability to all Utility classes
[ https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364242#comment-15364242 ] Rishi Solanki commented on OFBIZ-7272: -- [~jacques.le.roux]: Thanks for review and feedback, it is like energy booster for us. [~arunpati]: I have extracted few more classes which are under discussion, I'll sync with you on this in next week and try to complete the effort. > Enforce noninstantiability to all Utility classes > - > > Key: OFBIZ-7272 > URL: https://issues.apache.org/jira/browse/OFBIZ-7272 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > Attachments: OFBIZ-7272.patch > > > I have discusses this in past on mailing list, that Utility, helper, worker > classes which contains only static methods should not be instantiable. Also > we can restrict it by adding a private constructor. > Currently OFBiz has many such classes which should have private constructor. > Identify all the *Worker.java, *.Helper.java, and *Util.java which do not > have any non static method/member are eligible for having a private > constructor. > Reference why we should do this : > http://www.informit.com/articles/article.aspx?p=1216151=4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364233#comment-15364233 ] Mohammad Kathawala commented on OFBIZ-7544: --- Hi [~soledad], I just thought of usability. Checkbox is always easier to use instead of multiple select as we need to use CTRL key to select multiple options in multiple select box. WDYT? > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364205#comment-15364205
]
Nicolas Malin commented on OFBIZ-7680:
--
On framework/entity/src/org/ofbiz/entity/finder/PrimaryKeyFinder:90 I found
this (use by AbstractModelAction)
{code}
if (!valueNameAcsr.isEmpty()) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
I think we can extend like that
{code}
String originalValueName = this.valueNameAcsr.getOriginalName();
if (originalValueName.isEmpty()) {
originalValueName = "context";
}
if ( !"context".equals(originalValueName)) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
And correct Forms file like that
{code}
{code}
To
{code}
{code}
Your remarks?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-7680
> URL: https://issues.apache.org/jira/browse/OFBIZ-7680
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>
> I found these errors
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 25
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 57
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 93
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 125
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentForms.xml
> /ofbiz/applications/content/widget/content line 235
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentSetupForms.xml
> /ofbiz/applications/content/widget/contentsetup line 217
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. EmploymentAppForms.xml
> /ofbiz/applications/humanres/widget/forms line 27
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. PayGradeForms.xml
> /ofbiz/applications/humanres/widget/forms line 65
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364171#comment-15364171 ] Nicolas Malin commented on OFBIZ-7544: -- instead replace by check box, why replace just by a multiple select input ? > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component
[ https://issues.apache.org/jira/browse/OFBIZ-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7673: Assignee: Nicolas Malin (was: Suraj Khurana) > Create demo PartyStatus data for existing parties for applications component > > > Key: OFBIZ-7673 > URL: https://issues.apache.org/jira/browse/OFBIZ-7673 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Attachments: OFBIZ-7673.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7603) There should be a demo data set for the PartyStatus entity
[ https://issues.apache.org/jira/browse/OFBIZ-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7603: Assignee: Nicolas Malin > There should be a demo data set for the PartyStatus entity > -- > > Key: OFBIZ-7603 > URL: https://issues.apache.org/jira/browse/OFBIZ-7603 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Nicolas Malin > > Currently there is no demo data for the PartyStatus entity. This complicates > tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component
[ https://issues.apache.org/jira/browse/OFBIZ-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7672: Assignee: Nicolas Malin (was: Suraj Khurana) > Create demo PartyStatus data for existing parties for special purpose > component > --- > > Key: OFBIZ-7672 > URL: https://issues.apache.org/jira/browse/OFBIZ-7672 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/ebaystore, specialpurpose/ecommerce, > specialpurpose/projectmgr, specialpurpose/scrum >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Attachments: OFBIZ-7672.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6907) 1
[ https://issues.apache.org/jira/browse/OFBIZ-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-6907. Resolution: Later Assignee: Nicolas Malin I close this issue because it's too fuzzy, don't hesitate to open a new issue with specific case to improve ;) > 1 > - > > Key: OFBIZ-6907 > URL: https://issues.apache.org/jira/browse/OFBIZ-6907 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/ecommerce >Reporter: xin chang >Assignee: Nicolas Malin > > many of us think of the UI so bad,developer need to modify it,it meant need > more time to do this,I hope that your team can fix it,with many thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala updated OFBIZ-7544: -- Attachment: OFBIZ-7544.patch Replaced status dropdown with checkboxes in Find Production Run form. Now user will be able to search on the basis of multiple statuses. > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7680: Assignee: Nicolas Malin > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364159#comment-15364159 ] Nicolas Malin commented on OFBIZ-7680: -- negative, value-field is required at any time, it's an error on theses form > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7543) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Order' component
[ https://issues.apache.org/jira/browse/OFBIZ-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala updated OFBIZ-7543: -- Attachment: OFBIZ-7543.patch Added checkbox for status fields on - Find Orders - Find Quotes - Find Requirements - Find Returns On find orders, did changes in groovy in order to handle list of statuses. > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Order' component > --- > > Key: OFBIZ-7543 > URL: https://issues.apache.org/jira/browse/OFBIZ-7543 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Upcoming Branch >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7543.patch > > > Please refer the details provided on OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7605) Extend use of Apache IVY re external library management for r13x
[ https://issues.apache.org/jira/browse/OFBIZ-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364116#comment-15364116 ] Jacques Le Roux commented on OFBIZ-7605: I thought there was a lazy consensus about Gradle, if we need a vote let's go for a vote > Extend use of Apache IVY re external library management for r13x > > > Key: OFBIZ-7605 > URL: https://issues.apache.org/jira/browse/OFBIZ-7605 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS, framework >Affects Versions: Release Branch 13.07 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Blocker > Attachments: OFBIZ-7605-r13-ivy-v2.patch, OFBIZ-7605-status-v2.txt, > OFBIZ-7605-svn-status.txt, ofbiz-7605-r13-ivy.patch > > > This subtask addresses the issues regarding the r13.07 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7605) Extend use of Apache IVY re external library management for r13x
[ https://issues.apache.org/jira/browse/OFBIZ-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364102#comment-15364102 ] Pierre Smits commented on OFBIZ-7605: - Given that there is no shared agreement expressed by the contributors with binding votes with respect to how we are going to move forward regarding release branches 14.x and 15.x I don't see how you come to that conclusion. As far as I can tell all the suggestions expressed in the thread [DISCUSSION] Anticipate the end of life of the 13.07 branch and backport some non-bug related changes to the 14.12 and 15.12 branches (see start of thread at http://ofbiz.markmail.org/message/nqo5xacngpspytvf) are still on the table, waiting to be revisited in the dev ml. > Extend use of Apache IVY re external library management for r13x > > > Key: OFBIZ-7605 > URL: https://issues.apache.org/jira/browse/OFBIZ-7605 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS, framework >Affects Versions: Release Branch 13.07 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Blocker > Attachments: OFBIZ-7605-r13-ivy-v2.patch, OFBIZ-7605-status-v2.txt, > OFBIZ-7605-svn-status.txt, ofbiz-7605-r13-ivy.patch > > > This subtask addresses the issues regarding the r13.07 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7605) Extend use of Apache IVY re external library management for r13x
[ https://issues.apache.org/jira/browse/OFBIZ-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364079#comment-15364079 ] Jacques Le Roux commented on OFBIZ-7605: It seems all Ivy related tasks will be abandonned, we should close them as "Won't fix" or alike > Extend use of Apache IVY re external library management for r13x > > > Key: OFBIZ-7605 > URL: https://issues.apache.org/jira/browse/OFBIZ-7605 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS, framework >Affects Versions: Release Branch 13.07 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Blocker > Attachments: OFBIZ-7605-r13-ivy-v2.patch, OFBIZ-7605-status-v2.txt, > OFBIZ-7605-svn-status.txt, ofbiz-7605-r13-ivy.patch > > > This subtask addresses the issues regarding the r13.07 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6271) build management with maven
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6271. -- Resolution: Pending Closed > build management with maven > --- > > Key: OFBIZ-6271 > URL: https://issues.apache.org/jira/browse/OFBIZ-6271 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Adam Heath >Priority: Minor > Attachments: console.log > > > This is a new build system; the primary goal will be to not require any > changes to existing ofbiz layouts(for backwards compatibility, at least > initially). > These pom.xml files are completely new; the existing build.xml infrastructure > will continue to exist. The existing build.xml will never call into > maven(which is what processes the pom.xml), and maven will never call into > build.xml either. > I have already committed a working pom.xml for the top level, and > framework/start. Shortly, I will be adding framework/base and > framework/entity, but into this branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364074#comment-15364074
]
Jacques Le Roux commented on OFBIZ-7758:
I'd take care of it, but I rather want to put require.js in place to handle all
these sorts of things...
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-7753) OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues
[ https://issues.apache.org/jira/browse/OFBIZ-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7753. -- Resolution: Done > OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues > --- > > Key: OFBIZ-7753 > URL: https://issues.apache.org/jira/browse/OFBIZ-7753 > Project: OFBiz > Issue Type: Task > Components: site >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Labels: best-practice, jira > > Currently > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices > addresses how contributors work best with JIRA issues in the OFBiz way. > However, it doesn't address how we like our issues resolved and closed. > Enhanching the page in that respect decreases the confusion, leads to less > reopening and closing issues to set the proper resolution, and generate > better reports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7743) Move files in gradle folder to a location within base component of the framework stack
[ https://issues.apache.org/jira/browse/OFBIZ-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364060#comment-15364060 ] Jacques Le Roux commented on OFBIZ-7743: Should not this issue (and some recent others) be sub-tasks of OFBIZ-7534? So people interested could quickly reply. > Move files in gradle folder to a location within base component of the > framework stack > -- > > Key: OFBIZ-7743 > URL: https://issues.apache.org/jira/browse/OFBIZ-7743 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > > Currently the gradle folder and its content is in the root of the OFBiz > implementation. This should be - as part of the framework stack - reside in > the base component of the framework folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7753) OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues
[ https://issues.apache.org/jira/browse/OFBIZ-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364046#comment-15364046 ] Jacques Le Roux edited comment on OFBIZ-7753 at 7/6/16 9:29 AM: Thanks for the idea Pierre, This is not a bug but a trivial task :) To avoid redundancy and maintainabily nightmare I simply put a reference to the section in the committers page. I also added a note about "about backports for bug fixes": when you don't backport a bug fix to a release branch, please explain the reason/s you don't backport. Then when others review they don't wonder why it was not backported and don't have to search why! was (Author: jacques.le.roux): Thanks for the idea Pierre, This is not a bug but a trivial task :) To avoid redundancy and maintainabily nightmare I simply put a reference to the section in the committers page. I also added a note about "about backports for bug fixes": wWhen you don't backport a bug fix to a release branch, please explain the reason/s you don't backport. Then when others review they don't wonder why it was not backported and don't have to search why! > OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues > --- > > Key: OFBIZ-7753 > URL: https://issues.apache.org/jira/browse/OFBIZ-7753 > Project: OFBiz > Issue Type: Task > Components: site >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Labels: best-practice, jira > > Currently > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices > addresses how contributors work best with JIRA issues in the OFBiz way. > However, it doesn't address how we like our issues resolved and closed. > Enhanching the page in that respect decreases the confusion, leads to less > reopening and closing issues to set the proper resolution, and generate > better reports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7753) OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues
[ https://issues.apache.org/jira/browse/OFBIZ-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7753: --- Priority: Trivial (was: Major) Issue Type: Task (was: Bug) Thanks for the idea Pierre, This is not a bug but a trivial task :) To avoid redundancy and maintainabily nightmare I simply put a reference to the section in the committers page. I also added a note about "about backports for bug fixes": wWhen you don't backport a bug fix to a release branch, please explain the reason/s you don't backport. Then when others review they don't wonder why it was not backported and don't have to search why! > OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues > --- > > Key: OFBIZ-7753 > URL: https://issues.apache.org/jira/browse/OFBIZ-7753 > Project: OFBiz > Issue Type: Task > Components: site >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Labels: best-practice, jira > > Currently > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices > addresses how contributors work best with JIRA issues in the OFBiz way. > However, it doesn't address how we like our issues resolved and closed. > Enhanching the page in that respect decreases the confusion, leads to less > reopening and closing issues to set the proper resolution, and generate > better reports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Editing comments in Jira
Hi, Long ago we decided about this policy which is written as an info block at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices> It has been lost for some time. I know some committers (Scott for instance) really wanted this way of doing. I wonder know if we should continue to advice to respect it or if we should discard it. Opininons? Jacques
[jira] [Closed] (OFBIZ-7755) Geo data for Turkey
[ https://issues.apache.org/jira/browse/OFBIZ-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7755. -- Resolution: Done Fix Version/s: Upcoming Branch Thanks Tufan, Your patch is commited in trunk at revision: 1751635 Welcome! > Geo data for Turkey > --- > > Key: OFBIZ-7755 > URL: https://issues.apache.org/jira/browse/OFBIZ-7755 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Tufan Kaynak >Assignee: Jacques Le Roux >Priority: Minor > Labels: address, geodata, province, regions, turkey > Fix For: Upcoming Branch > > Attachments: ofbizGeoDataTUR02.patch > > > Please find attached the patch file for including Province data for Turkey > via GeoData_TR.xml and address format for Turkey in GeoData.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7753) OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues
[ https://issues.apache.org/jira/browse/OFBIZ-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7753: -- Assignee: Jacques Le Roux > OFBiz Contributors Best Practices visavis Resolution changes in JIRA issues > --- > > Key: OFBIZ-7753 > URL: https://issues.apache.org/jira/browse/OFBIZ-7753 > Project: OFBiz > Issue Type: Bug > Components: site >Reporter: Pierre Smits >Assignee: Jacques Le Roux > Labels: best-practice, jira > > Currently > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices > addresses how contributors work best with JIRA issues in the OFBiz way. > However, it doesn't address how we like our issues resolved and closed. > Enhanching the page in that respect decreases the confusion, leads to less > reopening and closing issues to set the proper resolution, and generate > better reports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363950#comment-15363950 ] Jacques Le Roux commented on OFBIZ-7534: Done at at revision: 1751619. I simply hid gradle and build directories for now. We will do the needed later as suggested above. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7759) Link in LookupContent causes unwanted behaviour
Montalbano Florian created OFBIZ-7759: - Summary: Link in LookupContent causes unwanted behaviour Key: OFBIZ-7759 URL: https://issues.apache.org/jira/browse/OFBIZ-7759 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor How to reproduce : - Log in the Content component - Go to the Content tab - In the search form, open the lookup of the field ' Owner Content Id ' - Click on the search button - In the result list, click on a button link in the column 'Data Resource Id' - The form to edit the Content will be displayed (a whole OFBiz seems to be accessible from this new page) - Close the lookup. - Try to reopen it, it doesn't show anything anymore. The only hint I've found for explaining this problem is that the request to open the lookup is somehow changed. At first it is : https://localhost:8443/content/control/LookupContent But then it becomes : https://localhost:8443/content/control/LookupLocale The other lookup seems unusable too after that. Did you already encounter this kind of problem before ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7543) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Order' component
[ https://issues.apache.org/jira/browse/OFBIZ-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala reassigned OFBIZ-7543: - Assignee: Mohammad Kathawala (was: Swapnil Shah) > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Order' component > --- > > Key: OFBIZ-7543 > URL: https://issues.apache.org/jira/browse/OFBIZ-7543 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Upcoming Branch >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > > Please refer the details provided on OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363907#comment-15363907 ] Jacques Le Roux commented on OFBIZ-7534: 2. Agreed, it was only in case we later refer to this commit and wonder what should be removed 3. OK, let's wait > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363861#comment-15363861 ] Jacques Le Roux edited comment on OFBIZ-7534 at 7/6/16 7:32 AM: Hi Jacques, In feedback to your comments: # agreed with .gradle ans build directories hiding in root as well as ofbiz.jar # It's okay but not very necessary to modify the commit saying we will remove .classpath and .project. Many other files will go away, maybe we should mention it in its own commit? # I hesitate about the build directory in each component. Under the current design each component is a gradle subproject. If any of these subprojects applies the Java plugin for whatever reason a build directory will be created. I am not sure we will use it but a little delay on this point would be better until the picture is clear. Cheers! was (Author: taher): Hi Jacques, In feedback to your comments: - agreed with .gradle ans build directories hiding in root as well as ofbiz.jar - It's okay but not very necessary to modify the commit saying we will remove .classpath and .project. Many other files will go away, maybe we should mention it in its own commit? - I hesitate about the build directory in each component. Under the current design each component is a gradle subproject. If any of these subprojects applies the Java plugin for whatever reason a build directory will be created. I am not sure we will use it but a little delay on this point would be better until the picture is clear. Cheers! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7443) UI improvements on XML Data Export screen in Framework webtools
[ https://issues.apache.org/jira/browse/OFBIZ-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363894#comment-15363894 ] Jacques Le Roux commented on OFBIZ-7443: Thanks Mridul! > UI improvements on XML Data Export screen in Framework webtools > --- > > Key: OFBIZ-7443 > URL: https://issues.apache.org/jira/browse/OFBIZ-7443 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Gopal Yadav >Assignee: Mridul Pathak >Priority: Minor > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ_7443.patch, xmldataexport.png > > > Go to Webtools -> Import/Export -> XML Data Export > (https://localhost:8443/webtools/control/xmldsdump) > 1) On this screen the label 'Entity Names:' is not correctly positioned on > the UI. This label should appear just above the section where entity names > are listed. > 2) The input field "Entity Sync Dump:" is visible in theme Tomahawk, but this > textbox is not visible in other themes like BlueLight theme, Dropping Crumbs, > Flat Grey, and all other Rainbow themes. As this text box is not visible so > it appears to be a label displaying some information. This needs to be > corrected as this is misleading, so it should appear as textbox in all the > themes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7553) On order list page, the 'All' checkbox for status field does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363893#comment-15363893 ] Jacques Le Roux commented on OFBIZ-7553: Thanks Mohammad! > On order list page, the 'All' checkbox for status field does not work properly > -- > > Key: OFBIZ-7553 > URL: https://issues.apache.org/jira/browse/OFBIZ-7553 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch >Reporter: Mohammad Kathawala >Assignee: Divesh Dutta >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7553.patch, Screenshot.png > > > Steps to generate: > 1) Go to order list page. > 2) For status field, check the 'All' checkbox. This will check all the other > status checkboxes. > 3) Now uncheck any one or more checkbox other than 'All'. > - Expected: This should uncheck the 'All' checkbox also. > - Actual: 'All' checkbox remains checked. > Please see the screenshot -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363861#comment-15363861 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, In feedback to your comments: - agreed with .gradle ans build directories hiding in root as well as ofbiz.jar - It's okay but not very necessary to modify the commit saying we will remove .classpath and .project. Many other files will go away, maybe we should mention it in its own commit? - I hesitate about the build directory in each component. Under the current design each component is a gradle subproject. If any of these subprojects applies the Java plugin for whatever reason a build directory will be created. I am not sure we will use it but a little delay on this point would be better until the picture is clear. Cheers! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, > gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
