[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381754#comment-15381754
 ] 

Deepak Dixit commented on OFBIZ-6274:
-

We did following thing while moving org.ofbiz to org.apache.org
- Moved all the artefacts from org.ofbiz.* to org.apache.ofbiz.*
- Changee all occurrence from org.ofbiz to org.apache.ofbiz in all the xml, ftl 
and groovy files.
- Changee the service providers files from org.ofbiz.* to org.apache.ofbiz 
(META-INF/services)
- Changed then entity package name from org.ofbiz.* to org.apache.ofbiz.*



> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[FYI] Trunk demo crashed

[Jacques Le Roux]

Hi,

FYI, we got this last night, I restart...

Jacques

Re: Proposal to modify the testing framework for OFBiz

[Taher Alkhateeb]

Hello Everyone,

In reference to this thread and the Jira OFBIZ-7254, I'm very happy to
announce that OFBiz is now ready for applying unit tests with only 8 new
lines of code in the build script (r1753143) :)

I recommend we do the following moving forward:

1- Introduce unit tests as much as we can to all components
2- Migrate most of the integration tests we currently have to unit tests
(since they are designed to do very little integration).

This is a great chance for us to practice real TDD in OFBiz

Cheers,

Taher Alkhateeb

On Mon, Jun 13, 2016 at 7:43 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> +1
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Fri, Jun 10, 2016 at 7:46 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com
> > wrote:
>
> > Hello Everyone,
> >
> > I was able to get a few tests running and this is very doable. But I
> faced
> > a big problem in designing the testing framework because of ANT.
> >
> > The problem
> > 
> > The way the build scripts are designed in OFBiz are very complex. A
> master
> > file calls other files which call other files. And in the middle you have
> > external libraries (ant-contrib) and macros, and variables, and class
> path
> > declarations, and and and 
> >
> > I cannot declare the tests programmatically (with JUnit test suites)
> > because this means lower level components would depend on higher level
> > components. So I have to do it in ANT, by navigating this maze of build
> > scripts, and it was a headache for me just to read them, let alone modify
> > them to create a testing framework.
> >
> > Suggested Solution
> > 
> > I suggest to implement the testing framework in Gradle, and simply call
> it
> > from within ant. This is a middle solution that sustains ant for now, but
> > can allow us to switch out later.
> >
> > This means I will just add one more file called build.gradle in the top
> > level directory, and figure out the business logic for calling the test
> > suites from that file
> >
> > I look forward to your feedback.
> >
> > Regards,
> >
> > Taher Alkhateeb
> >
> > On Wed, Jun 8, 2016 at 6:00 PM, Taher Alkhateeb <
> > slidingfilame...@gmail.com>
> > wrote:
> >
> > > Hi Everyone,
> > >
> > > Thank you all for your support, JIRA created in
> > > https://issues.apache.org/jira/browse/OFBIZ-7254
> > >
> > > I will start working on it and try to implement ASAP to get my focus
> back
> > > on refactoring.
> > >
> > > Cheers!
> > >
> > > Taher Alkhateeb
> > >
> > > On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit <
> > > deepak.di...@hotwaxsystems.com> wrote:
> > >
> > >> +1
> > >>
> > >> Thanks & Regards
> > >> --
> > >> Deepak Dixit
> > >> www.hotwaxsystems.com
> > >>
> > >> On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
> > >> mridul.pat...@hotwaxsystems.com> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > Makes perfect sense.
> > >> >
> > >> > --
> > >> > Thanks & Regards,
> > >> > Mridul Pathak
> > >> > Senior Manager
> > >> > HotWax Systems
> > >> > http://www.hotwaxsystems.com
> > >> >
> > >> > > On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb <
> > >> slidingfilame...@gmail.com>
> > >> > wrote:
> > >> > >
> > >> > > Hello Everyone,
> > >> > >
> > >> > > After refactoring the start component and while starting on the
> base
> > >> > > component I realized that the testing framework for OFBiz is not
> > good.
> > >> > You
> > >> > > cannot do real test driven development or red-green-refactor with
> > the
> > >> > > current setup, hence my proposal to change it. I explain below:
> > >> > >
> > >> > > Problem with current design
> > >> > > 
> > >> > > - What we have right now is not unit tests, it's really
> integration
> > >> > tests.
> > >> > > You have to start the framework, the database, the service engine,
> > the
> > >> > > entity engine and pretty much everything.
> > >> > > - Testing is very slow, because it's an integration test as I
> > >> mentioned
> > >> > > above. 10 minutes on a good computer!
> > >> > > - There is zero mocking! We actually have to --load-data for
> things
> > to
> > >> > > work. Again, these are integration tests.
> > >> > > - Too complex: Integration tests by their nature are grabbing too
> > >> much.
> > >> > > Mind you, I am not objecting to integration tests (I actually like
> > >> them)
> > >> > > but I am objecting to not having real unit-tests. Unit tests
> should
> > >> all
> > >> > run
> > >> > > in a few seconds.
> > >> > >
> > >> > > Proposed solution
> > >> > > --
> > >> > > - We keep what is considered real integration tests the way they
> are
> > >> > right
> > >> > > now and keep using them
> > >> > > - We move what should be unit tests into simple JUnit classes, and
> > we
> > >> do
> > >> > > not run them using java -jar ofbiz.jar --test, but instead run
> them
> > >> > > directly from the build.xml script, so these files are not
> > 

[jira] [Commented] (OFBIZ-7254) provide a new unit testing framework for OFBiz

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381724#comment-15381724
 ] 

Taher Alkhateeb commented on OFBIZ-7254:


Committed in r1753143 a small commit that introduces the framework :) Just 8 
lines of code now enable unit tests in OFBiz.

> provide a new unit testing framework for OFBiz
> --
>
> Key: OFBIZ-7254
> URL: https://issues.apache.org/jira/browse/OFBIZ-7254
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>
> The objective of this JIRA is to create a unit testing framework for OFBiz in 
> addition to the existing testing framework which is used for integration 
> tests.
> This objective will be achieved using the following steps:
> - Create a master suite to hold all other suites and unit tests
> - Modify build.xml to incorporate unit tests and integration tests in 
> separate tasks
> - design at least a few test scripts to showcase usage
> This JIRA has reference to the discussion on the below mail thread 
> http://ofbiz.markmail.org/message/3cebkshhgyzds4e5
> https://lists.apache.org/thread.html/0a5e3a02505061ac2d55f75dfb88714b5ab543c39bbadb9aa3e2d2b3@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7769) Have a gradle build file for the entity component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7769.
--
Resolution: Incomplete
  Assignee: Jacques Le Roux

As I said 2 days ago, 
bq. I close this issue and similar and will consult with the "OFBiz team" to 
propose a clear (simple) explanation about the plan with plugins (included 
short technical explanation)

To continue on this we will discuss, in the dev ML, the pros and cons of 
putting put a gradle.build file in each component; and see if, in a reasonable 
time, it's technically possible.

For now I close as incomplete because we have nere no actionnable plan.


> Have a gradle build file for the entity component
> -
>
> Key: OFBIZ-7769
> URL: https://issues.apache.org/jira/browse/OFBIZ-7769
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7748) Have a gradle build file for the catalina component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7748.
--
Resolution: Incomplete
  Assignee: Jacques Le Roux

As I said 2 days ago, 
bq. I close this issue and similar and will consult with the "OFBiz team" to 
propose a clear (simple) explanation about the plan with plugins (included 
short technical explanation)

To continue on this we will discuss, in the dev ML, the pros and cons of 
putting put a gradle.build file in each component; and see if, in a reasonable 
time, it's technically possible.

For now I close as incomplete because we have nere no actionnable plan.


> Have a gradle build file for the catalina component
> ---
>
> Key: OFBIZ-7748
> URL: https://issues.apache.org/jira/browse/OFBIZ-7748
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: gradle
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7747) Have a gradle build file for the base component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7747.
--
Resolution: Incomplete
  Assignee: Jacques Le Roux

As I said 2 days ago, 
bq. I close this issue and similar and will consult with the "OFBiz team" to 
propose a clear (simple) explanation about the plan with plugins (included 
short technical explanation)

To continue on this we will discuss, in the dev ML, the pros and cons of 
putting put a gradle.build file in each component; and see if, in a reasonable 
time, it's technically possible.

For now I close as incomplete because we have nere no actionnable plan.


> Have a gradle build file for the base component
> ---
>
> Key: OFBIZ-7747
> URL: https://issues.apache.org/jira/browse/OFBIZ-7747
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: gradle
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7746) Have a gradle build file for the product component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7746.
--
Resolution: Incomplete
  Assignee: Jacques Le Roux

As I said 2 days ago, 
bq. I close this issue and similar and will consult with the "OFBiz team" to 
propose a clear (simple) explanation about the plan with plugins (included 
short technical explanation)

To continue on this we will discuss, in the dev ML, the pros and cons of 
putting put a gradle.build file in each component; and see if, in a reasonable 
time, it's technically possible.

For now I close as incomplete because we have nere no actionnable plan.


> Have a gradle build file for the product component
> --
>
> Key: OFBIZ-7746
> URL: https://issues.apache.org/jira/browse/OFBIZ-7746
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7745) Have a gradle build file for the content component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7745.
--
Resolution: Incomplete
  Assignee: Jacques Le Roux

As I said 2 days ago, 
bq. I close this issue and similar and will consult with the "OFBiz team" to 
propose a clear (simple) explanation about the plan with plugins (included 
short technical explanation)

To continue on this we will discuss, in the dev ML, the pros and cons of 
putting put a gradle.build file in each component; and see if, in a reasonable 
time, it's technically possible.

For now I close as incomplete because we have nere no actionnable plan.


> Have a gradle build file for the content component
> --
>
> Key: OFBIZ-7745
> URL: https://issues.apache.org/jira/browse/OFBIZ-7745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: gradle
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Entity and Service definition

[Rishi Solanki]

Starter effort on this under - OFBIZ-7828. Community review / feedback /
suggestion / concerns are welcome.

Thanks!

Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Thu, Jul 14, 2016 at 9:58 AM, Rishi Solanki 
wrote:

> Thank you everyone for your approval and suggestion. We would try to
> follow most, and log Jira accordingly. Soon will start on this.
>
> Nicolas, thanks for pointing expire action on entity-auto.
>
> Jacques, Pierre, thanks for suggestion on managing Jira tickets, and you
> guys anyways helped us in our last effort in managing Jira tickets and
> review. Thanks for that.
>
> Plan is something like this, we would pick the easy entities first where
> we found minimum changes. After delivering few we will be able to establish
> practice internally, on what items we should take care before fixing an
> entity/service. We would like to go slow initially, and as soon as we start
> on it delivery process will more clear.
>
>
> Thanks again for your help, and looking forward for same in the big effort
> planned.
>
>
>
> Rishi Solanki
> Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
> On Wed, Jul 13, 2016 at 2:36 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Le 13/07/2016 à 09:39, Pierre Smits a écrit :
>>
>>> At this moment in time, I can't fathom how much effort is involved in
>>> this
>>> factoring, but I suggest to break it down as much as possible into
>>> separate
>>> JIRA issues. For instance, the rework on the removal of the
>>> OrderHeaderNoteView
>>> and OrderItemAndShipGroupAssoc from the OrderHeader entity can be a
>>> separate issue. Please be aware, that this might have a big impact in
>>> various functions/services/etc.
>>>
>>> Best regards,
>>>
>>> Pierre Smits
>>>
>> That's a good advice Pierre, from what I have seen these last months from
>> the HW effort, I'm confident they are totally aware of what to do :)
>>
>> Jacques
>>
>>
>

[jira] [Created] (OFBIZ-7891) Improvements in BudgetRevisionImpact entity definition and services

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7891:


 Summary: Improvements in BudgetRevisionImpact entity definition 
and services
 Key: OFBIZ-7891
 URL: https://issues.apache.org/jira/browse/OFBIZ-7891
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is not optional while 
create service.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, so nothing needs to be 
taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot success in on ofbiz-trunk

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1118

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1753063
Blamelist: taher

Build succeeded!

Sincerely,
 -The Buildbot

[jira] [Commented] (OFBIZ-7890) Improvements in BudgetRevision entity definition and services

[Rishi Solanki (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381317#comment-15381317
 ] 

Rishi Solanki commented on OFBIZ-7890:
--

Community, we decided to not provide delete operation for this entity, could 
you please help us here, what should we do in such cases. Here no from 
date/thru date or status field exists. But it contains the historical data IMO, 
and as per the entity def it can not (and should not) expire.

We have two option;
1) Do not provide delete service for such cases. (In ticket description I 
proposed to follow this.)
2) Provide delete service and let the business user decide weather to remove 
any record or not. We can add description in the service something like; 
"Entity contains historical data, and ideally not used."

> Improvements in BudgetRevision entity definition and services
> -
>
> Key: OFBIZ-7890
> URL: https://issues.apache.org/jira/browse/OFBIZ-7890
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is not optional while 
> create service.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, but it looks like it 
> will contain the revisions of same data so history needs to be maintain. We 
> should not provide service for delete its record.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7890) Improvements in BudgetRevision entity definition and services

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7890:


 Summary: Improvements in BudgetRevision entity definition and 
services
 Key: OFBIZ-7890
 URL: https://issues.apache.org/jira/browse/OFBIZ-7890
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is not optional while 
create service.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, but it looks like it will 
contain the revisions of same data so history needs to be maintain. We should 
not provide service for delete its record.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7889) Improvements in BudgetReviewResultType entity definition and services

[Rishi Solanki (JIRA)]

Rishi Solanki created OFBIZ-7889:


 Summary: Improvements in BudgetReviewResultType entity definition 
and services
 Key: OFBIZ-7889
 URL: https://issues.apache.org/jira/browse/OFBIZ-7889
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is optional while create 
service, so that can be generated from OFBiz sequence generator.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, so nothing needs to be 
taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7868) Improvements in AgreementAttribute entity definition and services

[Rishi Solanki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-7868:
-
Description: 
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is not optional while 
create service.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, so nothing needs to be 
taken care while deleting the records from service.

  was:
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is not optional while 
create service.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/trhu date exists in entity, so nothing needs to be 
taken care while deleting the records from service.


> Improvements in AgreementAttribute entity definition and services
> -
>
> Key: OFBIZ-7868
> URL: https://issues.apache.org/jira/browse/OFBIZ-7868
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7868.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is not optional while 
> create service.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services

[Rishi Solanki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-7847:
-
Description: 
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is optional while create 
service, so that can be generated from OFBiz sequence generator.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, so nothing needs to be 
taken care while deleting the records from service.

  was:
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is optional while create 
service, so that can be generated from OFBiz sequence generator.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/trhu date exists in entity, so nothing needs to be 
taken care while deleting the records from service.


> Improvements in AcctgTransEntryType entity definition and services
> --
>
> Key: OFBIZ-7847
> URL: https://issues.apache.org/jira/browse/OFBIZ-7847
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7847.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services

[Rishi Solanki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-7831:
-
Description: 
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is optional while create 
service, so that can be generated from OFBiz sequence generator.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/thru date exists in entity, so nothing needs to be 
taken care while deleting the records from service.

  was:
Required improvements;
- All is good with entity definition .
- Add crud services using entity-auto. Make sure PK is optional while create 
service, so that can be generated from OFBiz sequence generator.
- Do related changes if any occurrence found for direct create/update/delete of 
this entity, and replace them with crud services implemented.
- As no status/from date/trhu date exists in entity, so nothing needs to be 
taken care while deleting the records from service.


> Improvements in AccommodationClass entity definition and services
> -
>
> Key: OFBIZ-7831
> URL: https://issues.apache.org/jira/browse/OFBIZ-7831
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7831.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [Discussion] Shifting our OFBiz culture to enable innovation

[Pierre Smits]

Hi Taher, all,

I love to see innovation (both process and code wise) happening within the
project as much as the next participant. But any particular innovation can
have a serious impact and can raise concerns from any contributor. These
impacts and concerns need to be discussed and addressed first, before code
changes get implemented. Especially when the innovation is controversial. I
see such as an opportunity for all.

Now though I love to see innovation happening, I cannot voice to much that
I find it deplorable that a faction of the community (the so called OFBiz
Team) plots and schemes in some kind of back room channel to get
controversial code changes in the repo, not engage with the entire
community to discuss the controversies or not start a vote before
implementation, have some of their faction starting to implementing this
kind of code in the repo and then sell it to the entire community as
something that has some kind of consensus.

And if PMC members or even ASF Members are participating in this back room
plotting and scheming without upholding the Apache Principles (not
discussing first in the mailing list of the project) from begin to end,
their actions are even more shameful and embarrassing to the project.

It seems to me that the Gradle implementation and removal of the Ant build
solution has been shoved down the throat of the community in this way. We
have had discussions in the past (IIRW at least in 2014), and we all
learned from those discussions that we couldn't reach consensus back then.
I guess that this the members faction didn't want to engage in another
discussion (out of fear or arrogance) with the entire community and wanted
to have their way.

I will not hesitate (and I have) to voice my concerns and complaints (in
private channels and publicly) about such actions to any party I know.

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Sat, Jul 16, 2016 at 3:38 PM, Taher Alkhateeb  wrote:

> Hello Everyone,
>
> As you already know, we have been doing major work in terms of improving
> and refactoring the framework. We are buzzing and making changes everywhere
> and people are getting excited about helping out. This is fantastic! and I
> hope we can continue in this new direction.
>
> However, before we started the refactoring work, I kept wondering why did
> we get here in the first place? We do we have lots of bad and messy code in
> the code base? Why are we at point where we are shifting all energies to
> cleaning up?
>
> So as I started working with people on the refactoring project and the
> answers to the above questions started to slowly appear. I list below my
> perception of the problems and recommendations for avoiding repeating these
> problems of bad code.
>
> Problem: We are very conservative
> --
>
> How many times did you hear this: "Don't remove that, somebody might need
> it" or "Oh no, you just made a regression in trunk" or "No keep it, _one_
> person X objected".
>
> You know ... making software is difficult. It involves taking many
> decisions, some of these decisions might not appeal to every person but
> they are necessary for the health of the project.
>
> So here is where I observed conservative behavior:
>
> - We are too sensitive to objections that even _one_ person might stop an
> initiative. In a way we might be a little too nice.
> - We treat trunk like it is almost a stable branch, and for any serious
> change we immediately prefer to create branches.
> - We _rarely_ remove anything, and when we suggest removing things big
> resistance happens. We suffer from "code hoarding"
> - We are shy about changing other people's code. Shy not because we don't
> know what to do, but we are concerned about making those who wrote the
> software displeased.
> - We treat code written by others like it is holy and difficult and we
> cannot repeat, when in fact many times we can make it actually _better_!
>
> The above observations in my opinion are the main reasons why we have bad
> code. We just pile up and we are so afraid of change. We don't change
> anything and the code as a result suffers and deteriorates. We just pile
> things on top of other things and do not revisit the design and try to make
> it better and cleaner. Sometimes revisiting the design involves _DELETING_
> which is a strange word in our community :)
>
> Recommendation: Shifting our mindset
> ---
>
> At a high level, we can say our problem is fear! How do we reduce and
> control fear? How do we gain confidence about making change without too
> much pain? Luckily many smart people already thought about these things and
> came up with wonderful solutions. I list hear recommendations which are
> inspired by these thinkers:
>
> - First we must be aware that we are conservative 

[jira] [Commented] (OFBIZ-7821) Remove unused system generated fields from all data files

[Rishi Solanki (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381285#comment-15381285
 ] 

Rishi Solanki commented on OFBIZ-7821:
--

+1 for the effort, it takes time to understand a data in data file with four 
extra fields. Also these fields contains older dates, and create confusions.

> Remove unused system generated fields from all data files
> -
>
> Key: OFBIZ-7821
> URL: https://issues.apache.org/jira/browse/OFBIZ-7821
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Priority: Minor
>
> There are four system generated fields for every entity as lastUpdatedStamp, 
> lastUpdatedTxStamp, createdStamp and createdTxStamp
> To increase readability of data files, these fields are not necessary to be 
> there in data files, as it gets generated every time when data load occurs. 
> This ticket will be served as a parent ticket and I will be creating child 
> tickets component wise for all affected components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: OFBiz & Gradle building OFBiz

[Pierre Smits]

Taher,

It is not the vendor of hosting services dictating the GRC policies and
procedures IT organisations and/or (implementation) service providers
(consultants, developers, etc) need to adhere to. They merely convey the
boundaries they operate in and have a price for their services that is
based on the risk they run and can divide amongst their customers and the
influences of the market.

GRC policies and procedures are dictated and upheld by the companies that
employ an DEVOPS staff, or buy external services. Maybe you haven't had the
opportunity to work in/with organisations who have certified their
processes. And any company is different in how they assess, address and
mitigate the risks that threaten their reputation and the underlying
existence of the company. But it leads to the reason why SLAs (e.g.
regarding uptime and performance) exists.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Sun, Jul 17, 2016 at 11:56 AM, Taher Alkhateeb <
slidingfilame...@gmail.com> wrote:

> Hi Pierre,
>
> By the way if you don't want to / cannot copy the .gradle folder then I'm
> afraid you have to build a new jar yourself because the generated Jar
> contains the absolute Class-Path entries for all other jars required. If
> you want to put them in a different folder then you have to regenerate the
> Jar with the correct classpath entries (or alternatively include them in
> your -cp arguments). It's a few lines of code in Gradle but you should be
> familiar with configurations and iterations and some closure logic. So I
> think your safest bet is to just copy the .gradle folder to your production
> environment.
>
> With that being said, I find the requirements for your production
> environment quite draconian! I haven't seen anything like that before. I
> can spin off a droplet in DigitalOcean for 10$ a month that can do pretty
> much everything I need. If you're not stuck with them I think it would be a
> good idea to consider other vendors.
>
> Regrads,
>
> Taher Alkhateeb
>
> On Sun, Jul 17, 2016 at 4:47 AM, Pierre Smits 
> wrote:
>
> > Hi Taher,
> >
> > Bringing the dev environment up to the latest revision did the trick.
> > Thanks!
> >
> > Even
> >
> > Pierre Smits
> >
> > ORRTIZ.COM 
> > OFBiz based solutions & services
> >
> > OFBiz Extensions Marketplace
> > http://oem.ofbizci.net/oci-2/
> >
> > On Sat, Jul 16, 2016 at 9:10 PM, Taher Alkhateeb <
> > slidingfilame...@gmail.com
> > > wrote:
> >
> > > Hi Pierre,
> > >
> > > Maybe try it without the word apache because you're on an older
> revision?
> > >
> > > On Jul 16, 2016 9:10 PM, "Pierre Smits" 
> wrote:
> > >
> > > > Hi Taher,
> > > >
> > > > You said: 'You can run the system by typing java -cp
> > > build/libs/jarname.jar
> > > > org.apache.ofbiz.base.start.Start or running the jar directly.
> > > >
> > > > I tried:
> > > >
> > > > java -cp build/libs/ofbiz-gradle.jar
> org.apache.ofbiz.base.start.Start
> > > >
> > > > I guess that 'ofbiz-gradle.jar' is the 'jarname.jar' you mentioned.
> > > >
> > > > But that resulted in:
> > > >
> > > > Error: Could not find or load main class
> > > org.apache.ofbiz.base.start.Start
> > > >
> > > >
> > > > Best regards,
> > > >
> > > >
> > > > Pierre Smits
> > > >
> > > > ORRTIZ.COM 
> > > > OFBiz based solutions & services
> > > >
> > > > OFBiz Extensions Marketplace
> > > > http://oem.ofbizci.net/oci-2/
> > > >
> > > > On Sat, Jul 16, 2016 at 7:06 PM, Pierre Smits <
> pierre.sm...@gmail.com>
> > > > wrote:
> > > >
> > > > > Thanks.
> > > > >
> > > > > In a wadload of postgresql jars found I got:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> ./Users/pierre/.gradle/caches/modules-2/files-2.1/postgresql/postgresql/9.0-801.jdbc4/153f2f92a786f12fc111d0111f709012df87c808/postgresql-9.0-801.jdbc4.jar
> > > > >
> > > > > So that adds to the traceability issue I have. A pom in one folder
> > and
> > > a
> > > > > jar in another, no apparent relation and no logging. More digging
> to
> > > do.
> > > > :(
> > > > >
> > > > > Best regards,
> > > > >
> > > > > Pierre Smits
> > > > >
> > > > > ORRTIZ.COM 
> > > > > OFBiz based solutions & services
> > > > >
> > > > > OFBiz Extensions Marketplace
> > > > > http://oem.ofbizci.net/oci-2/
> > > > >
> > > > > On Sat, Jul 16, 2016 at 6:54 PM, Taher Alkhateeb <
> > > > > slidingfilame...@gmail.com> wrote:
> > > > >
> > > > >> find . -iname "*postgres*.jar"
> > > > >>
> > > > >> On Jul 16, 2016 7:50 PM, "Pierre Smits" 
> > > wrote:
> > > > >>
> > > > >> > Hmm.
> > > > >> >
> > > > >> > It seems I overlooked that it was a directory.
> > > > >> >
> > > > >> > This is what I have in the directory:
> > > > >> >
> > > > >> > Pierres-MacBook-Pro:files-2.1 pierre$ ls
> > > > >> >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> 

buildbot failure in on ofbiz-trunk

[buildbot]

The Buildbot has detected a new failure on builder ofbiz-trunk while building . 
Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1117

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1753051
Blamelist: taher

BUILD FAILED: failed shell_1

Sincerely,
 -The Buildbot

Re: OFBiz & Gradle building OFBiz

[Taher Alkhateeb]

Hi Pierre,

By the way if you don't want to / cannot copy the .gradle folder then I'm
afraid you have to build a new jar yourself because the generated Jar
contains the absolute Class-Path entries for all other jars required. If
you want to put them in a different folder then you have to regenerate the
Jar with the correct classpath entries (or alternatively include them in
your -cp arguments). It's a few lines of code in Gradle but you should be
familiar with configurations and iterations and some closure logic. So I
think your safest bet is to just copy the .gradle folder to your production
environment.

With that being said, I find the requirements for your production
environment quite draconian! I haven't seen anything like that before. I
can spin off a droplet in DigitalOcean for 10$ a month that can do pretty
much everything I need. If you're not stuck with them I think it would be a
good idea to consider other vendors.

Regrads,

Taher Alkhateeb

On Sun, Jul 17, 2016 at 4:47 AM, Pierre Smits 
wrote:

> Hi Taher,
>
> Bringing the dev environment up to the latest revision did the trick.
> Thanks!
>
> Even
>
> Pierre Smits
>
> ORRTIZ.COM 
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Sat, Jul 16, 2016 at 9:10 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com
> > wrote:
>
> > Hi Pierre,
> >
> > Maybe try it without the word apache because you're on an older revision?
> >
> > On Jul 16, 2016 9:10 PM, "Pierre Smits"  wrote:
> >
> > > Hi Taher,
> > >
> > > You said: 'You can run the system by typing java -cp
> > build/libs/jarname.jar
> > > org.apache.ofbiz.base.start.Start or running the jar directly.
> > >
> > > I tried:
> > >
> > > java -cp build/libs/ofbiz-gradle.jar org.apache.ofbiz.base.start.Start
> > >
> > > I guess that 'ofbiz-gradle.jar' is the 'jarname.jar' you mentioned.
> > >
> > > But that resulted in:
> > >
> > > Error: Could not find or load main class
> > org.apache.ofbiz.base.start.Start
> > >
> > >
> > > Best regards,
> > >
> > >
> > > Pierre Smits
> > >
> > > ORRTIZ.COM 
> > > OFBiz based solutions & services
> > >
> > > OFBiz Extensions Marketplace
> > > http://oem.ofbizci.net/oci-2/
> > >
> > > On Sat, Jul 16, 2016 at 7:06 PM, Pierre Smits 
> > > wrote:
> > >
> > > > Thanks.
> > > >
> > > > In a wadload of postgresql jars found I got:
> > > >
> > > >
> > > >
> > >
> >
> ./Users/pierre/.gradle/caches/modules-2/files-2.1/postgresql/postgresql/9.0-801.jdbc4/153f2f92a786f12fc111d0111f709012df87c808/postgresql-9.0-801.jdbc4.jar
> > > >
> > > > So that adds to the traceability issue I have. A pom in one folder
> and
> > a
> > > > jar in another, no apparent relation and no logging. More digging to
> > do.
> > > :(
> > > >
> > > > Best regards,
> > > >
> > > > Pierre Smits
> > > >
> > > > ORRTIZ.COM 
> > > > OFBiz based solutions & services
> > > >
> > > > OFBiz Extensions Marketplace
> > > > http://oem.ofbizci.net/oci-2/
> > > >
> > > > On Sat, Jul 16, 2016 at 6:54 PM, Taher Alkhateeb <
> > > > slidingfilame...@gmail.com> wrote:
> > > >
> > > >> find . -iname "*postgres*.jar"
> > > >>
> > > >> On Jul 16, 2016 7:50 PM, "Pierre Smits" 
> > wrote:
> > > >>
> > > >> > Hmm.
> > > >> >
> > > >> > It seems I overlooked that it was a directory.
> > > >> >
> > > >> > This is what I have in the directory:
> > > >> >
> > > >> > Pierres-MacBook-Pro:files-2.1 pierre$ ls
> > > >> >
> > > >> >
> > > >>
> > >
> >
> ./caches/modules-2/files-2/postgresql/postgresql/9.0-801.jdbc4/58952dea25c6251a7666d8eea01e4a31da0f8cf7
> > > >> >
> > > >> > postgresql-9.0-801.jdbc4.pom
> > > >> >
> > > >> > And the pom file contains:
> > > >> >
> > > >> > 
> > > >> >
> > > >> > 
> > > >> >
> > > >> >   4.0.0
> > > >> >
> > > >> >   postgresql
> > > >> >
> > > >> >   postgresql
> > > >> >
> > > >> >   jar
> > > >> >
> > > >> >   PostgreSQL JDBC Driver
> > > >> >
> > > >> >   9.0-801.jdbc4
> > > >> >
> > > >> >   http://jdbc.postgresql.org
> > > >> >
> > > >> >   The PostgreSQL Driver JDBC4
> > > >> >
> > > >> >   
> > > >> >
> > > >> > 
> > > >> >
> > > >> >   BSD License
> > > >> >
> > > >> >   http://jdbc.postgresql.org/license.html
> > > >> >
> > > >> >   repo
> > > >> >
> > > >> > 
> > > >> >
> > > >> >   
> > > >> >
> > > >> > 
> > > >> >
> > > >> >
> > > >> > I am yet to find the actual jar on my Mac.
> > > >> >
> > > >> >
> > > >> > Best regards,
> > > >> >
> > > >> > Pierre Smits
> > > >> >
> > > >> > ORRTIZ.COM 
> > > >> > OFBiz based solutions & services
> > > >> >
> > > >> > OFBiz Extensions Marketplace
> > > >> > http://oem.ofbizci.net/oci-2/
> > > >> >
> > > >> > On Sat, Jul 16, 2016 at 6:42 PM, Taher Alkhateeb <
> > > >> > slidingfilame...@gmail.com
> > > >> > > wrote:
> > > >> >
> > > >> > > Hi Pierre,
> > > >> > >
> > > >> > > The jar name is 

[jira] [Resolved] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taher Alkhateeb resolved OFBIZ-6274.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

This issue is resolved, we should keep it open for a few days just to ensure no 
further regressions arise.

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381260#comment-15381260
 ] 

Taher Alkhateeb commented on OFBIZ-6274:


I'm very happy to report that we believe the issue is resolved. The problems we 
discovered were due to heavy resource usage from logging. The logging system 
got polluted with too many messages because upon renaming the old logger 
(org.apache) became the parent of all OFBiz classes (org.apache.ofbiz) so the 
messages were numerous and causing system strain.

3 tests passed on my computer, 1 on Jacques, and 2 tests passed on the 
buildbot. I think this marks the issue as resolved :)

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381240#comment-15381240
 ] 

Jacques Le Roux commented on OFBIZ-6274:


Committed: At revision: 1753029  


> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381235#comment-15381235
 ] 

Taher Alkhateeb edited comment on OFBIZ-6274 at 7/17/16 8:39 AM:
-

A now it makes sense. So the rename is adding more because org.apache.ofbiz 
is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older 
code isn't order important? Meaning should it not be:

{code: xml}



{code}

Instead of

{code:xml}




...
{code}


was (Author: taher):
A now it makes sense. So the rename is adding more because org.apache.ofbiz 
is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older 
code isn't order important? Meaning should it not be:

{code: xml}



{code}

Instead of

{code: xml}




...
{code}

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381235#comment-15381235
 ] 

Taher Alkhateeb edited comment on OFBIZ-6274 at 7/17/16 8:40 AM:
-

A now it makes sense. So the rename is adding more because org.apache.ofbiz 
is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older 
code isn't order important? Meaning should it not be:

{code:xml}



{code}

Instead of

{code:xml}




...
{code}


was (Author: taher):
A now it makes sense. So the rename is adding more because org.apache.ofbiz 
is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older 
code isn't order important? Meaning should it not be:

{code: xml}



{code}

Instead of

{code:xml}




...
{code}

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381235#comment-15381235
 ] 

Taher Alkhateeb commented on OFBIZ-6274:


A now it makes sense. So the rename is adding more because org.apache.ofbiz 
is a subset of org.apache. Ok it clicks in place now.

But now I am not sure about your patch, by comparing your work with the older 
code isn't order important? Meaning should it not be:

{code: xml}



{code}

Instead of

{code: xml}




...
{code}

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot success in on ofbiz-trunk

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/1113

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1753024
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381229#comment-15381229
 ] 

Jacques Le Roux commented on OFBIZ-6274:


Ah, I think I forgot to explain why we had the org.apache logger in 1st place. 
IIRW, it's because we use Apache libs (eg Tomcat) and we want to be warned when 
issues appear at this level

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381227#comment-15381227
 ] 

Jacques Le Roux commented on OFBIZ-6274:


I agree, I'm also unsure of the reason. I did that by analogy since 

existed. I Googled for an explanation but I'm still short of it. 

For now it works, so I apply the patch because it's already a relief.

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets instead of ftl

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux resolved OFBIZ-6302.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Pierre,

Your modified patch is in trunk at revision: 1753024 

I updated the patch. I fixed things by hand: tabs in the groovy files, removed 
the ftl file because of a tree conflicts due to the recent ftl files move and 
updated org.ofbiz to org.apache.ofbiz in CertKeystore.groovy

I don't close to let you check all is allright before closing, thanks!




> Ftl to Widget: improve ViewCertificate to use widgets instead of ftl
> 
>
> Key: OFBIZ-6302
> URL: https://issues.apache.org/jira/browse/OFBIZ-6302
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6302-Certificate.patch, 
> OFBIZ-6302-Certificate.patch
>
>
> Currently the screen ViewCertificate uses a freemarker to render the form(s). 
> This can be replaced by widgets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets instead of ftl

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6302:
---
Summary: Ftl to Widget: improve ViewCertificate to use widgets instead of 
ftl  (was: Ftl to Widget: improve ViewCertificate to use widgets in stead of 
ftl)

> Ftl to Widget: improve ViewCertificate to use widgets instead of ftl
> 
>
> Key: OFBIZ-6302
> URL: https://issues.apache.org/jira/browse/OFBIZ-6302
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: security
> Attachments: OFBIZ-6302-Certificate.patch, 
> OFBIZ-6302-Certificate.patch
>
>
> Currently the screen ViewCertificate uses a freemarker to render the form(s). 
> This can be replaced by widgets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381209#comment-15381209
 ] 

Taher Alkhateeb commented on OFBIZ-6274:


It's not a problem at all, it's only strange that we need to add it now. I 
would imagine an org.apache logger should not exist, there should only be 
org.apache.ofbiz or org.ofbiz (on the older revision). Having both means 
somewhere in the code something is requesting the org.apache when it should 
instead request org.apache.ofbiz.

I could be wrong of course. I see no problem in applying your fix but it means 
we still did not hit root-cause.

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381174#comment-15381174
 ] 

Jacques Le Roux commented on OFBIZ-6274:


But we had already 2 loggers
  
  
So why adding a 3rd is a problem?

BTW I prefer this order. It shows we can override things. Though I'm still 
unsure about that, but this idea worked to show the log info with my patch.


> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381162#comment-15381162
 ] 

Taher Alkhateeb commented on OFBIZ-6274:


Hmmm, something does not feel right about this. We should not have two loggers, 
we should have only one logger. Having two loggers means the java code (or XML 
I don't know) is defining it twice.

This business of switching to org.apache.ofbiz is proving more complex than on 
first attempt.

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381160#comment-15381160
 ] 

Jacques Le Roux commented on OFBIZ-6274:


Hi Taher,
I tried your patch, but I prefer:
{code}
Index: framework/base/config/log4j2.xml
===
--- framework/base/config/log4j2.xml(revision 1753016)
+++ framework/base/config/log4j2.xml(working copy)
@@ -40,8 +40,9 @@
 
 
 
+
+
 
-
 

 
{code}
Because with your I saw a lot of debug info I don't want in standard mode (the 
mode we had before). Not sure why we seem to not get the same result, weird.

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)