date:20170710


I'll refrain to speak about swallowed exceptions ;)

I still want to continue on OFBIZ-8341 but accepted to get sidetracked in multi 
ways :)

Jacques


Le 10/07/2017 à 21:36, Taher Alkhateeb a écrit :

Fixed it in the JIRA, the EntitySaxReader (should be the next class to
refactor) is logging an error but suppressing an exception. The logic
for "continue-on-error" had to go 3 classes deep to work correctly. I
always underestimate how much spaghetti code we have :)

On Mon, Jul 10, 2017 at 8:14 PM, Taher Alkhateeb
 wrote:

Quick update, to my surprise an exception is swallowed
dp in the call stack. So getting this
feature might require some intrusive changes. I'm still working on it
and will keep you posted, but as of right now, no exception is
bubbling up to be caught with "continue-on-failure"

On Mon, Jul 10, 2017 at 2:14 PM, Taher Alkhateeb
 wrote:

Thank you everyone for your feedback, I will let this discussion
continue for a few days before committing anything (testing is going
to take some time anyway).

Now, I need help, I have a big patch in [1] that does what we
discussed in this thread and a whole lot more. If you have the time, I
really need your help! Most useful help is testing, there are so many
properties and combinations to use, so this requires thorough testing.
Also for those familiar with the core framework API, a second look at
the code would help.

[1] https://issues.apache.org/jira/browse/OFBIZ-9441

On Mon, Jul 10, 2017 at 1:45 PM, Devanshu Vyas
 wrote:

I agree with option #3 and the 'continue-on-failure' flag with default
value=false. :)

Thanks & Regards,
Devanshu Vyas.

On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb 
wrote:

I'm good to go with option #3 and continue-on-failure.

Just wanted to mention one thing here; for which type of data we will be
failing build. That means, we have several options seed, ext, demo. Do we
need to discuss these points or we are fine for all type of data. Like

demo

data fails only affect a process for that data set only, and for that
failing build is okay or not (as on data load we get logs if any file
didn't load).


Btw, I'm good with the proposal, just sharing a thought in case we should
discuss or may be we can simply ignore if we are good with that.

Thaks!



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:


Historically the data loader boolean props are false if ommitted and

the

code expects that, but you have a point about the double negative. We

can

instead call it "continue-on-failure" for example.


+1 continue-on-failure with default value false

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co




On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 

wrote:

Hi all,

I agree with option 3. I recall in my own work I once needed to add a

throw

where there was none to track down a problem.

However ignore-failure leads to a double negative. How about
"stop-on-failure", default value true?

Cheers

Paul Foxworthy


On 10 July 2017 at 05:27, Taher Alkhateeb  wrote:

Hello Everyone,

For a long time I was annoyed by something in OFBiz: the build

system

does not fail if data loading fails for some files. I spend hours
hunting bugs only to discover that the data simply did not load.

Given that I'm working on refactoring the data loading container,

I

believe this issue should resolved. However, I'm not sure if the
community is interested in making such a change.

So I list below 3 options to select from:

1- Leave it as is, do not fail the build if some files do not load
2- Continue loading until all files are done and then fail the

build

3- Provide a flag e.g. ignore-failure that tells the system

whether

to

fail or not with a default value of "false".

My personal preference is for (3)

WDYT?



--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web:

Re: [Discussion] Failing the build if data loading fails

Fixed it in the JIRA, the EntitySaxReader (should be the next class to
refactor) is logging an error but suppressing an exception. The logic
for "continue-on-error" had to go 3 classes deep to work correctly. I
always underestimate how much spaghetti code we have :)

On Mon, Jul 10, 2017 at 8:14 PM, Taher Alkhateeb
 wrote:
> Quick update, to my surprise an exception is swallowed
> dp in the call stack. So getting this
> feature might require some intrusive changes. I'm still working on it
> and will keep you posted, but as of right now, no exception is
> bubbling up to be caught with "continue-on-failure"
>
> On Mon, Jul 10, 2017 at 2:14 PM, Taher Alkhateeb
>  wrote:
>> Thank you everyone for your feedback, I will let this discussion
>> continue for a few days before committing anything (testing is going
>> to take some time anyway).
>>
>> Now, I need help, I have a big patch in [1] that does what we
>> discussed in this thread and a whole lot more. If you have the time, I
>> really need your help! Most useful help is testing, there are so many
>> properties and combinations to use, so this requires thorough testing.
>> Also for those familiar with the core framework API, a second look at
>> the code would help.
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9441
>>
>> On Mon, Jul 10, 2017 at 1:45 PM, Devanshu Vyas
>>  wrote:
>>> I agree with option #3 and the 'continue-on-failure' flag with default
>>> value=false. :)
>>>
>>> Thanks & Regards,
>>> Devanshu Vyas.
>>>
>>> On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb >>
 Hi Rishi,

 So my suggestion is that if anything does not load, then immediately fail.

 Why am I suggesting this?
 - You have to intentionally ignore data failure after being aware of
 it (it does not slip between the cracks)
 - The data will automatically get cleaned by committers because no
 failing data will be committed to the code base.

 I suspect we will actually catch some data loading failures that exist
 in the code base and we are maybe unaware of.

 On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki 
 wrote:
 > I'm good to go with option #3 and continue-on-failure.
 >
 > Just wanted to mention one thing here; for which type of data we will be
 > failing build. That means, we have several options seed, ext, demo. Do we
 > need to discuss these points or we are fine for all type of data. Like
 demo
 > data fails only affect a process for that data set only, and for that
 > failing build is okay or not (as on data load we get logs if any file
 > didn't load).
 >
 >
 > Btw, I'm good with the proposal, just sharing a thought in case we should
 > discuss or may be we can simply ignore if we are good with that.
 >
 > Thaks!
 >
 >
 >
 > Rishi Solanki
 > Sr Manager, Enterprise Software Development
 > HotWax Systems Pvt. Ltd.
 > Direct: +91-9893287847
 > http://www.hotwaxsystems.com
 >
 > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
 > deepak.di...@hotwaxsystems.com> wrote:
 >
 >> > Historically the data loader boolean props are false if ommitted and
 the
 >> > code expects that, but you have a point about the double negative. We
 can
 >> > instead call it "continue-on-failure" for example.
 >> >
 >>
 >> +1 continue-on-failure with default value false
 >>
 >> Thanks & Regards
 >> --
 >> Deepak Dixit
 >> www.hotwaxsystems.com
 >> www.hotwax.co
 >>
 >>
 >>
 >> >
 >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 
 wrote:
 >> >
 >> > Hi all,
 >> >
 >> > I agree with option 3. I recall in my own work I once needed to add a
 >> throw
 >> > where there was none to track down a problem.
 >> >
 >> > However ignore-failure leads to a double negative. How about
 >> > "stop-on-failure", default value true?
 >> >
 >> > Cheers
 >> >
 >> > Paul Foxworthy
 >> >
 >> >
 >> > On 10 July 2017 at 05:27, Taher Alkhateeb 
 >> > wrote:
 >> >
 >> > > Correction: on item (2) in my post: fail immediately, not after
 >> > > loading all files, otherwise there's no point.
 >> > >
 >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
 >> > >  wrote:
 >> > > > Hello Everyone,
 >> > > >
 >> > > > For a long time I was annoyed by something in OFBiz: the build
 system
 >> > > > does not fail if data loading fails for some files. I spend hours
 >> > > > hunting bugs only to discover that the data simply did not load.
 >> > > >
 >> > > > Given that I'm working on refactoring the data loading

Re: [Discussion] Failing the build if data loading fails

Quick update, to my surprise an exception is swallowed
dp in the call stack. So getting this
feature might require some intrusive changes. I'm still working on it
and will keep you posted, but as of right now, no exception is
bubbling up to be caught with "continue-on-failure"

On Mon, Jul 10, 2017 at 2:14 PM, Taher Alkhateeb
 wrote:
> Thank you everyone for your feedback, I will let this discussion
> continue for a few days before committing anything (testing is going
> to take some time anyway).
>
> Now, I need help, I have a big patch in [1] that does what we
> discussed in this thread and a whole lot more. If you have the time, I
> really need your help! Most useful help is testing, there are so many
> properties and combinations to use, so this requires thorough testing.
> Also for those familiar with the core framework API, a second look at
> the code would help.
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9441
>
> On Mon, Jul 10, 2017 at 1:45 PM, Devanshu Vyas
>  wrote:
>> I agree with option #3 and the 'continue-on-failure' flag with default
>> value=false. :)
>>
>> Thanks & Regards,
>> Devanshu Vyas.
>>
>> On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb >> wrote:
>>
>>> Hi Rishi,
>>>
>>> So my suggestion is that if anything does not load, then immediately fail.
>>>
>>> Why am I suggesting this?
>>> - You have to intentionally ignore data failure after being aware of
>>> it (it does not slip between the cracks)
>>> - The data will automatically get cleaned by committers because no
>>> failing data will be committed to the code base.
>>>
>>> I suspect we will actually catch some data loading failures that exist
>>> in the code base and we are maybe unaware of.
>>>
>>> On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki 
>>> wrote:
>>> > I'm good to go with option #3 and continue-on-failure.
>>> >
>>> > Just wanted to mention one thing here; for which type of data we will be
>>> > failing build. That means, we have several options seed, ext, demo. Do we
>>> > need to discuss these points or we are fine for all type of data. Like
>>> demo
>>> > data fails only affect a process for that data set only, and for that
>>> > failing build is okay or not (as on data load we get logs if any file
>>> > didn't load).
>>> >
>>> >
>>> > Btw, I'm good with the proposal, just sharing a thought in case we should
>>> > discuss or may be we can simply ignore if we are good with that.
>>> >
>>> > Thaks!
>>> >
>>> >
>>> >
>>> > Rishi Solanki
>>> > Sr Manager, Enterprise Software Development
>>> > HotWax Systems Pvt. Ltd.
>>> > Direct: +91-9893287847
>>> > http://www.hotwaxsystems.com
>>> >
>>> > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
>>> > deepak.di...@hotwaxsystems.com> wrote:
>>> >
>>> >> > Historically the data loader boolean props are false if ommitted and
>>> the
>>> >> > code expects that, but you have a point about the double negative. We
>>> can
>>> >> > instead call it "continue-on-failure" for example.
>>> >> >
>>> >>
>>> >> +1 continue-on-failure with default value false
>>> >>
>>> >> Thanks & Regards
>>> >> --
>>> >> Deepak Dixit
>>> >> www.hotwaxsystems.com
>>> >> www.hotwax.co
>>> >>
>>> >>
>>> >>
>>> >> >
>>> >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 
>>> wrote:
>>> >> >
>>> >> > Hi all,
>>> >> >
>>> >> > I agree with option 3. I recall in my own work I once needed to add a
>>> >> throw
>>> >> > where there was none to track down a problem.
>>> >> >
>>> >> > However ignore-failure leads to a double negative. How about
>>> >> > "stop-on-failure", default value true?
>>> >> >
>>> >> > Cheers
>>> >> >
>>> >> > Paul Foxworthy
>>> >> >
>>> >> >
>>> >> > On 10 July 2017 at 05:27, Taher Alkhateeb >> >
>>> >> > wrote:
>>> >> >
>>> >> > > Correction: on item (2) in my post: fail immediately, not after
>>> >> > > loading all files, otherwise there's no point.
>>> >> > >
>>> >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
>>> >> > >  wrote:
>>> >> > > > Hello Everyone,
>>> >> > > >
>>> >> > > > For a long time I was annoyed by something in OFBiz: the build
>>> system
>>> >> > > > does not fail if data loading fails for some files. I spend hours
>>> >> > > > hunting bugs only to discover that the data simply did not load.
>>> >> > > >
>>> >> > > > Given that I'm working on refactoring the data loading container,
>>> I
>>> >> > > > believe this issue should resolved. However, I'm not sure if the
>>> >> > > > community is interested in making such a change.
>>> >> > > >
>>> >> > > > So I list below 3 options to select from:
>>> >> > > >
>>> >> > > > 1- Leave it as is, do not fail the build if some files do not load
>>> >> > > > 2- Continue loading until all files are done and then fail the
>>> build
>>> >> > > > 3- Provide a flag e.g. ignore-failure that tells the system
>>>

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Hi Jacques,

I'll wait a few days if there are any objections and take care of it then.

Michael

Am 10.07.17 um 16:27 schrieb Jacques Le Roux:

If we agree (I guess we do) then we should update the committer page

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities

Thanks

Jacques

Le 10/07/2017 à 15:05, Michael Brohl a écrit :
Additional idea: we can also flag the issue with a label
"backport-needed" to easily find open issues which need a backport.

Am 10.07.17 um 14:55 schrieb Jacques Le Roux:

+1 for leaving open with a comment

Jacques

Le 10/07/2017 à 14:19, Deepak Dixit a écrit :

+1 , I think instead of opening new issue, we can leave it open with
comment

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl

wrote:

Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport
himself, we
should make sure that bugfixes go into the supported release
branches also.

I propose to define the following policies:

1. bugfixes should be backported by the committer who does the
bugfix in

trunk if possible

2. if he does not, for an reason, backport the bugfix, he should
either
open a new Jira for a task to backport or leave the original issue
open

with a remark that a backport is needed.

(I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):

[ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
l=16080188#comment-16080188 ]

Jacques Le Roux commented on OFBIZ-9459:

Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is
there a

reason? Do you want me to do it? Thanks.

Wrong screen redirection after adding note on Lead profile screen

Key: OFBIZ-9459
URL:
https://issues.apache.org/jira/browse/OFBIZ-9459

Project: OFBiz
Issue Type: Bug
Components: marketing
Reporter: Jagpreet Kaur
Assignee: Arun Patidar
Fix For: Upcoming Release

Attachments: Create Note.png, OFBIZ-9459.patch,
Screenredirection.png

ofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-
ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
=LEAD=DemoLead]
4) Click on "Create New" button in the Notes section.
5) Add the Note content.
6) Click on "Save Button".
View redirection should be profile but it shows the blank screen.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

smime.p7s
Description: S/MIME Cryptographic Signature

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

If we agree (I guess we do) then we should update the committer page

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities

Thanks

Jacques

Le 10/07/2017 à 15:05, Michael Brohl a écrit :

Additional idea: we can also flag the issue with a label "backport-needed" to
easily find open issues which need a backport.

Am 10.07.17 um 14:55 schrieb Jacques Le Roux:

+1 for leaving open with a comment

Jacques

Le 10/07/2017 à 14:19, Deepak Dixit a écrit :

+1 , I think instead of opening new issue, we can leave it open with
comment

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl
wrote:

Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport himself, we
should make sure that bugfixes go into the supported release branches also.

I propose to define the following policies:

1. bugfixes should be backported by the committer who does the bugfix in
trunk if possible

2. if he does not, for an reason, backport the bugfix, he should either
open a new Jira for a task to backport or leave the original issue open
with a remark that a backport is needed.

(I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):

[ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
l=16080188#comment-16080188 ]

Jacques Le Roux commented on OFBIZ-9459:

Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
reason? Do you want me to do it? Thanks.

Wrong screen redirection after adding note on Lead profile screen

Key: OFBIZ-9459
URL: https://issues.apache.org/jira/browse/OFBIZ-9459
Project: OFBiz
Issue Type: Bug
Components: marketing
Reporter: Jagpreet Kaur
Assignee: Arun Patidar
Fix For: Upcoming Release

Attachments: Create Note.png, OFBIZ-9459.patch,
Screenredirection.png

1) Go to SFA component.
2) Click on Leads tab [https://demo-trunk-ofbiz.apac
he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
apache.org:8443/sfa/control/FindLeads].
3) Choose any partyId from All Lead list, you will be navigated to Lead
profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
ofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-
ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
=LEAD=DemoLead]
4) Click on "Create New" button in the Notes section.
5) Add the Note content.
6) Click on "Save Button".
View redirection should be profile but it shows the blank screen.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Additional idea: we can also flag the issue with a label 
"backport-needed" to easily find open issues which need a backport.



Am 10.07.17 um 14:55 schrieb Jacques Le Roux:

+1 for leaving open with a comment

Jacques


Le 10/07/2017 à 14:19, Deepak Dixit a écrit :

+1 , I think instead of opening new issue, we can leave it open with
comment



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl 


wrote:


Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport 
himself, we
should make sure that bugfixes go into the supported release 
branches also.


I propose to define the following policies:

1. bugfixes should be backported by the committer who does the 
bugfix in

trunk if possible

2. if he does not, for an reason, backport the bugfix, he should either
open a new Jira for a task to backport or leave the original issue open
with a remark that a backport is needed.

 (I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):


  [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
l=16080188#comment-16080188 ]

Jacques Le Roux commented on OFBIZ-9459:


Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
reason? Do you want me to do it? Thanks.

Wrong screen redirection after adding note on Lead profile screen

-

  Key: OFBIZ-9459
  URL: 
https://issues.apache.org/jira/browse/OFBIZ-9459

  Project: OFBiz
   Issue Type: Bug
   Components: marketing
 Reporter: Jagpreet Kaur
 Assignee: Arun Patidar
  Fix For: Upcoming Release

  Attachments: Create Note.png, OFBIZ-9459.patch,
Screenredirection.png


1) Go to SFA component.
2) Click on Leads tab [https://demo-trunk-ofbiz.apac
he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
apache.org:8443/sfa/control/FindLeads].
3) Choose any partyId from All Lead list, you will be navigated to 
Lead

profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
ofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-
ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
=LEAD=DemoLead]
4) Click on "Create New" button in the Notes section.
5) Add the Note content.
6) Click on "Save Button".
View redirection should be profile but it shows the blank screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)











smime.p7s
Description: S/MIME Cryptographic Signature

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen


+1 for leaving open with a comment

Jacques


Le 10/07/2017 à 14:19, Deepak Dixit a écrit :

+1 , I think instead of opening new issue, we can leave it open with
comment



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl 
wrote:


Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport himself, we
should make sure that bugfixes go into the supported release branches also.

I propose to define the following policies:

1. bugfixes should be backported by the committer who does the bugfix in
trunk if possible

2. if he does not, for an reason, backport the bugfix, he should either
open a new Jira for a task to backport or leave the original issue open
with a remark that a backport is needed.

 (I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):


  [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
l=16080188#comment-16080188 ]

Jacques Le Roux commented on OFBIZ-9459:


Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
reason? Do you want me to do it? Thanks.

Wrong screen redirection after adding note on Lead profile screen

-

  Key: OFBIZ-9459
  URL: https://issues.apache.org/jira/browse/OFBIZ-9459
  Project: OFBiz
   Issue Type: Bug
   Components: marketing
 Reporter: Jagpreet Kaur
 Assignee: Arun Patidar
  Fix For: Upcoming Release

  Attachments: Create Note.png, OFBIZ-9459.patch,
Screenredirection.png


1) Go to SFA component.
2) Click on Leads tab [https://demo-trunk-ofbiz.apac
he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
apache.org:8443/sfa/control/FindLeads].
3) Choose any partyId from All Lead list, you will be navigated to Lead
profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
ofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-
ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
=LEAD=DemoLead]
4) Click on "Create New" button in the Notes section.
5) Add the Note content.
6) Click on "Save Button".
View redirection should be profile but it shows the blank screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

2017-07-10 Thread Deepak Dixit

+1 , I think instead of opening new issue, we can leave it open with
comment



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl 
wrote:

> Hi everyone,
>
> I think we should setup some kind of policy for the bugfixing in the
> project.
>
> While every committer is free to decide if he does a backport himself, we
> should make sure that bugfixes go into the supported release branches also.
>
> I propose to define the following policies:
>
> 1. bugfixes should be backported by the committer who does the bugfix in
> trunk if possible
>
> 2. if he does not, for an reason, backport the bugfix, he should either
> open a new Jira for a task to backport or leave the original issue open
> with a remark that a backport is needed.
>
> (I tend to leave the issue open).
>
> In no case should we close a Jira issue without doing 1. or 2.
>
> What do you think?
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>
>>  [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>> l=16080188#comment-16080188 ]
>>
>> Jacques Le Roux commented on OFBIZ-9459:
>> 
>>
>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>> reason? Do you want me to do it? Thanks.
>>
>> Wrong screen redirection after adding note on Lead profile screen
>>> -
>>>
>>>  Key: OFBIZ-9459
>>>  URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>>  Project: OFBiz
>>>   Issue Type: Bug
>>>   Components: marketing
>>> Reporter: Jagpreet Kaur
>>> Assignee: Arun Patidar
>>>  Fix For: Upcoming Release
>>>
>>>  Attachments: Create Note.png, OFBIZ-9459.patch,
>>> Screenredirection.png
>>>
>>>
>>> 1) Go to SFA component.
>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>> apache.org:8443/sfa/control/FindLeads].
>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>> ofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-
>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>> =LEAD=DemoLead]
>>> 4) Click on "Create New" button in the Notes section.
>>> 5) Add the Note content.
>>> 6) Click on "Save Button".
>>> View redirection should be profile but it shows the blank screen.
>>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.4.14#64029)
>>
>
>
>

[PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport himself,
we should make sure that bugfixes go into the supported release branches
also.

I propose to define the following policies:

1. bugfixes should be backported by the committer who does the bugfix in
trunk if possible

2. if he does not, for an reason, backport the bugfix, he should either
open a new Jira for a task to backport or leave the original issue open
with a remark that a backport is needed.

(I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):

[
https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080188#comment-16080188
]

Jacques Le Roux commented on OFBIZ-9459:

Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a reason?
Do you want me to do it? Thanks.

Wrong screen redirection after adding note on Lead profile screen
-

Key: OFBIZ-9459
URL: https://issues.apache.org/jira/browse/OFBIZ-9459
Project: OFBiz
Issue Type: Bug
Components: marketing
Reporter: Jagpreet Kaur
Assignee: Arun Patidar
Fix For: Upcoming Release

Attachments: Create Note.png, OFBIZ-9459.patch, Screenredirection.png

1) Go to SFA component.
2) Click on Leads tab
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads].
3) Choose any partyId from All Lead list, you will be navigated to Lead profile.
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD=DemoLead|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD=DemoLead]
4) Click on "Create New" button in the Notes section.
5) Add the Note content.
6) Click on "Save Button".
View redirection should be profile but it shows the blank screen.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

smime.p7s
Description: S/MIME Cryptographic Signature

Re: [Discussion] Failing the build if data loading fails

Thank you everyone for your feedback, I will let this discussion
continue for a few days before committing anything (testing is going
to take some time anyway).

Now, I need help, I have a big patch in [1] that does what we
discussed in this thread and a whole lot more. If you have the time, I
really need your help! Most useful help is testing, there are so many
properties and combinations to use, so this requires thorough testing.
Also for those familiar with the core framework API, a second look at
the code would help.

[1] https://issues.apache.org/jira/browse/OFBIZ-9441

On Mon, Jul 10, 2017 at 1:45 PM, Devanshu Vyas
 wrote:
> I agree with option #3 and the 'continue-on-failure' flag with default
> value=false. :)
>
> Thanks & Regards,
> Devanshu Vyas.
>
> On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb > wrote:
>
>> Hi Rishi,
>>
>> So my suggestion is that if anything does not load, then immediately fail.
>>
>> Why am I suggesting this?
>> - You have to intentionally ignore data failure after being aware of
>> it (it does not slip between the cracks)
>> - The data will automatically get cleaned by committers because no
>> failing data will be committed to the code base.
>>
>> I suspect we will actually catch some data loading failures that exist
>> in the code base and we are maybe unaware of.
>>
>> On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki 
>> wrote:
>> > I'm good to go with option #3 and continue-on-failure.
>> >
>> > Just wanted to mention one thing here; for which type of data we will be
>> > failing build. That means, we have several options seed, ext, demo. Do we
>> > need to discuss these points or we are fine for all type of data. Like
>> demo
>> > data fails only affect a process for that data set only, and for that
>> > failing build is okay or not (as on data load we get logs if any file
>> > didn't load).
>> >
>> >
>> > Btw, I'm good with the proposal, just sharing a thought in case we should
>> > discuss or may be we can simply ignore if we are good with that.
>> >
>> > Thaks!
>> >
>> >
>> >
>> > Rishi Solanki
>> > Sr Manager, Enterprise Software Development
>> > HotWax Systems Pvt. Ltd.
>> > Direct: +91-9893287847
>> > http://www.hotwaxsystems.com
>> >
>> > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
>> > deepak.di...@hotwaxsystems.com> wrote:
>> >
>> >> > Historically the data loader boolean props are false if ommitted and
>> the
>> >> > code expects that, but you have a point about the double negative. We
>> can
>> >> > instead call it "continue-on-failure" for example.
>> >> >
>> >>
>> >> +1 continue-on-failure with default value false
>> >>
>> >> Thanks & Regards
>> >> --
>> >> Deepak Dixit
>> >> www.hotwaxsystems.com
>> >> www.hotwax.co
>> >>
>> >>
>> >>
>> >> >
>> >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 
>> wrote:
>> >> >
>> >> > Hi all,
>> >> >
>> >> > I agree with option 3. I recall in my own work I once needed to add a
>> >> throw
>> >> > where there was none to track down a problem.
>> >> >
>> >> > However ignore-failure leads to a double negative. How about
>> >> > "stop-on-failure", default value true?
>> >> >
>> >> > Cheers
>> >> >
>> >> > Paul Foxworthy
>> >> >
>> >> >
>> >> > On 10 July 2017 at 05:27, Taher Alkhateeb > >
>> >> > wrote:
>> >> >
>> >> > > Correction: on item (2) in my post: fail immediately, not after
>> >> > > loading all files, otherwise there's no point.
>> >> > >
>> >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
>> >> > >  wrote:
>> >> > > > Hello Everyone,
>> >> > > >
>> >> > > > For a long time I was annoyed by something in OFBiz: the build
>> system
>> >> > > > does not fail if data loading fails for some files. I spend hours
>> >> > > > hunting bugs only to discover that the data simply did not load.
>> >> > > >
>> >> > > > Given that I'm working on refactoring the data loading container,
>> I
>> >> > > > believe this issue should resolved. However, I'm not sure if the
>> >> > > > community is interested in making such a change.
>> >> > > >
>> >> > > > So I list below 3 options to select from:
>> >> > > >
>> >> > > > 1- Leave it as is, do not fail the build if some files do not load
>> >> > > > 2- Continue loading until all files are done and then fail the
>> build
>> >> > > > 3- Provide a flag e.g. ignore-failure that tells the system
>> whether
>> >> to
>> >> > > > fail or not with a default value of "false".
>> >> > > >
>> >> > > > My personal preference is for (3)
>> >> > > >
>> >> > > > WDYT?
>> >> > >
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Coherent Software Australia Pty Ltd
>> >> > PO Box 2773
>> >> > Cheltenham Vic 3192
>> >> > Australia
>> >> >
>> >> > Phone: +61 3 9585 6788
>> >> > Web: http://www.coherentsoftware.com.au/
>> >> > Email: i...@coherentsoftware.com.au
>> >> >
>> >>
>>

Re: Document Location


Rishi,

yes, that's what I am proposing.

I'll create the page, it should serve as an Index page for the case

It would be cool if we can collect some more cases studies here.

Thanks,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 10.07.17 um 12:46 schrieb Rishi Solanki:

Thanks Michael,

Just to be super clear you are proposing;


Instead of moving to here: Document > Case Studies > Brewing with OFBiz at
a small or medium sized brewery
Better place is: Community/ References/ Case Studies > Brewing with OFBiz
at a small or medium sized brewery

And in case anyone want to contribute more case studies then she can add
her own page under Case Studies parallel to Brewing with OFBiz at a small
or medium sized brewery

+1 from my side and will do this change in a day or two in case no
objection/concerns/suggestion.

Thanks!


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 3:29 PM, Michael Brohl 
wrote:


Hi Rishi,

it's a good idea to move this out of the Uses Cases Library. I think that
it does not belong in the documentation section at all.

The documentation section should, after the restructure, only contain
documentation which belongs to the core OFBiz system.

I propose to move this to Community/ References/ Case Studies (new page),
which seems to be a more appropriate place to me.

Best regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 10.07.17 um 08:17 schrieb Rishi Solanki:


Thanks all, in case no objection in a day or two we will do the changes in
structure.


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav <
sanjay.ya...@hotwaxsystems.com> wrote:

+1

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Part II, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav


HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here


.
[image: Inline image 1]



On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

+1

Best regards,
Pranay Pandey
www.hotwaxsystems.com


On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki 
wrote:

Hi Pierre Smits/All,

I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz


at a


small or medium sized brewery 

I see this is good case study thanks Pierre for that. The only concern
I
have is this is under the 'Business Process Stories and Use Cases


Library'


as parent. I would propose new location for the document.

Current Location: Document > Business Process Stories and Use Cases


Library


Brewing with OFBiz at a small or medium sized brewery
Proposed Location: Document > Case Study > Brewing with OFBiz at a


small or


medium sized brewery


Proposing this so that in case other wanted to add case study then all


can


be found at one place.

If everyone agree then we can move this to new location.


Thanks!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com









smime.p7s
Description: S/MIME Cryptographic Signature

Re: [Discussion] Failing the build if data loading fails

2017-07-10 Thread Devanshu Vyas

I agree with option #3 and the 'continue-on-failure' flag with default
value=false. :)

Thanks & Regards,
Devanshu Vyas.

On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb  wrote:

> Hi Rishi,
>
> So my suggestion is that if anything does not load, then immediately fail.
>
> Why am I suggesting this?
> - You have to intentionally ignore data failure after being aware of
> it (it does not slip between the cracks)
> - The data will automatically get cleaned by committers because no
> failing data will be committed to the code base.
>
> I suspect we will actually catch some data loading failures that exist
> in the code base and we are maybe unaware of.
>
> On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki 
> wrote:
> > I'm good to go with option #3 and continue-on-failure.
> >
> > Just wanted to mention one thing here; for which type of data we will be
> > failing build. That means, we have several options seed, ext, demo. Do we
> > need to discuss these points or we are fine for all type of data. Like
> demo
> > data fails only affect a process for that data set only, and for that
> > failing build is okay or not (as on data load we get logs if any file
> > didn't load).
> >
> >
> > Btw, I'm good with the proposal, just sharing a thought in case we should
> > discuss or may be we can simply ignore if we are good with that.
> >
> > Thaks!
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> >
> > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
> > deepak.di...@hotwaxsystems.com> wrote:
> >
> >> > Historically the data loader boolean props are false if ommitted and
> the
> >> > code expects that, but you have a point about the double negative. We
> can
> >> > instead call it "continue-on-failure" for example.
> >> >
> >>
> >> +1 continue-on-failure with default value false
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotwaxsystems.com
> >> www.hotwax.co
> >>
> >>
> >>
> >> >
> >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 
> wrote:
> >> >
> >> > Hi all,
> >> >
> >> > I agree with option 3. I recall in my own work I once needed to add a
> >> throw
> >> > where there was none to track down a problem.
> >> >
> >> > However ignore-failure leads to a double negative. How about
> >> > "stop-on-failure", default value true?
> >> >
> >> > Cheers
> >> >
> >> > Paul Foxworthy
> >> >
> >> >
> >> > On 10 July 2017 at 05:27, Taher Alkhateeb  >
> >> > wrote:
> >> >
> >> > > Correction: on item (2) in my post: fail immediately, not after
> >> > > loading all files, otherwise there's no point.
> >> > >
> >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
> >> > >  wrote:
> >> > > > Hello Everyone,
> >> > > >
> >> > > > For a long time I was annoyed by something in OFBiz: the build
> system
> >> > > > does not fail if data loading fails for some files. I spend hours
> >> > > > hunting bugs only to discover that the data simply did not load.
> >> > > >
> >> > > > Given that I'm working on refactoring the data loading container,
> I
> >> > > > believe this issue should resolved. However, I'm not sure if the
> >> > > > community is interested in making such a change.
> >> > > >
> >> > > > So I list below 3 options to select from:
> >> > > >
> >> > > > 1- Leave it as is, do not fail the build if some files do not load
> >> > > > 2- Continue loading until all files are done and then fail the
> build
> >> > > > 3- Provide a flag e.g. ignore-failure that tells the system
> whether
> >> to
> >> > > > fail or not with a default value of "false".
> >> > > >
> >> > > > My personal preference is for (3)
> >> > > >
> >> > > > WDYT?
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Coherent Software Australia Pty Ltd
> >> > PO Box 2773
> >> > Cheltenham Vic 3192
> >> > Australia
> >> >
> >> > Phone: +61 3 9585 6788
> >> > Web: http://www.coherentsoftware.com.au/
> >> > Email: i...@coherentsoftware.com.au
> >> >
> >>
>

Re: Document Location

Thanks Michael,

Just to be super clear you are proposing;


Instead of moving to here: Document > Case Studies > Brewing with OFBiz at
a small or medium sized brewery
Better place is: Community/ References/ Case Studies > Brewing with OFBiz
at a small or medium sized brewery

And in case anyone want to contribute more case studies then she can add
her own page under Case Studies parallel to Brewing with OFBiz at a small
or medium sized brewery

+1 from my side and will do this change in a day or two in case no
objection/concerns/suggestion.

Thanks!


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 3:29 PM, Michael Brohl 
wrote:

> Hi Rishi,
>
> it's a good idea to move this out of the Uses Cases Library. I think that
> it does not belong in the documentation section at all.
>
> The documentation section should, after the restructure, only contain
> documentation which belongs to the core OFBiz system.
>
> I propose to move this to Community/ References/ Case Studies (new page),
> which seems to be a more appropriate place to me.
>
> Best regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 10.07.17 um 08:17 schrieb Rishi Solanki:
>
>> Thanks all, in case no objection in a day or two we will do the changes in
>> structure.
>>
>>
>> Rishi Solanki
>> Sr Manager, Enterprise Software Development
>> HotWax Systems Pvt. Ltd.
>> Direct: +91-9893287847
>> http://www.hotwaxsystems.com
>>
>> On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav <
>> sanjay.ya...@hotwaxsystems.com> wrote:
>>
>> +1
>>>
>>> Best Regards,
>>>
>>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
>>> HotWax Commerce  by HotWax Systems
>>> 
>>> 80, Scheme No. 78, Part II, Indore, M.P. 452010, India
>>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
>>> 
>>>
>>> HotWax Systems recently received 8 mentions in *The Gartner Digital
>>> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
>>> research and advisory company. Learn more about our research here
>>> >> rs/HotWax/1-2UVLP6M/index.html>
>>>
>>> .
>>> [image: Inline image 1]
>>>
>>>
>>>
>>> On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey <
>>> pranay.pan...@hotwaxsystems.com> wrote:
>>>
>>> +1

 Best regards,
 Pranay Pandey
 www.hotwaxsystems.com


 On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki 
 wrote:

 Hi Pierre Smits/All,
>
> I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz
>
 at a

> small or medium sized brewery  confluence/x/64HoAg>
>
> I see this is good case study thanks Pierre for that. The only concern
> I
> have is this is under the 'Business Process Stories and Use Cases
>
 Library'

> as parent. I would propose new location for the document.
>
> Current Location: Document > Business Process Stories and Use Cases
>
 Library

> Brewing with OFBiz at a small or medium sized brewery
>>
> Proposed Location: Document > Case Study > Brewing with OFBiz at a
>
 small or

> medium sized brewery
>
>
> Proposing this so that in case other wanted to add case study then all
>
 can

> be found at one place.
>
> If everyone agree then we can move this to new location.
>
>
> Thanks!
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
>
>>>
>
>

Re: [Discussion] Failing the build if data loading fails

Thanks Taher for your reply. I was just pushing the types to set some type
of data as in ignoring. But, now I am completely agree with you on point
"The data will automatically get cleaned by committers because no failing
data will be committed to the code base".

Again +1 for #3 with option continue-on-failure with default false, with no
confusion in thread from my side. :-)


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb  wrote:

> Hi Rishi,
>
> So my suggestion is that if anything does not load, then immediately fail.
>
> Why am I suggesting this?
> - You have to intentionally ignore data failure after being aware of
> it (it does not slip between the cracks)
> - The data will automatically get cleaned by committers because no
> failing data will be committed to the code base.
>
> I suspect we will actually catch some data loading failures that exist
> in the code base and we are maybe unaware of.
>
> On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki 
> wrote:
> > I'm good to go with option #3 and continue-on-failure.
> >
> > Just wanted to mention one thing here; for which type of data we will be
> > failing build. That means, we have several options seed, ext, demo. Do we
> > need to discuss these points or we are fine for all type of data. Like
> demo
> > data fails only affect a process for that data set only, and for that
> > failing build is okay or not (as on data load we get logs if any file
> > didn't load).
> >
> >
> > Btw, I'm good with the proposal, just sharing a thought in case we should
> > discuss or may be we can simply ignore if we are good with that.
> >
> > Thaks!
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> >
> > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
> > deepak.di...@hotwaxsystems.com> wrote:
> >
> >> > Historically the data loader boolean props are false if ommitted and
> the
> >> > code expects that, but you have a point about the double negative. We
> can
> >> > instead call it "continue-on-failure" for example.
> >> >
> >>
> >> +1 continue-on-failure with default value false
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotwaxsystems.com
> >> www.hotwax.co
> >>
> >>
> >>
> >> >
> >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" 
> wrote:
> >> >
> >> > Hi all,
> >> >
> >> > I agree with option 3. I recall in my own work I once needed to add a
> >> throw
> >> > where there was none to track down a problem.
> >> >
> >> > However ignore-failure leads to a double negative. How about
> >> > "stop-on-failure", default value true?
> >> >
> >> > Cheers
> >> >
> >> > Paul Foxworthy
> >> >
> >> >
> >> > On 10 July 2017 at 05:27, Taher Alkhateeb  >
> >> > wrote:
> >> >
> >> > > Correction: on item (2) in my post: fail immediately, not after
> >> > > loading all files, otherwise there's no point.
> >> > >
> >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
> >> > >  wrote:
> >> > > > Hello Everyone,
> >> > > >
> >> > > > For a long time I was annoyed by something in OFBiz: the build
> system
> >> > > > does not fail if data loading fails for some files. I spend hours
> >> > > > hunting bugs only to discover that the data simply did not load.
> >> > > >
> >> > > > Given that I'm working on refactoring the data loading container,
> I
> >> > > > believe this issue should resolved. However, I'm not sure if the
> >> > > > community is interested in making such a change.
> >> > > >
> >> > > > So I list below 3 options to select from:
> >> > > >
> >> > > > 1- Leave it as is, do not fail the build if some files do not load
> >> > > > 2- Continue loading until all files are done and then fail the
> build
> >> > > > 3- Provide a flag e.g. ignore-failure that tells the system
> whether
> >> to
> >> > > > fail or not with a default value of "false".
> >> > > >
> >> > > > My personal preference is for (3)
> >> > > >
> >> > > > WDYT?
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Coherent Software Australia Pty Ltd
> >> > PO Box 2773
> >> > Cheltenham Vic 3192
> >> > Australia
> >> >
> >> > Phone: +61 3 9585 6788
> >> > Web: http://www.coherentsoftware.com.au/
> >> > Email: i...@coherentsoftware.com.au
> >> >
> >>
>

Re: [Discussion] Failing the build if data loading fails


+1

Michael

Am 10.07.17 um 07:03 schrieb Taher Alkhateeb:

Historically the data loader boolean props are false if ommitted and the
code expects that, but you have a point about the double negative. We can
instead call it "continue-on-failure" for example.

On Jul 10, 2017 3:48 AM, "Paul Foxworthy"  wrote:

Hi all,

I agree with option 3. I recall in my own work I once needed to add a throw
where there was none to track down a problem.

However ignore-failure leads to a double negative. How about
"stop-on-failure", default value true?

Cheers

Paul Foxworthy


On 10 July 2017 at 05:27, Taher Alkhateeb 
wrote:


Correction: on item (2) in my post: fail immediately, not after
loading all files, otherwise there's no point.

On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
 wrote:

Hello Everyone,

For a long time I was annoyed by something in OFBiz: the build system
does not fail if data loading fails for some files. I spend hours
hunting bugs only to discover that the data simply did not load.

Given that I'm working on refactoring the data loading container, I
believe this issue should resolved. However, I'm not sure if the
community is interested in making such a change.

So I list below 3 options to select from:

1- Leave it as is, do not fail the build if some files do not load
2- Continue loading until all files are done and then fail the build
3- Provide a flag e.g. ignore-failure that tells the system whether to
fail or not with a default value of "false".

My personal preference is for (3)

WDYT?



--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web: http://www.coherentsoftware.com.au/
Email: i...@coherentsoftware.com.au






smime.p7s
Description: S/MIME Cryptographic Signature

Re: Document Location


Hi Rishi,

it's a good idea to move this out of the Uses Cases Library. I think 
that it does not belong in the documentation section at all.


The documentation section should, after the restructure, only contain 
documentation which belongs to the core OFBiz system.


I propose to move this to Community/ References/ Case Studies (new 
page), which seems to be a more appropriate place to me.


Best regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 10.07.17 um 08:17 schrieb Rishi Solanki:

Thanks all, in case no objection in a day or two we will do the changes in
structure.


Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav <
sanjay.ya...@hotwaxsystems.com> wrote:


+1

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Part II, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav


HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here

.
[image: Inline image 1]



On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:


+1

Best regards,
Pranay Pandey
www.hotwaxsystems.com


On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki 
wrote:


Hi Pierre Smits/All,

I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz

at a

small or medium sized brewery 

I see this is good case study thanks Pierre for that. The only concern I
have is this is under the 'Business Process Stories and Use Cases

Library'

as parent. I would propose new location for the document.

Current Location: Document > Business Process Stories and Use Cases

Library

Brewing with OFBiz at a small or medium sized brewery

Proposed Location: Document > Case Study > Brewing with OFBiz at a

small or

medium sized brewery


Proposing this so that in case other wanted to add case study then all

can

be found at one place.

If everyone agree then we can move this to new location.


Thanks!

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com








smime.p7s
Description: S/MIME Cryptographic Signature

Re: [Discussion] Failing the build if data loading fails

Hi Rishi,

So my suggestion is that if anything does not load, then immediately fail.

Why am I suggesting this?
- You have to intentionally ignore data failure after being aware of
it (it does not slip between the cracks)
- The data will automatically get cleaned by committers because no
failing data will be committed to the code base.

I suspect we will actually catch some data loading failures that exist
in the code base and we are maybe unaware of.

On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki  wrote:
> I'm good to go with option #3 and continue-on-failure.
>
> Just wanted to mention one thing here; for which type of data we will be
> failing build. That means, we have several options seed, ext, demo. Do we
> need to discuss these points or we are fine for all type of data. Like demo
> data fails only affect a process for that data set only, and for that
> failing build is okay or not (as on data load we get logs if any file
> didn't load).
>
>
> Btw, I'm good with the proposal, just sharing a thought in case we should
> discuss or may be we can simply ignore if we are good with that.
>
> Thaks!
>
>
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
> On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
> deepak.di...@hotwaxsystems.com> wrote:
>
>> > Historically the data loader boolean props are false if ommitted and the
>> > code expects that, but you have a point about the double negative. We can
>> > instead call it "continue-on-failure" for example.
>> >
>>
>> +1 continue-on-failure with default value false
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>> www.hotwax.co
>>
>>
>>
>> >
>> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy"  wrote:
>> >
>> > Hi all,
>> >
>> > I agree with option 3. I recall in my own work I once needed to add a
>> throw
>> > where there was none to track down a problem.
>> >
>> > However ignore-failure leads to a double negative. How about
>> > "stop-on-failure", default value true?
>> >
>> > Cheers
>> >
>> > Paul Foxworthy
>> >
>> >
>> > On 10 July 2017 at 05:27, Taher Alkhateeb 
>> > wrote:
>> >
>> > > Correction: on item (2) in my post: fail immediately, not after
>> > > loading all files, otherwise there's no point.
>> > >
>> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
>> > >  wrote:
>> > > > Hello Everyone,
>> > > >
>> > > > For a long time I was annoyed by something in OFBiz: the build system
>> > > > does not fail if data loading fails for some files. I spend hours
>> > > > hunting bugs only to discover that the data simply did not load.
>> > > >
>> > > > Given that I'm working on refactoring the data loading container, I
>> > > > believe this issue should resolved. However, I'm not sure if the
>> > > > community is interested in making such a change.
>> > > >
>> > > > So I list below 3 options to select from:
>> > > >
>> > > > 1- Leave it as is, do not fail the build if some files do not load
>> > > > 2- Continue loading until all files are done and then fail the build
>> > > > 3- Provide a flag e.g. ignore-failure that tells the system whether
>> to
>> > > > fail or not with a default value of "false".
>> > > >
>> > > > My personal preference is for (3)
>> > > >
>> > > > WDYT?
>> > >
>> >
>> >
>> >
>> > --
>> > Coherent Software Australia Pty Ltd
>> > PO Box 2773
>> > Cheltenham Vic 3192
>> > Australia
>> >
>> > Phone: +61 3 9585 6788
>> > Web: http://www.coherentsoftware.com.au/
>> > Email: i...@coherentsoftware.com.au
>> >
>>

Re: [Discussion] Failing the build if data loading fails

I'm good to go with option #3 and continue-on-failure.

Just wanted to mention one thing here; for which type of data we will be
failing build. That means, we have several options seed, ext, demo. Do we
need to discuss these points or we are fine for all type of data. Like demo
data fails only affect a process for that data set only, and for that
failing build is okay or not (as on data load we get logs if any file
didn't load).


Btw, I'm good with the proposal, just sharing a thought in case we should
discuss or may be we can simply ignore if we are good with that.

Thaks!



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:

> > Historically the data loader boolean props are false if ommitted and the
> > code expects that, but you have a point about the double negative. We can
> > instead call it "continue-on-failure" for example.
> >
>
> +1 continue-on-failure with default value false
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
>
>
> >
> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy"  wrote:
> >
> > Hi all,
> >
> > I agree with option 3. I recall in my own work I once needed to add a
> throw
> > where there was none to track down a problem.
> >
> > However ignore-failure leads to a double negative. How about
> > "stop-on-failure", default value true?
> >
> > Cheers
> >
> > Paul Foxworthy
> >
> >
> > On 10 July 2017 at 05:27, Taher Alkhateeb 
> > wrote:
> >
> > > Correction: on item (2) in my post: fail immediately, not after
> > > loading all files, otherwise there's no point.
> > >
> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
> > >  wrote:
> > > > Hello Everyone,
> > > >
> > > > For a long time I was annoyed by something in OFBiz: the build system
> > > > does not fail if data loading fails for some files. I spend hours
> > > > hunting bugs only to discover that the data simply did not load.
> > > >
> > > > Given that I'm working on refactoring the data loading container, I
> > > > believe this issue should resolved. However, I'm not sure if the
> > > > community is interested in making such a change.
> > > >
> > > > So I list below 3 options to select from:
> > > >
> > > > 1- Leave it as is, do not fail the build if some files do not load
> > > > 2- Continue loading until all files are done and then fail the build
> > > > 3- Provide a flag e.g. ignore-failure that tells the system whether
> to
> > > > fail or not with a default value of "false".
> > > >
> > > > My personal preference is for (3)
> > > >
> > > > WDYT?
> > >
> >
> >
> >
> > --
> > Coherent Software Australia Pty Ltd
> > PO Box 2773
> > Cheltenham Vic 3192
> > Australia
> >
> > Phone: +61 3 9585 6788
> > Web: http://www.coherentsoftware.com.au/
> > Email: i...@coherentsoftware.com.au
> >
>

Re: [Discussion] Failing the build if data loading fails

2017-07-10 Thread Deepak Dixit

> Historically the data loader boolean props are false if ommitted and the
> code expects that, but you have a point about the double negative. We can
> instead call it "continue-on-failure" for example.
>

+1 continue-on-failure with default value false

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co



>
> On Jul 10, 2017 3:48 AM, "Paul Foxworthy"  wrote:
>
> Hi all,
>
> I agree with option 3. I recall in my own work I once needed to add a throw
> where there was none to track down a problem.
>
> However ignore-failure leads to a double negative. How about
> "stop-on-failure", default value true?
>
> Cheers
>
> Paul Foxworthy
>
>
> On 10 July 2017 at 05:27, Taher Alkhateeb 
> wrote:
>
> > Correction: on item (2) in my post: fail immediately, not after
> > loading all files, otherwise there's no point.
> >
> > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
> >  wrote:
> > > Hello Everyone,
> > >
> > > For a long time I was annoyed by something in OFBiz: the build system
> > > does not fail if data loading fails for some files. I spend hours
> > > hunting bugs only to discover that the data simply did not load.
> > >
> > > Given that I'm working on refactoring the data loading container, I
> > > believe this issue should resolved. However, I'm not sure if the
> > > community is interested in making such a change.
> > >
> > > So I list below 3 options to select from:
> > >
> > > 1- Leave it as is, do not fail the build if some files do not load
> > > 2- Continue loading until all files are done and then fail the build
> > > 3- Provide a flag e.g. ignore-failure that tells the system whether to
> > > fail or not with a default value of "false".
> > >
> > > My personal preference is for (3)
> > >
> > > WDYT?
> >
>
>
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Australia
>
> Phone: +61 3 9585 6788
> Web: http://www.coherentsoftware.com.au/
> Email: i...@coherentsoftware.com.au
>

Re: [Discussion] Failing the build if data loading fails

2017-07-10 Thread Jacopo Cappellato

On Mon, Jul 10, 2017 at 7:03 AM, Taher Alkhateeb  wrote:

> Historically the data loader boolean props are false if ommitted and the
> code expects that, but you have a point about the double negative. We can
> instead call it "continue-on-failure" for example.


+1

Re: [Discussion] Failing the build if data loading fails

2017-07-10 Thread Paul Foxworthy

On 10 July 2017 at 15:03, Taher Alkhateeb 
wrote:

> Historically the data loader boolean props are false if ommitted and the
> code expects that, but you have a point about the double negative. We can
> instead call it "continue-on-failure" for example.
>

Hi Taher,

I'm happy with that.

Cheers

Paul

-- 
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web: http://www.coherentsoftware.com.au/
Email: i...@coherentsoftware.com.au

Re: [Discussion] Failing the build if data loading fails


Option 3 with with a default value of "false" for "continue-on-failure is fine 
with me

Jacques


Le 10/07/2017 à 07:03, Taher Alkhateeb a écrit :

Historically the data loader boolean props are false if ommitted and the
code expects that, but you have a point about the double negative. We can
instead call it "continue-on-failure" for example.

On Jul 10, 2017 3:48 AM, "Paul Foxworthy"  wrote:

Hi all,

I agree with option 3. I recall in my own work I once needed to add a throw
where there was none to track down a problem.

However ignore-failure leads to a double negative. How about
"stop-on-failure", default value true?

Cheers

Paul Foxworthy


On 10 July 2017 at 05:27, Taher Alkhateeb 
wrote:


Correction: on item (2) in my post: fail immediately, not after
loading all files, otherwise there's no point.

On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
 wrote:

Hello Everyone,

For a long time I was annoyed by something in OFBiz: the build system
does not fail if data loading fails for some files. I spend hours
hunting bugs only to discover that the data simply did not load.

Given that I'm working on refactoring the data loading container, I
believe this issue should resolved. However, I'm not sure if the
community is interested in making such a change.

So I list below 3 options to select from:

1- Leave it as is, do not fail the build if some files do not load
2- Continue loading until all files are done and then fail the build
3- Provide a flag e.g. ignore-failure that tells the system whether to
fail or not with a default value of "false".

My personal preference is for (3)

WDYT?



--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web: http://www.coherentsoftware.com.au/
Email: i...@coherentsoftware.com.au

Re: Document Location