Re: Keep deleteProductionRunRoutingTask?

2017-08-23 Thread Paul Foxworthy
Hi Gil,

Jacques counted 157 services with names starting with "remove" and 538
starting with "delete" . OFBiz is inconsistent here, but "delete" is more
commonly used. Why make it any worse by adding another "remove"?

Thanks

Paul Foxworthy

On 14 August 2017 at 23:50, gil portenseigne 
wrote:

> Hi Jacques,
>
> In my opinion when I read deleteWorkEffort i'm expecting an entity-auto
> service, that will remove my workEffort entry from database.
>
> In this case it's removing the workEffort and all related entity, so i
> propose to rename the service to removeWorkEffortAndRelated.
>
> This service is to be used when i really don't care about related data.
>
> Then we could replace deleteProductionRunRoutingTask with
> removeWorkEffortAndRelated service...
>
> The question remains, should we still define a deleteWorkEffort
> entity-auto service ? I'm not sure that will be useful, but that's not
> costly to have one defined...
>
> Gil
>
>
>
>
> On 11/08/2017 17:21, Jacques Le Roux wrote:
>
>> Hi Nicolas, All,
>>
>> Nicolas: are you speaking about deleteProductionRunRoutingTask
>> (OFBIZ-9568), deleteWorkEffort (OFBIZ-9185) or both ?
>>
>> I think you answered only about deleteWorkEffort and then I agree.
>>
>> I was also reluctant to remove it. But then we need to define what would
>> be it's minimal implementation.
>> Because as Deepak said, when you want to delete a workeffort with
>> relations with other entities (hence FKs); then you need to delete those
>> other entities before.
>> And in some case it can be quite hard (I try to generalise from this
>> case).
>>
>> I wonder if a new simpler service like deleteSimpleWorkeffort would not
>> be appropriate. A simple workEffort would not have any relations with any
>> entities, else the call would be rejected by this new service.
>> Because generalising seems hard, even more when considering all entities,
>> like eg OrderHeader
>> see https://cwiki.apache.org/confluence/display/OFBENDUSER/How+
>> to+delete+tuples+added+to+test+a+setup and also related thread
>> https://s.apache.org/DCiI
>>
>> This time I want to get to some action :D
>>
>> Jacques
>>
>> Le 11/08/2017 à 11:20, Nicolas Malin a écrit :
>>
>>> Hello Jacques,
>>>
>>> It's a good example why I explained that delete is interesting in some
>>> cases.
>>>
>>> We implemented a process with template workeffort where an operator
>>> create a production run from the templating and delete some task that is
>>> not needed before start. In this context, I have no reason to keep these
>>> workeffort on the database.
>>>
>>> I'm in favor to keep these services as simple as possible and in
>>> coherence with the create service with information that the delete service
>>> doesn't manage all foreign key and we need prepare the delete before. For
>>> all other case, expire will own friend :)
>>>
>>> Nicolas
>>>
>>> Le 10/08/2017 à 11:56, Jacques Le Roux a écrit :
>>>
 Hi,

 Please give your opinion on OFBIZ-9568 before I continue on OFBIZ-9185

 Thanks

 Jacques



>>>
>>>
>>
>


-- 
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: +61 3 9585 6788
Web: http://www.coherentsoftware.com.au/
Email: i...@coherentsoftware.com.au


buildbot success in on ofbiz-trunk-framework-plugins

2017-08-23 Thread buildbot
The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/376

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1805965
Blamelist: nmalin

Build succeeded!

Sincerely,
 -The Buildbot





buildbot success in on ofbiz-trunk-framework

2017-08-23 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework 
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/402

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1805965
Blamelist: nmalin

Build succeeded!

Sincerely,
 -The Buildbot





buildbot failure in on ofbiz-trunk-framework

2017-08-23 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-framework while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/401

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1805962
Blamelist: nmalin

BUILD FAILED: failed shell_2

Sincerely,
 -The Buildbot





buildbot success in on ofbiz-trunk-framework-plugins

2017-08-23 Thread buildbot
The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/373

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-plugins-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-plugins/trunk] 1805957
Blamelist: nmalin

Build succeeded!

Sincerely,
 -The Buildbot





Re: Shipment Id goes missing on PO receiving screen once PO is received partially

2017-08-23 Thread Jacques Le Roux

Hi Renuka,

I just read the Jira and your summary below. I totally agree with your summary. 
Did you already investigate a way to code it?

Thanks

Jacques


Le 23/08/2017 à 17:07, Renuka Srishti a écrit :

Hello Devs,

I think my question is not clear. So here are the more details:
Current flow to Receive a PO:
1. Facility manager needs to go to the order view screen.
2. Create shipment from order view screen.
3. Now come back to the facility component and then Recieve PO here.

IMO, no need to go to the order view screen. When we Receive PO from
facility component, the shipment should be created internally.

Thanks
Renuka Srishti

On Sun, Aug 20, 2017 at 5:54 PM, Renuka Srishti 
wrote:


Hello Dev,

This is related to OFBIZ-7718
 Here is the more
discussion  about this
ticket. To fix the OFBIZ-7718
 problem, shipment Id
should be created before receiving as mentioned in the comment.
There are following ways to create shipment before receiving:
1. We can first create shipment by click on *New Shipment For Ship Group*
button in orderview

screen and then go to Receive Inventory

screen for further process.
2. We can call internally create shipment on Receiving PO process as the
shipment is mandatory for further process.
Which option is right?


Thanks
Renuka Srishti





Re: svn commit: r1805548 - in /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts: datafile/ViewDataFile.groovy service/AvailableServices.groovy

2017-08-23 Thread Jacques Le Roux

Le 23/08/2017 à 18:29, Jacques Le Roux a écrit :

Thanks again Renuka,

I should have taken care of it more the 1st time. It was not a typo but my S/R 
regexp which was wrong :/

Forgot: fixed at r1805936


Jacques


Le 23/08/2017 à 17:19, Renuka Srishti a écrit :

In this commit, there is two typo mistake in ViewDataFile.groovy. Extra
closing bracket after dataFileSave and entityXmlFileSave which leads to
screen 
broken.

Thanks
Renuka Srishti

On Sun, Aug 20, 2017 at 5:41 PM,  wrote:


Author: jleroux
Date: Sun Aug 20 12:11:39 2017
New Revision: 1805548

URL: http://svn.apache.org/viewvc?rev=1805548&view=rev
Log:
No functional change,

In 3 places we use uiLabelMap.get("x") instead of uiLabelMap.x
which
does essentially the same when there is no default parameter passed to
get()
http://mrhaki.blogspot.fr/2009/11/groovy-goodness-get-
value-from-map-or.html

Modified:
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/
ViewDataFile.groovy
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/
AvailableServices.groovy

Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
groovyScripts/datafile/ViewDataFile.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/webtools/groovyScripts/datafile/ViewDataFile.groovy?rev=
1805548&r1=1805547&r2=1805548&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
Sun Aug 20 12:11:39 2017
@@ -83,7 +83,7 @@ if (dataFile) {
  if (dataFile && dataFileSave) {
  try {
  dataFile.writeDataFile(dataFileSave)
- messages.add(uiLabelMap.get("WebtoolsDataFileSavedTo") +
dataFileSave)
+    messages.add(uiLabelMap.WebtoolsDataFileSavedTo) + dataFileSave)
  }
  catch (Exception e) {
  messages.add(e.getMessage())
@@ -94,7 +94,7 @@ if (dataFile && entityXmlFileSave) {
  try {
  //dataFile.writeDataFile(entityXmlFileSave)
DataFile2EntityXml.writeToEntityXml(entityXmlFileSave, dataFile)
- messages.add(uiLabelMap.get("WebtoolsDataEntityFileSavedTo") +
entityXmlFileSave)
+ messages.add(uiLabelMap.WebtoolsDataEntityFileSavedTo) +
entityXmlFileSave)
  }
  catch (Exception e) {
  messages.add(e.getMessage())

Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
groovyScripts/service/AvailableServices.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/webtools/groovyScripts/service/AvailableServices.groovy?rev=
1805548&r1=1805547&r2=1805548&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
Sun Aug 20 12:11:39 2017
@@ -450,7 +450,7 @@ if (selectedService) {
  outParamsList.add(curOutParam)
  }
  outParamMap = [:]
-    outParamMap.title = uiLabelMap.get("WebtoolsOutParameters")
+    outParamMap.title = uiLabelMap.WebtoolsOutParameters)
  outParamMap.paramList = outParamsList
  allParamsList.add(outParamMap)











Re: svn commit: r1805548 - in /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts: datafile/ViewDataFile.groovy service/AvailableServices.groovy

2017-08-23 Thread Jacques Le Roux

Thanks again Renuka,

I should have taken care of it more the 1st time. It was not a typo but my S/R 
regexp which was wrong :/

Jacques


Le 23/08/2017 à 17:19, Renuka Srishti a écrit :

In this commit, there is two typo mistake in ViewDataFile.groovy. Extra
closing bracket after dataFileSave and entityXmlFileSave which leads to
screen 
broken.

Thanks
Renuka Srishti

On Sun, Aug 20, 2017 at 5:41 PM,  wrote:


Author: jleroux
Date: Sun Aug 20 12:11:39 2017
New Revision: 1805548

URL: http://svn.apache.org/viewvc?rev=1805548&view=rev
Log:
No functional change,

In 3 places we use uiLabelMap.get("x") instead of uiLabelMap.x
which
does essentially the same when there is no default parameter passed to
get()
http://mrhaki.blogspot.fr/2009/11/groovy-goodness-get-
value-from-map-or.html

Modified:
 ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/
ViewDataFile.groovy
 ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/
AvailableServices.groovy

Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
groovyScripts/datafile/ViewDataFile.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/webtools/groovyScripts/datafile/ViewDataFile.groovy?rev=
1805548&r1=1805547&r2=1805548&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
Sun Aug 20 12:11:39 2017
@@ -83,7 +83,7 @@ if (dataFile) {
  if (dataFile && dataFileSave) {
  try {
  dataFile.writeDataFile(dataFileSave)
-messages.add(uiLabelMap.get("WebtoolsDataFileSavedTo") +
dataFileSave)
+messages.add(uiLabelMap.WebtoolsDataFileSavedTo) + dataFileSave)
  }
  catch (Exception e) {
  messages.add(e.getMessage())
@@ -94,7 +94,7 @@ if (dataFile && entityXmlFileSave) {
  try {
  //dataFile.writeDataFile(entityXmlFileSave)
  DataFile2EntityXml.writeToEntityXml(entityXmlFileSave, dataFile)
-messages.add(uiLabelMap.get("WebtoolsDataEntityFileSavedTo") +
entityXmlFileSave)
+messages.add(uiLabelMap.WebtoolsDataEntityFileSavedTo) +
entityXmlFileSave)
  }
  catch (Exception e) {
  messages.add(e.getMessage())

Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
groovyScripts/service/AvailableServices.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/webtools/groovyScripts/service/AvailableServices.groovy?rev=
1805548&r1=1805547&r2=1805548&view=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
(original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
Sun Aug 20 12:11:39 2017
@@ -450,7 +450,7 @@ if (selectedService) {
  outParamsList.add(curOutParam)
  }
  outParamMap = [:]
-outParamMap.title = uiLabelMap.get("WebtoolsOutParameters")
+outParamMap.title = uiLabelMap.WebtoolsOutParameters)
  outParamMap.paramList = outParamsList
  allParamsList.add(outParamMap)








Re: svn commit: r1805548 - in /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts: datafile/ViewDataFile.groovy service/AvailableServices.groovy

2017-08-23 Thread Renuka Srishti
In this commit, there is two typo mistake in ViewDataFile.groovy. Extra
closing bracket after dataFileSave and entityXmlFileSave which leads to
screen 
broken.

Thanks
Renuka Srishti

On Sun, Aug 20, 2017 at 5:41 PM,  wrote:

> Author: jleroux
> Date: Sun Aug 20 12:11:39 2017
> New Revision: 1805548
>
> URL: http://svn.apache.org/viewvc?rev=1805548&view=rev
> Log:
> No functional change,
>
> In 3 places we use uiLabelMap.get("x") instead of uiLabelMap.x
> which
> does essentially the same when there is no default parameter passed to
> get()
> http://mrhaki.blogspot.fr/2009/11/groovy-goodness-get-
> value-from-map-or.html
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/
> ViewDataFile.groovy
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/
> AvailableServices.groovy
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
> groovyScripts/datafile/ViewDataFile.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/webtools/groovyScripts/datafile/ViewDataFile.groovy?rev=
> 1805548&r1=1805547&r2=1805548&view=diff
> 
> ==
> --- 
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
> (original)
> +++ 
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/datafile/ViewDataFile.groovy
> Sun Aug 20 12:11:39 2017
> @@ -83,7 +83,7 @@ if (dataFile) {
>  if (dataFile && dataFileSave) {
>  try {
>  dataFile.writeDataFile(dataFileSave)
> -messages.add(uiLabelMap.get("WebtoolsDataFileSavedTo") +
> dataFileSave)
> +messages.add(uiLabelMap.WebtoolsDataFileSavedTo) + dataFileSave)
>  }
>  catch (Exception e) {
>  messages.add(e.getMessage())
> @@ -94,7 +94,7 @@ if (dataFile && entityXmlFileSave) {
>  try {
>  //dataFile.writeDataFile(entityXmlFileSave)
>  DataFile2EntityXml.writeToEntityXml(entityXmlFileSave, dataFile)
> -messages.add(uiLabelMap.get("WebtoolsDataEntityFileSavedTo") +
> entityXmlFileSave)
> +messages.add(uiLabelMap.WebtoolsDataEntityFileSavedTo) +
> entityXmlFileSave)
>  }
>  catch (Exception e) {
>  messages.add(e.getMessage())
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/
> groovyScripts/service/AvailableServices.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/webtools/groovyScripts/service/AvailableServices.groovy?rev=
> 1805548&r1=1805547&r2=1805548&view=diff
> 
> ==
> --- 
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
> (original)
> +++ 
> ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/service/AvailableServices.groovy
> Sun Aug 20 12:11:39 2017
> @@ -450,7 +450,7 @@ if (selectedService) {
>  outParamsList.add(curOutParam)
>  }
>  outParamMap = [:]
> -outParamMap.title = uiLabelMap.get("WebtoolsOutParameters")
> +outParamMap.title = uiLabelMap.WebtoolsOutParameters)
>  outParamMap.paramList = outParamsList
>  allParamsList.add(outParamMap)
>
>
>
>


Re: Shipment Id goes missing on PO receiving screen once PO is received partially

2017-08-23 Thread Renuka Srishti
Hello Devs,

I think my question is not clear. So here are the more details:
Current flow to Receive a PO:
1. Facility manager needs to go to the order view screen.
2. Create shipment from order view screen.
3. Now come back to the facility component and then Recieve PO here.

IMO, no need to go to the order view screen. When we Receive PO from
facility component, the shipment should be created internally.

Thanks
Renuka Srishti

On Sun, Aug 20, 2017 at 5:54 PM, Renuka Srishti 
wrote:

> Hello Dev,
>
> This is related to OFBIZ-7718
>  Here is the more
> discussion  about this
> ticket. To fix the OFBIZ-7718
>  problem, shipment Id
> should be created before receiving as mentioned in the comment.
> There are following ways to create shipment before receiving:
> 1. We can first create shipment by click on *New Shipment For Ship Group*
> button in orderview
> 
> screen and then go to Receive Inventory
> 
> screen for further process.
> 2. We can call internally create shipment on Receiving PO process as the
> shipment is mandatory for further process.
> Which option is right?
>
>
> Thanks
> Renuka Srishti
>


Re: svn commit: r1805548 - in /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts: datafile/ViewDataFile.groovy service/AvailableServices.groovy

2017-08-23 Thread Renuka Srishti
Thanks Jacques

On Tue, Aug 22, 2017 at 8:35 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Renuka,
>
> Typo fixed at r1805775
>
> Jacques
>
>
> Le 22/08/2017 à 16:26, Renuka Srishti a écrit :
>
>> Mail is not showing the code in the correct way:
>> So the correct line of code is outParamMap.title =
>> uiLabelMap.WebtoolsOutParameters
>>
>> Thanks
>> Renuka Srishti
>>
>> On Tue, Aug 22, 2017 at 7:48 PM, Renuka Srishti <
>> renuka.srisht...@gmail.com>
>> wrote:
>>
>> In this commit 
>>> *outParamMap.title = uiLabelMap.**WebtoolsOutParameters) *, there is a
>>> typo mistake of a closing bracket which is leading for screen
>>> 
>>> broken.
>>>
>>> It should be *outParamMap.title = uiLabelMap.*
>>>
>>> *WebtoolsOutParameters*
>>> Thanks
>>> Renuka Srishti
>>>
>>> On Sun, Aug 20, 2017 at 5:41 PM,  wrote:
>>>
>>> Author: jleroux
 Date: Sun Aug 20 12:11:39 2017
 New Revision: 1805548

 URL: http://svn.apache.org/viewvc?rev=1805548&view=rev
 Log:
 No functional change,

 In 3 places we use uiLabelMap.get("x") instead of uiLabelMap.x
 which
 does essentially the same when there is no default parameter passed to
 get()
 http://mrhaki.blogspot.fr/2009/11/groovy-goodness-get-value-
 from-map-or.html

 Modified:
  ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /datafile/ViewDataFile.groovy
  ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /service/AvailableServices.groovy

 Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /datafile/ViewDataFile.groovy
 URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/fra
 mework/webtools/groovyScripts/datafile/ViewDataFile.groovy?
 rev=1805548&r1=1805547&r2=1805548&view=diff
 
 ==
 --- ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /datafile/ViewDataFile.groovy
 (original)
 +++ ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /datafile/ViewDataFile.groovy
 Sun Aug 20 12:11:39 2017
 @@ -83,7 +83,7 @@ if (dataFile) {
   if (dataFile && dataFileSave) {
   try {
   dataFile.writeDataFile(dataFileSave)
 -messages.add(uiLabelMap.get("WebtoolsDataFileSavedTo") +
 dataFileSave)
 +messages.add(uiLabelMap.WebtoolsDataFileSavedTo) +
 dataFileSave)
   }
   catch (Exception e) {
   messages.add(e.getMessage())
 @@ -94,7 +94,7 @@ if (dataFile && entityXmlFileSave) {
   try {
   //dataFile.writeDataFile(entityXmlFileSave)
   DataFile2EntityXml.writeToEntityXml(entityXmlFileSave,
 dataFile)
 -messages.add(uiLabelMap.get("WebtoolsDataEntityFileSavedTo") +
 entityXmlFileSave)
 +messages.add(uiLabelMap.WebtoolsDataEntityFileSavedTo) +
 entityXmlFileSave)
   }
   catch (Exception e) {
   messages.add(e.getMessage())

 Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /service/AvailableServices.groovy
 URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/fra
 mework/webtools/groovyScripts/service/AvailableServices.
 groovy?rev=1805548&r1=1805547&r2=1805548&view=diff
 
 ==
 --- ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /service/AvailableServices.groovy (original)
 +++ ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts
 /service/AvailableServices.groovy Sun Aug 20 12:11:39 2017
 @@ -450,7 +450,7 @@ if (selectedService) {
   outParamsList.add(curOutParam)
   }
   outParamMap = [:]
 -outParamMap.title = uiLabelMap.get("WebtoolsOutParameters")
 +outParamMap.title = uiLabelMap.WebtoolsOutParameters)
   outParamMap.paramList = outParamsList
   allParamsList.add(outParamMap)





>


Re: Suggestions Request: OFBiz Business Process Reference Book/Guide

2017-08-23 Thread Swapnil Mane
Big +1 for the idea, great initiative.


- Thanks & Regards,
Swapnil M Mane

On Sat, Aug 19, 2017 at 9:54 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Hello Devs,
>
> This is something where I wanted to request your suggestions. I am planning
> to rename and restructure the documentation on OFBiz Wiki page- Business
> Process Stories and Use Cases Library
> .
>
> The idea will still be the same i.e. to help OFBiz Evaluators. All the
> people who are more interested in written content to prove the
> implementation. Provide a robust process documentation that supports
> decision-makers to choose OFBiz over any other proprietary software. To
> help them take this content to a wider audience who take the decision for
> choosing a business automation software.
>
> I am planning to rename this page to: "*OFBiz Business Process Reference
> Book*".
> Then review and overhaul the overall content on this page to clarify the
> purpose of all the documents in this tree(Directory).
>
> Now restructure the child pages with new names with business significance
> i.e. the process names that industry people refer e.g. CRM, Product
> Information Management(PIM), Procurement, Fulfilment etc.
>
> Now every module page will have two child pages so the structure would be
> changed like this-
>
> - Catalog Management
> -- Product Information Management (PIM)
> --- PIM Process Overview (Content: Process Overview, Business Purpose,
> Level-1,2, and 3 Activity Diagrams as applicable to demonstrate the process
> flow)
> --- PIM User Stories, Use Cases and Test Cases (Content: Review, refine and
> add missing user stories, use cases, and test cases)
> -- Merchandising
> --- Merchandising Process Overview (Content: Process Overview, Business
> Purpose, Level-1,2, and 3 Activity Diagrams as applicable to demonstrate
> the process flow)
> --- Merchandising User Stories, Use Cases and Test Cases
> -- Store Management
> --- Store Management Process Overview
> --- Store Management User Stories, Use Cases and Test Cases
> ...
> ...
> ...
>
> I am planning to create a JIRA ticket with these details and would like to
> start from there with sub tasks. This way we'll be able to collaborate in
> this effort.
>
> How does that all sound to you? Please let me know your thoughts, feedback,
> and improvement suggestions for the mentioned effort.
>
> Kind regards,
> Pranay Pandey
>


buildbot success in on ofbiz-trunk-framework-plugins

2017-08-23 Thread buildbot
The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/369

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1805892
Blamelist: nmalin

Build succeeded!

Sincerely,
 -The Buildbot





Re: Label from flexibleStringExpander with UEL

2017-08-23 Thread Nicolas Malin
I create the issue OFBIZ-9617 and commit it on revision 1805888 with 
util prefix.


If we found a better name than label I will update the code.

Nicolas

Le 22/08/2017 à 17:59, Nicolas Malin a écrit :

Le 22/08/2017 à 17:21, Jacques Le Roux a écrit :


I search to call a labelization from a flexibleStringExpander 
without uiLableMap in my context.


Instead call like that ${groovy: 
org.apache.ofbiz.base.UtilProperty.getMessage(myRessource, myLabel, 
locale)}, I implemented an uel function : ${str:label(myRessource, 
myLable, locale)} ...
BTW, is this new UEL for forms?  Because remember we have decided to 
deprecate Minilang where so far ${str: and ${util: UELs are mostly used.


Jacques

Not really, I just want call it from the theme definition

${str:label('CommonEntityLabels', 
'VisualTheme.description.BLUELIGHT', locale)}



I didn't think about minilang, but I always in my mind to improve de 
groovyDSL like previously


Nicolas