Re: Issue when debugging with Eclipse

2019-08-13 Thread Mathieu Lirzin 
Hello,

Jacques Le Roux  writes:

> Yes it was much faster before (but before what???), as fast as running it in 
> console.

Seems like a good scenario for a ‘git bisect’. ;-)

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Re: Issue when debugging with Eclipse

2019-08-13 Thread Girish Vasmatkar 
It is pretty much the same case with me as well. Not just this, I observe
lag during DB operations as well. Did it use to be fast for you earlier? I
would say first request always takes more time than the subsequent requests.

My eclipse version -

Version: Photon Release (4.8.0)

Build id: 20180619-1200

Best,
Girish

On Tue, Aug 13, 2019 at 8:13 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> Since sometimes now (few weeks?) I get an issue when debugging with
> Eclipse (version 2018-12). I have to wait a long time before passing these
> lines
>
> 2019-08-13 15:00:05,186 |main |ServiceContainer  |I| Created
> new dispatcher: scrum
> 2019-08-13 15:00:05,187 |main |ControlServlet|I| Loading
> webapp [scrum], located at C:\projectsASF\ofbiz\plugins\scrum\webapp\scrum\
> 2019-08-13 15:00:05,221 |main |ConfigXMLReader   |I|
> controller loaded: 0.003s, 207 requests, 81 views in
>
> file:/C:/projectsASF/ofbiz/plugins/scrum/webapp/scrum/WEB-INF/controller.xml
>
> I tried it's not related with scrum component. If I remove it, the same
> happens with order component.
>
> The timeout is few minutes and quite annoying. Nobody has an idea?
>
> Thanks
>
> Jacques
>
>

Issue when debugging with Eclipse

2019-08-13 Thread Jacques Le Roux 

Hi,

Since sometimes now (few weeks?) I get an issue when debugging with Eclipse 
(version 2018-12). I have to wait a long time before passing these lines

2019-08-13 15:00:05,186 |main |ServiceContainer  |I| Created new 
dispatcher: scrum
2019-08-13 15:00:05,187 |main |ControlServlet    |I| Loading webapp 
[scrum], located at C:\projectsASF\ofbiz\plugins\scrum\webapp\scrum\
2019-08-13 15:00:05,221 |main |ConfigXMLReader   |I| controller loaded: 0.003s, 207 requests, 81 views in 
file:/C:/projectsASF/ofbiz/plugins/scrum/webapp/scrum/WEB-INF/controller.xml


I tried it's not related with scrum component. If I remove it, the same happens 
with order component.

The timeout is few minutes and quite annoying. Nobody has an idea?

Thanks

Jacques

Should we remove modifiers when default (no modifier) is the same?

2019-08-13 Thread Jacques Le Roux 

Hi,

I was looking at the work done by Pradhan Yash Sharma for OFBIZ-10477 "Parent ticket 
for reducing scope of variables and methods"

This work is related to 
https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html

I only applied the patch from OFBIZ-10478 "Reducing scope of variables in 
org.apache.ofbiz.base package"

Some changes are welcome, to improve security, like replacing public or 
protected by private when possible

I think removing public modifiers is also a good thing

What do you think?

Jacques