date:20200228


Le 28/02/2020 à 17:49, ASF subversion and git services (Jira) a écrit :

use kelvin syntax


Hi Nicolas, Gil,

Could you explain why you refer to Kelvin Syntax?

TIA

Jacques

[GitHub] [ofbiz-site] JacquesLeRoux merged pull request #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-28 Thread GitBox

JacquesLeRoux merged pull request #1: Improved: widget-theme.xsd typos 
(OFBIZ-11421)
URL: https://github.com/apache/ofbiz-site/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Checkstyle error: Files does not end with newline


Daniel,

This: https://ci.apache.org/projects/ofbiz/logs/

Jacques

Le 28/02/2020 à 14:41, Daniel Watford a écrit :

Hi Jacques,

If I follow the link to the ofbiz builds in Buildbot (
https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of
recent builds.

How do I navigate from the list of recent builds to view the test reports -
e.g. view build/reports/checkstyle/test.html for
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1202 ?

Thanks,

Dan.

On Fri, 28 Feb 2020 at 13:28, Jacques Le Roux 
wrote:


Thanks Daniel,

It works in Buildbot, so it's OK with me ;)

https://ci.apache.org/builders/ofbizTrunkFramework

Cheers

Jacques

Le 28/02/2020 à 11:24, Daniel Watford a écrit :

Hi Jacques,

I haven't been able to come up with an explanation for what you're

seeing,

so through I'd post some of my configuration and results to see if we can
spot anything odd.

Building on a Windows 10 host. Executing builds from Git Bash running in
Windows terminal:

$ git log -1
commit 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27 (HEAD -> trunk,
upstream/trunk, origin/trunk, origin/HEAD)
Merge: cfad407c48 0ece441228
Author: Jacques Le Roux 
Date: Fri Feb 28 09:44:28 2020 +0100

Merge pull request #35 from danwatford/ofbiz-11418-documentation

OFBIZ-11418: Fixed line lengths in ModelFormFieldTest to adhere to coding
standards

$ git status
On branch trunk
Your branch is up to date with 'origin/trunk'.

nothing to commit, working tree clean


$ ./gradlew clean


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :clean

BUILD SUCCESSFUL in 1s
1 actionable task: 1 executed

Windows Terminal
$ ./gradlew check


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :compileJava
Task :compileGroovy
Task :processResources
Task :classes
Task :checkstyleMain

Checkstyle rule violations were found. See the report at:


file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html

Checkstyle files with violations: 1055
Checkstyle violations by severity: [error:35504]



Task :compileTestJava

C:\dev\clients\ActiveTransport\activate-docker-ofbiz-framework\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\model\ModelFormFieldTest.java:128:

warning: [deprecation] getTargetParameterList() in
LookupField has been deprecated
assertThat(lookupField.getTargetParameterList(),
Matchers.contains("${prefix}TargetParam", "${key1}"));
^
1 warning


Task :compileTestGroovy
Task :processTestResources
Task :testClasses
Task :checkstyleTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.

Checkstyle rule violations were found. See the report at:

file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/test.html

Checkstyle files with violations: 39
Checkstyle violations by severity: [error:39]


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output. Run with --scan to get full

insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 30s
8 actionable tasks: 8 executed



If I then apply the change to config/checkstyle/checkstyle.xml:
Index: config/checkstyle/checkstyle.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===
--- config/checkstyle/checkstyle.xml (revision
66aa76d7f7fc368b5f039d0e3181edaaf85d9b27)
+++ config/checkstyle/checkstyle.xml (date 1582884183549)
@@ -30,7 +30,9 @@
   

   
-
+
+
+
   
   
  

And re-run checkstyle:
$ ./gradlew check


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :compileJava UP-TO-DATE
Task :compileGroovy UP-TO-DATE
Task :processResources UP-TO-DATE
Task :classes UP-TO-DATE
Task :checkstyleMain

Checkstyle rule violations were found. See the report at:


file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html

Checkstyle files with violations: 956
Checkstyle violations by severity: [error:34464]



Task :compileTestJava UP-TO-DATE
Task :compileTestGroovy UP-TO-DATE
Task :processTestResources UP-TO-DATE
Task :testClasses UP-TO-DATE
Task :checkstyleTest
Task :test
Task :check

BUILD SUCCESSFUL in 40s
9 actionable tasks: 3 executed, 6 up-to-date



This time all the 39 test file violations have been cleared.

Just in case there are some LF / CRLF issues remaining in your work area
you could run something like the following (assuming you have cygwin /

msys

/ git bash)
$ find . -path ./build -prune -o -not -type d -exec file "{}" ";" | grep
CRLF



My git config is as

Re: Solr/Lucene

2020-02-28 Thread Rishi Solanki

Jacques/Pierre,
Thanks for your response and information. My point is if indexing is not in
use on any page, and solr does the same using Lucene. I google it Solr vs
Lucene, and most of the articles in favor of Solr. So just thought to put
this in front of community if ignored or postpone decision due to some
reasons.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
cell: +91-98932-87847
LinkedIn 


On Fri, Feb 28, 2020 at 7:52 PM Pierre Smits  wrote:

> IMO, indexing (lucent/solr style) should be a lower level service given the
> dependencies in content and product. But maybe it already is?
>
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz  since
> 2008 (without privileges)
>
> *Apache Trafodion , Vice President*
> *Apache Directory , PMC Member*
> Apache Incubator , committer
> Apache Steve , committer
>
>
> On Fri, Feb 28, 2020 at 2:21 PM Pierre Smits 
> wrote:
>
> > Rich, Jacques,
> > Thanks for bringing this to the attention of the community. I guess the
> > reason is that in past discussions no agreement could be established on
> > what to do with it. Some fear it is lost forever when removed.
> >
> > re:If memory serves, Lucene is still used while indexing products and
> > content.
> > You're correct. But it is also true that the framework code works with
> the
> > plugins.
> >
> > Met vriendelijke groet,
> >
> > Pierre Smits
> > *Proud* *contributor** of* Apache OFBiz 
> since
> > 2008 (without privileges)
> >
> > *Apache Trafodion , Vice President*
> > *Apache Directory , PMC Member*
> > Apache Incubator , committer
> > Apache Steve , committer
> >
> >
> > On Fri, Feb 28, 2020 at 1:48 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi Rishi,
> >>
> >> If memory serves, Lucene is still used while indexing products and
> >> content.
> >>
> >> Jacques
> >>
> >> Le 28/02/2020 à 12:37, Rishi Solanki a écrit :
> >> > Dear All,
> >> > I was checking all plugins developed with OFBiz. I  see both Solr and
> >> > Lucene are there, may I know why we are keeping Lucene within plugins.
> >> >
> >> > As a framework we already have the Solr which resolves many functional
> >> > aspects on the top of Lucene library. Do we have any good reason to
> keep
> >> > the Lucene with us, as far as I remember we sample
> integration/indexing
> >> is
> >> > there, but not in use anywhere.
> >> >
> >> > May be we can remove Lucene if it is not in use as we are already
> using
> >> > Solr. Or may be we have good reason to keep both, one reason I could
> >> think
> >> > of is backward compatibility. Please share your thoughts on this.
> >> >
> >> > Purpose of this email is not to remove the Lucene as plugin, but
> wanted
> >> to
> >> > clarify why we are keeping it.
> >> >
> >> > Best Regards,
> >> > --
> >> > Rishi Solanki
> >> > *CTO, Mindpath Technology*
> >> > cell: +91-98932-87847
> >> > LinkedIn 
> >>
> >>
>

Re: Solr/Lucene

IMO, indexing (lucent/solr style) should be a lower level service given the
dependencies in content and product. But maybe it already is?


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz  since
2008 (without privileges)

*Apache Trafodion , Vice President*
*Apache Directory , PMC Member*
Apache Incubator , committer
Apache Steve , committer


On Fri, Feb 28, 2020 at 2:21 PM Pierre Smits  wrote:

> Rich, Jacques,
> Thanks for bringing this to the attention of the community. I guess the
> reason is that in past discussions no agreement could be established on
> what to do with it. Some fear it is lost forever when removed.
>
> re:If memory serves, Lucene is still used while indexing products and
> content.
> You're correct. But it is also true that the framework code works with the
> plugins.
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz  since
> 2008 (without privileges)
>
> *Apache Trafodion , Vice President*
> *Apache Directory , PMC Member*
> Apache Incubator , committer
> Apache Steve , committer
>
>
> On Fri, Feb 28, 2020 at 1:48 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Hi Rishi,
>>
>> If memory serves, Lucene is still used while indexing products and
>> content.
>>
>> Jacques
>>
>> Le 28/02/2020 à 12:37, Rishi Solanki a écrit :
>> > Dear All,
>> > I was checking all plugins developed with OFBiz. I  see both Solr and
>> > Lucene are there, may I know why we are keeping Lucene within plugins.
>> >
>> > As a framework we already have the Solr which resolves many functional
>> > aspects on the top of Lucene library. Do we have any good reason to keep
>> > the Lucene with us, as far as I remember we sample integration/indexing
>> is
>> > there, but not in use anywhere.
>> >
>> > May be we can remove Lucene if it is not in use as we are already using
>> > Solr. Or may be we have good reason to keep both, one reason I could
>> think
>> > of is backward compatibility. Please share your thoughts on this.
>> >
>> > Purpose of this email is not to remove the Lucene as plugin, but wanted
>> to
>> > clarify why we are keeping it.
>> >
>> > Best Regards,
>> > --
>> > Rishi Solanki
>> > *CTO, Mindpath Technology*
>> > cell: +91-98932-87847
>> > LinkedIn 
>>
>>

Re: Checkstyle error: Files does not end with newline

Hi Jacques,

If I follow the link to the ofbiz builds in Buildbot (
https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of
recent builds.

How do I navigate from the list of recent builds to view the test reports -
e.g. view build/reports/checkstyle/test.html for
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1202 ?

Thanks,

Dan.

On Fri, 28 Feb 2020 at 13:28, Jacques Le Roux 
wrote:

> Thanks Daniel,
>
> It works in Buildbot, so it's OK with me ;)
>
> https://ci.apache.org/builders/ofbizTrunkFramework
>
> Cheers
>
> Jacques
>
> Le 28/02/2020 à 11:24, Daniel Watford a écrit :
> > Hi Jacques,
> >
> > I haven't been able to come up with an explanation for what you're
> seeing,
> > so through I'd post some of my configuration and results to see if we can
> > spot anything odd.
> >
> > Building on a Windows 10 host. Executing builds from Git Bash running in
> > Windows terminal:
> >
> > $ git log -1
> > commit 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27 (HEAD -> trunk,
> > upstream/trunk, origin/trunk, origin/HEAD)
> > Merge: cfad407c48 0ece441228
> > Author: Jacques Le Roux 
> > Date: Fri Feb 28 09:44:28 2020 +0100
> >
> > Merge pull request #35 from danwatford/ofbiz-11418-documentation
> >
> > OFBIZ-11418: Fixed line lengths in ModelFormFieldTest to adhere to coding
> > standards
> >
> > $ git status
> > On branch trunk
> > Your branch is up to date with 'origin/trunk'.
> >
> > nothing to commit, working tree clean
> >
> >
> > $ ./gradlew clean
> >
> >> Configure project :
> > You are using one or more deprecated Asciidoctor task or plugins. To help
> > with migration run with --warnings=all
> >
> >> Task :clean
> > BUILD SUCCESSFUL in 1s
> > 1 actionable task: 1 executed
> >
> > Windows Terminal
> > $ ./gradlew check
> >
> >> Configure project :
> > You are using one or more deprecated Asciidoctor task or plugins. To help
> > with migration run with --warnings=all
> >
> >> Task :compileJava
> >> Task :compileGroovy
> >> Task :processResources
> >> Task :classes
> >> Task :checkstyleMain
> > Checkstyle rule violations were found. See the report at:
> >
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
> > Checkstyle files with violations: 1055
> > Checkstyle violations by severity: [error:35504]
> >
> >
> >> Task :compileTestJava
> >
> C:\dev\clients\ActiveTransport\activate-docker-ofbiz-framework\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\model\ModelFormFieldTest.java:128:
> > warning: [deprecation] getTargetParameterList() in
> > LookupField has been deprecated
> > assertThat(lookupField.getTargetParameterList(),
> > Matchers.contains("${prefix}TargetParam", "${key1}"));
> > ^
> > 1 warning
> >
> >> Task :compileTestGroovy
> >> Task :processTestResources
> >> Task :testClasses
> >> Task :checkstyleTest FAILED
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':checkstyleTest'.
> >> Checkstyle rule violations were found. See the report at:
> >
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/test.html
> > Checkstyle files with violations: 39
> > Checkstyle violations by severity: [error:39]
> >
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or
> > --debug option to get more log output. Run with --scan to get full
> insights.
> >
> > * Get more help at https://help.gradle.org
> >
> > BUILD FAILED in 30s
> > 8 actionable tasks: 8 executed
> >
> >
> >
> > If I then apply the change to config/checkstyle/checkstyle.xml:
> > Index: config/checkstyle/checkstyle.xml
> > IDEA additional info:
> > Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> > <+>UTF-8
> > ===
> > --- config/checkstyle/checkstyle.xml (revision
> > 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27)
> > +++ config/checkstyle/checkstyle.xml (date 1582884183549)
> > @@ -30,7 +30,9 @@
> >   
> >
> >   
> > -
> > +
> > +
> > +
> >   
> >   
> >  
> >
> > And re-run checkstyle:
> > $ ./gradlew check
> >
> >> Configure project :
> > You are using one or more deprecated Asciidoctor task or plugins. To help
> > with migration run with --warnings=all
> >
> >> Task :compileJava UP-TO-DATE
> >> Task :compileGroovy UP-TO-DATE
> >> Task :processResources UP-TO-DATE
> >> Task :classes UP-TO-DATE
> >> Task :checkstyleMain
> > Checkstyle rule violations were found. See the report at:
> >
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
> > Checkstyle files with violations: 956
> > Checkstyle violations by severity: [error:34464]
> >
> >
> >> Task :compileTestJava UP-TO-DATE
> >> Task :compileTestGroovy UP-TO-DATE
> >> Task :processTestResources UP-TO-DATE
> >> Task :testClasses UP-TO-DATE
> >> Task :checkstyleTest
> >> Task :test
>

Re: Checkstyle error: Files does not end with newline


Thanks Daniel,

It works in Buildbot, so it's OK with me ;)

https://ci.apache.org/builders/ofbizTrunkFramework

Cheers

Jacques

Le 28/02/2020 à 11:24, Daniel Watford a écrit :

Hi Jacques,

I haven't been able to come up with an explanation for what you're seeing,
so through I'd post some of my configuration and results to see if we can
spot anything odd.

Building on a Windows 10 host. Executing builds from Git Bash running in
Windows terminal:

$ git log -1
commit 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27 (HEAD -> trunk,
upstream/trunk, origin/trunk, origin/HEAD)
Merge: cfad407c48 0ece441228
Author: Jacques Le Roux 
Date: Fri Feb 28 09:44:28 2020 +0100

Merge pull request #35 from danwatford/ofbiz-11418-documentation

OFBIZ-11418: Fixed line lengths in ModelFormFieldTest to adhere to coding
standards

$ git status
On branch trunk
Your branch is up to date with 'origin/trunk'.

nothing to commit, working tree clean


$ ./gradlew clean


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :clean

BUILD SUCCESSFUL in 1s
1 actionable task: 1 executed

Windows Terminal
$ ./gradlew check


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :compileJava
Task :compileGroovy
Task :processResources
Task :classes
Task :checkstyleMain

Checkstyle rule violations were found. See the report at:
file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
Checkstyle files with violations: 1055
Checkstyle violations by severity: [error:35504]



Task :compileTestJava

C:\dev\clients\ActiveTransport\activate-docker-ofbiz-framework\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\model\ModelFormFieldTest.java:128:
warning: [deprecation] getTargetParameterList() in
LookupField has been deprecated
assertThat(lookupField.getTargetParameterList(),
Matchers.contains("${prefix}TargetParam", "${key1}"));
^
1 warning


Task :compileTestGroovy
Task :processTestResources
Task :testClasses
Task :checkstyleTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.

Checkstyle rule violations were found. See the report at:

file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/test.html
Checkstyle files with violations: 39
Checkstyle violations by severity: [error:39]


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 30s
8 actionable tasks: 8 executed



If I then apply the change to config/checkstyle/checkstyle.xml:
Index: config/checkstyle/checkstyle.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===
--- config/checkstyle/checkstyle.xml (revision
66aa76d7f7fc368b5f039d0e3181edaaf85d9b27)
+++ config/checkstyle/checkstyle.xml (date 1582884183549)
@@ -30,7 +30,9 @@
  

  
-
+
+
+
  
  
 

And re-run checkstyle:
$ ./gradlew check


Configure project :

You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all


Task :compileJava UP-TO-DATE
Task :compileGroovy UP-TO-DATE
Task :processResources UP-TO-DATE
Task :classes UP-TO-DATE
Task :checkstyleMain

Checkstyle rule violations were found. See the report at:
file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
Checkstyle files with violations: 956
Checkstyle violations by severity: [error:34464]



Task :compileTestJava UP-TO-DATE
Task :compileTestGroovy UP-TO-DATE
Task :processTestResources UP-TO-DATE
Task :testClasses UP-TO-DATE
Task :checkstyleTest
Task :test
Task :check

BUILD SUCCESSFUL in 40s
9 actionable tasks: 3 executed, 6 up-to-date



This time all the 39 test file violations have been cleared.

Just in case there are some LF / CRLF issues remaining in your work area
you could run something like the following (assuming you have cygwin / msys
/ git bash)
$ find . -path ./build -prune -o -not -type d -exec file "{}" ";" | grep
CRLF



My git config is as follows:
$ git config --list --show-origin | grep -v branch.ofbiz
file:C:/Program Files/Git/etc/gitconfig
diff.astextplain.textconv=astextplain
file:C:/Program Files/Git/etc/gitconfig filter.lfs.clean=git-lfs clean -- %f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.smudge=git-lfs smudge --
%f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.process=git-lfs
filter-process
file:C:/Program Files/Git/etc/gitconfig filter.lfs.required=true
file:C:/Program Files/Git/etc/gitconfig http.sslbackend=openssl
file:C:/Program Files/Git/etc/gitconfig

Re: Solr/Lucene

Rich, Jacques,
Thanks for bringing this to the attention of the community. I guess the
reason is that in past discussions no agreement could be established on
what to do with it. Some fear it is lost forever when removed.

re:If memory serves, Lucene is still used while indexing products and
content.
You're correct. But it is also true that the framework code works with the
plugins.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz  since
2008 (without privileges)

*Apache Trafodion , Vice President*
*Apache Directory , PMC Member*
Apache Incubator , committer
Apache Steve , committer


On Fri, Feb 28, 2020 at 1:48 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Rishi,
>
> If memory serves, Lucene is still used while indexing products and content.
>
> Jacques
>
> Le 28/02/2020 à 12:37, Rishi Solanki a écrit :
> > Dear All,
> > I was checking all plugins developed with OFBiz. I  see both Solr and
> > Lucene are there, may I know why we are keeping Lucene within plugins.
> >
> > As a framework we already have the Solr which resolves many functional
> > aspects on the top of Lucene library. Do we have any good reason to keep
> > the Lucene with us, as far as I remember we sample integration/indexing
> is
> > there, but not in use anywhere.
> >
> > May be we can remove Lucene if it is not in use as we are already using
> > Solr. Or may be we have good reason to keep both, one reason I could
> think
> > of is backward compatibility. Please share your thoughts on this.
> >
> > Purpose of this email is not to remove the Lucene as plugin, but wanted
> to
> > clarify why we are keeping it.
> >
> > Best Regards,
> > --
> > Rishi Solanki
> > *CTO, Mindpath Technology*
> > cell: +91-98932-87847
> > LinkedIn 
>
>

Re: Solr/Lucene


Hi Rishi,

If memory serves, Lucene is still used while indexing products and content.

Jacques

Le 28/02/2020 à 12:37, Rishi Solanki a écrit :

Dear All,
I was checking all plugins developed with OFBiz. I  see both Solr and
Lucene are there, may I know why we are keeping Lucene within plugins.

As a framework we already have the Solr which resolves many functional
aspects on the top of Lucene library. Do we have any good reason to keep
the Lucene with us, as far as I remember we sample integration/indexing is
there, but not in use anywhere.

May be we can remove Lucene if it is not in use as we are already using
Solr. Or may be we have good reason to keep both, one reason I could think
of is backward compatibility. Please share your thoughts on this.

Purpose of this email is not to remove the Lucene as plugin, but wanted to
clarify why we are keeping it.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
cell: +91-98932-87847
LinkedIn

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Aditya Sharma

+1

Thanks and regards,
Aditya Sharma

On Fri, Feb 28, 2020 at 3:17 PM Michael Brohl 
wrote:

> There is no impersonation functionality in 17.12. The findings are
> either documentation or "constants" which do not affect the functionality.
>
> For 17.12.02 we should remove the documentation artefacts for the
> impersonation feature, but IMO this is no showstopper for the 17.12.01
> release.
>
> Michael
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 28.02.20 um 09:21 schrieb Pierre Smits:
> > I found 3 artefacts relating to the impersonation aspects.
> >
> > - CommonEvents.java
> > - security.adoc
> > - sy-impersonation.adoc
> >
> >
> >
> > Met vriendelijke groet,
> >
> > Pierre Smits
>
>

Solr/Lucene

2020-02-28 Thread Rishi Solanki

Dear All,
I was checking all plugins developed with OFBiz. I  see both Solr and
Lucene are there, may I know why we are keeping Lucene within plugins.

As a framework we already have the Solr which resolves many functional
aspects on the top of Lucene library. Do we have any good reason to keep
the Lucene with us, as far as I remember we sample integration/indexing is
there, but not in use anywhere.

May be we can remove Lucene if it is not in use as we are already using
Solr. Or may be we have good reason to keep both, one reason I could think
of is backward compatibility. Please share your thoughts on this.

Purpose of this email is not to remove the Lucene as plugin, but wanted to
clarify why we are keeping it.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
cell: +91-98932-87847
LinkedIn

Re: Checkstyle error: Files does not end with newline

Issue  https://issues.apache.org/jira/browse/OFBIZ-11428 raised and PR
https://github.com/apache/ofbiz-framework/pull/36  created

On Fri, 28 Feb 2020 at 10:24, Daniel Watford  wrote:

> Hi Jacques,
>
> I haven't been able to come up with an explanation for what you're seeing,
> so through I'd post some of my configuration and results to see if we can
> spot anything odd.
>
> Building on a Windows 10 host. Executing builds from Git Bash running in
> Windows terminal:
>
> $ git log -1
> commit 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27 (HEAD -> trunk,
> upstream/trunk, origin/trunk, origin/HEAD)
> Merge: cfad407c48 0ece441228
> Author: Jacques Le Roux 
> Date: Fri Feb 28 09:44:28 2020 +0100
>
> Merge pull request #35 from danwatford/ofbiz-11418-documentation
>
> OFBIZ-11418: Fixed line lengths in ModelFormFieldTest to adhere to coding
> standards
>
> $ git status
> On branch trunk
> Your branch is up to date with 'origin/trunk'.
>
> nothing to commit, working tree clean
>
>
> $ ./gradlew clean
>
> > Configure project :
> You are using one or more deprecated Asciidoctor task or plugins. To help
> with migration run with --warnings=all
>
> > Task :clean
>
> BUILD SUCCESSFUL in 1s
> 1 actionable task: 1 executed
>
> Windows Terminal
> $ ./gradlew check
>
> > Configure project :
> You are using one or more deprecated Asciidoctor task or plugins. To help
> with migration run with --warnings=all
>
> > Task :compileJava
> > Task :compileGroovy
> > Task :processResources
> > Task :classes
>
> > Task :checkstyleMain
> Checkstyle rule violations were found. See the report at:
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
> Checkstyle files with violations: 1055
> Checkstyle violations by severity: [error:35504]
>
>
> > Task :compileTestJava
> C:\dev\clients\ActiveTransport\activate-docker-ofbiz-framework\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\model\ModelFormFieldTest.java:128:
> warning: [deprecation] getTargetParameterList() in
> LookupField has been deprecated
> assertThat(lookupField.getTargetParameterList(),
> Matchers.contains("${prefix}TargetParam", "${key1}"));
> ^
> 1 warning
>
> > Task :compileTestGroovy
> > Task :processTestResources
> > Task :testClasses
> > Task :checkstyleTest FAILED
>
> FAILURE: Build failed with an exception.
>
> * What went wrong:
> Execution failed for task ':checkstyleTest'.
> > Checkstyle rule violations were found. See the report at:
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/test.html
> Checkstyle files with violations: 39
> Checkstyle violations by severity: [error:39]
>
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
>
> * Get more help at https://help.gradle.org
>
> BUILD FAILED in 30s
> 8 actionable tasks: 8 executed
>
>
>
> If I then apply the change to config/checkstyle/checkstyle.xml:
> Index: config/checkstyle/checkstyle.xml
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===
> --- config/checkstyle/checkstyle.xml (revision
> 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27)
> +++ config/checkstyle/checkstyle.xml (date 1582884183549)
> @@ -30,7 +30,9 @@
>  
>
>  
> -
> +
> +
> +
>  
>  
> 
>
> And re-run checkstyle:
> $ ./gradlew check
>
> > Configure project :
> You are using one or more deprecated Asciidoctor task or plugins. To help
> with migration run with --warnings=all
>
> > Task :compileJava UP-TO-DATE
> > Task :compileGroovy UP-TO-DATE
> > Task :processResources UP-TO-DATE
> > Task :classes UP-TO-DATE
>
> > Task :checkstyleMain
> Checkstyle rule violations were found. See the report at:
> file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
> Checkstyle files with violations: 956
> Checkstyle violations by severity: [error:34464]
>
>
> > Task :compileTestJava UP-TO-DATE
> > Task :compileTestGroovy UP-TO-DATE
> > Task :processTestResources UP-TO-DATE
> > Task :testClasses UP-TO-DATE
> > Task :checkstyleTest
> > Task :test
> > Task :check
>
> BUILD SUCCESSFUL in 40s
> 9 actionable tasks: 3 executed, 6 up-to-date
>
>
>
> This time all the 39 test file violations have been cleared.
>
> Just in case there are some LF / CRLF issues remaining in your work area
> you could run something like the following (assuming you have cygwin / msys
> / git bash)
> $ find . -path ./build -prune -o -not -type d -exec file "{}" ";" | grep
> CRLF
>
>
>
> My git config is as follows:
> $ git config --list --show-origin | grep -v branch.ofbiz
> file:C:/Program Files/Git/etc/gitconfig
> diff.astextplain.textconv=astextplain
> file:C:/Program Files/Git/etc/gitconfig filter.lfs.clean=git-lfs clean --
> %f
> file:C:/Program

Re: Checkstyle error: Files does not end with newline

Hi Jacques,

I haven't been able to come up with an explanation for what you're seeing,
so through I'd post some of my configuration and results to see if we can
spot anything odd.

Building on a Windows 10 host. Executing builds from Git Bash running in
Windows terminal:

$ git log -1
commit 66aa76d7f7fc368b5f039d0e3181edaaf85d9b27 (HEAD -> trunk,
upstream/trunk, origin/trunk, origin/HEAD)
Merge: cfad407c48 0ece441228
Author: Jacques Le Roux 
Date: Fri Feb 28 09:44:28 2020 +0100

Merge pull request #35 from danwatford/ofbiz-11418-documentation

OFBIZ-11418: Fixed line lengths in ModelFormFieldTest to adhere to coding
standards

$ git status
On branch trunk
Your branch is up to date with 'origin/trunk'.

nothing to commit, working tree clean


$ ./gradlew clean

> Configure project :
You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all

> Task :clean

BUILD SUCCESSFUL in 1s
1 actionable task: 1 executed

Windows Terminal
$ ./gradlew check

> Configure project :
You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all

> Task :compileJava
> Task :compileGroovy
> Task :processResources
> Task :classes

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at:
file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
Checkstyle files with violations: 1055
Checkstyle violations by severity: [error:35504]


> Task :compileTestJava
C:\dev\clients\ActiveTransport\activate-docker-ofbiz-framework\ofbiz\framework\widget\src\test\java\org\apache\ofbiz\widget\model\ModelFormFieldTest.java:128:
warning: [deprecation] getTargetParameterList() in
LookupField has been deprecated
assertThat(lookupField.getTargetParameterList(),
Matchers.contains("${prefix}TargetParam", "${key1}"));
^
1 warning

> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
> Task :checkstyleTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at:
file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/test.html
Checkstyle files with violations: 39
Checkstyle violations by severity: [error:39]


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 30s
8 actionable tasks: 8 executed



If I then apply the change to config/checkstyle/checkstyle.xml:
Index: config/checkstyle/checkstyle.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===
--- config/checkstyle/checkstyle.xml (revision
66aa76d7f7fc368b5f039d0e3181edaaf85d9b27)
+++ config/checkstyle/checkstyle.xml (date 1582884183549)
@@ -30,7 +30,9 @@
 

 
-
+
+
+
 
 


And re-run checkstyle:
$ ./gradlew check

> Configure project :
You are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all

> Task :compileJava UP-TO-DATE
> Task :compileGroovy UP-TO-DATE
> Task :processResources UP-TO-DATE
> Task :classes UP-TO-DATE

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at:
file:///C:/dev/clients/ActiveTransport/activate-docker-ofbiz-framework/ofbiz/build/reports/checkstyle/main.html
Checkstyle files with violations: 956
Checkstyle violations by severity: [error:34464]


> Task :compileTestJava UP-TO-DATE
> Task :compileTestGroovy UP-TO-DATE
> Task :processTestResources UP-TO-DATE
> Task :testClasses UP-TO-DATE
> Task :checkstyleTest
> Task :test
> Task :check

BUILD SUCCESSFUL in 40s
9 actionable tasks: 3 executed, 6 up-to-date



This time all the 39 test file violations have been cleared.

Just in case there are some LF / CRLF issues remaining in your work area
you could run something like the following (assuming you have cygwin / msys
/ git bash)
$ find . -path ./build -prune -o -not -type d -exec file "{}" ";" | grep
CRLF



My git config is as follows:
$ git config --list --show-origin | grep -v branch.ofbiz
file:C:/Program Files/Git/etc/gitconfig
diff.astextplain.textconv=astextplain
file:C:/Program Files/Git/etc/gitconfig filter.lfs.clean=git-lfs clean -- %f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.smudge=git-lfs smudge --
%f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.process=git-lfs
filter-process
file:C:/Program Files/Git/etc/gitconfig filter.lfs.required=true
file:C:/Program Files/Git/etc/gitconfig http.sslbackend=openssl
file:C:/Program Files/Git/etc/gitconfig http.sslcainfo=C:/Program
Files/Git/mingw64/ssl/certs/ca-bundle.crt
file:C:/Program Files/Git/etc/gitconfig core.autocrlf=input
file:C:/Program

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Michael Brohl

There is no impersonation functionality in 17.12. The findings are 
either documentation or "constants" which do not affect the functionality.


For 17.12.02 we should remove the documentation artefacts for the 
impersonation feature, but IMO this is no showstopper for the 17.12.01 
release.


Michael

ecomify GmbH - www.ecomify.de


Am 28.02.20 um 09:21 schrieb Pierre Smits:

I found 3 artefacts relating to the impersonation aspects.

- CommonEvents.java
- security.adoc
- sy-impersonation.adoc



Met vriendelijke groet,

Pierre Smits




smime.p7s
Description: S/MIME Cryptographic Signature

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Taher Alkhateeb

+1

On Fri, Feb 28, 2020, 12:37 PM Gil Portenseigne 
wrote:

> +1
>
> On Thu, Feb 27, 2020 at 06:09:34PM +0100, Michael Brohl wrote:
> > +1
> >
> > ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01 
> > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip
> > sha check of file: apache-ofbiz-17.12.01.zip
> > Using sha file: apache-ofbiz-17.12.01.zip.sha512
> > apache-ofbiz-17.12.01.zip: 3E92DF0F 92E71B33 0FEF2B7C FBEE2E51 88F98E3B
> > 76614824 2A40C84F 922DDB08 B0760B76 8667EAF4 E35F2939 44757CD7 658C9A72
> > 5B8A5358 36208F4A D26DEB40
> > apache-ofbiz-17.12.01.zip: 3E92DF0F 92E71B33 0FEF2B7C FBEE2E51 88F98E3B
> > 76614824 2A40C84F 922DDB08 B0760B76 8667EAF4 E35F2939 44757CD7 658C9A72
> > 5B8A5358 36208F4A D26DEB40
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signature made Thu Feb 27 10:36:12 2020 CET using RSA key ID
> 847AF9E0
> > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> > " [ultimate]
> >
> >
> > ./gradlew loadAll testIntegration
> >
> > ...
> >
> > :testIntegration
> >
> > BUILD SUCCESSFUL
> >
> >
> > Thanks,
> >
> > Michael Brohl
> >
> > ecomify GmbH - www.ecomify.de
> >
> >
> > Am 27.02.20 um 10:49 schrieb Jacopo Cappellato:
> > > This is the vote thread (3nd attempt) to release "Apache OFBiz
> 17.12.01":
> > > this is the first release, containing the framework, applications and
> all
> > > the plugins from the 17.12 release branches.
> > >
> > > The release files can be downloaded from here:
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > > * apache-ofbiz-17.12.01.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> > > * apache-ofbiz-17.12.01.zip.sha512: checksum file
> > >
> > > Please download the zip file, build and test OFBiz and verify the
> signature
> > > and checksum (for instructions on testing the signatures see
> > > http://www.apache.org/info/verification.html).
> > >
> > > Vote:
> > >
> > > [ +1] release as Apache OFBiz 17.12.01
> > > [ -1] do not release
> > >
> > > This vote will be open for 5 days.
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> > >
> >
>
>
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Gil Portenseigne

+1

On Thu, Feb 27, 2020 at 06:09:34PM +0100, Michael Brohl wrote:
> +1
> 
> ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01 
> ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip
> sha check of file: apache-ofbiz-17.12.01.zip
> Using sha file: apache-ofbiz-17.12.01.zip.sha512
> apache-ofbiz-17.12.01.zip: 3E92DF0F 92E71B33 0FEF2B7C FBEE2E51 88F98E3B
> 76614824 2A40C84F 922DDB08 B0760B76 8667EAF4 E35F2939 44757CD7 658C9A72
> 5B8A5358 36208F4A D26DEB40
> apache-ofbiz-17.12.01.zip: 3E92DF0F 92E71B33 0FEF2B7C FBEE2E51 88F98E3B
> 76614824 2A40C84F 922DDB08 B0760B76 8667EAF4 E35F2939 44757CD7 658C9A72
> 5B8A5358 36208F4A D26DEB40
> sha checksum OK
> 
> GPG verification output
> gpg: Signature made Thu Feb 27 10:36:12 2020 CET using RSA key ID 847AF9E0
> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> " [ultimate]
> 
> 
> ./gradlew loadAll testIntegration
> 
> ...
> 
> :testIntegration
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Michael Brohl
> 
> ecomify GmbH - www.ecomify.de
> 
> 
> Am 27.02.20 um 10:49 schrieb Jacopo Cappellato:
> > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01":
> > this is the first release, containing the framework, applications and all
> > the plugins from the 17.12 release branches.
> > 
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > 
> > and are:
> > * apache-ofbiz-17.12.01.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.01.zip.sha512: checksum file
> > 
> > Please download the zip file, build and test OFBiz and verify the signature
> > and checksum (for instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> > 
> > Vote:
> > 
> > [ +1] release as Apache OFBiz 17.12.01
> > [ -1] do not release
> > 
> > This vote will be open for 5 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> > 
> 




signature.asc
Description: PGP signature

Re: Checkstyle error: Files does not end with newline



Le 28/02/2020 à 10:22, Jacques Le Roux a écrit :

Le 28/02/2020 à 10:07, Daniel Watford a écrit :

Hello,

In my dev environment (Windows 10, IntelliJ, Git checking out with LF line
endings) I see 39 checkstyle errors for our tests related to java files not
ending with a newline.

However on inspecting one of the files, ModelFormFieldTest, I can see that
it does end with a newline.

A quick google on the subject turned up
https://stackoverflow.com/questions/997021/how-to-get-rid-of-checkstyle-message-file-does-not-end-with-a-newline
.

It appears that checkstyle will assume the line endings of the environment
where it is being run. In my case, Windows, it will assume line endings of
CRLF, rather than the LF that I am using.

If I modify the checkstyle configuration to specify LF for line endings
using:


 


all the checkstyle errors in tests are resolved.

*Question: Does anyone see any issues in telling Checkstyle to use LF line
endings when it performs its checking?*

The interesting thing was that even if I convert a file to use CRLF line
endings, the above lineSeparator confgiuration for the NewlineAtEndOfFile
checkstyle module would still pass.

The above change also had the pleasant outcome of reducing checkstyle
errors for main code from 1055 files with violations to 956.

Dan


Hi Daniel,

Thanks for this information, I use also Windows (7) and was just to the point 
to look at the remaning issue with checkstyle.

+1 for your proposition

But I just tried after changing NewlineAtEndOfFile module as you suggest, and 
got this

   /C:\projectsASF\Git\ofbiz-framework>gradlew check > Configure project : You 
are using one or more deprecated Asciidoctor task or plugins. To help
   with migration run with --warnings=all > Task :compileJava UP-TO-DATE > Task 
:compileGroovy UP-TO-DATE > Task :processResources UP-TO-DATE > Task
   :classes UP-TO-DATE > Task :checkstyleMain Checkstyle rule violations were 
found. See the report at:
file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/main.html 
Checkstyle files with violations: 1038 Checkstyle violations by
   severity: [error:37692] > Task :compileTestJava UP-TO-DATE > Task 
:compileTestGroovy UP-TO-DATE > Task :processTestResources UP-TO-DATE > Task
   :testClasses UP-TO-DATE > Task :checkstyleTest > Task :test FAILED FAILURE: 
Build failed with an exception. * What went wrong: Execution failed
   for task ':test'. > 120/

Don't you have any checkstyle issues with trunk HEAD?
I checked my Git local config and see no reasons, any ideas?

Jacques


Also using

   /    //
   //    //
   //    /

Does not help, weird, isn't?

I'll relaunch manually 
https://ci.apache.org/builders/ofbizTrunkFramework/builds/1296

Because https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/ makes 
no sense another Buildbot quirk ;)

Jacques

Re: Checkstyle error: Files does not end with newline

Le 28/02/2020 à 10:07, Daniel Watford a écrit :

Hello,

In my dev environment (Windows 10, IntelliJ, Git checking out with LF line
endings) I see 39 checkstyle errors for our tests related to java files not
ending with a newline.

However on inspecting one of the files, ModelFormFieldTest, I can see that
it does end with a newline.

A quick google on the subject turned up
https://stackoverflow.com/questions/997021/how-to-get-rid-of-checkstyle-message-file-does-not-end-with-a-newline
.

It appears that checkstyle will assume the line endings of the environment
where it is being run. In my case, Windows, it will assume line endings of
CRLF, rather than the LF that I am using.

If I modify the checkstyle configuration to specify LF for line endings
using:

all the checkstyle errors in tests are resolved.

*Question: Does anyone see any issues in telling Checkstyle to use LF line
endings when it performs its checking?*

The interesting thing was that even if I convert a file to use CRLF line
endings, the above lineSeparator confgiuration for the NewlineAtEndOfFile
checkstyle module would still pass.

The above change also had the pleasant outcome of reducing checkstyle
errors for main code from 1055 files with violations to 956.

Dan

Hi Daniel,

Thanks for this information, I use also Windows (7) and was just to the point
to look at the remaning issue with checkstyle.

+1 for your proposition

But I just tried after changing NewlineAtEndOfFile module as you suggest, and
got this

/C:\projectsASF\Git\ofbiz-framework>gradlew check > Configure project : You
are using one or more deprecated Asciidoctor task or plugins. To help
with migration run with --warnings=all > Task :compileJava UP-TO-DATE > Task
:compileGroovy UP-TO-DATE > Task :processResources UP-TO-DATE > Task
:classes UP-TO-DATE > Task :checkstyleMain Checkstyle rule violations were
found. See the report at:

file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/main.html
Checkstyle files with violations: 1038 Checkstyle violations by
severity: [error:37692] > Task :compileTestJava UP-TO-DATE > Task
:compileTestGroovy UP-TO-DATE > Task :processTestResources UP-TO-DATE > Task
:testClasses UP-TO-DATE > Task :checkstyleTest > Task :test FAILED FAILURE:
Build failed with an exception. * What went wrong: Execution failed
for task ':test'. > 120/

Don't you have any checkstyle issues with trunk HEAD?
I checked my Git local config and see no reasons, any ideas?

Jacques

Checkstyle error: Files does not end with newline

Hello,

In my dev environment (Windows 10, IntelliJ, Git checking out with LF line
endings) I see 39 checkstyle errors for our tests related to java files not
ending with a newline.

However on inspecting one of the files, ModelFormFieldTest, I can see that
it does end with a newline.

A quick google on the subject turned up
https://stackoverflow.com/questions/997021/how-to-get-rid-of-checkstyle-message-file-does-not-end-with-a-newline
.

It appears that checkstyle will assume the line endings of the environment
where it is being run. In my case, Windows, it will assume line endings of
CRLF, rather than the LF that I am using.

If I modify the checkstyle configuration to specify LF for line endings
using:





all the checkstyle errors in tests are resolved.

*Question: Does anyone see any issues in telling Checkstyle to use LF line
endings when it performs its checking?*

The interesting thing was that even if I convert a file to use CRLF line
endings, the above lineSeparator confgiuration for the NewlineAtEndOfFile
checkstyle module would still pass.

The above change also had the pleasant outcome of reducing checkstyle
errors for main code from 1055 files with violations to 956.

Dan

-- 
Daniel Watford

Re: Backport in R18: OFBIZ-11415 & OFBIZ-11418


Le 28/02/2020 à 09:32, Pierre Smits a écrit :

I advice you to not forget to put the xsd change(s) in the correct source.


Hi Pierre,

Thanks for your advice, actually I include that in the documentation, so no 
I'll not forget :p

Jacques

Re: Backport in R18: OFBIZ-11415 & OFBIZ-11418

Hi Jacques,

As you're taking the lead to work the underlying issue, I advice you to not
forget to put the xsd change(s) in the correct source.

Mg

Pierre


Op vr 28 feb. 2020 09:24 schreef Jacques Le Roux <
jacques.le.r...@les7arts.com>:

> Hi,
>
> Daniel (Watford) has asked to exceptionally backport the new
> FlexibleStringExpander feature used in target-parameter and parameter-name
> of form widget
> to R18 branch.
>
> I'll do so (with tests and documentation) in a week if nobody is against
>
> Please share your thoughts if needed
>
> Thanks
>
> Jacques
>
>

Backport in R18: OFBIZ-11415 & OFBIZ-11418


Hi,

Daniel (Watford) has asked to exceptionally backport the new FlexibleStringExpander feature used in target-parameter and parameter-name of form widget 
to R18 branch.


I'll do so (with tests and documentation) in a week if nobody is against

Please share your thoughts if needed

Thanks

Jacques

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3