Re: REST implementation

[Girish Vasmatkar]

Hi Shi

Thanks for taking a look at it. I have a question on "WWW-Authenticate"
header so please clarify and I can make appropriate changes accordingly -

All I am finding is that to prevent the pop-up, either return 403 (which I
do not want to do) or not include "WWW-Authenticate" header at all (not
inclined to do this as well because then we would be violating the spec).
Do you mean to NOT start the value of the header with "Bearer" ?
so instead of below

*WWW-Authenticate: Bearer realm="Access to OFBiz", charset="UTF-8"*

should we change it to

*WWW-Authenticate: xBearer realm="Access to OFBiz", charset="UTF-8"*

I did not test it, but I can just change it like this without testing if
you can please confirm it will prevent the browser dialog.

Thanks again for the review.

Best,
Girish

On Wed, Jul 8, 2020 at 8:45 PM Shi Jinghai  wrote:

> Hi Girish,
>
> Excellent.
>
> Only one suggestion from my quick view, when response code is 401, the
> "WWW-Authenticate" header should be set to start with a word NOT “Bearer
> …”, this can prevent web browser from popping up a login dialog.
>
> Kind Regards,
>
> Shi Jinghai
>
> 发件人: Girish Vasmatkar
> 发送时间: 2020年7月8日 20:47
> 收件人: dev@ofbiz.apache.org
> 主题: Re: REST implementation
>
> Hi Folks
>
> I have added support for OpenApi Integration. The updated code can be found
> here : https://github.com/girishvasmatkar/ofbiz-rest-impl. Please go
> through the changes and test at your end and let me know your thoughts.
>
> I am planning to do some refactoring and then raise initial PR for the
> plug-in if the changes look good to everyone.
>
> Best,
> Girish
>
>
> On Wed, Jun 17, 2020 at 4:54 PM Carsten Schinzer <
> cars...@dcs-verkaufssysteme.de> wrote:
>
> > Hi Girish,
> >
> > Thanks to clarify :)
> > What caught me on the OpenAPI integration is the snippet quoted below and
> > I realize I should have read it in context. Actually then it is aligned
> > with my view.
> >
> > Warm regards
> >
> > Carsten
> >
> > > Initial implementation does not contain OpenApi integration yet.
> And
> >
> >
>
>

Re: Change "build and install" section on the website

[Jacques Le Roux]

Done

Le 08/07/2020 à 09:29, Jacques Le Roux a écrit :
hen I will modify the “Build and running OFBiz” section on the website to refer to the INSTALL file 

Re: REST implementation

[Shi Jinghai]

Hi Girish,

Excellent.

Only one suggestion from my quick view, when response code is 401, the 
"WWW-Authenticate" header should be set to start with a word NOT “Bearer …”, 
this can prevent web browser from popping up a login dialog.

Kind Regards,

Shi Jinghai

发件人: Girish Vasmatkar
发送时间: 2020年7月8日 20:47
收件人: dev@ofbiz.apache.org
主题: Re: REST implementation

Hi Folks

I have added support for OpenApi Integration. The updated code can be found
here : https://github.com/girishvasmatkar/ofbiz-rest-impl. Please go
through the changes and test at your end and let me know your thoughts.

I am planning to do some refactoring and then raise initial PR for the
plug-in if the changes look good to everyone.

Best,
Girish


On Wed, Jun 17, 2020 at 4:54 PM Carsten Schinzer <
cars...@dcs-verkaufssysteme.de> wrote:

> Hi Girish,
>
> Thanks to clarify :)
> What caught me on the OpenAPI integration is the snippet quoted below and
> I realize I should have read it in context. Actually then it is aligned
> with my view.
>
> Warm regards
>
> Carsten
>
> > Initial implementation does not contain OpenApi integration yet. And
>
>

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04 - Second Attempt

[Christian Geisert]

Looks good

+1 for the release

Christian

Am 05.07.20 um 10:23 schrieb Jacopo Cappellato:

This is the vote thread (second attempt) to publish a new bug fix release
from the "release17.12" branch. This new release, "Apache OFBiz 17.12.04",
will supersede all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/
and are:
* apache-ofbiz-17.12.04.zip
* KEYS: text file with keys
* apache-ofbiz-17.12.04.zip.asc: the detached signature file
* apache-ofbiz-17.12.04.zip.sha512: checksum file

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:
[ +1] release as Apache OFBiz 17.12.04
[ -1] do not release

This vote will be open for 5 days.

For more details about this process please read
http://www.apache.org/foundation/voting.html

Re: REST implementation

[Girish Vasmatkar]

Hi Folks

I have added support for OpenApi Integration. The updated code can be found
here : https://github.com/girishvasmatkar/ofbiz-rest-impl. Please go
through the changes and test at your end and let me know your thoughts.

I am planning to do some refactoring and then raise initial PR for the
plug-in if the changes look good to everyone.

Best,
Girish


On Wed, Jun 17, 2020 at 4:54 PM Carsten Schinzer <
cars...@dcs-verkaufssysteme.de> wrote:

> Hi Girish,
>
> Thanks to clarify :)
> What caught me on the OpenAPI integration is the snippet quoted below and
> I realize I should have read it in context. Actually then it is aligned
> with my view.
>
> Warm regards
>
> Carsten
>
> > Initial implementation does not contain OpenApi integration yet. And
>
>

Re: JUnit 5?

[Jacques Le Roux]

Thank you Girish for copying in OFBIZ-11870,

I still not had the time to think at your question :)

Jacques

Le 06/07/2020 à 07:39, Girish Vasmatkar a écrit :

Hi All

OFBiz integration tests are based on classes extending the TestCase class.
Should we not allow for a hybrid way of writing integration test cases
based on classes that do not extend TestCase while also allowing old ways
(extending TestCase and test methods starting with test) of writing test
cases?

Is there any particular reason why we are still using TestCase class?

Best
Girish




On Sun, Jul 5, 2020 at 1:44 PM Jacques Le Roux 
wrote:


Thanks Eugen,

That's quite interesting, could you please put your comment in the Jira?

TIA

Jacques

Le 05/07/2020 à 09:36, Eugen Stan a écrit :

Hello Jacques,

I think it makes sense to make the transition.

In James we do have it ongoing.

Junit5 people have documented the upgrade process and you can make it
gradually and have both.

Use ` git grep org.junit.Test | wc -l `to count the non-migrated tests.

This is what we have based on the migration samples
https://github.com/junit-team/junit5-samples#gradle-migration-



https://github.com/junit-team/junit5-samples/blob/main/junit5-migration-gradle/build.gradle


https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4



  testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.1'
  testImplementation 'org.junit.jupiter:junit-jupiter-params:5.5.1'
  testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.1'
  testCompileOnly 'junit:junit:4.13'
  testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.5.1'
}

test {
  useJUnitPlatform()
}




La 05.07.2020 10:01, Jacques Le Roux a scris:

I created https://issues.apache.org/jira/browse/OFBIZ-11870 for that

Jacques

Le 04/09/2018 à 09:15, Jacques Le Roux a écrit :

Hi,

I stumbled upon this tweet

  https://twitter.com/junitteam/status/1036707906706698243

Had a quick look at

  https://junit.org/junit5/docs/5.3.0/release-notes/

  https://www.baeldung.com/junit-5-migration

I did not rememberf, so searched if we discussed moving from JUnit 4
to JUnit 5, but did not find anything.

Did we discuss it, if so what were the conclusions? If not, should we
not discuss it?

Thanks


https://twitter.com/junitteam/status/1036707906706698243witter.com/junitteam/status/1036707906706698243

Jacques

Re: Change "build and install" section on the website

[Jacques Le Roux]

Hi All,

After trying to update it, I have finally moved
https://cwiki.apache.org/confluence/display/OFBIZ/How+to+install+OFBiz+with+the+Demo+Data
to the wiki Attic, with another older one from 2008.

I'll do the same for
https://cwiki.apache.org/confluence/display/OFBENDUSER/How+to+Install+OFBiz+without+the+Demo+Data
I'll document that in the INSTALL before

Then I will modify the “Build and running OFBiz” section on the website to 
refer to the INSTALL file

There are maybe other deprecated install or load data or what-not related to 
install and load data pages that you are aware of.
Then please either move them to Wiki Attic or let us know here that we check, 
TIA

Jacques

Le 02/07/2020 à 07:50, Jacques Le Roux a écrit :

Hi Michael,

That sounds like a pragmatic idea to me

Jacques

Le 01/07/2020 à 18:47, Michael Brohl a écrit :

Hi all,

The description in https://ofbiz.apache.org/business-users.html#UsrInstall  is 
not correct for the 17.12 download at the moment.

I think we should get rid of the “Build and running OFBiz” section on the website and just refer to the INSTALL/README in the downloaded package to 
avoid confusion.


It will be easier to maintain also.

What do you think?

Michael Brohl

ecomify GmbH - www.ecomify.de