OFBiz Integrations

[Rishi Solanki]

Dear All,
In another thread on "Integration with facebook ecommerce platform" one
good suggestion came from user Andrew Williams to integrate OFBiz with
WooCommerce and WordPress. I would like to extend it to all required
integrations.

Below are the areas as per my understanding where we would require
integrations which is in general expected.

1) Payment (Amazon, Apple, PayPal, First Data etc)
2) Shipping (UPS, UPS, FEDEX, DHL etc.)
3) Other Selling Portals and Channels (Amazon, WooCommerce, Wordpress,
Shopify etc.)
4) Communication related integration. (Email, SMS, Chatbot, Whatapp etc)
5) Supporting modules like Reports tool, Sales Force etc.
6) Data Import Tool like JSON, Excel, CSV etc.

Please add more in the list. Once will have all items listed, we will push
that list over the confluence page, and all supporting docs link. Later we
can pick one by one and mark them complete from there, in this way from the
open list everyone will have the opportunity to pick any and contribute.

We can also think of creating open tickets from the approved list to work
on. Looking forward.

Rishi Solanki
*CTO, Mindpath Technology*
Intelligent Solutions
cell: +91-98932-87847
http://www.mindpathtech.com
LinkedIn 

Re: OFBiz as OMS

[Pranay Pandey]

Thanks to all the community members who joined the second session.
The recording is available on YouTube: https://youtu.be/qJPy8_4tzfc

Kind regards,
Pranay Pandey


On Tue, Sep 29, 2020 at 3:58 PM Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Here is the URL for today's session.
> https://meet.google.com/fmp-djer-fmt
>
> Best regards,
> Pranay Pandey
>
>
> On Tue, Sep 29, 2020 at 12:44 PM Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
>> Thank you Devanshu.
>>
>> Just a reminder for all that we are going to do a session today at 4:00
>> PM on Real-time inventory visibility. I will post the meeting URL on this
>> thread at 3:55 PM.
>>
>> Best regards,
>> Pranay Pandey
>>
>>
>> On Sat, Sep 26, 2020 at 9:14 PM Devanshu Vyas 
>> wrote:
>>
>>> Hello, We just finished our first discussion on OFBiz as Open Source OMS.
>>> Thank you to all the participants joining in. The video is now published
>>> on
>>> the OFBiz Youtube Channel. Here is the link:
>>> https://youtu.be/37E777O7050
>>> This will be a series of videos where we will be discussing this topic.
>>> Here is the link for the playlist:
>>> https://www.youtube.com/playlist?list=PLobIkeUbRXqe7YKSOdrXTrbRlCa7xvyGe
>>>
>>> We have finalized a schedule to continue our discussions on this topic,
>>> which is every Tuesday at 4 PM IST.
>>> 29th September 2020 Real-time inventory visibility
>>> 6th October 2020 Order routing to a facility for fulfilment
>>> 13th October 2020 Order splitting of available items for faster
>>> fulfilment
>>> 20th October 2020 Fulfilment application to be used at Stores(BOSS - Buy
>>> Online Ship-to-Store)
>>> 27th October 2020 Store inventory management
>>> 3rd November 2020 Integrations with applications like BOPIS(Buy Online
>>> and
>>> Pick in Store), BORIS(Buy Online Return in Store), and Endless Aisle.
>>> 10th November 2020 Preorder and Backorder Management
>>>
>>> @Deepak, It was an impromptu session, and at the last minute, we thought
>>> of
>>> including anyone who wants to join.
>>> I have prepared and shared the schedule of each discussion we will be
>>> doing
>>> on this topic.
>>>
>>> @Joseph, I hope to see you in the next discussion.
>>>
>>>
>>> Thanks & Regards,
>>> Devanshu Vyas.
>>>
>>>
>>> On Sat, Sep 26, 2020 at 5:40 PM Deepak Dixit 
>>> wrote:
>>>
>>> > Hi Devanshu,
>>> >
>>> > It'd be good if you share this kind of information little early, In the
>>> > planned way you will get more participation.
>>> >
>>> >
>>> > Kind Regards,
>>> > Deepak Dixit
>>> >
>>> >
>>> >
>>> > On Sat, Sep 26, 2020 at 4:12 PM Devanshu Vyas <
>>> vyas.devansh...@gmail.com>
>>> > wrote:
>>> >
>>> > > Hello,
>>> > >
>>> > > We are going to start the discussion on 'OFBiz as OMS' today at 4:30
>>> PM
>>> > > IST. If you are interested in joining, please share your interest
>>> here
>>> > and
>>> > > I'll send you a link.
>>> > >
>>> > > Thanks & Regards,
>>> > > Devanshu Vyas.
>>> > >
>>> >
>>>
>>

Re: REST, how about 'Login' map

[Hans Bakker]

Hi Girish, thanks for your prompt reply,

the login map need to be filled when the related token is available, 
what is currently not the case.


Not sure if this is directly related to the Auth=false parameter, you 
know that better,


Regards, Hans

On 9/29/20 4:20 PM, Girish Vasmatkar wrote:

Hi Hans

Since you specifically mentioned about groovy service, I would think 
it is true for other services as well.


It would possibly be happening, if the service itself is declared with 
auth=false, so no token check is happening and hence userLogin is not 
retrieved from the token.
Can you confirm if this is the case? The userLogin is added to the 
service call before delegating the service call to dispatcher after 
jwt has been verified. But in case of auth=false, services, auth is 
bypassed and hence userLogin is not set.


I guess the key here is to bypass token validation if, and only if, 
the Authorization header is absent, otherwise perform validation. I 
had a discussion about this with Jacopo as well and here is what can 
be done (applicable for */services *endpoint ) -


If auth=false and *Authorization* header is */present/*, validate 
token and return error if invalid. Else set userLogin in context and 
delegate the call to dispatcher.
If auth=false and *Authorization* header is *absent, *just call the 
service. The service will be executed */without/* userLogin in context.


I will try to work on this change in the next couple days.

Best,
Girish
HotWax Systems











Best,
Girish
HotWax Systems








On Tue, Sep 29, 2020 at 6:20 AM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish,

thanks for your last email, that is working now too

howeveranother question,

If i call a service using the token i obtained earlier, i see that
the
userLogin map in the groovy service I called, is null

can you set the login map to the userLogin of the token that was
used so
we know who the user is?

Thanks, Hans

Re: OFBiz as OMS

[Pranay Pandey]

Here is the URL for today's session.
https://meet.google.com/fmp-djer-fmt

Best regards,
Pranay Pandey


On Tue, Sep 29, 2020 at 12:44 PM Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Thank you Devanshu.
>
> Just a reminder for all that we are going to do a session today at 4:00 PM
> on Real-time inventory visibility. I will post the meeting URL on this
> thread at 3:55 PM.
>
> Best regards,
> Pranay Pandey
>
>
> On Sat, Sep 26, 2020 at 9:14 PM Devanshu Vyas 
> wrote:
>
>> Hello, We just finished our first discussion on OFBiz as Open Source OMS.
>> Thank you to all the participants joining in. The video is now published
>> on
>> the OFBiz Youtube Channel. Here is the link: https://youtu.be/37E777O7050
>> This will be a series of videos where we will be discussing this topic.
>> Here is the link for the playlist:
>> https://www.youtube.com/playlist?list=PLobIkeUbRXqe7YKSOdrXTrbRlCa7xvyGe
>>
>> We have finalized a schedule to continue our discussions on this topic,
>> which is every Tuesday at 4 PM IST.
>> 29th September 2020 Real-time inventory visibility
>> 6th October 2020 Order routing to a facility for fulfilment
>> 13th October 2020 Order splitting of available items for faster fulfilment
>> 20th October 2020 Fulfilment application to be used at Stores(BOSS - Buy
>> Online Ship-to-Store)
>> 27th October 2020 Store inventory management
>> 3rd November 2020 Integrations with applications like BOPIS(Buy Online and
>> Pick in Store), BORIS(Buy Online Return in Store), and Endless Aisle.
>> 10th November 2020 Preorder and Backorder Management
>>
>> @Deepak, It was an impromptu session, and at the last minute, we thought
>> of
>> including anyone who wants to join.
>> I have prepared and shared the schedule of each discussion we will be
>> doing
>> on this topic.
>>
>> @Joseph, I hope to see you in the next discussion.
>>
>>
>> Thanks & Regards,
>> Devanshu Vyas.
>>
>>
>> On Sat, Sep 26, 2020 at 5:40 PM Deepak Dixit 
>> wrote:
>>
>> > Hi Devanshu,
>> >
>> > It'd be good if you share this kind of information little early, In the
>> > planned way you will get more participation.
>> >
>> >
>> > Kind Regards,
>> > Deepak Dixit
>> >
>> >
>> >
>> > On Sat, Sep 26, 2020 at 4:12 PM Devanshu Vyas <
>> vyas.devansh...@gmail.com>
>> > wrote:
>> >
>> > > Hello,
>> > >
>> > > We are going to start the discussion on 'OFBiz as OMS' today at 4:30
>> PM
>> > > IST. If you are interested in joining, please share your interest here
>> > and
>> > > I'll send you a link.
>> > >
>> > > Thanks & Regards,
>> > > Devanshu Vyas.
>> > >
>> >
>>
>

Re: REST, how about 'Login' map

[Girish Vasmatkar]

Hi Hans

Since you specifically mentioned about groovy service, I would think it is
true for other services as well.

It would possibly be happening, if the service itself is declared with
auth=false, so no token check is happening and hence userLogin is not
retrieved from the token.
Can you confirm if this is the case? The userLogin is added to the service
call before delegating the service call to dispatcher after jwt has been
verified. But in case of auth=false, services, auth is bypassed and hence
userLogin is not set.

I guess the key here is to bypass token validation if, and only if, the
Authorization header is absent, otherwise perform validation. I had a
discussion about this with Jacopo as well and here is what can be done
(applicable for */services *endpoint ) -

If auth=false and *Authorization* header is *present*, validate token and
return error if invalid. Else set userLogin in context and delegate the
call to dispatcher.
If auth=false and *Authorization* header is *absent, *just call the
service. The service will be executed *without* userLogin in context.

I will try to work on this change in the next couple days.

Best,
Girish
HotWax Systems











Best,
Girish
HotWax Systems








On Tue, Sep 29, 2020 at 6:20 AM Hans Bakker 
wrote:

> Hi Girish,
>
> thanks for your last email, that is working now too
>
> howeveranother question,
>
> If i call a service using the token i obtained earlier, i see that the
> userLogin map in the groovy service I called, is null
>
> can you set the login map to the userLogin of the token that was used so
> we know who the user is?
>
> Thanks, Hans
>
>
>

Re: UPDATE: OFBiz code linting issues

[Pritam Kute]

Thanks to Suraj and all the other people who worked on this task. This is a
great achievement. The introduction of checkstyle will surely help in
keeping code clean and neat.

Kind Regards,
--
Pritam Kute


On Mon, Sep 28, 2020 at 2:53 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Suraj, and to all who worked on it.
>
> I know it's not yet finished, but I think the next similar tasks would be
> to look at the FIXMEs and later TODOs...
>
> Jacques
>
> Le 26/09/2020 à 12:36, Suraj Khurana a écrit :
> > Hello team,
> >
> > Sometimes back, we introduced sonar and checkstyle linting tools
> integrated
> > with OFBiz.
> > We as a community are serious not only about features being introduced in
> > OFBiz but also code quality being added in the repo.
> > So we started correcting issues identified by the linting tool
> (checkstyle)
> > and there were nearly ~*40,000* of those in the whole codebase.
> >
> > Slowly we keep on discussing it on different mail threads and move
> towards
> > conclusions and fix those into the code base.
> > We also incorporated a pre-push commit hook to ensure that no new issues
> > are being introduced by committers.
> >
> > I am glad to announce that we have fixed around *99%* of these issues
> > successfully.
> > Kudos to everyone involved in this effort !!
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
>
>

Re: [PROPOSAL] Separate login service for API calls

[Mridul Pathak]

+1

Thanks.
Mridul Pathak

On Tue, Sep 29, 2020 at 1:29 PM Michael Brohl 
wrote:

> +1
>
> With an addition: we should do the implementation in a way that the
> user/password matching is implemented only once and used in both login
> methods (not just copy & paste into another method).
>
> It might take some refactoring to pull these part out of the login event.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 29.09.20 um 09:43 schrieb Jacopo Cappellato:
> > +1
> >
> > Jacopo
> >
> > On Sat, Sep 26, 2020 at 6:35 AM Girish Vasmatkar <
> > girish.vasmat...@hotwaxsystems.com> wrote:
> >
> >> Hi
> >>
> >> I am using userLogin service to authenticate users before generating
> auth
> >> tokens for REST API and GraphQL calls. However, I figured that a
> session is
> >> also getting created and returned in response which is defeating the
> >> purpose of having an API in place. Even though that session is not
> getting
> >> used anywhere when subsequent calls are made using the token, I still
> think
> >> it is an extra session lying around in tomcat's session cache.
> >>
> >> I propose to implement a new basic userLogin service
> (basicAuthUserLogin)
> >> that would just do username/password matching and be done with it
> without
> >> ever calling request.getSession(). This will ensure that APIs are
> stateless
> >> and no session is generated.
> >>
> >> Anything else you think should be part of the new service instead of
> just
> >> username/password validation?
> >>
> >> Best,
> >> Girish
> >> HotWax Systems
> >>
>
>

Re: [PROPOSAL] Separate login service for API calls

[Michael Brohl]

+1

With an addition: we should do the implementation in a way that the 
user/password matching is implemented only once and used in both login 
methods (not just copy & paste into another method).


It might take some refactoring to pull these part out of the login event.

Best regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 29.09.20 um 09:43 schrieb Jacopo Cappellato:

+1

Jacopo

On Sat, Sep 26, 2020 at 6:35 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:


Hi

I am using userLogin service to authenticate users before generating auth
tokens for REST API and GraphQL calls. However, I figured that a session is
also getting created and returned in response which is defeating the
purpose of having an API in place. Even though that session is not getting
used anywhere when subsequent calls are made using the token, I still think
it is an extra session lying around in tomcat's session cache.

I propose to implement a new basic userLogin service (basicAuthUserLogin)
that would just do username/password matching and be done with it without
ever calling request.getSession(). This will ensure that APIs are stateless
and no session is generated.

Anything else you think should be part of the new service instead of just
username/password validation?

Best,
Girish
HotWax Systems





smime.p7s
Description: S/MIME Cryptographic Signature

Re: [PROPOSAL] Separate login service for API calls

[Jacopo Cappellato]

+1

Jacopo

On Sat, Sep 26, 2020 at 6:35 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi
>
> I am using userLogin service to authenticate users before generating auth
> tokens for REST API and GraphQL calls. However, I figured that a session is
> also getting created and returned in response which is defeating the
> purpose of having an API in place. Even though that session is not getting
> used anywhere when subsequent calls are made using the token, I still think
> it is an extra session lying around in tomcat's session cache.
>
> I propose to implement a new basic userLogin service (basicAuthUserLogin)
> that would just do username/password matching and be done with it without
> ever calling request.getSession(). This will ensure that APIs are stateless
> and no session is generated.
>
> Anything else you think should be part of the new service instead of just
> username/password validation?
>
> Best,
> Girish
> HotWax Systems
>

Re: OFBiz as OMS

[Pranay Pandey]

Thank you Devanshu.

Just a reminder for all that we are going to do a session today at 4:00 PM
on Real-time inventory visibility. I will post the meeting URL on this
thread at 3:55 PM.

Best regards,
Pranay Pandey


On Sat, Sep 26, 2020 at 9:14 PM Devanshu Vyas 
wrote:

> Hello, We just finished our first discussion on OFBiz as Open Source OMS.
> Thank you to all the participants joining in. The video is now published on
> the OFBiz Youtube Channel. Here is the link: https://youtu.be/37E777O7050
> This will be a series of videos where we will be discussing this topic.
> Here is the link for the playlist:
> https://www.youtube.com/playlist?list=PLobIkeUbRXqe7YKSOdrXTrbRlCa7xvyGe
>
> We have finalized a schedule to continue our discussions on this topic,
> which is every Tuesday at 4 PM IST.
> 29th September 2020 Real-time inventory visibility
> 6th October 2020 Order routing to a facility for fulfilment
> 13th October 2020 Order splitting of available items for faster fulfilment
> 20th October 2020 Fulfilment application to be used at Stores(BOSS - Buy
> Online Ship-to-Store)
> 27th October 2020 Store inventory management
> 3rd November 2020 Integrations with applications like BOPIS(Buy Online and
> Pick in Store), BORIS(Buy Online Return in Store), and Endless Aisle.
> 10th November 2020 Preorder and Backorder Management
>
> @Deepak, It was an impromptu session, and at the last minute, we thought of
> including anyone who wants to join.
> I have prepared and shared the schedule of each discussion we will be doing
> on this topic.
>
> @Joseph, I hope to see you in the next discussion.
>
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Sat, Sep 26, 2020 at 5:40 PM Deepak Dixit 
> wrote:
>
> > Hi Devanshu,
> >
> > It'd be good if you share this kind of information little early, In the
> > planned way you will get more participation.
> >
> >
> > Kind Regards,
> > Deepak Dixit
> >
> >
> >
> > On Sat, Sep 26, 2020 at 4:12 PM Devanshu Vyas  >
> > wrote:
> >
> > > Hello,
> > >
> > > We are going to start the discussion on 'OFBiz as OMS' today at 4:30 PM
> > > IST. If you are interested in joining, please share your interest here
> > and
> > > I'll send you a link.
> > >
> > > Thanks & Regards,
> > > Devanshu Vyas.
> > >
> >
>