Re: New Helveticus theme as default

2021-09-09 Thread Nicolas Malin
With the last commit [1] on the login page, I agree to use Helveticus as
default.

For the reading from right I will happy to improve this theme if some
people want to go on this way. An other word : all contribution are
welcome :D

Nicolas


[1]
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=4bb54a1d1cbe1ac78148cb9211fb992f05f66ce1

On 30/08/2021 09:40, Jacques Le Roux wrote:
> Hi,
>
> Should we not make Helveticus the trunk theme default now?
>
> I note that Flat Grey has still a lot of attention on demos. Because,
> unlike other themes, it can be used by people reading from right to
> left...
>
> Jacques
>
> Le 23/07/2021 à 12:19, Nicolas Malin a écrit :
>> Yes sur Jacques, we will work on it
>>
>> Nicolas
>>
>> On 22/07/2021 14:22, Jacques Le Roux wrote:
>>> Thanks Nicolas,
>>>
>>> Before making it the default, I suggest few points:
>>>
>>> Add themes description:
>>> https://github.com/apache/ofbiz-framework/commit/0a919960904ffd037508ed05bd4b2bf9c2268b6d/
>>>
>>>
>>> Fix the remaining subtasks at
>>> https://issues.apache.org/jira/browse/OFBIZ-12276
>>>
>>> TIA
>>>
>>> Jacques
>>>
>>> Le 22/07/2021 à 11:21, Nicolas Malin a écrit :
 Hello,

 I just commit some Marine's improvement [1]  with your suggests
 increase
 the contrast on blue and add multiple color as rainbowstone.

 I think it's a good step to set as default theme :)

 Cheers,

 Nicolas

 [1]
 https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1d2902b

 On 07/07/2021 09:58, Jacques Le Roux wrote:
> Hi,
>
> OK, no problems.
>
> For Eugen's concern, maybe it's possible to have several colours like
> with Rainbow Stone?
>
> Jacques
>
> Le 07/07/2021 à 09:07, Nicolas Malin a écrit :
>> Hello,
>>
>> I suggest to wait some week, Marine who create this theme is
>> currently
>> off. I will share your remark upon her return.
>>
>> Nicolas
>>
>> On 07/07/2021 07:47, Eugen Stan wrote:
>>> The new theme looks good, the only thing that bothers me is the
>>> light
>>> blue text on white background - which is not very readable, esp. in
>>> high resolution (1080p).
>>>
>>>
>>> See here a screen capture:
>>> https://i.postimg.cc/HxcFKLt1/Captur-de-ecran-de-la-2021-07-07-08-41-31.png
>>>
>>>
>>>
>>> .
>>>
>>> I tried it on laptop 14" screen and also on a DELL desktop monitor.
>>>
>>> I think the issue is with the color contrast (light blue + white
>>> background) + small text on the accounting app main page.
>>>


Re: Groovy integration tests

2021-09-09 Thread Nicolas Malin
I endorse the words,

I currently implement some new test for
https://issues.apache.org/jira/browse/OFBIZ-6988, and after 3 hours to
build ofbiz, it's really boring without clear most valuable.

If for technical best practice it's better to keep test compile, it's
possible when you test write is terminate to move the groovy-test-suite
to junit-test-suite, so no reason to remove the possibility to write
test as script.

Nicolas

On 08/09/2021 15:30, Gil Portenseigne wrote:
> Hello,
>
> Currently using release 18.12 for some project we got the habit to
> develop using integration test while developing in groovy.
>
> For that usage we use mainly :
> groovy-test-suite
>
> That allow coding tests in groovy script that do not need to be compiled
> for their execution and executing them from webtools [1] (small
> improvement will be contributed soon), there is no need to reboot the
> local dev OFBiz instance for each modification in that test.
>
> But these type of test has been removed with OFBIZ-11165 [2], while I
> thinks that these resources are better compiled, during development
> process, not having to restart OFBiz is nice.
>
> So if nobody is against, I will reintroduce it in trunk with a note
> explaining the `dev` usage.
>
> WDYT
>
> Regards,
>
> Gil
>
> [1] https://localhost:8443/webtools/control/TestSuiteInfo
> [2] https://issues.apache.org/jira/browse/OFBIZ-11165