[jira] [Created] (OFBIZ-4847) webtools doesn't treat "Date" field properly
Leon created OFBIZ-4847: --- Summary: webtools doesn't treat "Date" field properly Key: OFBIZ-4847 URL: https://issues.apache.org/jira/browse/OFBIZ-4847 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk if a entity field type is "Date" (-MM-DD), in edit or create form of webtools, the component of this field is redered as "timestamp". Update the ViewGeneric.ftl to change the related "shortDateInput" from false to true will resolve this problem. see attached patch file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4847) webtools doesn't treat "Date" field properly
[ https://issues.apache.org/jira/browse/OFBIZ-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4847: Attachment: OFBIZ-4847.patch > webtools doesn't treat "Date" field properly > > > Key: OFBIZ-4847 > URL: https://issues.apache.org/jira/browse/OFBIZ-4847 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4847.patch > > > if a entity field type is "Date" (-MM-DD), in edit or create form of > webtools, the component of this field is redered as "timestamp". > Update the ViewGeneric.ftl to change the related "shortDateInput" from false > to true will resolve this problem. see attached patch file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
Leon created OFBIZ-4856: --- Summary: webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup Key: OFBIZ-4856 URL: https://issues.apache.org/jira/browse/OFBIZ-4856 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Fix For: SVN trunk Attachments: OFBIZ-4856.patch During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4856: Attachment: OFBIZ-4856.patch > webapp "tempfiles" is not successfully loaded because of > java.io.FileNotFoundException during startup > - > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when > ofbiz trying to load webapp "tempfiles" which is defined by framework/images > component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not > exist from the very first, catalina container will use default web.xml > instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" > and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4849) YUI Compressor conflict with BIRT
[ https://issues.apache.org/jira/browse/OFBIZ-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269262#comment-13269262 ] Leon commented on OFBIZ-4849: - I met this issue too. Is that safe to remove yui library? > YUI Compressor conflict with BIRT > - > > Key: OFBIZ-4849 > URL: https://issues.apache.org/jira/browse/OFBIZ-4849 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Ubuntu 10.04 >Reporter: Chatree Srichart > Labels: BIRT, yuicompressor > Original Estimate: 8h > Remaining Estimate: 8h > > I got a problem when I entered an example report which has been created using > BIRT https://demo-trunk.ofbiz.apache.org:8443/example/control/Report > I got an error message: Invalid javascript expression: dataSetRow["exampleId"] > This is a Mozilla JavaScript problem. > Actually BIRT has a proper library for that, framework/birt/lib/js.jar, but > it is conflicted by YUI Compressor library, > framework/base/lib/yuicompressor-2.4.6.jar . If I take the YUI Compressor > library out then the example report works fine. > I see that in the YUI Compressor library contains org.mozilla.javascript > package which duplicate with BIRT but I think it is different version. > Regards, > Chatree Srichart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4849) YUI Compressor conflict with BIRT
[ https://issues.apache.org/jira/browse/OFBIZ-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269602#comment-13269602 ] Leon commented on OFBIZ-4849: - See. Thanks. So, the lib is only used by particular ant target, is there any way to put it under another seperated place except framework and load it on the fly? > YUI Compressor conflict with BIRT > - > > Key: OFBIZ-4849 > URL: https://issues.apache.org/jira/browse/OFBIZ-4849 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Ubuntu 10.04 >Reporter: Chatree Srichart > Labels: BIRT, yuicompressor > Original Estimate: 8h > Remaining Estimate: 8h > > I got a problem when I entered an example report which has been created using > BIRT https://demo-trunk.ofbiz.apache.org:8443/example/control/Report > I got an error message: Invalid javascript expression: dataSetRow["exampleId"] > This is a Mozilla JavaScript problem. > Actually BIRT has a proper library for that, framework/birt/lib/js.jar, but > it is conflicted by YUI Compressor library, > framework/base/lib/yuicompressor-2.4.6.jar . If I take the YUI Compressor > library out then the example report works fine. > I see that in the YUI Compressor library contains org.mozilla.javascript > package which duplicate with BIRT but I think it is different version. > Regards, > Chatree Srichart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
Leon created OFBIZ-4865:
---
Summary: Exception there when trying to update order's "Shipping
Destination Address"
Key: OFBIZ-4865
URL: https://issues.apache.org/jira/browse/OFBIZ-4865
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Leon
If click the "update" button of "Shipping Destination Address" in order view
page, an exception thrown out as:
{quote}
The Following Errors Occurred:
BeanShell execution caused an error: Sourced file: inline evaluation of: ``
shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
{quote}
I'm not familiar with beanshell and the mechanism of how ofbiz handling it, but
I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4865:
Attachment: OFBIZ-4856.patch
> Exception there when trying to update order's "Shipping Destination Address"
>
>
> Key: OFBIZ-4865
> URL: https://issues.apache.org/jira/browse/OFBIZ-4865
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
> Attachments: OFBIZ-4856.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view
> page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: ``
> shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
> but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276739#comment-13276739
]
Leon commented on OFBIZ-4865:
-
I searched the log and find the root cause is
"java.lang.ArrayIndexOutOfBoundsException" from bsh script. As Paul told, there
should be at least two "@" chars in "shipmentmethod" value. So I guess maybe
somewhere "@" is missing. I tried to lookup for codes which construct
parameters map for calling, and fortunately, I found it.
See attached patch for detail.
Thanks you all.
> Exception there when trying to update order's "Shipping Destination Address"
>
>
> Key: OFBIZ-4865
> URL: https://issues.apache.org/jira/browse/OFBIZ-4865
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
> Attachments: OFBIZ-4856.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view
> page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: ``
> shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
> but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4865:
Attachment: (was: OFBIZ-4856.patch)
> Exception there when trying to update order's "Shipping Destination Address"
>
>
> Key: OFBIZ-4865
> URL: https://issues.apache.org/jira/browse/OFBIZ-4865
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
> Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view
> page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: ``
> shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
> but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4865:
Attachment: OFBIZ-4865.patch
> Exception there when trying to update order's "Shipping Destination Address"
>
>
> Key: OFBIZ-4865
> URL: https://issues.apache.org/jira/browse/OFBIZ-4865
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
> Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view
> page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: ``
> shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
> but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4865) Exception there when trying to update order's "Shipping Destination Address"
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276800#comment-13276800
]
Leon commented on OFBIZ-4865:
-
Adrian, Sorry for that. This one is correct.
> Exception there when trying to update order's "Shipping Destination Address"
>
>
> Key: OFBIZ-4865
> URL: https://issues.apache.org/jira/browse/OFBIZ-4865
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
> Attachments: OFBIZ-4865.patch
>
>
> If click the "update" button of "Shipping Destination Address" in order view
> page, an exception thrown out as:
> {quote}
> The Following Errors Occurred:
> BeanShell execution caused an error: Sourced file: inline evaluation of: ``
> shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
> {quote}
> I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
> but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4911) very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
Leon created OFBIZ-4911:
---
Summary: very trivial update to fieldlookup.js in case of "null
object" failure for wierd unknonw reason
Key: OFBIZ-4911
URL: https://issues.apache.org/jira/browse/OFBIZ-4911
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Priority: Trivial
Fix For: SVN trunk
I cannot find the root cause and it's hard to reproduce, but it does happen
sometimes. The web browser reports "null object" exception when it tries to
evaluate following codes in fieldlookup.js:
{quote}
var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
{quote}
window.opener is there but window.opener.lookups is null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4911) very trivial update to fieldlookup.js in case of "null object" failure for wierd unknonw reason
[
https://issues.apache.org/jira/browse/OFBIZ-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4911:
Attachment: OFBIZ-4911.patch
> very trivial update to fieldlookup.js in case of "null object" failure for
> wierd unknonw reason
> ---
>
> Key: OFBIZ-4911
> URL: https://issues.apache.org/jira/browse/OFBIZ-4911
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4911.patch
>
>
> I cannot find the root cause and it's hard to reproduce, but it does happen
> sometimes. The web browser reports "null object" exception when it tries to
> evaluate following codes in fieldlookup.js:
> {quote}
> var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
> {quote}
> window.opener is there but window.opener.lookups is null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4948) Render checkbox field as same behavior as radiobox
Leon created OFBIZ-4948: --- Summary: Render checkbox field as same behavior as radiobox Key: OFBIZ-4948 URL: https://issues.apache.org/jira/browse/OFBIZ-4948 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk when rendering a radio field in form widget, the generated html codes looks like: blahblah. The radio box and its description are wrapped by and it's easy to change css style for both of them (radio and description), not only for radio type input. But the check box is rendered in another way without around. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4948) Render checkbox field as same behavior as radiobox
[ https://issues.apache.org/jira/browse/OFBIZ-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4948: Attachment: OFBIZ-4948.patch > Render checkbox field as same behavior as radiobox > -- > > Key: OFBIZ-4948 > URL: https://issues.apache.org/jira/browse/OFBIZ-4948 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4948.patch > > > when rendering a radio field in form widget, the generated html codes looks > like: blahblah. The radio box and its > description are wrapped by and it's easy to change css style for both > of them (radio and description), not only for radio type input. But the check > box is rendered in another way without around. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.
Leon created OFBIZ-4950: --- Summary: Lookup filed with target-parameter attribute set cannot be displayed. Key: OFBIZ-4950 URL: https://issues.apache.org/jira/browse/OFBIZ-4950 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4950.patch if field has attribute "target-parameter" set, then there's javascript error in front end and lookup icon disappears. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.
[ https://issues.apache.org/jira/browse/OFBIZ-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4950: Attachment: OFBIZ-4950.patch > Lookup filed with target-parameter attribute set cannot be displayed. > - > > Key: OFBIZ-4950 > URL: https://issues.apache.org/jira/browse/OFBIZ-4950 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4950.patch > > > if field has attribute "target-parameter" set, then there's > javascript error in front end and lookup icon disappears. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4951) "entity/src" ommited in .classpath that makes project built failed in eclipse.
Leon created OFBIZ-4951: --- Summary: "entity/src" ommited in .classpath that makes project built failed in eclipse. Key: OFBIZ-4951 URL: https://issues.apache.org/jira/browse/OFBIZ-4951 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk in latest revision of trunk, the classpathentry of "entity/src" is removed for some reason, it causes eclipse unalbe to build project successfully. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4951) "entity/src" ommited in .classpath that makes project built failed in eclipse.
[ https://issues.apache.org/jira/browse/OFBIZ-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4951: Attachment: OFBIZ-4951.patch > "entity/src" ommited in .classpath that makes project built failed in eclipse. > -- > > Key: OFBIZ-4951 > URL: https://issues.apache.org/jira/browse/OFBIZ-4951 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4951.patch > > > in latest revision of trunk, the classpathentry of "entity/src" is removed > for some reason, it causes eclipse unalbe to build project successfully. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
[
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon reopened OFBIZ-4281:
-
after fieildlookup.js refacoring reacently, this bug occurs again.
> parse javascript link wrongly in lookup layer dialog if there's slash '/' in
> data
> -
>
> Key: OFBIZ-4281
> URL: https://issues.apache.org/jira/browse/OFBIZ-4281
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Assignee: Sascha Rodekamp
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js.patch
>
>
> e.g. in lookup dialog (in layer mode), one href value of a link is
> "javascript:set_value('123/ABC');", then the ofbiz framework will parse it to
> "javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong.
> Correct one should be given href itself.
> to fix:
> judge whether the link contains "javascript:set_" before split it by slash
> '/'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4969) IndexOutOfBoundsException thrown by ServerHitBin.countHit
Leon created OFBIZ-4969:
---
Summary: IndexOutOfBoundsException thrown by ServerHitBin.countHit
Key: OFBIZ-4969
URL: https://issues.apache.org/jira/browse/OFBIZ-4969
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Priority: Trivial
Fix For: SVN trunk
Never happened before, but reacently, this weird exception thrown out when
initiated a "json" request.
{quote}
229156224 [http-bio-0.0.0.0-443-exec-6138] ERROR
org.ofbiz.webapp.control.ControlServlet -
runtime exception report --
Error in request handler:
Exception: java.lang.IndexOutOfBoundsException
Message: index: 0
stack trace ---
java.lang.IndexOutOfBoundsException: index: 0
javolution.util.FastList.add(FastList.java:228)
org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:210)
org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:84)
org.ofbiz.webapp.stats.ServerHitBin.countEvent(ServerHitBin.java:66)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:409)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
..
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4969) IndexOutOfBoundsException thrown by ServerHitBin.countHit
[
https://issues.apache.org/jira/browse/OFBIZ-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4969:
Attachment: OFBIZ-4969.patch
"binList.add(0, bin);" :
IndexOutOfBoundsException - if the index is out of range (index < 0 || index >
size())
> IndexOutOfBoundsException thrown by ServerHitBin.countHit
> -
>
> Key: OFBIZ-4969
> URL: https://issues.apache.org/jira/browse/OFBIZ-4969
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4969.patch
>
>
> Never happened before, but reacently, this weird exception thrown out when
> initiated a "json" request.
> {quote}
> 229156224 [http-bio-0.0.0.0-443-exec-6138] ERROR
> org.ofbiz.webapp.control.ControlServlet -
> runtime exception report
> --
> Error in request handler:
> Exception: java.lang.IndexOutOfBoundsException
> Message: index: 0
> stack trace
> ---
> java.lang.IndexOutOfBoundsException: index: 0
> javolution.util.FastList.add(FastList.java:228)
> org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:210)
> org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:84)
> org.ofbiz.webapp.stats.ServerHitBin.countEvent(ServerHitBin.java:66)
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:409)
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> ..
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4969) IndexOutOfBoundsException thrown by ServerHitBin.countHit
[
https://issues.apache.org/jira/browse/OFBIZ-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418322#comment-13418322
]
Leon commented on OFBIZ-4969:
-
same as this version:
https://fisheye6.atlassian.com/browse/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java?r=1337662
Just replace the line 210.
> IndexOutOfBoundsException thrown by ServerHitBin.countHit
> -
>
> Key: OFBIZ-4969
> URL: https://issues.apache.org/jira/browse/OFBIZ-4969
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4969.patch
>
>
> Never happened before, but reacently, this weird exception thrown out when
> initiated a "json" request.
> {quote}
> 229156224 [http-bio-0.0.0.0-443-exec-6138] ERROR
> org.ofbiz.webapp.control.ControlServlet -
> runtime exception report
> --
> Error in request handler:
> Exception: java.lang.IndexOutOfBoundsException
> Message: index: 0
> stack trace
> ---
> java.lang.IndexOutOfBoundsException: index: 0
> javolution.util.FastList.add(FastList.java:228)
> org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:210)
> org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:84)
> org.ofbiz.webapp.stats.ServerHitBin.countEvent(ServerHitBin.java:66)
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:409)
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)
> org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> ..
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4970) correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
Leon created OFBIZ-4970: --- Summary: correct "javascript:void();" to "javascript:void(0);" to make it syntax valid Key: OFBIZ-4970 URL: https://issues.apache.org/jira/browse/OFBIZ-4970 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4970.patch Firefox will throw syntax error if you call javascript void function without parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4970) correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
[ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4970: Attachment: OFBIZ-4970.patch > correct "javascript:void();" to "javascript:void(0);" to make it syntax valid > - > > Key: OFBIZ-4970 > URL: https://issues.apache.org/jira/browse/OFBIZ-4970 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4970.patch > > > Firefox will throw syntax error if you call javascript void function without > parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4970) correct "javascript:void();" to "javascript:void(0);" to make it syntax valid
[ https://issues.apache.org/jira/browse/OFBIZ-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4970: Attachment: screenshot-1.jpg field now supports "clear" function, but if you try to "clear", you will get syntax error. > correct "javascript:void();" to "javascript:void(0);" to make it syntax valid > - > > Key: OFBIZ-4970 > URL: https://issues.apache.org/jira/browse/OFBIZ-4970 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4970.patch, screenshot-1.jpg > > > Firefox will throw syntax error if you call javascript void function without > parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5007) how about add a default implementation for deQueue() in AbstractJob?
Leon created OFBIZ-5007:
---
Summary: how about add a default implementation for deQueue() in
AbstractJob?
Key: OFBIZ-5007
URL: https://issues.apache.org/jira/browse/OFBIZ-5007
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Priority: Trivial
Fix For: SVN trunk
Although I do not use "workflow" component and no ant build error there since
it's comment out as default, there're some kind of java error in eclipse build.
It is because org.ofbiz.workflow.client.StartActivityJob and
org.ofbiz.workflow.WorkflowRunner extend AbstractJob but do not implement Job
interface method - deQueue which is added recently.
Is it better to add following code to Abstract.java or to implement deQueue in
each concrete class?
{code:java}
@Override
public void deQueue() throws InvalidJobException {
if (currentState != State.QUEUED) {
throw new InvalidJobException("Illegal state change");
}
this.currentState = State.CREATED;
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5007) how about add a default implementation for deQueue() in AbstractJob?
[
https://issues.apache.org/jira/browse/OFBIZ-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-5007:
Attachment: OFBIZ-5007.patch
> how about add a default implementation for deQueue() in AbstractJob?
>
>
> Key: OFBIZ-5007
> URL: https://issues.apache.org/jira/browse/OFBIZ-5007
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5007.patch
>
>
> Although I do not use "workflow" component and no ant build error there since
> it's comment out as default, there're some kind of java error in eclipse
> build. It is because org.ofbiz.workflow.client.StartActivityJob and
> org.ofbiz.workflow.WorkflowRunner extend AbstractJob but do not implement Job
> interface method - deQueue which is added recently.
> Is it better to add following code to Abstract.java or to implement deQueue
> in each concrete class?
> {code:java}
> @Override
> public void deQueue() throws InvalidJobException {
> if (currentState != State.QUEUED) {
> throw new InvalidJobException("Illegal state change");
> }
> this.currentState = State.CREATED;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5008) tomcat lib upgrade, but .classpath (r1361130) not.
[ https://issues.apache.org/jira/browse/OFBIZ-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5008: Attachment: OFBIZ-5008.patch > tomcat lib upgrade, but .classpath (r1361130) not. > -- > > Key: OFBIZ-5008 > URL: https://issues.apache.org/jira/browse/OFBIZ-5008 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-5008.patch > > > trivial update to .classpath to modify tomcat library version from "7.0.28." > to "7.0.29-" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5008) tomcat lib upgrade, but .classpath (r1361130) not.
Leon created OFBIZ-5008: --- Summary: tomcat lib upgrade, but .classpath (r1361130) not. Key: OFBIZ-5008 URL: https://issues.apache.org/jira/browse/OFBIZ-5008 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-5008.patch trivial update to .classpath to modify tomcat library version from "7.0.28." to "7.0.29-" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5025) jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: Attachment: OFBIZ-5025.patch > jquery validator localization looks for "messages_cn.js" for locale zh_CN and > "_tw" for zh_TW > - > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn > or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate > correct file url for zh_CN and zh_TW. Besides, a uptodate > JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is > also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5025) jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW
Leon created OFBIZ-5025: --- Summary: jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW Key: OFBIZ-5025 URL: https://issues.apache.org/jira/browse/OFBIZ-5025 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-5025.patch it's weird that jquery validator localization does not treat "zh_CN" as zhcn or zh-cn but "cn", neither does zh_TW. Trivial update to JsLanguageFileMappingCreator.java to make it generate correct file url for zh_CN and zh_TW. Besides, a uptodate JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5025) jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: Attachment: (was: OFBIZ-5025.patch) > jquery validator localization looks for "messages_cn.js" for locale zh_CN and > "_tw" for zh_TW > - > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Erwan de FERRIERES >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn > or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate > correct file url for zh_CN and zh_TW. Besides, a uptodate > JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is > also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5025) jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5025: Attachment: OFBIZ-5025.patch > jquery validator localization looks for "messages_cn.js" for locale zh_CN and > "_tw" for zh_TW > - > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Erwan de FERRIERES >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn > or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate > correct file url for zh_CN and zh_TW. Besides, a uptodate > JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is > also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5025) jquery validator localization looks for "messages_cn.js" for locale zh_CN and "_tw" for zh_TW
[ https://issues.apache.org/jira/browse/OFBIZ-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447457#comment-13447457 ] Leon commented on OFBIZ-5025: - hi, Erwan, please try the new patch. Since these two files is in DOS format, the patch file generated from windows cannot be recognized correctly in unix. I re-diff them from unix and test it through. > jquery validator localization looks for "messages_cn.js" for locale zh_CN and > "_tw" for zh_TW > - > > Key: OFBIZ-5025 > URL: https://issues.apache.org/jira/browse/OFBIZ-5025 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Erwan de FERRIERES >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5025.patch > > > it's weird that jquery validator localization does not treat "zh_CN" as zhcn > or zh-cn but "cn", neither does zh_TW. > Trivial update to JsLanguageFileMappingCreator.java to make it generate > correct file url for zh_CN and zh_TW. Besides, a uptodate > JsLanguageFilesMapping.java created by service createJsLanguageFileMapping is > also packaged into patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order
Leon created OFBIZ-5038: --- Summary: Internal notes and shipping notes are lost when input an order Key: OFBIZ-5038 URL: https://issues.apache.org/jira/browse/OFBIZ-5038 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last. The estimated delivery before/after date are not correctly set either in "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5039) Internal notes and shipping notes are lost when input an order
Leon created OFBIZ-5039: --- Summary: Internal notes and shipping notes are lost when input an order Key: OFBIZ-5039 URL: https://issues.apache.org/jira/browse/OFBIZ-5039 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk when we try to create an order, we can input internal note and shipping note in "option" form. But those information is lost when we come back to "option" setting form or when we create the order at last. The estimated delivery before/after date are not correctly set either in "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OFBIZ-5039) Internal notes and shipping notes are lost when input an order
[ https://issues.apache.org/jira/browse/OFBIZ-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon resolved OFBIZ-5039. - Resolution: Duplicate Dup with #OFBIZ-5038. > Internal notes and shipping notes are lost when input an order > -- > > Key: OFBIZ-5039 > URL: https://issues.apache.org/jira/browse/OFBIZ-5039 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > > when we try to create an order, we can input internal note and shipping note > in "option" form. But those information is lost when we come back to "option" > setting form or when we create the order at last. > The estimated delivery before/after date are not correctly set either in > "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5039) Internal notes and shipping notes are lost when input an order
[ https://issues.apache.org/jira/browse/OFBIZ-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458368#comment-13458368 ] Leon commented on OFBIZ-5039: - Dup with #OFBIZ-5038. sorry for duplicated submit. please close this one, thanks. > Internal notes and shipping notes are lost when input an order > -- > > Key: OFBIZ-5039 > URL: https://issues.apache.org/jira/browse/OFBIZ-5039 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > > when we try to create an order, we can input internal note and shipping note > in "option" form. But those information is lost when we come back to "option" > setting form or when we create the order at last. > The estimated delivery before/after date are not correctly set either in > "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order
[ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5038: Attachment: OFBIZ-5038.patch 1. submit internal notes and shipping notes to order cart 2. display estimated shipping before and after date 3. avoid adding internal notes and shipping notes multiple times if submit options repeatedly 4. make it possible to empty internal note or shipping note > Internal notes and shipping notes are lost when input an order > -- > > Key: OFBIZ-5038 > URL: https://issues.apache.org/jira/browse/OFBIZ-5038 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5038.patch > > > when we try to create an order, we can input internal note and shipping note > in "option" form. But those information is lost when we come back to "option" > setting form or when we create the order at last. > The estimated delivery before/after date are not correctly set either in > "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471375#comment-13471375 ] Leon commented on OFBIZ-2628: - it solves the "DVD+R" problem, but seems not solve ""Bäume" problem, anything I missed? > No Url encoding for get parameters > -- > > Key: OFBIZ-2628 > URL: https://issues.apache.org/jira/browse/OFBIZ-2628 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk > Environment: All >Reporter: Patrick Antivackis >Assignee: Sascha Rodekamp >Priority: Critical > Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, > Release Branch 12.04 > > Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-encoding-hidden-post-params (list forms).patch, > OFBIZ-2628-encoding-hidden-post-params (list forms).patch, > OFBIZ-2628-encoding-hidden-post-params.patch, > OFBIZ-2628-encoding-request-and-hidden-params.patch, > OFBIZ-2628-encoding-request-redirect-params.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > Let's say I want to create a new category which ID is DVD+R > Creation is ok through the admin interface, but whenever i want to access > this category, the get parameter productCategoryId= of the url is wrong > as it's not url encoded, so we have : > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R > instead of > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR > Both <@ofbizUrl> tag and menu widgets are not encoding get parameters. > Way to correct : > framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the > makeLink function > framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function > buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of > simpleEncoder > Beofre i do the fix, can a core developper let me know about possible side > effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471375#comment-13471375 ] Leon edited comment on OFBIZ-2628 at 10/8/12 3:07 AM: -- it solves the "DVD+R" problem, but seems not solve ""Bäume" problem, anything I missed? --yeah, I missed the patch to CatalinaContainer.java. Thanks Wojciech Szymanowski. was (Author: utcb): it solves the "DVD+R" problem, but seems not solve ""Bäume" problem, anything I missed? > No Url encoding for get parameters > -- > > Key: OFBIZ-2628 > URL: https://issues.apache.org/jira/browse/OFBIZ-2628 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk > Environment: All >Reporter: Patrick Antivackis >Assignee: Sascha Rodekamp >Priority: Critical > Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, > Release Branch 12.04 > > Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-encoding-hidden-post-params (list forms).patch, > OFBIZ-2628-encoding-hidden-post-params (list forms).patch, > OFBIZ-2628-encoding-hidden-post-params.patch, > OFBIZ-2628-encoding-request-and-hidden-params.patch, > OFBIZ-2628-encoding-request-redirect-params.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > Let's say I want to create a new category which ID is DVD+R > Creation is ok through the admin interface, but whenever i want to access > this category, the get parameter productCategoryId= of the url is wrong > as it's not url encoded, so we have : > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R > instead of > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR > Both <@ofbizUrl> tag and menu widgets are not encoding get parameters. > Way to correct : > framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the > makeLink function > framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function > buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of > simpleEncoder > Beofre i do the fix, can a core developper let me know about possible side > effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5038) Internal notes and shipping notes are lost when input an order
[ https://issues.apache.org/jira/browse/OFBIZ-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472254#comment-13472254 ] Leon commented on OFBIZ-5038: - 3. avoid adding internal notes and shipping notes multiple times if submit options repeatedly These two lines code will clear notes buffer before new notes added. Otherwise, if you go back and forth between "options" tab and other tabs, you will get more than one internal notes and shipping notes at last. > Internal notes and shipping notes are lost when input an order > -- > > Key: OFBIZ-5038 > URL: https://issues.apache.org/jira/browse/OFBIZ-5038 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5038.patch > > > when we try to create an order, we can input internal note and shipping note > in "option" form. But those information is lost when we come back to "option" > setting form or when we create the order at last. > The estimated delivery before/after date are not correctly set either in > "option" form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3575) Union view entity support
[ https://issues.apache.org/jira/browse/OFBIZ-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472869#comment-13472869 ] Leon commented on OFBIZ-3575: - Either do I^^ > Union view entity support > - > > Key: OFBIZ-3575 > URL: https://issues.apache.org/jira/browse/OFBIZ-3575 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: SVN trunk >Reporter: Bob Morley >Assignee: Adam Heath > Attachments: OFBIZ-3575_UnionViewEntitySupport.patch > > > As per conversion titled "entity-engine union support" > (http://n4.nabble.com/entity-engine-union-support-td1607240.html#a1607240); > here is the basic union support that we had added into our Ofbiz project. I > have changed a little of the xml schema here ... the premise is that a > "UnionViewEntity" extends the standard "ViewEntity" and contains a list of > union members that it will union together. There should only be changes to > the ModelReader to instantiate the new model object and then in SqlJdbcUtil > to handle generating the new sql for unions. I have included a very small > unit test that executes a findList against a test union. > Here is sample sql that was generated: > SELECT uva.UNION_ID, uva.TESTING_NAME, uva.TESTING_SIZE, uva.TESTING_DATE > FROM ( SELECT T1.TESTING_ID AS UNION_ID, T1.TESTING_NAME AS TESTING_NAME, > T1.TESTING_SIZE AS TESTING_SIZE, T1.TESTING_DATE AS TESTING_DATE FROM TESTING > T1 UNION SELECT T2.TESTING_TYPE_ID AS UNION_ID, T2.TESTING_NAME AS > TESTING_NAME, T2.TESTING_SIZE AS TESTING_SIZE, T2.TESTING_DATE AS > TESTING_DATE FROM TESTING T2 ) uva -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5053) correct BIRT_VIEWER_SCRIPTLIB_DIR configuration
Leon created OFBIZ-5053: --- Summary: correct BIRT_VIEWER_SCRIPTLIB_DIR configuration Key: OFBIZ-5053 URL: https://issues.apache.org/jira/browse/OFBIZ-5053 Project: OFBiz Issue Type: Bug Components: specialpurpose/shark Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk birt has been move to specialpurpose but BIRT_VIEWER_SCRIPTLIB_DIR in web.xml is still configured to framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5053) correct BIRT_VIEWER_SCRIPTLIB_DIR configuration
[ https://issues.apache.org/jira/browse/OFBIZ-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5053: Attachment: OFBIZ-5053.patch > correct BIRT_VIEWER_SCRIPTLIB_DIR configuration > --- > > Key: OFBIZ-5053 > URL: https://issues.apache.org/jira/browse/OFBIZ-5053 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/shark >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-5053.patch > > > birt has been move to specialpurpose but BIRT_VIEWER_SCRIPTLIB_DIR in web.xml > is still configured to framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5068) slight update to ShoppingCartEvents.loadCartFromQuote to avoid NPE exception
Leon created OFBIZ-5068: --- Summary: slight update to ShoppingCartEvents.loadCartFromQuote to avoid NPE exception Key: OFBIZ-5068 URL: https://issues.apache.org/jira/browse/OFBIZ-5068 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk There's a quote within that one product has been released and no valid price set. If try to create order from this quote, NPE exception raised. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5068) slight update to ShoppingCartEvents.loadCartFromQuote to avoid NPE exception
[
https://issues.apache.org/jira/browse/OFBIZ-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-5068:
Attachment: OFBIZ-5068.patch
to check the result return from runSync("loadCartFromQuote")
> slight update to ShoppingCartEvents.loadCartFromQuote to avoid NPE exception
>
>
> Key: OFBIZ-5068
> URL: https://issues.apache.org/jira/browse/OFBIZ-5068
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5068.patch
>
>
> There's a quote within that one product has been released and no valid price
> set. If try to create order from this quote, NPE exception raised.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4958) Additional Validation for Password : Make password pattern driven
[ https://issues.apache.org/jira/browse/OFBIZ-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509474#comment-13509474 ] Leon commented on OFBIZ-4958: - very nice feature. Is there any conclusion? > Additional Validation for Password : Make password pattern driven > -- > > Key: OFBIZ-4958 > URL: https://issues.apache.org/jira/browse/OFBIZ-4958 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Sumit Pandit >Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-4958.patch, OFBIZ-4958.patch > > > Providing an additional validation for password - > Idea is to achieve following - > * Insist user to provide a stronger login password for additional protection. > * User's password need to match a pre-defined Pattern. > * Password pattern can change any time. > * Validation should applied for new user creation and update password > processes. > -- > Thanks And Regards > Sumit Pandit -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5097) jquery language mapping fix for japanese
[
https://issues.apache.org/jira/browse/OFBIZ-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531050#comment-13531050
]
Leon commented on OFBIZ-5097:
-
hi Naofumi,
Kindly remind you that the file you patched is an auto-generated by service
"createJsLanguageFileMapping".
There're two comments in this file:
// DO NOT EDIT THIS FILE! THIS IS AUTO GENERATED AND WILL GET WRITTEN OVER
PERIODICALLY WHEN THE DATA CHANGE
// Rather use the createJsLanguageFileMapping service to create or update
it. You will still need to compile thereafter
> jquery language mapping fix for japanese
>
>
> Key: OFBIZ-5097
> URL: https://issues.apache.org/jira/browse/OFBIZ-5097
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Naofumi Fukue
>Priority: Minor
> Attachments: JsLanguageFilesMapping.java.patch
>
>
> jQuery language mapping is not collect for japanese (datepicker). So date
> format is wrong in japanese.
> Index: framework/common/src/org/ofbiz/common/JsLanguageFilesMapping.java
> ===
> --- framework/common/src/org/ofbiz/common/JsLanguageFilesMapping.java
> (revision 1419381)
> +++ framework/common/src/org/ofbiz/common/JsLanguageFilesMapping.java
> (working copy)
> @@ -120,9 +120,9 @@
> localeFiles.put("it",
> "/images/jquery/plugins/datejs/date-it-IT.js");
> localeFiles.put("it_IT",
> "/images/jquery/plugins/datejs/date-it-IT.js");
> localeFiles.put("it_CH",
> "/images/jquery/plugins/datejs/date-it-CH.js");
> -localeFiles.put("ja",
> "/images/jquery/plugins/datejs/date-en-US.js");
> +localeFiles.put("ja",
> "/images/jquery/plugins/datejs/date-ja-JP.js");
> localeFiles.put("ja_JP",
> "/images/jquery/plugins/datejs/date-ja-JP.js");
> -localeFiles.put("ja_JP_JP",
> "/images/jquery/plugins/datejs/date-en-US.js");
> +localeFiles.put("ja_JP_JP",
> "/images/jquery/plugins/datejs/date-ja-JP.js");
> localeFiles.put("ko",
> "/images/jquery/plugins/datejs/date-en-US.js");
> localeFiles.put("ko_KR",
> "/images/jquery/plugins/datejs/date-ko-KR.js");
> localeFiles.put("lv",
> "/images/jquery/plugins/datejs/date-lv-LV.js");
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5115) wrong COUNT DISTINCT if there's GROUP BY clause
Leon created OFBIZ-5115: --- Summary: wrong COUNT DISTINCT if there's GROUP BY clause Key: OFBIZ-5115 URL: https://issues.apache.org/jira/browse/OFBIZ-5115 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk if there's a "group by" and distinct find options set, then the count of select returned is always the total number of non-distinct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5115) wrong COUNT DISTINCT if there's GROUP BY clause
[ https://issues.apache.org/jira/browse/OFBIZ-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5115: Attachment: OFBIZ-5115.patch > wrong COUNT DISTINCT if there's GROUP BY clause > --- > > Key: OFBIZ-5115 > URL: https://issues.apache.org/jira/browse/OFBIZ-5115 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5115.patch > > > if there's a "group by" and distinct find options set, then the count of > select returned is always the total number of non-distinct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5115) wrong COUNT DISTINCT if there's GROUP BY clause
[ https://issues.apache.org/jira/browse/OFBIZ-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540723#comment-13540723 ] Leon edited comment on OFBIZ-5115 at 12/29/12 1:57 AM: --- Jacques, We use OFBiz as the back-end framework of our LIMS (Laboratory Information Management System). It requires very heavy data statistics. In this case, we defined a static view entity to do some basic summary job and use "select" with distinct options to get desired result data-set. The data itself is no problem, but we found the total count it returned is always a little bigger than expected. After some research, we found the root cause: the SQL with group by implies to select all the fields to be grouped by, that's why "count" and /or "count(distinct)" does not work as usual. e.g. SELECT COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID -> its count result is same as SELECT COUNTRY_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID. and, SELECT COUNT(DISTINCT COUNTRY_GEO_ID) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID -> its data set result size equals that of SELECT COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID. was (Author: utcb): Jacques, We use OFBiz as the back-end framework of our LIMS (Laboratory Information Management System). It requires very heavy data statistics. In this case, we defined a static view entity to get some basic summary job and use "select" with distinct options to get desired result data-set. The data itself is no problem, but we found the total count it returned is always a little bigger than expected. After some research, we found the root cause: the SQL with group by implies to select all the fields to be grouped by, that's why "count" and /or "count(distinct)" does not work as usual. e.g. SELECT COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID -> its count result is same as SELECT COUNTRY_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID. and, SELECT COUNT(DISTINCT COUNTRY_GEO_ID) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID -> its data set result size equals that of SELECT COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID. > wrong COUNT DISTINCT if there's GROUP BY clause > --- > > Key: OFBIZ-5115 > URL: https://issues.apache.org/jira/browse/OFBIZ-5115 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5115.patch > > > if there's a "group by" and distinct find options set, then the count of > select returned is always the total number of non-distinct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5115) wrong COUNT DISTINCT if there's GROUP BY clause
[ https://issues.apache.org/jira/browse/OFBIZ-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540723#comment-13540723 ] Leon commented on OFBIZ-5115: - Jacques, We use OFBiz as the back-end framework of our LIMS (Laboratory Information Management System). It requires very heavy data statistics. In this case, we defined a static view entity to get some basic summary job and use "select" with distinct options to get desired result data-set. The data itself is no problem, but we found the total count it returned is always a little bigger than expected. After some research, we found the root cause: the SQL with group by implies to select all the fields to be grouped by, that's why "count" and /or "count(distinct)" does not work as usual. e.g. SELECT COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID -> its count result is same as SELECT COUNTRY_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID. and, SELECT COUNT(DISTINCT COUNTRY_GEO_ID) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID -> its data set result size equals that of SELECT COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID, COUNT(*) FROM POSTAL_ADDRESS GROUP BY COUNTRY_GEO_ID, STATE_PROVINCE_GEO_ID. > wrong COUNT DISTINCT if there's GROUP BY clause > --- > > Key: OFBIZ-5115 > URL: https://issues.apache.org/jira/browse/OFBIZ-5115 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5115.patch > > > if there's a "group by" and distinct find options set, then the count of > select returned is always the total number of non-distinct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5115) wrong COUNT DISTINCT if there's GROUP BY clause
[ https://issues.apache.org/jira/browse/OFBIZ-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542677#comment-13542677 ] Leon commented on OFBIZ-5115: - Dear Jacques, I know what you mean, but the entities we used is new created for our domain, not the OFBiz OOTB ones. That's why I demonstrate an example above. For materialized view you mentioned, it's really a great feature, but I doubt a little whether it will be too complex to keep data consistency, especially for those view with various join condition and complicated group by clause. > wrong COUNT DISTINCT if there's GROUP BY clause > --- > > Key: OFBIZ-5115 > URL: https://issues.apache.org/jira/browse/OFBIZ-5115 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-5115.patch > > > if there's a "group by" and distinct find options set, then the count of > select returned is always the total number of non-distinct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5127) add some omitted zh (CN) translation to OrderUiLables.xml
[ https://issues.apache.org/jira/browse/OFBIZ-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5127: Attachment: OFBIZ-5127.patch > add some omitted zh (CN) translation to OrderUiLables.xml > - > > Key: OFBIZ-5127 > URL: https://issues.apache.org/jira/browse/OFBIZ-5127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-5127.patch > > > Several new zh and zh_CN translations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5127) add some omitted zh (CN) translation to OrderUiLables.xml
Leon created OFBIZ-5127: --- Summary: add some omitted zh (CN) translation to OrderUiLables.xml Key: OFBIZ-5127 URL: https://issues.apache.org/jira/browse/OFBIZ-5127 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-5127.patch Several new zh and zh_CN translations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4378) unable to empty a datetime field
[ https://issues.apache.org/jira/browse/OFBIZ-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon closed OFBIZ-4378. --- Resolution: Invalid The up-to-date behavior of date-time form widget is : empty the field if there's any format error. So what I submitted before (WYSWYG) is out of season. > unable to empty a datetime field > > > Key: OFBIZ-4378 > URL: https://issues.apache.org/jira/browse/OFBIZ-4378 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: datetimeField.patch > > > In form which is designed by form widget, if there's datetime field, then you > can input datetime value directly or via jquery date picker. But whenever you > input a valid datetime, you're unable to empty it again. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5148) Bug introduced by OFBIZ-4769, it makes failed if the context contains incorrect data
Leon created OFBIZ-5148: --- Summary: Bug introduced by OFBIZ-4769, it makes failed if the context contains incorrect data Key: OFBIZ-5148 URL: https://issues.apache.org/jira/browse/OFBIZ-5148 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Critical Fix For: SVN trunk how to reproduce: 1. open "https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?create_new=Y"; (try to create a new party group) 2. input any words in group name field, input any "incorrect" non-digits characters (e.g. "abcd" blah blah) to field "Annual revenue" 3. click save It leads to an "exception" page instead of original input form with error message. I digged some codes and found it's related to r1426231 commit (of OFBIZ-4769). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5148) Bug introduced by OFBIZ-4769, it makes failed if the context contains incorrect data
[ https://issues.apache.org/jira/browse/OFBIZ-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5148: Attachment: OFBIZ-5148.patch Firstly, revert to r 941284 (before OFBIZ-4769), then apply what OFBIZ-4769 tried to fix in another approach. > Bug introduced by OFBIZ-4769, it makes failed if the context > contains incorrect data > - > > Key: OFBIZ-5148 > URL: https://issues.apache.org/jira/browse/OFBIZ-5148 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Jacques Le Roux >Priority: Critical > Fix For: SVN trunk > > Attachments: OFBIZ-5148.patch > > > how to reproduce: > 1. open > "https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?create_new=Y"; > (try to create a new party group) > 2. input any words in group name field, input any "incorrect" non-digits > characters (e.g. "abcd" blah blah) to field "Annual revenue" > 3. click save > It leads to an "exception" page instead of original input form with error > message. > I digged some codes and found it's related to r1426231 commit (of OFBIZ-4769). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5148) Bug introduced by OFBIZ-4769, it makes failed if the context contains incorrect data
[ https://issues.apache.org/jira/browse/OFBIZ-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598297#comment-13598297 ] Leon commented on OFBIZ-5148: - yes, Jacques, just apply the attached patch directly. > Bug introduced by OFBIZ-4769, it makes failed if the context > contains incorrect data > - > > Key: OFBIZ-5148 > URL: https://issues.apache.org/jira/browse/OFBIZ-5148 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Jacques Le Roux >Priority: Critical > Fix For: SVN trunk > > Attachments: OFBIZ-5148.patch > > > how to reproduce: > 1. open > "https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?create_new=Y"; > (try to create a new party group) > 2. input any words in group name field, input any "incorrect" non-digits > characters (e.g. "abcd" blah blah) to field "Annual revenue" > 3. click save > It leads to an "exception" page instead of original input form with error > message. > I digged some codes and found it's related to r1426231 commit (of OFBIZ-4769). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5167) each time file upload, a new sub directory is created under runtime/upload/ofbiz/
Leon created OFBIZ-5167: --- Summary: each time file upload, a new sub directory is created under runtime/upload/ofbiz/ Key: OFBIZ-5167 URL: https://issues.apache.org/jira/browse/OFBIZ-5167 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Leon Fix For: SVN trunk File cannot be upload today in one of our ofbiz deployment environment because the number of sub-folder under "runtime/uploads/ofbiz/" exceeds OS limit (CentOS, 32000 it is). Root cause: bug in DataResourceWorker.java. see attached patch for detail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5167) each time file upload, a new sub directory is created under runtime/upload/ofbiz/
[ https://issues.apache.org/jira/browse/OFBIZ-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-5167: Attachment: OFBIZ-5167.patch > each time file upload, a new sub directory is created under > runtime/upload/ofbiz/ > - > > Key: OFBIZ-5167 > URL: https://issues.apache.org/jira/browse/OFBIZ-5167 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: SVN trunk >Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-5167.patch > > > File cannot be upload today in one of our ofbiz deployment environment > because the number of sub-folder under "runtime/uploads/ofbiz/" exceeds OS > limit (CentOS, 32000 it is). > Root cause: bug in DataResourceWorker.java. see attached patch for detail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4101) i18n problem in auto-completed dropdown box: display not correct characters but html entities
i18n problem in auto-completed dropdown box: display not correct characters but html entities - Key: OFBIZ-4101 URL: https://issues.apache.org/jira/browse/OFBIZ-4101 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Windows 7, Eclipse, Java 6 Reporter: Leon Priority: Minor if there're chinese characters contained in a description field of a lookup textbox with auto-complete feature enabled, then what I can get from auto-completed dropdown box is not unstandable chinese but messed html entities such as "氨" blah blah. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4101) i18n problem in auto-completed dropdown box: display not correct characters but html entities
[ https://issues.apache.org/jira/browse/OFBIZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4101: Attachment: auto-completed-mess.png attach a screenshot. Although the screenshot was taken from product association form, this problem is exist in the places where the lookup+auto-completed text box used. > i18n problem in auto-completed dropdown box: display not correct characters > but html entities > - > > Key: OFBIZ-4101 > URL: https://issues.apache.org/jira/browse/OFBIZ-4101 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Windows 7, Eclipse, Java 6 >Reporter: Leon >Priority: Minor > Attachments: auto-completed-mess.png > > > if there're chinese characters contained in a description field of a lookup > textbox with auto-complete feature enabled, then what I can get from > auto-completed dropdown box is not unstandable chinese but messed html > entities such as "氨" blah blah. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4101) i18n problem in auto-completed dropdown box: display not correct characters but html entities
[ https://issues.apache.org/jira/browse/OFBIZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4101: Attachment: selectall.js.patch A quick patch to resolve this issue. However, the patch is a hurry work around, maybe it's only available to my case. > i18n problem in auto-completed dropdown box: display not correct characters > but html entities > - > > Key: OFBIZ-4101 > URL: https://issues.apache.org/jira/browse/OFBIZ-4101 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: Windows 7, Eclipse, Java 6 >Reporter: Leon >Priority: Minor > Attachments: auto-completed-mess.png, selectall.js.patch > > > if there're chinese characters contained in a description field of a lookup > textbox with auto-complete feature enabled, then what I can get from > auto-completed dropdown box is not unstandable chinese but messed html > entities such as "氨" blah blah. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4117) To reject a new created order, the order status does not change
To reject a new created order, the order status does not change --- Key: OFBIZ-4117 URL: https://issues.apache.org/jira/browse/OFBIZ-4117 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: OFBiz trunk Reporter: Leon Priority: Minor Via order manager web application, after I create a order, the order status is "ORDER_CREATED". If I approve this order, the order status will become "ORDER_APPROVED" just as expected. But if I reject it, the order status is still "ORDER_CREATED" while all the order item status is changed to "rejected". Is it a bug or is there any particular business consideration? btw, IMHO, if the order is rejected, user who created this order can re-submit the order for approval after review the rejected reason and modify the order as required. But it seems there's no such create-reject-update-approve workflow in current order management application. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4117) To reject a new created order, the order status does not change
[ https://issues.apache.org/jira/browse/OFBIZ-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon closed OFBIZ-4117. --- Resolution: Later Fix Version/s: SVN trunk ok. I will close this ticket firstly. When I fininsh the "re-submit" process, I will reopen it and provide the pathch for your review. > To reject a new created order, the order status does not change > --- > > Key: OFBIZ-4117 > URL: https://issues.apache.org/jira/browse/OFBIZ-4117 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk > Environment: OFBiz trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > > Via order manager web application, after I create a order, the order status > is "ORDER_CREATED". If I approve this order, the order status will become > "ORDER_APPROVED" just as expected. But if I reject it, the order status is > still "ORDER_CREATED" while all the order item status is changed to > "rejected". > Is it a bug or is there any particular business consideration? > btw, IMHO, if the order is rejected, user who created this order can > re-submit the order for approval after review the rejected reason and modify > the order as required. But it seems there's no such > create-reject-update-approve workflow in current order management application. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4133) "Desired Delivery Date" and "comments" is lost when select a virtual product into shopping cart
"Desired Delivery Date" and "comments" is lost when select a virtual product into shopping cart --- Key: OFBIZ-4133 URL: https://issues.apache.org/jira/browse/OFBIZ-4133 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: JDK1.6 Reporter: Leon Priority: Minor Fix For: SVN trunk >From "ordermgr/control/additem/product" page, if you try to select a "virtual" >product into shopping cart with some comments or "desired delivery date" >input, you'll be redirect to varaints selection page. After you select >neccessary features and submit, the variant product appears in shopping cart >item list, but the comments and "desired delivery date" you input ealier is >lost. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4133) "Desired Delivery Date" and "comments" is lost when select a virtual product into shopping cart
[ https://issues.apache.org/jira/browse/OFBIZ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4133: Attachment: order-variants.patch 1. add some hidden fields store the value from previous "additem" form 2. add paramMap to request attributes in case those values lost again when error occurs > "Desired Delivery Date" and "comments" is lost when select a virtual product > into shopping cart > --- > > Key: OFBIZ-4133 > URL: https://issues.apache.org/jira/browse/OFBIZ-4133 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk > Environment: JDK1.6 >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: order-variants.patch > > > From "ordermgr/control/additem/product" page, if you try to select a > "virtual" product into shopping cart with some comments or "desired delivery > date" input, you'll be redirect to varaints selection page. After you select > neccessary features and submit, the variant product appears in shopping cart > item list, but the comments and "desired delivery date" you input ealier is > lost. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item Key: OFBIZ-4134 URL: https://issues.apache.org/jira/browse/OFBIZ-4134 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
[ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4134: Attachment: ShoppingCartItem.patch trivial update to "equals" method. not only for the bug mentiond ealier, but also another similar one while comparing "additionalProductFeatureAndAppls" to exist items. > Shopping Cart Item, treat items contains same product but with or without > comment as same shopping cart item > > > Key: OFBIZ-4134 > URL: https://issues.apache.org/jira/browse/OFBIZ-4134 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: ShoppingCartItem.patch > > > In "add order item" page, you select a product and leave other field empty, > submit. Then you select same product but input some comment, after submit, > you can only get one item in shopping cart item list with its order quantity > increased but the comment written in second time is discard. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
[ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4136: Attachment: lookup_target-parameter.patch A patch to resolve this issue. > In layer mode, the attribute "target-parameter" of a lookup field is not used > - > > Key: OFBIZ-4136 > URL: https://issues.apache.org/jira/browse/OFBIZ-4136 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: lookup_target-parameter.patch > > > As xsd describes, "target-parameter" of a lookup field can be used to > transfer extra parameters to lookup something. But if we choose "layer" mode > (the default mode of lookup), this attribute does nothing. It works before > jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
In layer mode, the attribute "target-parameter" of a lookup field is not used - Key: OFBIZ-4136 URL: https://issues.apache.org/jira/browse/OFBIZ-4136 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: lookup_target-parameter.patch As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
[ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4136: Attachment: (was: lookup_target-parameter.patch) > In layer mode, the attribute "target-parameter" of a lookup field is not used > - > > Key: OFBIZ-4136 > URL: https://issues.apache.org/jira/browse/OFBIZ-4136 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > > As xsd describes, "target-parameter" of a lookup field can be used to > transfer extra parameters to lookup something. But if we choose "layer" mode > (the default mode of lookup), this attribute does nothing. It works before > jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
[ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4136: Attachment: lookup_target-parameter.patch previous patch has a trivial problem when handle more than one target-parameters. Update and re-attached. > In layer mode, the attribute "target-parameter" of a lookup field is not used > - > > Key: OFBIZ-4136 > URL: https://issues.apache.org/jira/browse/OFBIZ-4136 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: lookup_target-parameter.patch > > > As xsd describes, "target-parameter" of a lookup field can be used to > transfer extra parameters to lookup something. But if we choose "layer" mode > (the default mode of lookup), this attribute does nothing. It works before > jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
[ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986175#action_12986175 ] Leon commented on OFBIZ-4134: - following is the steps to re-produce this issue: 1. (in order entry--additem page) choose a product, e.g. "GZ-1000", input quantity as "1", then click "submit" directly. An cart item will be shown in "Order Items" list 2. choose same product again, e.g. "GZ-1000", input quantity as "2", select a "Desired Delivery Date" and input some comments, then click "submit". This time, according to my understanding, there should be second (a new ) item in "Order items" list, but in fact there's only one. The reason for this issue is because ShoppingCartItem.equals method return true if the attribute of either cart item or new item is empty. > Shopping Cart Item, treat items contains same product but with or without > comment as same shopping cart item > > > Key: OFBIZ-4134 > URL: https://issues.apache.org/jira/browse/OFBIZ-4134 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: ShoppingCartItem.patch > > > In "add order item" page, you select a product and leave other field empty, > submit. Then you select same product but input some comment, after submit, > you can only get one item in shopping cart item list with its order quantity > increased but the comment written in second time is discard. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
[ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon reopened OFBIZ-4136: - hi, Sascha and Jacques, It seems that you applied my previous patch (not the one current attached). The only update is line 526 of "framework/widget/templates/htmlFormMacroLibrary.ftl", in previous patch, I put "<#assign isFirst = false>" in wrong place. Please move "<#assign isFirst = false>" from line 528 to line 526 from "htmlFormMacroLibrary.ftl". Many thanks. Leon > In layer mode, the attribute "target-parameter" of a lookup field is not used > - > > Key: OFBIZ-4136 > URL: https://issues.apache.org/jira/browse/OFBIZ-4136 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: lookup_target-parameter.patch > > > As xsd describes, "target-parameter" of a lookup field can be used to > transfer extra parameters to lookup something. But if we choose "layer" mode > (the default mode of lookup), this attribute does nothing. It works before > jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used
[ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon closed OFBIZ-4136. --- Resolution: Fixed Double check the code, it's correct this time. Thanks for your quick response. ^^ > In layer mode, the attribute "target-parameter" of a lookup field is not used > - > > Key: OFBIZ-4136 > URL: https://issues.apache.org/jira/browse/OFBIZ-4136 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Assignee: Jacques Le Roux >Priority: Minor > Fix For: SVN trunk > > Attachments: lookup_target-parameter.patch > > > As xsd describes, "target-parameter" of a lookup field can be used to > transfer extra parameters to lookup something. But if we choose "layer" mode > (the default mode of lookup), this attribute does nothing. It works before > jQuery introduced. I guess this feature is forgot by mistake during migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4156) infinite lookup ajax calls if key enter on the page with layer lookup forms
infinite lookup ajax calls if key enter on the page with layer lookup forms --- Key: OFBIZ-4156 URL: https://issues.apache.org/jira/browse/OFBIZ-4156 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: jQuery Reporter: Leon Fix For: SVN trunk If the rendered page has one lookup field which is configured as layer mode, at first open the lookup dialog and click the empty space of the page to hide it, then, key the "enter", then in the console log you will find there's lookup request logged. Try to key "enter" serveral times, you will get more lookup requests in the backend. In particular case, even if you key one "enter" in, it will send hundrends lookup calls. See attached "infinite-lookups.log" for the log details. Cause: In modifySubmitButton of fieldlookup.js, it bind the keypress event to whole "document" to call "lookupFormAjaxRequest" when "enter" keyin. And in "lookupFormAjaxRequest" function, it call "modifySubmitButton" again after data load. Resolution: Move the keypress event bind operation to dialog open process and unbind it when dialog is closed. See attached patch for code update. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4156) infinite lookup ajax calls if key enter on the page with layer lookup forms
[ https://issues.apache.org/jira/browse/OFBIZ-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4156: Attachment: fieldlookup.patch infinite-lookups.log 1. hundreds lookup calls logged to console.log 2. patch for this issue > infinite lookup ajax calls if key enter on the page with layer lookup forms > --- > > Key: OFBIZ-4156 > URL: https://issues.apache.org/jira/browse/OFBIZ-4156 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: jQuery >Reporter: Leon > Fix For: SVN trunk > > Attachments: fieldlookup.patch, infinite-lookups.log > > > If the rendered page has one lookup field which is configured as layer mode, > at first open the lookup dialog and click the empty space of the page to hide > it, then, key the "enter", then in the console log you will find there's > lookup request logged. Try to key "enter" serveral times, you will get more > lookup requests in the backend. In particular case, even if you key one > "enter" in, it will send hundrends lookup calls. See attached > "infinite-lookups.log" for the log details. > Cause: > In modifySubmitButton of fieldlookup.js, it bind the keypress event to whole > "document" to call "lookupFormAjaxRequest" when "enter" keyin. And in > "lookupFormAjaxRequest" function, it call "modifySubmitButton" again after > data load. > Resolution: > Move the keypress event bind operation to dialog open process and unbind it > when dialog is closed. > See attached patch for code update. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4156) infinite lookup ajax calls if key enter on the page with layer lookup forms
[ https://issues.apache.org/jira/browse/OFBIZ-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4156: Attachment: (was: fieldlookup.patch) > infinite lookup ajax calls if key enter on the page with layer lookup forms > --- > > Key: OFBIZ-4156 > URL: https://issues.apache.org/jira/browse/OFBIZ-4156 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: jQuery >Reporter: Leon > Fix For: SVN trunk > > Attachments: infinite-lookups.log > > > If the rendered page has one lookup field which is configured as layer mode, > at first open the lookup dialog and click the empty space of the page to hide > it, then, key the "enter", then in the console log you will find there's > lookup request logged. Try to key "enter" serveral times, you will get more > lookup requests in the backend. In particular case, even if you key one > "enter" in, it will send hundrends lookup calls. See attached > "infinite-lookups.log" for the log details. > Cause: > In modifySubmitButton of fieldlookup.js, it bind the keypress event to whole > "document" to call "lookupFormAjaxRequest" when "enter" keyin. And in > "lookupFormAjaxRequest" function, it call "modifySubmitButton" again after > data load. > Resolution: > Move the keypress event bind operation to dialog open process and unbind it > when dialog is closed. > See attached patch for code update. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4156) infinite lookup ajax calls if key enter on the page with layer lookup forms
[ https://issues.apache.org/jira/browse/OFBIZ-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4156: Attachment: fieldlookup.patch new patch. Besides to fix what have mentioned, also make some trivial improvements to modifySubmitButton method: 1. in jquery, "contains" is not a valid method of String prototype, use "indexOf(blah) != -1" instead 2. bypass the "javascript:..." link in lookup result table. Although it's not a good solution, it makes more sence than "to skip the first Entry of the row". > infinite lookup ajax calls if key enter on the page with layer lookup forms > --- > > Key: OFBIZ-4156 > URL: https://issues.apache.org/jira/browse/OFBIZ-4156 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: jQuery >Reporter: Leon > Fix For: SVN trunk > > Attachments: fieldlookup.patch, infinite-lookups.log > > > If the rendered page has one lookup field which is configured as layer mode, > at first open the lookup dialog and click the empty space of the page to hide > it, then, key the "enter", then in the console log you will find there's > lookup request logged. Try to key "enter" serveral times, you will get more > lookup requests in the backend. In particular case, even if you key one > "enter" in, it will send hundrends lookup calls. See attached > "infinite-lookups.log" for the log details. > Cause: > In modifySubmitButton of fieldlookup.js, it bind the keypress event to whole > "document" to call "lookupFormAjaxRequest" when "enter" keyin. And in > "lookupFormAjaxRequest" function, it call "modifySubmitButton" again after > data load. > Resolution: > Move the keypress event bind operation to dialog open process and unbind it > when dialog is closed. > See attached patch for code update. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] [Created] (OFBIZ-4223) jQuery.ajax or jQuery.post with json datatype is broken after upgrade to jquery 1.5.1
jQuery.ajax or jQuery.post with json datatype is broken after upgrade to jquery 1.5.1 - Key: OFBIZ-4223 URL: https://issues.apache.org/jira/browse/OFBIZ-4223 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: jQuery 1.5.1 Reporter: Leon Priority: Minor After the jquery library is upgraded from 1.4 to 1.5, the jQuery.post function fails while the response data type is 'json'. In firefox the error message is "Invalid Label" and in IE the error message is "no ending ;"。 After some googling, I figure out the reason that is the uncompatible issue between jquery.validate plugin 1.7 and the jquery 1.5.1. Plese refer the links below for details: http://bugs.jquery.com/ticket/8064 http://bugs.jquery.com/ticket/8084#comment:16 and the note in http://bassistance.de/jquery-plugins/jquery-plugin-validation/ There's a compatible version of jquery.validate in the GitHub repository, but it's not the official release. I wonder whether we should patch the jquery.validate with this temporary solution or not. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4223) jQuery.ajax or jQuery.post with json datatype is broken after upgrade to jquery 1.5.1
[ https://issues.apache.org/jira/browse/OFBIZ-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009219#comment-13009219 ] Leon commented on OFBIZ-4223: - There's only few .post calls in current ofbiz trunk. But we use much in our customized project. We disabled the 'jsonp' temporarily to bypass this issue and wait for the official patch. So far it works for us well. We can wait, until the final version plugin released. > jQuery.ajax or jQuery.post with json datatype is broken after upgrade to > jquery 1.5.1 > - > > Key: OFBIZ-4223 > URL: https://issues.apache.org/jira/browse/OFBIZ-4223 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: jQuery 1.5.1 >Reporter: Leon >Assignee: Sascha Rodekamp >Priority: Minor > > After the jquery library is upgraded from 1.4 to 1.5, the jQuery.post > function fails while the response data type is 'json'. In firefox the error > message is "Invalid Label" and in IE the error message is "no ending ;"。 > After some googling, I figure out the reason that is the uncompatible issue > between jquery.validate plugin 1.7 and the jquery 1.5.1. Plese refer the > links below for details: > http://bugs.jquery.com/ticket/8064 > http://bugs.jquery.com/ticket/8084#comment:16 > and the note in http://bassistance.de/jquery-plugins/jquery-plugin-validation/ > There's a compatible version of jquery.validate in the GitHub repository, but > it's not the official release. I wonder whether we should patch the > jquery.validate with this temporary solution or not. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4228) Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed
[ https://issues.apache.org/jira/browse/OFBIZ-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4228: Attachment: ordermgrLookupScreensParm0.patch update "parameters.parm0" to "parameters.parm1" > Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form > widget is not working) fixed > > > Key: OFBIZ-4228 > URL: https://issues.apache.org/jira/browse/OFBIZ-4228 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Leon >Priority: Minor > Fix For: SVN trunk > > Attachments: ordermgrLookupScreensParm0.patch > > > In https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug > in fieldlookup.js which caused "Lookup target-parameter in form widget is not > working"。 > Now the form widget framework behaves same as widget-form.xsd specifies: > using parameters.parmI (where I is the position number in the > "target-parameter" list) in the related lookup screen. The position number in > the list begins from 1. That implictes "parm0" is invalid. > So I search the whole project to look up whether there's "parm0" left out. > That's what this patch for. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4228) Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed
Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed Key: OFBIZ-4228 URL: https://issues.apache.org/jira/browse/OFBIZ-4228 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Priority: Minor Fix For: SVN trunk Attachments: ordermgrLookupScreensParm0.patch In https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug in fieldlookup.js which caused "Lookup target-parameter in form widget is not working"。 Now the form widget framework behaves same as widget-form.xsd specifies: using parameters.parmI (where I is the position number in the "target-parameter" list) in the related lookup screen. The position number in the list begins from 1. That implictes "parm0" is invalid. So I search the whole project to look up whether there's "parm0" left out. That's what this patch for. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011892#comment-13011892 ] Leon commented on OFBIZ-4225: - What a long story ^^. Since the .xsd has been updated, I think this time parm0 would nevever change to parm1 again. I can apply the patch comfortablely. Thank you all. > Lookup target-parameter in form widget is not working. > -- > > Key: OFBIZ-4225 > URL: https://issues.apache.org/jira/browse/OFBIZ-4225 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 10.04, SVN trunk >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4225_BRANCH_IMPROVE.patch, > OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch, > OFBIZ-4225_TRUNK_IMPROVE.patch > > > There is a target-parameter for lookup, Currently its not working. > We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4258) Add "MUNICIPALITY" to getStateList's search condition to make "municipality" of china visible in state list
Add "MUNICIPALITY" to getStateList's search condition to make "municipality" of china visible in state list --- Key: OFBIZ-4258 URL: https://issues.apache.org/jira/browse/OFBIZ-4258 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Trivial Fix For: SVN trunk In china, city like "Shanghai","Beijing", "Chongqin" and "Tianjin" is municipality which is equivalent to province, but there's no such municipality in the state list displayed in client end. ==to fix==: In Geo entity, these municipalities is stored with geoTypeId="MUNICIPALITY", So I add it as a new search condition to CommonWorkers.getStateList to fix this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4258) Add "MUNICIPALITY" to getStateList's search condition to make "municipality" of china visible in state list
[ https://issues.apache.org/jira/browse/OFBIZ-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4258: Attachment: CommonWorkers_municipality.patch The patch to CommonWorkers.java, to display municipalities of china in dropdown state list. > Add "MUNICIPALITY" to getStateList's search condition to make "municipality" > of china visible in state list > --- > > Key: OFBIZ-4258 > URL: https://issues.apache.org/jira/browse/OFBIZ-4258 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Labels: ofbiz > Fix For: SVN trunk > > Attachments: CommonWorkers_municipality.patch > > > In china, city like "Shanghai","Beijing", "Chongqin" and "Tianjin" is > municipality which is equivalent to province, but there's no such > municipality in the state list displayed in client end. > ==to fix==: > In Geo entity, these municipalities is stored with geoTypeId="MUNICIPALITY", > So I add it as a new search condition to CommonWorkers.getStateList to fix > this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4258) Add "MUNICIPALITY" to getStateList's search condition to make "municipality" of china visible in state list
[ https://issues.apache.org/jira/browse/OFBIZ-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4258: Attachment: GeoData_CN.patch fix some problem in current GeoData_CN.xml > Add "MUNICIPALITY" to getStateList's search condition to make "municipality" > of china visible in state list > --- > > Key: OFBIZ-4258 > URL: https://issues.apache.org/jira/browse/OFBIZ-4258 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Labels: ofbiz > Fix For: SVN trunk > > Attachments: CommonWorkers_municipality.patch, GeoData_CN.patch > > > In china, city like "Shanghai","Beijing", "Chongqin" and "Tianjin" is > municipality which is equivalent to province, but there's no such > municipality in the state list displayed in client end. > ==to fix==: > In Geo entity, these municipalities is stored with geoTypeId="MUNICIPALITY", > So I add it as a new search condition to CommonWorkers.getStateList to fix > this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4258) Add "MUNICIPALITY" to getStateList's search condition to make "municipality" of china visible in state list
[ https://issues.apache.org/jira/browse/OFBIZ-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020937#comment-13020937 ] Leon commented on OFBIZ-4258: - Also change the geoTypeId from "REGIONS" to "MUNICIPALITY" for some "Autonomous regions" and "Special administrative Regions" and add some missing country-state associations. It's better to add new geo types for "Autonomous regions" or "Special Administrative Regions", but I don't want to make the thing complex if there's no such strong demand. > Add "MUNICIPALITY" to getStateList's search condition to make "municipality" > of china visible in state list > --- > > Key: OFBIZ-4258 > URL: https://issues.apache.org/jira/browse/OFBIZ-4258 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Leon >Priority: Trivial > Labels: ofbiz > Fix For: SVN trunk > > Attachments: CommonWorkers_municipality.patch, GeoData_CN.patch > > > In china, city like "Shanghai","Beijing", "Chongqin" and "Tianjin" is > municipality which is equivalent to province, but there's no such > municipality in the state list displayed in client end. > ==to fix==: > In Geo entity, these municipalities is stored with geoTypeId="MUNICIPALITY", > So I add it as a new search condition to CommonWorkers.getStateList to fix > this issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4261) Next, Last, Previous and First functions are broken in lookup dialog
Next, Last, Previous and First functions are broken in lookup dialog Key: OFBIZ-4261 URL: https://issues.apache.org/jira/browse/OFBIZ-4261 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Priority: Minor When I open an layer mode lookup window and click the 'Next' button above the search result list, nothing happend but exception occures in backend. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
parse javascript link wrongly in lookup layer dialog if there's slash '/' in
data
-
Key: OFBIZ-4281
URL: https://issues.apache.org/jira/browse/OFBIZ-4281
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Priority: Trivial
Fix For: SVN trunk
Attachments: fieldlookup.js.patch
e.g. in lookup dialog (in layer mode), one href value of a link is
"javascript:set_value('123/ABC');", then the ofbiz framework will parse it to
"javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong.
Correct one should be given href itself.
to fix:
judge whether the link contains "javascript:set_" before split it by slash '/'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
[
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4281:
Attachment: fieldlookup.js.patch
> parse javascript link wrongly in lookup layer dialog if there's slash '/' in
> data
> -
>
> Key: OFBIZ-4281
> URL: https://issues.apache.org/jira/browse/OFBIZ-4281
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js.patch
>
>
> e.g. in lookup dialog (in layer mode), one href value of a link is
> "javascript:set_value('123/ABC');", then the ofbiz framework will parse it to
> "javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong.
> Correct one should be given href itself.
> to fix:
> judge whether the link contains "javascript:set_" before split it by slash
> '/'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
[
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033421#comment-13033421
]
Leon commented on OFBIZ-4281:
-
hi, Sascha,
here is an example:
in form widget, we defined a lookup field,
in lookup form, we use set_values to set the target field and description
field,
Unfortunately, almost all "testMethodName" may contains character '/'. Then
the link we got from lookup dialog is something like
"javascript:lookupAjaxRequest blah blah", not the "javascript:set_values" we
wanted.
Leon.
> parse javascript link wrongly in lookup layer dialog if there's slash '/' in
> data
> -
>
> Key: OFBIZ-4281
> URL: https://issues.apache.org/jira/browse/OFBIZ-4281
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Assignee: Sascha Rodekamp
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js.patch
>
>
> e.g. in lookup dialog (in layer mode), one href value of a link is
> "javascript:set_value('123/ABC');", then the ofbiz framework will parse it to
> "javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong.
> Correct one should be given href itself.
> to fix:
> judge whether the link contains "javascript:set_" before split it by slash
> '/'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
[
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033490#comment-13033490
]
Leon commented on OFBIZ-4281:
-
Hi, Sascha,
Very glad to hear that you're considering parsing mechanism improvement.
There's a little assumptions and restriction in current implementation.
IMHO, maybe we can use different decorator (to exclude header and tailer of
layer mode) and html iframe in div (to avoid ajax replacement) in future
version.
best,
Leon
> parse javascript link wrongly in lookup layer dialog if there's slash '/' in
> data
> -
>
> Key: OFBIZ-4281
> URL: https://issues.apache.org/jira/browse/OFBIZ-4281
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
>Assignee: Sascha Rodekamp
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js.patch
>
>
> e.g. in lookup dialog (in layer mode), one href value of a link is
> "javascript:set_value('123/ABC');", then the ofbiz framework will parse it to
> "javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong.
> Correct one should be given href itself.
> to fix:
> judge whether the link contains "javascript:set_" before split it by slash
> '/'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4305) The absence of default delay value for ajaxAutoCompleter introduces html syntax error in client end
The absence of default delay value for ajaxAutoCompleter introduces html syntax
error in client end
---
Key: OFBIZ-4305
URL: https://issues.apache.org/jira/browse/OFBIZ-4305
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Fix For: SVN trunk
Attachments: autocompleter_defaultdelay.patch
When I open a page with lookup fields inside, the browser reports syntax error:
Error: syntax error
Source code:
ajaxAutoCompleter('theLookupUrl_blahblah', true, 2, );
The last parameter of function "ajaxAutoCompleter" is omitted, it should be a
number to indicate the ajaxautocompleter delay value.
In some complex page which includes serveral lookup fields, sometimes, this
kind of syntax error crippled the whole function.
workaround:
Modify the name of "widget.autocompleter.delay" in
framework/widget/config/widget.properties to
"widget.autocompleter.defaultDelay" and uncommment this line.
Note that org.ofbiz.base.util.UtilProperties.getPropertyValue won't return null
if the property does not exist, it return empty string "". Thus the expression
"${defaultDelay!300}" in .ftl returns an empty string instead of number "300"
as we want.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4305) The absence of default delay value for ajaxAutoCompleter introduces html syntax error in client end
[
https://issues.apache.org/jira/browse/OFBIZ-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leon updated OFBIZ-4305:
Attachment: autocompleter_defaultdelay.patch
> The absence of default delay value for ajaxAutoCompleter introduces html
> syntax error in client end
> ---
>
> Key: OFBIZ-4305
> URL: https://issues.apache.org/jira/browse/OFBIZ-4305
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: SVN trunk
>Reporter: Leon
> Fix For: SVN trunk
>
> Attachments: autocompleter_defaultdelay.patch
>
>
> When I open a page with lookup fields inside, the browser reports syntax
> error:
> Error: syntax error
> Source code:
> ajaxAutoCompleter('theLookupUrl_blahblah', true, 2, );
> The last parameter of function "ajaxAutoCompleter" is omitted, it should be a
> number to indicate the ajaxautocompleter delay value.
> In some complex page which includes serveral lookup fields, sometimes, this
> kind of syntax error crippled the whole function.
> workaround:
> Modify the name of "widget.autocompleter.delay" in
> framework/widget/config/widget.properties to
> "widget.autocompleter.defaultDelay" and uncommment this line.
> Note that org.ofbiz.base.util.UtilProperties.getPropertyValue won't return
> null if the property does not exist, it return empty string "". Thus the
> expression "${defaultDelay!300}" in .ftl returns an empty string instead of
> number "300" as we want.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
