Re: [jira] [Commented] (OFBIZ-5179) checkExternalPayment returns payflowpro instead of paypal
Hello Mirko, The Java class works OK. It is the integration with the checkout process that is the culprit here. I understand the following at present: - PayPal Express Checkout allows/demands to register the current party with PayPal before any shipment address or use details are even captured through a UI - PayPal payment (party and shipment details already captured) flow is initiated before the Order is created, ie. all order details are still on the ShoppingCart When studying the Java class, I found that there are context objects read (or better attempted to be read) which are not present a checkout time, but only once the order is confirmed. Similar to googlecheckout component, I would like to see a paypalcheckout component here which will fulfill the requirements of a two phase commit on checkout, which is also enforced by PayPal ie: - preregister the order with PayPal; at this time on the OFBiz side only a session with a ShoppingCart exists --> setPayPalCheckout, retrieve PayPal Token - optionally retrieve the customer's data from PayPal (when using ExpressCheckout; this avoids lenghty registration forms on the shop's side) --> getPayPalCheckout - create the order once customer confirms order --> doPayPalCheckout If the customer changes anyting later on the order (e.g. cancels it), then updatePayPalCheckout method will be used to communicate that to PayPal. >From your comment, I assume you create the Order before even contacting PayPal. Is that correct? Also, I see there are more methods defined on the PayPal NVP API, I assume those are use on the accounting side to do CRUD operations on the PayPal account / it's reflection in OFBiz accounting. Let me know whether this clarifies, please, or whether I am completely wrong. I've spent quite some effort to get things straight for the 2-phase-commit on checkout and also segregated the PayPalServices.java into three: PaypalUtil.java, PayPalServices.java and PayPalCheckout.java. Kind regards Carsten PS: I also hope this is "concrete" enough for your purpose? 2013/5/1 Mirko Vogelsmeier (JIRA) > > [ > https://issues.apache.org/jira/browse/OFBIZ-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646204#comment-13646204] > > Mirko Vogelsmeier commented on OFBIZ-5179: > -- > > Hello Carsten, > i did reviewed the function of the paypal interface just some months ago > and it worked fine for me. > "PayPal contiditions are met" is a little to abstract to exactly point out > a bug there might be. > > About simple methods: I rather guess that the interface integration is not > designed to use the OFBiz Simple-Methods (which to be honest im pretty glad > about :D ). Or did i missinterpret the problem? > > CheckOutEvents#checkExternalPayment checks the defined OrderPaymentPref > for the currently definied paymentMethod. Maybe your issue is while > creating / working with the order? > > It would be helpfull if you create tickets for concrete problems (eg. > inconsistent ways to get a locale) and refere to the users mailinglist for > configuration issues with payment-regarding issues. > > Greetings, > Mirko > > > > checkExternalPayment returns payflowpro instead of paypal > > - > > > > Key: OFBIZ-5179 > > URL: https://issues.apache.org/jira/browse/OFBIZ-5179 > > Project: OFBiz > > Issue Type: Bug > > Components: accounting > >Affects Versions: SVN trunk > > Environment: independant > >Reporter: Carsten Schinzer > > Fix For: SVN trunk > > > > Original Estimate: 1h > > Remaining Estimate: 1h > > > > The following method contains a false return value: > > org.ofbiz.order.schoppingcart.CheckOutEvents#checkExternalPayment > > It verifies a Paypal payment method is defined for the ProductStore, but > then returns a value 'payflowpro' in return which is clearly false as > PayFlowPro is a separate external payment method. > > The patch/fix will allow to check for both, PayPal and PayFlowPro as > external payment methods. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira >
[jira] [Commented] (OFBIZ-5179) checkExternalPayment returns payflowpro instead of paypal
[ https://issues.apache.org/jira/browse/OFBIZ-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646204#comment-13646204 ] Mirko Vogelsmeier commented on OFBIZ-5179: -- Hello Carsten, i did reviewed the function of the paypal interface just some months ago and it worked fine for me. "PayPal contiditions are met" is a little to abstract to exactly point out a bug there might be. About simple methods: I rather guess that the interface integration is not designed to use the OFBiz Simple-Methods (which to be honest im pretty glad about :D ). Or did i missinterpret the problem? CheckOutEvents#checkExternalPayment checks the defined OrderPaymentPref for the currently definied paymentMethod. Maybe your issue is while creating / working with the order? It would be helpfull if you create tickets for concrete problems (eg. inconsistent ways to get a locale) and refere to the users mailinglist for configuration issues with payment-regarding issues. Greetings, Mirko > checkExternalPayment returns payflowpro instead of paypal > - > > Key: OFBIZ-5179 > URL: https://issues.apache.org/jira/browse/OFBIZ-5179 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: SVN trunk > Environment: independant >Reporter: Carsten Schinzer > Fix For: SVN trunk > > Original Estimate: 1h > Remaining Estimate: 1h > > The following method contains a false return value: > org.ofbiz.order.schoppingcart.CheckOutEvents#checkExternalPayment > It verifies a Paypal payment method is defined for the ProductStore, but then > returns a value 'payflowpro' in return which is clearly false as PayFlowPro > is a separate external payment method. > The patch/fix will allow to check for both, PayPal and PayFlowPro as external > payment methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5179) checkExternalPayment returns payflowpro instead of paypal
[ https://issues.apache.org/jira/browse/OFBIZ-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634171#comment-13634171 ] Carsten Schinzer commented on OFBIZ-5179: - The scope of this creeps unfortunately. It turns out that PayPal services are apparently not ootb usable, the following seem to be missing before they will work: - checkExternalPayment returns the wrong value when PayPal contiditions are met - although PayPaylServices.java is there and respective java servicedef is also in place, the mapping of context parameters for service execution is entirely missing, ie -- Simple Method Map Processings are missing -- Simple Method Events are missing -- Simple Method Services are missing - IN map parameters also need to be reviewed as the interface methods only partially define the required parameters that are used and accessed in PayPalServices.java - some review might be required for consistent parameter use on PayPalServices.java as well (I already found eg. the Locale being accessed through the cart and directly on context) On top of that, the de translations on the payPalEvents are also missing. (I got the full pacakge here :D) that will be tracked on a separate JIRA though, since it is only mutually related to this one. I have reviewed the estimated effort and upped it to 4 hrs. > checkExternalPayment returns payflowpro instead of paypal > - > > Key: OFBIZ-5179 > URL: https://issues.apache.org/jira/browse/OFBIZ-5179 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: SVN trunk > Environment: independant >Reporter: Carsten Schinzer > Fix For: SVN trunk > > Original Estimate: 1h > Remaining Estimate: 1h > > The following method contains a false return value: > org.ofbiz.order.schoppingcart.CheckOutEvents#checkExternalPayment > It verifies a Paypal payment method is defined for the ProductStore, but then > returns a value 'payflowpro' in return which is clearly false as PayFlowPro > is a separate external payment method. > The patch/fix will allow to check for both, PayPal and PayFlowPro as external > payment methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
