[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588401#action_12588401 ] Enrique Ruibal commented on OFBIZ-1189: --- I think currently there is an issue with this default setting as the order is only approved (and completed) for a digital good if and only if it has been previously paid for, wich seems a bit odd compared to real business situations where a service order is just issued and paid for after a period of time has elapsed, there is a broad discussion here http://www.nabble.com/Can%27t-Approve-Orders-with-service-products-to16242722.html#a16659894 Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588474#action_12588474 ] David E. Jones commented on OFBIZ-1189: --- What you're describing is a difference between service products and digital products. A new indicator should be added to the ProductType entity to represent service products and the relevant code should be added or changed to look at this indicator and behave accordingly, just like we do for digital and physical goods (neither of which are service products). Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588341#action_12588341 ] Jacques Le Roux commented on OFBIZ-1189: Should we not close this issue ? Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519291 ] Bilgin Ibryam commented on OFBIZ-1189: -- Jacques, Your solution is better and fixes the bug. Thanks. Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518668 ] Bilgin Ibryam commented on OFBIZ-1189: -- David, I tested it with r562836 and it works fine. Looks like it is affected from your changes (ProductStore.headerApprovedStatus feature r562843). But the changes you did are correct. The error occurs because the seca approves the items, approves the order, completes the items and completes the order. Then the first started service for approving returns the error. In OrderServices.java:1973 i see that when we try to change the order status to the same status, we are not returning error but only a warning log and success . So the solution i offer is similar: Instead of returning error when the order_status_change is not valid, we can log warning and return success. What you think ? Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Fix For: SVN trunk Attachments: order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518476 ] David E. Jones commented on OFBIZ-1189: --- I made some changes to this stuff recently because the way it was written broke the ProductStore.headerApprovedStatus feature, and had some general weirdness in it. Which revision exactly are you using? Also, could you attach a stack trace or more log info related to the error? Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Fix For: SVN trunk Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518517 ] Bilgin Ibryam commented on OFBIZ-1189: -- I am using latest ofbiz trunk r563918, here is the log [java] 2007-08-08 20:21:54,156 (http-0.0.0.0-8443-Processor2) [ ControlServlet.java:93 :INFO ] The character encoding of the request is: [null]. The character encoding we will use for the request and response is: [UTF-8] [java] 2007-08-08 20:21:54,250 (http-0.0.0.0-8443-Processor2) [ ConfigXMLReader.java:558:INFO ] ConfigMap Created: (4) records in 0.0s [java] 2007-08-08 20:21:54,250 (http-0.0.0.0-8443-Processor2) [ ConfigXMLReader.java:716:INFO ] HandlerMap Created: (4) view handlers and (6) request/event handlers in 0.0s [java] 2007-08-08 20:21:54,265 (http-0.0.0.0-8443-Processor2) [ ConfigXMLReader.java:291:INFO ] RequestMap Created: (299) records in 0.015s [java] 2007-08-08 20:21:54,281 (http-0.0.0.0-8443-Processor2) [ ConfigXMLReader.java:385:INFO ] ViewMap Created: (132) records in 0.0s [java] 2007-08-08 20:21:54,281 (http-0.0.0.0-8443-Processor2) [ RequestHandler.java:239:INFO ] [Processing Request]: changeOrderStatus sessionId=C79B19660A0979D9DE3D5BEF621785D9.jvm1 [java] 2007-08-08 20:21:54,593 (http-0.0.0.0-8443-Processor2) [ EntityEcaRule.java:111:INFO ] Running Entity ECA Service: checkCreateOrderRequirement, triggered by rule on Entity: OrderItem [java] 2007-08-08 20:21:54,734 (http-0.0.0.0-8443-Processor2) [ PrimaryKeyFinder.java:124:INFO ] Returning null because found incomplete primary key in find: [GenericEntity:Product] [java] 2007-08-08 20:21:54,937 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:112:INFO ] Got false for condition: [null][][statusId][equals][null][ITEM_CANCELLED][true][String][] [java] 2007-08-08 20:21:54,953 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:112:INFO ] Got false for condition: [null][][statusId][equals][null][ITEM_COMPLETED][true][String][] [java] 2007-08-08 20:21:54,953 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:137:INFO ] Running Service ECA Service: checkOrderItemStatus, triggered by rule on Service: changeOrderItemStatus [java] 2007-08-08 20:21:55,500 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:112:INFO ] Got false for condition: [null][][statusId][equals][null][ORDER_CANCELLED][true][String][] [java] 2007-08-08 20:21:55,500 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:112:INFO ] Got false for condition: [null][][statusId][equals][null][ORDER_COMPLETED][true][String][] [java] 2007-08-08 20:21:55,500 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:112:INFO ] Got false for condition: [null][][statusId][equals][null][ORDER_COMPLETED][true][String][] [java] 2007-08-08 20:21:55,500 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:137:INFO ] Running Service ECA Service: updateContentSubscriptionByOrder, triggered by rule on Service: changeOrderStatus [java] 2007-08-08 20:21:55,546 (http-0.0.0.0-8443-Processor2) [ContentManagementServices.java:1577:INFO ] In updateContentSubscriptionByOrder service with orderId: WSCO1 [java] 2007-08-08 20:21:55,656 (http-0.0.0.0-8443-Processor2) [ GenericDelegator.java:2295:WARN ] Tried to put a value of the OrderHeader entity in the BY PRIMARY KEY cache but this entity has never-cache set to true, not caching. [java] 2007-08-08 20:21:55,750 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:137:INFO ] Running Service ECA Service: processExtendSubscriptionByOrder, triggered by rule on Service: changeOrderStatus [java] 2007-08-08 20:21:55,828 (http-0.0.0.0-8443-Processor2) [SubscriptionServices.java:220:INFO ] In processExtendSubscriptionByOrder service with orderId: WSCO1 [java] 2007-08-08 20:21:55,828 (http-0.0.0.0-8443-Processor2) [ GenericDelegator.java:2295:WARN ] Tried to put a value of the OrderHeader entity in the BY PRIMARY KEY cache but this entity has never-cache set to true, not caching. [java] 2007-08-08 20:21:56,093 (http-0.0.0.0-8443-Processor2) [ ServiceEcaRule.java:137:INFO ] Running Service ECA Service: checkDigitalItemFulfillment, triggered by rule on Service: changeOrderItemStatus [java] 2007-08-08 20:21:57,218 (http-0.0.0.0-8443-Processor2) [ Log.java:94 :INFO ] In getNextInvoiceId partyId is [Company], partyAcctgPreference: [GenericEntity:PartyAcctgPreference][baseCurrencyUomId,USD(java.lang.String)][cogsMethodId,COGS_AVG_COST(java.lang.String)][createdStamp,2007-08-08 19:20:37.671(java.sql.Timestamp)][createdTxStamp,2007-08-08
