[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634159#action_12634159 ] Adrian Crum commented on OFBIZ-1698: Jacques, I believe the problem was fixed in rev 698429. Can we close this now? Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625198#action_12625198 ] Jacques Le Roux commented on OFBIZ-1698: Moreover, this bug seems to be random... The only way for now is to put all languages needed, even if it's the same sentence than in English Actually French is the most, and maybe sole, concerned and only for few words. So it's not a big deal... We will only have to put them as they appears... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621866#action_12621866 ] Adrian Crum commented on OFBIZ-1698: Jacques, If you provide an example of where this is occurring, I will take a look at it. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621881#action_12621881 ] Jacques Le Roux commented on OFBIZ-1698: Adrian, I have 2, please look at revisions 685140 and 684522 Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12610924#action_12610924 ] Jacques Le Roux commented on OFBIZ-1698: Thanks for update Bruno, I think you are right. I will commit your results, after a quick check Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12611062#action_12611062 ] Jacques Le Roux commented on OFBIZ-1698: Bruno, Something is not clear to me. Your script says : Duplication of label CommonDescription found in applications/product/config/ProductUiLabels.xml (7 languages) Label removed from file applications/product/config/ProductUiLabels.xml But the label is only moved (sorted) in the file not removed. Is that normal ? Are you sure of that Number of removed labels : 636 ? BTW, if we want to remove them we should at least check that a such label exists in the right file (here common) and that in this right file there are not less languagues and that existing values are the same. Else I suggest to write something (both labels) to allow to do it manually later, rather than removing it automatically. It takes a man to do errors, but it takes a machine to really screw it up ;o) Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12611210#action_12611210 ] Bruno Busco commented on OFBIZ-1698: Jacques, you are right there is something not working in the script. It SHOULD delete the label but it fails to do it. At the moment I cannot fix it, I will fix it asap. Sorry, Bruno Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip, cleanlabels_1.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12610689#action_12610689 ] Jacques Le Roux commented on OFBIZ-1698: Hi Bruno, Please let me know if you are still interested by this issue (I already asked on dev ML). I gave it a try today. After a 1st review, here are some remarks There are some annoyances : Trivial (but maybe not in you Python script) -?xml version=1.0 encoding=UTF-8? -!-- - +?xml version=1.0 encoding=UTF-8 ?!-- --- -resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; +--resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; .quot; and at large all special characters are replaced by HTML entities (not easy to learn and maintain) -value xml:lang=nlBerekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt./value +value xml:lang=nlBerekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt.quot;/value Because your algorithm was written before we decided to not have overriden labels in different files, we have some in this patch. If you are still interested you could change your script to only keep CommonDescription in Common file in the case below. At large, the rule should be discussed before. But in case of duplicated lables, we may automatically keep only labels within their own file (like CommonDescription). Your script may in other cases write a list of possible changes to check by hand, ie 2 patches : 1 for changes to apply, one for changes to check before applying. ContentUiLabels.xml +property key=CommonDescription +value xml:lang=arوصف/value +value xml:lang=enDescription/value +value xml:lang=itDescrizione/value +value xml:lang=roDescriere/value +value xml:lang=thรายละเอียด/value +value xml:lang=zh描述/value +/property -property key=CommonDescription -value xml:lang=arوصف/value -value xml:lang=enDescription/value -value xml:lang=itDescrizione/value -value xml:lang=roDescriere/value -value xml:lang=thรายละเอียด/value -value xml:lang=zh描述/value -/property ProductUiLabels.xml +property key=CommonDescription +value xml:lang=enDescription/value +value xml:lang=frDescription/value +value xml:lang=itDescrizione/value +value xml:lang=roDescriere/value +value xml:lang=ruОписание/value +value xml:lang=thอธิบาย/value +value xml:lang=zh描述/value +/property -property key=CommonDescription -value xml:lang=enDescription/value -value xml:lang=frDescription/value -value xml:lang=itDescrizione/value -value xml:lang=roDescriere/value -value xml:lang=ruОписание/value -value xml:lang=thอธิบาย/value -value xml:lang=zh描述/value -/property CommonUiLabels.xml property key=CommonDescription value xml:lang=arوصف/value value xml:lang=csPopis/value value xml:lang=deBeschreibung/value value xml:lang=enDescription/value value xml:lang=esDescripción/value value xml:lang=frDescription/value value xml:lang=itDescrizione/value value xml:lang=nlOmschrijving/value value xml:lang=ptDescrição/value value xml:lang=roDescriere/value value xml:lang=ruОписание/value value xml:lang=thคำอธิบาย/value value xml:lang=zh描述/value value xml:lang=zh_CN描述/value /property Please, let me know what you think. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239 ] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
Thank you, Jacques. When you will be on the issue, if you want, I will run the script again on the latest trunk to simplify the commit. Just let me know. -Bruno 2008/4/12, Jacques Le Roux (JIRA) [EMAIL PROTECTED]: [ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
Ok, thanks ! Jacques From: Bruno Busco [EMAIL PROTECTED] Thank you, Jacques. When you will be on the issue, if you want, I will run the script again on the latest trunk to simplify the commit. Just let me know. -Bruno 2008/4/12, Jacques Le Roux (JIRA) [EMAIL PROTECTED]: [ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12581263#action_12581263 ] Jacques Le Roux commented on OFBIZ-1698: Hi Bruno, I did not find enough time to seriously look at your python script. About the order above, I can't see any problems with it though for instance I don't think any modules depend of Shark and Xui at this stage and I would put Ecommerce after core all core applications (like manufacturing, workeffort and marketing). Anyway, it's a matter of taste I guess as soon as an order is given and respected. But please wait before we find a consensus. I will ask the dev ML. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.py A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12581154#action_12581154 ] Bruno Busco commented on OFBIZ-1698: If we agree with the following dependence hierarchy i can run the script against the last trunk and submit a patch with all the modified UiLabels files. framework/common/config/CommonUiLabels.xml, framework/common/config/PrefErrorUiLabels.xml, framework/common/config/SecurityextUiLabels.xml, framework/service/config/ServiceErrorUiLabels.xml, framework/minilang/config/MiniLangErrorUiLabels.xml, framework/shark/config/SharkUILabels.xml, framework/guiapp/config/XuiUiLabels.xml, framework/example/config/ExampleUiLabels.xml, framework/webapp/config/WebappUiLabels.xml, framework/webtools/config/WebtoolsErrorUiLabels.xml, framework/webtools/config/WebtoolsUiLabels.xml, applications/accounting/config/AccountingUiLabels.xml, applications/party/config/PartyUiLabels.xml, applications/product/config/ProductErrorUiLabels.xml, applications/product/config/ProductUiLabels.xml, applications/order/config/OrderErrorUiLabels.xml, applications/order/config/OrderUiLabels.xml, applications/content/config/ContentUiLabels.xml, applications/content/config/ContentErrorUiLabels.xml, applications/ecommerce/config/EcommerceUiLabels.xml, applications/manufacturing/config/ManufacturingReportsUiLabels.xml, applications/manufacturing/config/ManufacturingUiLabels.xml, applications/marketing/config/MarketingUiLabels.xml, applications/humanres/config/HumanResUiLabels.xml, applications/workeffort/config/WorkEffortUiLabels.xml, specialpurpose/assetmaint/config/AssetMaintUiLabels.xml, specialpurpose/bi/config/BiUiLabels.xml, specialpurpose/ebay/config/EbayUiLabels.xml, specialpurpose/googlebase/config/GoogleBaseUiLabels.xml, specialpurpose/oagis/config/OagisUiLabels.xml, specialpurpose/ProjectMgr/config/ProjectMgrUiLabels.xml, Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.py A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12579058#action_12579058 ] Jacques Le Roux commented on OFBIZ-1698: Interesting I will have a look as soon as possible... BTW which version of python did you use (I will do it in on Windows, I will have to update), thanks Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.py A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12579059#action_12579059 ] Bruno Busco commented on OFBIZ-1698: I use windows as well (XP). I have installed ActivePython 2.4.3 but should work with other versions also. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.py A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12577752#action_12577752 ] Bruno Busco commented on OFBIZ-1698: Still checking for UiLabels definition redundancy. I can report two examples found: Label: AccountingAccountNumber Defined in: AccountingUiLabels.xml (10 languages), EcommerceUiLabels.xml (14 languages), OrderUiLabels.xml (4 languages) Used in: ecommerce, order, party [and NOT in accounting :( ] Label: AccountingBillingAccount Defined in: AccountingUiLabels.xml (10 languages), EcommerceUiLabels.xml (13 langiages), OrderUiLabels.xml (4 languages), PartyUiLabels.xml (10 languages) Used in: accounting, ecommerce, order, party I think i have found a generic rule that we could follow, here it is, please review it. 1) Define a dependence hierarchy among applications (even between core applications). If two applications are at the same level (i.e. depends each other, one must be declared at an higher level in the hierarchy) (higher level means that the application is more dependent from others) 2) If a label is used in more than one application it should be defined ONLY in the lower level application UiLabels file. 3) All labels defined in a AppNameUiLabels.xml files MUST be named AppNameLabelName What do you think about? Does this make sense? Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578076#action_12578076 ] Jacques Le Roux commented on OFBIZ-1698: This sounds good to me (I can't see any flaws in this proposition), but it means a lot of work moving and deleting labels, isn'it ? Of course, I would prefer to have this cleaned. I only wonder if we will have ever enough will to do it ;o) Though I saw the work you already did ! Moreover I would prefer to have other opinions. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578157#action_12578157 ] Bruno Busco commented on OFBIZ-1698: Oh yes it will be a long, not very exiting but simple work. Since I need to touch some UiLabels files to add italian translations i could start with this also. All we need is to agree with an application dependence hierarchy (if someone has this clear in mind could post it here otherwise i will try to work out a my proposal) and starting applying the rule on any new label added to OFBiz. The work is not necessarly to be done at once. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12576776#action_12576776 ] Bruno Busco commented on OFBIZ-1698: Thank you for having checked this. Now, since the EcommerceCartSummary definition is the same in both EcommerceUiLabels and OrderUiLabels files (for the defined languages) what do you think about the alternative solution of moving the definition in EcommerceUiLabels, merging all the languages and deleteing the definition from OrderUiLabels ? The label name starts with Ecommerce so i think that EcommerceUiLabels.xml is the right place for it. This will reduce redundancy, will work with the logic you have explained and will make OFBiz cleaner (IMHO). One more thing: According to the logic that in the list should be located FIRST more specific files and then more generic, shouldn't CommonUiLabels be the LAST in the list? Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12576797#action_12576797 ] Jacques Le Roux commented on OFBIZ-1698: These are good question, answers will complete http://docs.ofbiz.org/display/OFBIZ/Tips+for+translation. We really need to resolve all ambiguities... I'm not sure for the 1st point. The reason is that Order is one of the core applications (applications which other, like eCommerce, humanres or apps in specialpurpose, hot deploy use as fundamental bricks). Hence it should be independent of any upper applications (like eCommerce). On the other hands, the labels is obviously an eCommerce one. History is certainly the reason, we need an expert here, :o) For EcommerceCartSummary, from my POV I will renanme it OrderCartSummary (eveyrwhere) and delete EcommerceCartSummary from eCommerce labels. 2d point : yes, I already asked myslef the same question, not sure of an answer though. I would say : yes. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12576582#action_12576582 ] Adrian Crum commented on OFBIZ-1698: I spent some time checking into this and it appears to me the system is working correctly even though the result seems wrong. The UI labels are loaded in the eCommerce CommonScreens.xml file as follows: property-map resource=EcommerceUiLabels map-name=uiLabelMap global=true/ property-map resource=ContentUiLabels map-name=uiLabelMap global=true/ property-map resource=CommonUiLabels map-name=uiLabelMap global=true/ property-map resource=ProductUiLabels map-name=uiLabelMap global=true/ property-map resource=AccountingUiLabels map-name=uiLabelMap global=true/ property-map resource=PartyUiLabels map-name=uiLabelMap global=true/ property-map resource=OrderUiLabels map-name=uiLabelMap global=true/ The framework searches for the UI label in sequence from the top down, so EcommerceUiLabels is checked first. If the user's locale is italian, the framework will search for a matching italian label. If that isn't found, it searches for a matching english label. If that isn't found, it moves on to the ContentUiLabels properties file and the process repeats. In the example you gave, the EcommerceCartSummary UI label exists in the EcommerceUiLabels file, but there is no translation for italian. Since a translation exists for english, that one is used. Since a matching label is found, the process stops - so the italian translation in the OrderUiLabels properties file is never found. The solution is to include the italian translation in the EcommerceUiLabels properties file. Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
