[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (86 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2619  Make  Hive action defaults to match hive defaults when running from 
command line
https://issues-test.apache.org/jira/browse/OOZIE-2619
OOZIE-2618  Include hive-common in hive-beeline as compile component for 
hive-server2 (hive2 action)
https://issues-test.apache.org/jira/browse/OOZIE-2618
OOZIE-2617  Read properties files in action configurations
https://issues-test.apache.org/jira/browse/OOZIE-2617
OOZIE-2616  Add Tez profile for Hive and Pig sharelibs
https://issues-test.apache.org/jira/browse/OOZIE-2616
OOZIE-2606  Set spark.yarn.jars to fix Spark 2.0 with Oozie
https://issues-test.apache.org/jira/browse/OOZIE-2606
OOZIE-2589  CompletedActionXCommand priority param is of no effect
https://issues-test.apache.org/jira/browse/OOZIE-2589
OOZIE-2588  Support getting credentials for same cluster hcat when credentials 
config is empty
https://issues-test.apache.org/jira/browse/OOZIE-2588
OOZIE-2585  Disable or remove test case 
TestPartitionDependencyManagerEhcache.testMemoryUsageAndSpeedOverflowToDisk and 
testMemoryUsageAndSpeed
https://issues-test.apache.org/jira/browse/OOZIE-2585
OOZIE-2584  Eliminate Thread.sleep() calls in TestMemoryLocks
https://issues-test.apache.org/jira/browse/OOZIE-2584
OOZIE-2583  oozie throws EL Exception when reference variable name containing 
dot
https://issues-test.apache.org/jira/browse/OOZIE-2583
OOZIE-2582  Populating external child Ids for action failures
https://issues-test.apache.org/jira/browse/OOZIE-2582
OOZIE-2573  dataset url  which contains spaces can not be handled rightly
https://issues-test.apache.org/jira/browse/OOZIE-2573
OOZIE-2572  SLA DURATION miss not shown when job is running for longer than 
expected time
https://issues-test.apache.org/jira/browse/OOZIE-2572
OOZIE-2571  Add scala.binary.version Maven property so that Scala 2.11 can be 
used
https://issues-test.apache.org/jira/browse/OOZIE-2571
OOZIE-2569  Adding yarn-site, core-site, hdfs-site and mapred-site into spark 
launcher 
https://issues-test.apache.org/jira/browse/OOZIE-2569
OOZIE-2568  SSH  action pretends to retry automaticly when it failed
https://issues-test.apache.org/jira/browse/OOZIE-2568
OOZIE-2564  Create new log4j config for unit tests so that logged messages 
contain threads
https://issues-test.apache.org/jira/browse/OOZIE-2564
OOZIE-2552  Update ActiveMQ version for security and other fixes
https://issues-test.apache.org/jira/browse/OOZIE-2552
OOZIE-2538  Update HttpClient versions to close security vulnerabilities
https://issues-test.apache.org/jira/browse/OOZIE-2538
OOZIE-2534  Versioned action libs (similar to how SharedLibs works)
https://issues-test.apache.org/jira/browse/OOZIE-2534
OOZIE-2530  Remove jline from parent and sharelib pig pom
https://issues-test.apache.org/jira/browse/OOZIE-2530
OOZIE-2528  Print out environment variables in LauncherMapper
https://issues-test.apache.org/jira/browse/OOZIE-2528
OOZIE-2521  Filter options are case sensitive for jobtye=bundle
https://issues-test.apache.org/jira/browse/OOZIE-2521
OOZIE-2518  Oozie is creating many files and directories in /tmp per day
https://issues-test.apache.org/jira/browse/OOZIE-2518
OOZIE-2517  Add support for startCreatedTime and endCreatedTime filters for 
coord and bundles
https://issues-test.apache.org/jira/browse/OOZIE-2517
OOZIE-2513  log.scan.duration should not be used for error and audit logs
https://issues-test.apache.org/jira/browse/OOZIE-2513
OOZIE-2512  ShareLibservice returns incorrect path for jar
https://issues-test.apache.org/jira/browse/OOZIE-2512
OOZIE-2508  Documentation change for Coord action rerun [OOZIE-1735]
https://issues-test.apache.org/jira/browse/OOZIE-2508
OOZIE-2501  ZK reentrant lock doesn't work for few cases
https://issues-test.apache.org/jira/browse/OOZIE-2501
OOZIE-2500  -DtestJarSimple option mentioned in minioozie doc does not work
https://issues-test.apache.org/jira/browse/OOZIE-2500
OOZIE-2499  map-reduce launcher does not need distributed files, archives 
except  jar of input/outputformat class
https://issues-test.apache.org/jira/browse/OOZIE-2499
OOZIE-2498  Oozie CallerId configuration for downstream components 
https://issues-test.apache.org/jira/browse/OOZIE-2498
OOZIE-2495  change action status from  ErrorType.NON_TRANSIENT to TRANSIENT 
when SSH action occurs AUTH_FAILED occasionally
https://issues-test.apache.org/jira/browse/OOZIE-2495
OOZIE-2491  oozie acl cannot specify group,it does`t work
https://issues-test.apache.org/jira/browse/OOZIE-2491
OOZIE

[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (89 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2780  Upgrade hadoop-common version to 2.6.0
https://issues.apache.org/jira/browse/OOZIE-2780
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues.apache.org/jira/browse/OOZIE-2779
OOZIE-2778  Copy only jetty.version related server dependencies to distro 
https://issues.apache.org/jira/browse/OOZIE-2778
OOZIE-2777  Config-default.xml longer than 64k results in  
java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
OOZIE-2769  Extend FS action to allow setrep on a file
https://issues.apache.org/jira/browse/OOZIE-2769
OOZIE-2766  Coordinator rerun should start actions in action id order
https://issues.apache.org/jira/browse/OOZIE-2766
OOZIE-2753  Update Docs for Jetty Tomcat changes
https://issues.apache.org/jira/browse/OOZIE-2753
OOZIE-2751  LocalOozieClient is missing methods from OozieClient
https://issues.apache.org/jira/browse/OOZIE-2751
OOZIE-2750  Spelling errors in the log messages and exception messages
https://issues.apache.org/jira/browse/OOZIE-2750
OOZIE-2746  Several tests failure in TestV2ValidateServlet.java
https://issues.apache.org/jira/browse/OOZIE-2746
OOZIE-2739  Remove property expansion pattern from ShellMain's log4j properties 
content
https://issues.apache.org/jira/browse/OOZIE-2739
OOZIE-2736  Reduce the number of threads during test execution
https://issues.apache.org/jira/browse/OOZIE-2736
OOZIE-2733  change org.apache.hadoop.fs.permission.AccessControlException to 
org.apache.hadoop.security.AccessControlException
https://issues.apache.org/jira/browse/OOZIE-2733
OOZIE-2726  Flaky test due to daylight saving changes
https://issues.apache.org/jira/browse/OOZIE-2726
OOZIE-2713  Provide an option to log out contents of the localized jar files
https://issues.apache.org/jira/browse/OOZIE-2713
OOZIE-2701  Oozie to support Multiple HCatalog URIs
https://issues.apache.org/jira/browse/OOZIE-2701
OOZIE-2694  Add logging for FsActionExecutor 
https://issues.apache.org/jira/browse/OOZIE-2694
OOZIE-2693  SimpleHCatDependencyCache.removeMissingDependency can throw NPE
https://issues.apache.org/jira/browse/OOZIE-2693
OOZIE-2692  Oozie job submit doesn't report error message to user if there is 
any issue with job conf
https://issues.apache.org/jira/browse/OOZIE-2692
OOZIE-2684  Bad database schema error for WF_ACTIONS table
https://issues.apache.org/jira/browse/OOZIE-2684
OOZIE-2681  fix javadoc to compile on JDK8 again
https://issues.apache.org/jira/browse/OOZIE-2681
OOZIE-2670  Upgrade Hbase to 1.2
https://issues.apache.org/jira/browse/OOZIE-2670
OOZIE-2668  Status update and recovery problems when coord action and its 
children not in sync
https://issues.apache.org/jira/browse/OOZIE-2668
OOZIE-2662  DB migration fails if DB is too big
https://issues.apache.org/jira/browse/OOZIE-2662
OOZIE-2652  Skip trash while deleting hive table partition
https://issues.apache.org/jira/browse/OOZIE-2652
OOZIE-2650  Retry coord start on database exceptions
https://issues.apache.org/jira/browse/OOZIE-2650
OOZIE-2644  Skip queuing Notification Commands when there's nothing to notify
https://issues.apache.org/jira/browse/OOZIE-2644
OOZIE-2641  rerunning an oozie coordinator job stucks on waiting
https://issues.apache.org/jira/browse/OOZIE-2641
OOZIE-2630  Oozie Coordinator EL Functions to get first day of the week/month
https://issues.apache.org/jira/browse/OOZIE-2630
OOZIE-2629  Get OozieShareLibCLI to perform a final rename to destPath when 
creating a Sharelib
https://issues.apache.org/jira/browse/OOZIE-2629
OOZIE-2618  Include hive-common in hive-beeline as compile component for 
hive-server2 (hive2 action)
https://issues.apache.org/jira/browse/OOZIE-2618
OOZIE-2608  Comma in oozie.service.JPAService.jdbc.password value results in 
authentication error
https://issues.apache.org/jira/browse/OOZIE-2608
OOZIE-2585  Disable or remove test case 
TestPartitionDependencyManagerEhcache.testMemoryUsageAndSpeedOverflowToDisk and 
testMemoryUsageAndSpeed
https://issues.apache.org/jira/browse/OOZIE-2585
OOZIE-2573  dataset url  which contains spaces can not be handled rightly
https://issues.apache.org/jira/browse/OOZIE-2573
OOZIE-2568  SSH  action pretends to retry automaticly when it failed
https://issues.apache.org/jira/browse/OOZIE-2568
OOZIE-2564  Create new log4j config for unit tests so that logged messages 
contain threads
https://issues.apache.org/jira/browse/OOZIE-2564
OOZIE-2540  Create a PySpark example
https://issues.apach

[jira] [Commented] (OOZIE-2771) Allow retrieving keystore and truststore passwords from Hadoop Credential Provider

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837295#comment-15837295
 ] 

Abhishek Bafna commented on OOZIE-2771:
---

Thanks [~asasvari] for the patch and [~gezapeti] [~andras.piros] for the review.
Committed to master.

> Allow retrieving keystore and truststore passwords from Hadoop Credential 
> Provider
> --
>
> Key: OOZIE-2771
> URL: https://issues.apache.org/jira/browse/OOZIE-2771
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2771-01.patch
>
>
> Right now passwords for keystore and truststore 
> ({{oozie.https.keystore.pass}}, {{oozie.https.truststore.pass}}) are stored 
> in {{oozie-site.xml}} as cleartext.
> However, Oozie could take advantage of the Hadoop Credential Provider for 
> storing and retrieving that passwords similarly how the JDBC password 
> ({{oozie.service.JPAService.jdbc.password}}) is handled today (see 
> https://issues.apache.org/jira/browse/OOZIE-2272).
> This way keystore and truststore passwords could be masked in oozie-site.
> Note: {{ConfigurationService.getPassword}} is worth to look at.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2771) Allow retrieving keystore and truststore passwords from Hadoop Credential Provider

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837293#comment-15837293
 ] 

Abhishek Bafna commented on OOZIE-2771:
---

+1.

> Allow retrieving keystore and truststore passwords from Hadoop Credential 
> Provider
> --
>
> Key: OOZIE-2771
> URL: https://issues.apache.org/jira/browse/OOZIE-2771
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
> Attachments: OOZIE-2771-01.patch
>
>
> Right now passwords for keystore and truststore 
> ({{oozie.https.keystore.pass}}, {{oozie.https.truststore.pass}}) are stored 
> in {{oozie-site.xml}} as cleartext.
> However, Oozie could take advantage of the Hadoop Credential Provider for 
> storing and retrieving that passwords similarly how the JDBC password 
> ({{oozie.service.JPAService.jdbc.password}}) is handled today (see 
> https://issues.apache.org/jira/browse/OOZIE-2272).
> This way keystore and truststore passwords could be masked in oozie-site.
> Note: {{ConfigurationService.getPassword}} is worth to look at.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2619) Make Hive action defaults to match hive defaults when running from command line

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837284#comment-15837284
 ] 

Abhishek Bafna commented on OOZIE-2619:
---

Thanks [~venkatnrangan] for the patch. Committed to master.

> Make  Hive action defaults to match hive defaults when running from command 
> line
> 
>
> Key: OOZIE-2619
> URL: https://issues.apache.org/jira/browse/OOZIE-2619
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.0, 4.2.0
>Reporter: Venkat Ranganathan
>Assignee: Venkat Ranganathan
> Fix For: 5.0.0
>
> Attachments: OOZIE-2619.patch, OOZIE-2619.patch.2
>
>
> Over a few patches, we have done a few fixes to make Oozie Hive actions 
> easier for users.
> One of them was OOZIE-2051 which allows default hive and tez site xml configs 
> to be added to hive actions automatically by introducing action specific 
> configuration directory under oozie conf/action-conf directory and as a bonus 
> in an Ambari managed cluster the hive site changes done as part of the Hive 
> components are automatically reflected into the oozie hive action defaults.
> But there is one issue pending for Oozie hive actions.
> Oozie Hive jobs launched via hive action  are historically restricted to one 
> reducer by default (and also there are few other in terms of split sizes 
> etc).   Thisvis because of the way Oozie action config management is done and 
> how Hive was determining the reducers.   Hive uses mapreduce.job.reduces to 
> determine if the reducers have to be dynamically determined (when this 
> parameter is initialized to an invalid value -1) or explicitly determined by 
> the users.   In HiveConf, this is internally set to -1 if not in 
> hive-site.xml or in one of the set statements.
> Oozie, when it prepares the action configuration, has the 
> mapreduce.job.reduces set to 1 (from mapred-default).   As part of the hive 
> action, Oozie writes the action configuration prepared (the action.xml) also 
> as hive-site.xml with the value for mapreduce.job.reduces set to 1.
> There are a few ways to overcome this issue, true to Oozie being very
> flexible with lots of options :).  I may be missing a few other
> options here!
> # Explicitly set the mapreduce.job.reduces parameter in the configuration 
> element of the action
> Every hive workflow configuration has be changed
> #  Add the parameter to a job-xml for the action
> Once again affects all actions
> #  Set the parameter to disable loading of the default *-site.xml
> files as provided by OOZIE-2205
>We need to make sure that the  *-site.xml are otherwise available to the 
> containers - either have hadoop conf directory (typically /etc/hadoop/conf) 
> in the mapred framework classpath or explicitly make the files using other 
> mechanisms available (as files, archives, in sharelib ec).   The big issue is 
> that this affects rolling upgrades once you add explicit config dependency
> Unfortunately we can't use the default action config addition introduced in 
> OOZIE-2051 for adding one more configuration file to the oozie hive action 
> conf directory with hive MR defaults.
> The config files under the action-conf/hive/*.xml or action-conf/hive.xml are 
> all merged using the method injectDefaults which only updates the target only 
> if it does not exist in the target configuration map.   In our case, 
> mapreduce.job.reduces already exsits in the action default configuration 
> (coming from mapred-default.xml) and hence does not get overwritten from the 
> action-conf/hive configuration files.
> The fix (essentially one line of code change) is to use the copy method of 
> XConfiguration  to copy the action-default config instead of using the 
> injectDefaults method and then provide the action-default/hive.xm with the 
> required mapred hive parameters with hive expected initial values.
> This patch introduces a change that has potential backward compatibility 
> issues.
> * If the action-conf/.xml currently has entries that were no-ops so 
> far, they can be added to the action configuration.
> * Hive will work as expected when run as an Oozie action without users 
> needing to resort to changes!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2619) Make Hive action defaults to match hive defaults when running from command line

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837281#comment-15837281
 ] 

Abhishek Bafna commented on OOZIE-2619:
---

+1.

testcase passes locally.

> Make  Hive action defaults to match hive defaults when running from command 
> line
> 
>
> Key: OOZIE-2619
> URL: https://issues.apache.org/jira/browse/OOZIE-2619
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.0, 4.2.0
>Reporter: Venkat Ranganathan
>Assignee: Venkat Ranganathan
> Attachments: OOZIE-2619.patch, OOZIE-2619.patch.2
>
>
> Over a few patches, we have done a few fixes to make Oozie Hive actions 
> easier for users.
> One of them was OOZIE-2051 which allows default hive and tez site xml configs 
> to be added to hive actions automatically by introducing action specific 
> configuration directory under oozie conf/action-conf directory and as a bonus 
> in an Ambari managed cluster the hive site changes done as part of the Hive 
> components are automatically reflected into the oozie hive action defaults.
> But there is one issue pending for Oozie hive actions.
> Oozie Hive jobs launched via hive action  are historically restricted to one 
> reducer by default (and also there are few other in terms of split sizes 
> etc).   Thisvis because of the way Oozie action config management is done and 
> how Hive was determining the reducers.   Hive uses mapreduce.job.reduces to 
> determine if the reducers have to be dynamically determined (when this 
> parameter is initialized to an invalid value -1) or explicitly determined by 
> the users.   In HiveConf, this is internally set to -1 if not in 
> hive-site.xml or in one of the set statements.
> Oozie, when it prepares the action configuration, has the 
> mapreduce.job.reduces set to 1 (from mapred-default).   As part of the hive 
> action, Oozie writes the action configuration prepared (the action.xml) also 
> as hive-site.xml with the value for mapreduce.job.reduces set to 1.
> There are a few ways to overcome this issue, true to Oozie being very
> flexible with lots of options :).  I may be missing a few other
> options here!
> # Explicitly set the mapreduce.job.reduces parameter in the configuration 
> element of the action
> Every hive workflow configuration has be changed
> #  Add the parameter to a job-xml for the action
> Once again affects all actions
> #  Set the parameter to disable loading of the default *-site.xml
> files as provided by OOZIE-2205
>We need to make sure that the  *-site.xml are otherwise available to the 
> containers - either have hadoop conf directory (typically /etc/hadoop/conf) 
> in the mapred framework classpath or explicitly make the files using other 
> mechanisms available (as files, archives, in sharelib ec).   The big issue is 
> that this affects rolling upgrades once you add explicit config dependency
> Unfortunately we can't use the default action config addition introduced in 
> OOZIE-2051 for adding one more configuration file to the oozie hive action 
> conf directory with hive MR defaults.
> The config files under the action-conf/hive/*.xml or action-conf/hive.xml are 
> all merged using the method injectDefaults which only updates the target only 
> if it does not exist in the target configuration map.   In our case, 
> mapreduce.job.reduces already exsits in the action default configuration 
> (coming from mapred-default.xml) and hence does not get overwritten from the 
> action-conf/hive configuration files.
> The fix (essentially one line of code change) is to use the copy method of 
> XConfiguration  to copy the action-default config instead of using the 
> injectDefaults method and then provide the action-default/hive.xm with the 
> required mapred hive parameters with hive expected initial values.
> This patch introduces a change that has potential backward compatibility 
> issues.
> * If the action-conf/.xml currently has entries that were no-ops so 
> far, they can be added to the action configuration.
> * Hive will work as expected when run as an Oozie action without users 
> needing to resort to changes!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837221#comment-15837221
 ] 

Abhishek Bafna commented on OOZIE-2041:
---

[~rohini] Can you please take a look? Thanks.

> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch, 
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch, 
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch, 
> OOZIE-2041-08.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.  
> We can add a new admin command to run this.  e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we 
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either 
> it's already running (i.e. the user sent it twice) or if the scheduled 
> PurgeService is already running it.  On top of that, we may need extra 
> consideration for HA setups where we currently only run it on the leader.  
> We should probably also have a to not schedule the PurgeService in ooize-site 
> for users who only want to run it manually.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

[András Piros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51029/#review162866
---




core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 520)


`testCoord_endOfMonthTillMiddleOfNext_differenceIsCalculatedCorrectly()` 
would be a better name.



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 538)


`testCoord_middleOfMonth_tillEndOfNext_differenceIsCalculatedCorrectly()` 
would be a better name.



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 546)


I like that :)



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 551 - 559)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 563)


`testCoord_startIsAfterEnd_throw()` would be a better name.



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 564 - 573)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 576)


`testCoord_latestEnd_notSupported()` would be a better name.



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 577 - 585)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(line 589)


`testCoord_endOfWeeksTillCurrent_correct()` would be a better name.



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 624 - 632)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 637 - 646)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 650 - 658)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 715 - 723)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedException.none();
...
expected.expect(MyOoziException.class);
expected.expectMessage(myExceptionMessageString);
performAndThrow();
```



core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
(lines 737 - 746)


For all similar `try-catch` stories like this, beginning w/ JUnit 4.7:

```
@Rule
public ExpectedException expected = ExpectedExce

Build failed in Jenkins: oozie-trunk-precommit-build #3578

[Apache Jenkins Server]

See 

--
[...truncated 14801 lines...]
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/dependency/URIHandler.Context.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/dependency/HCatURIHandler.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/dependency/URIHandler.DependencyType.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/DagEngine.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/WorkflowActionBean.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/XException.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/BaseEngine.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/docs/core/apidocs/src-html/org/apache/oozie/WorkflowJobBean.html
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/js/table/jquery-ui-timepicker-addon.js
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/js/table/jquery-ui-1.10.3.custom.min.js
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/css/images/ui-bg_glass_100_f6f6f6_1x400.png
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/css/images/ui-bg_flat_100_DEECFD_40x100.png
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/css/images/ui-icons_22_256x240.png
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/css/images/ui-bg_glass_65_ff_1x400.png
 longer than 100 characters.
[WARNING] Entry: 
oozie-4.4.0-SNAPSHOT/embedded-oozie-server/webapp/console/sla/css/images/ui-bg_highlight-soft_100_ee_1x100.png
 longer than 100 characters.
[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ 
oozie-zookeeper-security-tests ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
oozie-zookeeper-security-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Oozie Main .. SUCCESS [  1.469 s]
[INFO] Apache Oozie Hadoop Utils hadoop-2-4.4.0-SNAPSHOT .. SUCCESS [  2.191 

[jira] [Commented] (OOZIE-2630) Oozie Coordinator EL Functions to get first day of the week/month

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836973#comment-15836973
 ] 

Hadoop QA commented on OOZIE-2630:
--

Testing JIRA OOZIE-2630

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 11 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 6 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that 
must be fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:red}-1{color} There are [3] new bugs found below threshold in 
[core] that must be fixed.
.You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The most important FindBugs errors are:
.At CoordCommandUtils.java:[line 79]: 
org.apache.oozie.command.coord.CoordCommandUtils.ENDOFDAYS isn't final but 
should be
.At CoordCommandUtils.java:[line 77]: 
org.apache.oozie.command.coord.CoordCommandUtils.ENDOFMONTHS isn't final but 
should be
.At CoordCommandUtils.java:[line 78]: 
org.apache.oozie.command.coord.CoordCommandUtils.ENDOFWEEKS isn't final but 
should be
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1857
.Tests failed: 17
.Tests errors: 13

.The patch failed the following testcases:

.  
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
.  testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
.  
testOnWorkflowJobStartedEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnWorkflowJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnWorkflowJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnWorkflowJobSuspendEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  testWorkflowJobSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testWorkflowJobSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)
.  testWorkflowJobSelectorsOr(org.apache.oozie.jms.TestJMSJobEventListener)
.  testWorkflowJobSelectorsAnd(org.apache.oozie.jms.TestJMSJobEventListener)
.  testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnCoordinatorActionWaitingEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnCoordinatorActionStartEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnCoordinatorJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testOnCoordinatorJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testCoordinatorActionSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
.  
testCoordinatorActionSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)

.Tests failing with errors:
.  
testSubmitWithTimeout(org.apache.oozie.command.coord.TestCoo

[jira] [Updated] (OOZIE-2630) Oozie Coordinator EL Functions to get first day of the week/month

[Satish Subhashrao Saley (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Satish Subhashrao Saley updated OOZIE-2630:
---
Attachment: OOZIE-2630-3.patch

> Oozie Coordinator EL Functions to get first day of the week/month
> -
>
> Key: OOZIE-2630
> URL: https://issues.apache.org/jira/browse/OOZIE-2630
> Project: Oozie
>  Issue Type: New Feature
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Fix For: 5.0.0
>
> Attachments: OOZIE-2630-1.patch, OOZIE-2630-2.patch, 
> OOZIE-2630-3.patch
>
>
> Some users are demanding functions to give first day of week and first day of 
> month. It would help them in aggregation jobs accumulating data from first 
> day of the month/week to the intended date (current date). Currently we have 
> no way to define such start-instance with any existing EL function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

[Satish Saley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51029/
---

(Updated Jan. 24, 2017, 2:49 p.m.)


Review request for oozie.


Changes
---

Some changes in documentation


Bugs: OOZIE-2630
https://issues.apache.org/jira/browse/OOZIE-2630


Repository: oozie-git


Description
---

Oozie Coordinator EL Functions to get first day of the week/month


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
969336d 
  core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa 
  core/src/main/java/org/apache/oozie/coord/TimeUnit.java 5b37639 
  core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 
  core/src/main/resources/oozie-default.xml ad10386 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
7062e69 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 29e7ca1 
  core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be60133 
  core/src/test/resources/coord-dataset-endOfDays.xml PRE-CREATION 
  core/src/test/resources/coord-dataset-endOfMonths.xml PRE-CREATION 
  core/src/test/resources/coord-dataset-endOfWeeks.xml PRE-CREATION 
  docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 

Diff: https://reviews.apache.org/r/51029/diff/


Testing
---

Tested locally


Thanks,

Satish Saley

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

[Satish Saley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51029/
---

(Updated Jan. 24, 2017, 2:28 p.m.)


Review request for oozie.


Bugs: OOZIE-2630
https://issues.apache.org/jira/browse/OOZIE-2630


Repository: oozie-git


Description
---

Oozie Coordinator EL Functions to get first day of the week/month


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
969336d 
  core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa 
  core/src/main/java/org/apache/oozie/coord/TimeUnit.java 5b37639 
  core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 
  core/src/main/resources/oozie-default.xml ad10386 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
7062e69 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 29e7ca1 
  core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be60133 
  core/src/test/resources/coord-dataset-endOfDays.xml PRE-CREATION 
  core/src/test/resources/coord-dataset-endOfMonths.xml PRE-CREATION 
  core/src/test/resources/coord-dataset-endOfWeeks.xml PRE-CREATION 
  docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 

Diff: https://reviews.apache.org/r/51029/diff/


Testing
---

Tested locally


Thanks,

Satish Saley

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

[Satish Saley]

> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 582-585
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 598-601
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 681-684
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 697-700
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  line 712
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 714-717
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  line 781
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I spent some time finding out the way to check wrapped exception message with 
ExpectedException, but there is no way to check the wrapped exception message 
string. Also, in future, (junit 5), ExpectedException is going to be removed. 
So dropping this.http://junit.org/junit5/docs/current/api/


> On Jan. 23, 2017, 11:47 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java,
> >  lines 783-786
> > 
> >
> > Use JUnit's `ExpectedException` instead:
> > 
> > https://github.com/junit-team/junit4/wiki/exception-testing

I

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Bacsko]

> On jan. 24, 2017, 2:50 du, Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, 
> > line 39
> > 
> >
> > I'd prefer a deterministic behaviour in an unit test.
> > 
> > I think it's better to use Strings.repeat() from Guava.
> 
> Peter Cseh wrote:
> I like the idea of random testing as it might bring out issues we're not 
> think about. E.g. that some charaters are represented with more than 2 bytes 
> in UTF-8

In that case, tests are not reproducible. It makes sense though, but if it 
fails, you won't know which was the input that caused the failure.

IMO it's better to supply a string which causes characters to be serialized 
with different byte lengths (1/2/3), then repeat this string until the desired 
length is not reached.

Example:

public static String TEST_STRING = "aabcdef?úéá?üó\u0800\u0850\u0900"; 

The last three chars will be encoded to a 3-byte sequence.


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
---


On jan. 24, 2017, 4:30 du, Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> ---
> 
> (Updated jan. 24, 2017, 4:30 du)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException  
> https://issues.apache.org/jira/browse/OOZIE-2777
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
> 2b13e6701226b7236d101d738aba6b6ebbabf4e5 
>   core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
> 496b0086f840c0c6fc60a74bdb3dc382c4db2612 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
> 47ff8ca2751926bb728ea3eba5d7fe11282c3176 
>   core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  a3c7b142d08101e2bb03737871db939133bd3cd2 
>   core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Bacsko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162832
---



- Peter Bacsko


On jan. 24, 2017, 4:30 du, Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> ---
> 
> (Updated jan. 24, 2017, 4:30 du)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException  
> https://issues.apache.org/jira/browse/OOZIE-2777
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
> 2b13e6701226b7236d101d738aba6b6ebbabf4e5 
>   core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
> 496b0086f840c0c6fc60a74bdb3dc382c4db2612 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
> 47ff8ca2751926bb728ea3eba5d7fe11282c3176 
>   core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  a3c7b142d08101e2bb03737871db939133bd3cd2 
>   core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Build failed in Jenkins: oozie-trunk-precommit-build #3577

[Apache Jenkins Server]

See 

--
[...truncated 4467 lines...]
[INFO] Copying commons-jexl-2.1.1.jar to 

[INFO] Copying commons-pool-1.5.4.jar to 

[INFO] Copying jaxb-impl-2.2.3-1.jar to 

[INFO] Copying jets3t-0.9.0.jar to 

[INFO] Copying datanucleus-rdbms-3.2.9.jar to 

[INFO] Copying hive-common-1.2.0.jar to 

[INFO] Copying snappy-java-1.0.4.1.jar to 

[INFO] Copying javax.annotation-api-1.2.jar to 

[INFO] Copying commons-compiler-2.7.6.jar to 

[INFO] Copying ant-1.9.1.jar to 

[INFO] Copying janino-2.7.6.jar to 

[INFO] Copying activemq-client-5.13.3.jar to 

[INFO] Copying guice-3.0.jar to 

[INFO] Copying httpclient-4.3.6.jar to 

[INFO] Copying xz-1.0.jar to 

[INFO] Copying zookeeper-3.4.5.jar to 

[INFO] Copying leveldbjni-all-1.8.jar to 

[INFO] Copying jetty-util-6.1.26.jar to 

[INFO] Copying velocity-1.5.jar to 

[INFO] Copying apache-log4j-extras-1.2.17.jar to 

[INFO] Copying xmlenc-0.52.jar to 

[INFO] Copying httpcore-4.3.3.jar to 

[INFO] Copying jetty-io-9.2.19.v20160908.jar to 

[INFO] Copying commons-beanutils-core-1.8.0.jar to 

[INFO] Copying antlr-2.7.7.jar to 

[INFO] Copying slf4j-log4j12-1.6.6.jar to 

[INFO] Copying datanucleus-api-jdo-3.2.6.jar to 

[INFO] Copying jung-api-2.0.1.jar to 

[INFO] Copying jta-1.1.jar to 

[INFO] Copying kryo-2.22.jar to 

[INFO] Copying hive-serde-1.2.0.jar to 

[INFO] Copying jetty-client-9.2.19.v20160908.jar to 

[INFO] Copying hadoop-yarn-serve

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Cseh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
---

(Updated Jan. 24, 2017, 4:30 p.m.)


Review request for oozie.


Repository: oozie-git


Description
---

Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
2b13e6701226b7236d101d738aba6b6ebbabf4e5 
  core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
496b0086f840c0c6fc60a74bdb3dc382c4db2612 
  core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
47ff8ca2751926bb728ea3eba5d7fe11282c3176 
  core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
PRE-CREATION 
  
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
 a3c7b142d08101e2bb03737871db939133bd3cd2 
  core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION 

Diff: https://reviews.apache.org/r/55879/diff/


Testing
---


Thanks,

Peter Cseh

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Cseh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
---

(Updated Jan. 24, 2017, 3:43 p.m.)


Review request for oozie.


Repository: oozie-git


Description
---

Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 
a06595d3b2b99dbe33ef5d55208435aaec151e1a 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
2b13e6701226b7236d101d738aba6b6ebbabf4e5 
  core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
496b0086f840c0c6fc60a74bdb3dc382c4db2612 
  core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
47ff8ca2751926bb728ea3eba5d7fe11282c3176 
  core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
PRE-CREATION 
  
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
 a3c7b142d08101e2bb03737871db939133bd3cd2 

Diff: https://reviews.apache.org/r/55879/diff/


Testing
---


Thanks,

Peter Cseh

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Cseh]

> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java, line 
> > 33
> > 
> >
> > Is it still 60k? Not 20k?

I'm looking at the size of the byte array now, not the string.


> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, 
> > line 34
> > 
> >
> > What about the case when the number of characters are below 20k?

It tests with a string of lenght 1, 10001, 20001  140001.


> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java, 
> > line 32
> > 
> >
> > Does it have to extend XTestCase?

Yes, LiteWorkflowApp needs some services. It was not started as one.


> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, 
> > line 39
> > 
> >
> > I'd prefer a deterministic behaviour in an unit test.
> > 
> > I think it's better to use Strings.repeat() from Guava.

I like the idea of random testing as it might bring out issues we're not think 
about. E.g. that some charaters are represented with more than 2 bytes in UTF-8


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
---


On Jan. 24, 2017, 1:25 p.m., Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> ---
> 
> (Updated Jan. 24, 2017, 1:25 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException  
> https://issues.apache.org/jira/browse/OOZIE-2777
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 
> a06595d3b2b99dbe33ef5d55208435aaec151e1a 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
> 2b13e6701226b7236d101d738aba6b6ebbabf4e5 
>   core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
> 496b0086f840c0c6fc60a74bdb3dc382c4db2612 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
> 47ff8ca2751926bb728ea3eba5d7fe11282c3176 
>   core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  a3c7b142d08101e2bb03737871db939133bd3cd2 
> 
> Diff: https://reviews.apache.org/r/55879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Build failed in Jenkins: oozie-trunk-precommit-build #3576

[Apache Jenkins Server]

See 

--
[...truncated 14337 lines...]
Synchronized access at JMSAccessorService.java:[line 283]: Synchronized 
access at JMSAccessorService.java:[line 283]
Synchronized access at JMSAccessorService.java:[line 286]: Synchronized 
access at JMSAccessorService.java:[line 285]
Synchronized access at JMSAccessorService.java:[line 287]: Synchronized 
access at JMSAccessorService.java:[line 287]
At JMSAccessorService.java:[line 85]: Write to static field 
org.apache.oozie.service.JMSAccessorService.LOG from instance method 
org.apache.oozie.service.JMSAccessorService.init(Services)
At JMSTopicService.java:[line 99]: Write to static field 
org.apache.oozie.service.JMSTopicService.LOG from instance method 
org.apache.oozie.service.JMSTopicService.init(Services)
At JPAService.java:[line 141]: Write to static field 
org.apache.oozie.service.JPAService.LOG from instance method 
org.apache.oozie.service.JPAService.init(Services)
At JobsConcurrencyService.java:[line 47]: Write to static field 
org.apache.oozie.service.JobsConcurrencyService.urls from instance method 
org.apache.oozie.service.JobsConcurrencyService.init(Services)
At MetricsInstrumentationService.java:[line 54]: Write to static field 
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance 
method org.apache.oozie.service.MetricsInstrumentationService.destroy()
At MetricsInstrumentationService.java:[line 45]: Write to static field 
org.apache.oozie.service.InstrumentationService.instrumentation from instance 
method org.apache.oozie.service.MetricsInstrumentationService.init(Services)
At MetricsInstrumentationService.java:[line 46]: Write to static field 
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance 
method org.apache.oozie.service.MetricsInstrumentationService.init(Services)
At PartitionDependencyManagerService.java:[line 96]: Unread field: 
org.apache.oozie.service.PartitionDependencyManagerService$CachePurgeWorker.cache
Dereferenced at RecoveryService.java:[line 213]: Possible null pointer 
dereference of bundleJob in 
org.apache.oozie.service.RecoveryService$RecoveryRunnable.runBundleRecovery()
Known null at RecoveryService.java:[line 209]: Null value at 
RecoveryService.java:[line 208]
At Service.java:[line 56]: Initialization of 
org.apache.oozie.service.Service accesses class 
org.apache.oozie.service.ConfigurationService, which isn't initialized yet
At Services.java:[lines 105-109]: Incorrect lazy initialization of static 
field org.apache.oozie.service.Services.SERVICES in new 
org.apache.oozie.service.Services()
At Services.java:[line 132]: Exceptional return value of 
java.io.File.delete() ignored in 
org.apache.oozie.service.Services.createRuntimeDir()
At Services.java:[line 109]: Write to static field 
org.apache.oozie.service.Services.SERVICES from instance method new 
org.apache.oozie.service.Services()
At Services.java:[line 349]: Write to static field 
org.apache.oozie.service.Services.SERVICES from instance method 
org.apache.oozie.service.Services.destroy()
At Services.java:[line 211]: Write to static field 
org.apache.oozie.service.Services.SERVICES from instance method 
org.apache.oozie.service.Services.init()
org.apache.oozie.service.Services.getSystemMode() is unsynchronized, 
org.apache.oozie.service.Services.setSystemMode(OozieClient$SYSTEM_MODE) is 
synchronized: Another occurrence at Services.java:[line 221]
Result of integer multiplication cast to long in new 
org.apache.oozie.service.ShareLibService(): At Services.java:[line 155]
Result of integer multiplication cast to long in 
org.apache.oozie.service.ShareLibService.init(Services): At 
ShareLibService.java:[line 113]
org.apache.oozie.service.ShareLibService.SHARE_LIB_CONF_PREFIX isn't final 
but should be: At ShareLibService.java:[line 162]
Call to method of static java.text.DateFormat in 
org.apache.oozie.service.ShareLibService.getLatestLibPath(Path, String): At 
ShareLibService.java:[line 103]
Call to method of static java.text.DateFormat in 
org.apache.oozie.service.ShareLibService.getLauncherlibPath(): At 
ShareLibService.java:[line 692]
org.apache.oozie.service.ShareLibService.dateFormat is a static field of 
type java.text.DateFormat, which isn't thread safe: At 
ShareLibService.java:[line 662]
Call to method of static java.text.DateFormat in 
org.apache.oozie.service.ShareLibService$2.accept(Path): In ShareLibService.java
Found reliance on default encoding in 
org.apache.oozie.service.SparkConfigurationService.loadSparkConfigs(): new 
java.io.FileReader(File): At ShareLibService.java:[line 479]
org.apache.oozie.service.StatusTransitService.lastInstanceStartTime should 
be package protected: At SparkConfigurationService.java:[line 85]
org.apache.oozie.service.StatusTransitService.limit isn

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[András Piros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162813
---


Ship it!




Ship It!

- András Piros


On Jan. 24, 2017, 1:25 p.m., Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> ---
> 
> (Updated Jan. 24, 2017, 1:25 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException  
> https://issues.apache.org/jira/browse/OOZIE-2777
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 
> a06595d3b2b99dbe33ef5d55208435aaec151e1a 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
> 2b13e6701226b7236d101d738aba6b6ebbabf4e5 
>   core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
> 496b0086f840c0c6fc60a74bdb3dc382c4db2612 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
> 47ff8ca2751926bb728ea3eba5d7fe11282c3176 
>   core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  a3c7b142d08101e2bb03737871db939133bd3cd2 
> 
> Diff: https://reviews.apache.org/r/55879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Bacsko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
---




core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 33)


Is it still 60k? Not 20k?



core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 38)


Typo



core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java (line 
131)


Is this code path covered with test?



core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 
34)


What about the case when the number of characters are below 20k?



core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 
39)


I'd prefer a deterministic behaviour in an unit test.

I think it's better to use Strings.repeat() from Guava.



core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
(line 32)


Does it have to extend XTestCase?



core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
(line 45)


Shouldn't be a class variable if it's used in only one method. Also, 
probably we should stick to a deterministic input.


- Peter Bacsko


On jan. 24, 2017, 1:25 du, Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> ---
> 
> (Updated jan. 24, 2017, 1:25 du)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException  
> https://issues.apache.org/jira/browse/OOZIE-2777
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 
> a06595d3b2b99dbe33ef5d55208435aaec151e1a 
>   core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
> 2b13e6701226b7236d101d738aba6b6ebbabf4e5 
>   core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
> 496b0086f840c0c6fc60a74bdb3dc382c4db2612 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
> 47ff8ca2751926bb728ea3eba5d7fe11282c3176 
>   core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
>  a3c7b142d08101e2bb03737871db939133bd3cd2 
> 
> Diff: https://reviews.apache.org/r/55879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

[Peter Cseh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
---

Review request for oozie.


Repository: oozie-git


Description
---

Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777


Diffs
-

  core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java 
a06595d3b2b99dbe33ef5d55208435aaec151e1a 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 
2b13e6701226b7236d101d738aba6b6ebbabf4e5 
  core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 
496b0086f840c0c6fc60a74bdb3dc382c4db2612 
  core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
47ff8ca2751926bb728ea3eba5d7fe11282c3176 
  core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 
PRE-CREATION 
  
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
 a3c7b142d08101e2bb03737871db939133bd3cd2 

Diff: https://reviews.apache.org/r/55879/diff/


Testing
---


Thanks,

Peter Cseh