[jira] [Commented] (OOZIE-3105) testJMXInstrumentation from the org.apache.oozie.util.TestMetricsInstrumentation class is flaky

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412339#comment-16412339
 ] 

Hadoop QA commented on OOZIE-3105:
--


Testing JIRA OOZIE-3105

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2096
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/465/



> testJMXInstrumentation from the 
> org.apache.oozie.util.TestMetricsInstrumentation class is flaky
> ---
>
> Key: OOZIE-3105
> URL: https://issues.apache.org/jira/browse/OOZIE-3105
> Project: Oozie
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 4.3.0
> Environment: mvn: 3.5.0
> java: 1.8.0.144
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: OOZIE-3105-00.patch
>
>
> I'm able to reproduce the test failure consistently by running test in 
> isolation with the following command
> {code}
> mvn clean 
> -Dtest=org.apache.oozie.util.TestMetricsInstrumentation#testJMXInstrumentation
>  test
> {code}
> the test succeeds consistently with the following
> {code}
> mvn clean -Dtest=org.apache.oozie.util.TestMetricsInstrumentation test
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Success: OOZIE-3105 PreCommit Build #465

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3105
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/465/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.70 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/hcatalog].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/pig].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3105

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [tools].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2096
+1 DISTRO
+1 distro tarball builds with the patch 


+1 Overall result, good!, no -1s

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/465/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  29520 0  100  2952  0   4523 --:--:-- --:--:-- --:--:--  
4520{"self":"https://issues.apache.org/jira/rest/api/2/issue/1311/comment/16412339","id":"16412339","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 

[jira] [Commented] (OOZIE-2726) Flaky test due to daylight saving changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412335#comment-16412335
 ] 

Hadoop QA commented on OOZIE-2726:
--


Testing JIRA OOZIE-2726

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 2 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 2 new RAT warning(s)
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2104
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/464/



> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at 

Failed: OOZIE-2726 PreCommit Build #464

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2726
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/464/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.69 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2244 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2726

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 2 testcase(s)
-1 RAT
-1 the patch seems to introduce 2 new RAT warning(s)
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2104
Tests failed: 1
Tests errors: 0

The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/464/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  33350 0  100  3335  0   3444 --:--:-- --:--:-- --:--:--  
3445{"self":"https://issues.apache.org/jira/rest/api/2/issue/13019006/comment/16412335","id":"16412335","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-2726\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:green}+1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce any @author tags\n.{color:green}+1{color} the patch does not 
introduce any tabs\n.{color:green}+1{color} the patch does not introduce 
any 

[jira] [Commented] (OOZIE-3105) testJMXInstrumentation from the org.apache.oozie.util.TestMetricsInstrumentation class is flaky

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412262#comment-16412262
 ] 

Hadoop QA commented on OOZIE-3105:
--

PreCommit-OOZIE-Build started


> testJMXInstrumentation from the 
> org.apache.oozie.util.TestMetricsInstrumentation class is flaky
> ---
>
> Key: OOZIE-3105
> URL: https://issues.apache.org/jira/browse/OOZIE-3105
> Project: Oozie
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 4.3.0
> Environment: mvn: 3.5.0
> java: 1.8.0.144
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: OOZIE-3105-00.patch
>
>
> I'm able to reproduce the test failure consistently by running test in 
> isolation with the following command
> {code}
> mvn clean 
> -Dtest=org.apache.oozie.util.TestMetricsInstrumentation#testJMXInstrumentation
>  test
> {code}
> the test succeeds consistently with the following
> {code}
> mvn clean -Dtest=org.apache.oozie.util.TestMetricsInstrumentation test
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2726) Flaky test due to daylight saving changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412254#comment-16412254
 ] 

Hadoop QA commented on OOZIE-2726:
--

PreCommit-OOZIE-Build started


> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2967) TestStatusTransitService.testBundleStatusCoordSubmitFails fails intermittently in Apache Oozie Core 5.0.0-SNAPSHOT

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2967:

Fix Version/s: 5.1.0

> TestStatusTransitService.testBundleStatusCoordSubmitFails fails 
> intermittently in Apache Oozie Core 5.0.0-SNAPSHOT
> --
>
> Key: OOZIE-2967
> URL: https://issues.apache.org/jira/browse/OOZIE-2967
> Project: Oozie
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 5.0.0
> Environment: $ uname -a
> Linux pts00450-vm24 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 
> 17:42:36 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux
>Reporter: Parita Johari
>Priority: Minor
> Fix For: 5.1.0
>
>
> {code:java}
> Stacktrace
> junit.framework.AssertionFailedError: expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:86)
>   at junit.framework.TestCase.assertEquals(TestCase.java:253)
>   at 
> org.apache.oozie.service.TestStatusTransitService.testBundleStatusCoordSubmitFails(TestStatusTransitService.java:1647)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:255)
>   at junit.framework.TestSuite.run(TestSuite.java:250)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
>   at org.junit.runners.Suite.runChild(Suite.java:127)
>   at org.junit.runners.Suite.runChild(Suite.java:26)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3111) [Umbrella] Fix flaky tests in Oozie

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3111:

Fix Version/s: (was: 5.0.0)

> [Umbrella] Fix flaky tests in Oozie
> ---
>
> Key: OOZIE-3111
> URL: https://issues.apache.org/jira/browse/OOZIE-3111
> Project: Oozie
>  Issue Type: Bug
>  Components: tests
>Reporter: Peter Bacsko
>Assignee: Peter Cseh
>Priority: Major
>
> In Oozie, we've had a number or flaky tests for quite a while. In order to 
> have successful builds, we circumvented the problem by re-running failed 
> tests. But this is not a good long-term solution.
> This JIRA tracks the tests that are currently flaky. We should address each 
> of these tests to have stable builds.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2968) TestJavaActionExecutor.testCredentialsSkip fails intermittently in Apache Oozie Core 5.0.0-SNAPSHOT

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2968:

Fix Version/s: 5.1.0

> TestJavaActionExecutor.testCredentialsSkip fails intermittently in Apache 
> Oozie Core 5.0.0-SNAPSHOT
> ---
>
> Key: OOZIE-2968
> URL: https://issues.apache.org/jira/browse/OOZIE-2968
> Project: Oozie
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 5.0.0
> Environment: $ uname -a
> Linux pts00450-vm24 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 
> 17:42:36 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux
>Reporter: Parita Johari
>Priority: Minor
> Fix For: 5.1.0
>
>
> {code:java}
> Stacktrace
> org.apache.oozie.action.ActionExecutorException: JA020: Could not load 
> credentials of type [abc] with name [abcname]]; perhaps it was not defined in 
> oozie-site.xml?
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setCredentialTokens(JavaActionExecutor.java:1202)
>   at 
> org.apache.oozie.action.hadoop.TestJavaActionExecutor._testCredentialsSkip(TestJavaActionExecutor.java:1096)
>   at 
> org.apache.oozie.action.hadoop.TestJavaActionExecutor.testCredentialsSkip(TestJavaActionExecutor.java:995)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:255)
>   at junit.framework.TestSuite.run(TestSuite.java:250)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
>   at org.junit.runners.Suite.runChild(Suite.java:127)
>   at org.junit.runners.Suite.runChild(Suite.java:26)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3105) testJMXInstrumentation from the org.apache.oozie.util.TestMetricsInstrumentation class is flaky

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3105:

Fix Version/s: 5.1.0

> testJMXInstrumentation from the 
> org.apache.oozie.util.TestMetricsInstrumentation class is flaky
> ---
>
> Key: OOZIE-3105
> URL: https://issues.apache.org/jira/browse/OOZIE-3105
> Project: Oozie
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 4.3.0
> Environment: mvn: 3.5.0
> java: 1.8.0.144
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.1.0
>
> Attachments: OOZIE-3105-00.patch
>
>
> I'm able to reproduce the test failure consistently by running test in 
> isolation with the following command
> {code}
> mvn clean 
> -Dtest=org.apache.oozie.util.TestMetricsInstrumentation#testJMXInstrumentation
>  test
> {code}
> the test succeeds consistently with the following
> {code}
> mvn clean -Dtest=org.apache.oozie.util.TestMetricsInstrumentation test
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2726:

Fix Version/s: 5.0.0

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2459) TestCoordActionInputCheckXCommand.testNone is flakey

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2459:

Fix Version/s: 5.1.0

> TestCoordActionInputCheckXCommand.testNone is flakey
> 
>
> Key: OOZIE-2459
> URL: https://issues.apache.org/jira/browse/OOZIE-2459
> Project: Oozie
>  Issue Type: Sub-task
>  Components: action, tests
>Affects Versions: 4.1.0
>Reporter: Ferenc Denes
>Assignee: Peter Bacsko
>Priority: Minor
> Fix For: 5.1.0
>
> Attachments: OOZIE-2459-1.patch
>
>
> TestCoordActionInputCheckXCommand.testNone is flakey.
> Also the TestCoordActionInputCheckXCommandNonUTC.testNone which is very 
> similar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66262/
---

Review request for oozie, Peter Cseh and Satish Saley.


Repository: oozie-git


Description
---

[OOZIE-2726] Flaky test due to daylight saving changes. Review request #2.

Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) 
of the [review request #1](https://reviews.apache.org/r/53775).


Diffs
-

  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b9125387b4e356e408e112c55af7bb3f1c39d3e 
  
core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java 
PRE-CREATION 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 61bbbfe3d1dde89b875c30c75e875efc9227f05d 
  
core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66262/diff/1/


Testing
---

`TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator`


Thanks,

András Piros

[jira] [Updated] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2726:

Attachment: OOZIE-2726.006.patch

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411781#comment-16411781
 ] 

Hadoop QA commented on OOZIE-2645:
--


Testing JIRA OOZIE-2645

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2096
.Tests failed: 6
.Tests errors: 10

.The patch failed the following testcases:

testInstrumentation(org.apache.oozie.servlet.TestAdminServlet)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testInstrumentation(org.apache.oozie.servlet.TestV1AdminServlet)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testIsEnabled(org.apache.oozie.service.TestInstrumentationService)
testInstrumentation(org.apache.oozie.service.TestInstrumentationService)

.Tests failing with errors:
testActionCheckPreCondition1(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition2(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition3(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition4(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionStartPreCondition1(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition2(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition3(org.apache.oozie.command.wf.TestActionStartXCommand)
testEarlyCallbackTimeout(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testEarlyCallbackTransitionToRunning(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/463/



> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: 

Failed: OOZIE-2645 PreCommit Build #463

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2645
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/463/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.72 MB...]

Testing JIRA OOZIE-2645

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2096
Tests failed: 6
Tests errors: 10

The patch failed the following testcases:

testInstrumentation(org.apache.oozie.servlet.TestAdminServlet)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testInstrumentation(org.apache.oozie.servlet.TestV1AdminServlet)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testIsEnabled(org.apache.oozie.service.TestInstrumentationService)
testInstrumentation(org.apache.oozie.service.TestInstrumentationService)

Tests failing with errors:
testActionCheckPreCondition1(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition2(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition3(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionCheckPreCondition4(org.apache.oozie.command.wf.TestActionCheckXCommand)
testActionStartPreCondition1(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition2(org.apache.oozie.command.wf.TestActionStartXCommand)
testActionStartPreCondition3(org.apache.oozie.command.wf.TestActionStartXCommand)
testEarlyCallbackTimeout(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testEarlyCallbackTransitionToRunning(org.apache.oozie.command.wf.TestCompletedActionXCommand)
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/463/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  45670 0  100  4567  0   4605 --:--:-- --:--:-- --:--:--  
4603{"self":"https://issues.apache.org/jira/rest/api/2/issue/12998382/comment/16411781","id":"16411781","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-2645\n\nCleaning local git 

[jira] [Comment Edited] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411682#comment-16411682
 ] 

Andras Piros edited comment on OOZIE-2726 at 3/23/18 4:41 PM:
--

[~satishsaley] taking over on the base of {{OOZIE\-2726\-4.patch}}.


was (Author: andras.piros):
[~satishsaley] taking over on the base of {{OOZIE-2726-4.patch}}.

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411682#comment-16411682
 ] 

Andras Piros commented on OOZIE-2726:
-

[~satishsaley] taking over on the base of {{OOZIE-2726-4.patch}}.

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3193) Applications are not killed when submitted via subworkflow

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411680#comment-16411680
 ] 

Hadoop QA commented on OOZIE-3193:
--


Testing JIRA OOZIE-3193

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:green}+1{color} the patch adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2097
.Tests failed: 2
.Tests errors: 0

.The patch failed the following testcases:

testSubWorkflowRerun(org.apache.oozie.action.oozie.TestSubWorkflowActionExecutor)
testSubWorkflowKillExternalChild(org.apache.oozie.action.oozie.TestSubWorkflowActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestHiveActionExecutor#testHiveAction
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/462/



> Applications are not killed when submitted via subworkflow
> --
>
> Key: OOZIE-3193
> URL: https://issues.apache.org/jira/browse/OOZIE-3193
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
>Priority: Major
> Attachments: OOZIE-3193.001.patch, OOZIE-3193.002.patch
>
>
> We're using tags to kill applications. Subworkflows have special tags like 
> {{workflowID@subwfAcitonID@actionID}} 
> Right now we're not getting the subWorkflow config properly in JavaAE.kill() 
> so we're looking for the tag {{subWorkflowID@actionID}} to kill. Therefore 
> actions submitted via subworkflows are not killed properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3193 PreCommit Build #462

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3193
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/462/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2250 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3193

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 1 line(s) longer than 132 characters
+1 the patch adds/modifies 3 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2097
Tests failed: 2
Tests errors: 0

The patch failed the following testcases:

testSubWorkflowRerun(org.apache.oozie.action.oozie.TestSubWorkflowActionExecutor)
testSubWorkflowKillExternalChild(org.apache.oozie.action.oozie.TestSubWorkflowActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestHiveActionExecutor#testHiveAction
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/462/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13143252/comment/16411680","id":"16411680","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-3193\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:red}-1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce any @author tags\n.{color:green}+1{color} the patch does not 
introduce any tabs\n.{color:green}+1{color} the patch does not 

[jira] [Commented] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411643#comment-16411643
 ] 

Hadoop QA commented on OOZIE-2645:
--

PreCommit-OOZIE-Build started


> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.
> 
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
> {{MetricsInstrumentationService}} the default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-2726:
---

Assignee: Andras Piros  (was: Satish Subhashrao Saley)

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3200) Drop Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3200:

Description: 
OOZIE-1817 added the option to use DropWizard Metrics instead of our homegrown 
Instrumentation. We left the Instrumentation as the default for compatibility; 
in Oozie 5.1.0, we should drop Instrumentation and only have Metrics.

OOZIE-2645 deprecated {{Instrumentation}} and made {{Metrics}} the default 
choice, but no code cleanup happened there.

We can also use this opportunity to clean up the code and interface for 
Metrics, which currently has to conform to Instrumentation for pluggability.

> Drop Instrumentation in favor of Metrics
> 
>
> Key: OOZIE-3200
> URL: https://issues.apache.org/jira/browse/OOZIE-3200
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Priority: Blocker
> Fix For: 5.1.0
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation. We left the Instrumentation as the default for 
> compatibility; in Oozie 5.1.0, we should drop Instrumentation and only have 
> Metrics.
> OOZIE-2645 deprecated {{Instrumentation}} and made {{Metrics}} the default 
> choice, but no code cleanup happened there.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-3200) Drop Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-3200:
---

Assignee: Andras Piros

> Drop Instrumentation in favor of Metrics
> 
>
> Key: OOZIE-3200
> URL: https://issues.apache.org/jira/browse/OOZIE-3200
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.1.0
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation. We left the Instrumentation as the default for 
> compatibility; in Oozie 5.1.0, we should drop Instrumentation and only have 
> Metrics.
> OOZIE-2645 deprecated {{Instrumentation}} and made {{Metrics}} the default 
> choice, but no code cleanup happened there.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OOZIE-3200) Drop Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

Andras Piros created OOZIE-3200:
---

 Summary: Drop Instrumentation in favor of Metrics
 Key: OOZIE-3200
 URL: https://issues.apache.org/jira/browse/OOZIE-3200
 Project: Oozie
  Issue Type: Improvement
  Components: monitoring
Affects Versions: 5.0.0
Reporter: Andras Piros
 Fix For: 5.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2645:

Description: 
OOZIE-1817 added the option to use DropWizard Metrics instead of our homegrown 
Instrumentation.  We left the Instrumentation as the default for compatibility; 
in Oozie 5, we should drop Instrumentation and only have Metrics.

We can also use this opportunity to clean up the code and interface for 
Metrics, which currently has to conform to Instrumentation for pluggability.



Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
{{MetricsInstrumentationService}} the default.

  was:
OOZIE-1817 added the option to use DropWizard Metrics instead of our homegrown 
Instrumentation.  We left the Instrumentation as the default for compatibility; 
in Oozie 5, we should drop Instrumentation and only have Metrics.

We can also use this opportunity to clean up the code and interface for 
Metrics, which currently has to conform to Instrumentation for pluggability.


> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.
> 
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
> {{MetricsInstrumentationService}} the default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66250: [OOZIE-2645] Deprecate Instrumentation in favor of Metrics

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66250/
---

Review request for oozie, Peter Cseh and Robert Kanter.


Repository: oozie-git


Description
---

[OOZIE-2645] Deprecate Instrumentation in favor of Metrics


Diffs
-

  core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
afa35113c7fc258d0da75bdbf183fc6f2a1e54ee 
  core/src/main/java/org/apache/oozie/util/Instrumentation.java 
a57b6655da6a6c28eb857691336ab27508ee8092 
  core/src/main/resources/oozie-default.xml 
966dd29b20ffb4a627418d62403c0cec166dd147 
  core/src/test/resources/oozie-site-instrumentation.xml 
ab3f0f5b99aabf149d409c762efd3feb51fe9f6d 
  docs/src/site/twiki/AG_Install.twiki 8e2d795da838d184940bc177e95e9dfb8b52cc54 
  docs/src/site/twiki/AG_Monitoring.twiki 
523f85133055b80b32b2cf73f1e8c25751cf9fc4 
  docs/src/site/twiki/DG_CommandLineTool.twiki 
a94201ded8451cc725b40e9f73182ecaa52be88a 
  docs/src/site/twiki/WebServicesAPI.twiki 
c662a5eefdfc012ea6c13256a3df426e1a073965 


Diff: https://reviews.apache.org/r/66250/diff/1/


Testing
---

Generated `mkdistro` and saw that `/admin/v2/metrics` is available, and 
`/admin/instrumentation` isn't.


Thanks,

András Piros

[jira] [Updated] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2645:

Summary: Deprecate Instrumentation in favor of Metrics  (was: Drop 
Instrumentation in favor of Metrics)

> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2645) Drop Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2645:

Attachment: OOZIE-2645.001.patch

> Drop Instrumentation in favor of Metrics
> 
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3193) Applications are not killed when submitted via subworkflow

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411508#comment-16411508
 ] 

Hadoop QA commented on OOZIE-3193:
--

PreCommit-OOZIE-Build started


> Applications are not killed when submitted via subworkflow
> --
>
> Key: OOZIE-3193
> URL: https://issues.apache.org/jira/browse/OOZIE-3193
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
>Priority: Major
> Attachments: OOZIE-3193.001.patch, OOZIE-3193.002.patch
>
>
> We're using tags to kill applications. Subworkflows have special tags like 
> {{workflowID@subwfAcitonID@actionID}} 
> Right now we're not getting the subWorkflow config properly in JavaAE.kill() 
> so we're looking for the tag {{subWorkflowID@actionID}} to kill. Therefore 
> actions submitted via subworkflows are not killed properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3056) Implement new mechanism to specify ShareLibs for workflow actions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411447#comment-16411447
 ] 

Hadoop QA commented on OOZIE-3056:
--


Testing JIRA OOZIE-3056

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2098
.{color:orange}Tests failed at first run:{color}
TestJMSJobEventListener#testConnectionDrop
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/461/



> Implement new mechanism to specify ShareLibs for workflow actions
> -
>
> Key: OOZIE-3056
> URL: https://issues.apache.org/jira/browse/OOZIE-3056
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Attila Sasvari
>Assignee: Peter Cseh
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-3056.001.patch, OOZIE-3056.002.patch, 
> OOZIE-3056.003.patch, OOZIE-3056.004.patch, OOZIE-3056.005.patch
>
>
> OOZIE-2687 introduces the {{launcher}} element for workflows:
> {code}
> 
> 1024
> 1
> -Dsome.property=true -XX:+RandomJVMSwitch
> key=value
> root.oozie
> spark,hive
> 
> {code}
> The purpose of this ticket is to discuss and implement new mechanism for 
> handling ShareLib. 
> {{addActionShareLib}} in {{JavaActionExecutor}} should adjusted. Regarding 
> "precedence order":
> if global and an action level {{launcher}} and {{configuration}} (e.g. 
> {{oozie.action.sharelib.for.#ACTIONTYPE#}}) tries to override the sharelib 
> the following should apply:
> {quote} 
> config properties defined in an action's  have priority over 
> an action's , which has priority over the global section's 
>  and , which has priority over the action defaults in 
> oozie-site, and so on.
> {quote}
> Here we have multiple choices how to handle sharelib:
> - Alternative 1: override sharelib in a way that is consistent with current 
> way of handling Oozie configuration settings.
> - Alternative 2: 

Success: OOZIE-3056 PreCommit Build #461

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3056
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/461/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[DEBUG] There are no new bugs found in [sharelib/pig].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3056

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 4 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [tools].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2098
Tests failed at first run:
TestJMSJobEventListener#testConnectionDrop
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


+1 Overall result, good!, no -1s

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/461/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  31230 0  100  3123  0   4019 --:--:-- --:--:-- --:--:--  
4019{"self":"https://issues.apache.org/jira/rest/api/2/issue/13102211/comment/16411447","id":"16411447","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 

[jira] [Commented] (OOZIE-3056) Implement new mechanism to specify ShareLibs for workflow actions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411305#comment-16411305
 ] 

Hadoop QA commented on OOZIE-3056:
--

PreCommit-OOZIE-Build started


> Implement new mechanism to specify ShareLibs for workflow actions
> -
>
> Key: OOZIE-3056
> URL: https://issues.apache.org/jira/browse/OOZIE-3056
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Attila Sasvari
>Assignee: Peter Cseh
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-3056.001.patch, OOZIE-3056.002.patch, 
> OOZIE-3056.003.patch, OOZIE-3056.004.patch, OOZIE-3056.005.patch
>
>
> OOZIE-2687 introduces the {{launcher}} element for workflows:
> {code}
> 
> 1024
> 1
> -Dsome.property=true -XX:+RandomJVMSwitch
> key=value
> root.oozie
> spark,hive
> 
> {code}
> The purpose of this ticket is to discuss and implement new mechanism for 
> handling ShareLib. 
> {{addActionShareLib}} in {{JavaActionExecutor}} should adjusted. Regarding 
> "precedence order":
> if global and an action level {{launcher}} and {{configuration}} (e.g. 
> {{oozie.action.sharelib.for.#ACTIONTYPE#}}) tries to override the sharelib 
> the following should apply:
> {quote} 
> config properties defined in an action's  have priority over 
> an action's , which has priority over the global section's 
>  and , which has priority over the action defaults in 
> oozie-site, and so on.
> {quote}
> Here we have multiple choices how to handle sharelib:
> - Alternative 1: override sharelib in a way that is consistent with current 
> way of handling Oozie configuration settings.
> - Alternative 2: make sharelib additive
> -- For example, if there is a global {{launcher}} with {{sharelib}} element 
> in a workflow that includes multiple ShareLibs (e.g. A,B), and  
> {{oozie.action.sharelib.for.#ACTIONTYPE#}} is also specified for an action's 
> configuration (e.g. C,D), then we take the union of the specified entities 
> (A,B,C,D would be included). 
> -- It's inconsistent with everything else



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66243: OOZIE-3193 Applications are not killed when submitted via subworkflow

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66243/#review199874
---




core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Line 1766 (original), 1766 (patched)


I don't really get the difference between `jobConf` and 
`context.getProtoActionConf`, but I think it's important.

Would you mind having some comments / JUnit examples for real contents?



core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 107-120 (patched)


Extract method `createSleepMapperReducerJobConf()`.



core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 129 (patched)


Some message to standard error?



core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 137 (patched)


Change signature to `writeJobID(Path, JobConf, String)`.



core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 138-142 (patched)


Use try-with-resources for `FileSystem` and `OutputStreamWriter`.



core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
Lines 145-152 (patched)


Use instead `writeJobID(Path, JobConf, String)`.



core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
Lines 35 (patched)


`SLEEP_TIME_MILLIS`



core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
Lines 46-50 (patched)


Extract method `sleepUninterrupted(long millis, String message)`.



core/src/test/java/org/apache/oozie/action/hadoop/SleepMapperReducerForTest.java
Lines 56-60 (patched)


Use instead method `sleepUninterrupted(long millis, String message)`.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Line 40 (original), 58 (patched)


Remove `*` import.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 542-543 (patched)


Extract method `killWorkflow(String id)` and remove comment.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 545-546 (patched)


Rename `childMRJobApplicationId` to `externalChildJobId` and remove comment.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 554 (patched)


Cannot decrypt `sack` :(



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 560 (patched)


Why not wait for `JOB_TIMEOUT`?



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 567 (patched)


Use `try-with-resources`.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 575-576 (patched)


Rename `ex` to `ignored` and remove comment.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 596-597 (patched)


Extract local variables `isSubWfRunning` and `isSubWfActionRunning`.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 597 (patched)


Use `getSubWFId()`.



core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 717-719 (patched)


Use `try-with-resources`.



src/main/resources/checkstyle.xml
Lines 29-32 (original)


Submit another patch for another JIRA, please.


- András Piros


On March 23, 2018, 10:50 a.m., Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66243/
> ---
> 
> (Updated March 23, 2018, 10:50 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Bugs: OOZIE-3193
> https://issues.apache.org/jira/browse/OOZIE-3193
> 
> 
> 

[jira] [Updated] (OOZIE-3193) Applications are not killed when submitted via subworkflow

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-3193:
--
Attachment: OOZIE-3193.002.patch

> Applications are not killed when submitted via subworkflow
> --
>
> Key: OOZIE-3193
> URL: https://issues.apache.org/jira/browse/OOZIE-3193
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
>Priority: Major
> Attachments: OOZIE-3193.001.patch, OOZIE-3193.002.patch
>
>
> We're using tags to kill applications. Subworkflows have special tags like 
> {{workflowID@subwfAcitonID@actionID}} 
> Right now we're not getting the subWorkflow config properly in JavaAE.kill() 
> so we're looking for the tag {{subWorkflowID@actionID}} to kill. Therefore 
> actions submitted via subworkflows are not killed properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3134) Potential inconsistency between the in-memory SLA map and the Oozie database

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411208#comment-16411208
 ] 

Andras Piros commented on OOZIE-3134:
-

[~kmarton] please address {{RAW_PATCH_ANALYSIS}} and {{FINDBUGS_DIFF}} errors, 
warnings. Thanks!

> Potential inconsistency between the in-memory SLA map and the Oozie database
> 
>
> Key: OOZIE-3134
> URL: https://issues.apache.org/jira/browse/OOZIE-3134
> Project: Oozie
>  Issue Type: Bug
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3134-001.patch, OOZIE-3134-002.patch, 
> OOZIE-3134-003.patch, OOZIE-3134-004.patch, OOZIE-3134-005.patch, 
> OOZIE-3134-006.patch
>
>
> Upon {{SLACalculatorMemory.addRegistration}}, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later [persists 
> it|https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L380]
>  in the Oozie database. 
> However, if there is a failure during the database operation, a 
> {{JPAExecutorException}} is thrown, and the entry [is not removed from the 
> SLA map| 
> https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L393].
> It may introduce inconsistency between the Oozie database and the SLA map.
> To prevent this, a rollback mechanism (with proper logging) should be 
> implemented.  It would also make sense to do more sanity/consistency check in 
> the Oozie server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3134 PreCommit Build #460

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3134
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/460/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2684 bytes
[TRACE] Full summary file size is 1748 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3134

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 1 line(s) longer than 132 characters
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [1] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [webapp].
 -1 There are [1] new bugs found below threshold in [core] that must be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The most important FindBugs errors are:
 At FailingConnectionWrapper.java:[line 175]: This use of 
java/sql/Connection.prepareStatement(Ljava/lang/String;II)Ljava/sql/PreparedStatement;
 can be vulnerable to SQL injection
 At FailingConnectionWrapper.java:[line 169]
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2100
Tests failed: 1
Tests errors: 0

The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/460/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13120523/comment/16411175","id":"16411175","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-3134\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:red}-1 
RAW_PATCH_ANALYSIS{color}\n.

[jira] [Commented] (OOZIE-3134) Potential inconsistency between the in-memory SLA map and the Oozie database

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411175#comment-16411175
 ] 

Hadoop QA commented on OOZIE-3134:
--


Testing JIRA OOZIE-3134

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [1] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At FailingConnectionWrapper.java:[line 175]: This use of 
java/sql/Connection.prepareStatement(Ljava/lang/String;II)Ljava/sql/PreparedStatement;
 can be vulnerable to SQL injection
. At FailingConnectionWrapper.java:[line 169]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2100
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/460/



> Potential inconsistency between the in-memory SLA map and the Oozie database
> 
>
> Key: OOZIE-3134
> URL: https://issues.apache.org/jira/browse/OOZIE-3134
> Project: Oozie
>  Issue Type: Bug
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3134-001.patch, OOZIE-3134-002.patch, 
> OOZIE-3134-003.patch, OOZIE-3134-004.patch, OOZIE-3134-005.patch, 
> OOZIE-3134-006.patch
>
>
> Upon {{SLACalculatorMemory.addRegistration}}, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later [persists 
> it|https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L380]
>  in the Oozie database. 
> However, if there is a failure during the database 

[jira] [Commented] (OOZIE-3134) Potential inconsistency between the in-memory SLA map and the Oozie database

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411013#comment-16411013
 ] 

Hadoop QA commented on OOZIE-3134:
--

PreCommit-OOZIE-Build started


> Potential inconsistency between the in-memory SLA map and the Oozie database
> 
>
> Key: OOZIE-3134
> URL: https://issues.apache.org/jira/browse/OOZIE-3134
> Project: Oozie
>  Issue Type: Bug
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3134-001.patch, OOZIE-3134-002.patch, 
> OOZIE-3134-003.patch, OOZIE-3134-004.patch, OOZIE-3134-005.patch, 
> OOZIE-3134-006.patch
>
>
> Upon {{SLACalculatorMemory.addRegistration}}, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later [persists 
> it|https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L380]
>  in the Oozie database. 
> However, if there is a failure during the database operation, a 
> {{JPAExecutorException}} is thrown, and the entry [is not removed from the 
> SLA map| 
> https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L393].
> It may introduce inconsistency between the Oozie database and the SLA map.
> To prevent this, a rollback mechanism (with proper logging) should be 
> implemented.  It would also make sense to do more sanity/consistency check in 
> the Oozie server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3134) Potential inconsistency between the in-memory SLA map and the Oozie database

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411007#comment-16411007
 ] 

Andras Piros commented on OOZIE-3134:
-

Thanks for the contribution [~kmarton]! +1 (pending Jenkins)

> Potential inconsistency between the in-memory SLA map and the Oozie database
> 
>
> Key: OOZIE-3134
> URL: https://issues.apache.org/jira/browse/OOZIE-3134
> Project: Oozie
>  Issue Type: Bug
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3134-001.patch, OOZIE-3134-002.patch, 
> OOZIE-3134-003.patch, OOZIE-3134-004.patch, OOZIE-3134-005.patch, 
> OOZIE-3134-006.patch
>
>
> Upon {{SLACalculatorMemory.addRegistration}}, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later [persists 
> it|https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L380]
>  in the Oozie database. 
> However, if there is a failure during the database operation, a 
> {{JPAExecutorException}} is thrown, and the entry [is not removed from the 
> SLA map| 
> https://github.com/apache/oozie/blob/50f4b5984832941f1341586e43fd832c293b3275/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java#L393].
> It may introduce inconsistency between the Oozie database and the SLA map.
> To prevent this, a rollback mechanism (with proper logging) should be 
> implemented.  It would also make sense to do more sanity/consistency check in 
> the Oozie server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65481/#review199865
---


Ship it!




Ship It!

- András Piros


On March 23, 2018, 7:28 a.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65481/
> ---
> 
> (Updated March 23, 2018, 7:28 a.m.)
> 
> 
> Review request for oozie, András Piros and Attila Sasvari.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Upon SLACalculatorMemory.addRegistration, Oozie puts an entry into an 
> in-memory concurrent hashmap ("slaMap"), and later persists it in the Oozie 
> database.
> However, if there is a failure during the database operation, a 
> JPAExecutorException is thrown, and the entry is not removed from the SLA map.
> It may introduce inconsistency between the Oozie database and the SLA map.
> To prevent this, a rollback mechanism (with proper logging) should be 
> implemented. It would also make sense to do more sanity/consistency check in 
> the Oozie server.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java ef019e73 
>   
> core/src/main/java/org/apache/oozie/util/db/AlwaysFailingHSQLDriverMapper.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 
> 0e310253 
>   core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 
> fe9f08b1 
>   core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java 
> f0e2b181 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
> ee906f45 
> 
> 
> Diff: https://reviews.apache.org/r/65481/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

[Peter Cseh via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66181/
---

(Updated March 23, 2018, 7:47 a.m.)


Review request for oozie, András Piros and Attila Sasvari.


Bugs: OOZIE-3056
https://issues.apache.org/jira/browse/OOZIE-3056


Repository: oozie-git


Description
---

Refactored out Sharelib name resolution from JavaAE as an additional step to 
pick that giant class to pieces.
Added logic to process the  properties added in  sections.


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
122dfd02e17456b9aab924504faee790813fb6a1 
  core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
b55a3cd7f8064cd898edc686891c9f6ebb118c42 
  core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibConfigs.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibResolver.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/action/hadoop/TestWorkflowHelper.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66181/diff/4/

Changes: https://reviews.apache.org/r/66181/diff/3-4/


Testing
---

Added Junit tests to validate that 
1) the configs are propagating and overwriting each other correctly when an xml 
is formatted
2) the configs are resolved in the correct order for sharelib names


Thanks,

Peter Cseh

[jira] [Commented] (OOZIE-3056) Implement new mechanism to specify ShareLibs for workflow actions

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410936#comment-16410936
 ] 

Peter Cseh commented on OOZIE-3056:
---

There was a typo in the -04 patch that caused compilation failure. It should 
work now

> Implement new mechanism to specify ShareLibs for workflow actions
> -
>
> Key: OOZIE-3056
> URL: https://issues.apache.org/jira/browse/OOZIE-3056
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Attila Sasvari
>Assignee: Peter Cseh
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-3056.001.patch, OOZIE-3056.002.patch, 
> OOZIE-3056.003.patch, OOZIE-3056.004.patch, OOZIE-3056.005.patch
>
>
> OOZIE-2687 introduces the {{launcher}} element for workflows:
> {code}
> 
> 1024
> 1
> -Dsome.property=true -XX:+RandomJVMSwitch
> key=value
> root.oozie
> spark,hive
> 
> {code}
> The purpose of this ticket is to discuss and implement new mechanism for 
> handling ShareLib. 
> {{addActionShareLib}} in {{JavaActionExecutor}} should adjusted. Regarding 
> "precedence order":
> if global and an action level {{launcher}} and {{configuration}} (e.g. 
> {{oozie.action.sharelib.for.#ACTIONTYPE#}}) tries to override the sharelib 
> the following should apply:
> {quote} 
> config properties defined in an action's  have priority over 
> an action's , which has priority over the global section's 
>  and , which has priority over the action defaults in 
> oozie-site, and so on.
> {quote}
> Here we have multiple choices how to handle sharelib:
> - Alternative 1: override sharelib in a way that is consistent with current 
> way of handling Oozie configuration settings.
> - Alternative 2: make sharelib additive
> -- For example, if there is a global {{launcher}} with {{sharelib}} element 
> in a workflow that includes multiple ShareLibs (e.g. A,B), and  
> {{oozie.action.sharelib.for.#ACTIONTYPE#}} is also specified for an action's 
> configuration (e.g. C,D), then we take the union of the specified entities 
> (A,B,C,D would be included). 
> -- It's inconsistent with everything else



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65481: OOZIE-3134 - Potential inconsistency between the in-memory SLA map and the Oozie database

[Kinga Marton via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65481/
---

(Updated March 23, 2018, 7:28 a.m.)


Review request for oozie, András Piros and Attila Sasvari.


Repository: oozie-git


Description
---

Upon SLACalculatorMemory.addRegistration, Oozie puts an entry into an in-memory 
concurrent hashmap ("slaMap"), and later persists it in the Oozie database.
However, if there is a failure during the database operation, a 
JPAExecutorException is thrown, and the entry is not removed from the SLA map.
It may introduce inconsistency between the Oozie database and the SLA map.
To prevent this, a rollback mechanism (with proper logging) should be 
implemented. It would also make sense to do more sanity/consistency check in 
the Oozie server.


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java ef019e73 
  
core/src/main/java/org/apache/oozie/util/db/AlwaysFailingHSQLDriverMapper.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 
0e310253 
  core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 
fe9f08b1 
  core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java 
f0e2b181 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java ee906f45 


Diff: https://reviews.apache.org/r/65481/diff/6/

Changes: https://reviews.apache.org/r/65481/diff/5-6/


Testing
---


Thanks,

Kinga Marton

[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (107 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3185  Conflicting JARs org.apache.derby exist in Oozie
https://issues.apache.org/jira/browse/OOZIE-3185
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3176  Oozie-core fails with checkstyle errors.
https://issues.apache.org/jira/browse/OOZIE-3176
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3134  Potential inconsistency between the in-memory SLA map and the Oozie 
database
https://issues.apache.org/jira/browse/OOZIE-3134
OOZIE-3109  Escape log-streaming's HTML-specific characters
https://issues.apache.org/jira/browse/OOZIE-3109
OOZIE-3105  testJMXInstrumentation from the 
org.apache.oozie.util.TestMetricsInstrumentation class is flaky
https://issues.apache.org/jira/browse/OOZIE-3105
OOZIE-3094  fix for grammar mistake
https://issues.apache.org/jira/browse/OOZIE-3094
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-3056  Implement new mechanism to specify ShareLibs for workflow actions
https://issues.apache.org/jira/browse/OOZIE-3056
OOZIE-3002  address findbugs errors in client lib
https://issues.apache.org/jira/browse/OOZIE-3002
OOZIE-2975  code clean up in pig sharelib, replace Exception with more 
explicit, add try with resources, StringBuilder instead of StringBuffer
https://issues.apache.org/jira/browse/OOZIE-2975
OOZIE-2956  Fix Findbugs warnings related to reliance on default encoding in 
oozie-core
https://issues.apache.org/jira/browse/OOZIE-2956
OOZIE-2955  Fix Findbugs warnings related to reliance on default encoding in 
oozie-client
https://issues.apache.org/jira/browse/OOZIE-2955
OOZIE-2954  Fix Checkstyle issues in oozie-client
https://issues.apache.org/jira/browse/OOZIE-2954
OOZIE-2953  Fix Checkstyle issues in oozie-tools
https://issues.apache.org/jira/browse/OOZIE-2953
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2942  Fix Findbugs warnings in oozie-examples
https://issues.apache.org/jira/browse/OOZIE-2942
OOZIE-2937  Remove redundant groupId from the child pom's
https://issues.apache.org/jira/browse/OOZIE-2937
OOZIE-2934  Fix "Exceptional return value of java.io.File.mkdirs() ignored" 
Findbugs error in oozie-sharelib-spark
https://issues.apache.org/jira/browse/OOZIE-2934
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2914  Consolidate Trim 
https://issues.apache.org/jira/browse/OOZIE-2914
OOZIE-2883  OOZIE throw the error "Missing 
[oozie.service.ProxyUserService.proxyuser.oozie.service.ProxyUserService.proxyuser.mr.groups]
 property"
https://issues.apache.org/jira/browse/OOZIE-2883
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2867  Timezone handling for Coordinators: emphasize "Continent/City" 
format
https://issues.apache.org/jira/browse/OOZIE-2867
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.