[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (108 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3193  Applications are not killed when submitted via subworkflow
https://issues.apache.org/jira/browse/OOZIE-3193
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3185  Conflicting JARs org.apache.derby exist in Oozie
https://issues.apache.org/jira/browse/OOZIE-3185
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3176  Oozie-core fails with checkstyle errors.
https://issues.apache.org/jira/browse/OOZIE-3176
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3134  Potential inconsistency between the in-memory SLA map and the Oozie 
database
https://issues.apache.org/jira/browse/OOZIE-3134
OOZIE-3109  Escape log-streaming's HTML-specific characters
https://issues.apache.org/jira/browse/OOZIE-3109
OOZIE-3105  testJMXInstrumentation from the 
org.apache.oozie.util.TestMetricsInstrumentation class is flaky
https://issues.apache.org/jira/browse/OOZIE-3105
OOZIE-3094  fix for grammar mistake
https://issues.apache.org/jira/browse/OOZIE-3094
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-3002  address findbugs errors in client lib
https://issues.apache.org/jira/browse/OOZIE-3002
OOZIE-2975  code clean up in pig sharelib, replace Exception with more 
explicit, add try with resources, StringBuilder instead of StringBuffer
https://issues.apache.org/jira/browse/OOZIE-2975
OOZIE-2956  Fix Findbugs warnings related to reliance on default encoding in 
oozie-core
https://issues.apache.org/jira/browse/OOZIE-2956
OOZIE-2955  Fix Findbugs warnings related to reliance on default encoding in 
oozie-client
https://issues.apache.org/jira/browse/OOZIE-2955
OOZIE-2954  Fix Checkstyle issues in oozie-client
https://issues.apache.org/jira/browse/OOZIE-2954
OOZIE-2953  Fix Checkstyle issues in oozie-tools
https://issues.apache.org/jira/browse/OOZIE-2953
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2942  Fix Findbugs warnings in oozie-examples
https://issues.apache.org/jira/browse/OOZIE-2942
OOZIE-2937  Remove redundant groupId from the child pom's
https://issues.apache.org/jira/browse/OOZIE-2937
OOZIE-2934  Fix "Exceptional return value of java.io.File.mkdirs() ignored" 
Findbugs error in oozie-sharelib-spark
https://issues.apache.org/jira/browse/OOZIE-2934
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2914  Consolidate Trim 
https://issues.apache.org/jira/browse/OOZIE-2914
OOZIE-2883  OOZIE throw the error "Missing 
[oozie.service.ProxyUserService.proxyuser.oozie.service.ProxyUserService.proxyuser.mr.groups]
 property"
https://issues.apache.org/jira/browse/OOZIE-2883
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2867  Timezone handling for Coordinators: emphasize "Continent/City" 
format
https://issues.apache.org/jira/browse/OOZIE-2867
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZI

[jira] [Commented] (OOZIE-2339) Provide an API for writing jobs based on the XSD schemas

[Artem Ervits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414862#comment-16414862
 ] 

Artem Ervits commented on OOZIE-2339:
-

how about "workflow as code"?

> Provide an API for writing jobs based on the XSD schemas
> 
>
> Key: OOZIE-2339
> URL: https://issues.apache.org/jira/browse/OOZIE-2339
> Project: Oozie
>  Issue Type: New Feature
>  Components: client
>Affects Versions: 4.3.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2339.001.patch, OOZIE-2339.002.patch, 
> OOZIE-2339.003.patch, OOZIE-2339.004.patch, OOZIE-2339.005.patch, 
> OOZIE-2339.006.patch, OOZIE-2339.008.patch, OOZIE-2339.010.patch, 
> OOZIE-2339.011.patch
>
>
> Users often complain about the XML they have to write for Oozie jobs.  It 
> would be nice if they could write them in something like Java, but we don't 
> want to have to maintain a separate Java API for this.  I was looking around 
> and saw that JAXB might be the right thing here.  From what I can tell, it 
> lets you create Java classes from XSD schemas.  So, we should be able to 
> auto-generate a Java API for writing Oozie jobs, without having to really 
> maintain it.
> We should investigate if this is feasible and, if so, implement it.
> Some useful looking links:
> * [JAXB 
> overview|https://en.wikipedia.org/wiki/Java_Architecture_for_XML_Binding]
> * [JAXB description|https://jaxb.java.net/2.2.11/docs/ch03.html]
> * [Maven JAXB plugin|https://java.net/projects/maven-jaxb2-plugin/pages/Home]
> * [Apache Falcon|https://falcon.apache.org]
> Key features:
> * must have:
> ** inside an {{oozie-jobs-api}} artifact
> ** able to create workflow / coordinator / bundle definitions programmatically
> ** synchronizing each and every XSD change on rebuild
> ** can write {{workflow.xml}}, {{coordinator.xml}}, {{bundle.xml}}, and 
> {{jobs.properties}} artifacts of every XSD version
> ** cloneability of workflow etc. {{Object}} s
> ** perform cross checks, e.g. that the workflow graph is a DAG
> ** only latest XSD versions should be supported as must have
> * nice to have:
> ** XSD version(s) can be provided. When not provided, latest ones are 
> considered as valid
> ** implement a [*fluent API*|https://en.wikipedia.org/wiki/Fluent_interface]
> ** have a Python / Jython REPL to make it easy to experiment
> ** create documentation about usage
> ** can read {{workflow.xml}}, {{coordinator.xml}}, {{bundle.xml}}, and 
> {{jobs.properties}} artifacts of every XSD version
> ** can convert between XSD versions
> ** support XSD change on the fly (within REPL)
> ** support HDFS reads / writes
> ** support dry run on an Oozie server to perform checks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2339) Provide an API for writing jobs based on the XSD schemas

[Robert Kanter (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414845#comment-16414845
 ] 

Robert Kanter commented on OOZIE-2339:
--

I just left some more comments on ReviewBoard.  Though in the interest of time, 
I didn't look too carefully at some of the generating code like the 
{{DozerConverter}} classes and a lot of the unit tests.

One high-level thing I wanted to bring up is what are we calling this feature?  
It looks like it's currently "Jobs API", but I have a few concerns about that 
name:
# It's pretty generic-sounding and non-specific.  
# "Jobs" is a pretty overloaded term already.  It refers to Oozie Jobs (i.e. 
Workflows, Coordinators, and Bundles), Hadoop/Pig/Sqoop/etc Jobs, the Launcher 
Job, etc.  I'd like to avoid "Jobs" if possible, or at least qualify it with 
something else like "Programatic Jobs API" or something.

I don't have a great alternative for a name, other than "Programatic Jobs API", 
which isn't super great either.  Any ideas?
 

> Provide an API for writing jobs based on the XSD schemas
> 
>
> Key: OOZIE-2339
> URL: https://issues.apache.org/jira/browse/OOZIE-2339
> Project: Oozie
>  Issue Type: New Feature
>  Components: client
>Affects Versions: 4.3.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2339.001.patch, OOZIE-2339.002.patch, 
> OOZIE-2339.003.patch, OOZIE-2339.004.patch, OOZIE-2339.005.patch, 
> OOZIE-2339.006.patch, OOZIE-2339.008.patch, OOZIE-2339.010.patch, 
> OOZIE-2339.011.patch
>
>
> Users often complain about the XML they have to write for Oozie jobs.  It 
> would be nice if they could write them in something like Java, but we don't 
> want to have to maintain a separate Java API for this.  I was looking around 
> and saw that JAXB might be the right thing here.  From what I can tell, it 
> lets you create Java classes from XSD schemas.  So, we should be able to 
> auto-generate a Java API for writing Oozie jobs, without having to really 
> maintain it.
> We should investigate if this is feasible and, if so, implement it.
> Some useful looking links:
> * [JAXB 
> overview|https://en.wikipedia.org/wiki/Java_Architecture_for_XML_Binding]
> * [JAXB description|https://jaxb.java.net/2.2.11/docs/ch03.html]
> * [Maven JAXB plugin|https://java.net/projects/maven-jaxb2-plugin/pages/Home]
> * [Apache Falcon|https://falcon.apache.org]
> Key features:
> * must have:
> ** inside an {{oozie-jobs-api}} artifact
> ** able to create workflow / coordinator / bundle definitions programmatically
> ** synchronizing each and every XSD change on rebuild
> ** can write {{workflow.xml}}, {{coordinator.xml}}, {{bundle.xml}}, and 
> {{jobs.properties}} artifacts of every XSD version
> ** cloneability of workflow etc. {{Object}} s
> ** perform cross checks, e.g. that the workflow graph is a DAG
> ** only latest XSD versions should be supported as must have
> * nice to have:
> ** XSD version(s) can be provided. When not provided, latest ones are 
> considered as valid
> ** implement a [*fluent API*|https://en.wikipedia.org/wiki/Fluent_interface]
> ** have a Python / Jython REPL to make it easy to experiment
> ** create documentation about usage
> ** can read {{workflow.xml}}, {{coordinator.xml}}, {{bundle.xml}}, and 
> {{jobs.properties}} artifacts of every XSD version
> ** can convert between XSD versions
> ** support XSD change on the fly (within REPL)
> ** support HDFS reads / writes
> ** support dry run on an Oozie server to perform checks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

[Robert Kanter via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64029/#review21
---




.gitignore
Lines 1-5 (original), 1-8 (patched)


These changes probably shouldn't be part of this patch.  If we do want to 
add these to .gitignore, we should do that as a separate JIRA.



client/pom.xml
Lines 96 (patched)


version shouldn't be in non-root pom



client/src/main/java/org/apache/oozie/cli/ApiJarFactory.java
Lines 41 (patched)


Looks like this is used only by unit tests.  If so, then perhaps this 
should be moved to a test package and made package private?  I just want to 
make sure users won't start trying to use this class when they shouldn't be.



client/src/main/java/org/apache/oozie/cli/ApiJarFactory.java
Lines 79-80 (patched)


Please add curly braces for the if statement



client/src/main/java/org/apache/oozie/cli/ApiJarLoader.java
Lines 58 (patched)


We check that mainClass is not null here, but we should also check 
that mainClassName is not null before trying to load it on line 56.  
Otherwise, I imagine you'll get a CNFE or NPE or something ugly.  If we add a 
check for mainClassName, we can give a clear message that they're 
missing the manifest's main class property.

Also, what happens if the jar has no manifest at all?  Does 
apiJar.getManifest() return null?  If so, we need to check for that too.



client/src/main/java/org/apache/oozie/cli/OozieCLI.java
Line 991 (original), 1006 (patched)


I don't think we need to declare IllegalAccessException and 
ClassNotFoundException here.  The new method calls you added only ever 
throw OozieClientException.



client/src/main/java/org/apache/oozie/cli/WorkflowFactoryCompiler.java
Lines 36 (patched)


Again, if this is for unit tests, we should move it to a different test and 
limit its scope if possible.



client/src/main/java/org/apache/oozie/cli/WorkflowFactoryCompiler.java
Lines 65 (patched)


Let's not turn this into Hadoop :)

If this isn't working, it looks like the fileManager can be used to do 
something equivalent and you can throw away the options.  Take a look 
at the second answer on the StackOverflow.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 558-559 (original), 559-568 (patched)


Doesn't this change the V0 and V1 APIs?



core/src/main/resources/oozie-default.xml
Lines 3326 (patched)


A few things with this path:
1. I think "jobs" and "application" is a little redundent.  
2. I'm also not sure we need to go 3 levels deep; 1 is probably enough.
3. I could easily see a user having a "jobs" or "application" directory 
already existing in their home dir.  I think we should try to pick something 
more unique and more obviously for Oozie.

Perhaps

/user/${user.name}/oozie-generated/

or something like that?



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 110 (patched)


V2ValidateServlet is an implementation detail.  We shouldn't 
mention it in the user-facing docs or CLI.



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 114 (patched)


"an HDFS location"



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 117 (patched)


Again, DAGEngine is an implementation detail that we don't need to 
expose to the user.



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 118 (patched)


"an HDFS location"



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 1095 (patched)


queueName is a custom user-defined property, isn't it?  Just like 
nameNode and JobTracker.  Does the Jobs API always require 
these three properties?  While commonly used (because users often copy the 
examples where these are used), they're not officially standard.



docs/src/site/twiki/DG_CommandLineTool.twiki
Lines 1132 (patched)


Again, no need to mention DAGEngine



docs/src/site/twiki/DG_JobsAPI.twiki
Lines 11-13 (patched)

[jira] [Commented] (OOZIE-3199) Let system property restriction configurable

[Denes Bodo (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414538#comment-16414538
 ] 

Denes Bodo commented on OOZIE-3199:
---

Currently I am getting
{noformat}
fatal: git cat-file: could not get object info 
Line undefined: undefined
{noformat}
I'll try it tomorrow.

> Let system property restriction configurable
> 
>
> Key: OOZIE-3199
> URL: https://issues.apache.org/jira/browse/OOZIE-3199
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3199-001.patch, OOZIE-3199-002.patch
>
>
> Currently Oozie restricts resolution of system properties by default. In some 
> cases that would be nice if as an administrator I could set a whitelist of 
> enabled system property names.
> Suggestion will be provided asap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-2645 PreCommit Build #474

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2645
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/474/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2645

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 4 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2099
Tests failed: 1
Tests errors: 0

The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/474/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/12998382/comment/16414163","id":"16414163","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-2645\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:green}+1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce any @author tags\n.{color:green}+1{color} the patch does not 
introduce any tabs\n.{color:green}+1

[jira] [Commented] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414163#comment-16414163
 ] 

Hadoop QA commented on OOZIE-2645:
--


Testing JIRA OOZIE-2645

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2099
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/474/



> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch, OOZIE-2645.002.patch, 
> OOZIE-2645.003.patch, OOZIE-2645.004.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.
> 
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
> {{MetricsInstrumentationService}} the default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2726) Flaky test due to daylight saving changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414145#comment-16414145
 ] 

Hadoop QA commented on OOZIE-2726:
--


Testing JIRA OOZIE-2726

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2106
.Tests failed: 1
.Tests errors: 1

.The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)

.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/473/



> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch, OOZIE-2726.007.patch, OOZIE-2726.008.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  

Failed: OOZIE-2726 PreCommit Build #473

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-2726
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/473/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2726

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 2 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2106
Tests failed: 1
Tests errors: 1

The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)

Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/473/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  34450 0  100  3445  0   3996 --:--:-- --:--:-- --:--:--  
3996{"self":"https://issues.apache.org/jira/rest/api/2/issue/13019006/comment/16414145","id":"16414145","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-2726\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:green}+1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch d

[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414062#comment-16414062
 ] 

Hadoop QA commented on OOZIE-3176:
--


Testing JIRA OOZIE-3176

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 56 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2098
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestJMSAccessorService#testConnectionRetry
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/472/



> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, 
> OOZIE-3176-002.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3176 PreCommit Build #472

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3176
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/472/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.77 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2253 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3176

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 56 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2098
Tests failed: 1
Tests errors: 0

The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestJMSAccessorService#testConnectionRetry
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/472/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  33880 0  100  3388  0   4026 --:--:-- --:--:-- --:--:--  
4023{"self":"https://issues.apache.org/jira/rest/api/2/issue/13136797/comment/16414062","id":"16414062","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-3176\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:green}+1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce any @author tags\n.{color:green}+1{color} the patch does not 
introduce any tabs\n.{color:green}+1{color} the patch does n

[jira] [Updated] (OOZIE-3150) Remove references to not present dependencies within NOTICE.txt

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3150:

Summary: Remove references to not present dependencies within NOTICE.txt  
(was: Update NOTICE.txt)

> Remove references to not present dependencies within NOTICE.txt
> ---
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3150) Remove references to not present dependencies within NOTICE.txt

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414037#comment-16414037
 ] 

Andras Piros commented on OOZIE-3150:
-

Committed to {{master}}.

> Remove references to not present dependencies within NOTICE.txt
> ---
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414017#comment-16414017
 ] 

Hadoop QA commented on OOZIE-2645:
--

PreCommit-OOZIE-Build started


> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch, OOZIE-2645.002.patch, 
> OOZIE-2645.003.patch, OOZIE-2645.004.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.
> 
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
> {{MetricsInstrumentationService}} the default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-2645) Deprecate Instrumentation in favor of Metrics

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2645:

Attachment: OOZIE-2645.004.patch

> Deprecate Instrumentation in favor of Metrics
> -
>
> Key: OOZIE-2645
> URL: https://issues.apache.org/jira/browse/OOZIE-2645
> Project: Oozie
>  Issue Type: Improvement
>  Components: monitoring
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2645.001.patch, OOZIE-2645.002.patch, 
> OOZIE-2645.003.patch, OOZIE-2645.004.patch
>
>
> OOZIE-1817 added the option to use DropWizard Metrics instead of our 
> homegrown Instrumentation.  We left the Instrumentation as the default for 
> compatibility; in Oozie 5, we should drop Instrumentation and only have 
> Metrics.
> We can also use this opportunity to clean up the code and interface for 
> Metrics, which currently has to conform to Instrumentation for pluggability.
> 
> Update: for 5.0.0 we only deprecate {{InstrumentationService}}, and make 
> {{MetricsInstrumentationService}} the default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3150 PreCommit Build #471

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3150
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/471/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2253 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3150

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2098
Tests failed: 1
Tests errors: 1

The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)

Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/471/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13127720/comment/16414002","id":"16414002","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-3150\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:red}-1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patc

[jira] [Commented] (OOZIE-2726) Flaky test due to daylight saving changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414016#comment-16414016
 ] 

Hadoop QA commented on OOZIE-2726:
--

PreCommit-OOZIE-Build started


> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch, OOZIE-2726.007.patch, OOZIE-2726.008.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66250: [OOZIE-2645] Deprecate Instrumentation in favor of Metrics

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66250/
---

(Updated March 26, 2018, 3:21 p.m.)


Review request for oozie, Peter Cseh and Robert Kanter.


Changes
---

Addressing review comments.


Repository: oozie-git


Description
---

[OOZIE-2645] Deprecate Instrumentation in favor of Metrics


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
afa35113c7fc258d0da75bdbf183fc6f2a1e54ee 
  core/src/main/java/org/apache/oozie/util/Instrumentation.java 
a57b6655da6a6c28eb857691336ab27508ee8092 
  core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java 
1288a3f980435164c38b09edbbbcad51577e694d 
  core/src/main/resources/oozie-default.xml 
966dd29b20ffb4a627418d62403c0cec166dd147 
  core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 
b31816e15f5f419e52042187931674fbd3cd4c5b 
  core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 
f91d22f668b14bde7437e9a3f854dd87a5565e00 
  core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 
534f5727ce398d6dbf8473bf4442b76e7c2630c4 
  core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java 
ab974436769b786d99d10fc3aa951c2a3b16d398 
  core/src/test/resources/oozie-site-instrumentation.xml 
ab3f0f5b99aabf149d409c762efd3feb51fe9f6d 
  docs/src/site/twiki/AG_Install.twiki 8e2d795da838d184940bc177e95e9dfb8b52cc54 
  docs/src/site/twiki/AG_Monitoring.twiki 
523f85133055b80b32b2cf73f1e8c25751cf9fc4 
  docs/src/site/twiki/DG_CommandLineTool.twiki 
a94201ded8451cc725b40e9f73182ecaa52be88a 
  docs/src/site/twiki/WebServicesAPI.twiki 
c662a5eefdfc012ea6c13256a3df426e1a073965 


Diff: https://reviews.apache.org/r/66250/diff/4/

Changes: https://reviews.apache.org/r/66250/diff/3-4/


Testing
---

Generated `mkdistro` and saw that `/admin/v2/metrics` is available, and 
`/admin/instrumentation` isn't.


Thanks,

András Piros

[jira] [Updated] (OOZIE-3198) Extend remaining job tracker references in code and documentation

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3198:

Fix Version/s: (was: 5.0.0)
   5.1.0

> Extend remaining job tracker references in code and documentation
> -
>
> Key: OOZIE-3198
> URL: https://issues.apache.org/jira/browse/OOZIE-3198
> Project: Oozie
>  Issue Type: Sub-task
>  Components: action, core, docs
>Affects Versions: 5.0.0b1
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.1.0
>
>
> Extend the places in configuration, code and documentation where 
> {{jobTracker}} and {{job-tracker}} is still referenced without a proper 
> {{resourceManager}}, {{resource-manager}} reference that precedes it.
> Example: {{oozie.service.HadoopAccessorService.jobTracker.whitelist}} in 
> {{AG_HadoopConfiguration.twiki}}, {{HadoopAccessorService.java}}, and 
> {{oozie-default.xml}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OOZIE-3150) Update NOTICE.txt

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414009#comment-16414009
 ] 

Andras Piros edited comment on OOZIE-3150 at 3/26/18 3:34 PM:
--

Thanks for the contribution [~gezapeti]! I'm OK to remove the conflicting 
parts, and have follow-up JIRAs to clarify / generate license and dependency 
reports post {{5.0.0}} timeline.

+1


was (Author: andras.piros):
Thanks for the contribution [~gezapeti]! I'm OK to remove the conflicting 
parts, and have follow-up JIRAs to clarify / generate license and dependency 
reports post {{5.0.0}} timeline.

+1 (pending Jenkins)

> Update NOTICE.txt
> -
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3150) Update NOTICE.txt

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414009#comment-16414009
 ] 

Andras Piros commented on OOZIE-3150:
-

Thanks for the contribution [~gezapeti]! I'm OK to remove the conflicting 
parts, and have follow-up JIRAs to clarify / generate license and dependency 
reports post {{5.0.0}} timeline.

+1 (pending Jenkins)

> Update NOTICE.txt
> -
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3150) Update NOTICE.txt

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414002#comment-16414002
 ] 

Hadoop QA commented on OOZIE-3150:
--


Testing JIRA OOZIE-3150

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2098
.Tests failed: 1
.Tests errors: 1

.The patch failed the following testcases:

testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)

.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/471/



> Update NOTICE.txt
> -
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from

[jira] [Updated] (OOZIE-2726) Flaky test due to daylight saving changes

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2726:

Attachment: OOZIE-2726.008.patch

> Flaky test due to daylight saving changes
> -
>
> Key: OOZIE-2726
> URL: https://issues.apache.org/jira/browse/OOZIE-2726
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Satish Subhashrao Saley
>Assignee: Andras Piros
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2726-1.patch, OOZIE-2726-2.patch, 
> OOZIE-2726-3.patch, OOZIE-2726-4.patch, OOZIE-2726-5.patch, 
> OOZIE-2726.006.patch, OOZIE-2726.007.patch, OOZIE-2726.008.patch
>
>
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup
> {code}
> Error Message
> expected: but was:
> Stacktrace
> junit.framework.AssertionFailedError: expected: 
> but was:
>   at junit.framework.Assert.fail(Assert.java:50)
>   at junit.framework.Assert.failNotEquals(Assert.java:287)
>   at junit.framework.Assert.assertEquals(Assert.java:67)
>   at junit.framework.Assert.assertEquals(Assert.java:74)
>   at 
> org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand.testMaterizationLookup(TestCoordMaterializeTransitionXCommand.java:582)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:483)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:243)
>   at junit.framework.TestSuite.run(TestSuite.java:238)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:24)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66250: [OOZIE-2645] Deprecate Instrumentation in favor of Metrics

[András Piros via Review Board]

> On March 26, 2018, 10:40 a.m., Peter Cseh wrote:
> > docs/src/site/twiki/AG_Install.twiki
> > Lines 919-921 (original), 927-937 (patched)
> > 
> >
> > Shouldn't it be enabled by adding the deprecated Service to the 
> > services.ext?

Documentation updated and test case added.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66250/#review199953
---


On March 24, 2018, 6:15 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66250/
> ---
> 
> (Updated March 24, 2018, 6:15 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> [OOZIE-2645] Deprecate Instrumentation in favor of Metrics
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
> afa35113c7fc258d0da75bdbf183fc6f2a1e54ee 
>   core/src/main/java/org/apache/oozie/util/Instrumentation.java 
> a57b6655da6a6c28eb857691336ab27508ee8092 
>   core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java 
> 1288a3f980435164c38b09edbbbcad51577e694d 
>   core/src/main/resources/oozie-default.xml 
> 966dd29b20ffb4a627418d62403c0cec166dd147 
>   core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 
> b31816e15f5f419e52042187931674fbd3cd4c5b 
>   core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 
> f91d22f668b14bde7437e9a3f854dd87a5565e00 
>   core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 
> 534f5727ce398d6dbf8473bf4442b76e7c2630c4 
>   core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java 
> ab974436769b786d99d10fc3aa951c2a3b16d398 
>   core/src/test/resources/oozie-site-instrumentation.xml 
> ab3f0f5b99aabf149d409c762efd3feb51fe9f6d 
>   docs/src/site/twiki/AG_Install.twiki 
> 8e2d795da838d184940bc177e95e9dfb8b52cc54 
>   docs/src/site/twiki/AG_Monitoring.twiki 
> 523f85133055b80b32b2cf73f1e8c25751cf9fc4 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> a94201ded8451cc725b40e9f73182ecaa52be88a 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> c662a5eefdfc012ea6c13256a3df426e1a073965 
> 
> 
> Diff: https://reviews.apache.org/r/66250/diff/3/
> 
> 
> Testing
> ---
> 
> Generated `mkdistro` and saw that `/admin/v2/metrics` is available, and 
> `/admin/instrumentation` isn't.
> 
> 
> Thanks,
> 
> András Piros
> 
>

[jira] [Updated] (OOZIE-3093) Test Scenarios for Oozie 5.0

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3093:

Fix Version/s: (was: 5.0.0)

> Test Scenarios for Oozie 5.0
> 
>
> Key: OOZIE-3093
> URL: https://issues.apache.org/jira/browse/OOZIE-3093
> Project: Oozie
>  Issue Type: Test
>Affects Versions: 5.0.0b1
>Reporter: Artem Ervits
>Priority: Blocker
>
> This is umbrella jira to track test scenarios on Oozie 5.0. In my discussion 
> with [~gezapeti] we can have a joint effort to test different test cases. 
> [~clayb] please provide your input as well.
> 1. Oozie HA
> 2. Oozie secure cluster
> 3. Run all examples
> 4. Execute against every Hadoop profile
> etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3093) Test Scenarios for Oozie 5.0

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413951#comment-16413951
 ] 

Andras Piros commented on OOZIE-3093:
-

Thanks [~gezapeti]. Pushing out of {{5.0.0}}.

> Test Scenarios for Oozie 5.0
> 
>
> Key: OOZIE-3093
> URL: https://issues.apache.org/jira/browse/OOZIE-3093
> Project: Oozie
>  Issue Type: Test
>Affects Versions: 5.0.0b1
>Reporter: Artem Ervits
>Priority: Blocker
>
> This is umbrella jira to track test scenarios on Oozie 5.0. In my discussion 
> with [~gezapeti] we can have a joint effort to test different test cases. 
> [~clayb] please provide your input as well.
> 1. Oozie HA
> 2. Oozie secure cluster
> 3. Run all examples
> 4. Execute against every Hadoop profile
> etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3093) Test Scenarios for Oozie 5.0

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413950#comment-16413950
 ] 

Peter Cseh commented on OOZIE-3093:
---

Yeah, we're good on HA/kerberos testing with Hadoop 3 based on our internal 
tests.
I think we can push this ticket out from 5.0 until we figure out how to keep 
the master more release-ready.

> Test Scenarios for Oozie 5.0
> 
>
> Key: OOZIE-3093
> URL: https://issues.apache.org/jira/browse/OOZIE-3093
> Project: Oozie
>  Issue Type: Test
>Affects Versions: 5.0.0b1
>Reporter: Artem Ervits
>Priority: Blocker
> Fix For: 5.0.0
>
>
> This is umbrella jira to track test scenarios on Oozie 5.0. In my discussion 
> with [~gezapeti] we can have a joint effort to test different test cases. 
> [~clayb] please provide your input as well.
> 1. Oozie HA
> 2. Oozie secure cluster
> 3. Run all examples
> 4. Execute against every Hadoop profile
> etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

[András Piros via Review Board]

> On March 26, 2018, 12:21 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java
> > Lines 54-58 (patched)
> > 
> >
> > Isn't this handled in getDSTOffset as part of returning 0 there? I 
> > don't think the performance would require this additional logic, but it 
> > makes things a bit confusing

Refactored method, and updated class and method level Javadoc as well as unit 
test cases to have a better understanding what's going on here.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66262/#review199958
---


On March 24, 2018, 11:53 a.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66262/
> ---
> 
> (Updated March 24, 2018, 11:53 a.m.)
> 
> 
> Review request for oozie, Peter Cseh and Satish Saley.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2.
> 
> Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) 
> of the [review request #1](https://reviews.apache.org/r/53775).
> 
> 
> Diffs
> -
> 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b9125387b4e356e408e112c55af7bb3f1c39d3e 
>   
> core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
>  61bbbfe3d1dde89b875c30c75e875efc9227f05d 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66262/diff/2/
> 
> 
> Testing
> ---
> 
> `TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66262/
---

(Updated March 26, 2018, 2:39 p.m.)


Review request for oozie, Peter Cseh and Satish Saley.


Changes
---

Addressing review comments.


Repository: oozie-git


Description
---

[OOZIE-2726] Flaky test due to daylight saving changes. Review request #2.

Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) 
of the [review request #1](https://reviews.apache.org/r/53775).


Diffs (updated)
-

  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b9125387b4e356e408e112c55af7bb3f1c39d3e 
  
core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java 
PRE-CREATION 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 61bbbfe3d1dde89b875c30c75e875efc9227f05d 
  
core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66262/diff/3/

Changes: https://reviews.apache.org/r/66262/diff/2-3/


Testing
---

`TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator`


Thanks,

András Piros

[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413937#comment-16413937
 ] 

Hadoop QA commented on OOZIE-3176:
--

PreCommit-OOZIE-Build started


> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, 
> OOZIE-3176-002.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-3176:
--
Attachment: OOZIE-3176-002.patch

> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, 
> OOZIE-3176-002.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

[Peter Cseh via Review Board]

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
> 
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header 
> checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
>  and the corresponging file: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt
> 
> Alisha Prabhu wrote:
> Uploaded the patch by making the above changes.

It looks good! I've attached this patch to the Jira so the pre-commit hook can 
kick in.


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src

[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413927#comment-16413927
 ] 

Peter Cseh commented on OOZIE-3176:
---

I'm attaching patch#3 from Reviewboard to kick off the pre-commit hook.
https://reviews.apache.org/r/66084/diff/3#index_header


> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, 
> OOZIE-3176-002.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-3176:
--
Priority: Blocker  (was: Minor)

> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3176) Oozie-core fails with checkstyle errors.

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-3176:
--
Fix Version/s: 5.0.0

> Oozie-core fails with checkstyle errors.
> 
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug 
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred 
> while building.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3150) Update NOTICE.txt

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413890#comment-16413890
 ] 

Hadoop QA commented on OOZIE-3150:
--

PreCommit-OOZIE-Build started


> Update NOTICE.txt
> -
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3150) Update NOTICE.txt

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-3150:
--
Attachment: OOZIE-3150.001.patch

> Update NOTICE.txt
> -
>
> Key: OOZIE-3150
> URL: https://issues.apache.org/jira/browse/OOZIE-3150
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0b1
>Reporter: Robert Kanter
>Assignee: Peter Cseh
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-3150.001.patch
>
>
> NOTICE.txt currently contains:
> {noformat}
> ===
> NOTICE file for use with, and corresponding to Section 4 of,
> the Apache License, Version 2.0,
> in this case for the Oozie, Workflow Engine for Hadoop project
> ===
> Copyright 2011 The Apache Software Foundation
> This product includes software developed by The Apache Software
> Foundation (http://www.apache.org/).
> This product includes org.json (http://www.json.org/java/index.html),
> Copyright (c) 2002 JSON.org
> Detailed License information for all components can be found in the
> documentation in the ooziedocs.war at index.html##LicenseInfo
> Oozie source contains 3 binaries (wordcount-simple_Linux-amd64-64_h20,
> wordcount-simple_Linux-i386-32_h20, wordcount-simple_Mac_OS_X-x86_64-64_h20) 
> for
> testing purposes, these binaries are compiled artifacts from Apache Hadoop.
> {noformat}
> A few problems:
> - There is no ooziedocs.war
> - Oozie doesn't contain any binaries AFAIK and hasn't for a long time
> - We should see if there is anything else we need to add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3199) Let system property restriction configurable

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413833#comment-16413833
 ] 

Andras Piros commented on OOZIE-3199:
-

Thanks for the contribution [~dionusos]! Can you please create a ReviewBoard 
review request?

> Let system property restriction configurable
> 
>
> Key: OOZIE-3199
> URL: https://issues.apache.org/jira/browse/OOZIE-3199
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3199-001.patch, OOZIE-3199-002.patch
>
>
> Currently Oozie restricts resolution of system properties by default. In some 
> cases that would be nice if as an administrator I could set a whitelist of 
> enabled system property names.
> Suggestion will be provided asap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3201) Typo in TestCoordActionInputCheckXCommand

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413821#comment-16413821
 ] 

Andras Piros commented on OOZIE-3201:
-

Committed to {{master}}.

> Typo in TestCoordActionInputCheckXCommand
> -
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Assignee: gongchuanjie
>Priority: Minor
> Fix For: 5.0.0
>
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3201) Typo in TestCoordActionInputCheckXCommand

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3201:

Fix Version/s: 5.0.0

> Typo in TestCoordActionInputCheckXCommand
> -
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Assignee: gongchuanjie
>Priority: Minor
> Fix For: 5.0.0
>
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

[Peter Cseh via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66262/#review199959
---




core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
Line 468 (original), 479 (patched)


This was 4 hours before. Why is this changed?


- Peter Cseh


On March 24, 2018, 11:53 a.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66262/
> ---
> 
> (Updated March 24, 2018, 11:53 a.m.)
> 
> 
> Review request for oozie, Peter Cseh and Satish Saley.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2.
> 
> Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) 
> of the [review request #1](https://reviews.apache.org/r/53775).
> 
> 
> Diffs
> -
> 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b9125387b4e356e408e112c55af7bb3f1c39d3e 
>   
> core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
>  61bbbfe3d1dde89b875c30c75e875efc9227f05d 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66262/diff/2/
> 
> 
> Testing
> ---
> 
> `TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator`
> 
> 
> Thanks,
> 
> András Piros
> 
>

[jira] [Updated] (OOZIE-3201) Typo in TestCoordActionInputCheckXCommand

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3201:

Summary: Typo in TestCoordActionInputCheckXCommand  (was: the typo in 
TestCoordActionInputCheckXCommand class)

> Typo in TestCoordActionInputCheckXCommand
> -
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Assignee: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3201) Typo in TestCoordActionInputCheckXCommand

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413805#comment-16413805
 ] 

Andras Piros commented on OOZIE-3201:
-

Thanks for the contribution [~gongchuanjie]! Added you to the contributors 
list. +1

> Typo in TestCoordActionInputCheckXCommand
> -
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Assignee: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3201 PreCommit Build #469

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/OOZIE-3201
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/469/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.71 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2252 bytes
[TRACE] Full summary file size is 1314 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3201

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [server].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
-1 TESTS
Tests run: 2096
Tests failed: 1
Tests errors: 0

The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

Tests failing with errors:


Tests failed at first run:
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/469/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  34080 0  100  3408  0   4002 --:--:-- --:--:-- --:--:--  
4000{"self":"https://issues.apache.org/jira/rest/api/2/issue/13147882/comment/16413792","id":"16413792","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","emailAddress":"blackhole
 at hadoop dot apache dot 
org","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"timeZone":"Etc/UTC"},"body":"\nTesting JIRA 
OOZIE-3201\n\nCleaning local git 
workspace\n\n\n\n{color:green}+1 
PATCH_APPLIES{color}\n{color:green}+1 CLEAN{color}\n{color:green}+1 
RAW_PATCH_ANALYSIS{color}\n.{color:green}+1{color} the patch does not 
introduce any @author tags\n.{color:green}+1{color} the patch does not 
introduce any tabs\n.{color:green}+1{col

[jira] [Commented] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413792#comment-16413792
 ] 

Hadoop QA commented on OOZIE-3201:
--


Testing JIRA OOZIE-3201

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2096
.Tests failed: 1
.Tests errors: 0

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:


.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/469/



> the typo in TestCoordActionInputCheckXCommand class
> ---
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-3201:
---

Assignee: gongchuanjie

> the typo in TestCoordActionInputCheckXCommand class
> ---
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Assignee: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66181/#review199960
---


Ship it!




Ship It!

- András Piros


On March 23, 2018, 7:47 a.m., Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66181/
> ---
> 
> (Updated March 23, 2018, 7:47 a.m.)
> 
> 
> Review request for oozie, András Piros and Attila Sasvari.
> 
> 
> Bugs: OOZIE-3056
> https://issues.apache.org/jira/browse/OOZIE-3056
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Refactored out Sharelib name resolution from JavaAE as an additional step to 
> pick that giant class to pieces.
> Added logic to process the  properties added in  sections.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd02e17456b9aab924504faee790813fb6a1 
>   core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> b55a3cd7f8064cd898edc686891c9f6ebb118c42 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibConfigs.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibResolver.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestWorkflowHelper.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66181/diff/4/
> 
> 
> Testing
> ---
> 
> Added Junit tests to validate that 
> 1) the configs are propagating and overwriting each other correctly when an 
> xml is formatted
> 2) the configs are resolved in the correct order for sharelib names
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

[jira] [Commented] (OOZIE-3056) Implement new mechanism to specify ShareLibs for workflow actions

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413778#comment-16413778
 ] 

Andras Piros commented on OOZIE-3056:
-

Thanks for the contribution [~gezapeti]! +1

> Implement new mechanism to specify ShareLibs for workflow actions
> -
>
> Key: OOZIE-3056
> URL: https://issues.apache.org/jira/browse/OOZIE-3056
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Attila Sasvari
>Assignee: Peter Cseh
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-3056.001.patch, OOZIE-3056.002.patch, 
> OOZIE-3056.003.patch, OOZIE-3056.004.patch, OOZIE-3056.005.patch
>
>
> OOZIE-2687 introduces the {{launcher}} element for workflows:
> {code}
> 
> 1024
> 1
> -Dsome.property=true -XX:+RandomJVMSwitch
> key=value
> root.oozie
> spark,hive
> 
> {code}
> The purpose of this ticket is to discuss and implement new mechanism for 
> handling ShareLib. 
> {{addActionShareLib}} in {{JavaActionExecutor}} should adjusted. Regarding 
> "precedence order":
> if global and an action level {{launcher}} and {{configuration}} (e.g. 
> {{oozie.action.sharelib.for.#ACTIONTYPE#}}) tries to override the sharelib 
> the following should apply:
> {quote} 
> config properties defined in an action's  have priority over 
> an action's , which has priority over the global section's 
>  and , which has priority over the action defaults in 
> oozie-site, and so on.
> {quote}
> Here we have multiple choices how to handle sharelib:
> - Alternative 1: override sharelib in a way that is consistent with current 
> way of handling Oozie configuration settings.
> - Alternative 2: make sharelib additive
> -- For example, if there is a global {{launcher}} with {{sharelib}} element 
> in a workflow that includes multiple ShareLibs (e.g. A,B), and  
> {{oozie.action.sharelib.for.#ACTIONTYPE#}} is also specified for an action's 
> configuration (e.g. C,D), then we take the union of the specified entities 
> (A,B,C,D would be included). 
> -- It's inconsistent with everything else



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

[Peter Cseh via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66262/#review199958
---




core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java
Lines 54-58 (patched)


Isn't this handled in getDSTOffset as part of returning 0 there? I don't 
think the performance would require this additional logic, but it makes things 
a bit confusing


- Peter Cseh


On March 24, 2018, 11:53 a.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66262/
> ---
> 
> (Updated March 24, 2018, 11:53 a.m.)
> 
> 
> Review request for oozie, Peter Cseh and Satish Saley.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2.
> 
> Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) 
> of the [review request #1](https://reviews.apache.org/r/53775).
> 
> 
> Diffs
> -
> 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b9125387b4e356e408e112c55af7bb3f1c39d3e 
>   
> core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
>  61bbbfe3d1dde89b875c30c75e875efc9227f05d 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66262/diff/2/
> 
> 
> Testing
> ---
> 
> `TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator`
> 
> 
> Thanks,
> 
> András Piros
> 
>

[jira] [Commented] (OOZIE-3199) Let system property restriction configurable

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413712#comment-16413712
 ] 

Hadoop QA commented on OOZIE-3199:
--

PreCommit-OOZIE-Build started


> Let system property restriction configurable
> 
>
> Key: OOZIE-3199
> URL: https://issues.apache.org/jira/browse/OOZIE-3199
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3199-001.patch, OOZIE-3199-002.patch
>
>
> Currently Oozie restricts resolution of system properties by default. In some 
> cases that would be nice if as an administrator I could set a whitelist of 
> enabled system property names.
> Suggestion will be provided asap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3199) Let system property restriction configurable

[Denes Bodo (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413703#comment-16413703
 ] 

Denes Bodo commented on OOZIE-3199:
---

I've uploaded a more elegant solution.

> Let system property restriction configurable
> 
>
> Key: OOZIE-3199
> URL: https://issues.apache.org/jira/browse/OOZIE-3199
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3199-001.patch, OOZIE-3199-002.patch
>
>
> Currently Oozie restricts resolution of system properties by default. In some 
> cases that would be nice if as an administrator I could set a whitelist of 
> enabled system property names.
> Suggestion will be provided asap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3199) Let system property restriction configurable

[Denes Bodo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denes Bodo updated OOZIE-3199:
--
Attachment: OOZIE-3199-002.patch

> Let system property restriction configurable
> 
>
> Key: OOZIE-3199
> URL: https://issues.apache.org/jira/browse/OOZIE-3199
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3199-001.patch, OOZIE-3199-002.patch
>
>
> Currently Oozie restricts resolution of system properties by default. In some 
> cases that would be nice if as an administrator I could set a whitelist of 
> enabled system property names.
> Suggestion will be provided asap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[gongchuanjie (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

gongchuanjie updated OOZIE-3201:

Attachment: OOZIE-3201.001.patch

> the typo in TestCoordActionInputCheckXCommand class
> ---
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[gongchuanjie (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413690#comment-16413690
 ] 

gongchuanjie commented on OOZIE-3201:
-

please add me to contributor list

> the typo in TestCoordActionInputCheckXCommand class
> ---
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

[Alisha Prabhu]

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> >

Hi Attila Sasvari, can you please review the updated patch. Thank you.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
>   core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
>   core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
>   core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
>   core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
> d08521c 
>   core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
>   core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
>   core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
>   core/src/main/java/org/

[jira] [Commented] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413689#comment-16413689
 ] 

Hadoop QA commented on OOZIE-3201:
--

PreCommit-OOZIE-Build started


> the typo in TestCoordActionInputCheckXCommand class
> ---
>
> Key: OOZIE-3201
> URL: https://issues.apache.org/jira/browse/OOZIE-3201
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: gongchuanjie
>Priority: Minor
> Attachments: OOZIE-3201.001.patch
>
>
> the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66250: [OOZIE-2645] Deprecate Instrumentation in favor of Metrics

[Peter Cseh via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66250/#review199953
---




docs/src/site/twiki/AG_Install.twiki
Lines 919-921 (original), 927-937 (patched)


Shouldn't it be enabled by adding the deprecated Service to the 
services.ext?



docs/src/site/twiki/AG_Install.twiki
Lines 919-921 (original), 927-937 (patched)


Shouldn't it be enabled by adding the deprecated Service to the 
services.ext?


- Peter Cseh


On March 24, 2018, 6:15 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66250/
> ---
> 
> (Updated March 24, 2018, 6:15 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> [OOZIE-2645] Deprecate Instrumentation in favor of Metrics
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
> afa35113c7fc258d0da75bdbf183fc6f2a1e54ee 
>   core/src/main/java/org/apache/oozie/util/Instrumentation.java 
> a57b6655da6a6c28eb857691336ab27508ee8092 
>   core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java 
> 1288a3f980435164c38b09edbbbcad51577e694d 
>   core/src/main/resources/oozie-default.xml 
> 966dd29b20ffb4a627418d62403c0cec166dd147 
>   core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 
> b31816e15f5f419e52042187931674fbd3cd4c5b 
>   core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 
> f91d22f668b14bde7437e9a3f854dd87a5565e00 
>   core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 
> 534f5727ce398d6dbf8473bf4442b76e7c2630c4 
>   core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java 
> ab974436769b786d99d10fc3aa951c2a3b16d398 
>   core/src/test/resources/oozie-site-instrumentation.xml 
> ab3f0f5b99aabf149d409c762efd3feb51fe9f6d 
>   docs/src/site/twiki/AG_Install.twiki 
> 8e2d795da838d184940bc177e95e9dfb8b52cc54 
>   docs/src/site/twiki/AG_Monitoring.twiki 
> 523f85133055b80b32b2cf73f1e8c25751cf9fc4 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> a94201ded8451cc725b40e9f73182ecaa52be88a 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> c662a5eefdfc012ea6c13256a3df426e1a073965 
> 
> 
> Diff: https://reviews.apache.org/r/66250/diff/3/
> 
> 
> Testing
> ---
> 
> Generated `mkdistro` and saw that `/admin/v2/metrics` is available, and 
> `/admin/instrumentation` isn't.
> 
> 
> Thanks,
> 
> András Piros
> 
>

[jira] [Created] (OOZIE-3201) the typo in TestCoordActionInputCheckXCommand class

[gongchuanjie (JIRA)]

gongchuanjie created OOZIE-3201:
---

 Summary: the typo in TestCoordActionInputCheckXCommand class
 Key: OOZIE-3201
 URL: https://issues.apache.org/jira/browse/OOZIE-3201
 Project: Oozie
  Issue Type: Improvement
  Components: core
Affects Versions: 4.3.1, 5.0.0
Reporter: gongchuanjie


the typo of "aciton" in TestCoordActionInputCheckXCommand class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66181/#review199944
---


Ship it!




Ship It!

- András Piros


On March 23, 2018, 7:47 a.m., Peter Cseh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66181/
> ---
> 
> (Updated March 23, 2018, 7:47 a.m.)
> 
> 
> Review request for oozie, András Piros and Attila Sasvari.
> 
> 
> Bugs: OOZIE-3056
> https://issues.apache.org/jira/browse/OOZIE-3056
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Refactored out Sharelib name resolution from JavaAE as an additional step to 
> pick that giant class to pieces.
> Added logic to process the  properties added in  sections.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd02e17456b9aab924504faee790813fb6a1 
>   core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> b55a3cd7f8064cd898edc686891c9f6ebb118c42 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibConfigs.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibResolver.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestWorkflowHelper.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66181/diff/4/
> 
> 
> Testing
> ---
> 
> Added Junit tests to validate that 
> 1) the configs are propagating and overwriting each other correctly when an 
> xml is formatted
> 2) the configs are resolved in the correct order for sharelib names
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>