[jira] [Updated] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-27 Thread Julia Kinga Marton (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton updated OOZIE-2955:
--
Attachment: OOZIE-2955-002.patch

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2955-002.patch, OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetInstru

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525974#comment-16525974
 ] 

Julia Kinga Marton commented on OOZIE-2956:
---

The reported bugs are already existing ones, are not related to the patch.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2956-003.patch, OOZIE-2956-1.patch, 
> OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 

[jira] Subscription: Oozie Patch Available

2018-06-27 Thread jira
Issue Subscription
Filter: Oozie Patch Available (97 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3218  Oozie Sqoop action with command splits the select clause into 
multiple parts due to delimiter being space
https://issues.apache.org/jira/browse/OOZIE-3218
OOZIE-3208  "It should never happen" error messages should be more specific to 
root cause
https://issues.apache.org/jira/browse/OOZIE-3208
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3193  Applications are not killed when submitted via subworkflow
https://issues.apache.org/jira/browse/OOZIE-3193
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3160  PriorityDelayQueue put()/take() can cause significant CPU load due 
to busy waiting
https://issues.apache.org/jira/browse/OOZIE-3160
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3109  Escape log-streaming's HTML-specific characters
https://issues.apache.org/jira/browse/OOZIE-3109
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-2956  Fix Findbugs warnings related to reliance on default encoding in 
oozie-core
https://issues.apache.org/jira/browse/OOZIE-2956
OOZIE-2955  Fix Findbugs warnings related to reliance on default encoding in 
oozie-client
https://issues.apache.org/jira/browse/OOZIE-2955
OOZIE-2954  Fix Checkstyle issues in oozie-client
https://issues.apache.org/jira/browse/OOZIE-2954
OOZIE-2953  Fix Checkstyle issues in oozie-tools
https://issues.apache.org/jira/browse/OOZIE-2953
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2942  [examples] Fix Findbugs warnings
https://issues.apache.org/jira/browse/OOZIE-2942
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2829  Improve sharelib upload to accept multiple source folders
https://issues.apache.org/jira/browse/OOZIE-2829
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters
https://issues.apache.org/jira/browse/OOZIE-2791
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
   

[jira] [Commented] (OOZIE-3272) Purging fails if oozie.service.PurgeService.purge.old.coord.action enabled

2018-06-27 Thread Prabhu Joseph (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525807#comment-16525807
 ] 

Prabhu Joseph commented on OOZIE-3272:
--

This issue is due to Older OpenJPA Version and got fixed with OOZIE-2488

> Purging fails if oozie.service.PurgeService.purge.old.coord.action enabled
> --
>
> Key: OOZIE-3272
> URL: https://issues.apache.org/jira/browse/OOZIE-3272
> Project: Oozie
>  Issue Type: Bug
>  Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Prabhu Joseph
>Assignee: Prabhu Joseph
>Priority: Major
>
> Oozie PurgeService fails if oozie.service.PurgeService.purge.old.coord.action 
> enabled as it queries below with endTime as per the days configured in 
> oozie.service.PurgeService.older.than without converting to timestamp.
> {code}
> select w.id, w.parentId from WorkflowJobBean w where w.endTimestamp < 
> :endTime and w.parentId like '%C@%'"),
> {code}
> Exception:
> {code}
> 2018-05-22 15:59:51,100 ERROR PurgeXCommand:517 - 
> SERVER[bigdata2.openstacklocal] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-] 
> ACTION[-] Exception, 
>  
> org.apache.openjpa.persistence.PersistenceException: The column index is out 
> of range: 3, number of columns: 2. 
> FailedObject: select w.id, w.parentId from WorkflowJobBean w where 
> w.endTimestamp < :endTime and w.parentId like '%C@%' [java.lang.String] 
> at org.apache.openjpa.jdbc.sql.DBDictionary.narrow(DBDictionary.java:4962) 
> at 
> org.apache.openjpa.jdbc.sql.DBDictionary.newStoreException(DBDictionary.java:4922)
>  
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:136) 
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:118) 
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:70) 
> at 
> org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.handleCheckedException(SelectResultObjectProvider.java:155)
>  
> at 
> org.apache.openjpa.kernel.QueryImpl$PackingResultObjectProvider.handleCheckedException(QueryImpl.java:2111)
>  
> at org.apache.openjpa.lib.rop.EagerResultList.(EagerResultList.java:40) 
> at org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1251) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1007) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:863) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:794) 
> at 
> org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:542) 
> at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:286) 
> at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:302) 
> at org.apache.oozie.service.JPAService.executeGetList(JPAService.java:496) 
> at 
> org.apache.oozie.executor.jpa.WorkflowJobQueryExecutor.getList(WorkflowJobQueryExecutor.java:377)
>  
> at 
> org.apache.oozie.executor.jpa.WorkflowJobQueryExecutor.getList(WorkflowJobQueryExecutor.java:39)
>  
> at org.apache.oozie.command.PurgeXCommand.loadState(PurgeXCommand.java:110) 
> at org.apache.oozie.command.XCommand.call(XCommand.java:281) 
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:178)
>  
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  
> at java.lang.Thread.run(Thread.java:745) 
> Caused by: org.postgresql.util.PSQLException: The column index is out of 
> range: 3, number of columns: 2. 
> at 
> org.postgresql.core.v3.SimpleParameterList.bind(SimpleParameterList.java:53) 
> at 
> org.postgresql.core.v3.SimpleParameterList.setLiteralParameter(SimpleParameterList.java:114)
>  
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.bindLiteral(AbstractJdbc2Statement.java:2172)
>  
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.setLong(AbstractJdbc2Statement.java:1227)
>  
> at 
> org.apache.commons.dbcp.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:123)
>  
> at 
> org.apache.commons.dbcp.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:123)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at 
> org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.setLong(LoggingConnectionDecorator.java:1370)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at org.apache.openjpa.jdbc.sql.DBDictionary.setLong(DBDi

[jira] [Resolved] (OOZIE-3272) Purging fails if oozie.service.PurgeService.purge.old.coord.action enabled

2018-06-27 Thread Prabhu Joseph (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prabhu Joseph resolved OOZIE-3272.
--
Resolution: Duplicate

> Purging fails if oozie.service.PurgeService.purge.old.coord.action enabled
> --
>
> Key: OOZIE-3272
> URL: https://issues.apache.org/jira/browse/OOZIE-3272
> Project: Oozie
>  Issue Type: Bug
>  Components: coordinator
>Affects Versions: 4.3.0
>Reporter: Prabhu Joseph
>Assignee: Prabhu Joseph
>Priority: Major
>
> Oozie PurgeService fails if oozie.service.PurgeService.purge.old.coord.action 
> enabled as it queries below with endTime as per the days configured in 
> oozie.service.PurgeService.older.than without converting to timestamp.
> {code}
> select w.id, w.parentId from WorkflowJobBean w where w.endTimestamp < 
> :endTime and w.parentId like '%C@%'"),
> {code}
> Exception:
> {code}
> 2018-05-22 15:59:51,100 ERROR PurgeXCommand:517 - 
> SERVER[bigdata2.openstacklocal] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-] 
> ACTION[-] Exception, 
>  
> org.apache.openjpa.persistence.PersistenceException: The column index is out 
> of range: 3, number of columns: 2. 
> FailedObject: select w.id, w.parentId from WorkflowJobBean w where 
> w.endTimestamp < :endTime and w.parentId like '%C@%' [java.lang.String] 
> at org.apache.openjpa.jdbc.sql.DBDictionary.narrow(DBDictionary.java:4962) 
> at 
> org.apache.openjpa.jdbc.sql.DBDictionary.newStoreException(DBDictionary.java:4922)
>  
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:136) 
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:118) 
> at org.apache.openjpa.jdbc.sql.SQLExceptions.getStore(SQLExceptions.java:70) 
> at 
> org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.handleCheckedException(SelectResultObjectProvider.java:155)
>  
> at 
> org.apache.openjpa.kernel.QueryImpl$PackingResultObjectProvider.handleCheckedException(QueryImpl.java:2111)
>  
> at org.apache.openjpa.lib.rop.EagerResultList.(EagerResultList.java:40) 
> at org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1251) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1007) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:863) 
> at org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:794) 
> at 
> org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:542) 
> at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:286) 
> at org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:302) 
> at org.apache.oozie.service.JPAService.executeGetList(JPAService.java:496) 
> at 
> org.apache.oozie.executor.jpa.WorkflowJobQueryExecutor.getList(WorkflowJobQueryExecutor.java:377)
>  
> at 
> org.apache.oozie.executor.jpa.WorkflowJobQueryExecutor.getList(WorkflowJobQueryExecutor.java:39)
>  
> at org.apache.oozie.command.PurgeXCommand.loadState(PurgeXCommand.java:110) 
> at org.apache.oozie.command.XCommand.call(XCommand.java:281) 
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:178)
>  
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  
> at java.lang.Thread.run(Thread.java:745) 
> Caused by: org.postgresql.util.PSQLException: The column index is out of 
> range: 3, number of columns: 2. 
> at 
> org.postgresql.core.v3.SimpleParameterList.bind(SimpleParameterList.java:53) 
> at 
> org.postgresql.core.v3.SimpleParameterList.setLiteralParameter(SimpleParameterList.java:114)
>  
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.bindLiteral(AbstractJdbc2Statement.java:2172)
>  
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.setLong(AbstractJdbc2Statement.java:1227)
>  
> at 
> org.apache.commons.dbcp.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:123)
>  
> at 
> org.apache.commons.dbcp.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:123)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at 
> org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.setLong(LoggingConnectionDecorator.java:1370)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at 
> org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.setLong(DelegatingPreparedStatement.java:299)
>  
> at org.apache.openjpa.jdbc.sql.DBDictionary.setLong(DBDictionary.java:1155) 
> at 
> org.apache.openjpa.jdbc.sql.DBDictionary.setUnknown(DBDictionary.java:1454

[jira] [Updated] (OOZIE-3299) CoordStatusTransitXCommand logs shows wrong ACTION value

2018-06-27 Thread Prabhu Joseph (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prabhu Joseph updated OOZIE-3299:
-
Description: 
ISSUE:

The logs from CoordStatusTransitXCommand with different coordinators shows 
wrong ACTION value. The action 0188706-180421101115209-oozie-oozi-W does 
not belong to any of the coordinators. This is misleading while analyzing the 
oozie server logs.

{code}

oozie.log-2018-06-07-16:2018-06-07 16:13:17,301  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[PVL_data_sync] JOB[0009039-180122185814644-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0009039-180122185814644-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,305  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[sohe] JOB[0182017-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0182017-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,310  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awdlc03] 
GROUP[-] TOKEN[] APP[PRD_COORDINATOR_INGESTION_CAD] 
JOB[0005634-171021095136703-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0005634-171021095136703-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,329  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[a004163] 
GROUP[-] TOKEN[] APP[coordinator_inventory] 
JOB[0160434-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0160434-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'

{code}

Suspect:

The logging is a shared service and every commands (or threads) uses it has own 
values for the fields like USER, GROUP, TOKEN, APP , JOB and ACTION. The 
CoordinatorJob won't have any ACTION details. While logging, since it does not 
have a action value, Log Service wrongly uses a value which is in memory and 
used by some other thread.


Code Analysis:

CoordStatusTransitXCommand - at start defines the parameters like GROUP, USER, 
JOB, TOKEN, APP and it does not have any ACTION.

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java#L101

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L46

We need a fix like clear the log prefix before logging from 
CoordStatusTransitXCommand - which will remove stale ACTION value and won;t 
show any ACTION details

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L172


  was:
ISSUE:

The logs from CoordStatusTransitXCommand with different coordinators shows 
wrong ACTION value. The action 0188706-180421101115209-oozie-oozi-W does 
not belong to any of the coordinators. 

{code}

oozie.log-2018-06-07-16:2018-06-07 16:13:17,301  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[PVL_data_sync] JOB[0009039-180122185814644-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0009039-180122185814644-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,305  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[sohe] JOB[0182017-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0182017-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,310  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awdlc03] 
GROUP[-] TOKEN[] APP[PRD_COORDINATOR_INGESTION_CAD] 
JOB[0005634-171021095136703-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0005634-171021095136703-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,329  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[a004163] 
GROUP[-] TOKEN[] APP[coordinator_inventory] 
JOB[0160434-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0160434-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'

{code}

Suspect:

The logging is a shared service and every commands (or threads) uses it has own 
values for the fields like USER, GROUP, TOKEN, APP , JOB and ACTION. The 
CoordinatorJob won't have any ACTION details. While logging, since it does not 
have a action value, Log Service wrongly uses a value which is in memory and 
used by some other thread.


Co

[jira] [Created] (OOZIE-3299) CoordStatusTransitXCommand logs shows wrong ACTION value

2018-06-27 Thread Prabhu Joseph (JIRA)
Prabhu Joseph created OOZIE-3299:


 Summary: CoordStatusTransitXCommand logs shows wrong ACTION value
 Key: OOZIE-3299
 URL: https://issues.apache.org/jira/browse/OOZIE-3299
 Project: Oozie
  Issue Type: Bug
  Components: core
Affects Versions: 4.3.1
Reporter: Prabhu Joseph


ISSUE:

The logs from CoordStatusTransitXCommand with different coordinators shows 
wrong ACTION value. The action 0188706-180421101115209-oozie-oozi-W does 
not belong to any of the coordinators. 

{code}

oozie.log-2018-06-07-16:2018-06-07 16:13:17,301  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[PVL_data_sync] JOB[0009039-180122185814644-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0009039-180122185814644-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,305  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] 
GROUP[-] TOKEN[] APP[sohe] JOB[0182017-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0182017-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,310  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awdlc03] 
GROUP[-] TOKEN[] APP[PRD_COORDINATOR_INGESTION_CAD] 
JOB[0005634-171021095136703-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0005634-171021095136703-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
oozie.log-2018-06-07-16:2018-06-07 16:13:17,329  INFO 
CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[a004163] 
GROUP[-] TOKEN[] APP[coordinator_inventory] 
JOB[0160434-180421101115209-oozie-oozi-C] 
ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job 
[0160434-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'

{code}

Suspect:

The logging is a shared service and every commands (or threads) uses it has own 
values for the fields like USER, GROUP, TOKEN, APP , JOB and ACTION. The 
CoordinatorJob won't have any ACTION details. While logging, since it does not 
have a action value, Log Service wrongly uses a value which is in memory and 
used by some other thread.


Code Analysis:

CoordStatusTransitXCommand - at start defines the parameters like GROUP, USER, 
JOB, TOKEN, APP and it does not have any ACTION.

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java#L101

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L46

We need a fix like clear the log prefix before logging from 
CoordStatusTransitXCommand - which will remove stale ACTION value and won;t 
show any ACTION details

https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L172




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525598#comment-16525598
 ] 

Hadoop QA commented on OOZIE-2956:
--


Testing JIRA OOZIE-2956

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [3] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At SshActionExecutor.java:[line 145]: This usage of 
java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be 
vulnerable to Command Injection
. At SshActionExecutor.java:[line 142]: At SshActionExecutor.java:[line 141]
. java/io/FileOutputStream.(Ljava/lang/String;)V writes to a file 
whose location might be specified by user input: At 
SshActionExecutor.java:[line 145]
. At SshActionExecutor.java:[line 523]: At SshActionExecutor.java:[line 530]
. java/io/FileOutputStream.(Ljava/lang/String;)V writes to a file 
whose location might be specified by user input: At 
SshActionExecutor.java:[line 530]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2897
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/643/



> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2956-003.patch, OOZIE-2956-1.patch, 
> OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob():

Failed: OOZIE-2956 PreCommit Build #643

2018-06-27 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-2956
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/643/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.78 MB...]
[DEBUG] There are no new bugs found in [sharelib/oozie].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/distcp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/spark].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[ERROR] There are [3] new bugs found below threshold in total that must be 
fixed.
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 3302 bytes
[TRACE] Full summary file size is 2360 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2956

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [3] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [webapp].
 -1 There are [3] new bugs found below threshold in [core] that must be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The most important FindBugs errors are:
 At SshActionExecutor.java:[line 145]: This usage of 
java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be 
vulnerable to Command Injection
 At SshActionExecutor.java:[line 142]: At SshActionExecutor.java:[line 141]
 java/io/FileOutputStream.(Ljava/lang/String;)V writes to a file 
whose location might be specified by user input: At 
SshActionExecutor.java:[line 145]
 At SshActionExecutor.java:[line 523]: At SshActionExecutor.java:[line 530]
 java/io/FileOutputStream.(Ljava/lang/String;)V writes to a file 
whose location might be specified by user input: At 
SshActionExecutor.java:[line 530]
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [client].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2897
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/643/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0{"self":"https://issues.apache.org/jira/rest/api/2/issue/13080663/comment/16525598","id":"16525598","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525471#comment-16525471
 ] 

Hadoop QA commented on OOZIE-2956:
--

PreCommit-OOZIE-Build started


> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2956-003.patch, OOZIE-2956-1.patch, 
> OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance

Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Kinga Marton via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67763/
---

Review request for oozie and András Piros.


Repository: oozie-git


Description
---

Currently Findbugs complains about the a few warnings related to the reliance 
on the default encoding in the oozie-core module
They should be fixed to get the code more reliable.


Diffs
-

  core/src/main/java/org/apache/oozie/StringBlob.java 6c776011 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d3 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 
21c9b7e4 
  
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 
d0b80742 
  core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 
69d5e7e9 
  core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 
128feee7 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 
80e7d5d4 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
8bfa634f 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java 
502a800f 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
251838ce 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java c725f493 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0 
  core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22 
  core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f572 
  core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48 
  core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af 
  core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db3 
  core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b36 


Diff: https://reviews.apache.org/r/67763/diff/1/


Testing
---


Thanks,

Kinga Marton



[jira] [Updated] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Julia Kinga Marton (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton updated OOZIE-2956:
--
Attachment: OOZIE-2956-003.patch

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2956-003.patch, OOZIE-2956-1.patch, 
> OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> org.apa

[jira] [Commented] (OOZIE-3265) properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2018-06-27 Thread TIAN XING (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525172#comment-16525172
 ] 

TIAN XING commented on OOZIE-3265:
--

[~andras.piros], [~gezapeti] hey, sorry for late response. I just settled down 
in a new city, will finish this patch soon.

> properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear 
> together
> --
>
> Key: OOZIE-3265
> URL: https://issues.apache.org/jira/browse/OOZIE-3265
> Project: Oozie
>  Issue Type: Task
>Affects Versions: 5.0.0
>Reporter: TIAN XING
>Assignee: TIAN XING
>Priority: Minor
> Attachments: OOZIE-3265-v1.patch, OOZIE-3265-v2.patch, rerun.patch
>
>
> Currently when you re-run a workflow with property "oozie.wf.rerun.failnodes" 
>  set to true,
> you can no longer re-run it again with "oozie.wf.rerun.skip.nodes" property 
> specified, even if you set "oozie.wf.rerun.failnodes" to false.
> This kind of limitation is not reasonable. There is only one case where 
> "oozie.wf.rerun.failnodes" is true and "oozie.wf.rerun.skip.nodes" is not 
> null or empty, that should be disallowed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Julia Kinga Marton (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton reassigned OOZIE-2956:
-

Assignee: Julia Kinga Marton  (was: Jan Hentschel)

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in 
> org.apa

[jira] [Assigned] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-27 Thread Julia Kinga Marton (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton reassigned OOZIE-2955:
-

Assignee: Julia Kinga Marton  (was: Jan Hentschel)

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetIns

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Jan Hentschel (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525104#comment-16525104
 ] 

Jan Hentschel commented on OOZIE-2956:
--

[~kmarton] Yes, sure. Go ahead.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At 
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding 

[jira] [Commented] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-27 Thread Jan Hentschel (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525105#comment-16525105
 ] 

Jan Hentschel commented on OOZIE-2955:
--

[~kmarton] Yes, sure. Go ahead.

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.Oozie

[jira] [Commented] (OOZIE-2955) Fix Findbugs warnings related to reliance on default encoding in oozie-client

2018-06-27 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525084#comment-16525084
 ] 

Julia Kinga Marton commented on OOZIE-2955:
---

Hi [~Jan Hentschel], do you have any plans with this issue? I have some free 
capacity, if you want, I can take it over.

> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new 
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At 
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new 
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At 
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new 
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
>  new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At 
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new 
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] 
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
>  new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At 
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 
> 1502]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At 
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At 
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At 
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 
> 1743]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 
> 1455]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At 
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 
> 1773]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At 
> OozieClie

[jira] [Commented] (OOZIE-2956) Fix Findbugs warnings related to reliance on default encoding in oozie-core

2018-06-27 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525082#comment-16525082
 ] 

Julia Kinga Marton commented on OOZIE-2956:
---

Hi [~Jan Hentschel], do you have any plans with this issue? I have some free 
capacity, if you want, I can take it over.

> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
>  Issue Type: Sub-task
>  Components: build, core
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: OOZIE-2956-1.patch, OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the 
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() 
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): 
> java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ActionExecutor.registerError(String, 
> ActionExecutorException$ErrorType, String): new 
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At 
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration, 
> Path, String): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line 
> 69]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String): 
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At 
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new 
> java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1, 
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line 
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at 
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line 
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At 
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
>  WorkflowAction): String.getBytes() 
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At 
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, 
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 684]Another occurrence at 
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new 
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor, 
> org.apache.oozie.action.ssh.SshActionExecutor] At 
> SshActionExecutor.java:[line 502]Another occurrence at 
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At 
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): 
> new java.io.InputStreamReader(InputStream) 
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At 
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in 
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, 
> String): java.io.ByteArrayOutputStream.toString() 
> [org.apache.oozie.command.coord.CoordUpd

[jira] [Updated] (OOZIE-3298) OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3298:

Fix Version/s: 5.1.0

> OYA: external ID is not filled properly and failing MR job is treated as 
> SUCCEEDED
> --
>
> Key: OOZIE-3298
> URL: https://issues.apache.org/jira/browse/OOZIE-3298
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Peter Bacsko
>Assignee: Andras Piros
>Priority: Critical
> Fix For: 5.1.0
>
>
> When a MapReduce action is launched from Oozie (OYA), we don't properly fill 
> the external ID field. It gets populated with the YARN id of the LauncherAM, 
> not with the id of the actual MR job. If the MR job is succesfully submitted 
> then fails, it will be treated as a successfully executed action, which is 
> very misleading and can potentially confuse Oozie users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3208) "It should never happen" error messages should be more specific to root cause

2018-06-27 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525027#comment-16525027
 ] 

Julia Kinga Marton commented on OOZIE-3208:
---

Thank you [~andras.piros] for the review! Calling close in case of StringWriter 
has no effect. This is why I removed the try catch. 

> "It should never happen" error messages should be more specific to root cause
> -
>
> Key: OOZIE-3208
> URL: https://issues.apache.org/jira/browse/OOZIE-3208
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3208-001.patch, OOZIE-3208-002.patch
>
>
> If you forget to install the sharelib and you try to run a workflow, the 
> action will fail (as expected), but the error code will be "It should never 
> happen".  That's not a good error code :D
> {noformat}
> 2018-03-29 14:35:02,361  WARN ActionStartXCommand:523 - 
> SERVER[rkanter-MBP.local] USER[rkanter] GROUP[-] TOKEN[] APP[map-reduce-wf] 
> JOB[000-180329142919509-oozie-rkan-W] 
> ACTION[000-180329142919509-oozie-rkan-W@mr-node] Error starting action 
> [mr-node]. ErrorType [FAILED], ErrorCode [It should never happen], Message 
> [File /user/rkanter/share/lib does not exist]
> org.apache.oozie.action.ActionExecutorException: File /user/rkanter/share/lib 
> does not exist
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:646)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:760)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:746)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:984)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1512)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:243)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
> at org.apache.oozie.command.XCommand.call(XCommand.java:290)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:334)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:263)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:181)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> Error starting action [mr-node]. ErrorType [FAILED], ErrorCode [It should 
> never happen]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3298) OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3298:

Affects Version/s: 5.0.0

> OYA: external ID is not filled properly and failing MR job is treated as 
> SUCCEEDED
> --
>
> Key: OOZIE-3298
> URL: https://issues.apache.org/jira/browse/OOZIE-3298
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Peter Bacsko
>Assignee: Andras Piros
>Priority: Critical
>
> When a MapReduce action is launched from Oozie (OYA), we don't properly fill 
> the external ID field. It gets populated with the YARN id of the LauncherAM, 
> not with the id of the actual MR job. If the MR job is succesfully submitted 
> then fails, it will be treated as a successfully executed action, which is 
> very misleading and can potentially confuse Oozie users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3297) Retry logic does not handle the exception from BulkJPAExecutor properly

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3297:

Fix Version/s: 5.1.0

> Retry logic does not handle the exception from BulkJPAExecutor properly
> ---
>
> Key: OOZIE-3297
> URL: https://issues.apache.org/jira/browse/OOZIE-3297
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Peter Bacsko
>Assignee: Andras Piros
>Priority: Critical
> Fix For: 5.1.0
>
>
> The test {{testJavaNoRecords}} revealed an interesting problem - if 
> {{BulkJPAExecutor}} does not find a particaular bundle job, it throws a 
> {{JPAExecutorException}} and the operation is retried even though it the 
> exception should be re-thrown without any retry.
> The problem is that the cause of {{JPAExecutorException}} is another 
> {{JPAExecutorException}} and the predicate logic inside 
> {{OperationRetryHandler}} mishandles this situation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3297) Retry logic does not handle the exception from BulkJPAExecutor properly

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3297:

Affects Version/s: 5.0.0

> Retry logic does not handle the exception from BulkJPAExecutor properly
> ---
>
> Key: OOZIE-3297
> URL: https://issues.apache.org/jira/browse/OOZIE-3297
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.0.0
>Reporter: Peter Bacsko
>Assignee: Andras Piros
>Priority: Critical
> Fix For: 5.1.0
>
>
> The test {{testJavaNoRecords}} revealed an interesting problem - if 
> {{BulkJPAExecutor}} does not find a particaular bundle job, it throws a 
> {{JPAExecutorException}} and the operation is retried even though it the 
> exception should be re-thrown without any retry.
> The problem is that the cause of {{JPAExecutorException}} is another 
> {{JPAExecutorException}} and the predicate logic inside 
> {{OperationRetryHandler}} mishandles this situation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-2829) Improve sharelib upload to accept multiple source folders

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2829:

Affects Version/s: 5.1.0

> Improve sharelib upload to accept multiple source folders
> -
>
> Key: OOZIE-2829
> URL: https://issues.apache.org/jira/browse/OOZIE-2829
> Project: Oozie
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2829-01.patch, OOZIE-2829-02.patch, 
> OOZIE-2829-03.patch, OOZIE-2829-04.patch, OOZIE-2829-05.patch
>
>
> Right now sharelib can be created via {{sharelib create -fs FS_URI -locallib 
> SHARED_LIBRARY}} where the SHARED_LIBRARY can be a tarbal or a folder. 
> It would be nice to have the possibility to define additional folders to be 
> uploaded into the sharelib, so the users don't have to copy or link the files 
> together on their machine.
> The syntax could be something like -additional-lib 
> sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-2829) Improve sharelib upload to accept multiple source folders

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2829:

Fix Version/s: 5.1.0

> Improve sharelib upload to accept multiple source folders
> -
>
> Key: OOZIE-2829
> URL: https://issues.apache.org/jira/browse/OOZIE-2829
> Project: Oozie
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2829-01.patch, OOZIE-2829-02.patch, 
> OOZIE-2829-03.patch, OOZIE-2829-04.patch, OOZIE-2829-05.patch
>
>
> Right now sharelib can be created via {{sharelib create -fs FS_URI -locallib 
> SHARED_LIBRARY}} where the SHARED_LIBRARY can be a tarbal or a folder. 
> It would be nice to have the possibility to define additional folders to be 
> uploaded into the sharelib, so the users don't have to copy or link the files 
> together on their machine.
> The syntax could be something like -additional-lib 
> sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-2829) Improve sharelib upload to accept multiple source folders

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2829:

Affects Version/s: (was: 5.1.0)
   5.0.0

> Improve sharelib upload to accept multiple source folders
> -
>
> Key: OOZIE-2829
> URL: https://issues.apache.org/jira/browse/OOZIE-2829
> Project: Oozie
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2829-01.patch, OOZIE-2829-02.patch, 
> OOZIE-2829-03.patch, OOZIE-2829-04.patch, OOZIE-2829-05.patch
>
>
> Right now sharelib can be created via {{sharelib create -fs FS_URI -locallib 
> SHARED_LIBRARY}} where the SHARED_LIBRARY can be a tarbal or a folder. 
> It would be nice to have the possibility to define additional folders to be 
> uploaded into the sharelib, so the users don't have to copy or link the files 
> together on their machine.
> The syntax could be something like -additional-lib 
> sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3193) Applications are not killed when submitted via subworkflow

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3193:

Affects Version/s: 5.0.0

> Applications are not killed when submitted via subworkflow
> --
>
> Key: OOZIE-3193
> URL: https://issues.apache.org/jira/browse/OOZIE-3193
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3193.001.patch, OOZIE-3193.002.patch
>
>
> We're using tags to kill applications. Subworkflows have special tags like 
> {{workflowID@subwfAcitonID@actionID}} 
> Right now we're not getting the subWorkflow config properly in JavaAE.kill() 
> so we're looking for the tag {{subWorkflowID@actionID}} to kill. Therefore 
> actions submitted via subworkflows are not killed properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3193) Applications are not killed when submitted via subworkflow

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3193:

Fix Version/s: 5.1.0

> Applications are not killed when submitted via subworkflow
> --
>
> Key: OOZIE-3193
> URL: https://issues.apache.org/jira/browse/OOZIE-3193
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Peter Cseh
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3193.001.patch, OOZIE-3193.002.patch
>
>
> We're using tags to kill applications. Subworkflows have special tags like 
> {{workflowID@subwfAcitonID@actionID}} 
> Right now we're not getting the subWorkflow config properly in JavaAE.kill() 
> so we're looking for the tag {{subWorkflowID@actionID}} to kill. Therefore 
> actions submitted via subworkflows are not killed properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-1624) Exclusion pattern for sharelib JARs

2018-06-27 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525019#comment-16525019
 ] 

Andras Piros commented on OOZIE-1624:
-

[~matijhs] did another review round.

> Exclusion pattern for sharelib JARs
> ---
>
> Key: OOZIE-1624
> URL: https://issues.apache.org/jira/browse/OOZIE-1624
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 4.3.1
>Reporter: Purshotam Shah
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: OOZIE-1624-V2.patch, OOZIE-1624-V3.patch, 
> OOZIE-1624-V4.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2..jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> 
> oozie.action.sharelib.for.hive.exclusion
> json-\*.jar|abc-*.jar
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-2629:
---

Assignee: Yishan Yang

> Get OozieShareLibCLI to perform a final rename to destPath when creating a 
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
>  Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Assignee: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, 
> OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition 
> where 'half' of the sharelib could exist during sharelib installation, if 
> Oozie attempts to run a workflow at the same time as the sharelib 
> installation. Oozie will only start if the sharelib exists, but this by 
> itself is not enough since the sharelib could be in an unusable state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3109) Escape log-streaming's HTML-specific characters

2018-06-27 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525004#comment-16525004
 ] 

Andras Piros commented on OOZIE-3109:
-

Thanks for the contribution [~dionusos]! Can you please address remaining 
{{RAW_PATCH_ANALYSIS}} errors? Thanks!

> Escape log-streaming's HTML-specific characters
> ---
>
> Key: OOZIE-3109
> URL: https://issues.apache.org/jira/browse/OOZIE-3109
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3109-v001.patch, OOZIE-3109-v002.patch, 
> OOZIE-3109-v003.patch
>
>
> That can be a security problem if we do not encode the stream read from log 
> files before transferred to the web browser.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3265) properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear together

2018-06-27 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524996#comment-16524996
 ] 

Andras Piros commented on OOZIE-3265:
-

[~txsing] do you happen to have time to finish this JIRA soon? Thanks!

> properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to appear 
> together
> --
>
> Key: OOZIE-3265
> URL: https://issues.apache.org/jira/browse/OOZIE-3265
> Project: Oozie
>  Issue Type: Task
>Affects Versions: 5.0.0
>Reporter: TIAN XING
>Assignee: TIAN XING
>Priority: Minor
> Attachments: OOZIE-3265-v1.patch, OOZIE-3265-v2.patch, rerun.patch
>
>
> Currently when you re-run a workflow with property "oozie.wf.rerun.failnodes" 
>  set to true,
> you can no longer re-run it again with "oozie.wf.rerun.skip.nodes" property 
> specified, even if you set "oozie.wf.rerun.failnodes" to false.
> This kind of limitation is not reasonable. There is only one case where 
> "oozie.wf.rerun.failnodes" is true and "oozie.wf.rerun.skip.nodes" is not 
> null or empty, that should be disallowed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OOZIE-3208) "It should never happen" error messages should be more specific to root cause

2018-06-27 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524955#comment-16524955
 ] 

Andras Piros edited comment on OOZIE-3208 at 6/27/18 11:59 AM:
---

Thanks for the contribution [~kmarton]!

Can you please make one change more here; in {{ConfigurationService}} please 
use {{try-with-resources}} in order the {{StringWriter#close()}} would be 
called automatically. Thanks!


was (Author: andras.piros):
Thanks for the contribution [~kmarton]! +1

> "It should never happen" error messages should be more specific to root cause
> -
>
> Key: OOZIE-3208
> URL: https://issues.apache.org/jira/browse/OOZIE-3208
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3208-001.patch, OOZIE-3208-002.patch
>
>
> If you forget to install the sharelib and you try to run a workflow, the 
> action will fail (as expected), but the error code will be "It should never 
> happen".  That's not a good error code :D
> {noformat}
> 2018-03-29 14:35:02,361  WARN ActionStartXCommand:523 - 
> SERVER[rkanter-MBP.local] USER[rkanter] GROUP[-] TOKEN[] APP[map-reduce-wf] 
> JOB[000-180329142919509-oozie-rkan-W] 
> ACTION[000-180329142919509-oozie-rkan-W@mr-node] Error starting action 
> [mr-node]. ErrorType [FAILED], ErrorCode [It should never happen], Message 
> [File /user/rkanter/share/lib does not exist]
> org.apache.oozie.action.ActionExecutorException: File /user/rkanter/share/lib 
> does not exist
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:646)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:760)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:746)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:984)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1512)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:243)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
> at org.apache.oozie.command.XCommand.call(XCommand.java:290)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:334)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:263)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:181)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> Error starting action [mr-node]. ErrorType [FAILED], ErrorCode [It should 
> never happen]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3208) "It should never happen" error messages should be more specific to root cause

2018-06-27 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3208:

Summary: "It should never happen" error messages should be more specific to 
root cause  (was: "It should never happen" error code when running an action 
when Sharelib doesn't exist)

> "It should never happen" error messages should be more specific to root cause
> -
>
> Key: OOZIE-3208
> URL: https://issues.apache.org/jira/browse/OOZIE-3208
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3208-001.patch, OOZIE-3208-002.patch
>
>
> If you forget to install the sharelib and you try to run a workflow, the 
> action will fail (as expected), but the error code will be "It should never 
> happen".  That's not a good error code :D
> {noformat}
> 2018-03-29 14:35:02,361  WARN ActionStartXCommand:523 - 
> SERVER[rkanter-MBP.local] USER[rkanter] GROUP[-] TOKEN[] APP[map-reduce-wf] 
> JOB[000-180329142919509-oozie-rkan-W] 
> ACTION[000-180329142919509-oozie-rkan-W@mr-node] Error starting action 
> [mr-node]. ErrorType [FAILED], ErrorCode [It should never happen], Message 
> [File /user/rkanter/share/lib does not exist]
> org.apache.oozie.action.ActionExecutorException: File /user/rkanter/share/lib 
> does not exist
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:646)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:760)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:746)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:984)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1512)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:243)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
> at org.apache.oozie.command.XCommand.call(XCommand.java:290)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:334)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:263)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:181)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> Error starting action [mr-node]. ErrorType [FAILED], ErrorCode [It should 
> never happen]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3208) "It should never happen" error code when running an action when Sharelib doesn't exist

2018-06-27 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524955#comment-16524955
 ] 

Andras Piros commented on OOZIE-3208:
-

Thanks for the contribution [~kmarton]! +1

> "It should never happen" error code when running an action when Sharelib 
> doesn't exist
> --
>
> Key: OOZIE-3208
> URL: https://issues.apache.org/jira/browse/OOZIE-3208
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3208-001.patch, OOZIE-3208-002.patch
>
>
> If you forget to install the sharelib and you try to run a workflow, the 
> action will fail (as expected), but the error code will be "It should never 
> happen".  That's not a good error code :D
> {noformat}
> 2018-03-29 14:35:02,361  WARN ActionStartXCommand:523 - 
> SERVER[rkanter-MBP.local] USER[rkanter] GROUP[-] TOKEN[] APP[map-reduce-wf] 
> JOB[000-180329142919509-oozie-rkan-W] 
> ACTION[000-180329142919509-oozie-rkan-W@mr-node] Error starting action 
> [mr-node]. ErrorType [FAILED], ErrorCode [It should never happen], Message 
> [File /user/rkanter/share/lib does not exist]
> org.apache.oozie.action.ActionExecutorException: File /user/rkanter/share/lib 
> does not exist
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:646)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:760)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:746)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:984)
> at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1512)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:243)
> at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
> at org.apache.oozie.command.XCommand.call(XCommand.java:290)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:334)
> at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:263)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:181)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> Error starting action [mr-node]. ErrorType [FAILED], ErrorCode [It should 
> never happen]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)