Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-29 Thread Rohini Palaniswamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review163445
---




core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java (line 
782)


getFirst()

Not a issue with this patch. But please fix the typo before commit


- Rohini Palaniswamy


On Jan. 29, 2017, 9:15 p.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 29, 2017, 9:15 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6e30d7e 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java a107c4a 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java d670142 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be97 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 91fe5a1 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 9a843bd 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 63287b9 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd6 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 82f9bed 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a327 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c19 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 87a2b42 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 0c42128 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 95dcca6 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 3a0ffb0 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8ec38e4 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1f 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d 
>   core/src/test/resources/coord-multiple-output-instance5.xml PRE-CREATION 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 2dbbd4c 
>   docs/src/site/twiki/WebServicesAPI.twiki 8406da6 
>   webapp/src/main/webapp/oozie-console.js 7b20e91 
> 
> Diff: https://reviews.apache.org/r/55214/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-29 Thread Purshotam Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/
---

(Updated Jan. 29, 2017, 9:15 p.m.)


Review request for oozie.


Bugs: OOZIE-2770
https://issues.apache.org/jira/browse/OOZIE-2770


Repository: oozie-git


Description
---

OOZIE-2770 Show missing dependencies for coord actions


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6e30d7e 
  client/src/main/java/org/apache/oozie/client/OozieClient.java a107c4a 
  client/src/main/java/org/apache/oozie/client/rest/JsonTags.java d670142 
  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 9a3be97 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 91fe5a1 
  core/src/main/java/org/apache/oozie/ErrorCode.java 9a843bd 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 PRE-CREATION 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
63287b9 
  core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
b8affd6 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 82f9bed 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 0da60ec 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
 504bc3d 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 aabd2bf 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
 f20dcae 
  core/src/main/java/org/apache/oozie/dependency/ActionDependency.java fe7a327 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
c0e6c19 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 87a2b42 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 0c42128 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 95dcca6 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 3a0ffb0 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8ec38e4 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
 PRE-CREATION 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1f 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
0e74f2d 
  core/src/test/resources/coord-multiple-output-instance5.xml PRE-CREATION 
  docs/src/site/twiki/DG_CommandLineTool.twiki 2dbbd4c 
  docs/src/site/twiki/WebServicesAPI.twiki 8406da6 
  webapp/src/main/webapp/oozie-console.js 7b20e91 

Diff: https://reviews.apache.org/r/55214/diff/


Testing
---


Thanks,

Purshotam Shah

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-29 Thread Purshotam Shah 


> On Jan. 28, 2017, 1:32 p.m., Attila Sasvari wrote:
> > client/src/main/java/org/apache/oozie/cli/OozieCLI.java, line 1354
> > 
> >
> > If you close System.out via ps, you will no longer be able to write to 
> > the console. If there is a subsequent call, nothing will be printed to 
> > System.out. So, you can leave the task of closing System.out to the JVM.
> > 
> > I would simply pass System.out getCoordActionMissingDependencies and 
> > remove the surrounding try catch and would fix other similar methods. I 
> > beleive it would make easier to read the code. (Or if you want to keep the 
> > current logic, you could use try-with-resources from java 7.)

You are correct. But it may not matter to Oozie CLI because it just makes one 
command in one run. But I agree that it's better to not close System.out. We do 
it in multiple places.  I guess I just copied it. You can create a different 
JIRA to fix them.


- Purshotam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review163400
---


On Jan. 27, 2017, 8:14 p.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 27, 2017, 8:14 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
> 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 
> a107c4a3224dba76a59b9eb7c1903c0022d553a4 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
> d670142f446798f39fbb1cd8c3aed738a0897b18 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 91fe5a1d709ba1a90e493d301030465aa35ca790 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 9a843bd0f60ef3b946748adcd45563863c291a60 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc9094aaf24a6636ccebea17493e457fcce 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
> 82f9bede0878b361ffb47d865036573b15448c68 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec70373399414a637c22753da7e2a7e6618 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d5f8c48676736cb461462677ddac400d17 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae0ff44d745ffbcb22bce2653d042a65122 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a3272190718f21aa594188013fadfa9b58646 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c198f4978744016f35dd8940db345a71f92c 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
> 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
> 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 95dcca63c459475b8d41a85e0db11ca2a530a2e4 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
> 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
> 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
>   core/src/test/resources/coord-multiple-output-instance5.xml 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> 2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-28 Thread Attila Sasvari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review163400
---




client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 1354)


If you close System.out via ps, you will no longer be able to write to the 
console. If there is a subsequent call, nothing will be printed to System.out. 
So, you can leave the task of closing System.out to the JVM.

I would simply pass System.out getCoordActionMissingDependencies and remove 
the surrounding try catch and would fix other similar methods. I beleive it 
would make easier to read the code. (Or if you want to keep the current logic, 
you could use try-with-resources from java 7.)



core/src/main/java/org/apache/oozie/CoordinatorEngine.java (line 994)


typo "ist"


- Attila Sasvari


On Jan. 27, 2017, 8:14 p.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 27, 2017, 8:14 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
> 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 
> a107c4a3224dba76a59b9eb7c1903c0022d553a4 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
> d670142f446798f39fbb1cd8c3aed738a0897b18 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 91fe5a1d709ba1a90e493d301030465aa35ca790 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 9a843bd0f60ef3b946748adcd45563863c291a60 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc9094aaf24a6636ccebea17493e457fcce 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
> 82f9bede0878b361ffb47d865036573b15448c68 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec70373399414a637c22753da7e2a7e6618 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d5f8c48676736cb461462677ddac400d17 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae0ff44d745ffbcb22bce2653d042a65122 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a3272190718f21aa594188013fadfa9b58646 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c198f4978744016f35dd8940db345a71f92c 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
> 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
> 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 95dcca63c459475b8d41a85e0db11ca2a530a2e4 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
> 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
> 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
>   core/src/test/resources/coord-multiple-output-instance5.xml 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> 2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> 8406da6ab3bec859a9ef2b889e558f6c9ad1d652 
>   webapp/src/main/webapp/oozie-console.js 
> 7b20e9196cc6129b53fc610d34f6090311474eae 
> 
> Diff: https://reviews.apache.org/r/55214/diff/
> 
> 
> Testing

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-27 Thread Purshotam Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/
---

(Updated Jan. 27, 2017, 8:14 p.m.)


Review request for oozie.


Bugs: OOZIE-2770
https://issues.apache.org/jira/browse/OOZIE-2770


Repository: oozie-git


Description
---

OOZIE-2770 Show missing dependencies for coord actions


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 
a107c4a3224dba76a59b9eb7c1903c0022d553a4 
  client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
d670142f446798f39fbb1cd8c3aed738a0897b18 
  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
91fe5a1d709ba1a90e493d301030465aa35ca790 
  core/src/main/java/org/apache/oozie/ErrorCode.java 
9a843bd0f60ef3b946748adcd45563863c291a60 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc9094aaf24a6636ccebea17493e457fcce 
  core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
82f9bede0878b361ffb47d865036573b15448c68 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 0da60ec70373399414a637c22753da7e2a7e6618 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
 504bc3d5f8c48676736cb461462677ddac400d17 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
 f20dcae0ff44d745ffbcb22bce2653d042a65122 
  core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
fe7a3272190718f21aa594188013fadfa9b58646 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
c0e6c198f4978744016f35dd8940db345a71f92c 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
95dcca63c459475b8d41a85e0db11ca2a530a2e4 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
8ec38e498f31bb69923125e34cda5abfc8e72aa9 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
  core/src/test/resources/coord-multiple-output-instance5.xml 
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  docs/src/site/twiki/DG_CommandLineTool.twiki 
2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
  docs/src/site/twiki/WebServicesAPI.twiki 
8406da6ab3bec859a9ef2b889e558f6c9ad1d652 
  webapp/src/main/webapp/oozie-console.js 
7b20e9196cc6129b53fc610d34f6090311474eae 

Diff: https://reviews.apache.org/r/55214/diff/


Testing
---


Thanks,

Purshotam Shah

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Rohini Palaniswamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review162727
---


Ship it!




Ship It!

- Rohini Palaniswamy


On Jan. 23, 2017, 10:11 p.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 23, 2017, 10:11 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6e30d7e 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java a107c4a 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java d670142 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be97 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 91fe5a1 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 9a843bd 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd6 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 82f9bed 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a327 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c19 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 87a2b42 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 0c42128 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 95dcca6 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 3a0ffb0 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8ec38e4 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1f 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d 
>   core/src/test/resources/coord-multiple-output-instance5.xml PRE-CREATION 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 2dbbd4c 
>   docs/src/site/twiki/WebServicesAPI.twiki 8406da6 
>   webapp/src/main/webapp/oozie-console.js 7b20e91 
> 
> Diff: https://reviews.apache.org/r/55214/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Purshotam Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/
---

(Updated Jan. 23, 2017, 10:11 p.m.)


Review request for oozie.


Bugs: OOZIE-2770
https://issues.apache.org/jira/browse/OOZIE-2770


Repository: oozie-git


Description
---

OOZIE-2770 Show missing dependencies for coord actions


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6e30d7e 
  client/src/main/java/org/apache/oozie/client/OozieClient.java a107c4a 
  client/src/main/java/org/apache/oozie/client/rest/JsonTags.java d670142 
  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 9a3be97 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 91fe5a1 
  core/src/main/java/org/apache/oozie/ErrorCode.java 9a843bd 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 PRE-CREATION 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc 
  core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
b8affd6 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 82f9bed 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 0da60ec 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
 504bc3d 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 aabd2bf 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
 f20dcae 
  core/src/main/java/org/apache/oozie/dependency/ActionDependency.java fe7a327 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
c0e6c19 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 87a2b42 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 0c42128 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 95dcca6 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 3a0ffb0 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8ec38e4 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
 PRE-CREATION 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1f 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
0e74f2d 
  core/src/test/resources/coord-multiple-output-instance5.xml PRE-CREATION 
  docs/src/site/twiki/DG_CommandLineTool.twiki 2dbbd4c 
  docs/src/site/twiki/WebServicesAPI.twiki 8406da6 
  webapp/src/main/webapp/oozie-console.js 7b20e91 

Diff: https://reviews.apache.org/r/55214/diff/


Testing
---


Thanks,

Purshotam Shah

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Purshotam Shah 


> On Jan. 23, 2017, 5:48 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java, line 231
> > 
> >
> > Accidental revert?

Yes, will fix it.


- Purshotam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review162661
---


On Jan. 23, 2017, 9:05 a.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 23, 2017, 9:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
> 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 
> a107c4a3224dba76a59b9eb7c1903c0022d553a4 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
> d670142f446798f39fbb1cd8c3aed738a0897b18 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 91fe5a1d709ba1a90e493d301030465aa35ca790 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 9a843bd0f60ef3b946748adcd45563863c291a60 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc9094aaf24a6636ccebea17493e457fcce 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
> 82f9bede0878b361ffb47d865036573b15448c68 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec70373399414a637c22753da7e2a7e6618 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d5f8c48676736cb461462677ddac400d17 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae0ff44d745ffbcb22bce2653d042a65122 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a3272190718f21aa594188013fadfa9b58646 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c198f4978744016f35dd8940db345a71f92c 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
> 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
> 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 95dcca63c459475b8d41a85e0db11ca2a530a2e4 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
> 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
> 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
>   core/src/test/resources/coord-multiple-output-instance5.xml 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> 2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> 8406da6ab3bec859a9ef2b889e558f6c9ad1d652 
>   webapp/src/main/webapp/oozie-console.js 
> 7b20e9196cc6129b53fc610d34f6090311474eae 
> 
> Diff: https://reviews.apache.org/r/55214/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Rohini Palaniswamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review162661
---




core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java (line 231)


Accidental revert?


- Rohini Palaniswamy


On Jan. 23, 2017, 9:05 a.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 23, 2017, 9:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
> 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 
> a107c4a3224dba76a59b9eb7c1903c0022d553a4 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
> d670142f446798f39fbb1cd8c3aed738a0897b18 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 91fe5a1d709ba1a90e493d301030465aa35ca790 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 9a843bd0f60ef3b946748adcd45563863c291a60 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc9094aaf24a6636ccebea17493e457fcce 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
> 82f9bede0878b361ffb47d865036573b15448c68 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec70373399414a637c22753da7e2a7e6618 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d5f8c48676736cb461462677ddac400d17 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae0ff44d745ffbcb22bce2653d042a65122 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a3272190718f21aa594188013fadfa9b58646 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c198f4978744016f35dd8940db345a71f92c 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
> 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
> 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 95dcca63c459475b8d41a85e0db11ca2a530a2e4 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
> 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
> 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   
> core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
>  6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
>   core/src/test/resources/coord-multiple-output-instance5.xml 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> 2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> 8406da6ab3bec859a9ef2b889e558f6c9ad1d652 
>   webapp/src/main/webapp/oozie-console.js 
> 7b20e9196cc6129b53fc610d34f6090311474eae 
> 
> Diff: https://reviews.apache.org/r/55214/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Purshotam Shah 


> On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote:
> > client/src/main/java/org/apache/oozie/cli/OozieCLI.java, line 182
> > 
> >
> > missingdeps instead of missingDependencies. Too long and we don't use 
> > camel case for command line options.

Agree.


> On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote:
> > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java, lines 
> > 248-249
> > 
> >
> > Indentation does not look right.

it's correct.


> On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java,
> >  lines 325-327
> > 
> >
> > I don't see CoordPushInputDependency implementing this method. How does 
> > it work for that?

For input-logic first missing dependencies is always null ( and it doesn't get 
displayed in CLI/UI), because it difficult to find first since we don execute 
expression


> On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java,
> >  line 66
> > 
> >
> > GET_COORD_ACTION_DEPENDENCIES

This is already being used by CoordActionInputCheckXCommand.


- Purshotam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review162319
---


On Jan. 23, 2017, 9:05 a.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55214/
> ---
> 
> (Updated Jan. 23, 2017, 9:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2770
> https://issues.apache.org/jira/browse/OOZIE-2770
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2770 Show missing dependencies for coord actions
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
> 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 
> a107c4a3224dba76a59b9eb7c1903c0022d553a4 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
> d670142f446798f39fbb1cd8c3aed738a0897b18 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 91fe5a1d709ba1a90e493d301030465aa35ca790 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 9a843bd0f60ef3b946748adcd45563863c291a60 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 0af7edc9094aaf24a6636ccebea17493e457fcce 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
> b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
> 82f9bede0878b361ffb47d865036573b15448c68 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
>  0da60ec70373399414a637c22753da7e2a7e6618 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
>  504bc3d5f8c48676736cb461462677ddac400d17 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
>  aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
>   
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
>  f20dcae0ff44d745ffbcb22bce2653d042a65122 
>   core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
> fe7a3272190718f21aa594188013fadfa9b58646 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
>  c0e6c198f4978744016f35dd8940db345a71f92c 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
> 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
> 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 95dcca63c459475b8d41a85e0db11ca2a530a2e4 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
> 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
> 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
>

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-23 Thread Purshotam Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/
---

(Updated Jan. 23, 2017, 9:05 a.m.)


Review request for oozie.


Bugs: OOZIE-2770
https://issues.apache.org/jira/browse/OOZIE-2770


Repository: oozie-git


Description
---

OOZIE-2770 Show missing dependencies for coord actions


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 
a107c4a3224dba76a59b9eb7c1903c0022d553a4 
  client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
d670142f446798f39fbb1cd8c3aed738a0897b18 
  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
9a3be979e1acf6fce8dc13ccdf985ce47215cf49 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
91fe5a1d709ba1a90e493d301030465aa35ca790 
  core/src/main/java/org/apache/oozie/ErrorCode.java 
9a843bd0f60ef3b946748adcd45563863c291a60 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc9094aaf24a6636ccebea17493e457fcce 
  core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
82f9bede0878b361ffb47d865036573b15448c68 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 0da60ec70373399414a637c22753da7e2a7e6618 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
 504bc3d5f8c48676736cb461462677ddac400d17 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
 f20dcae0ff44d745ffbcb22bce2653d042a65122 
  core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
fe7a3272190718f21aa594188013fadfa9b58646 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
c0e6c198f4978744016f35dd8940db345a71f92c 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
87a2b426ad3f5eeb08e76e1be473fdcdf387d293 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
95dcca63c459475b8d41a85e0db11ca2a530a2e4 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
8ec38e498f31bb69923125e34cda5abfc8e72aa9 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
  core/src/test/resources/coord-multiple-output-instance5.xml 
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  docs/src/site/twiki/DG_CommandLineTool.twiki 
2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 
  docs/src/site/twiki/WebServicesAPI.twiki 
8406da6ab3bec859a9ef2b889e558f6c9ad1d652 
  webapp/src/main/webapp/oozie-console.js 
7b20e9196cc6129b53fc610d34f6090311474eae 

Diff: https://reviews.apache.org/r/55214/diff/


Testing
---


Thanks,

Purshotam Shah

Re: Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-19 Thread Rohini Palaniswamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/#review162319
---




client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 182)


missingdeps instead of missingDependencies. Too long and we don't use camel 
case for command line options.



client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 386)


List missing dependencies of a coord action. To specify multiple actions, 
use with -action or -date option.



client/src/main/java/org/apache/oozie/client/OozieClient.java (line 595)


Can you move this utility method to either bottom of the class or next to 
where it is called?



client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1223)


Get coord action missing dependencies



client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1235)


Get coord action missing dependencies



client/src/main/java/org/apache/oozie/client/OozieClient.java (lines 1267 - 
1274)


You should send it in sorted order. Users consuming webservice should not 
have to do this.



client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1277)


Command line output uses camel casing and is not consistent with other 
outputs. For eg: job -info. In general, avoid camel casing in user facing 
options, output or documentation. Please change command line output from
id : 6
blockedOn : 
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS
dataSet : input-1
missingDependencies : 
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/40/_SUCCESS
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/20/_SUCCESS
  
to below. "CoordAction ID" already exists and is used in other job command 
outputs.

CoordAction ID : 6
Blocked on : 
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS
Dataset : input-1
Pending Dependencies : 
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/40/_SUCCESS
  
hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/20/_SUCCESS



client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1312)


No missing input dependencies found



client/src/main/java/org/apache/oozie/client/rest/JsonTags.java (lines 248 - 
249)


Indentation does not look right.



core/src/main/java/org/apache/oozie/CoordinatorEngine.java (line 990)


Get coord action missing dependencies



core/src/main/java/org/apache/oozie/CoordinatorEngine.java (line 994)


... list of missing input dependencies. 

Avoid capitalizing in the middle of sentence unless required.



core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 (line 48)


CoordActionMissingDependenciesXCommand



core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 (lines 123 - 129)


Instead of creating a new one and copying over both, can do
pullDependencies.putAll(pushDependencies);



core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 (lines 324 - 326)


I don't see CoordPushInputDependency implementing this method. How does it 
work for that?



core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
(line 66)


GET_COORD_ACTION_DEPENDENCIES



core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java (line 53)


Declared but not used



core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java (line 332)


Use COORDINATOR_ACTION_ID instead. Same but reads better in context.

Review Request 55214: OOZIE-2770 Show missing dependencies for coord actions

2017-01-06 Thread Purshotam Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55214/
---

Review request for oozie.


Bugs: OOZIE-2770
https://issues.apache.org/jira/browse/OOZIE-2770


Repository: oozie-git


Description
---

OOZIE-2770 Show missing dependencies for coord actions


Diffs
-

  client/src/main/java/org/apache/oozie/cli/OozieCLI.java 
e67fae9e2c7b32c1f209c24b4aba98daba96c06e 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 
12c80cbf422447c8d5c98e6ba95737e127087173 
  client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 
397e9ede8ebf63281c7f56f9cb9ee44c1518a1ed 
  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
41293642b06743294e4a640a2c66865b4e64eebd 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
91fe5a1d709ba1a90e493d301030465aa35ca790 
  core/src/main/java/org/apache/oozie/ErrorCode.java 
8fc3835023744ae7506b849ee676b0f763ed575d 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
0af7edc9094aaf24a6636ccebea17493e457fcce 
  core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java 
b8affd67a412fac7d4ec452d7e2efa02c62ce25a 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 
82f9bede0878b361ffb47d865036573b15448c68 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java
 0da60ec70373399414a637c22753da7e2a7e6618 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java
 504bc3d5f8c48676736cb461462677ddac400d17 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java
 aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf 
  
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java
 f20dcae0ff44d745ffbcb22bce2653d042a65122 
  core/src/main/java/org/apache/oozie/dependency/ActionDependency.java 
fe7a3272190718f21aa594188013fadfa9b58646 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 
c0e6c198f4978744016f35dd8940db345a71f92c 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 
21105223b1a8a819b4ec091e1a513e5751b51425 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
86ff278e6ff3b6ad9f2e7ea1d3e87446e404d122 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
60f1029d49f78bff973bd167791cfcdaaa1af60f 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 
662a7ff26ff802bcdb530af71b52685bad089a6c 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
ce95ff34030c97b56ed9257ebe027833493a9fa1 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java
 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1fc7e8d1ed85b9e309cd163ae92f005f281 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 
  core/src/test/resources/coord-multiple-output-instance5.xml 
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  docs/src/site/twiki/DG_CommandLineTool.twiki 
35eee40363ffb8d998df34a693ee318cf70a230f 
  docs/src/site/twiki/WebServicesAPI.twiki 
b76e9343087a8c68825d222720543dc6d4d9f27a 
  webapp/src/main/webapp/oozie-console.js 
11c6940bb26c1a8318781ce62926b6e4a185e37c 

Diff: https://reviews.apache.org/r/55214/diff/


Testing
---


Thanks,

Purshotam Shah