Re: Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-18 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65177/
---

(Updated Jan. 18, 2018, 11:35 a.m.)


Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.


Repository: oozie-git


Description
---

After running TestDistcpMain, local files created are not removed. Subsequent 
test runs will reuse those files and fail:
`$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*`
`-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
/home/asasvari/workspace/oozie/core/distcp-log4j.properties`
`-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
/home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log`
Those files should be removed after test execution. It would be better to use 
the oozie/core/target directory so that mvn could clean it.


Diffs (updated)
-

  core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java a3b3b7b3 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 
  core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 728916ec 
  core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
505049d2 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b 
  sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
35c2865e 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
9a185c91 
  
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java 
ff1b3cef 
  
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java 
b9f37c84 
  tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java a7df5c79 


Diff: https://reviews.apache.org/r/65177/diff/2/

Changes: https://reviews.apache.org/r/65177/diff/1-2/


Testing
---

I`ve run a mvn clean test and the repository remained clean.


Thanks,

Kinga Marton

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-17 Thread Peter Bacsko via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65177/#review195568
---




core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 505 (patched)


Nit: space after "f" :)



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java
Lines 148 (patched)


This annotation is not needed - JUnit3 test runner is used to run this test.


- Peter Bacsko


On jan. 16, 2018, 2:45 du, Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65177/
> ---
> 
> (Updated jan. 16, 2018, 2:45 du)
> 
> 
> Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> After running TestDistcpMain, local files created are not removed. Subsequent 
> test runs will reuse those files and fail:
> `$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*`
> `-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
> /home/asasvari/workspace/oozie/core/distcp-log4j.properties`
> `-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
> /home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log`
> Those files should be removed after test execution. It would be better to use 
> the oozie/core/target directory so that mvn could clean it.
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
> a3b3b7b3 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 
>   core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 
> 728916ec 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 505049d2 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b 
>   
> sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
> 35c2865e 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
> 9a185c91 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java
>  ff1b3cef 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java
>  b9f37c84 
>   tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java 
> a7df5c79 
> 
> 
> Diff: https://reviews.apache.org/r/65177/diff/1/
> 
> 
> Testing
> ---
> 
> I`ve run a mvn clean test and the repository remained clean.
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-17 Thread Peter Cseh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65177/#review195561
---




sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java
Line 47 (original), 49 (patched)


can we create the jar in a temporary folder or in target/ instead of 
deleting it after the fact?


- Peter Cseh


On Jan. 16, 2018, 2:45 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65177/
> ---
> 
> (Updated Jan. 16, 2018, 2:45 p.m.)
> 
> 
> Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> After running TestDistcpMain, local files created are not removed. Subsequent 
> test runs will reuse those files and fail:
> `$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*`
> `-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
> /home/asasvari/workspace/oozie/core/distcp-log4j.properties`
> `-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
> /home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log`
> Those files should be removed after test execution. It would be better to use 
> the oozie/core/target directory so that mvn could clean it.
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
> a3b3b7b3 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 
>   core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 
> 728916ec 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 505049d2 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b 
>   
> sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
> 35c2865e 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
> 9a185c91 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java
>  ff1b3cef 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java
>  b9f37c84 
>   tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java 
> a7df5c79 
> 
> 
> Diff: https://reviews.apache.org/r/65177/diff/1/
> 
> 
> Testing
> ---
> 
> I`ve run a mvn clean test and the repository remained clean.
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-17 Thread Peter Cseh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65177/#review195560
---




core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 501 (patched)


Can you create a function that returns the "files to delete" list? I think 
it would be nicer to just overwrite that methong in Pig and Spark tests to add 
more files there.


- Peter Cseh


On Jan. 16, 2018, 2:45 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65177/
> ---
> 
> (Updated Jan. 16, 2018, 2:45 p.m.)
> 
> 
> Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> After running TestDistcpMain, local files created are not removed. Subsequent 
> test runs will reuse those files and fail:
> `$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*`
> `-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
> /home/asasvari/workspace/oozie/core/distcp-log4j.properties`
> `-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
> /home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log`
> Those files should be removed after test execution. It would be better to use 
> the oozie/core/target directory so that mvn could clean it.
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
> a3b3b7b3 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 
>   core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 
> 728916ec 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 505049d2 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b 
>   
> sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
> 35c2865e 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
> 9a185c91 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java
>  ff1b3cef 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java
>  b9f37c84 
>   tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java 
> a7df5c79 
> 
> 
> Diff: https://reviews.apache.org/r/65177/diff/1/
> 
> 
> Testing
> ---
> 
> I`ve run a mvn clean test and the repository remained clean.
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Review Request 65177: >git status< should be clean after >mvn test< was called

2018-01-16 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65177/
---

Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh.


Repository: oozie-git


Description
---

After running TestDistcpMain, local files created are not removed. Subsequent 
test runs will reuse those files and fail:
`$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*`
`-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
/home/asasvari/workspace/oozie/core/distcp-log4j.properties`
`-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
/home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log`
Those files should be removed after test execution. It would be better to use 
the oozie/core/target directory so that mvn could clean it.


Diffs
-

  core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java a3b3b7b3 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 
  core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 728916ec 
  core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
505049d2 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b 
  sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
35c2865e 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
9a185c91 
  
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java 
ff1b3cef 
  
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java 
b9f37c84 
  tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java a7df5c79 


Diff: https://reviews.apache.org/r/65177/diff/1/


Testing
---

I`ve run a mvn clean test and the repository remained clean.


Thanks,

Kinga Marton