Re: DataSourceFactory / BasicManagedDataSource plan of action?

2011-10-07 Thread AndyG
Thanks for the suggestion Romain. I will look into it.

--
View this message in context: 
http://openejb.979440.n4.nabble.com/DataSourceFactory-BasicManagedDataSource-plan-of-action-tp3878426p3881115.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


DataSourceFactory / BasicManagedDataSource plan of action?

2011-10-06 Thread AndyG
I know DataSourceFactory is currently in progress, so this just an enquiry as
to the plan of action based upon my very specific issue.

I am currently using a modified DataSourceFactory and BasicManagedDataSource
due to changes in the latest version. I'll explain why further down.

Basically just changed the following in DataSourceFactory to force the
default create call:

//if (DataSource.class.isAssignableFrom(impl)) {
if (false) {

And in BasicManagedDataSource the close override is commented out - Not sure
why close is overridden in the first place as this prevents the ds from
being closed?

So now my reason. I am using assembler.createResource(ri) directly in a
custom openejb specific deployer to create dynamic datasources during
runtime. This deployer also closes the ds on undeployment - Hence the
'close' requirement.

To be more specific - The deployer creates an entirely new database schema,
deploys a datasource that accesses this schema, then creates and deploys an
application from a template which incorporates a persistence unit. This is
entirely dynamic at runtime and can not be pre-configured. As the schema may
also require a restore during runtime it is also possible to undeploy the
application, including it's datasources. 

The current trunk version of DataSourceFactory is currently hsql specific
(with a comment that it needs to be worked on), so the question is what is
intended here? Is someone working on it, or is it an open issue?

What needs to be done in? :
@Override
public void setJdbcUrl(String string) {...

Are we planning to reflect methods on all possible datasources?

Regards,

Andy.



--
View this message in context: 
http://openejb.979440.n4.nabble.com/DataSourceFactory-BasicManagedDataSource-plan-of-action-tp3878426p3878426.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Re: DataSourceFactory / BasicManagedDataSource plan of action?

2011-10-06 Thread Romain Manni-Bucau
i think nobody works on it now,

in setJdbcUrl we should probably manage more datasource driver or just try a
direct set if we are able to get the url before (i think it was done before
david refactor but it was a bit too raw).

i don't know if i'll match your need but i made resources.xml works with
mysql without any issues, can't it replace your deployer? it is a kind of
light openejb.xml  embeddable in an application (see in webapps examples).

- Romain

2011/10/6 AndyG andy.gumbre...@orprovision.com

 I know DataSourceFactory is currently in progress, so this just an enquiry
 as
 to the plan of action based upon my very specific issue.

 I am currently using a modified DataSourceFactory and
 BasicManagedDataSource
 due to changes in the latest version. I'll explain why further down.

 Basically just changed the following in DataSourceFactory to force the
 default create call:

 //if (DataSource.class.isAssignableFrom(impl)) {
 if (false) {

 And in BasicManagedDataSource the close override is commented out - Not
 sure
 why close is overridden in the first place as this prevents the ds from
 being closed?

 So now my reason. I am using assembler.createResource(ri) directly in a
 custom openejb specific deployer to create dynamic datasources during
 runtime. This deployer also closes the ds on undeployment - Hence the
 'close' requirement.

 To be more specific - The deployer creates an entirely new database schema,
 deploys a datasource that accesses this schema, then creates and deploys an
 application from a template which incorporates a persistence unit. This is
 entirely dynamic at runtime and can not be pre-configured. As the schema
 may
 also require a restore during runtime it is also possible to undeploy the
 application, including it's datasources.

 The current trunk version of DataSourceFactory is currently hsql specific
 (with a comment that it needs to be worked on), so the question is what is
 intended here? Is someone working on it, or is it an open issue?

 What needs to be done in? :
 @Override
 public void setJdbcUrl(String string) {...

 Are we planning to reflect methods on all possible datasources?

 Regards,

 Andy.



 --
 View this message in context:
 http://openejb.979440.n4.nabble.com/DataSourceFactory-BasicManagedDataSource-plan-of-action-tp3878426p3878426.html
 Sent from the OpenEJB Dev mailing list archive at Nabble.com.