date:20230120

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #62: Update sandbox component 'modelbuilder-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread via GitHub



mawiesne commented on code in PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62#discussion_r1082978350


##
modelbuilder-addon/src/main/java/opennlp/addons/modelbuilder/DefaultModelBuilderUtil.java:
##
@@ -98,17 +96,17 @@ public static void generateModel(File sentences, File 
knownEntities, File knownE
  */
 ModelGenerationValidator validator = new FileModelValidatorImpl();
 validator.setParameters(params);
-/**
+/*
  * Modelable's write and read the annotated sentences, as well as create 
and
  * write the NER models
  */
 Modelable modelable = new GenericModelableImpl();
 modelable.setParameters(params);
 
-/**
+/*
  * the modelGenerator actually runs the process with a set number of
  * iterations... could be better by actually calculating the diff between
- * runs and stopping based on a thresh, but for extrememly large sentence
+ * runs and stopping based on a thresh, but for extremely large sentence

Review Comment:
   Nice find. My  were already tired, it seems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] kinow commented on a diff in pull request #62: Update sandbox component 'modelbuilder-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread via GitHub



kinow commented on code in PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62#discussion_r1082912447


##
modelbuilder-addon/src/main/java/opennlp/addons/modelbuilder/DefaultModelBuilderUtil.java:
##
@@ -98,17 +96,17 @@ public static void generateModel(File sentences, File 
knownEntities, File knownE
  */
 ModelGenerationValidator validator = new FileModelValidatorImpl();
 validator.setParameters(params);
-/**
+/*
  * Modelable's write and read the annotated sentences, as well as create 
and
  * write the NER models
  */
 Modelable modelable = new GenericModelableImpl();
 modelable.setParameters(params);
 
-/**
+/*
  * the modelGenerator actually runs the process with a set number of
  * iterations... could be better by actually calculating the diff between
- * runs and stopping based on a thresh, but for extrememly large sentence
+ * runs and stopping based on a thresh, but for extremely large sentence

Review Comment:
   Also s/thresh/threshol



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #55: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-similarity

2023-01-20 Thread GitBox



mawiesne commented on PR #55:
URL: https://github.com/apache/opennlp-sandbox/pull/55#issuecomment-1398612318

   @jzonthemtn FYI: I will migrate this sandbox component here as well. 
However, this is not an easy one... Just to inform you, not to start working on 
that migration; already on it.
   
   CC: @rzo1 @kinow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #49: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /modelbuilder-addon

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #49:
URL: https://github.com/apache/opennlp-sandbox/pull/49#issuecomment-1398558119

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #52: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /tagging-server

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #52:
URL: https://github.com/apache/opennlp-sandbox/pull/52#issuecomment-1398558023

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] jzonthemtn closed pull request #49: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /modelbuilder-addon

2023-01-20 Thread GitBox



jzonthemtn closed pull request #49: Bump opennlp-tools from 1.6.0-SNAPSHOT to 
1.8.2 in /modelbuilder-addon
URL: https://github.com/apache/opennlp-sandbox/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] jzonthemtn closed pull request #52: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /tagging-server

2023-01-20 Thread GitBox



jzonthemtn closed pull request #52: Bump opennlp-tools from 1.5.2-incubating to 
1.8.2 in /tagging-server
URL: https://github.com/apache/opennlp-sandbox/pull/52


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #46: Bump uimaj-core from 2.3.1 to 2.10.2 in /wikinews-importer

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #46: Bump uimaj-core from 2.3.1 to 2.10.2 
in /wikinews-importer
URL: https://github.com/apache/opennlp-sandbox/pull/46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #54: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #54:
URL: https://github.com/apache/opennlp-sandbox/pull/54#issuecomment-1398557897

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #46: Bump uimaj-core from 2.3.1 to 2.10.2 in /wikinews-importer

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #46:
URL: https://github.com/apache/opennlp-sandbox/pull/46#issuecomment-1398557123

   Superseded by #67.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] jzonthemtn closed pull request #54: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



jzonthemtn closed pull request #54: Bump opennlp-tools from 1.5.2-incubating to 
1.8.2 in /caseditor-opennlp-plugin
URL: https://github.com/apache/opennlp-sandbox/pull/54


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #47: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-connector

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #47: Bump uimaj-core from 2.3.1 to 2.10.2 
in /corpus-server-connector
URL: https://github.com/apache/opennlp-sandbox/pull/47


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #44: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-impl

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #44: Bump uimaj-core from 2.3.1 to 2.10.2 
in /corpus-server-impl
URL: https://github.com/apache/opennlp-sandbox/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #43: Bump uimaj-core from 2.4.0 to 2.10.2 in /caseditor-corpus-server-plugin

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #43: Bump uimaj-core from 2.4.0 to 2.10.2 
in /caseditor-corpus-server-plugin
URL: https://github.com/apache/opennlp-sandbox/pull/43


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #47: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-connector

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #47:
URL: https://github.com/apache/opennlp-sandbox/pull/47#issuecomment-1398557103

   Superseded by #70.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #45: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-tools

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #45: Bump uimaj-core from 2.3.1 to 2.10.2 
in /corpus-server-tools
URL: https://github.com/apache/opennlp-sandbox/pull/45


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #45: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-tools

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #45:
URL: https://github.com/apache/opennlp-sandbox/pull/45#issuecomment-1398557089

   Superseded by #66.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #43: Bump uimaj-core from 2.4.0 to 2.10.2 in /caseditor-corpus-server-plugin

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #43:
URL: https://github.com/apache/opennlp-sandbox/pull/43#issuecomment-1398557074

   Superseded by #69.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #69: Bump uimaj-core from 2.4.0 to 3.3.1 in /caseditor-corpus-server-plugin

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #69:
URL: https://github.com/apache/opennlp-sandbox/pull/69

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.4.0 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

Apache UIMA (Unstructured Information Management Architecture) v3.3.1
Release Notes
Contents
https://github.com/apache/uima-uimaj/blob/HEAD/#what.is.uima;>What is
UIMA?
https://github.com/apache/uima-uimaj/blob/HEAD/#major.changes;>Major
Changes in this Release
https://github.com/apache/uima-uimaj/blob/HEAD/#get.involved;>How
to Get Involved
https://github.com/apache/uima-uimaj/blob/HEAD/#report.issues;>How
to Report Issues
What is UIMA?
Unstructured Information Management applications are software systems
that analyze large volumes of
unstructured information in order to discover knowledge that is relevant to
an end user. UIMA is a
framework and SDK for developing such applications. An example UIM
application might ingest plain
text and identify entities, such as persons, places, organizations; or
relations, such as works-for
or located-at. UIMA enables such an application to be decomposed into
components, for example
language identification - language specific
segmentation - sentence boundary detection -
entity detection (person/place names etc.). Each component must
implement interfaces defined by
the framework and must provide self-describing metadata via XML descriptor
files. The framework
manages these components and the data flow between them. Components are
written in Java or C++; the
data that flows between components is designed for efficient mapping between
these languages. UIMA
additionally provides capabilities to wrap components as network services,
and can scale to very
large volumes by replicating processing pipelines over a cluster of
networked nodes.
Apache UIMA is an Apache-licensed open source implementation of the UIMA
specification (that
specification is, in turn, being developed concurrently by a technical
committee within
http://www.oasis-open.org;>OASIS, a standards organization). We
invite and encourage you to
participate in both the implementation and specification efforts.

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

Apache UIMA (Unstructured Information Management Architecture) v3.3.1
Release Notes
Contents
https://github.com/apache/uima-uimaj/blob/main/#what.is.uima;>What is
UIMA?
https://github.com/apache/uima-uimaj/blob/main/#major.changes;>Major
Changes in this Release
https://github.com/apache/uima-uimaj/blob/main/#list.issues;>List
of JIRA Issues Fixed in this Release
https://github.com/apache/uima-uimaj/blob/main/#get.involved;>How
to Get Involved
https://github.com/apache/uima-uimaj/blob/main/#report.issues;>How
to Report Issues
What is UIMA?
Unstructured Information Management applications are software systems
that analyze large volumes of
unstructured information in order to discover knowledge that is relevant to
an end user. UIMA is a
framework and SDK for developing such applications. An example UIM
application might ingest plain
text and identify entities, such as persons, places, organizations; or
relations, such as works-for
or located-at. UIMA enables such an application to be decomposed into
components, for example
language identification - language specific
segmentation - sentence boundary detection -
entity detection (person/place names etc.). Each component must
implement interfaces defined by
the framework and must provide self-describing metadata via XML descriptor
files. The framework
manages these components and the data flow between them. Components are
written in Java or C++; the
data that flows between components is designed for efficient mapping between
these languages. UIMA
additionally provides capabilities to wrap components as network services,
and can scale to very
large volumes by replicating processing pipelines over a cluster of
networked nodes.
Apache UIMA is an Apache-licensed open source implementation of the UIMA
specification (that
specification is, in turn, being developed concurrently by a technical
committee within
http://www.oasis-open.org;>OASIS, a standards organization). We
invite and encourage you to
participate in both the implementation and specification efforts.
UIMA is a component framework for analysing unstructured content such as
text, audio and video. It
comprises an SDK and tooling for composing and running analytic components
written in Java and C++,
with some support for Perl, Python and TCL.
Notable changes in this release
This is a bug fix release.
Bugs fixed

烈 Issue

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #68: Bump uimaj-core from 2.3.1 to 3.3.1 in /corpus-server-impl

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #68:
URL: https://github.com/apache/opennlp-sandbox/pull/68

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.3.1 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

烈 Issue

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #67: Bump uimaj-core from 2.3.1 to 3.3.1 in /wikinews-importer

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #67:
URL: https://github.com/apache/opennlp-sandbox/pull/67

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.3.1 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

烈 Issue

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #65: Bump uimaj-core from 2.4.0 to 3.3.1 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #65:
URL: https://github.com/apache/opennlp-sandbox/pull/65

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.4.0 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

烈 Issue

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #44: Bump uimaj-core from 2.3.1 to 2.10.2 in /corpus-server-impl

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #44:
URL: https://github.com/apache/opennlp-sandbox/pull/44#issuecomment-1398557064

   Superseded by #68.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #42: Bump uimaj-core from 2.4.0 to 2.10.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #42:
URL: https://github.com/apache/opennlp-sandbox/pull/42#issuecomment-1398556972

   Superseded by #65.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] closed pull request #42: Bump uimaj-core from 2.4.0 to 2.10.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



dependabot[bot] closed pull request #42: Bump uimaj-core from 2.4.0 to 2.10.2 
in /caseditor-opennlp-plugin
URL: https://github.com/apache/opennlp-sandbox/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #70: Bump uimaj-core from 2.3.1 to 3.3.1 in /corpus-server-connector

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #70:
URL: https://github.com/apache/opennlp-sandbox/pull/70

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.3.1 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

烈 Issue

[GitHub] [opennlp-sandbox] dependabot[bot] opened a new pull request, #66: Bump uimaj-core from 2.3.1 to 3.3.1 in /corpus-server-tools

2023-01-20 Thread GitBox

dependabot[bot] opened a new pull request, #66:
URL: https://github.com/apache/opennlp-sandbox/pull/66

Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 2.3.1 to 3.3.1.

Release notes
Sourced from https://github.com/apache/uima-uimaj/releases;>uimaj-core's
releases.

Apache UIMA Java SDK 3.3.1

... (truncated)

Changelog
Sourced from https://github.com/apache/uima-uimaj/blob/main/RELEASE_NOTES.md;>uimaj-core's
changelog.

烈 Issue

[GitHub] [opennlp-sandbox] jzonthemtn merged pull request #61: Update sandbox component 'mallet-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



jzonthemtn merged PR #61:
URL: https://github.com/apache/opennlp-sandbox/pull/61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] jzonthemtn merged pull request #60: Update sandbox component 'mahout-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



jzonthemtn merged PR #60:
URL: https://github.com/apache/opennlp-sandbox/pull/60


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] jzonthemtn merged pull request #58: Update sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



jzonthemtn merged PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #42: Bump uimaj-core from 2.4.0 to 2.10.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



mawiesne commented on PR #42:
URL: https://github.com/apache/opennlp-sandbox/pull/42#issuecomment-1398551432

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/64 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #54: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /caseditor-opennlp-plugin

2023-01-20 Thread GitBox



mawiesne commented on PR #54:
URL: https://github.com/apache/opennlp-sandbox/pull/54#issuecomment-1398551024

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/64 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #64: Update sandbox component 'caseditor-opennlp-plugin' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne opened a new pull request, #64:
URL: https://github.com/apache/opennlp-sandbox/pull/64

   - adjusts opennlp-tools to 2.1.0
   - adjusts parent project (org.apache.apache) to version 18
   - adjusts Java language level to 11
   - updates `uimaj` dependencies to version 2.10.4
   - updates `maven-bundle-plugin` to version 5.1.8 so things work with class 
files compiled in Java 11 format
   - adjusts some array declarations to comply with Java, not C style
   - removes unused imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #52: Bump opennlp-tools from 1.5.2-incubating to 1.8.2 in /tagging-server

2023-01-20 Thread GitBox



mawiesne commented on PR #52:
URL: https://github.com/apache/opennlp-sandbox/pull/52#issuecomment-1398449715

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/63 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #63: Update sandbox component 'tagging-server' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne opened a new pull request, #63:
URL: https://github.com/apache/opennlp-sandbox/pull/63

   - adjusts opennlp-tools to 2.1.0
   - adjusts parent project (org.apache.apache) to version 18
   - adjusts Java language level to 11
   - updates `maven-bundle-plugin` to version 5.1.8 so things work with class 
files compiled in Java 11 format
   - adjusts some array declarations to comply with Java, not C style
   - removes unused imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #49: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /modelbuilder-addon

2023-01-20 Thread GitBox



mawiesne commented on PR #49:
URL: https://github.com/apache/opennlp-sandbox/pull/49#issuecomment-1398419748

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/62 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #62: Update sandbox component 'modelbuilder-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne opened a new pull request, #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62

   - adjusts opennlp-tools to 2.1.0
   - adjusts parent project (org.apache.apache) to version 18
   - adjusts Java language level to 11
   - improves resource handling of streams
   - removes funny pseudo JUnit-test which was effectively doing nothing
   - removes unused imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #50: Bump opennlp-tools from 1.6.1-SNAPSHOT to 1.8.2 in /mallet-addon

2023-01-20 Thread GitBox



mawiesne commented on PR #50:
URL: https://github.com/apache/opennlp-sandbox/pull/50#issuecomment-1398272054

   Closing in favor of #61.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #50: Bump opennlp-tools from 1.6.1-SNAPSHOT to 1.8.2 in /mallet-addon

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #50:
URL: https://github.com/apache/opennlp-sandbox/pull/50#issuecomment-1398271746

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne closed pull request #50: Bump opennlp-tools from 1.6.1-SNAPSHOT to 1.8.2 in /mallet-addon

2023-01-20 Thread GitBox



mawiesne closed pull request #50: Bump opennlp-tools from 1.6.1-SNAPSHOT to 
1.8.2 in /mallet-addon
URL: https://github.com/apache/opennlp-sandbox/pull/50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #50: Bump opennlp-tools from 1.6.1-SNAPSHOT to 1.8.2 in /mallet-addon

2023-01-20 Thread GitBox



mawiesne commented on PR #50:
URL: https://github.com/apache/opennlp-sandbox/pull/50#issuecomment-1398189559

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/61 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #61: Updates sandbox component 'mallet-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne opened a new pull request, #61:
URL: https://github.com/apache/opennlp-sandbox/pull/61

   - adjusts opennlp-tools to 2.1.0
   - adjusts parent project (org.apache.apache) to version 18
   - adjusts Java language level to 11
   - updates to mallet version 2.0.8 to mitigate several CVEs, adds exclusions 
and related newer versions to mitigate CVEs
   - adjusts some array declarations to comply with Java, not C, style
   - improves resource handling of streams
   - removes unused imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp] rzo1 opened a new pull request, #493: OPENNLP-1452 - Upgrade to Apache Parent 29

2023-01-20 Thread GitBox



rzo1 opened a new pull request, #493:
URL: https://github.com/apache/opennlp/pull/493

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x Does your PR title start with OPENNLP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #60: Updates sandbox component 'mahout-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #60:
URL: https://github.com/apache/opennlp-sandbox/pull/60#discussion_r108224


##
mahout-addon/pom.xml:
##
@@ -21,40 +21,52 @@
 
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
-   
+

-   org.apache.opennlp
-   opennlp
-   1.6.0-SNAPSHOT
-   ../opennlp/pom.xml
-
-
+   org.apache
+   apache
+   
+   18
+   
+   
+
mahout-addon
+   2.1.1-SNAPSHOT
jar
Apache OpenNLP Mahout Addon
 


org.apache.opennlp
opennlp-tools
-   1.6.0-SNAPSHOT
+   2.1.0

-   
+

org.apache.mahout
mahout-core
-   0.8
+   0.9

 

junit
junit
+   4.13.1

Review Comment:
   Will be change to JUnit 5 anyway, once new sandbox parent pom lands.



##
mahout-addon/pom.xml:
##
@@ -21,40 +21,52 @@
 
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
-   
+

-   org.apache.opennlp
-   opennlp
-   1.6.0-SNAPSHOT
-   ../opennlp/pom.xml
-
-
+   org.apache
+   apache
+   
+   18
+   
+   
+
mahout-addon
+   2.1.1-SNAPSHOT
jar
Apache OpenNLP Mahout Addon
 


org.apache.opennlp
opennlp-tools
-   1.6.0-SNAPSHOT
+   2.1.0

-   
+

org.apache.mahout
mahout-core
-   0.8
+   0.9

 

junit
junit
+   4.13.1

Review Comment:
   Will be changed to JUnit 5 anyway, once new sandbox parent pom lands.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #60: Updates sandbox component 'mahout-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #60:
URL: https://github.com/apache/opennlp-sandbox/pull/60#discussion_r1082298980


##
mahout-addon/pom.xml:
##
@@ -21,40 +21,52 @@
 
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
-   
+

-   org.apache.opennlp
-   opennlp
-   1.6.0-SNAPSHOT
-   ../opennlp/pom.xml
-
-
+   org.apache
+   apache
+   
+   18
+   
+   
+
mahout-addon
+   2.1.1-SNAPSHOT
jar
Apache OpenNLP Mahout Addon
 


org.apache.opennlp
opennlp-tools
-   1.6.0-SNAPSHOT
+   2.1.0

-   
+

org.apache.mahout
mahout-core
-   0.8
+   0.9

 

junit
junit
+   4.13.1

Review Comment:
   `4.13.2` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #48: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /mahout-addon

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #48:
URL: https://github.com/apache/opennlp-sandbox/pull/48#issuecomment-1398147576

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne closed pull request #48: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /mahout-addon

2023-01-20 Thread GitBox



mawiesne closed pull request #48: Bump opennlp-tools from 1.6.0-SNAPSHOT to 
1.8.2 in /mahout-addon
URL: https://github.com/apache/opennlp-sandbox/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #48: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /mahout-addon

2023-01-20 Thread GitBox



mawiesne commented on PR #48:
URL: https://github.com/apache/opennlp-sandbox/pull/48#issuecomment-1398147454

   Closing in favor of #60.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #48: Bump opennlp-tools from 1.6.0-SNAPSHOT to 1.8.2 in /mahout-addon

2023-01-20 Thread GitBox



mawiesne commented on PR #48:
URL: https://github.com/apache/opennlp-sandbox/pull/48#issuecomment-1398145989

   This PR can be closed, provided 
https://github.com/apache/opennlp-sandbox/pull/60 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #60: Updates sandbox component 'mahout-addon' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne opened a new pull request, #60:
URL: https://github.com/apache/opennlp-sandbox/pull/60

   - adjusts opennlp-tools to 2.1.0
   - adjusts parent project (org.apache.apache) to version 18
   - adjusts Java language level to 11
   - updates to mahout-core in version 0.9 to mitigate several CVEs
   - removes unused imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp] rzo1 commented on pull request #492: OPENNLP-1448 - Introduce SLF4J in OpenNLP

2023-01-20 Thread GitBox



rzo1 commented on PR #492:
URL: https://github.com/apache/opennlp/pull/492#issuecomment-1398138413

   Switched it to `DRAFT`, so it cannot be merged accidently but the review 
would be very much appreciated!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp] rzo1 opened a new pull request, #492: OPENNLP-1448 - Introduce SLF4J in OpenNLP

2023-01-20 Thread GitBox



rzo1 opened a new pull request, #492:
URL: https://github.com/apache/opennlp/pull/492

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with OPENNLP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [x] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   
   This PR is the first sub-task of 
[OPENNLP-1447](https://issues.apache.org/jira/browse/OPENNLP-1447).
   
   - It introduces `slf4j-api` in OpenNLP and replaces calls to `System.err` or 
`System.out` by related logger calls.
   - It adds `log4j2` as `runtime` dependency to the OpenNLP distribution + 
related configuration and adjusts the scripts accordingly
   
    Notes for reviewers:
   
   - Revision of log levels is tracked with 
[OPENNLP-1449](https://issues.apache.org/jira/browse/OPENNLP-1449) and is not 
scope of the given PR. However, comments on specific log levels are highly 
welcome, so they can be tracked and incorporated in OPENNLP-1449.
   - Fully use of formatting using the possibilities of SLF4J 
eg.`{}`-replacement is tracked with 
[OPENNLP-1450](https://issues.apache.org/jira/browse/OPENNLP-1450) and is not 
scope of the given PR.
   - Log output reduction during the build is currently tracked with  
[OPENNLP-1451](https://issues.apache.org/jira/browse/OPENNLP-1451). At the 
moment, I introduced `slf4j-simple` as a `test` dependency and disabled log 
output. We can discuss how we want to deal with it within OPENNLP-1451.
   - If some removed `System.out / System.err` statements (in the tests) are 
really needed, please leave a comment. We can easily move them to log statements
   
    TODOs for reviewers:
   
   - It would be great, if our heavy CLI users like @atarora can provide 
valuable feedback. Due to the absence of a Windows machine, I cannot test the 
`.bat` changes - maybe some Windows user can have a look here.
   - It would be great, if someone with the `eval` datasets available on 
his/her machine can run the `eval` tests and provide feedback, if needed.
   - I disabled a few tests, which relied on overriding `System.out` and 
gathering the output. Happy to receive ideas on how we can re-write them to 
work with `slf4j-simple` in the test context
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #51: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-wsd

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #51:
URL: https://github.com/apache/opennlp-sandbox/pull/51#issuecomment-1398117629

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne closed pull request #51: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-wsd

2023-01-20 Thread GitBox



mawiesne closed pull request #51: Bump opennlp-tools from 1.6.0 to 1.8.2 in 
/opennlp-wsd
URL: https://github.com/apache/opennlp-sandbox/pull/51


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #51: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-wsd

2023-01-20 Thread GitBox



mawiesne commented on PR #51:
URL: https://github.com/apache/opennlp-sandbox/pull/51#issuecomment-1398117571

   Closing in favor of #59.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] dependabot[bot] commented on pull request #53: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-coref

2023-01-20 Thread GitBox



dependabot[bot] commented on PR #53:
URL: https://github.com/apache/opennlp-sandbox/pull/53#issuecomment-1398117188

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne closed pull request #53: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-coref

2023-01-20 Thread GitBox



mawiesne closed pull request #53: Bump opennlp-tools from 1.6.0 to 1.8.2 in 
/opennlp-coref
URL: https://github.com/apache/opennlp-sandbox/pull/53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #53: Bump opennlp-tools from 1.6.0 to 1.8.2 in /opennlp-coref

2023-01-20 Thread GitBox



mawiesne commented on PR #53:
URL: https://github.com/apache/opennlp-sandbox/pull/53#issuecomment-1398117132

   Closing in favor of #58.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1398109754

   > Added some (non blocking) comments.
   
   @rzo1 Comments resolved where applicable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082255758


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/SemcorReaderExtended.java:
##
@@ -200,7 +202,7 @@ private ArrayList readFile(String file) {
*/
   private ArrayList getSemcorOneFileData(String file, String 
wordTag) {
 
-ArrayList setInstances = new ArrayList();
+ArrayList setInstances = new ArrayList<>();

Review Comment:
   see other comment, not this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r108228


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -631,7 +629,7 @@ public static ArrayList 
getAllRelevantWords(String[] sentence) {
   public static ArrayList StemWordWithWordNet(WordPOS wordToStem) {
 if (wordToStem == null)
   return null;
-ArrayList stems = new ArrayList();
+ArrayList stems = new ArrayList<>();

Review Comment:
   see other comment, not this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082255136


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -606,7 +604,7 @@ public static boolean areStringArraysEqual(String[] array1, 
String[] array2) {
 
   public static ArrayList getAllRelevantWords(String[] sentence) {
 
-ArrayList relevantWords = new ArrayList();
+ArrayList relevantWords = new ArrayList<>();

Review Comment:
   Method signature returns ArrayList and is used quite frequently under this 
assumption. Won't change (in this PR).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082250243


##
opennlp-coref/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   I'll leave a TODO referencing this issue number here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082245585


##
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/AbstractResolver.java:
##
@@ -169,7 +170,14 @@ public DiscourseEntity retain(MentionContext mention, 
DiscourseModel dm) {
   DiscourseEntity cde = dm.getEntity(ei);
   MentionContext cec = cde.getLastExtent(); // candidate extent context
   if (cec.getId() == mention.getId()) {
-distances.add(ei);
+// adding counts
+Integer count = distances.get(ei);

Review Comment:
   `e` -> `ei`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082237964


##
opennlp-coref/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   https://issues.apache.org/jira/browse/OPENNLP-1452



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082237692


##
opennlp-wsd/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   https://issues.apache.org/jira/browse/OPENNLP-1452



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082235783


##
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/AbstractResolver.java:
##
@@ -169,7 +170,14 @@ public DiscourseEntity retain(MentionContext mention, 
DiscourseModel dm) {
   DiscourseEntity cde = dm.getEntity(ei);
   MentionContext cec = cde.getLastExtent(); // candidate extent context
   if (cec.getId() == mention.getId()) {
-distances.add(ei);
+// adding counts
+Integer count = distances.get(ei);

Review Comment:
   Will check.



##
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/MaxentResolver.java:
##
@@ -286,7 +294,14 @@ public DiscourseEntity retain(MentionContext mention, 
DiscourseModel dm) {
   events.add(new Event(SAME, features.toArray(new 
String[features.size()])));
   de = cde;
   //System.err.println("MaxentResolver.retain: resolved at "+ei);
-  distances.add(ei);
+  // adding counts
+  Integer count = distances.get(ei);

Review Comment:
   Will check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082234738


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -68,11 +72,11 @@ public class WSDHelper {
   "RBR", "RBS", "VB", "VBD", "VBG", "VBN", "VBP", "VBZ" };
 
   // List of Negation Words
-  public static ArrayList negationWords = new ArrayList(
+  public static ArrayList negationWords = new ArrayList<>(

Review Comment:
   List? (as HashMap was also changed to Map in this class a few lines above)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082235308


##
opennlp-coref/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   Not yet, future work. See other comment in other PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082234738


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -68,11 +72,11 @@ public class WSDHelper {
   "RBR", "RBS", "VB", "VBD", "VBG", "VBN", "VBP", "VBZ" };
 
   // List of Negation Words
-  public static ArrayList negationWords = new ArrayList(
+  public static ArrayList negationWords = new ArrayList<>(

Review Comment:
   List?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082234405


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -606,7 +604,7 @@ public static boolean areStringArraysEqual(String[] array1, 
String[] array2) {
 
   public static ArrayList getAllRelevantWords(String[] sentence) {
 
-ArrayList relevantWords = new ArrayList();
+ArrayList relevantWords = new ArrayList<>();

Review Comment:
   Will check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082234165


##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -68,11 +72,11 @@ public class WSDHelper {
   "RBR", "RBS", "VB", "VBD", "VBG", "VBN", "VBP", "VBZ" };
 
   // List of Negation Words
-  public static ArrayList negationWords = new ArrayList(
+  public static ArrayList negationWords = new ArrayList<>(

Review Comment:
   Unclear to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



mawiesne commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082233356


##
opennlp-wsd/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   Good idea, I wanted to keep it in sync with opennlp core project. Will take 
note for next PRs, once the core is referencing "29". Feel free to open up an 
issue there, so make this happen soon. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #58: Updates sandbox component 'opennlp-coref' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r108656


##
opennlp-coref/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   29?



##
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/AbstractResolver.java:
##
@@ -169,7 +170,14 @@ public DiscourseEntity retain(MentionContext mention, 
DiscourseModel dm) {
   DiscourseEntity cde = dm.getEntity(ei);
   MentionContext cec = cde.getLastExtent(); // candidate extent context
   if (cec.getId() == mention.getId()) {
-distances.add(ei);
+// adding counts
+Integer count = distances.get(ei);

Review Comment:
   `distances.merge(e, 1, Integer::sum)` ?



##
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/MaxentResolver.java:
##
@@ -286,7 +294,14 @@ public DiscourseEntity retain(MentionContext mention, 
DiscourseModel dm) {
   events.add(new Event(SAME, features.toArray(new 
String[features.size()])));
   de = cde;
   //System.err.println("MaxentResolver.retain: resolved at "+ei);
-  distances.add(ei);
+  // adding counts
+  Integer count = distances.get(ei);

Review Comment:
   `distances.merge(e, 1, Integer::sum)` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #59: Updates sandbox component 'opennlp-wsd' to be compatible with latest opennlp-tools release

2023-01-20 Thread GitBox



rzo1 commented on code in PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#discussion_r1082216933


##
opennlp-wsd/pom.xml:
##
@@ -25,20 +25,20 @@

org.apache
apache
-   13
+   18

Review Comment:
   Can we go for `29` ? We can update it in `opennlp` as well (mostly build 
support, etc.)



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -480,14 +482,10 @@ public static HashMap 
getEnglishWords(String dict) {
*/
   public static POS getPOS(String posTag) {
 
-ArrayList adjective = new ArrayList(Arrays.asList("JJ",
-"JJR", "JJS"));
-ArrayList adverb = new ArrayList(Arrays.asList("RB", "RBR",
-"RBS"));
-ArrayList noun = new ArrayList(Arrays.asList("NN", "NNS",
-"NNP", "NNPS"));
-ArrayList verb = new ArrayList(Arrays.asList("VB", "VBD",
-"VBG", "VBN", "VBP", "VBZ"));
+List adjective = new ArrayList<>(Arrays.asList("JJ", "JJR", 
"JJS"));

Review Comment:
   The `new ArrayList()` calls are not needed. 



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -631,7 +629,7 @@ public static ArrayList 
getAllRelevantWords(String[] sentence) {
   public static ArrayList StemWordWithWordNet(WordPOS wordToStem) {
 if (wordToStem == null)
   return null;
-ArrayList stems = new ArrayList();
+ArrayList stems = new ArrayList<>();

Review Comment:
   List?



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -606,7 +604,7 @@ public static boolean areStringArraysEqual(String[] array1, 
String[] array2) {
 
   public static ArrayList getAllRelevantWords(String[] sentence) {
 
-ArrayList relevantWords = new ArrayList();
+ArrayList relevantWords = new ArrayList<>();

Review Comment:
   List?



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/SensevalReader.java:
##
@@ -218,9 +240,9 @@ public ArrayList getSensevalData(String wordTag) 
{
   String textAfter = nChild.getChildNodes().item(2)
   .getTextContent();
 
-  ArrayList textBeforeTokenzed = new 
ArrayList(
+  ArrayList textBeforeTokenzed = new ArrayList<>(

Review Comment:
   No need for `new` Operator, if we use `List` interface



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WSDHelper.java:
##
@@ -68,11 +72,11 @@ public class WSDHelper {
   "RBR", "RBS", "VB", "VBD", "VBG", "VBN", "VBP", "VBZ" };
 
   // List of Negation Words
-  public static ArrayList negationWords = new ArrayList(
+  public static ArrayList negationWords = new ArrayList<>(

Review Comment:
   There is a switch from `HashMap` to `Map` -> also switch from `ArrayList` to 
`List` ?



##
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/SemcorReaderExtended.java:
##
@@ -200,7 +202,7 @@ private ArrayList readFile(String file) {
*/
   private ArrayList getSemcorOneFileData(String file, String 
wordTag) {
 
-ArrayList setInstances = new ArrayList();
+ArrayList setInstances = new ArrayList<>();

Review Comment:
   List?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

75 matches

Mail list logo