Re: Post-release steps for 4.1.4
Matthias Seidel wrote: But knowing that now one thing comes to my mind: If we *would* enable permanent redirection to HTTPS for the website, we may have to exclude http://installation.openoffice.org/description otherwise it would break the update feed? No, this is not a problem. It is not a real URL. See it more as a string, like if it was "TheOpenOfficeUpdateFeedSchema". Historically a URL is used for this purpose, but it can be an invented URL like http://the.openoffice.update.feed.schema since nobody uses it as a URL. I think https://www.w3schools.com/xml/xml_namespaces.asp gives a good explanation, summarized as follows: - The namespace URI is not used by the parser to look up information. - The purpose of using an URI is to give the namespace a unique name. - However, companies often use the namespace as a pointer to a web page containing namespace information. Actually, until a few years ago the URL was not existing at all (if one clicked on it a 404 would appear). Then we decided to put something at the URL. But the reason it broke is simply that the string changed: the fact that it looks like a URL is irrelevant in this respect. OK, I will add German and French then, leaving Mac out. Tomorrow (or Monday?) all remaining languages will follow (without Mac). OK, good plan. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Issue for 4.1.4 and MacOS
On 10/28/2017 12:11 PM, Andrea Pescetti wrote: Dave Fisher wrote: We ought to factor out the build tooling by comparing a build based on 4.1.3 with the bug to rule out a tooling regression. Very good suggestion. Building 4.1.3 on exactly the same system and with exactly the same config used for 4.1.4 will tell us whether this is related to the code or to the build options or the build machine. +1 - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Post-release steps for 4.1.4
Am 28.10.2017 um 22:12 schrieb Andrea Pescetti: > Matthias Seidel wrote: >> Am 28.10.2017 um 20:07 schrieb Andrea Pescetti: >>> You didn't only look around, you committed stuff and I'll now try to >>> review it. But yes, I confirm that one is the tool we use. >> >> Only small changes for https... I couldn't resist! ;-) > > OK, no problem! But as you will see in > http://svn.apache.org/viewvc/openoffice/devtools/genUpdateFeed/ > (besides the duplicated record for "he" that invalidated the feed but, > I assume, was just due to not noticing that we had it already) there > is an important lesson to learn about HTTPS. > > When this is meant for a human using an ordinary browser, indeed we > can do the change and if somebody feels this is better and more > secure, no objections to doing so. > > When this is meant for a program, though, we must make sure that > things will still work. In this case, switching to HTTPS broke since > the XML namespace (which looks like a URL, but is not meant to be > browsed) changed and OpenOffice was no longer able to recognize it, so > my 4.1.3 was not finding the update. There is absolutely no advantage > in changing XML namespaces to HTTPS, they are not real URLs and the > only effect in changing them will be that OpenOffice won't detect the > updates any longer. I kept the HTTPS in download URL instead: with our > current model, we ask the user to open a browser anyway, so this won't > break. Sorry for my mistakes... But knowing that now one thing comes to my mind: If we *would* enable permanent redirection to HTTPS for the website, we may have to exclude http://installation.openoffice.org/description otherwise it would break the update feed? I am not really sure about that, but we should have an eye on it... > >>> Let's do this: I'll push the update feeds for Italian 4.1.3 only, >>> within a couple hours, just to check that everything still works the >>> way it should; then I'll leave you free to take over. >> OK, I would then proceed according to your list. > > Italian done. Actually I decided to keep Mac on hold, since I'd like > to know more about https://bz.apache.org/ooo/show_bug.cgi?id=127568 > before pushing the update to all users. If others feel the same, we > can keep Mac notifications pending for the time being. OK, I will add German and French then, leaving Mac out. Tomorrow (or Monday?) all remaining languages will follow (without Mac). I will hold back all other update feeds (4.0 - 4.1.2) until the situation is clear. Regards, Matthias > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
Re: Issue for 4.1.4 and MacOS
> On Oct 28, 2017, at 12:11 PM, Andrea Pescetti wrote: > > Dave Fisher wrote: >> We ought to factor out the build tooling by comparing a build based on 4.1.3 >> with the bug to rule out a tooling regression. > > Very good suggestion. Building 4.1.3 on exactly the same system and with > exactly the same config used for 4.1.4 will tell us whether this is related > to the code or to the build options or the build machine. A reminder from the 4.1.x is frozen and no updates thread. Macs builds are not done on VMs. Regards, Dave > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > signature.asc Description: Message signed with OpenPGP
Re: [4.1.5] Re: SDBC developments and the JDBC driver port
Dave Fisher wrote: BTW - Damjan’s changes are javadoc related and absolutely needed on modern Macs where getting JDK7 is not easy. We cannot be so conservative that we are afraid of upgrades. Yes we can. And not only we can, but we should (a personal opinion of course). It must be clear to everybody that trunk is the only place where development is active. There it is important to try to support modern systems as much as we can. But not on 4.1.x. 4.1.x is frozen (and possibly even stopped). If we ever have to release something from 4.1.x again, we must strive to build it on the same VMs used for 4.1.4 and the same configuration; this is our best guarantee against regressions, and the proof is in the many 4.1.4-RCx. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Post-release steps for 4.1.4
> Italian done. Actually I decided to keep Mac on hold, since I'd like to know > more about https://bz.apache.org/ooo/show_bug.cgi?id=127568 before pushing > the update to all users. If others feel the same, we can keep Mac > notifications pending for the time being. +1 to delay Mac notice. Regards, Dave > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > signature.asc Description: Message signed with OpenPGP
Re: Post-release steps for 4.1.4
Matthias Seidel wrote: Am 28.10.2017 um 20:07 schrieb Andrea Pescetti: You didn't only look around, you committed stuff and I'll now try to review it. But yes, I confirm that one is the tool we use. Only small changes for https... I couldn't resist! ;-) OK, no problem! But as you will see in http://svn.apache.org/viewvc/openoffice/devtools/genUpdateFeed/ (besides the duplicated record for "he" that invalidated the feed but, I assume, was just due to not noticing that we had it already) there is an important lesson to learn about HTTPS. When this is meant for a human using an ordinary browser, indeed we can do the change and if somebody feels this is better and more secure, no objections to doing so. When this is meant for a program, though, we must make sure that things will still work. In this case, switching to HTTPS broke since the XML namespace (which looks like a URL, but is not meant to be browsed) changed and OpenOffice was no longer able to recognize it, so my 4.1.3 was not finding the update. There is absolutely no advantage in changing XML namespaces to HTTPS, they are not real URLs and the only effect in changing them will be that OpenOffice won't detect the updates any longer. I kept the HTTPS in download URL instead: with our current model, we ask the user to open a browser anyway, so this won't break. Let's do this: I'll push the update feeds for Italian 4.1.3 only, within a couple hours, just to check that everything still works the way it should; then I'll leave you free to take over. OK, I would then proceed according to your list. Italian done. Actually I decided to keep Mac on hold, since I'd like to know more about https://bz.apache.org/ooo/show_bug.cgi?id=127568 before pushing the update to all users. If others feel the same, we can keep Mac notifications pending for the time being. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Issue for 4.1.4 and MacOS
Dave Fisher wrote: We ought to factor out the build tooling by comparing a build based on 4.1.3 with the bug to rule out a tooling regression. Very good suggestion. Building 4.1.3 on exactly the same system and with exactly the same config used for 4.1.4 will tell us whether this is related to the code or to the build options or the build machine. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Issue for 4.1.4 and MacOS
Hi - > On Oct 28, 2017, at 10:30 AM, Patricia Shanahan wrote: > > The original bug report said "This wasn't an issue of AOO 4.1.3, but is an > issue of AOO 4.1.4" so we are looking for something that changed. > > I would have assumed that the same libraries would be used in writing the > main content.xml and the one in the 'Object 1' subdirectory. The main > content.xml is fine. The one in the 'Object 1' subdirectory is empty, so I am > confused and puzzled. > > Can someone with Mac building and testing capability do the search for the > change that made it fail? In another project, I used binary search on the SVN > revision number to locate exactly when a regression appeared. I think that only Jim can build 4.1.4 on Mac. I am blocked waiting for a friend to give me a Mac JDK7. Or, I’ll apply Damjan’s javadoc JDK8 patches and see. Keep in mind that 4.1.3 was built over a year ago. AFIAK it was not built by Jim. Apple has updated Xcode and switched MacOSX to macOS since then. We ought to factor out the build tooling by comparing a build based on 4.1.3 with the bug to rule out a tooling regression. > > (For anyone who is not already familiar with the structure of the files, it > may be useful to look at an unzipped .ods file.) Regards, Dave > > On 10/28/2017 10:01 AM, Dave Fisher wrote: >> Hi - >> I’ve attached a diff of the differences between 4.1.3 and 4.1.4. I hope that >> this helps. If I had a working build I would be looking into undoing a >> change at a time to see which had the impact on the save of links on Mac. >> I am also suspicious of tooling and what caused the link xml to be created, >> but empty. Is there a system library involved and an impact due to fixes and >> updates in Xcode? If aoo413 is built on the same tooling as aoo414 is it >> broken too? >> Regards, >> Dave >>> On Oct 28, 2017, at 5:47 AM, Patricia Shanahan wrote: >>> >>> I at first thought this might be a load problem. It is now clear it is a >>> case of file corruption on save, only on Mac. >>> >>> Unfortunately, that means I am out of ideas, other than checking that your >>> original test has been done on the file save. The fixes I know about are >>> intended to affect file loading, not saving. >>> >>> On 10/26/2017 5:45 AM, Jim Jagielski wrote: Yeah, I kinda figured out what your hypothesis was... I'll need to think about this some more. > On Oct 26, 2017, at 8:34 AM, Patricia Shanahan wrote: > > OK, forget that hypothesis. You have even done the next test I would have > asked for if the line 288 breakpoint was not reached. > > I'll need to think up a new hypothesis. I'm planning to go groom a couple > of horses this morning, but I'll work on this in the afternoon. > > On 10/26/2017 5:01 AM, Jim Jagielski wrote: >> I set breakpoints on both: >>(lldb) breakpoint set --file main/sfx2/source/appl/linkmgr2.cxx >> --line 288 >>(lldb) breakpoint set -n LinkManager::GetUserAllowsLinkUpdate >> Breakpoint 4: where = >> libsfx.dylib`sfx2::LinkManager::GetUserAllowsLinkUpdate(Window*), >> address = 0x00010070a260 >> and when opening up the corrupted file, neither breakpoint >> was reached. :/ >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > signature.asc Description: Message signed with OpenPGP
Re: Post-release steps for 4.1.4
Am 28.10.2017 um 20:07 schrieb Andrea Pescetti: > Matthias Seidel wrote: >> Am 26.10.2017 um 22:58 schrieb Andrea Pescetti: >>> - Enable feeds for 4.1.3 in French, German, Italian (three random >>> "medium-size" languages) within the next 24 hours. >> I was a bit curious and looked around. ;-) >> https://svn.apache.org/repos/asf/openoffice/devtools/genUpdateFeed/ > > You didn't only look around, you committed stuff and I'll now try to > review it. But yes, I confirm that one is the tool we use. Only small changes for https... I couldn't resist! ;-) > >> I would like to give the first step a try, if you don't mind? > > Let's do this: I'll push the update feeds for Italian 4.1.3 only, > within a couple hours, just to check that everything still works the > way it should; then I'll leave you free to take over. OK, I would then proceed according to your list. Regards, Matthias > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
Re: Post-release steps for 4.1.4
Matthias Seidel wrote: Am 26.10.2017 um 22:58 schrieb Andrea Pescetti: - Enable feeds for 4.1.3 in French, German, Italian (three random "medium-size" languages) within the next 24 hours. I was a bit curious and looked around. ;-) https://svn.apache.org/repos/asf/openoffice/devtools/genUpdateFeed/ You didn't only look around, you committed stuff and I'll now try to review it. But yes, I confirm that one is the tool we use. I would like to give the first step a try, if you don't mind? Let's do this: I'll push the update feeds for Italian 4.1.3 only, within a couple hours, just to check that everything still works the way it should; then I'll leave you free to take over. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Issue for 4.1.4 and MacOS
The original bug report said "This wasn't an issue of AOO 4.1.3, but is an issue of AOO 4.1.4" so we are looking for something that changed. I would have assumed that the same libraries would be used in writing the main content.xml and the one in the 'Object 1' subdirectory. The main content.xml is fine. The one in the 'Object 1' subdirectory is empty, so I am confused and puzzled. Can someone with Mac building and testing capability do the search for the change that made it fail? In another project, I used binary search on the SVN revision number to locate exactly when a regression appeared. (For anyone who is not already familiar with the structure of the files, it may be useful to look at an unzipped .ods file.) On 10/28/2017 10:01 AM, Dave Fisher wrote: Hi - I’ve attached a diff of the differences between 4.1.3 and 4.1.4. I hope that this helps. If I had a working build I would be looking into undoing a change at a time to see which had the impact on the save of links on Mac. I am also suspicious of tooling and what caused the link xml to be created, but empty. Is there a system library involved and an impact due to fixes and updates in Xcode? If aoo413 is built on the same tooling as aoo414 is it broken too? Regards, Dave On Oct 28, 2017, at 5:47 AM, Patricia Shanahan wrote: I at first thought this might be a load problem. It is now clear it is a case of file corruption on save, only on Mac. Unfortunately, that means I am out of ideas, other than checking that your original test has been done on the file save. The fixes I know about are intended to affect file loading, not saving. On 10/26/2017 5:45 AM, Jim Jagielski wrote: Yeah, I kinda figured out what your hypothesis was... I'll need to think about this some more. On Oct 26, 2017, at 8:34 AM, Patricia Shanahan wrote: OK, forget that hypothesis. You have even done the next test I would have asked for if the line 288 breakpoint was not reached. I'll need to think up a new hypothesis. I'm planning to go groom a couple of horses this morning, but I'll work on this in the afternoon. On 10/26/2017 5:01 AM, Jim Jagielski wrote: I set breakpoints on both: (lldb) breakpoint set --file main/sfx2/source/appl/linkmgr2.cxx --line 288 (lldb) breakpoint set -n LinkManager::GetUserAllowsLinkUpdate Breakpoint 4: where = libsfx.dylib`sfx2::LinkManager::GetUserAllowsLinkUpdate(Window*), address = 0x00010070a260 and when opening up the corrupted file, neither breakpoint was reached. :/ - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [4.1.5] Re: SDBC developments and the JDBC driver port
> On Oct 28, 2017, at 9:10 AM, Andrea Pescetti wrote: > > Patricia Shanahan wrote: >> Unless the changes are also in 4.1.4 or are super-urgent, I do not think >> they belong in 4.1.5. 4.1.5, which we hope will never be released, is >> for fixes to 4.1.4 that are too urgent to wait for 4.2. > > Confirmed. 4.2 should get all the focus. Nothing gets in AOO415 (which is a > branch, not a planned release at the moment) besides what we want to fix. All > the rest in AOO415 remains unchanged with respect to AOO414: any improvements > can have side effects, as we have seen in the numerous RCs for 4.1.4. What are we planning regarding a fix for the MacOSX regression? (Or will we wait for the solution and then discuss?) My thought is that we may want to be ready to release a 4.1.5 for Mac only. BTW - Damjan’s changes are javadoc related and absolutely needed on modern Macs where getting JDK7 is not easy. We cannot be so conservative that we are afraid of upgrades. Regards, Dave > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > signature.asc Description: Message signed with OpenPGP
Re: Issue for 4.1.4 and MacOS
Hi - I’ve attached a diff of the differences between 4.1.3 and 4.1.4. I hope that this helps. If I had a working build I would be looking into undoing a change at a time to see which had the impact on the save of links on Mac. I am also suspicious of tooling and what caused the link xml to be created, but empty. Is there a system library involved and an impact due to fixes and updates in Xcode? If aoo413 is built on the same tooling as aoo414 is it broken too? Regards, Dave > On Oct 28, 2017, at 5:47 AM, Patricia Shanahan wrote: > > I at first thought this might be a load problem. It is now clear it is a case > of file corruption on save, only on Mac. > > Unfortunately, that means I am out of ideas, other than checking that your > original test has been done on the file save. The fixes I know about are > intended to affect file loading, not saving. > > On 10/26/2017 5:45 AM, Jim Jagielski wrote: >> Yeah, I kinda figured out what your hypothesis was... I'll need >> to think about this some more. >>> On Oct 26, 2017, at 8:34 AM, Patricia Shanahan wrote: >>> >>> OK, forget that hypothesis. You have even done the next test I would have >>> asked for if the line 288 breakpoint was not reached. >>> >>> I'll need to think up a new hypothesis. I'm planning to go groom a couple >>> of horses this morning, but I'll work on this in the afternoon. >>> >>> On 10/26/2017 5:01 AM, Jim Jagielski wrote: I set breakpoints on both: (lldb) breakpoint set --file main/sfx2/source/appl/linkmgr2.cxx --line 288 (lldb) breakpoint set -n LinkManager::GetUserAllowsLinkUpdate Breakpoint 4: where = libsfx.dylib`sfx2::LinkManager::GetUserAllowsLinkUpdate(Window*), address = 0x00010070a260 and when opening up the corrupted file, neither breakpoint was reached. :/ - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > signature.asc Description: Message signed with OpenPGP
Re: [4.1.5] Re: SDBC developments and the JDBC driver port
Patricia Shanahan wrote: Unless the changes are also in 4.1.4 or are super-urgent, I do not think they belong in 4.1.5. 4.1.5, which we hope will never be released, is for fixes to 4.1.4 that are too urgent to wait for 4.2. Confirmed. 4.2 should get all the focus. Nothing gets in AOO415 (which is a branch, not a planned release at the moment) besides what we want to fix. All the rest in AOO415 remains unchanged with respect to AOO414: any improvements can have side effects, as we have seen in the numerous RCs for 4.1.4. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PROPOSAL] Managing branches for future releases
Peter Kovacs wrote: Am Samstag, den 28.10.2017, 00:40 +0200 schrieb Andrea Pescetti: this thread was actually to address the problem with actually changing release numbers in code, nothing else. It does not adress the problem with release models. It works only around them. Is there a bug report for the Problem? https://bz.apache.org/ooo/show_bug.cgi?id=127552 but the right way would be to simply script it, so using the occasion for performing that specific set of changes, but also for improving our tools so that we can execute a script to achieve the same effect. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Post-release steps for 4.1.4
Am 26.10.2017 um 22:58 schrieb Andrea Pescetti: > A short summary of the post-release steps for 4.1.4 I'm going to take > care of, since we are now at the "7 days after release" mark: > > 1) Security reports for 4.1.4 are now published at > https://www.openoffice.org/security/bulletin.html > Nothing special, the usual handful of fixes we do at every release; > but I'll now send a notice to the announce@ list with this link. > > 2) Update feeds haven't been updated yet. They are organized by > language and version (i.e., there is a feed that will be shown to > current users of version 4.1.3 in Italian, one for version 4.1.2 in > French, one for 4.1.2 in German, one for 4.1.1 in German...), so a lot > of combinations. > > I plan to: > - Enable feeds for 4.1.3 in French, German, Italian (three random > "medium-size" languages) within the next 24 hours. > - 24/48 hours later, enable feeds for 4.1.3 in all other languages > including English > - As time allows, enable feeds for users of versions < 4.1.3 I was a bit curious and looked around. ;-) It seems quite easy to generate the update feeds using these scripts: https://svn.apache.org/repos/asf/openoffice/devtools/genUpdateFeed/ I would like to give the first step a try, if you don't mind? Regards, Matthias > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > > smime.p7s Description: S/MIME Cryptographic Signature
Re: Issue for 4.1.4 and MacOS
I at first thought this might be a load problem. It is now clear it is a case of file corruption on save, only on Mac. Unfortunately, that means I am out of ideas, other than checking that your original test has been done on the file save. The fixes I know about are intended to affect file loading, not saving. On 10/26/2017 5:45 AM, Jim Jagielski wrote: Yeah, I kinda figured out what your hypothesis was... I'll need to think about this some more. On Oct 26, 2017, at 8:34 AM, Patricia Shanahan wrote: OK, forget that hypothesis. You have even done the next test I would have asked for if the line 288 breakpoint was not reached. I'll need to think up a new hypothesis. I'm planning to go groom a couple of horses this morning, but I'll work on this in the afternoon. On 10/26/2017 5:01 AM, Jim Jagielski wrote: I set breakpoints on both: (lldb) breakpoint set --file main/sfx2/source/appl/linkmgr2.cxx --line 288 (lldb) breakpoint set -n LinkManager::GetUserAllowsLinkUpdate Breakpoint 4: where = libsfx.dylib`sfx2::LinkManager::GetUserAllowsLinkUpdate(Window*), address = 0x00010070a260 and when opening up the corrupted file, neither breakpoint was reached. :/ - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [4.1.5] Re: SDBC developments and the JDBC driver port
Unless the changes are also in 4.1.4 or are super-urgent, I do not think they belong in 4.1.5. 4.1.5, which we hope will never be released, is for fixes to 4.1.4 that are too urgent to wait for 4.2. On 10/27/2017 7:17 PM, Dave Fisher wrote: Hi Damjan, A friend is sending me a JDK7. But I agree. I think that these changes should be backported to 4.1.5. The redland and raptor updates should be backported too. RMs Jim / Matthias - what do you think? Regards, Dave Sent from my iPhone On Oct 27, 2017, at 7:07 PM, Damjan Jovanovic wrote: Apply these commits to 4.1.x and you'll be able to build AOO with Java 8: 1697228 1697237 1697247 1697306 1697312 I don't know why they haven't been backported yet. Damjan On Fri, Oct 27, 2017 at 10:31 PM, Dave Fisher wrote: Hi Matthias, It is no longer easy to get EOLed JDKs. You have to pay Oracle for support. You have to pay Apple to get the old SDKs you need for Mac OpenOffice. I don’t mind paying Apple as I have the goal of trying to sign the Application to avoid Gatekeeper. I have the Xcode stuff and I’ve found JDK 6s. If a friend has the the JDK7 in /Libary/Java/JavaVirtualMachines/ and would ship it to me that would be AWESOME. In my builds with JDK6 I am now having trouble with Help. There is a lot wrong with the Building guides. Too many options - MacPort or Brew, etc. I’ve spent about 16 hours this week on this and … I am about done with it. Regards, Dave On Oct 27, 2017, at 1:22 PM, Matthias Seidel wrote: Am 27.10.2017 um 21:19 schrieb Dave Fisher: Hi - As an aside I am working on Mac builds for 4.1.4 and it looks like uno does not like JDK 8+, something to do with javadocs, but not sure as I am looking for JDK7 … Do you need the SDK? From our release notes (Known Issues): For developers: - The OpenOffice SDK won't build with Java 8. Either build with --disable-odk or see the dev list archives for possible solutions. Either go with Java 7 or use --disable-odk as configure switch. Regards, Matthias If I can get things working I will be willing to try builds for you on trunk or a branch as you make changes. Regards, Dave On Oct 27, 2017, at 12:05 PM, Peter Kovacs wrote: Am Freitag, den 27.10.2017, 11:18 +0200 schrieb Damjan Jovanovic: Hi *wave* To update you on my development efforts, the PostgreSQL driver continues to advance. I recently added views and fixed a major problem where "Refresh Tables" causes everything done to tables from then on to fail (as Base keeps holding references to the old table/view/user/group containers, so container contents may change, but containers themselves must persist for the lifetime of the driver). I did however run into a disturbing bug. When my SDBC driver in Java calls XStatement.close() on our underlying SDBC to JDBC converter driver written in C++, and it calls java.sql.Statement.close() in the PostgreSQL JDBC driver, I get a reproducible unchecked java.lang.IllegalClassChangeError exception. After hours of debugging I did manage to work around it, by getting a new methodID before every JNI call to close() instead of caching it in a static global variable, which shouldn't be required as methodIDs are meant to persist for the lifetime of the JVM. Either it's a bug in the JVM itself, or an obscure bug in our SDBC-JDBC driver, such as memory corruption or the like :(. Instead of committing that senseless methodID hack, I've decided to port the SDBC-JDBC driver to Java, which should make memory corruption impossible and any debugging and future maintenance much easier (the JNI code to call into Java is exceptionally complex and ugly, and compiles into a 15 MB pig of a library in a debug build!). Nothing is lost by using Java, as the C++ driver can't load JDBC drivers without Java either, and performance should be identical as the slow boundary between native and Java is crossed an equal number of times, the crossing just happens in the JNI bridge under main/bridges instead of the SDBC-JDBC driver. WTF?! So far the reusable parts of the PostgreSQL driver have been split off into a dbtools.jar that will be used in a new sdbc-jdbc.jar, which is itself currently in the painful phase of dealing with JDBC classloading and class caching. The final architecture should be something along these lines: The rest of AOO (mostly C++) | | |UNO | UNO | v | PostgreSQL SDBC driver (Java) | | | | | UNO | UNO v v v SDBC-JDBC driver (Java) SDBC-ODBC driver (C++) | | | | Java | Java | C v v v other PostgreSQL JDBC PostgreSQL ODBC JDBC driver (Java)driver (C) drivers | | | network I/O | v v PostgreSQL server +1 Looks like a clean architecture, LIKE ! S2 I've also already developed considerable support code for Java (logging, resource bundles, data structure manipulation), a
Re: Post-release steps for 4.1.4
Am 26.10.2017 um 22:58 schrieb Andrea Pescetti: > A short summary of the post-release steps for 4.1.4 I'm going to take > care of, since we are now at the "7 days after release" mark: > > 1) Security reports for 4.1.4 are now published at > https://www.openoffice.org/security/bulletin.html > Nothing special, the usual handful of fixes we do at every release; > but I'll now send a notice to the announce@ list with this link. > > 2) Update feeds haven't been updated yet. They are organized by > language and version (i.e., there is a feed that will be shown to > current users of version 4.1.3 in Italian, one for version 4.1.2 in > French, one for 4.1.2 in German, one for 4.1.1 in German...), so a lot > of combinations. > > I plan to: > - Enable feeds for 4.1.3 in French, German, Italian (three random > "medium-size" languages) within the next 24 hours. > - 24/48 hours later, enable feeds for 4.1.3 in all other languages > including English > - As time allows, enable feeds for users of versions < 4.1.3 Hi Andrea, That sounds great and is right on time for the OpenRheinRuhr (https://openrheinruhr.de/aussteller/liste/) next weekend. Michael and his family will hopefully have a lot of visitors (including me on Sunday) ;-) Additional tasks: I think the tag for 4.1.4 is missing. https://svn.apache.org/repos/asf/openoffice/tags/ Is this somehow related to the Github tag (which was created premature)? https://github.com/apache/openoffice/releases Regards, Matthias > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > > smime.p7s Description: S/MIME Cryptographic Signature
Re: [4.1.5] Re: SDBC developments and the JDBC driver port
Am 28.10.2017 um 04:17 schrieb Dave Fisher: > Hi Damjan, > > A friend is sending me a JDK7. > > But I agree. > > I think that these changes should be backported to 4.1.5. The redland and > raptor updates should be backported too. > > RMs Jim / Matthias - what do you think? Don't ask me, I only provided the Windows builds... ;-) I am now concentrating on 4.2.0 (trunk). Regards, Matthias > > Regards, > Dave > > Sent from my iPhone > >> On Oct 27, 2017, at 7:07 PM, Damjan Jovanovic wrote: >> >> Apply these commits to 4.1.x and you'll be able to build AOO with Java 8: >> 1697228 >> 1697237 >> 1697247 >> 1697306 >> 1697312 >> >> I don't know why they haven't been backported yet. >> >> Damjan >> >>> On Fri, Oct 27, 2017 at 10:31 PM, Dave Fisher wrote: >>> >>> Hi Matthias, >>> >>> It is no longer easy to get EOLed JDKs. You have to pay Oracle for >>> support. You have to pay Apple to get the old SDKs you need for Mac >>> OpenOffice. I don’t mind paying Apple as I have the goal of trying to sign >>> the Application to avoid Gatekeeper. I have the Xcode stuff and I’ve found >>> JDK 6s. If a friend has the the JDK7 in /Libary/Java/JavaVirtualMachines/ >>> and would ship it to me that would be AWESOME. >>> >>> In my builds with JDK6 I am now having trouble with Help. >>> >>> There is a lot wrong with the Building guides. Too many options - MacPort >>> or Brew, etc. >>> >>> I’ve spent about 16 hours this week on this and … I am about done with it. >>> >>> Regards, >>> Dave >>> >>> On Oct 27, 2017, at 1:22 PM, Matthias Seidel >>> wrote: >>> >>> Am 27.10.2017 um 21:19 schrieb Dave Fisher: >>> >>> Hi - >>> >>> As an aside I am working on Mac builds for 4.1.4 and it looks like uno does >>> not like JDK 8+, something to do with javadocs, but not sure as I am >>> looking for JDK7 … >>> >>> >>> Do you need the SDK? >>> >>> From our release notes (Known Issues): >>> >>> For developers: >>> >>> - The OpenOffice SDK won't build with Java 8. Either build with >>> --disable-odk or see the dev list archives for possible solutions. >>> >>> Either go with Java 7 or use --disable-odk as configure switch. >>> >>> Regards, Matthias >>> >>> If I can get things working I will be willing to try builds for you on >>> trunk or a branch as you make changes. >>> >>> Regards, >>> Dave >>> >>> >>> On Oct 27, 2017, at 12:05 PM, Peter Kovacs >>> wrote: >>> >>> Am Freitag, den 27.10.2017, 11:18 +0200 schrieb Damjan Jovanovic: >>> >>> Hi >>> >>> *wave* >>> >>> To update you on my development efforts, the PostgreSQL driver >>> continues to >>> advance. I recently added views and fixed a major problem where >>> "Refresh >>> Tables" causes everything done to tables from then on to fail (as >>> Base >>> keeps holding references to the old table/view/user/group containers, >>> so >>> container contents may change, but containers themselves must persist >>> for >>> the lifetime of the driver). >>> >>> I did however run into a disturbing bug. When my SDBC driver in Java >>> calls >>> XStatement.close() on our underlying SDBC to JDBC converter driver >>> written >>> in C++, and it calls java.sql.Statement.close() in the PostgreSQL >>> JDBC >>> driver, I get a reproducible unchecked >>> java.lang.IllegalClassChangeError >>> exception. After hours of debugging I did manage to work around it, >>> by >>> getting a new methodID before every JNI call to close() instead of >>> caching >>> it in a static global variable, which shouldn't be required as >>> methodIDs >>> are meant to persist for the lifetime of the JVM. Either it's a bug >>> in the >>> JVM itself, or an obscure bug in our SDBC-JDBC driver, such as memory >>> corruption or the like :(. >>> >>> Instead of committing that senseless methodID hack, I've decided to >>> port >>> the SDBC-JDBC driver to Java, which should make memory corruption >>> impossible and any debugging and future maintenance much easier (the >>> JNI >>> code to call into Java is exceptionally complex and ugly, and >>> compiles into >>> a 15 MB pig of a library in a debug build!). Nothing is lost by using >>> Java, >>> as the C++ driver can't load JDBC drivers without Java either, and >>> performance should be identical as the slow boundary between native >>> and >>> Java is crossed an equal number of times, the crossing just happens >>> in the >>> JNI bridge under main/bridges instead of the SDBC-JDBC driver. >>> >>> WTF?! >>> >>> So far the reusable parts of the PostgreSQL driver have been split >>> off into >>> a dbtools.jar that will be used in a new sdbc-jdbc.jar, which is >>> itself >>> currently in the painful phase of dealing with JDBC classloading and >>> class >>> caching. The final architecture should be something along these >>> lines: >>> >>> The rest of AOO (mostly C++) >>> | | >>> |UNO | UNO >>> | v >>> | PostgreSQL SDBC driver (Java) >>> | | | >>> | | UNO | UNO >>> v v v >>> SDBC-JDBC driver (Java) SDBC-ODBC driv
