Re: Unused patches

2013-12-22 Thread Rob Weir
On Sun, Dec 22, 2013 at 2:07 PM, Rainer Bielefeld
rainerbielefeld_ooo...@bielefeldundbuss.de wrote:
 Hi all,

 we have lots of bug reports with unused patches. I think patches should be
 checked as soon as possible and be integrated as soon as possible.

 Example:
 I found 31 Bugs with unused patches by Kohei Yoshida - I think we can't get
 progress in Calc any cheaper.

 And also the other Bugs with unused patches should be checked ...


We would probably want to confirm with the original author for any
pre-Apache patches, to make sure that the patch is given under ALv2.
The exception might be those who were Sun/Oracle/IBM employees at the
time.


 BTW, I haven't a clue how to use custom search Attachment is a Patch. Can
 someone tell me?


Attachment is a Patch is equal to 1

-Rob

 Best regards


 Rainer

 Hyperlinks
 [1]
 https://issues.apache.org/ooo/buglist.cgi?bug_status=UNCONFIRMEDbug_status=CONFIRMEDbug_status=ACCEPTEDbug_status=REOPENEDf1=attachments.submitterf2=attachments.ispatchlist_id=112364o1=equalsquery_format=advancedv1=kyoshida%40novell.com

 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: Unused patches

2013-12-22 Thread jan i
On 22 December 2013 21:13, Rob Weir robw...@apache.org wrote:

 On Sun, Dec 22, 2013 at 2:07 PM, Rainer Bielefeld
 rainerbielefeld_ooo...@bielefeldundbuss.de wrote:
  Hi all,
 
  we have lots of bug reports with unused patches. I think patches should
 be
  checked as soon as possible and be integrated as soon as possible.
 
  Example:
  I found 31 Bugs with unused patches by Kohei Yoshida - I think we can't
 get
  progress in Calc any cheaper.
 
  And also the other Bugs with unused patches should be checked ...
 

 We would probably want to confirm with the original author for any
 pre-Apache patches, to make sure that the patch is given under ALv2.
 The exception might be those who were Sun/Oracle/IBM employees at the
 time.

 How about we do it the other way round, we sent a mail the the authors
stating we assume the accept alv2 unless we hear from them within x days  ?

rgds
jan I.


 
  BTW, I haven't a clue how to use custom search Attachment is a Patch.
 Can
  someone tell me?
 

 Attachment is a Patch is equal to 1

 -Rob

  Best regards
 
 
  Rainer
 
  Hyperlinks
  [1]
  
 https://issues.apache.org/ooo/buglist.cgi?bug_status=UNCONFIRMEDbug_status=CONFIRMEDbug_status=ACCEPTEDbug_status=REOPENEDf1=attachments.submitterf2=attachments.ispatchlist_id=112364o1=equalsquery_format=advancedv1=kyoshida%40novell.com
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
  For additional commands, e-mail: dev-h...@openoffice.apache.org
 

 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org




Re: Unused patches

2013-12-22 Thread David Gerard
On 22 December 2013 21:12, jan i j...@apache.org wrote:
 On 22 December 2013 21:13, Rob Weir robw...@apache.org wrote:

 We would probably want to confirm with the original author for any
 pre-Apache patches, to make sure that the patch is given under ALv2.
 The exception might be those who were Sun/Oracle/IBM employees at the
 time.

 How about we do it the other way round, we sent a mail the the authors
 stating we assume the accept alv2 unless we hear from them within x days  ?


Because as well as being profoundly rude, that would be a copyright
violation unless you are absolutely sure that (a) every contributor
signed a Sun or Oracle CLA (b) that the patch was accepted under said
CLA (does putting a patch in Bugzilla count as a contribution if it
wasn't accepted?) (c) that copyright on all said patches was covered
by the Oracle grant (as, e.g., the CWSes may not be).


- d.

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: Unused patches

2013-12-22 Thread Andrea Pescetti

Rob Weir wrote:

We would probably want to confirm with the original author for any
pre-Apache patches, to make sure that the patch is given under ALv2.
The exception might be those who were Sun/Oracle/IBM employees at the
time.


Could we try to have a clearer picture here, limited to patches that are 
attached to Bugzilla issues?


Patches by then-Sun/Oracle employees belong to Sun/Oracle, but they 
haven't necessarily been explicitly granted to Apache. Or do we have 
permission to use all patches by Sun and Oracle employees in Bugzilla? I 
remember this was discussed but I can't find a conclusive answer.


Patches by then-IBM employees, as far as I know, have not been granted 
to Apache by IBM.


And there's the group of people who signed a copyright agreement with 
Sun: these are not Sun employees but I don't see reasons to consider 
their patches different than those by Sun/Oracle employees:

http://www.openoffice.org/copyright/copyrightapproved.html

If we manage to get some safe guidelines on what patches we can reuse 
this would simplify integration a lot.


Regards,
  Andrea.

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: Unused patches

2013-12-22 Thread Rob Weir
On Sun, Dec 22, 2013 at 4:25 PM, Andrea Pescetti pesce...@apache.org wrote:
 Rob Weir wrote:

 We would probably want to confirm with the original author for any
 pre-Apache patches, to make sure that the patch is given under ALv2.
 The exception might be those who were Sun/Oracle/IBM employees at the
 time.


 Could we try to have a clearer picture here, limited to patches that are
 attached to Bugzilla issues?

 Patches by then-Sun/Oracle employees belong to Sun/Oracle, but they haven't
 necessarily been explicitly granted to Apache. Or do we have permission to
 use all patches by Sun and Oracle employees in Bugzilla? I remember this was
 discussed but I can't find a conclusive answer.

 Patches by then-IBM employees, as far as I know, have not been granted to
 Apache by IBM.


For both of the above scenarios I was speaking from the perspective of
an IBMer.  That allows me to make an additional set of assumptions
that might not be true of other developers.  But it is best to discuss
in the context of a specific patch.

Regards,

-Rob

 And there's the group of people who signed a copyright agreement with Sun:
 these are not Sun employees but I don't see reasons to consider their
 patches different than those by Sun/Oracle employees:
 http://www.openoffice.org/copyright/copyrightapproved.html

 If we manage to get some safe guidelines on what patches we can reuse this
 would simplify integration a lot.

 Regards,
   Andrea.


 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org