Re: [IMPORTANT] About Big Commits
On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt Thanks Gurkan -- I ran standalone and got these results (twice) : Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed: 42.527 sec FAILURE! Results : Failed tests: testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest) testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest) Is the current expectation that both web and standalone run 100% clean, with perhaps some timing issues that cause transient failures? I was surprised to see EJB definition tests in the standalone suite -- do you test against a tomcat+openejb that has the integration applied? I don't think we could figure out local interfaces only without that (looking at testcase name only of one of the above) -- Eric Covener cove...@gmail.com
Re: [jira] Created: (OWB-424) Adding Document for How to Configure and Run TCK (standalone and web profile TCKs)
Hi! +1 on improving our docu ;) I usually run the TCK after big changes, but since dropping the EL listener was almost a no-brainer (just used lazy init instead of it), I have to admit that I didn't run it. Otoh such things like the change with caching the bean-proxy are definitely not tested in the TCK anyway ;) Liegrue, strub - Original Message From: Gurkan Erdogdu (JIRA) j...@apache.org To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 8:36:49 PM Subject: [jira] Created: (OWB-424) Adding Document for How to Configure and Run TCK (standalone and web profile TCKs) Adding Document for How to Configure and Run TCK (standalone and web profile TCKs) -- - Key: OWB-424 URL: https://issues.apache.org/jira/browse/OWB-424 Project: OpenWebBeans Issue Type: TCK Challenge Components: TCK Affects Versions: 1.0.0-alpha-1 Reporter: Gurkan Erdogdu Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r979071 - in /openwebbeans/trunk: webbeans-ejb/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/interceptor/ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/
Paul, can you submit a followup patch to address a few issues inline below?
+ �...@aroundtimeout
+ public Object callAroundTimeouts(InvocationContext context) throws
Exception
+ {
+ Object retVal = null;
+ InjectionTargetBean? injectionTarget = (InjectionTargetBean?)
threadLocal.get();
+
+ logger.debug(OpenWebBeansEjbInterceptor: @AroundTimeout called.
Trying to run Interceptors.);
+
+ if(injectionTarget != null)
+ {
+ if
(WebBeansUtil.isContainsInterceptorMethod(injectionTarget.getInterceptorStack(),
InterceptorType.AROUND_TIMEOUT))
+ {
+ InvocationContextImpl impl = new InvocationContextImpl(null,
context.getTarget(), null, null,
+
InterceptorUtil.getInterceptorMethods(injectionTarget.getInterceptorStack(),
InterceptorType.AROUND_TIMEOUT), InterceptorType.AROUND_TIMEOUT);
+
impl.setCreationalContext(threadLocalCreationalContext.get());
+ try
+ {
+ //run OWB interceptors
+ impl.proceed();
I think something needs to be done with the return value of the 299
stack. This does not apply to the passivation related chunks.
+
+ //run EJB interceptors
+ retVal = context.proceed();
Please take a look at the recent restructuring of the lifecycle
interceptos == ejbcontect.proceed needs to occur outside of the
if(...intereceptor stack not empty). This does apply to the
passivation related chunks as well.
I think it is safe to a) remove the TODOS around
runPrePostForNonContextual and also to rename that routine. If it's
used for AroundTimeout, even lifecycle is probably bad. Maybe
runInterceptorsForNonContextualEJB or something.
--
Eric Covener
cove...@gmail.com
Re: CIA bot on #openwebbeans?
+1 On Sun, Jul 25, 2010 at 1:28 PM, Eric Covener cove...@gmail.com wrote: How do people feel / who do we ask to turn on a CIA bot for commit messages in #openwebbeans? I am personally +1 -- Eric Covener cove...@gmail.com
[jira] Created: (OWB-425) improve performance of owb-el-resolver
improve performance of owb-el-resolver -- Key: OWB-425 URL: https://issues.apache.org/jira/browse/OWB-425 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-425) improve performance of owb-el-resolver
[ https://issues.apache.org/jira/browse/OWB-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated OWB-425: - Attachment: OWB-425.patch this patch improves the performance of the owb-el-resolver up to 40% improve performance of owb-el-resolver -- Key: OWB-425 URL: https://issues.apache.org/jira/browse/OWB-425 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu Attachments: OWB-425.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-425) improve performance of owb-el-resolver
[ https://issues.apache.org/jira/browse/OWB-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892180#action_12892180 ] Gerhard Petracek commented on OWB-425: -- here i see up to 60 % for @RequestScoped and @SessionScoped improve performance of owb-el-resolver -- Key: OWB-425 URL: https://issues.apache.org/jira/browse/OWB-425 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu Attachments: OWB-425.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
