Re: [IMPORTANT] About Big Commits
I have committed changes. Now, all 574 tests have passed. From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Mon, July 26, 2010 11:16:44 AM Subject: Re: [IMPORTANT] About Big Commits Hi Eric; Needs some tweaking on EJB plugin to allow standalone test's EJB classes are correctly deployed. Iwill tinker it. Regards; --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Sun, July 25, 2010 7:39:13 PM Subject: Re: [IMPORTANT] About Big Commits On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt Thanks Gurkan -- I ran standalone and got these results (twice) : Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed: 42.527 sec FAILURE! Results : Failed tests: testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest) testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest) Is the current expectation that both web and standalone run 100% clean, with perhaps some timing issues that cause transient failures? I was surprised to see EJB definition tests in the standalone suite -- do you test against a tomcat+openejb that has the integration applied? I don't think we could figure out local interfaces only without that (looking at testcase name only of one of the above) -- Eric Covener cove...@gmail.com
Re: [IMPORTANT] About Big Commits
On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt Thanks Gurkan -- I ran standalone and got these results (twice) : Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed: 42.527 sec FAILURE! Results : Failed tests: testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest) testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest) Is the current expectation that both web and standalone run 100% clean, with perhaps some timing issues that cause transient failures? I was surprised to see EJB definition tests in the standalone suite -- do you test against a tomcat+openejb that has the integration applied? I don't think we could figure out local interfaces only without that (looking at testcase name only of one of the above) -- Eric Covener cove...@gmail.com
[IMPORTANT] About Big Commits
Hello folks; Please do not commit big changes to codebase before running TCKs and passing them. Current EL related commits breaks TCK from even running. I consumed really big effort to pass all those TCKs. Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. Please not remove any class before finding a bug around it or clearly explains what it is removed. --Gurkan
Re: [IMPORTANT] About Big Commits
Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. My mistake, checking out webbeans-porting. Will try to run TCKs. Thanks; --Gurkan From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 8:57:04 PM Subject: [IMPORTANT] About Big Commits Hello folks; Please do not commit big changes to codebase before running TCKs and passing them. Current EL related commits breaks TCK from even running. I consumed really big effort to pass all those TCKs. Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. Please not remove any class before finding a bug around it or clearly explains what it is removed. --Gurkan
Re: [IMPORTANT] About Big Commits
Notes on this somewhere? Is it just testng from eclipse on the -tck files? I've only run the TCK in limited form, and it was quite a while ago. I have sent email about TCK running. TCK means standalone and web profile. Those are in webbeans-tck project. You can also run from mvn test at the root of webbeans-tck. --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 9:17:05 PM Subject: Re: [IMPORTANT] About Big Commits On Sat, Jul 24, 2010 at 1:57 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Notes on this somewhere? Is it just testng from eclipse on the -tck files? I've only run the TCK in limited form, and it was quite a while ago. -- Eric Covener cove...@gmail.com
Re: [IMPORTANT] About Big Commits
This is mainly about web and core related logics. --Gurkan From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 8:57:04 PM Subject: [IMPORTANT] About Big Commits Hello folks; Please do not commit big changes to codebase before running TCKs and passing them. Current EL related commits breaks TCK from even running. I consumed really big effort to pass all those TCKs. Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. Please not remove any class before finding a bug around it or clearly explains what it is removed. --Gurkan
Re: [IMPORTANT] About Big Commits
Notes on this somewhere? I will add a README TCK for how to configure and run TCK. --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 9:17:05 PM Subject: Re: [IMPORTANT] About Big Commits On Sat, Jul 24, 2010 at 1:57 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Notes on this somewhere? Is it just testng from eclipse on the -tck files? I've only run the TCK in limited form, and it was quite a while ago. -- Eric Covener cove...@gmail.com
Re: [IMPORTANT] About Big Commits
http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 9:34:13 PM Subject: Re: [IMPORTANT] About Big Commits Notes on this somewhere? I will add a README TCK for how to configure and run TCK. --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 9:17:05 PM Subject: Re: [IMPORTANT] About Big Commits On Sat, Jul 24, 2010 at 1:57 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Notes on this somewhere? Is it just testng from eclipse on the -tck files? I've only run the TCK in limited form, and it was quite a while ago. -- Eric Covener cove...@gmail.com
Re: [IMPORTANT] About Big Commits
Will try to run TCKs. Altough TCKs have been passed succesfully :) , my observations are still valid. Thanks; --Gurkan From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 9:07:11 PM Subject: Re: [IMPORTANT] About Big Commits Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. My mistake, checking out webbeans-porting. Will try to run TCKs. Thanks; --Gurkan From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Sat, July 24, 2010 8:57:04 PM Subject: [IMPORTANT] About Big Commits Hello folks; Please do not commit big changes to codebase before running TCKs and passing them. Current EL related commits breaks TCK from even running. I consumed really big effort to pass all those TCKs. Until now, OWB code base is very stable, and passing Standalone and Web Profile TCKs. If you change lots of places ensure that TCKs are able to run and passed. Currently, not running TCKs, because of java.lang.NoClassDefFoundError: org/apache/webbeans/el/OwbElContextListener. Please not remove any class before finding a bug around it or clearly explains what it is removed. --Gurkan
