[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994151#comment-12994151 ] Gerhard Petracek commented on OWB-472: -- i agree with mark! archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling
https://issues.jboss.org/browse/CDI-18 My personal fear is that this will quickly lead to lots of follow up failures like one can currently see in glassfish and JBossAS. For getting this done if e.g. an EE server needs to implement the CDI-1.0 spec then this can still be provided via a custom ScannerService Impl, isn't? LieGrue, strub --- On Sun, 2/13/11, Eric Covener cove...@gmail.com wrote: From: Eric Covener cove...@gmail.com Subject: Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling To: dev@openwebbeans.apache.org Date: Sunday, February 13, 2011, 8:52 PM Isn't the current code pretty non-intrusive and no behavior change by default? Is there something like a draft to cite that shows what overhaul in this area is due in 1.1? -- Forwarded message -- From: Mark Struberg (JIRA) j...@apache.org Date: Sun, Feb 13, 2011 at 3:40 PM Subject: [jira] Commented: (OWB-472) archive centric beans.xml enabling To: dev@openwebbeans.apache.org [ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994150#comment-12994150 ] Mark Struberg commented on OWB-472: --- I fear we need to rollback the commits. The problem with this is that the whole BDA definition is UTTERLY broken in the spec. This resulted in a spec change which is due to 1.1. See CDI-18 for more information. By implementing the same sh**t than Weld currently has (they are forced to, but hey, we are not the RI ;) we just corrupt any normal modus operandi. Comments are welcome. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Eric Covener cove...@gmail.com
Re: Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling
+1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/13 Mark Struberg strub...@yahoo.de https://issues.jboss.org/browse/CDI-18 My personal fear is that this will quickly lead to lots of follow up failures like one can currently see in glassfish and JBossAS. For getting this done if e.g. an EE server needs to implement the CDI-1.0 spec then this can still be provided via a custom ScannerService Impl, isn't? LieGrue, strub --- On Sun, 2/13/11, Eric Covener cove...@gmail.com wrote: From: Eric Covener cove...@gmail.com Subject: Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling To: dev@openwebbeans.apache.org Date: Sunday, February 13, 2011, 8:52 PM Isn't the current code pretty non-intrusive and no behavior change by default? Is there something like a draft to cite that shows what overhaul in this area is due in 1.1? -- Forwarded message -- From: Mark Struberg (JIRA) j...@apache.org Date: Sun, Feb 13, 2011 at 3:40 PM Subject: [jira] Commented: (OWB-472) archive centric beans.xml enabling To: dev@openwebbeans.apache.org [ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994150#comment-12994150 ] Mark Struberg commented on OWB-472: --- I fear we need to rollback the commits. The problem with this is that the whole BDA definition is UTTERLY broken in the spec. This resulted in a spec change which is due to 1.1. See CDI-18 for more information. By implementing the same sh**t than Weld currently has (they are forced to, but hey, we are not the RI ;) we just corrupt any normal modus operandi. Comments are welcome. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June ( http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser ) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Eric Covener cove...@gmail.com
Re: [jira] Commented: (OWB-472) archive centric beans.xml enabling
On Sun, Feb 13, 2011 at 4:12 PM, Gerhard gerhard.petra...@gmail.com wrote: yes - it's non-intrusive because i fixed it. Non-intrusive in terms of technical rationale to call for a revert, not non-intrusive in terms of you had to refactor to use trunk in an appserver. however, we have a spi (ScannerService) for such additional features. We have many SPIs and Plugins, and in trunk we have a set that can satisfy the requirements of CDI 1.0.
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994169#comment-12994169 ] Gurkan Erdogdu commented on OWB-472: AFAIK, BDA has been enabled as plugin or SPI. Therefore, current implementation may not affect any other parts, because it has not been enabled. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994179#comment-12994179 ] Jacquelle Leggett commented on OWB-472: --- I understand Mark's viewpoint, but I do not understand why there is a need to rollback changes. As I mentioned in a previous post, it is useful to have the ability to limit the scope of modifiers (interceptors, decorators, alternatives). This function is disabled by default. There were not many core changes. From memory, InjectionResolver was the only core class with significant changes. ScannerService was also modified to allow information about class location to be passed to the core. The rest of the changes were refactoring or config related. Overall, I was impressed at how straightforward the changes were to add this function...it's a credit to the design of OWB. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994211#comment-12994211 ] Gurkan Erdogdu commented on OWB-472: I do not see a reason to rollback the changes. Everyhing in OWB has been written as plugin. Therefore if you do not wish to use any plugin functioanality disabling is enough. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Mark Struberg Attachments: patch.txt Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921268#action_12921268 ] Mark Struberg commented on OWB-472: --- agree, we should just write a warning and put all found interceptors into a big fat Set. Of course the reason why Gavin defined the BDA was to be able to define a certain order of interceptors (contrary to EJB the interceptor order is defined in beans.xml and not via the annotations). I think this was a quick and dirty solution (remember the old saying dirty remains while quick is long forgotten?) and defining an 'ordinal' property for beans.xml or the interceptors section would be much better. See the config.ordinal logic I did for our openwebbeans.properties. I talked with Pete a while ago and he told me that he extended the beans.xml schema to allow own tags somewhere. Haven't looked at it closely, but this might help us. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Gurkan Erdogdu Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921042#action_12921042 ] Jacquelle Leggett commented on OWB-472: --- I have already started working on a patch for this problem. It only enables decorators, interceptors, and alternatives in the BDA that contains such a definition in its beans.xml. This behavior is non-default and enabled via an OWB property. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Gurkan Erdogdu Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921155#action_12921155 ] Mark Struberg commented on OWB-472: --- Hi Jacquelle! Thanks for your effort, but please note that the current behaviour is not a bug but a feature! As explained on the mail thread you already posted: the spec is contradictory in itself and the BDA behaviour for alternatives, interceptors and decorators is _not_ backed by the Spec, _not_ backed by the TCK (we pass those parts of the TCK easily) and completely sick and weird (personal opinion of course). So I'd rather go and report a spec issue than changing our implementation. The reason: if I e.g. need to enable an alternative _inside_ a JAR, then it's completely useless! Because there is NO way to enable this alternative from lets say your webapp _without_ repackaging your JAR every time. Same is true for interceptors and decorators of course. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Gurkan Erdogdu Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-472) archive centric beans.xml enabling
[ https://issues.apache.org/jira/browse/OWB-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921206#action_12921206 ] Jacquelle Leggett commented on OWB-472: --- I think some aspects of this issue can be considered a bug and other parts represent a non-default implementation. As mentioned in the description, most of us agree that not being able to define the same interceptor in multiple jars of a .war is a bug. I understand your point (Mark) about having to repackage a jar. In such a case, the user would simply use the default OWB behavior. If a war contains utility.jar with numerous common classes (some of which are not well-known) and app1classes.jar with application-specific logic, then there should be a way to only enable the modifiers (interceptors, decorators, alternatives) in app1classes.jar. In this case, a property would be set to enable the archive centric beans.xml solution. archive centric beans.xml enabling --- Key: OWB-472 URL: https://issues.apache.org/jira/browse/OWB-472 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Reporter: Jacquelle Leggett Assignee: Gurkan Erdogdu Original Estimate: 336h Remaining Estimate: 336h This issue was discussed in great detail in June (http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201006.mbox/browser) on the developers forum. The title of the thread is problems with lack of archive-centric BeanManager. The main problem is described below (snippet from discussion): ...Our current design does not permit either of the following scenarions, AFAICT: b.jar and c.jar both enable the interceptor defined in a.jar (treated as a duplicate) Exactly one of b.jar and c.jar enables the interceptor defined in a.jar (ends up enabled for beans from either archive if enabled in one -- this is in the more troubling neighborhood)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
