Re: [VOTE] Apache OpenWhisk graduation to Top Level Project
+1 Lots of work to get to this stage. It’s been eye-opening to see how much more there is to an Apache project than just the code. Regards, Rob > On 4 Jun 2019, at 22:25, Rodric Rabbah wrote: > > Hi all, > > After a discussion among the Apache OpenWhisk community on the dev > mailing list [1], we have completed all Trademark transfers, and we > are now in the process of pruning the PMC roster, completing the > podling status page and completing the project maturity model [2]. > > Apache OpenWhisk entered the incubator on November 23 2016. Since > then, we have grown to be in the top 25 list of Apache projects by > GitHub Stars at 4041, have 229 unique contributors across all our > project repos, more than 2500 commits, and most importantly, our > community has grown and is diversified beyond the initial founding > contributors and organization. > > The project has come a long way in embracing The Apache Way, in no > small part to our dedicated mentors and the community spirit that has > grown along this journey. We are operating well as an Apache project > and so we should take the next step. > > As such, I am calling a vote for Apache OpenWhisk to graduate to a top > level project. If we agree that we should graduate to a top level > project, the next step will be to draft a Resolution [3] for the PPMC > and IPMC to vote upon. > > Please take a minute to vote on whether or not Apache OpenWhisk should > graduate to a Top Level Project by responding with one of the > following: > > [ ] +1 Apache OpenWhisk should graduate. > [ ] +0 No opinion > [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) > > The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] > I will notify the incubator mailing list that a community vote is > under way. > > Thank you. > -r > (on behalf of the Apache OpenWhisk PPMC) > > [1] > https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E > [2] > https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model > [3] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 > [4] > https://incubator.apache.org/guides/graduation.html#community_graduation_vote
Re: [VOTE] Apache OpenWhisk graduation to Top Level Project
+1. I think you are ready :) Best regards Krzysztof On 04.06.2019 23:25, Rodric Rabbah wrote: Hi all, After a discussion among the Apache OpenWhisk community on the dev mailing list [1], we have completed all Trademark transfers, and we are now in the process of pruning the PMC roster, completing the podling status page and completing the project maturity model [2]. Apache OpenWhisk entered the incubator on November 23 2016. Since then, we have grown to be in the top 25 list of Apache projects by GitHub Stars at 4041, have 229 unique contributors across all our project repos, more than 2500 commits, and most importantly, our community has grown and is diversified beyond the initial founding contributors and organization. The project has come a long way in embracing The Apache Way, in no small part to our dedicated mentors and the community spirit that has grown along this journey. We are operating well as an Apache project and so we should take the next step. As such, I am calling a vote for Apache OpenWhisk to graduate to a top level project. If we agree that we should graduate to a top level project, the next step will be to draft a Resolution [3] for the PPMC and IPMC to vote upon. Please take a minute to vote on whether or not Apache OpenWhisk should graduate to a Top Level Project by responding with one of the following: [ ] +1 Apache OpenWhisk should graduate. [ ] +0 No opinion [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] I will notify the incubator mailing list that a community vote is under way. Thank you. -r (on behalf of the Apache OpenWhisk PPMC) [1] https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E [2] https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model [3] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 [4] https://incubator.apache.org/guides/graduation.html#community_graduation_vote -- Krzysztof Sobkowiak JEE & OSS Architect, Integration Architect Apache Software Foundation Member (http://apache.org/) Apache ServiceMix Committer & PMC Member (http://servicemix.apache.org/) Apache Incubator PMC Member (https://incubator.apache.org/) Senior Solution Architect @ Capgemini SSC (http://www.capgeminisoftware.pl/)
Re: [VOTE] Apache OpenWhisk graduation to Top Level Project
+1 What? Apache OpenWhisk is not yet graduated? But there is even an O’Reilly Book on it! -- Michele Sciabarra mich...@sciabarra.com - Original message - From: Rodric Rabbah To: dev@openwhisk.apache.org Subject: [VOTE] Apache OpenWhisk graduation to Top Level Project Date: Tuesday, June 04, 2019 11:26 PM Hi all, After a discussion among the Apache OpenWhisk community on the dev mailing list [1], we have completed all Trademark transfers, and we are now in the process of pruning the PMC roster, completing the podling status page and completing the project maturity model [2]. Apache OpenWhisk entered the incubator on November 23 2016. Since then, we have grown to be in the top 25 list of Apache projects by GitHub Stars at 4041, have 229 unique contributors across all our project repos, more than 2500 commits, and most importantly, our community has grown and is diversified beyond the initial founding contributors and organization. The project has come a long way in embracing The Apache Way, in no small part to our dedicated mentors and the community spirit that has grown along this journey. We are operating well as an Apache project and so we should take the next step. As such, I am calling a vote for Apache OpenWhisk to graduate to a top level project. If we agree that we should graduate to a top level project, the next step will be to draft a Resolution [3] for the PPMC and IPMC to vote upon. Please take a minute to vote on whether or not Apache OpenWhisk should graduate to a Top Level Project by responding with one of the following: [ ] +1 Apache OpenWhisk should graduate. [ ] +0 No opinion [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] I will notify the incubator mailing list that a community vote is under way. Thank you. -r (on behalf of the Apache OpenWhisk PPMC) [1] https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E [2] https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model [3] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 [4] https://incubator.apache.org/guides/graduation.html#community_graduation_vote
Re: [VOTE] Apache OpenWhisk graduation to Top Level Project
+1 Exciting times ahead! On Tue, 4 Jun 2019 at 16:28, Dave Grove wrote: > > +1 Apache OpenWhisk should graduate. > > --dave > > On 2019/06/04 21:25:28, Rodric Rabbah wrote: > > Hi all, > > > > After a discussion among the Apache OpenWhisk community on the dev > > mailing list [1], we have completed all Trademark transfers, and we > > are now in the process of pruning the PMC roster, completing the > > podling status page and completing the project maturity model [2]. > > > > Apache OpenWhisk entered the incubator on November 23 2016. Since > > then, we have grown to be in the top 25 list of Apache projects by > > GitHub Stars at 4041, have 229 unique contributors across all our > > project repos, more than 2500 commits, and most importantly, our > > community has grown and is diversified beyond the initial founding > > contributors and organization. > > > > The project has come a long way in embracing The Apache Way, in no > > small part to our dedicated mentors and the community spirit that has > > grown along this journey. We are operating well as an Apache project > > and so we should take the next step. > > > > As such, I am calling a vote for Apache OpenWhisk to graduate to a top > > level project. If we agree that we should graduate to a top level > > project, the next step will be to draft a Resolution [3] for the PPMC > > and IPMC to vote upon. > > > > Please take a minute to vote on whether or not Apache OpenWhisk should > > graduate to a Top Level Project by responding with one of the > > following: > > > > [ ] +1 Apache OpenWhisk should graduate. > > [ ] +0 No opinion > > [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) > > > > The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] > > I will notify the incubator mailing list that a community vote is > > under way. > > > > Thank you. > > -r > > (on behalf of the Apache OpenWhisk PPMC) > > > > [1] > > https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E > > [2] > > https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model > > [3] > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 > > [4] > > https://incubator.apache.org/guides/graduation.html#community_graduation_vote > > -- Matt Sicker
Re: [VOTE] Apache OpenWhisk graduation to Top Level Project
+1 Apache OpenWhisk should graduate. --dave On 2019/06/04 21:25:28, Rodric Rabbah wrote: > Hi all, > > After a discussion among the Apache OpenWhisk community on the dev > mailing list [1], we have completed all Trademark transfers, and we > are now in the process of pruning the PMC roster, completing the > podling status page and completing the project maturity model [2]. > > Apache OpenWhisk entered the incubator on November 23 2016. Since > then, we have grown to be in the top 25 list of Apache projects by > GitHub Stars at 4041, have 229 unique contributors across all our > project repos, more than 2500 commits, and most importantly, our > community has grown and is diversified beyond the initial founding > contributors and organization. > > The project has come a long way in embracing The Apache Way, in no > small part to our dedicated mentors and the community spirit that has > grown along this journey. We are operating well as an Apache project > and so we should take the next step. > > As such, I am calling a vote for Apache OpenWhisk to graduate to a top > level project. If we agree that we should graduate to a top level > project, the next step will be to draft a Resolution [3] for the PPMC > and IPMC to vote upon. > > Please take a minute to vote on whether or not Apache OpenWhisk should > graduate to a Top Level Project by responding with one of the > following: > > [ ] +1 Apache OpenWhisk should graduate. > [ ] +0 No opinion > [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) > > The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] > I will notify the incubator mailing list that a community vote is > under way. > > Thank you. > -r > (on behalf of the Apache OpenWhisk PPMC) > > [1] > https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E > [2] > https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model > [3] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 > [4] > https://incubator.apache.org/guides/graduation.html#community_graduation_vote >
[VOTE] Apache OpenWhisk graduation to Top Level Project
Hi all, After a discussion among the Apache OpenWhisk community on the dev mailing list [1], we have completed all Trademark transfers, and we are now in the process of pruning the PMC roster, completing the podling status page and completing the project maturity model [2]. Apache OpenWhisk entered the incubator on November 23 2016. Since then, we have grown to be in the top 25 list of Apache projects by GitHub Stars at 4041, have 229 unique contributors across all our project repos, more than 2500 commits, and most importantly, our community has grown and is diversified beyond the initial founding contributors and organization. The project has come a long way in embracing The Apache Way, in no small part to our dedicated mentors and the community spirit that has grown along this journey. We are operating well as an Apache project and so we should take the next step. As such, I am calling a vote for Apache OpenWhisk to graduate to a top level project. If we agree that we should graduate to a top level project, the next step will be to draft a Resolution [3] for the PPMC and IPMC to vote upon. Please take a minute to vote on whether or not Apache OpenWhisk should graduate to a Top Level Project by responding with one of the following: [ ] +1 Apache OpenWhisk should graduate. [ ] +0 No opinion [ ] -1 Apache OpenWhisk should not graduate (please provide the reason) The VOTE is open for a minimum of 72 hours. Per Apache guidelines [4] I will notify the incubator mailing list that a community vote is under way. Thank you. -r (on behalf of the Apache OpenWhisk PPMC) [1] https://lists.apache.org/thread.html/8daa3a05148f54ca82458777e2b2b5e25ba99d39dcf8ce7dd85d0188@%3Cdev.openwhisk.apache.org%3E [2] https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model [3] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 [4] https://incubator.apache.org/guides/graduation.html#community_graduation_vote
Re: Help answering last few Project Maturity Model Qs for graduation readiness
Thanks for the responses here which have been very helpful. I have endeavored to include all responses (represent in some way the heart of) in updating the corresponding table rows. Please let me know what you think of the results. On 2019/05/15 18:32:27, Matt Rutkowski wrote: > Hello Whiskers! > You may not have noticed, but last month I endeavored to complete filling out > our project maturity model which has been an ongoing process for a since last > fall (at least). For reference, it is located on our project Wiki here: > > https://cwiki.apache.org/confluence/display/OPENWHISK/Project+Maturity+Model > > Last month, when I came upon the last 2 sections titled "Consensus Building" > and "Independence" (especially), I found it hard to complete using just my > viewpoint which I consider biased (and of course from IBM which helped > charter the project). I would like to use this thread to raise the questions > from that section and ask that our community help supply their honest > answers/opinions. Including: > > - Here are the questions: > > **Consensus building** > [CS50] *All "important" discussions happen asynchronously in written form on > the project's main communications channel. Offline, face-to-face or private > discussions 11 that affect the project are also documented on that channel.* > > **Independence** > [IN10] *The project is independent from any corporate or organizational > influence.* > [IN20] *Contributors act as themselves as opposed to representatives of a > corporation or organization.* > > - > > Of course, feel free to comment on the Wiki as well. I would love to have > enough responses to propose the final text by middle of next week. Please > help with any contributions to the answers. > > Thanks, > Matt > >
Re: [REVIEW] draft proposal for TLP project charter and ASF board resolution
On 2019/05/29 19:05:37, Matt Rutkowski wrote: > Dear Whiskers, > > As a community we have been discussing the possibility of graduation for > quite some time. In the wake of the last legal hurdle being cleared (i.e., > IBM completed transfer of all trademarks and name registrations to the ASF > board) and in anticipation of a VOTE thread, I have created a page on our > CWiki for drafting 2 artifacts we would need to present to the board as part > of the process, that is the graduated project Charter (simple, > straightforward) and the Resolution (which references the charter/project > scope) to become a Top-Level-Project (TLP). > > I am asking you all, as you did for the Maturity model review, to please help > develop/review/comment on these items as well: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526932 > > Note that some background and links that describe the process and artifacts > are included on the page as well. > > FYI, I brought this up as a topic on the agenda of today's Tech. Int. call if > you want my unedited "take" on the process and these items: > https://www.youtube.com/watch?v=kxxTLBC1QD8 > > Thanks for your help! > -Matt > Please check out the charter (simple sentence derived from our CWiki tag line) on proposal page and let me know if we should amend it in any way My Qs... do I need to say FaaS to qualify Serverless? should we say anything about supporting Cloud Native (i.e., 12-factors implied, portable to any Container framework)?
Re: Re: Re: Incubator status report
Matt Sicker wrote on 06/04/2019 12:40:37 PM: > > I still can't edit the wiki. > > On Mon, 3 Jun 2019 at 09:55, Bertrand Delacretaz > wrote: > > > > On Mon, Jun 3, 2019 at 4:50 PM Matt Rutkowski wrote: > > >... You should now have edit access to the Wiki,.. > > > > Works indeed, thank you! > > -Bertrand fwiw, I have to login to the OpenWhisk cwiki using `dgrove-oss` while I login to the incubator wiki using `dgrove`. I don't know why... --dave
Re: Re: Incubator status report
I still can't edit the wiki. On Mon, 3 Jun 2019 at 09:55, Bertrand Delacretaz wrote: > > On Mon, Jun 3, 2019 at 4:50 PM Matt Rutkowski wrote: > >... You should now have edit access to the Wiki,.. > > Works indeed, thank you! > -Bertrand -- Matt Sicker
Re: [RESULT] [VOTE] Release Apache OpenWhisk API Gateway (v0.10.0-incubating, rc2)
Will do. On Mon, 3 Jun 2019 at 11:15, Dave Grove wrote: > > The voting is now closed. > > The vote has passed with 5 +1 votes (Rabbah, Dragos, Hamann, Thomas, > Rutowski) and no other votes cast. > > I will kick off an IPMC vote next. OpenWhisk mentors, please vote on the > IPMC thread so we can get our three binding +1 votes to move forward with > this release. > > --dave > > On 2019/05/29 21:50:35, "David P Grove" wrote: > > > > > > Hi, > > > > As discussed in [2], there was a regression in rc1 of apigateway. so > > we needed to generate a new release candidate once the fix had been merged. > > That has been done. Therefore... > > > > This is a call to vote on releasing version 0.10.0-incubating release > > candidate rc2 of the following project module with artifacts built from the > > Git repositories and commit IDs listed below. > > > > * OpenWhisk API Gateway: a737552c > > https://github.com/apache/incubator-openwhisk-apigateway/commits/a737552c > > > > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.10.0-incubating-rc2/openwhisk-apigateway-0.10.0-incubating-sources.tar.gz > > > > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.10.0-incubating-rc2/openwhisk-apigateway-0.10.0-incubating-sources.tar.gz.asc > > > > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.10.0-incubating-rc2/openwhisk-apigateway-0.10.0-incubating-sources.tar.gz.sha512 > > > > This release is comprised of source code distribution only. > > > > You can use this UNIX script to download the release and verify the > > checklist below: > > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > > > Usage: > > curl -s " > > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > " -o rcverify.sh > > chmod +x rcverify.sh > > rcverify.sh openwhisk-apigateway 'OpenWhisk API Gateway' 0.10.0-incubating > > rc2 > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > Release verification checklist for reference: > > [ ] Download links are valid. > > [ ] Checksums and PGP signatures are valid. > > [ ] DISCLAIMER is included. > > [ ] Source code artifacts have correct names matching the current > > release. > > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository. > > [ ] All files have license headers as specified by OpenWhisk project > > policy [1]. > > [ ] No compiled archives bundled in source archive. > > > > This majority vote is open for at least 72 hours. > > > > > > [1] > > https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md > > [2] > > https://lists.apache.org/thread.html/3a33c365fb755f364385bff06ac681912fd1af7a43a9b58a881d6b85@%3Cdev.openwhisk.apache.org%3E > > -- Matt Sicker
Re: [VOTE] Release Apache OpenWhisk Runtime Node.js (v0.14.0, rc2) apache-openwhisk x
+1 to release Apache OpenWhisk Runtime Node.js (v0.14.0, rc2) All checks passed. ./tools/rcverify.sh openwhisk-runtime-nodejs 'OpenWhisk Runtime Node.js' 1.14.0-incubating rc2 rcverify.sh (script SHA1: 6871 208F 37F8 2352 BA60 E66E 8953 94E8 2832 AA69) working in the following directory: /var/folders/q9/s3th42s53d34ftd5wvcypybrgn/T/tmp.X1GMccNe fetching tarball and signatures from https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-1.14.0-incubating-rc2 fetching openwhisk-runtime-nodejs-1.14.0-incubating-sources.tar.gz fetching openwhisk-runtime-nodejs-1.14.0-incubating-sources.tar.gz.asc fetching openwhisk-runtime-nodejs-1.14.0-incubating-sources.tar.gz.sha512 fetching release keys importing keys gpg: key 72AF0CC22C4CF320: "Vincent Hou (Release manager of OpenWhisk) < houshen...@apache.org>" not changed gpg: key 22907064147F886E: "Dave Grove " not changed gpg: key 44667BC927C86D51: "Rodric Rabbah " not changed gpg: Total number processed: 3 gpg: unchanged: 3 unpacking tar ball cloning scancode Cloning into 'incubator-openwhisk-utilities'... remote: Enumerating objects: 57, done. remote: Counting objects: 100% (57/57), done. remote: Compressing objects: 100% (42/42), done. remote: Total 57 (delta 19), reused 37 (delta 12), pack-reused 0 Unpacking objects: 100% (57/57), done. computing sha512 for openwhisk-runtime-nodejs-1.14.0-incubating-sources.tar.gz SHA512: openwhisk-runtime-nodejs-1.14.0-incubating-sources.tar.gz: EA61BE97 5E7CCA26 E18D95B5 24B5414A 1C3998C7 C00B5C8A 39F8E3F0 04F4A20B 7045173D 0F588F43 CA911AE1 EEE0B31F 9C297417 4370BF67 3A95B83F 31335048 validating sha512... passed verifying asc... passed (signed-by: Vincent Hou (Release manager of OpenWhisk) ) verifying disclaimer... passed verifing notice... passed verifying license... passed verifying sources have proper headers... passed scanning for executable files... passed scanning for non-text files... passed scanning for archives... passed scanning for packages... passed run the following command to remove the scratch space: rm -rf '/var/folders/q9/s3th42s53d34ftd5wvcypybrgn/T/tmp.X1GMccNe' On Thu, May 30, 2019 at 12:42 PM James Thomas wrote: > Hello, > > This is a call to vote on releasing version 1.14.0-incubating release > candidate rc2 of the following project module with artifacts > built from the Git repositories and commit IDs listed below. > > * Apache OpenWhisk Runtime Node.js: 14d2af8 > > https://github.com/apache/incubator-openwhisk-runtime-nodejs.git/commits/14d2af8 > > This release is comprised of source code distribution only. > > You can use this UNIX script to download the release and verify the > checklist below: > > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > Usage: > curl -s " > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > " > -o rcverify.sh > chmod +x rcverify.sh > rcverify.sh openwhisk-runtime-nodejs 'OpenWhisk Runtime Node.js' > 1.14.0-incubating rc2 > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > Release verification checklist for reference: > [ ] Download links are valid. > [ ] Checksums and PGP signatures are valid. > [ ] DISCLAIMER is included. > [ ] Source code artifacts have correct names matching the current > release. > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository. > [ ] All files have license headers if necessary. > [ ] No compiled archives bundled in source archive. > > This majority vote is open for at least 72 hours. > > > > -- > Regards, > James Thomas >
[GitHub] [incubator-openwhisk-pluggable-provider] markusthoemmes commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
markusthoemmes commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290293704
##
File path: actions/event-actions/changesWebAction.js
##
@@ -36,7 +36,7 @@ function main(params) {
common.verifyTriggerAuth(triggerData, false)
.then(() => EventProvider.validate(params))
.catch(err => {
- return reject(common.sendError(400, `Feed parameter validation
failed`, err.message));
+ throw common.sendError(400, `Feed parameter validation failed`,
err.message);
Review comment:
If you return `Promise.reject` that should not happen. Javascript doesn't
care (or even know) what error values are, as long as the promise is rejected
underneath.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-openwhisk-pluggable-provider] jthomas commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
jthomas commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290292293
##
File path: provider/lib/triggers_manager.js
##
@@ -47,81 +47,6 @@ module.exports = function(logger, triggerDB, EventProvider,
redisClient) {
});
};
-// Add a trigger: listen for changes and dispatch.
- /**
-this.createTrigger = function(triggerData) {
-var method = 'createTrigger';
-
-var Cloudant = require('@cloudant/cloudant');
-var cloudantConnection;
-
-if (triggerData.iamApiKey) {
-var dbURL = `${triggerData.protocol}://${triggerData.host}`;
-if (triggerData.port) {
-dbURL += ':' + triggerData.port;
-}
-cloudantConnection = new Cloudant({ url: dbURL, plugins: {
iamauth: { iamApiKey: triggerData.iamApiKey, iamTokenUrl: triggerData.iamUrl }
} });
-}
-else {
-var url =
`${triggerData.protocol}://${triggerData.user}:${triggerData.pass}@${triggerData.host}`;
-if (triggerData.port) {
-url += ':' + triggerData.port;
-}
-cloudantConnection = Cloudant(url);
-}
-
-try {
-var triggeredDB = cloudantConnection.use(triggerData.dbname);
-
-// Listen for changes on this database.
-var feed = triggeredDB.follow({since: triggerData.since,
include_docs: false});
-if (triggerData.filter) {
-feed.filter = triggerData.filter;
-}
-if (triggerData.query_params) {
-feed.query_params = triggerData.query_params;
-}
-
-triggerData.feed = feed;
-self.triggers[triggerData.id] = triggerData;
-
-feed.on('change', function (change) {
-var triggerHandle = self.triggers[triggerData.id];
-if (triggerHandle && shouldFireTrigger(triggerHandle) &&
hasTriggersRemaining(triggerHandle)) {
-logger.info(method, 'Trigger', triggerData.id, 'got change
from', triggerData.dbname);
-try {
-fireTrigger(triggerData.id, change);
-} catch (e) {
-logger.error(method, 'Exception occurred while firing
trigger', triggerData.id, e);
-}
-}
-});
-
-feed.follow();
-
-return new Promise(function(resolve, reject) {
-feed.on('error', function (err) {
-logger.error(method,'Error occurred for trigger',
triggerData.id, '(db ' + triggerData.dbname + '):', err);
-reject(err);
-});
-
-feed.on('confirm', function () {
-logger.info(method, 'Added cloudant data trigger',
triggerData.id, 'listening for changes in database', triggerData.dbname);
-if (isMonitoringTrigger(triggerData.monitor,
triggerData.id)) {
-self.monitorStatus.triggerStarted = "success";
-}
-resolve(triggerData.id);
-});
-});
-
-} catch (err) {
-logger.info(method, 'caught an exception for trigger',
triggerData.id, err);
-return Promise.reject(err);
-}
-
-};
-*/
Review comment:
I'm removing code that was commented out as it was unused from the
re-working on the codebase. I didn't mean to leave this in originally. Is that
what you mean?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-openwhisk-pluggable-provider] jthomas commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
jthomas commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290289829
##
File path: actions/event-actions/changesWebAction.js
##
@@ -36,7 +36,7 @@ function main(params) {
common.verifyTriggerAuth(triggerData, false)
.then(() => EventProvider.validate(params))
.catch(err => {
- return reject(common.sendError(400, `Feed parameter validation
failed`, err.message));
+ throw common.sendError(400, `Feed parameter validation failed`,
err.message);
Review comment:
The existing code returns the result of the `reject` function which is a
non-error value and causes the following `then` handlers to run (which is not
what we want). By throwing the error, all the `then` handlers are skipped and
the `catch` at the end can reject the returned promise with the error from the
validation issue. Did you spot something else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-openwhisk-pluggable-provider] markusthoemmes commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
markusthoemmes commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290255887
##
File path: provider/lib/triggers_manager.js
##
@@ -47,81 +47,6 @@ module.exports = function(logger, triggerDB, EventProvider,
redisClient) {
});
};
-// Add a trigger: listen for changes and dispatch.
- /**
-this.createTrigger = function(triggerData) {
-var method = 'createTrigger';
-
-var Cloudant = require('@cloudant/cloudant');
-var cloudantConnection;
-
-if (triggerData.iamApiKey) {
-var dbURL = `${triggerData.protocol}://${triggerData.host}`;
-if (triggerData.port) {
-dbURL += ':' + triggerData.port;
-}
-cloudantConnection = new Cloudant({ url: dbURL, plugins: {
iamauth: { iamApiKey: triggerData.iamApiKey, iamTokenUrl: triggerData.iamUrl }
} });
-}
-else {
-var url =
`${triggerData.protocol}://${triggerData.user}:${triggerData.pass}@${triggerData.host}`;
-if (triggerData.port) {
-url += ':' + triggerData.port;
-}
-cloudantConnection = Cloudant(url);
-}
-
-try {
-var triggeredDB = cloudantConnection.use(triggerData.dbname);
-
-// Listen for changes on this database.
-var feed = triggeredDB.follow({since: triggerData.since,
include_docs: false});
-if (triggerData.filter) {
-feed.filter = triggerData.filter;
-}
-if (triggerData.query_params) {
-feed.query_params = triggerData.query_params;
-}
-
-triggerData.feed = feed;
-self.triggers[triggerData.id] = triggerData;
-
-feed.on('change', function (change) {
-var triggerHandle = self.triggers[triggerData.id];
-if (triggerHandle && shouldFireTrigger(triggerHandle) &&
hasTriggersRemaining(triggerHandle)) {
-logger.info(method, 'Trigger', triggerData.id, 'got change
from', triggerData.dbname);
-try {
-fireTrigger(triggerData.id, change);
-} catch (e) {
-logger.error(method, 'Exception occurred while firing
trigger', triggerData.id, e);
-}
-}
-});
-
-feed.follow();
-
-return new Promise(function(resolve, reject) {
-feed.on('error', function (err) {
-logger.error(method,'Error occurred for trigger',
triggerData.id, '(db ' + triggerData.dbname + '):', err);
-reject(err);
-});
-
-feed.on('confirm', function () {
-logger.info(method, 'Added cloudant data trigger',
triggerData.id, 'listening for changes in database', triggerData.dbname);
-if (isMonitoringTrigger(triggerData.monitor,
triggerData.id)) {
-self.monitorStatus.triggerStarted = "success";
-}
-resolve(triggerData.id);
-});
-});
-
-} catch (err) {
-logger.info(method, 'caught an exception for trigger',
triggerData.id, err);
-return Promise.reject(err);
-}
-
-};
-*/
Review comment:
Remove this code vs. commenting it out?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-openwhisk-pluggable-provider] markusthoemmes commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
markusthoemmes commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290255720
##
File path: actions/event-actions/changesWebAction.js
##
@@ -36,7 +36,7 @@ function main(params) {
common.verifyTriggerAuth(triggerData, false)
.then(() => EventProvider.validate(params))
.catch(err => {
- return reject(common.sendError(400, `Feed parameter validation
failed`, err.message));
+ throw common.sendError(400, `Feed parameter validation failed`,
err.message);
Review comment:
Shouldn't this actually be what you had above? `Promise.reject(...)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
