[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

[prasanthj]

Github user prasanthj commented on a diff in the pull request:

https://github.com/apache/orc/pull/154#discussion_r132805602
  
--- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
@@ -81,6 +81,7 @@ public Thread getOwner() {
*/
   public MemoryManagerImpl(Configuration conf) {
 double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
+ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
--- End diff --

I don't think we want to support too larger interval for this. Having very 
high value means prolonging the memory check which is bad (flush often as 
opposed to don't flush and fail). 
1 to 1 may be good range. Also please make a note in the description 
that keeping too low value is for testing only and can cause too early flushes 
in some cases and generate sub-optimal orc files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

[ekoifman]

Github user ekoifman commented on a diff in the pull request:

https://github.com/apache/orc/pull/154#discussion_r132804794
  
--- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
@@ -81,6 +81,7 @@ public Thread getOwner() {
*/
   public MemoryManagerImpl(Configuration conf) {
 double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
+ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
--- End diff --

default is set OrcConf - 5000
what would be reasonable range of valid values?  [1,?]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

[prasanthj]

Github user prasanthj commented on a diff in the pull request:

https://github.com/apache/orc/pull/154#discussion_r132804639
  
--- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
@@ -81,6 +81,7 @@ public Thread getOwner() {
*/
   public MemoryManagerImpl(Configuration conf) {
 double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
+ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
--- End diff --

validate values here? and set default value in case of invalid values and 
maybe log?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

[ekoifman]

GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/154

ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-228

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #154


commit ac56bacb0f58c5703cb7fb55ef8b70b7a08cd8a3
Author: Eugene Koifman 
Date:   2017-08-11T23:58:10Z

ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---