Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
Thank you, Pavan and everyone. Could you conclude this vote, William? Dongjoon. On Thu, Jan 19, 2023 at 7:44 AM Pavan Lanka wrote: > Thanks @Dongjoon for the clarification. > > +1 for the release > > * Test the java build and tests using OpenJDK 11 > * Reviewed the list of issues > > > On Jan 18, 2023, at 9:42 PM, Dongjoon Hyun > wrote: > > > > In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the > > correct versions which I wanted to mention. > > ``` > > - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. > > + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. > > ``` > > > > > > On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun > > wrote: > > > >> Thank you, Pavan. > >> > >> 1. Yes, it's intentional. First, we cannot remove the added public API. > >> That's the main reason why we couldn't revert the commit physically. > This > >> discussion happended on the original PR. Second, we keep the added test > >> case by marking 'ignored' because we want to re-enable the test case > when > >> the feature is ready later. > >> > >> 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 > >> releases. It's not s blocker for these releases because there is no > reader > >> implementation before. We are open for implementng that missing > features in > >> new releases. Feel free to make a PR if you are interested. > >> > >> Dongjoon > >> > >> On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka > >> wrote: > >> > >>> I wanted to follow up on ORC-1343 (Ignore orc.create.index). > >>> * The discussion in the Jira seems to indicate that we want to revert > >>> ORC-1283, but the included changes are not a full revert, was that > >>> intentional? > >>> * I think any files created with the previous version of the writer > with > >>> index as false and row_index_stride > 0 will continue to fail during > read, > >>> didn’t we need to fix that? I do see that the scope is limited with > >>> ORC-1283 coming in to 1.7.7 and 1.8.1 > >>> > >>> Please clarify. > >>> > >>> Thanks, > >>> Pavan > >>> > On Jan 16, 2023, at 1:47 PM, William H. > wrote: > > Please vote on releasing the following candidate as Apache ORC version > >>> 1.7.8. > > [ ] +1 Release this package as Apache ORC 1.7.8 > [ ] -1 Do not release this package because ... > > TAG: > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > RELEASE FILES: > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > STAGING REPOSITORY: > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > LIST OF ISSUES: > https://issues.apache.org/jira/projects/ORC/versions/12352724 > https://github.com/apache/orc/milestone/14 > > This vote will be open for 72 hours. > > Regards, > William > >>> > >>> > >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
Thanks @Dongjoon for the clarification. +1 for the release * Test the java build and tests using OpenJDK 11 * Reviewed the list of issues > On Jan 18, 2023, at 9:42 PM, Dongjoon Hyun wrote: > > In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the > correct versions which I wanted to mention. > ``` > - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. > + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. > ``` > > > On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun > wrote: > >> Thank you, Pavan. >> >> 1. Yes, it's intentional. First, we cannot remove the added public API. >> That's the main reason why we couldn't revert the commit physically. This >> discussion happended on the original PR. Second, we keep the added test >> case by marking 'ignored' because we want to re-enable the test case when >> the feature is ready later. >> >> 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 >> releases. It's not s blocker for these releases because there is no reader >> implementation before. We are open for implementng that missing features in >> new releases. Feel free to make a PR if you are interested. >> >> Dongjoon >> >> On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka >> wrote: >> >>> I wanted to follow up on ORC-1343 (Ignore orc.create.index). >>> * The discussion in the Jira seems to indicate that we want to revert >>> ORC-1283, but the included changes are not a full revert, was that >>> intentional? >>> * I think any files created with the previous version of the writer with >>> index as false and row_index_stride > 0 will continue to fail during read, >>> didn’t we need to fix that? I do see that the scope is limited with >>> ORC-1283 coming in to 1.7.7 and 1.8.1 >>> >>> Please clarify. >>> >>> Thanks, >>> Pavan >>> On Jan 16, 2023, at 1:47 PM, William H. wrote: Please vote on releasing the following candidate as Apache ORC version >>> 1.7.8. [ ] +1 Release this package as Apache ORC 1.7.8 [ ] -1 Do not release this package because ... TAG: https://github.com/apache/orc/releases/tag/v1.7.8-rc0 RELEASE FILES: https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 STAGING REPOSITORY: https://repository.apache.org/content/repositories/orgapacheorc-1065 LIST OF ISSUES: https://issues.apache.org/jira/projects/ORC/versions/12352724 https://github.com/apache/orc/milestone/14 This vote will be open for 72 hours. Regards, William >>> >>>
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 Thank you, Dongjoon, Gang, Yiqun, Junwang, Pavan, and Deshan, for your participation. Bests, William On Wed, Jan 18, 2023 at 9:54 PM deshan xiao wrote: > > +1 for the release. > > As for ORC-1343 (Ignore orc.create.index), we need more careful > implementation to avoid any issue in reader & writer. This is not an urgent > issue in the current release. > BTW, I am very willing to re-implement it in the next release. > > Thanks, > Deshan Xiao > > On Thu, Jan 19, 2023 at 1:43 PM Dongjoon Hyun > wrote: > > > In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the > > correct versions which I wanted to mention. > > ``` > > - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. > > + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. > > ``` > > > > > > On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun > > wrote: > > > > > Thank you, Pavan. > > > > > > 1. Yes, it's intentional. First, we cannot remove the added public API. > > > That's the main reason why we couldn't revert the commit physically. This > > > discussion happended on the original PR. Second, we keep the added test > > > case by marking 'ignored' because we want to re-enable the test case when > > > the feature is ready later. > > > > > > 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 > > > releases. It's not s blocker for these releases because there is no > > reader > > > implementation before. We are open for implementng that missing features > > in > > > new releases. Feel free to make a PR if you are interested. > > > > > > Dongjoon > > > > > > On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka > > > wrote: > > > > > >> I wanted to follow up on ORC-1343 (Ignore orc.create.index). > > >> * The discussion in the Jira seems to indicate that we want to revert > > >> ORC-1283, but the included changes are not a full revert, was that > > >> intentional? > > >> * I think any files created with the previous version of the writer with > > >> index as false and row_index_stride > 0 will continue to fail during > > read, > > >> didn’t we need to fix that? I do see that the scope is limited with > > >> ORC-1283 coming in to 1.7.7 and 1.8.1 > > >> > > >> Please clarify. > > >> > > >> Thanks, > > >> Pavan > > >> > > >> > On Jan 16, 2023, at 1:47 PM, William H. > > wrote: > > >> > > > >> > Please vote on releasing the following candidate as Apache ORC version > > >> 1.7.8. > > >> > > > >> > [ ] +1 Release this package as Apache ORC 1.7.8 > > >> > [ ] -1 Do not release this package because ... > > >> > > > >> > TAG: > > >> > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > >> > > > >> > RELEASE FILES: > > >> > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > >> > > > >> > STAGING REPOSITORY: > > >> > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > >> > > > >> > LIST OF ISSUES: > > >> > https://issues.apache.org/jira/projects/ORC/versions/12352724 > > >> > https://github.com/apache/orc/milestone/14 > > >> > > > >> > This vote will be open for 72 hours. > > >> > > > >> > Regards, > > >> > William > > >> > > >> > >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 for the release. As for ORC-1343 (Ignore orc.create.index), we need more careful implementation to avoid any issue in reader & writer. This is not an urgent issue in the current release. BTW, I am very willing to re-implement it in the next release. Thanks, Deshan Xiao On Thu, Jan 19, 2023 at 1:43 PM Dongjoon Hyun wrote: > In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the > correct versions which I wanted to mention. > ``` > - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. > + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. > ``` > > > On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun > wrote: > > > Thank you, Pavan. > > > > 1. Yes, it's intentional. First, we cannot remove the added public API. > > That's the main reason why we couldn't revert the commit physically. This > > discussion happended on the original PR. Second, we keep the added test > > case by marking 'ignored' because we want to re-enable the test case when > > the feature is ready later. > > > > 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 > > releases. It's not s blocker for these releases because there is no > reader > > implementation before. We are open for implementng that missing features > in > > new releases. Feel free to make a PR if you are interested. > > > > Dongjoon > > > > On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka > > wrote: > > > >> I wanted to follow up on ORC-1343 (Ignore orc.create.index). > >> * The discussion in the Jira seems to indicate that we want to revert > >> ORC-1283, but the included changes are not a full revert, was that > >> intentional? > >> * I think any files created with the previous version of the writer with > >> index as false and row_index_stride > 0 will continue to fail during > read, > >> didn’t we need to fix that? I do see that the scope is limited with > >> ORC-1283 coming in to 1.7.7 and 1.8.1 > >> > >> Please clarify. > >> > >> Thanks, > >> Pavan > >> > >> > On Jan 16, 2023, at 1:47 PM, William H. > wrote: > >> > > >> > Please vote on releasing the following candidate as Apache ORC version > >> 1.7.8. > >> > > >> > [ ] +1 Release this package as Apache ORC 1.7.8 > >> > [ ] -1 Do not release this package because ... > >> > > >> > TAG: > >> > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > >> > > >> > RELEASE FILES: > >> > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > >> > > >> > STAGING REPOSITORY: > >> > https://repository.apache.org/content/repositories/orgapacheorc-1065 > >> > > >> > LIST OF ISSUES: > >> > https://issues.apache.org/jira/projects/ORC/versions/12352724 > >> > https://github.com/apache/orc/milestone/14 > >> > > >> > This vote will be open for 72 hours. > >> > > >> > Regards, > >> > William > >> > >> >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
In the previous email, the following was a typo. 1.8.2 and 1.7.9 are the correct versions which I wanted to mention. ``` - Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. + Implementing is not the scope of urgent 1.8.2 and 1.7.9 releases. ``` On Wed, Jan 18, 2023 at 9:29 PM Dongjoon Hyun wrote: > Thank you, Pavan. > > 1. Yes, it's intentional. First, we cannot remove the added public API. > That's the main reason why we couldn't revert the commit physically. This > discussion happended on the original PR. Second, we keep the added test > case by marking 'ignored' because we want to re-enable the test case when > the feature is ready later. > > 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 > releases. It's not s blocker for these releases because there is no reader > implementation before. We are open for implementng that missing features in > new releases. Feel free to make a PR if you are interested. > > Dongjoon > > On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka > wrote: > >> I wanted to follow up on ORC-1343 (Ignore orc.create.index). >> * The discussion in the Jira seems to indicate that we want to revert >> ORC-1283, but the included changes are not a full revert, was that >> intentional? >> * I think any files created with the previous version of the writer with >> index as false and row_index_stride > 0 will continue to fail during read, >> didn’t we need to fix that? I do see that the scope is limited with >> ORC-1283 coming in to 1.7.7 and 1.8.1 >> >> Please clarify. >> >> Thanks, >> Pavan >> >> > On Jan 16, 2023, at 1:47 PM, William H. wrote: >> > >> > Please vote on releasing the following candidate as Apache ORC version >> 1.7.8. >> > >> > [ ] +1 Release this package as Apache ORC 1.7.8 >> > [ ] -1 Do not release this package because ... >> > >> > TAG: >> > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 >> > >> > RELEASE FILES: >> > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 >> > >> > STAGING REPOSITORY: >> > https://repository.apache.org/content/repositories/orgapacheorc-1065 >> > >> > LIST OF ISSUES: >> > https://issues.apache.org/jira/projects/ORC/versions/12352724 >> > https://github.com/apache/orc/milestone/14 >> > >> > This vote will be open for 72 hours. >> > >> > Regards, >> > William >> >>
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
Thank you, Pavan. 1. Yes, it's intentional. First, we cannot remove the added public API. That's the main reason why we couldn't revert the commit physically. This discussion happended on the original PR. Second, we keep the added test case by marking 'ignored' because we want to re-enable the test case when the feature is ready later. 2. Yes, right. Implementing is not the scope of urgent 1.8.1 and 1.7.7 releases. It's not s blocker for these releases because there is no reader implementation before. We are open for implementng that missing features in new releases. Feel free to make a PR if you are interested. Dongjoon On Wed, Jan 18, 2023 at 8:30 PM Pavan Lanka wrote: > I wanted to follow up on ORC-1343 (Ignore orc.create.index). > * The discussion in the Jira seems to indicate that we want to revert > ORC-1283, but the included changes are not a full revert, was that > intentional? > * I think any files created with the previous version of the writer with > index as false and row_index_stride > 0 will continue to fail during read, > didn’t we need to fix that? I do see that the scope is limited with > ORC-1283 coming in to 1.7.7 and 1.8.1 > > Please clarify. > > Thanks, > Pavan > > > On Jan 16, 2023, at 1:47 PM, William H. wrote: > > > > Please vote on releasing the following candidate as Apache ORC version > 1.7.8. > > > > [ ] +1 Release this package as Apache ORC 1.7.8 > > [ ] -1 Do not release this package because ... > > > > TAG: > > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > > > RELEASE FILES: > > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > > > STAGING REPOSITORY: > > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > > > LIST OF ISSUES: > > https://issues.apache.org/jira/projects/ORC/versions/12352724 > > https://github.com/apache/orc/milestone/14 > > > > This vote will be open for 72 hours. > > > > Regards, > > William > >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
I wanted to follow up on ORC-1343 (Ignore orc.create.index). * The discussion in the Jira seems to indicate that we want to revert ORC-1283, but the included changes are not a full revert, was that intentional? * I think any files created with the previous version of the writer with index as false and row_index_stride > 0 will continue to fail during read, didn’t we need to fix that? I do see that the scope is limited with ORC-1283 coming in to 1.7.7 and 1.8.1 Please clarify. Thanks, Pavan > On Jan 16, 2023, at 1:47 PM, William H. wrote: > > Please vote on releasing the following candidate as Apache ORC version 1.7.8. > > [ ] +1 Release this package as Apache ORC 1.7.8 > [ ] -1 Do not release this package because ... > > TAG: > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > RELEASE FILES: > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > STAGING REPOSITORY: > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > LIST OF ISSUES: > https://issues.apache.org/jira/projects/ORC/versions/12352724 > https://github.com/apache/orc/milestone/14 > > This vote will be open for 72 hours. > > Regards, > William
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 build and tested on macOS Monterey Version 12.6. Thanks for driving this, William. Regards, Junwang Zhao On Tue, Jan 17, 2023 at 5:47 AM William H. wrote: > > Please vote on releasing the following candidate as Apache ORC version 1.7.8. > > [ ] +1 Release this package as Apache ORC 1.7.8 > [ ] -1 Do not release this package because ... > > TAG: > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > RELEASE FILES: > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > STAGING REPOSITORY: > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > LIST OF ISSUES: > https://issues.apache.org/jira/projects/ORC/versions/12352724 > https://github.com/apache/orc/milestone/14 > > This vote will be open for 72 hours. > > Regards, > William
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 Thank you for driving this release, William. Best, Yiqun Gang Wu 于2023年1月17日周二 12:40写道： > +1 > > Thanks for driving this, William. > > Best, > Gang > > On Tue, Jan 17, 2023 at 12:17 PM Dongjoon Hyun > wrote: > > > +1 > > > > Thank you so much, William. > > > > Dongjoon. > > > > On Mon, Jan 16, 2023 at 1:47 PM William H. > wrote: > > > > > Please vote on releasing the following candidate as Apache ORC version > > > 1.7.8. > > > > > > [ ] +1 Release this package as Apache ORC 1.7.8 > > > [ ] -1 Do not release this package because ... > > > > > > TAG: > > > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > > > > > RELEASE FILES: > > > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > > > > > STAGING REPOSITORY: > > > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > > > > > LIST OF ISSUES: > > > https://issues.apache.org/jira/projects/ORC/versions/12352724 > > > https://github.com/apache/orc/milestone/14 > > > > > > This vote will be open for 72 hours. > > > > > > Regards, > > > William > > > > > >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 Thanks for driving this, William. Best, Gang On Tue, Jan 17, 2023 at 12:17 PM Dongjoon Hyun wrote: > +1 > > Thank you so much, William. > > Dongjoon. > > On Mon, Jan 16, 2023 at 1:47 PM William H. wrote: > > > Please vote on releasing the following candidate as Apache ORC version > > 1.7.8. > > > > [ ] +1 Release this package as Apache ORC 1.7.8 > > [ ] -1 Do not release this package because ... > > > > TAG: > > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > > > RELEASE FILES: > > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > > > STAGING REPOSITORY: > > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > > > LIST OF ISSUES: > > https://issues.apache.org/jira/projects/ORC/versions/12352724 > > https://github.com/apache/orc/milestone/14 > > > > This vote will be open for 72 hours. > > > > Regards, > > William > > >
Re: [VOTE] Release Apache ORC 1.7.8 (RC0)
+1 Thank you so much, William. Dongjoon. On Mon, Jan 16, 2023 at 1:47 PM William H. wrote: > Please vote on releasing the following candidate as Apache ORC version > 1.7.8. > > [ ] +1 Release this package as Apache ORC 1.7.8 > [ ] -1 Do not release this package because ... > > TAG: > https://github.com/apache/orc/releases/tag/v1.7.8-rc0 > > RELEASE FILES: > https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 > > STAGING REPOSITORY: > https://repository.apache.org/content/repositories/orgapacheorc-1065 > > LIST OF ISSUES: > https://issues.apache.org/jira/projects/ORC/versions/12352724 > https://github.com/apache/orc/milestone/14 > > This vote will be open for 72 hours. > > Regards, > William >
[VOTE] Release Apache ORC 1.7.8 (RC0)
Please vote on releasing the following candidate as Apache ORC version 1.7.8. [ ] +1 Release this package as Apache ORC 1.7.8 [ ] -1 Do not release this package because ... TAG: https://github.com/apache/orc/releases/tag/v1.7.8-rc0 RELEASE FILES: https://dist.apache.org/repos/dist/dev/orc/v1.7.8-rc0 STAGING REPOSITORY: https://repository.apache.org/content/repositories/orgapacheorc-1065 LIST OF ISSUES: https://issues.apache.org/jira/projects/ORC/versions/12352724 https://github.com/apache/orc/milestone/14 This vote will be open for 72 hours. Regards, William
