[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508754#comment-16508754 ] ASF GitHub Bot commented on PARQUET-1292: - costimuraru commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-396388109 @chawlakunal any luck? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493896#comment-16493896 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-392865677 @BenoitHanotte I'll work on that sometime this week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493879#comment-16493879 ] ASF GitHub Bot commented on PARQUET-1292: - BenoitHanotte commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-392860267 Hello @costimuraru @chawlakunal As we might again be adding a new flag if https://github.com/apache/parquet-mr/pull/410 passes, I think we may want to follow @lukasnalezenec suggestion and try to have constructors that accept the conf object, which would allow to avoid duplicating all the existing constructors for each new flag. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481585#comment-16481585 ] ASF GitHub Bot commented on PARQUET-1292: - costimuraru commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390399184 @lukasnalezenec From my perspective, it looks great! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480803#comment-16480803 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390241161 I think that problem is that there was no ProtoParquetWriter constructor with conf parameter. I would recommend adding the conf parameter and not writeSpecsCompliant parameter. AFAIK there is no elegant solution how we can accept writeSpecsCompliant parameter, set its value to configuration and pass it super constructor. (see getConfigWithWriteSpecsCompliant()) I would take existing constructors and add those two new constructors: ``` ProtoParquetWriter(Path file, Class protoMessage, Configuration conf); ProtoParquetWriter(Path file, Class protoMessage, ParquetFileWriter.Mode mode, CompressionCodecName compressionCodecName, int blockSize, int pageSize, int dictionaryPageSize, boolean enableDictionary, boolean validating, WriterVersion writerVersion, Configuration conf ``` We might also extend some other existing constructors with conf parameter. (I am not sure if it is necessary) After this change we might turn on the parameter like this: ```java Configuration conf = new Configuration(); ProtoWriteSupport.setWriteSpecsCompliant(conf, true); ParquetWriter writer = new ProtoParquetWriter<>(file, cls, conf);` ``` If you disagree with me, I'm open to another solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480801#comment-16480801 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390241161 I think that problem is that there was no ProtoParquetWriter constructor with conf parameter. I would recommend adding the conf parameter and not writeSpecsCompliant parameter. AFAIK there is no elegant solution how we can accept writeSpecsCompliant parameter, set its value to configuration and pass it super constructor. (see getConfigWithWriteSpecsCompliant()) I would take existing constructors and add those two new constructors: ``` ProtoParquetWriter(Path file, Class protoMessage, Configuration conf); ProtoParquetWriter(Path file, Class protoMessage, ParquetFileWriter.Mode mode, CompressionCodecName compressionCodecName, int blockSize, int pageSize, int dictionaryPageSize, boolean enableDictionary, boolean validating, WriterVersion writerVersion, Configuration conf ``` We might add also extends some other existing constructors with conf parameter. After this change we might turn on the parameter like this: ```java Configuration conf = new Configuration(); ProtoWriteSupport.setWriteSpecsCompliant(conf, true); ParquetWriter writer = new ProtoParquetWriter<>(file, cls, conf);` ``` If you disagree with me, I'm open to another solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480799#comment-16480799 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390241161 I think that problem is that there was no ProtoParquetWriter with conf parameter. I would recommend adding the conf parameter and not writeSpecsCompliant parameter. AFAIK there is no elegant solution how we can accept writeSpecsCompliant parameter, set its value to configuration and pass it super constructor. (see getConfigWithWriteSpecsCompliant()) I would take existing constructors and add those two new constructors: ``` ProtoParquetWriter(Path file, Class protoMessage, Configuration conf); ProtoParquetWriter(Path file, Class protoMessage, ParquetFileWriter.Mode mode, CompressionCodecName compressionCodecName, int blockSize, int pageSize, int dictionaryPageSize, boolean enableDictionary, boolean validating, WriterVersion writerVersion, Configuration conf ``` We might add also extends some other existing constructors with conf parameter. After this change we might turn on the parameter like this: ```java Configuration conf = new Configuration(); ProtoWriteSupport.setWriteSpecsCompliant(conf, true); ParquetWriter writer = new ProtoParquetWriter<>(file, cls, conf);` ``` If you disagree with me, I'm open to another solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480795#comment-16480795 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390241161 I think that problem is that there was no ProtoParquetWriter with conf parameter. I would recommend adding the conf parameter and not writeSpecsCompliant parameter. AFAIK there is no elegant solution how we can accept writeSpecsCompliant parameter, set its value to configuration and pass it super constructor. (see getConfigWithWriteSpecsCompliant()) I would take existing constructors and add those two new constructors: ProtoParquetWriter(Path file, Class protoMessage, Configuration conf); ProtoParquetWriter(Path file, Class protoMessage, ParquetFileWriter.Mode mode, CompressionCodecName compressionCodecName, int blockSize, int pageSize, int dictionaryPageSize, boolean enableDictionary, boolean validating, WriterVersion writerVersion, Configuration conf We might add also extends some other existing constructors with conf parameter. If you disagree with me, I'm open to another solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480793#comment-16480793 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-390241161 I think that problem is that there was no ProtoParquetWriter with conf parameter. I would recommend adding the conf parameter and not writeSpecsCompliant parameter. AFAIK there is no elegant solution how we can accept writeSpecsCompliant parameter, set its value to configuration and pass it super constructor. (see getConfigWithWriteSpecsCompliant()) I would add those two new constructors: ProtoParquetWriter(Path file, Class protoMessage, Configuration conf); ProtoParquetWriter(Path file, Class protoMessage, ParquetFileWriter.Mode mode, CompressionCodecName compressionCodecName, int blockSize, int pageSize, int dictionaryPageSize, boolean enableDictionary, boolean validating, WriterVersion writerVersion, Configuration conf We might add also extends some other existing constructors with conf parameter. If you disagree with me, I'm open to another solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475884#comment-16475884 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-389179871 I am still waiting for comments from @lukasnalezenec This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475749#comment-16475749 ] ASF GitHub Bot commented on PARQUET-1292: - costimuraru commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-389147990 +1 on finding a way to pass the `writeSpecsCompliant` flag directly to the `ProtoParquetWriter` and simplify things. Right now we have to do something like: ```java Configuration conf = new Configuration(); ProtoWriteSupport.setWriteSpecsCompliant(conf, true); ParquetWriter writer = new ParquetWriter<>(file, new ProtoWriteSupport(cls), CompressionCodecName.GZIP, 256 * 1024 * 1024, 1 * 1024 * 1024, 1 * 1024 * 1024, true, false, ParquetWriter.DEFAULT_WRITER_VERSION, conf); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466202#comment-16466202 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-387136555 Hi @lukasnalezenec Waiting to hear from you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464685#comment-16464685 ] ASF GitHub Bot commented on PARQUET-1292: - lukasnalezenec commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386785204 Hi, Thank you for your work. I looked at it briefly, I will send you detailed opinion after weekend. I am not sure if we need so many new constructors. We should publish the Configuration parameter from superclass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464496#comment-16464496 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386758887 @BenoitHanotte Can this be approved and merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463645#comment-16463645 ] ASF GitHub Bot commented on PARQUET-1292: - zivanfi commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386555458 @chawlakunal, I added you the list of contributors so that you can assign JIRA-s to yourself. I assigned this one to you to make sure it works. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Assignee: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462656#comment-16462656 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386345925 @BenoitHanotte Happy to contribute!!1 I have created a JIRA for this but I am unable to assign it to myself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462654#comment-16462654 ] ASF GitHub Bot commented on PARQUET-1292: - BenoitHanotte commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386235161 Thanks @chawlakunal for the commit, it looks good to me. I believe there is a slight mistake in a comment (see my review above). You may want to open a Jira ticket for this commit and add the ticket name in the message ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462655#comment-16462655 ] ASF GitHub Bot commented on PARQUET-1292: - chawlakunal commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386345925 @BenoitHanotte Happy to contribute (in a very small way though :P) I have created a JIRA for this but I am unable to assign it to myself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1292) Add constructors to ProtoParquetWriter to write specs compliant Parquet
[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462651#comment-16462651 ] ASF GitHub Bot commented on PARQUET-1292: - BenoitHanotte commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-386235161 Thanks @chawlakunal for the commit, it looks good to me. I believe there is a slight mistake an a comment (see my review above). You may want to open a Jira ticket for this commit and add the ticket name in the message ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > --- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement >Reporter: Kunal Chawla >Priority: Minor > Fix For: 1.11 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
