[ https://issues.apache.org/jira/browse/PARQUET-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493879#comment-16493879 ]
ASF GitHub Bot commented on PARQUET-1292: ----------------------------------------- BenoitHanotte commented on issue #473: PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag URL: https://github.com/apache/parquet-mr/pull/473#issuecomment-392860267 Hello @costimuraru @chawlakunal As we might again be adding a new flag if https://github.com/apache/parquet-mr/pull/410 passes, I think we may want to follow @lukasnalezenec suggestion and try to have constructors that accept the conf object, which would allow to avoid duplicating all the existing constructors for each new flag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add constructors to ProtoParquetWriter to write specs compliant Parquet > ----------------------------------------------------------------------- > > Key: PARQUET-1292 > URL: https://issues.apache.org/jira/browse/PARQUET-1292 > Project: Parquet > Issue Type: Improvement > Reporter: Kunal Chawla > Assignee: Kunal Chawla > Priority: Minor > Fix For: 1.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)