[jira] [Commented] (PDFBOX-2576) Improve code quality

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272977#comment-14272977
 ] 

ASF subversion and git services commented on PDFBOX-2576:
-

Commit 1650918 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650918 ]

PDFBOX-2576: remove unused imports; remove unused assignments

> Improve code quality
> 
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Apache PDFBox January 2015 board report due

[Maruan Sahyoun]

Tilman, Andreas,

good idea. In addition we should include some of the metrics from the Sonar 
Reports

a) because we made some progress there (mostly because of your efforts) and
b) we provide feedback that such tools, provided by the ASF to us, are very 
valuable and used by the projects

I'd also include the much better test coverage with the corpora testbed both 
for PDFBox 'core' as well as Preflight.

Above topics could be under a 'Software Quality' header

Maybe it's also worth noting the joint efforts with TIKA to show cross project 
efforts. These have been very useful I think.
 

BR

Maruan


Am 10.01.2015 um 16:07 schrieb Tilman Hausherr :

> I wonder if it would make sense to include some statistic about issues opened 
> vs. issues resolved/closed. For example, a statistic like this
> 
> https://issues.apache.org/jira/browse/PDFBOX/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
> 
> looks very nice, it means we're getting forward, while another such as this 
> one
> 
> https://issues.apache.org/jira/browse/IMAGING/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
> 
> means they're falling behind (but still making a good effort).
> 
> Tilman
> 
> Am 10.01.2015 um 13:50 schrieb Andreas Lehmkuehler:
>> Hi,
>> 
>> find attached a quick draft of the board report we're expected to submit this
>> month.
>> 
>> @John
>> Any news about "your" GSoC project?
>> 
>> 
>> Any further comments, objections or additions?
>> 
>> 
>> 
>> 
>> The Apache PDFBox library is an open source Java tool for working with PDF
>> documents.
>> 
>> 
>> General Comments
>> 
>> 
>> There are no issues that require Board attention.
>> 
>> Community
>> -
>> 
>> There is a steady stream of contributions and bug reports from the community.
>> 
>> John Hewson and Tilman Hausherr were added as committers and PMC members to 
>> our ranks in February 2014.
>> 
>> 493 (481 last report) subscribers on the user@ list
>> 149 (155 last report) subscribers on the dev@ list
>> 
>> Releases
>> 
>> 
>> Version 1.8.8 was released on 13nd of December 2014. It is an incremental 
>> bugfix release based on PDFBox 1.8.x.
>> 
>> 
>> Development:
>> 
>> 
>> The work on our next major release is an ongoing effort. The main topics are:
>> 
>> - switch to java 1.6
>> - enhance the parser
>> - code cleanup
>> - enhance rendering
>> - enhance font handling
>> - add unicode support
>> - reduce memory footprint
>> 
>> The long-awaited new major release is still under construction and there is 
>> still a lot to do. Most of the bigger parts are done so that we see the 
>> light at the end of the tunnel.
>> 
>> 
>> 
>> BR
>> Andreas Lehmkühler
> 

[jira] [Commented] (PDFBOX-2576) Improve code quality

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272983#comment-14272983
 ] 

ASF subversion and git services commented on PDFBOX-2576:
-

Commit 1650927 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650927 ]

PDFBOX-2576: remove unused imports; add override

> Improve code quality
> 
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2576) Improve code quality

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272988#comment-14272988
 ] 

ASF subversion and git services commented on PDFBOX-2576:
-

Commit 1650933 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650933 ]

PDFBOX-2576: avoid overridable call in constructor

> Improve code quality
> 
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272992#comment-14272992
 ] 

ASF subversion and git services commented on PDFBOX-2516:
-

Commit 1650936 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650936 ]

PDFBOX-2516 handle null when setting inheritable attributes

> Further align AcroForms and Fields PDModel with PDF specification
> -
>
> Key: PDFBOX-2516
> URL: https://issues.apache.org/jira/browse/PDFBOX-2516
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
> Fix For: 2.0.0
>
>
> The PDModel for AcroForms and the fields being part of it  
> (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues:
>  - RadioButton and Checkbox don’t support DV entries although they should
>  - inheritable attributes only support inheritance either form their parent 
> or the root of the AcroForms model which is not inline with the specification



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273000#comment-14273000
 ] 

ASF subversion and git services commented on PDFBOX-2516:
-

Commit 1650945 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650945 ]

PDFBOX-2516 PDFBOX-2582 enhance javadoc to clarify getFields() method

> Further align AcroForms and Fields PDModel with PDF specification
> -
>
> Key: PDFBOX-2516
> URL: https://issues.apache.org/jira/browse/PDFBOX-2516
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
> Fix For: 2.0.0
>
>
> The PDModel for AcroForms and the fields being part of it  
> (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues:
>  - RadioButton and Checkbox don’t support DV entries although they should
>  - inheritable attributes only support inheritance either form their parent 
> or the root of the AcroForms model which is not inline with the specification



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2582) Form fields missing entirely or incorrect in PDField list

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273001#comment-14273001
 ] 

ASF subversion and git services commented on PDFBOX-2582:
-

Commit 1650945 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650945 ]

PDFBOX-2516 PDFBOX-2582 enhance javadoc to clarify getFields() method

> Form fields missing entirely or incorrect in PDField list
> -
>
> Key: PDFBOX-2582
> URL: https://issues.apache.org/jira/browse/PDFBOX-2582
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 1.8.8, 2.0.0
> Environment: Windows 7, JRE 1.8.0_25
>Reporter: Gilad Denneboom
>Assignee: Maruan Sahyoun
>  Labels: acroform
> Attachments: Rollover Mock 5.pdf
>
>
> Running this code on the attached file results in incorrect and missing 
> results:
> PDDocument doc = PDDocument.load( new File(filePath) );
> PDAcroForm form = doc.getDocumentCatalog().getAcroForm();
> List fields = form.getFields();
> for ( int i=0; i   System.out.println("Name:" + fields.get(i).getFullyQualifiedName());
> }
> The output is:
> Name:2
> Name:Step 2
> Name:Image 2
> Name:Button 2
> Name:Button 5
> Name:Image 5
> The file was generated in InDesign and the form fields created there, so they 
> should be recognizable. You can see that the part of the form fields after 
> the dot was removed and the two fields on page 4 are missing entirely.
> I tested it using 1.8.8 and a very recent 2.0.0 snapshot, both yielded the 
> same results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2576) Improve code quality

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273003#comment-14273003
 ] 

ASF subversion and git services commented on PDFBOX-2576:
-

Commit 1650946 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650946 ]

PDFBOX-2576: close inputStream

> Improve code quality
> 
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2582) Form fields missing entirely or incorrect in PDField list

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273004#comment-14273004
 ] 

ASF subversion and git services commented on PDFBOX-2582:
-

Commit 1650948 from [~msahyoun] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1650948 ]

PDFBOX-2582 enhance javadoc to clarify getFields() method

> Form fields missing entirely or incorrect in PDField list
> -
>
> Key: PDFBOX-2582
> URL: https://issues.apache.org/jira/browse/PDFBOX-2582
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 1.8.8, 2.0.0
> Environment: Windows 7, JRE 1.8.0_25
>Reporter: Gilad Denneboom
>Assignee: Maruan Sahyoun
>  Labels: acroform
> Attachments: Rollover Mock 5.pdf
>
>
> Running this code on the attached file results in incorrect and missing 
> results:
> PDDocument doc = PDDocument.load( new File(filePath) );
> PDAcroForm form = doc.getDocumentCatalog().getAcroForm();
> List fields = form.getFields();
> for ( int i=0; i   System.out.println("Name:" + fields.get(i).getFullyQualifiedName());
> }
> The output is:
> Name:2
> Name:Step 2
> Name:Image 2
> Name:Button 2
> Name:Button 5
> Name:Image 5
> The file was generated in InDesign and the form fields created there, so they 
> should be recognizable. You can see that the part of the form fields after 
> the dot was removed and the two fields on page 4 are missing entirely.
> I tested it using 1.8.8 and a very recent 2.0.0 snapshot, both yielded the 
> same results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PDFBOX-2582) Form fields missing entirely or incorrect in PDField list

[Maruan Sahyoun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maruan Sahyoun updated PDFBOX-2582:
---
Fix Version/s: 2.0.0
   1.8.9

> Form fields missing entirely or incorrect in PDField list
> -
>
> Key: PDFBOX-2582
> URL: https://issues.apache.org/jira/browse/PDFBOX-2582
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 1.8.8, 2.0.0
> Environment: Windows 7, JRE 1.8.0_25
>Reporter: Gilad Denneboom
>Assignee: Maruan Sahyoun
>  Labels: acroform
> Fix For: 1.8.9, 2.0.0
>
> Attachments: Rollover Mock 5.pdf
>
>
> Running this code on the attached file results in incorrect and missing 
> results:
> PDDocument doc = PDDocument.load( new File(filePath) );
> PDAcroForm form = doc.getDocumentCatalog().getAcroForm();
> List fields = form.getFields();
> for ( int i=0; i   System.out.println("Name:" + fields.get(i).getFullyQualifiedName());
> }
> The output is:
> Name:2
> Name:Step 2
> Name:Image 2
> Name:Button 2
> Name:Button 5
> Name:Image 5
> The file was generated in InDesign and the form fields created there, so they 
> should be recognizable. You can see that the part of the form fields after 
> the dot was removed and the two fields on page 4 are missing entirely.
> I tested it using 1.8.8 and a very recent 2.0.0 snapshot, both yielded the 
> same results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PDFBOX-2597) Provide easier access to AcroForm field tree

[Maruan Sahyoun (JIRA)]

Maruan Sahyoun created PDFBOX-2597:
--

 Summary: Provide easier access to AcroForm field tree
 Key: PDFBOX-2597
 URL: https://issues.apache.org/jira/browse/PDFBOX-2597
 Project: PDFBox
  Issue Type: Improvement
Reporter: Maruan Sahyoun
Priority: Minor


The current implementation of the AcroForm field retrieval methods don’t 
provide an easy access to get to all fields as 
 - one needs to retrieve the documents root fields
 - check if these are non-terminal fields
 - retrieve their childs
 - move on until all terminal fields have been retrieved

There should be a way to easier get access to all terminal fields  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PDFBOX-2597) Provide easier access to AcroForm field tree

[Maruan Sahyoun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maruan Sahyoun updated PDFBOX-2597:
---
Component/s: AcroForm

> Provide easier access to AcroForm field tree
> 
>
> Key: PDFBOX-2597
> URL: https://issues.apache.org/jira/browse/PDFBOX-2597
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Reporter: Maruan Sahyoun
>Priority: Minor
>
> The current implementation of the AcroForm field retrieval methods don’t 
> provide an easy access to get to all fields as 
>  - one needs to retrieve the documents root fields
>  - check if these are non-terminal fields
>  - retrieve their childs
>  - move on until all terminal fields have been retrieved
> There should be a way to easier get access to all terminal fields  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (PDFBOX-2582) Form fields missing entirely or incorrect in PDField list

[Maruan Sahyoun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maruan Sahyoun resolved PDFBOX-2582.

Resolution: Not a Problem

The software works as designed here. Follow up issue created to enhance the 
user experience.

> Form fields missing entirely or incorrect in PDField list
> -
>
> Key: PDFBOX-2582
> URL: https://issues.apache.org/jira/browse/PDFBOX-2582
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 1.8.8, 2.0.0
> Environment: Windows 7, JRE 1.8.0_25
>Reporter: Gilad Denneboom
>Assignee: Maruan Sahyoun
>  Labels: acroform
> Fix For: 1.8.9, 2.0.0
>
> Attachments: Rollover Mock 5.pdf
>
>
> Running this code on the attached file results in incorrect and missing 
> results:
> PDDocument doc = PDDocument.load( new File(filePath) );
> PDAcroForm form = doc.getDocumentCatalog().getAcroForm();
> List fields = form.getFields();
> for ( int i=0; i   System.out.println("Name:" + fields.get(i).getFullyQualifiedName());
> }
> The output is:
> Name:2
> Name:Step 2
> Name:Image 2
> Name:Button 2
> Name:Button 5
> Name:Image 5
> The file was generated in InDesign and the form fields created there, so they 
> should be recognizable. You can see that the part of the form fields after 
> the dot was removed and the two fields on page 4 are missing entirely.
> I tested it using 1.8.8 and a very recent 2.0.0 snapshot, both yielded the 
> same results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273046#comment-14273046
 ] 

ASF subversion and git services commented on PDFBOX-2516:
-

Commit 1650964 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650964 ]

PDFBOX-2516 fix value for SigFlags AppendOnly

> Further align AcroForms and Fields PDModel with PDF specification
> -
>
> Key: PDFBOX-2516
> URL: https://issues.apache.org/jira/browse/PDFBOX-2516
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
> Fix For: 2.0.0
>
>
> The PDModel for AcroForms and the fields being part of it  
> (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues:
>  - RadioButton and Checkbox don’t support DV entries although they should
>  - inheritable attributes only support inheritance either form their parent 
> or the root of the AcroForms model which is not inline with the specification



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2576) Improve code quality

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273050#comment-14273050
 ] 

ASF subversion and git services commented on PDFBOX-2576:
-

Commit 1650968 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650968 ]

PDFBOX-2576: avoid unsynchronized lazy initialization and update of static field

> Improve code quality
> 
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2333) Overhaul the apperance generation for PDF forms

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273078#comment-14273078
 ] 

ASF subversion and git services commented on PDFBOX-2333:
-

Commit 1650982 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650982 ]

PDFBOX-2333 support String and PDTextStream field values

> Overhaul the apperance generation for PDF forms
> ---
>
> Key: PDFBOX-2333
> URL: https://issues.apache.org/jira/browse/PDFBOX-2333
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: AcroForms-SimpleTextFields.1.8.7.pdf, 
> AcroForms-SimpleTextFields.1.8.7.png, AcroForms-SimpleTextFields.pdf, 
> AlignmentTests-post1633495.pdf, AlignmentTests-pre1633495.pdf, 
> MultilineTests-prePatch.pdf
>
>
> The appearance handling for forms in 1.x is limited and does not reflect all 
> settings possible for form fields. In addition the current code is not very 
> modular and does not follow the box model used for form fields. 
> Unfortunately only the basics of form handling are defined in the PDF spec. 
> The details like padding of boxes, text placement etc. have to be determined 
> by looking at how Adobe forms are generated.
> Update: The file from PDFBOX-2310 has bad rendering which might be related?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2333) Overhaul the apperance generation for PDF forms

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273079#comment-14273079
 ] 

ASF subversion and git services commented on PDFBOX-2333:
-

Commit 1650983 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650983 ]

PDFBOX-2333 fix obsolete start/end hex string delimiters

> Overhaul the apperance generation for PDF forms
> ---
>
> Key: PDFBOX-2333
> URL: https://issues.apache.org/jira/browse/PDFBOX-2333
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: AcroForms-SimpleTextFields.1.8.7.pdf, 
> AcroForms-SimpleTextFields.1.8.7.png, AcroForms-SimpleTextFields.pdf, 
> AlignmentTests-post1633495.pdf, AlignmentTests-pre1633495.pdf, 
> MultilineTests-prePatch.pdf
>
>
> The appearance handling for forms in 1.x is limited and does not reflect all 
> settings possible for form fields. In addition the current code is not very 
> modular and does not follow the box model used for form fields. 
> Unfortunately only the basics of form handling are defined in the PDF spec. 
> The details like padding of boxes, text placement etc. have to be determined 
> by looking at how Adobe forms are generated.
> Update: The file from PDFBOX-2310 has bad rendering which might be related?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PDFBOX-2433) PDFPrinter does not print Acroform fields

[Maruan Sahyoun (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273081#comment-14273081
 ] 

Maruan Sahyoun commented on PDFBOX-2433:


Tested with the current trunk version. Can’t reproduce the issue. A filled out 
form prints fine with the original values (set by Adobe Acrobat) and after 
changing the field values using PDFBox. We’d need the users PDF to reproduce 
the issue or see what might have been wrong otherwise (e.g. when setting the 
field values).



> PDFPrinter does not print Acroform fields
> -
>
> Key: PDFBOX-2433
> URL: https://issues.apache.org/jira/browse/PDFBOX-2433
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.0
> Environment: Windows 8, Java 7
>Reporter: Andre Gregori
>Priority: Critical
>  Labels: PDFPrint, printJob, printing
> Fix For: 2.0.0
>
>
> In v 1.8, if you set a PDPageable to a PrinterJob and told it to print(), it 
> would print AcroForm fields if they existed.
> Now, with PDFPrinter (a great improvement in many respects!) the AcroForm 
> fields don't print anymore.
> I have tried pinpointing the problem in PDFPrinter, PDFRenderer, and 
> PageDrawer, but unsuccessfully.
> Perhaps I am doing it wrong.  Here is some code:
> {code}
> PDAcroForm form = document.getDocumentCatalog().getAcroForm();
> PDFieldTreeNode f = form.getField("referral");
> f.setValue("test");
> PDFPrinter pdfPrinter = new PDFPrinter(document);
> pdfPrinter.silentPrint();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build became unstable: PDFBox-trunk » Apache PDFBox #1655

[Apache Jenkins Server]

See 

Jenkins build became unstable: PDFBox-trunk #1655

[Apache Jenkins Server]

See 

Re: Jenkins build became unstable: PDFBox-trunk » Apache PDFBox #1655

[Tilman Hausherr]

Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.022 sec <<< 
FAILURE! - in org.apache.pdfbox.pdmodel.interactive.form.TestFields
testFlags(org.apache.pdfbox.pdmodel.interactive.form.TestFields)  Time elapsed: 0.014 
sec  <<< ERROR!
java.lang.NullPointerException: null
at 
org.apache.pdfbox.service.interactive.form.PDAppearanceString.setAppearanceValue(PDAppearanceString.java:245)
at 
org.apache.pdfbox.service.interactive.form.AppearanceGenerator.generateFieldAppearances(AppearanceGenerator.java:75)
at 
org.apache.pdfbox.pdmodel.interactive.form.PDField.updateFieldAppearances(PDField.java:119)
at 
org.apache.pdfbox.pdmodel.interactive.form.PDTextField.setValue(PDTextField.java:282)
at 
org.apache.pdfbox.pdmodel.interactive.form.TestFields.testFlags(TestFields.java:123)

[jira] [Commented] (PDFBOX-2333) Overhaul the apperance generation for PDF forms

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273091#comment-14273091
 ] 

ASF subversion and git services commented on PDFBOX-2333:
-

Commit 1650989 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1650989 ]

PDFBOX-2333 adjust test to work on fields with appearance

> Overhaul the apperance generation for PDF forms
> ---
>
> Key: PDFBOX-2333
> URL: https://issues.apache.org/jira/browse/PDFBOX-2333
> Project: PDFBox
>  Issue Type: Improvement
>  Components: AcroForm
>Affects Versions: 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: AcroForms-SimpleTextFields.1.8.7.pdf, 
> AcroForms-SimpleTextFields.1.8.7.png, AcroForms-SimpleTextFields.pdf, 
> AlignmentTests-post1633495.pdf, AlignmentTests-pre1633495.pdf, 
> MultilineTests-prePatch.pdf
>
>
> The appearance handling for forms in 1.x is limited and does not reflect all 
> settings possible for form fields. In addition the current code is not very 
> modular and does not follow the box model used for form fields. 
> Unfortunately only the basics of form handling are defined in the PDF spec. 
> The details like padding of boxes, text placement etc. have to be determined 
> by looking at how Adobe forms are generated.
> Update: The file from PDFBOX-2310 has bad rendering which might be related?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to stable : PDFBox-trunk #1656

[Apache Jenkins Server]

See 

Jenkins build is back to stable : PDFBox-trunk » Apache PDFBox #1656

[Apache Jenkins Server]

See